Java User Group - Warnings clean-up hack day - 31st of Jan

Martijn Verburg martijnverburg at gmail.com
Tue Jan 31 03:21:13 PST 2012


Hi all,

Some corrections in-line (error between chair and keyboard ;p)

On 31 January 2012 10:01, Martijn Verburg <martijnverburg at gmail.com> wrote:
>> I've added an awk script to the main Warnings Cleanup page [2] that does
>> some analysis of warnings from a build log. I used this script to keep track
>> of the warnings counts as the cleanup fixes were integrated. This script
>> breaks down the warnings by "build step", that is, a run of javac from a
>> particular Makefile in a jdk/make subdirectory. It might be effective to use
>> the report from this script to target a build step with relatively few
>> warnings and to get it all the way to zero. When this occurs, -Werror can be
>> added to its Makefile to prevent warnings from being reintroduced. Another
>> approach would be to find a build step with hundreds or thousands (!) of
>> warnings and then further break it down to file granularity.
>
> I ran this script over the latest build that I have
> (http://hg.openjdk.java.net/jdk8/tl/jdk).
> It's really useful but I think there might be a bug?  The complete
> output I got was:
>
> files warnings dir
>    2      0   make/java/java
>    1      0   make/java/java/reflect
>    1      0   make/java/java/reflect
>    1     34   make/java/awt
>    1      2   make/java/beans
>   10      0   make/java/invoke
>    1     10   make/javax/swing/plaf
>    1      0   make/sun/awt
>    1      0   make/sun/xawt
>    1      0   make/sun/tracing
>    2      0   make/com/sun/net/httpserver
>    2      0   make/com/sun/tracing
>    1      0   make/com/sun/tracing/dtrace
>    1      0   make/com/sun/tracing/dtrace
>
> But when analysing the build.log file by hand, I could see other large
> warning counts
> e.g. 77 warnings for democlasses/demo/jfc/Font2DTest/src
>
> Actually that perhaps makes sense as I assume the democlasses are excluded? If
> that's the case then http://hg.openjdk.java.net/jdk8/tl/jdk has only
> 46 warnings left,
> we might need to look at another branch to work on at that stage
> (recommendations
> welcome).

This was all lies!  I ran clean in the wrong directory.  Noting to see
here, move along folks :-)

Cheers,
Martijn


More information about the jdk8-dev mailing list