CFV: New jdk8 Reviewer: Vicente Romero

[Jonathan Gibbons]

On 08/29/2013 09:04 AM, Volker Simonis wrote:
> On Wed, Aug 28, 2013 at 11:54 PM, Jonathan Gibbons
> <jonathan.gibbons at oracle.com>  wrote:
>> >
>> >I hereby nominate Vicente Romero to jdk8 Reviewer.
>> >
>> >Vicente has been a contributor to OpenJDK since 2011, and since
>> >then, he has made a total of 78 contributions and participated in
>> >38 code reviews, for javac and other tools in the langtools repository.
> I don't want to be overly picky and by no means I want to reduce
> Vincentes merits or his eligibility to be a jdk8 reviewer.
>
> I just have a question regarding the whole process: how it can be that
> somebody who is 'only' a committer has already done 38 code reviews
> (for change '8013789: Compiler should emit bridges in interfaces' he
> was even the only reviewer)?
>
> It seems like the whole process of electing somebody to be a
> "reviewer" is pointless, if there are no checks that only "real
> reviewers" can actually review changes.
>
> Regards,
> Volker
>

We have encouraged Vicente to participate in the review process,
even though he is not an official Reviewer(TM).   Normally, we try
and make sure that there is always an official Reviewer involved
as well.   It was an error that he was the only reviewer on 8013789,
and that the system did not detect that.

-- Jon