Review request: JDK8 b89 source with GPL header errors
Dmitry Samersoff
dmitry.samersoff at oracle.com
Thu May 9 12:56:10 PDT 2013
Looks good for me.
-Dmitry
On 2013-05-09 23:45, David Katleman wrote:
>
> On 5/9/2013 12:09 PM, Dmitry Samersoff wrote:
>> David,
>>
>> test/java/lang/CharSequence/DefaultTest.java
>>
>> has a "Classpath exception" but shouldn't.
>
> Good catch.
>
> Scripts just check for correct format of the header, but not whether the
> file should have GPL or GPL+classpath.
>
> I've updated the webrev with a corrected GPL header
>
> http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.02
>
> The other 3 files are unchanged.
>
> Thanks
> Dave
> ,
> On 2013-05-09 22:38, David Katleman wrote:
>>> Below are corrections to GPL headers found in JDK8 b89:
>>>
>>> http://cr.openjdk.java.net/~katleman/8014289/webrev.jdk.01/
>>>
>>> Just 4 files this go around, all are simple punctuation changes, anyone
>>> can review.
>>>
>>> As a veteran of many such header reviews, reviewing the patch link at
>>> the top of the webrev is often easier than each individual file.
>>>
>>> Thanks
>>> Dave
>>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the source code.
More information about the jdk8-dev
mailing list