Review request: JDK8 b91 source with GPL header errors

Mike Duigou mike.duigou at oracle.com
Tue May 28 20:33:07 PDT 2013


On May 28 2013, at 18:45 , David Holmes wrote:

> On 29/05/2013 11:35 AM, David Katleman wrote:
>> Below are corrections to GPL headers found in JDK8 b91
>> 
>>     http://cr.openjdk.java.net/~katleman/8015525/webrev
>> 
>> All are punctuation issues, no code is involved, anyone can review.
>> 
>> As a veteran of many such header reviews, reviewing the patch link at
>> the top of the webrev is often easier than each individual file.
> 
> All good.
> 
> Will we never get to the end of this saga :(

Davids,

I have a partial solution and also the explanation for the missing commas in the lambda test files:

The templates in make/templates don't include a comma after the %YEARS% variable. Can we add one to the templates? These templates are what I have been using and telling others to use. Since I am guilty of pushing some of these without the comma I know, at least, those would have been prevented.

HTH,

Mike

> 
> Thanks,
> David
> 
>>         Thanks
>>                 Dave



More information about the jdk8-dev mailing list