patch in test/Makefile for running langtools tests on a WXP/Cygwin platform

Francis ANDRE francis.andre.kampbell at orange.fr
Fri Nov 1 02:25:40 PDT 2013


Hi

Following is an hg diff output for making the test/Makefile running the 
langtools/test on a WXP/Cygwin platform.


FrancisANDRE at idefix /cygdrive/z/JDK/jdk8
$ hg diff test/Makefile
diff --git a/test/Makefile b/test/Makefile
--- a/test/Makefile
+++ b/test/Makefile
@@ -57,7 +57,7 @@

  # Test targets
  langtools_% :
-       @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), 
JT_JAVA=$(PRODUCT_HOME) JTREG_HOME=$(JT
_HOME) TEST="$(subst langtools_,,$@)" $(subst langtools_,,$@))
+       @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), 
JT_JAVA=$(PRODUCT_HOME) TEST="$(subst l
angtools_,,$@)" $(subst langtools_,,$@))

  jdk_% :
         @$(NO_STOPPING)$(call SUBDIR_TEST, $(JDK_DIR), TEST="$@" $@)



In the langtools/test, there is already a computation of the JTREG_HOME from 
these lines

# Default JTREG to run
ifdef JPRT_JTREG_HOME
   JTREG_HOME = $(JPRT_JTREG_HOME)
else
   JTREG_HOME = $(SLASH_JAVA)/re/jtreg/4.1/promoted/latest/binaries/jtreg
endif


Thus, setting JTREG_HOME= as a variable of the launching make precludes the 
previous computation if JT_HOME is not defined. This produces the following errors

/cygdrive/c/cygwin/usr/local/bin/make -k -C  ../langtools/test 
JT_JAVA=/cygdrive/Z/JDK/jdk8/build/windows-x86-normal-server-release/images/j2sdk-image 
JTREG_HOME= TEST=jtreg jtreg
make[2]: Entering directory `/cygdrive/Z/JDK/jdk8/langtools/test'
_make[2]: *** No rule to make target `/win32/bin/jtreg', needed by `check-jtreg'._
if [ -r Z:/JDK/jdk8/LANGTO~1/build/WINDOW~1/test/LANGTO~1/jtreg/status.txt ]; then \
     echo ; echo "Summary of jtreg test failures" ; \
     cat 
Z:/JDK/jdk8/LANGTO~1/build/WINDOW~1/test/LANGTO~1/jtreg/JTreport/text/summary.txt | 
\
     grep -v 'Not run' | grep -v 'Passed' ; \
     echo ; \
     exit `cat 
Z:/JDK/jdk8/LANGTO~1/build/WINDOW~1/test/LANGTO~1/jtreg/status.txt` ; \
fi
make[2]: Target `jtreg' not remade because of errors.

Francis


More information about the jdk8-dev mailing list