patch in test/Makefile for running langtools tests on a WXP/Cygwin platform

[Mike Duigou]

On Nov 1 2013, at 02:25 , Francis ANDRE <francis.andre.kampbell at orange.fr> wrote:

> Hi
> 
> Following is an hg diff output for making the test/Makefile running the langtools/test on a WXP/Cygwin platform.
> 
> 
> FrancisANDRE at idefix /cygdrive/z/JDK/jdk8
> $ hg diff test/Makefile
> diff --git a/test/Makefile b/test/Makefile
> --- a/test/Makefile
> +++ b/test/Makefile
> @@ -57,7 +57,7 @@
> 
> # Test targets
> langtools_% :
> -       @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), JT_JAVA=$(PRODUCT_HOME) JTREG_HOME=$(JT
> _HOME) TEST="$(subst langtools_,,$@)" $(subst langtools_,,$@))
> +       @$(NO_STOPPING)$(call SUBDIR_TEST, $(LANGTOOLS_DIR), JT_JAVA=$(PRODUCT_HOME) TEST="$(subst l
> angtools_,,$@)" $(subst langtools_,,$@))
> 
> jdk_% :
>        @$(NO_STOPPING)$(call SUBDIR_TEST, $(JDK_DIR), TEST="$@" $@)
> 

This is better fixed by adding --with-jtreg option to your configure.


> In the langtools/test, there is already a computation of the JTREG_HOME from these lines
> 
> # Default JTREG to run
> ifdef JPRT_JTREG_HOME
>  JTREG_HOME = $(JPRT_JTREG_HOME)
> else
>  JTREG_HOME = $(SLASH_JAVA)/re/jtreg/4.1/promoted/latest/binaries/jtreg
> endif
> 
> 
> Thus, setting JTREG_HOME= as a variable of the launching make precludes the previous computation if JT_HOME is not defined. This produces the following errors

This code exists for backwards compatibility and will eventually be removed. Providing configure with JT_HOME or --with-jtreg is the more reliable option.

Mike