webrev.ksh on Ubuntu 12.04

Dave Pointon dpointo8 at linux.vnet.ibm.com
Thu Nov 14 05:42:18 PST 2013


Hiya Volker ,

I have latest webrev.ksh with 2.7.2 as delivered via update deb i.e. not
self-built.

Even better than using print, using ksh -x make/scripts/webrev.ksh
reveals the following ...

.
.
hg path
+ 2> /dev/null
+ cat
+ tmp='default =
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head'
+ [[ -n 'default =
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head' ]]
+ OUTPWS='default =
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head'
+ OUTPWS2='default =
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head'
+ [[ -n 'default =
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head' ]]
+ expr 'default =
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head' : '.*://[^/]*@.*'
+ [[ 0 -gt 0 ]]
+ [[ -z '' ]]
+ hg branch
+ HG_BRANCH=default
+ [ default '==' default ]
+ HG_BRANCH=''
+ [[ -z '' ]]
+ [[ -z '' ]]
+ hg outgoing -q --template '{rev}\n' default '='
ssh://jtc-hg.hursley.ibm.com//home/hg/jtchg-ibm-adm/composite/80/jcl/head
+ sort -n
hg outgoing: invalid arguments
+ ALL_CREV=$'\n\nhg outgoing [-M] [-p] [-n] [-f] [-r REV]...
[DEST]\nshow changesets not found in the destination\nuse "hg help
outgoing" to show the full help text'
+ [[ -n $'\n\nhg outgoing [-M] [-p] [-n] [-f] [-r REV]... [DEST]\nshow
changesets not found in the destination\nuse "hg help outgoing" to show
the full help text' ]]
+ echo $'\n\nhg outgoing [-M] [-p] [-n] [-f] [-r REV]... [DEST]\nshow
changesets not found in the destination\nuse "hg help outgoing" to show
the full help text'
+ head -1
+ FIRST_CREV=''
+ [[ -z '' ]]
+ find_outrev ''
hg: parse error: can't negate that
expr: syntax error
.
.

As you can see, the prefix isn't stripped off before being passed on to
the hg outgoing command - hence my posited 'fix', if it is actually a
defect.

Rgds ,

On Thu, 2013-11-14 at 13:54 +0100, Volker Simonis wrote:
> That's strange.
> 
> I'm using the latest webrev.ksh from jdk8/make/scripts/webrev.ksh with
> Mercurial 2.0.2 (which I tihnk is the default on Ubuntu 12.04) on
> Ubuntu 12.04 without any problems. My .hg/hgrc files look as follows:
> 
> [paths]
> default = http://hg.openjdk.java.net/ppc-aix-port/stage/jdk
> 
> Did you compile/install Mercurial V2.7.2 yourself? Maybe you could try
> with the default Ubuntu Mercurial package?
> 
> You could also try to hack the webrev.ksh script to print what's going
> wrong. You could just print the arguments for the line:
> 
>            ALL_CREV=`hg outgoing -q --template '{rev}\n' $OUTPWS | sort -n`
> 
> which seems to cause problems on your site. Maybe Anthony is right and
> your OUTPWS is somehow miss-detected.
> 
> Regards,
> Volker
<snip>

-- 
Dave Pointon FIAP MBCS

Now I saw, tho' too late, the folly of beginning a work before we count
the cost and before we we judge rightly of our strength to go thro' with
it - Robinson Crusoe



More information about the jdk8-dev mailing list