From joel.franck at oracle.com Mon Sep 2 01:39:32 2013 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Mon, 2 Sep 2013 10:39:32 +0200 Subject: CFV: New jdk8 Committer: Jan Lahoda In-Reply-To: <521E718E.1090800@oracle.com> References: <521E718E.1090800@oracle.com> Message-ID: <8243F7E2-8BA8-492B-A233-41C4C1824DCC@oracle.com> Vote: yes cheers /Joel On 28 aug 2013, at 23:54, Jonathan Gibbons wrote: > I hereby nominate Jan Lahoda to jdk8 Committer. > > Jan is very familiar with the javac codebase as a result of his work on the NetBeans Java editor, and since 2010, he has been making contributions back to the OpenJDK langtools repository. He has a total of 18 contributions of his own and has worked on an additional 3. His OpenJDK activity is given below. > > Votes are due by 5 p.m. PDT, September 11. > > Only current jdk 8 Committers [1] are eligible to vote on > this nomination. Votes must be cast in the open by replying to > to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -- Jonathan Gibbons > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > > -------------------- > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f657d400c736 > user: jlahoda > 8022508: javac crashes if the generics arity of a base class is wrong > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ec77c7b46c37 > user: jlahoda > 8015809: More user friendly compile-time errors for uncaught exceptions in lambda expression > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d601238641e6 > 8022161: javac Null Pointer Exception in Enter.visitTopLevel > Reviewed-by: jjg, vromero, jlahoda > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/cd9e8cea1b3c > user: jlahoda > 8021338: Diamond finder may mark a required type argument as unnecessary > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8c4b2987edac > user: jlahoda > 8020689: Missing LineNumberTable entries in compiled class files > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/10711bd8bb2d > user: jlahoda > 8020586: Warning produced for an incorrect file > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8dd528992c15 > user: jlahoda > 8012929: Trees.getElement should work not only for declaration trees, but also for use-trees > Contributed-by: Dusan Balek , Jan Lahoda > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/a7ff36d06fa2 > user: jlahoda > 8009724: Enhance the DocTree API with DocTreePath > Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/ed918a442b83 > user: jlahoda > 8008174: DocTree API should provide start and end positions for tree nodes > Contributed-by: Ralph Benjamin Ruijs , Jan Lahoda > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/170e486632d9 > user: jlahoda > 8004504: ListBuffer could reuse List.nil() as the sentinel element > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/20e4a54b1629 > 7198582: (java) Minor refactor of JavacParser > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fabfd2710057 > 7192073: (javac) minor refactoring of tree maker to help IDEs > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c9749226cdde > 7192068: (javac) provide a way for IDEs to produce Enclosing Method attributes. > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/833bab705918 > 7159445: (javac) emits inaccurate diagnostics for enhanced for-loops > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/d10db3576c08 > 7166010: (javac) JavacMessager incorrectly restores log source file > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9c429f38ca7e > 7156633: (javac) incorrect errors when parsing variable declaration in block statements. > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/84b61130cbed > 7142086: performance problem in Check.checkOverrideClashes(...) > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/9350d0498d21 > 7119032: (javac) increase visibility of JavacParser methods to improve subtyping > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/04f983e3e825 > 7073631: (javac) javac parser improvements for error position reporting > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/74f0c05c51eb > 7024568: Very long method resolution causing OOM error > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/abaceae7c9f8 > 7000973: isBogus needs to be called on the to-be-returned entry, not on the current entry > Contributed-by: jan.lahoda at oracle.com > > Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b29160d1b3e0 > 6972327: JCTree.pos incorrect for annotations without modifiers and package > Contributed-by: jan.lahoda at sun.com > > Summary: > Earliest: Tue Jul 27 11:32:03 PDT 2010 > Commits: 6 > Contributions: 12 > Partial contributions: 3 > Reviews: 1 From alejandro.murillo at oracle.com Tue Sep 3 14:31:25 2013 From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com) Date: Tue, 03 Sep 2013 21:31:25 +0000 Subject: hg: jdk8/jdk8/hotspot: 33 new changesets Message-ID: <20130903213231.3796D624E8@hg.openjdk.java.net> Changeset: 73921c720b94 Author: amurillo Date: 2013-08-23 03:14 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/73921c720b94 8023635: new hotspot build - hs25-b48 Reviewed-by: jcoomes ! make/hotspot_version Changeset: c6ec0a97b30a Author: sla Date: 2013-08-21 13:18 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c6ec0a97b30a 8022808: Kitchensink hangs on macos Summary: Use pthread_mach_thread_np() instead of mach_thread_self() to avoid leaking resources Reviewed-by: dholmes, rbackman ! src/os/bsd/vm/os_bsd.cpp Changeset: 3a57fa7a4cd0 Author: hseigel Date: 2013-08-22 11:52 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3a57fa7a4cd0 7121403: [TESTBUG] runtime/7051189/Xchecksig.sh fails on 64bit solaris 8023393: Need to suppress info message if -Xcheck:jni used with libjsig.dylab on Mac OSX Summary: Rewrite 7051189 test in Java, port Linux fix for 7051189 to Mac OSX. Reviewed-by: coleenp, dholmes, mseledtsov, ccheung ! src/os/bsd/vm/os_bsd.cpp - test/runtime/7051189/Xchecksig.sh + test/runtime/XCheckJniJsig/XCheckJSig.java Changeset: e37ab280bbce Author: allwin Date: 2013-07-23 14:32 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e37ab280bbce 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__" Reviewed-by: sla, sundar, kmo Contributed-by: yunda.mly at taobao.com ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js Changeset: 669d9a235486 Author: sla Date: 2013-08-22 14:56 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/669d9a235486 Merge Changeset: c062a6e1fa33 Author: iklam Date: 2013-08-22 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c062a6e1fa33 8023406: make/windows/build_vm_def.sh takes too long even when BUILD_WIN_SA != 1 Summary: Avoid dumping C++ vtable when BUILD_WIN_SA != 1 Reviewed-by: dcubed, sla, tbell ! make/windows/build_vm_def.sh ! make/windows/makefiles/debug.make ! make/windows/makefiles/fastdebug.make ! make/windows/makefiles/product.make ! make/windows/makefiles/projectcreator.make ! make/windows/makefiles/vm.make Changeset: 811aea34d5e7 Author: iklam Date: 2013-08-22 13:53 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/811aea34d5e7 Merge Changeset: ff2520b97b00 Author: jiangli Date: 2013-08-22 19:27 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ff2520b97b00 8023547: com/sun/jdi/RedefineMulti.sh fails with IllegalArgumentException after JDK-8021948 . Summary: Need to check if the constant pool mapping returns 0. Reviewed-by: coleenp, sspitsyn ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 887db75613f8 Author: jiangli Date: 2013-08-22 17:21 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/887db75613f8 Merge Changeset: a70566600baf Author: poonam Date: 2013-08-21 22:12 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a70566600baf 8020530: Non heap memory size calculated incorrectly Reviewed-by: coleenp, sla Contributed-by: vladimir.kempik at oracle.com ! src/share/vm/services/management.cpp Changeset: 730210728146 Author: poonam Date: 2013-08-22 18:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/730210728146 Merge - test/runtime/7051189/Xchecksig.sh Changeset: 817e46dd5864 Author: poonam Date: 2013-08-22 21:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/817e46dd5864 Merge Changeset: 739c309fd729 Author: mgronlun Date: 2013-08-23 10:36 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/739c309fd729 8023457: Event based tracing framework needs a mutex for thread groups Reviewed-by: acorn, sla ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp Changeset: cacc421f39d7 Author: dcubed Date: 2013-08-23 10:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/cacc421f39d7 Merge - test/runtime/7051189/Xchecksig.sh Changeset: badf4244ceae Author: hseigel Date: 2013-08-25 21:21 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/badf4244ceae 8022183: GCC 4.6 change sdefault setting for omit-frame-pointer which breaks hotspot stack walking Summary: Explicitly specify -fno-omit-frame-pointer. Reviewed-by: coleenp, dholmes, dcubed ! make/linux/makefiles/amd64.make ! make/linux/makefiles/gcc.make Changeset: faf2631b9334 Author: dsimms Date: 2013-08-26 09:33 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/faf2631b9334 8022683: JNI GetStringUTFChars should return NULL on allocation failure not abort the VM Summary: Return NULL on OOM from GetStringChars, GetStringUTFChars and GetArrayElements family of functions. Reviewed-by: dholmes, coleenp ! src/share/vm/memory/allocation.hpp ! src/share/vm/prims/jni.cpp Changeset: 4c84d351cca9 Author: stefank Date: 2013-08-16 13:22 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/4c84d351cca9 8007074: SIGSEGV at ParMarkBitMap::verify_clear() Summary: Replace the broken large pages implementation on Linux. New flag: -XX:+UseTransparentHugePages - Linux specific flag to turn on transparent huge page hinting with madvise(..., MAP_HUGETLB). Changed behavior: -XX:+UseLargePages - tries to use -XX:+UseTransparentHugePages before trying other large pages implementations (on Linux). Changed behavior: -XX:+UseHugeTLBFS - Use upfront allocation of Large Pages instead of using the broken implementation to dynamically committing large pages. Changed behavior: -XX:LargePageSizeInBytes - Turned off the ability to use this flag on Linux and provides warning to user if set to a value different than the OS chosen large page size. Changed behavior: Setting no large page size - Now defaults to use -XX:UseTransparentHugePages if the OS supports it. Previously, -XX:+UseHugeTLBFS was chosen if the OS was configured to use large pages. Reviewed-by: tschatzl, dcubed, brutisso ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/globals_linux.hpp ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp ! src/share/vm/services/memTracker.hpp ! src/share/vm/utilities/globalDefinitions.hpp Changeset: 21ffbaa691b5 Author: stefank Date: 2013-08-26 07:01 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/21ffbaa691b5 Merge ! src/share/vm/prims/jni.cpp Changeset: 1bb10d3170fa Author: jmasa Date: 2013-08-16 06:12 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1bb10d3170fa 8022817: CMS should not shrink if compaction was not done Reviewed-by: ysr, mgerdin ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp Changeset: f7d3b4387a16 Author: brutisso Date: 2013-08-21 22:35 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f7d3b4387a16 8022872: G1: Use correct GC cause for young GC triggered by humongous allocations Reviewed-by: tonyp, tschatzl ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c31eb8c86a50 Author: brutisso Date: 2013-08-22 04:14 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c31eb8c86a50 Merge Changeset: ec145d04eda8 Author: jmasa Date: 2013-08-23 15:59 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ec145d04eda8 Merge Changeset: 1624a68007bd Author: jmasa Date: 2013-08-27 18:55 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1624a68007bd Merge ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: f92b82d454fa Author: bpittore Date: 2013-08-23 20:33 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f92b82d454fa 8014135: The JVMTI specification does not conform to recent changes in JNI specification Summary: Added support for statically linked agents Reviewed-by: sspitsyn, bobv, coleenp ! src/os/posix/vm/os_posix.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/prims/jvmti.xml ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp Changeset: 5fd8e2fbafd4 Author: cjplummer Date: 2013-08-23 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5fd8e2fbafd4 8020829: JT_HS: 2 runtime NMT tests fail on platforms if NMT detail is not supported Summary: Make tests query a new WhiteBox API to see if NMT detail is supported, and behave properly if it is not supported. Reviewed-by: dholmes, coleenp ! src/share/vm/prims/whitebox.cpp ! test/runtime/NMT/ThreadedVirtualAllocTestType.java ! test/runtime/NMT/VirtualAllocTestType.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: 7aa0c1fb6fdb Author: dholmes Date: 2013-08-27 22:05 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7aa0c1fb6fdb 8006164: [TESTBUG] compact profile hotspot test issues Summary: Define profile-based test groups. Reviewed-by: dcubed, mchung ! test/TEST.ROOT + test/TEST.groups Changeset: 1fedf3c7f923 Author: bpittore Date: 2013-08-28 14:44 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1fedf3c7f923 8023580: Add jtreg test for 8004051 and 8005722 Summary: Tests checks an assertion dealing with the number of args passed in registers Reviewed-by: mseledtsov, kvn + test/compiler/8004051/Test8004051.java Changeset: b1fb293d92c4 Author: jiangli Date: 2013-08-28 12:01 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b1fb293d92c4 Merge Changeset: 2b113b65a051 Author: dholmes Date: 2013-08-28 19:25 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2b113b65a051 8023900: [TESTBUG] Initial compact profile test groups need adjusting Reviewed-by: dcubed, mchung, hseigel ! test/TEST.groups Changeset: 54dfd798deaf Author: dholmes Date: 2013-08-28 21:42 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/54dfd798deaf Merge Changeset: 62f527c674d2 Author: dholmes Date: 2013-08-29 00:22 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/62f527c674d2 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.hpp Changeset: 18b4798adbc4 Author: amurillo Date: 2013-08-30 00:19 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/18b4798adbc4 Merge - test/runtime/7051189/Xchecksig.sh Changeset: aed585cafc0d Author: amurillo Date: 2013-08-30 00:19 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/aed585cafc0d Added tag hs25-b48 for changeset 18b4798adbc4 ! .hgtags From alejandro.murillo at oracle.com Tue Sep 3 15:00:34 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 03 Sep 2013 16:00:34 -0600 Subject: jdk8-b106: HotSpot Message-ID: <52265C02.5030903@oracle.com> hs25-b48 has been integrated into jdk8-b106. http://hg.openjdk.java.net/jdk8/jdk8/rev/4ac867c44467 http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/2e3a056c84a7 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/aed585cafc0d http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/d3be8e3b429d http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/6908370afe83 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c817276bd870 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/fcd768844b99 http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/bf70cbd2c836 Component : VM Status : 0 major failures, 0 minor failures Date : 09/03/2013 at 21:57 Tested By : VM SQE &leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : 2013-08-30-072135.amurillo.hs25-b48-snapshot Bundles : 2013-08-30-072135.amurillo.hs25-b48-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs : none Number of Tests Executed : 0 product tests, 0 unit tests, 0 tck tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 7121403: [TESTBUG] runtime/7051189/Xchecksig.sh fails on 64bit solaris 8006164: [TESTBUG] compact profile hotspot test issues 8007074: SIGSEGV at ParMarkBitMap::verify_clear() 8011888: sa.js: TypeError: [object JSAdapter] has no such function "__has__" 8014135: The JVMTI specification does not conform to recent changes in JNI specification 8020530: Non heap memory size calculated incorrectly 8020829: JT_HS: 2 runtime NMT tests fail on platforms if NMT detail is not supported 8022183: GCC 4.6 change sdefault setting for omit-frame-pointer which breaks hotspot stack walking 8022683: JNI GetStringUTFChars should return NULL on allocation failure not abort the VM 8022808: Kitchensink hangs on macos 8022817: CMS should not shrink if compaction was not done 8022872: G1: Use correct GC cause for young GC triggered by humongous allocations 8023393: Need to suppress info message if -Xcheck:jni used with libjsig.dylab on Mac OSX 8023406: make/windows/build_vm_def.sh takes too long even when BUILD_WIN_SA != 1 8023457: Event based tracing framework needs a mutex for thread groups 8023547: com/sun/jdi/RedefineMulti.sh fails with IllegalArgumentException after JDK-8021948 . 8023580: Add jtreg test for 8004051 and 8005722 8023635: new hotspot build - hs25-b48 8023900: [TESTBUG] Initial compact profile test groups need adjusting Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b106. Issues and Notes: This is PIT for HS25 b48 for JDK 8 b106. -- Alejandro From joe.darcy at oracle.com Tue Sep 3 18:40:43 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Tue, 03 Sep 2013 18:40:43 -0700 Subject: Turning on javac lint warnings when building Java sources in jdk 8 repo Message-ID: <52268F9B.8010203@oracle.com> Hello, Over the last few months, over on core-libs-dev there have been various clean up efforts concerning the Java code in the JDK 8 "jdk" repo, resolving both javac lint and doclint warnings. With these clean ups in place, I think it is time for selected categories of javac lint warnings to be enabled during the build under -Werror. That is, for lint categories that have been scrubbed, the build should be reconfigured so that reintroducing such a warning is a build error. (Under the old build, different packages could use different javac command line options. With the new build, all the Java code is compiled under the same options so the full build was reduced to the least restrictive javac lint setting.) As additional warning categories are resolved, the set of enabled lint categories could be expanded, potentially including doclint categories too. Cheers, -Joe [1] http://mail.openjdk.java.net/pipermail/build-dev/2013-August/009806.html From stuart.marks at oracle.com Wed Sep 4 14:09:03 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 04 Sep 2013 14:09:03 -0700 Subject: Turning on javac lint warnings when building Java sources in jdk 8 repo In-Reply-To: <52268F9B.8010203@oracle.com> References: <52268F9B.8010203@oracle.com> Message-ID: <5227A16F.2070108@oracle.com> Hi Joe, As you might imagine, I'm all for it. Which specific warnings categories do you envision enabling? Some work in the makefiles is probably necessary provide default settings for warnings/errors and to make the settings easily overridable from the command line. The current variable that controls this is DISABLE_WARNINGS (see jdk/makefiles/Setup.gmk) which is probably a misnomer. (But the specifics of makefile changes probably ought to be discussed on build-dev.) s'marks On 9/3/13 6:40 PM, Joe Darcy wrote: > Hello, > > Over the last few months, over on core-libs-dev there have been various > clean up efforts concerning the Java code in the JDK 8 "jdk" repo, > resolving both javac lint and doclint warnings. > > With these clean ups in place, I think it is time for selected > categories of javac lint warnings to be enabled during the build under > -Werror. That is, for lint categories that have been scrubbed, the build > should be reconfigured so that reintroducing such a warning is a build > error. (Under the old build, different packages could use different > javac command line options. With the new build, all the Java code is > compiled under the same options so the full build was reduced to the > least restrictive javac lint setting.) > > As additional warning categories are resolved, the set of enabled lint > categories could be expanded, potentially including doclint categories too. > > Cheers, > > -Joe > > [1] > http://mail.openjdk.java.net/pipermail/build-dev/2013-August/009806.html From david.katleman at oracle.com Wed Sep 4 14:18:30 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 04 Sep 2013 21:18:30 +0000 Subject: hg: jdk8/jdk8: 5 new changesets Message-ID: <20130904211831.63C5C62579@hg.openjdk.java.net> Changeset: 21198f51bc7e Author: erikj Date: 2013-08-29 15:47 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/21198f51bc7e 8003162: build-infra: Improve suggestions for missing packages on linux Reviewed-by: tbell, omajid ! common/autoconf/generated-configure.sh ! common/autoconf/help.m4 ! common/autoconf/libraries.m4 Changeset: 92facce22941 Author: erikj Date: 2013-08-30 10:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/92facce22941 8023957: Lock down version of autoconf Reviewed-by: chegar, dsamersoff, tbell, dholmes ! README-builds.html ! common/autoconf/autogen.sh ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh Changeset: 2aacc7080d36 Author: katleman Date: 2013-09-03 13:48 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/2aacc7080d36 Merge Changeset: 0f6dde6231bd Author: ihse Date: 2013-09-04 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/0f6dde6231bd 8024155: Fix 'make CONF= ' Reviewed-by: erikj, tbell ! NewMakefile.gmk ! common/makefiles/Main.gmk Changeset: 8e7b4d9fb00f Author: erikj Date: 2013-09-04 10:37 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/8e7b4d9fb00f Merge ! NewMakefile.gmk ! common/makefiles/Main.gmk From stuart.marks at oracle.com Wed Sep 4 14:38:18 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Wed, 04 Sep 2013 14:38:18 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) Message-ID: <5227A84A.3050406@oracle.com> I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. Attila's changesets (in the jdk8/tl/nashorn repo): hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" This currently shows 115 reviews. Votes are due by 2359 PDT, September 18, 2013. Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. s'marks [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From mike.duigou at oracle.com Wed Sep 4 14:54:19 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Wed, 4 Sep 2013 14:54:19 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5C52DFD5-3E00-41EC-BB0C-80AD37DC268B@oracle.com> Vote: YES On Sep 4 2013, at 14:38 , Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From Abhi.Saha at Oracle.COM Wed Sep 4 15:17:12 2013 From: Abhi.Saha at Oracle.COM (Abhijit Saha (Oracle)) Date: Wed, 04 Sep 2013 15:17:12 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5227B168.4030704@Oracle.COM> Vote: yes On 9/4/2013 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, > general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > -- Lead, Java SE Updates Java Platform Group Oracle Corporation. (408)276-7564 From joe.darcy at oracle.com Wed Sep 4 15:21:15 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 04 Sep 2013 15:21:15 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5227B25B.2090403@oracle.com> Vote: yes -Joe On 9/4/2013 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, > general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From john.r.rose at oracle.com Wed Sep 4 15:30:23 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 4 Sep 2013 15:30:23 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: Vote: yes From jonathan.gibbons at oracle.com Wed Sep 4 15:30:35 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 04 Sep 2013 15:30:35 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5227B48B.40903@oracle.com> Vote: yes On 09/04/2013 02:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, > general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From henry.jen at oracle.com Wed Sep 4 15:35:15 2013 From: henry.jen at oracle.com (Henry Jen) Date: Wed, 4 Sep 2013 15:35:15 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <59F695C4-49A8-4937-8265-929F41A4C602@oracle.com> Vote: YES Cheers, Henry On Sep 4, 2013, at 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From james.laskey at oracle.com Wed Sep 4 16:06:05 2013 From: james.laskey at oracle.com (Jim Laskey (Oracle)) Date: Wed, 4 Sep 2013 20:06:05 -0300 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: Vote: Yes On 2013-09-04, at 6:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From david.katleman at oracle.com Wed Sep 4 16:15:48 2013 From: david.katleman at oracle.com (David Katleman) Date: Wed, 04 Sep 2013 16:15:48 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5227BF24.5010003@oracle.com> Vote: yes On 9/4/2013 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, > general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From mark.reinhold at oracle.com Wed Sep 4 16:18:56 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 04 Sep 2013 16:18:56 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <20130904161856.566134@eggemoggin.niobe.net> Vote: yes - Mark From joe.darcy at oracle.com Wed Sep 4 18:41:55 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Wed, 04 Sep 2013 18:41:55 -0700 Subject: Turning on javac lint warnings when building Java sources in jdk 8 repo In-Reply-To: <5227A16F.2070108@oracle.com> References: <52268F9B.8010203@oracle.com> <5227A16F.2070108@oracle.com> Message-ID: <5227E163.2050906@oracle.com> Hi Stuart, On 9/4/2013 2:09 PM, Stuart Marks wrote: > Hi Joe, > > As you might imagine, I'm all for it. Which specific warnings > categories do you envision enabling? What worked (as of about two weeks ago) was a javac lint setting of -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfile,dep-ann,divzero,empty,try,varargs -Werror The corelibs area is clean on a larger set of values than client; for example, the core area is clean on "cast" and "static" too. > > Some work in the makefiles is probably necessary provide default > settings for warnings/errors and to make the settings easily > overridable from the command line. The current variable that controls > this is DISABLE_WARNINGS (see jdk/makefiles/Setup.gmk) which is > probably a misnomer. (But the specifics of makefile changes probably > ought to be discussed on build-dev.) FWIW, the patch I had out for review renamed "DISABLE_WARNINGS" to "JAVAC_WARNINGS". Cheers, -Joe > > s'marks > > > On 9/3/13 6:40 PM, Joe Darcy wrote: >> Hello, >> >> Over the last few months, over on core-libs-dev there have been various >> clean up efforts concerning the Java code in the JDK 8 "jdk" repo, >> resolving both javac lint and doclint warnings. >> >> With these clean ups in place, I think it is time for selected >> categories of javac lint warnings to be enabled during the build under >> -Werror. That is, for lint categories that have been scrubbed, the build >> should be reconfigured so that reintroducing such a warning is a build >> error. (Under the old build, different packages could use different >> javac command line options. With the new build, all the Java code is >> compiled under the same options so the full build was reduced to the >> least restrictive javac lint setting.) >> >> As additional warning categories are resolved, the set of enabled lint >> categories could be expanded, potentially including doclint >> categories too. >> >> Cheers, >> >> -Joe >> >> [1] >> http://mail.openjdk.java.net/pipermail/build-dev/2013-August/009806.html From john.r.rose at oracle.com Wed Sep 4 18:49:57 2013 From: john.r.rose at oracle.com (John Rose) Date: Wed, 4 Sep 2013 18:49:57 -0700 Subject: Turning on javac lint warnings when building Java sources in jdk 8 repo In-Reply-To: <52268F9B.8010203@oracle.com> References: <52268F9B.8010203@oracle.com> Message-ID: +1 As new warnings are introduced it is a moving target. But it is a very good target. -- John (on my iPhone) On Sep 3, 2013, at 6:40 PM, Joe Darcy wrote: > I think it is time for selected categories of javac lint warnings to be enabled during the build under -Werror. From sundararajan.athijegannathan at oracle.com Wed Sep 4 20:00:46 2013 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 05 Sep 2013 08:30:46 +0530 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: References: <5227A84A.3050406@oracle.com> Message-ID: <5227F3DE.3080202@oracle.com> Vote: Yes On Thursday 05 September 2013 04:36 AM, Jim Laskey (Oracle) wrote: > Vote: Yes > > On 2013-09-04, at 6:38 PM, Stuart Marks wrote: > >> I hereby nominate Attila Szegedi to JDK 8 Committer. >> >> Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. >> >> Attila's changesets (in the jdk8/tl/nashorn repo): >> >> hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " >> >> This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): >> >> hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" >> >> This currently shows 115 reviews. >> >> Votes are due by 2359 PDT, September 18, 2013. >> >> Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. >> >> For Lazy Consensus voting instructions, see [2]. >> >> s'marks >> >> [1] http://openjdk.java.net/census >> [2] http://openjdk.java.net/projects/#committer-vote >> From marcus.lagergren at oracle.com Wed Sep 4 22:23:23 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 5 Sep 2013 07:23:23 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: Yes. /M On Sep 4, 2013, at 11:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From staffan.larsen at oracle.com Wed Sep 4 23:07:47 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 5 Sep 2013 08:07:47 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: Vote: yes. On 4 sep 2013, at 23:38, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From staffan.larsen at oracle.com Wed Sep 4 23:16:28 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 5 Sep 2013 08:16:28 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin Message-ID: I hereby nominate Erik Gahlin to JDK 8 Committer. Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace 6417649: -interval=0 is accepted and jconsole doesn't update window content at all 7042707: Un-needed mnemonic in JConsole resource file 6800801: NPE in JConsole when using Nimbus L&F 6417721: Thread list should not allow multiple selection 6358357: Division by zero in Threads tab when shrinking jconsole window 6696970: Jconsole becomes unusable if a plugin throws an exception 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation 6721425: jconsole Makefile clean rule is missing rm of generated Version.java 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box 8008611: Better handling of annotations in JMX 7017818: NLS: JConsoleResources.java cannot be handled by translation team 8005008: Add Java Flight Recorder Phase II 7132386: makefile support for tracing/Java Flight Recorder framework phase I Votes are due by 2013-09-19. Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. Staffan Larsen [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From jaroslav.bachorik at oracle.com Wed Sep 4 23:20:28 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 05 Sep 2013 08:20:28 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <522822AC.3000607@oracle.com> Vote: yes -JB- On 09/04/2013 11:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, general > performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From marcus.lagergren at oracle.com Wed Sep 4 23:35:01 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 5 Sep 2013 08:35:01 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <1D2E0107-27F4-4814-90DB-84A08E12878B@oracle.com> Vote: Yes /M On Sep 5, 2013, at 8:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From shanliang.jiang at oracle.com Wed Sep 4 23:47:50 2013 From: shanliang.jiang at oracle.com (shanliang) Date: Thu, 05 Sep 2013 08:47:50 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <52282916.3040700@oracle.com> Yes. Shanliang Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From jaroslav.bachorik at oracle.com Wed Sep 4 23:58:38 2013 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Thu, 05 Sep 2013 08:58:38 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <52282B9E.8070901@oracle.com> Vote: yes -JB- On 09/05/2013 08:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From Alan.Bateman at oracle.com Thu Sep 5 00:04:21 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Thu, 05 Sep 2013 08:04:21 +0100 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <52282CF5.8020402@oracle.com> Vote: yes -Alan. From daniel.fuchs at oracle.com Thu Sep 5 01:29:51 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Thu, 05 Sep 2013 10:29:51 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <522840FF.6030000@oracle.com> Vote: yes -- daniel On 9/5/13 8:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > From vicente.romero at oracle.com Thu Sep 5 01:53:29 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 05 Sep 2013 09:53:29 +0100 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227B48B.40903@oracle.com> References: <5227A84A.3050406@oracle.com> <5227B48B.40903@oracle.com> Message-ID: <52284689.6000202@oracle.com> Vote: yes > On 09/04/2013 02:38 PM, Stuart Marks wrote: >> I hereby nominate Attila Szegedi to JDK 8 Committer. >> >> Attila is a Reviewer on the Nashorn project. In addition to regularly >> reviewing other committers' work, he is actively developing Nashorn >> on daily basis and has contributed many changesets related to areas >> of Nashorn's parser and compiler, invokedynamic linking, security, >> general performance optimizations, and more. >> >> Attila's changesets (in the jdk8/tl/nashorn repo): >> >> hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " >> >> This currently shows 73 changesets. Attila's reviews (also >> jdk8/tl/nashorn): >> >> hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" >> >> This currently shows 115 reviews. >> >> Votes are due by 2359 PDT, September 18, 2013. >> >> Only current JDK 8 Committers [1] are eligible to vote on this >> nomination. Votes must be cast in the open by replying to this >> mailing list. >> >> For Lazy Consensus voting instructions, see [2]. >> >> s'marks >> >> [1] http://openjdk.java.net/census >> [2] http://openjdk.java.net/projects/#committer-vote >> > From frederic.parain at oracle.com Thu Sep 5 02:20:09 2013 From: frederic.parain at oracle.com (Frederic Parain) Date: Thu, 05 Sep 2013 11:20:09 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <52284CC9.9070400@oracle.com> Vote: yes Fred On 09/05/2013 08:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From christine.lu at oracle.com Thu Sep 5 02:47:56 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:47:56 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b106 for changeset 2e3a056c84a7 Message-ID: <20130905094757.D1B5362592@hg.openjdk.java.net> Changeset: 23fc34133152 Author: cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/23fc34133152 Added tag jdk8-b106 for changeset 2e3a056c84a7 ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:47:47 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:47:47 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b106 for changeset 8e7b4d9fb00f Message-ID: <20130905094747.7B16662591@hg.openjdk.java.net> Changeset: 58f1b6f32b47 Author: cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/58f1b6f32b47 Added tag jdk8-b106 for changeset 8e7b4d9fb00f ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:48:33 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:48:33 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b106 for changeset aed585cafc0d Message-ID: <20130905094840.4BE9762593@hg.openjdk.java.net> Changeset: 3f4392035ec7 Author: cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3f4392035ec7 Added tag jdk8-b106 for changeset aed585cafc0d ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:49:41 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:49:41 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b106 for changeset d3be8e3b429d Message-ID: <20130905094945.61CB962594@hg.openjdk.java.net> Changeset: d6a32e3831aa Author: cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/d6a32e3831aa Added tag jdk8-b106 for changeset d3be8e3b429d ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:50:00 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:50:00 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b106 for changeset 6908370afe83 Message-ID: <20130905095004.363E162595@hg.openjdk.java.net> Changeset: e3c9328f7563 Author: cl Date: 2013-09-05 02:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/e3c9328f7563 Added tag jdk8-b106 for changeset 6908370afe83 ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:52:01 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:52:01 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b106 for changeset fcd768844b99 Message-ID: <20130905095208.9788962597@hg.openjdk.java.net> Changeset: 3f274927ec18 Author: cl Date: 2013-09-05 02:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3f274927ec18 Added tag jdk8-b106 for changeset fcd768844b99 ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:50:32 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:50:32 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b106 for changeset c817276bd870 Message-ID: <20130905095104.F2D0962596@hg.openjdk.java.net> Changeset: aafc0f332658 Author: cl Date: 2013-09-05 02:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/aafc0f332658 Added tag jdk8-b106 for changeset c817276bd870 ! .hgtags From christine.lu at oracle.com Thu Sep 5 02:52:26 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 05 Sep 2013 09:52:26 +0000 Subject: hg: jdk8/jdk8/nashorn: Added tag jdk8-b106 for changeset bf70cbd2c836 Message-ID: <20130905095229.41C4062598@hg.openjdk.java.net> Changeset: f35e1255024b Author: cl Date: 2013-09-05 02:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/f35e1255024b Added tag jdk8-b106 for changeset bf70cbd2c836 ! .hgtags From jesper.wilhelmsson at oracle.com Thu Sep 5 03:11:06 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 05 Sep 2013 12:11:06 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <522858BA.7020508@oracle.com> Vote: yes /Jesper Staffan Larsen skrev 5/9/13 8:16 AM: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From jesper.wilhelmsson at oracle.com Thu Sep 5 03:12:02 2013 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 05 Sep 2013 12:12:02 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <522858F2.2010909@oracle.com> Vote: yes /Jesper Stuart Marks skrev 4/9/13 11:38 PM: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing > other committers' work, he is actively developing Nashorn on daily basis and has > contributed many changesets related to areas of Nashorn's parser and compiler, > invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes > must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From dalibor.topic at oracle.com Thu Sep 5 04:18:18 2013 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 05 Sep 2013 13:18:18 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5228687A.7010903@oracle.com> Vote: Yes. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From dalibor.topic at oracle.com Thu Sep 5 04:19:08 2013 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Thu, 05 Sep 2013 13:19:08 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <522868AC.3080004@oracle.com> Vote: Yes. -- Oracle Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Gesch?ftsf?hrer: J?rgen Kunz Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Green Oracle Oracle is committed to developing practices and products that help protect the environment From kumar.x.srinivasan at oracle.com Thu Sep 5 05:08:32 2013 From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan) Date: Thu, 05 Sep 2013 05:08:32 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <52287440.70904@oracle.com> Vote: yes > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, > general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From mandy.chung at oracle.com Thu Sep 5 07:13:24 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 05 Sep 2013 07:13:24 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <52289184.1000205@oracle.com> Vote: yes Mandy From karen.kinnear at oracle.com Thu Sep 5 07:13:48 2013 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 5 Sep 2013 10:13:48 -0400 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <0B2FDE8B-C0BC-4558-8E49-AFA8159E0DCA@oracle.com> Vote: yes thanks, Karen On Sep 5, 2013, at 2:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From coleen.phillimore at oracle.com Thu Sep 5 07:31:44 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Thu, 05 Sep 2013 10:31:44 -0400 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <522895D0.5090303@oracle.com> Vote: yes On 9/5/2013 2:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From mike.duigou at oracle.com Thu Sep 5 07:51:08 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 5 Sep 2013 07:51:08 -0700 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: YES On Sep 4 2013, at 23:16 , Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From jonathan.gibbons at oracle.com Thu Sep 5 08:04:31 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 05 Sep 2013 08:04:31 -0700 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <52289D7F.3090002@oracle.com> Vote: yes On 09/04/2013 11:16 PM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From michael.fang at oracle.com Thu Sep 5 08:27:12 2013 From: michael.fang at oracle.com (Michael Fang) Date: Thu, 05 Sep 2013 08:27:12 -0700 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5228A2D0.3000502@oracle.com> Vote: yes mfang On 09/04/13 23:16, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From daniel.daugherty at oracle.com Thu Sep 5 08:33:57 2013 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Thu, 05 Sep 2013 09:33:57 -0600 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5228A465.8000701@oracle.com> Vote: yes Dan On 9/5/13 12:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From joel.franck at oracle.com Thu Sep 5 08:43:13 2013 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Thu, 5 Sep 2013 17:43:13 +0200 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: Vote: yes cheers /Joel On Sep 5, 2013, at 8:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From joel.franck at oracle.com Thu Sep 5 08:44:24 2013 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Thu, 5 Sep 2013 17:44:24 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <4B547C35-69CA-47A2-B426-F33D42A6F5B3@oracle.com> Vote: yes cheers /Joel On Sep 4, 2013, at 11:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From calvin.cheung at oracle.com Thu Sep 5 09:19:04 2013 From: calvin.cheung at oracle.com (Calvin Cheung) Date: Thu, 05 Sep 2013 09:19:04 -0700 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5228AEF8.2090403@oracle.com> Vote: yes Calvin On 9/4/2013 11:16 PM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From alexander.zuev at oracle.com Thu Sep 5 09:58:11 2013 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Thu, 5 Sep 2013 20:58:11 +0400 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: Vote: yes With best regards, Alexander Zuev 05.09.2013, ? 1:38, Stuart Marks ???????(?): > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From mandy.chung at oracle.com Thu Sep 5 12:36:48 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 05 Sep 2013 12:36:48 -0700 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5228DD50.500@oracle.com> Vote: yes Mandy From alejandro.murillo at oracle.com Thu Sep 5 13:13:23 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Thu, 05 Sep 2013 14:13:23 -0600 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5228E5E3.9000409@oracle.com> vote: yes -- Alejandro From tim.bell at oracle.com Thu Sep 5 14:43:53 2013 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 05 Sep 2013 14:43:53 -0700 Subject: Upcoming JDK 8 Platform/Compiler upgrades at Oracle Message-ID: <5228FB19.1010506@oracle.com> All- We have been working on upgrading the build platforms and compilers used at Oracle to build JDK 8. The plan is to update to newer build platforms and tools, as well as reduce the total number of build OS versions involved. This is important because the changes we make now will be with us for the lifetime of JDK 8, including update releases. These platforms will be used for the EA builds on java.net, the reference implementation, and the final product shipped by Oracle. Our target combinations are: - Linux - Oracle 6.4 64-bit / GCC 4.7.3 - MacOS X - 10.8 64-bit / XCode 4.6.2 / clang [1] - Solaris X86 - 10 update 10 64-bit / Oracle Solaris Studio 12.3 [2] - Solaris SPARC - 10 update 10 64-bit / Oracle Solaris Studio 12.3 [2] - Windows - 2008 R2 64-bit / Microsoft Visual Studio 2010 SP1 For Linux and Windows, the 64-bit platform will also build 32-bit binaries. The MacOS build is 64-bit only. For Solaris we are moving towards removing the legacy 32-bit builds entirely for both SPARC and X86, and cleaning up the overlay installation requirements. [3] Feedback is welcome. We will send regular updates as we work through the upgrade process. Tim [1] With a fallback position of using XCode 4.6.2 and gcc, pending further testing. [2] With a fallback position of staying with Studio 12.1, pending further testing. [3] http://bugs.sun.com/view_bug.do?bug_id=8020552 From alexander.zuev at oracle.com Fri Sep 6 05:29:33 2013 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Fri, 06 Sep 2013 16:29:33 +0400 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: References: Message-ID: <5229CAAD.20203@oracle.com> Vote: yes /Alex On 9/5/13 10:16, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: > > 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing > 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace > 6417649: -interval=0 is accepted and jconsole doesn't update window content at all > 7042707: Un-needed mnemonic in JConsole resource file > 6800801: NPE in JConsole when using Nimbus L&F > 6417721: Thread list should not allow multiple selection > 6358357: Division by zero in Threads tab when shrinking jconsole window > 6696970: Jconsole becomes unusable if a plugin throws an exception > 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation > 6721425: jconsole Makefile clean rule is missing rm of generated Version.java > 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box > 8008611: Better handling of annotations in JMX > 7017818: NLS: JConsoleResources.java cannot be handled by translation team > 8005008: Add Java Flight Recorder Phase II > 7132386: makefile support for tracing/Java Flight Recorder framework phase I > > Votes are due by 2013-09-19. > > Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > Staffan Larsen > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From ivan at azulsystems.com Fri Sep 6 06:39:44 2013 From: ivan at azulsystems.com (Ivan Krylov) Date: Fri, 6 Sep 2013 13:39:44 +0000 Subject: CFV: New JDK 8 Committer: Erik Gahlin In-Reply-To: <5229CAAD.20203@oracle.com> References: <5229CAAD.20203@oracle.com> Message-ID: <33929323-A18C-4A1F-90B1-1CFCB6D562C7@azulsystems.com> Vote: yes > On 9/5/13 10:16, Staffan Larsen wrote: >> I hereby nominate Erik Gahlin to JDK 8 Committer. >> >> Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: >> >> 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing >> 6359971: Threads tab: Simple text to explain that one can click on a thread to get stack trace >> 6417649: -interval=0 is accepted and jconsole doesn't update window content at all >> 7042707: Un-needed mnemonic in JConsole resource file >> 6800801: NPE in JConsole when using Nimbus L&F >> 6417721: Thread list should not allow multiple selection >> 6358357: Division by zero in Threads tab when shrinking jconsole window >> 6696970: Jconsole becomes unusable if a plugin throws an exception >> 7015157: String "Tabular Navigation" should be rephrased for avoiding mistranslation >> 6721425: jconsole Makefile clean rule is missing rm of generated Version.java >> 6417702: Graph in Memory tab is not redrawn immediately if changed via 'Chart' combo box >> 8008611: Better handling of annotations in JMX >> 7017818: NLS: JConsoleResources.java cannot be handled by translation team >> 8005008: Add Java Flight Recorder Phase II >> 7132386: makefile support for tracing/Java Flight Recorder framework phase I >> >> Votes are due by 2013-09-19. >> >> Only current JDK Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. >> >> For Lazy Consensus voting instructions, see [2]. >> >> Staffan Larsen >> >> [1] http://openjdk.java.net/census >> [2] http://openjdk.java.net/projects/#committer-vote > From mark.reinhold at oracle.com Mon Sep 9 10:46:42 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Mon, 09 Sep 2013 10:46:42 -0700 Subject: JDK 8 Developer Preview Message-ID: <20130909104642.896175@eggemoggin.niobe.net> Build 106, promoted last Thursday, is the Developer Preview build. This milestone is intended for broad testing by developers [1]. For reference, the proprietary Oracle builds for this milestone can be found here: http://jdk8.java.net/download.html . Pointers to other builds are welcome! - Mark [1] http://mreinhold.org/blog/jdk8-preview From omajid at redhat.com Mon Sep 9 11:18:26 2013 From: omajid at redhat.com (Omair Majid) Date: Mon, 09 Sep 2013 14:18:26 -0400 Subject: JDK 8 Developer Preview In-Reply-To: <20130909104642.896175@eggemoggin.niobe.net> References: <20130909104642.896175@eggemoggin.niobe.net> Message-ID: <522E10F2.3040501@redhat.com> On 09/09/2013 01:46 PM, mark.reinhold at oracle.com wrote: > Build 106, promoted last Thursday, is the Developer Preview build. > This milestone is intended for broad testing by developers [1]. > > For reference, the proprietary Oracle builds for this milestone can > be found here: http://jdk8.java.net/download.html . > > Pointers to other builds are welcome! Fedora packages should be available as an update soon: Fedora 19: https://admin.fedoraproject.org/updates/FEDORA-2013-16024 Fedora 20: https://admin.fedoraproject.org/updates/FEDORA-2013-16041 Cheers, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From alejandro.murillo at oracle.com Tue Sep 10 14:02:18 2013 From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com) Date: Tue, 10 Sep 2013 21:02:18 +0000 Subject: hg: jdk8/jdk8/jdk: 8024515: ProblemList.txt updates to exclude tests that fail with hs25-b49 Message-ID: <20130910210246.CEDD5626D6@hg.openjdk.java.net> Changeset: eea685b9ccaa Author: amurillo Date: 2013-09-10 05:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/eea685b9ccaa 8024515: ProblemList.txt updates to exclude tests that fail with hs25-b49 Reviewed-by: alanb, chegar ! test/ProblemList.txt From alejandro.murillo at oracle.com Tue Sep 10 14:05:25 2013 From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com) Date: Tue, 10 Sep 2013 21:05:25 +0000 Subject: hg: jdk8/jdk8/hotspot: 57 new changesets Message-ID: <20130910210735.30CA1626D7@hg.openjdk.java.net> Changeset: c169f7038414 Author: amurillo Date: 2013-08-30 00:29 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c169f7038414 8024022: new hotspot build - hs25-b49 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 4a1efab850f4 Author: shade Date: 2013-08-26 17:42 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/4a1efab850f4 8023638: Add the regression test for 8006997 Summary: Add the relevant test and proofread the VM messages as well Reviewed-by: coleenp, mseledtsov, dcubed ! src/share/vm/runtime/arguments.cpp + test/runtime/contended/Options.java Changeset: a7d8baf4cca7 Author: dcubed Date: 2013-08-26 18:34 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a7d8baf4cca7 Merge Changeset: 91b93f523ec6 Author: acorn Date: 2013-08-26 11:35 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/91b93f523ec6 8012294: remove generic handling for default methods Reviewed-by: kamg, coleenp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/defaultMethods.cpp - src/share/vm/classfile/genericSignatures.cpp - src/share/vm/classfile/genericSignatures.hpp ! src/share/vm/runtime/globals.hpp Changeset: d80493ee6430 Author: acorn Date: 2013-08-27 01:21 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d80493ee6430 Merge - src/share/vm/classfile/genericSignatures.cpp - src/share/vm/classfile/genericSignatures.hpp ! src/share/vm/runtime/globals.hpp Changeset: 6b3ac96bada6 Author: jiangli Date: 2013-08-26 13:32 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6b3ac96bada6 8023477: Invalid CP index when reading ConstantPool. Summary: Need to check for 0 case for InstanceKlass::_generic_signature_index. Reviewed-by: sspitsyn, sla ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java Changeset: b3596321fbf4 Author: jiangli Date: 2013-08-27 04:58 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b3596321fbf4 Merge Changeset: 7e7dd25666da Author: ccheung Date: 2013-08-26 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7e7dd25666da 8020675: invalid jar file in the bootclasspath could lead to jvm fatal error Summary: removed offending EXCEPTION_MARK calls and code cleanup Reviewed-by: dholmes, iklam, coleenp, mseledtsov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/classfile/classLoader.hpp + test/runtime/LoadClass/LoadClassNegative.java + test/runtime/LoadClass/TestForName.java + test/runtime/LoadClass/dummy.jar Changeset: 5351fe805c12 Author: minqi Date: 2013-08-27 07:54 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5351fe805c12 Merge Changeset: f462e61bce87 Author: iklam Date: 2013-08-26 21:59 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f462e61bce87 8020622: create.bat on Windows failed to create project file for Visual Studio 2012 Summary: Treat VS2012 the same as VS2010. Reviewed-by: dcubed, kamg, minqi ! make/windows/create.bat ! make/windows/makefiles/rules.make Changeset: 35471dcba316 Author: iklam Date: 2013-08-27 03:35 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/35471dcba316 Merge Changeset: c26d57fa08aa Author: iklam Date: 2013-08-27 16:02 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c26d57fa08aa Merge Changeset: 915cc4f3fb15 Author: acorn Date: 2013-08-28 08:15 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/915cc4f3fb15 8020489: VM crash when non-existent interface called by invokespecial Reviewed-by: kamg, coleenp ! src/share/vm/classfile/defaultMethods.cpp Changeset: cc56f122f3f7 Author: sla Date: 2013-08-29 11:05 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/cc56f122f3f7 8023720: (hotspot) setjmp/longjmp changes the process signal mask on OS X Reviewed-by: dholmes, rbackman ! src/os/posix/vm/os_posix.cpp Changeset: 76482cbba706 Author: hseigel Date: 2013-08-29 10:33 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/76482cbba706 8016764: JVM does not prohibit invokespecial in c.f.v 51.0 that invokes default interface method in c.f.v 52.0 Summary: Check cfv before allowing invokespecial call to default method. Reviewed-by: kamg, acorn, dholmes ! src/share/vm/classfile/verifier.cpp Changeset: dfc126b2f659 Author: hseigel Date: 2013-08-29 13:44 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/dfc126b2f659 8022407: sun/misc/CopyMemory.java fails with SIGSEGV in Unsafe_SetByte+0x35 Summary: lower optimization level for unsafe.cpp due to MacOS Xcode 4.6.2 compiler optimization issue. Reviewed-by: coleenp, twisti, dholmes Contributed-by: lois.foltan at oracle.com ! make/bsd/makefiles/gcc.make Changeset: d8e99408faad Author: dsamersoff Date: 2013-08-29 21:48 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d8e99408faad 8009062: poor performance of JNI AttachCurrentThread after fix for 7017193 Summary: don't re-evaluate stack bounds for main thread before install guard page Reviewed-by: coleenp, dholmes, dlong ! src/os/linux/vm/os_linux.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp + test/runtime/InitialThreadOverflow/DoOverflow.java + test/runtime/InitialThreadOverflow/invoke.cxx + test/runtime/InitialThreadOverflow/testme.sh Changeset: cef1e56a4d88 Author: dsamersoff Date: 2013-08-29 21:46 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/cef1e56a4d88 Merge Changeset: 9758d9f36299 Author: coleenp Date: 2013-08-29 18:56 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/9758d9f36299 8021954: VM SIGSEGV during classloading on MacOS; hs_err_pid file produced Summary: declare all user-defined operator new()s within Hotspot code with the empty throw() exception specification Reviewed-by: coleenp, twisti, dholmes, hseigel, dcubed, kvn, ccheung Contributed-by: lois.foltan at oracle.com ! src/share/vm/adlc/arena.cpp ! src/share/vm/adlc/arena.hpp ! src/share/vm/adlc/main.cpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.hpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/code/codeBlob.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/relocInfo.hpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/code/vtableStubs.hpp ! src/share/vm/gc_implementation/shared/gcUtil.hpp ! src/share/vm/libadt/port.hpp ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/memory/allocation.inline.hpp ! src/share/vm/memory/memRegion.cpp ! src/share/vm/memory/memRegion.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/symbol.cpp ! src/share/vm/oops/symbol.hpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/fprofiler.cpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/interfaceSupport.hpp ! src/share/vm/runtime/objectMonitor.hpp ! src/share/vm/runtime/park.cpp ! src/share/vm/runtime/park.hpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/services/memRecorder.hpp ! src/share/vm/services/memTrackWorker.cpp ! src/share/vm/services/memTrackWorker.hpp ! src/share/vm/utilities/array.hpp Changeset: c636758ea616 Author: dcubed Date: 2013-08-30 07:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c636758ea616 Merge ! src/os/posix/vm/os_posix.cpp - src/share/vm/classfile/genericSignatures.cpp - src/share/vm/classfile/genericSignatures.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 522d69638aa8 Author: zgu Date: 2013-08-30 11:54 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/522d69638aa8 6991327: using -Xprof trigger native memory leak Summary: Fixed a memory leak in FlatProfiler::record_thread_tick() method Reviewed-by: dholmes, ccheung ! src/share/vm/runtime/fprofiler.cpp Changeset: 491de79915eb Author: zgu Date: 2013-08-30 12:22 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/491de79915eb Merge ! src/share/vm/runtime/fprofiler.cpp Changeset: ac2764460da7 Author: zgu Date: 2013-08-30 13:38 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ac2764460da7 Merge Changeset: ca0501b58953 Author: hseigel Date: 2013-08-30 15:07 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ca0501b58953 8024050: Incorrect optimization level and comment specified for unsafe.cpp Summary: Fix comments and optimization level. Reviewed-by: rdurbin, coleenp, hseigel Contributed-by: lois.foltan at oracle.com ! make/bsd/makefiles/gcc.make Changeset: d8ff06fb87ae Author: hseigel Date: 2013-08-30 15:15 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d8ff06fb87ae Merge Changeset: abff50660360 Author: hseigel Date: 2013-08-30 15:57 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/abff50660360 Merge Changeset: 3a1df0dce3e5 Author: acorn Date: 2013-08-30 15:15 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3a1df0dce3e5 8023872: Verification error in generated lambda classes Summary: skip verification for generated lambda classes Reviewed-by: kamg, dholmes ! src/share/vm/classfile/verifier.cpp ! src/share/vm/runtime/globals.hpp Changeset: 735f94656acc Author: acorn Date: 2013-08-30 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/735f94656acc Merge Changeset: 2918c7e21a3a Author: acorn Date: 2013-08-30 15:42 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2918c7e21a3a Merge Changeset: 35b99e7e0af2 Author: hseigel Date: 2013-09-01 10:37 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/35b99e7e0af2 8023381: VM fails to initialize in runtime/CDSCompressedKPtrs/XShareAuto.java runtime/SharedArchiveFile/CdsSameObjectAlignment.java Summary: Improve handling when CDS archive cannot be mapped Reviewed-by: kvn, dholmes, mseledtsov ! src/share/vm/memory/filemap.cpp ! test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrs.java ! test/runtime/CDSCompressedKPtrs/XShareAuto.java ! test/runtime/SharedArchiveFile/CdsSameObjectAlignment.java Changeset: 766fac3395d6 Author: kvn Date: 2013-08-23 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/766fac3395d6 8012972: Incremental Inlining should support scalar replaced object in debug info Summary: store in _first_index not absolute index but an index relative to the last (youngest) jvms->_scloff value Reviewed-by: roland, twisti ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/callnode.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/generateOptoStub.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/output.cpp Changeset: b17d8f6d9ed7 Author: kvn Date: 2013-08-23 18:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b17d8f6d9ed7 8023472: C2 optimization breaks with G1 Summary: set control edge for previous value load in G1 pre-barrier Reviewed-by: twisti ! src/share/vm/opto/graphKit.cpp + test/compiler/gcbarriers/G1CrashTest.java Changeset: f98f5d48f511 Author: roland Date: 2013-08-21 13:34 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f98f5d48f511 7199175: JSR 292: C1 needs patching when invokedynamic/invokehandle call site is not linked Summary: Do patching rather bailing out for unlinked call with appendix Reviewed-by: twisti, kvn ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/share/vm/c1/c1_CodeStubs.hpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/c1/c1_globals.cpp ! src/share/vm/c1/c1_globals.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: e1fbb86b47e4 Author: roland Date: 2013-08-26 16:12 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e1fbb86b47e4 8016277: Crash in nmethod::is_compiled_by_c1() on x86 Summary: Method pointer for zombie methods may be invalid Reviewed-by: kvn, coleenp ! src/share/vm/code/nmethod.cpp Changeset: e47de6dfec5d Author: vlivanov Date: 2013-08-26 17:37 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e47de6dfec5d 8022456: LogCompilation tool does not work with C1 output again Reviewed-by: kvn ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/CallSite.java ! src/share/tools/LogCompilation/src/com/sun/hotspot/tools/compiler/LogParser.java ! src/share/vm/c1/c1_Compilation.cpp Changeset: 74608df95ba3 Author: vlivanov Date: 2013-08-26 17:41 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/74608df95ba3 8022595: JSR292: deadlock during class loading of MethodHandles, MethodHandleImpl & MethodHandleNatives Reviewed-by: kvn, coleenp, dholmes ! src/share/vm/runtime/thread.cpp + test/compiler/jsr292/ConcurrentClassLoadingTest.java Changeset: 022415fe638e Author: vlivanov Date: 2013-08-26 21:48 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/022415fe638e Merge Changeset: 59982ff9e0ec Author: rbackman Date: 2013-08-20 09:37 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/59982ff9e0ec 8022283: Assertion failed: assert(is_loaded() && field->holder()->is_loaded() && klass()->is_subclass_of (field->holder())) failed: invalid access Reviewed-by: roland, twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciInstance.cpp Changeset: 58e010ab2d06 Author: rbackman Date: 2013-08-27 19:37 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/58e010ab2d06 Merge Changeset: 650868c062a9 Author: adlertz Date: 2013-08-26 12:50 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/650868c062a9 8023691: Create interface for nodes in class Block Summary: Create public methods for accessing the nodes in a block Reviewed-by: kvn, roland ! src/share/vm/adlc/output_c.cpp ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/buildOopMap.cpp ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/domgraph.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/idealGraphPrinter.cpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/opto/reg_split.cpp Changeset: 7181dd13a6c4 Author: adlertz Date: 2013-08-27 21:16 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7181dd13a6c4 Merge Changeset: 29aa8936f03c Author: kvn Date: 2013-08-28 11:22 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/29aa8936f03c 8023597: Optimize G1 barriers code for unsafe load_store Summary: Avoid loading old values in G1 pre-barriers for inlined unsafe load_store nodes. Reviewed-by: kvn, tonyp Contributed-by: Martin Doerr ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp Changeset: 8947af8a9cec Author: vlivanov Date: 2013-08-29 22:44 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8947af8a9cec 8023976: assert(!CompilationPolicy::can_be_compiled(this, comp_level)) failed: sanity check Reviewed-by: kvn, twisti ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp Changeset: 4b078f877b56 Author: adlertz Date: 2013-09-01 19:21 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/4b078f877b56 8023988: Move local scheduling of nodes to the CFG creation and code motion phase (PhaseCFG) Summary: Moved local scheduling code from class Block to class PhaseCFG Reviewed-by: kvn, roland ! src/share/vm/opto/block.cpp ! src/share/vm/opto/block.hpp ! src/share/vm/opto/coalesce.cpp ! src/share/vm/opto/gcm.cpp ! src/share/vm/opto/lcm.cpp Changeset: 40ed2dc92a79 Author: adlertz Date: 2013-09-01 19:52 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/40ed2dc92a79 Merge Changeset: 27ffd1c4537b Author: rbackman Date: 2013-09-02 13:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/27ffd1c4537b Merge ! src/share/vm/runtime/thread.cpp Changeset: a9a968364704 Author: adlertz Date: 2013-09-02 22:44 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a9a968364704 8024095: Missing brackets in local scheduling code. Summary: Added brackets for if-statement Reviewed-by: kvn, roland ! src/share/vm/opto/lcm.cpp Changeset: 3bfb204913de Author: adlertz Date: 2013-09-05 10:39 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3bfb204913de Merge ! src/share/vm/code/nmethod.cpp ! src/share/vm/opto/callnode.hpp ! src/share/vm/opto/node.hpp Changeset: 88c255656030 Author: mgerdin Date: 2013-08-22 10:50 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/88c255656030 8016155: SIGBUS when running Kitchensink with ParallelScavenge and ParallelOld Summary: When using NUMA and large pages we need to ease the requirement on which node the memory should be allocated on. To avoid the SIGBUS we now use the memory policy MPOL_PREFERRED, which prefers a certain node, instead of MPOL_BIND, which requires a certain node. Reviewed-by: jmasa, pliden Contributed-by: stefan.johansson at oracle.com ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 0d59407e7e09 Author: jmasa Date: 2013-08-29 06:53 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/0d59407e7e09 Merge ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 84683e78e713 Author: brutisso Date: 2013-08-30 07:31 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/84683e78e713 8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size Reviewed-by: tonyp, tschatzl, sjohanss ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp Changeset: f175e3678be2 Author: ehelin Date: 2013-08-22 11:23 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f175e3678be2 8020692: TestGCEventMixed.java failed because of timestamp in event after end event Reviewed-by: mgerdin, stefank ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/shared/gcTraceSend.cpp Changeset: a701c16e8bbf Author: jmasa Date: 2013-09-04 11:41 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a701c16e8bbf 8013938: Native OOME on fastdebug VM on Solaris Reviewed-by: azeemj, brutisso, kvn, tschatzl ! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 428025878417 Author: jmasa Date: 2013-09-04 12:56 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/428025878417 Merge Changeset: bb57d48691f5 Author: tschatzl Date: 2013-09-05 14:15 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/bb57d48691f5 Merge ! src/os/linux/vm/os_linux.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp Changeset: 50794d8ac11c Author: amurillo Date: 2013-09-06 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/50794d8ac11c Merge - src/share/vm/classfile/genericSignatures.cpp - src/share/vm/classfile/genericSignatures.hpp Changeset: 5b7f90aab3ad Author: amurillo Date: 2013-09-06 11:04 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5b7f90aab3ad Added tag hs25-b49 for changeset 50794d8ac11c ! .hgtags From alejandro.murillo at oracle.com Tue Sep 10 14:54:29 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 10 Sep 2013 15:54:29 -0600 Subject: jdk8-b107: HotSpot Message-ID: <522F9515.9090701@oracle.com> hs25-b49 has been integrated into jdk8-b107. http://hg.openjdk.java.net/jdk8/jdk8/rev/58f1b6f32b47 http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/23fc34133152 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5b7f90aab3ad http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/d6a32e3831aa http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/e3c9328f7563 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/eea685b9ccaa http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3f274927ec18 http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/f35e1255024b Component : VM Status : 0 major failures, 0 minor failures Date : 09/10/2013 at 21:57 Tested By : VM SQE &leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : 2013-09-06-180541.jcoomes.hs25-b49-snapshot Bundles : 2013-09-06-180541.jcoomes.hs25-b49-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Browsers : NA Patches : NA Logs :http://surl.us.oracle.com/PIT_HS25b49 Number of Tests Executed : 343301 passed tests, 4705 failed tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 6991327: using -Xprof trigger native memory leak 7199175: JSR 292: C1 needs patching when invokedynamic/invokehandle call site is not linked 8009062: poor performance of JNI AttachCurrentThread after fix for 7017193 8012294: remove generic handling for default methods 8012972: Incremental Inlining should support scalar replaced object in debug info 8013938: Native OOME on fastdebug VM on Solaris 8016155: SIGBUS when running Kitchensink with ParallelScavenge and ParallelOld 8016277: Crash in nmethod::is_compiled_by_c1() on x86 8016764: JVM does not prohibit invokespecial in c.f.v 51.0 that invokes default interface method in c.f.v 52.0 8019902: G1: Use the average heap size rather than the minimum heap size to calculate the region size 8020489: VM crash when non-existent interface called by invokespecial 8020622: create.bat on Windows failed to create project file for Visual Studio 2012 8020675: invalid jar file in the bootclasspath could lead to jvm fatal error 8020692: TestGCEventMixed.java failed because of timestamp in event after end event 8021954: VM SIGSEGV during classloading on MacOS; hs_err_pid file produced 8022283: Assertion failed: assert(is_loaded() && field->holder()->is_loaded() && klass()->is_subclass_of (field->holder())) failed: invalid access 8022407: sun/misc/CopyMemory.java fails with SIGSEGV in Unsafe_SetByte+0x35 8022456: LogCompilation tool does not work with C1 output again 8022595: JSR292: deadlock during class loading of MethodHandles, MethodHandleImpl & MethodHandleNatives 8023381: VM fails to initialize in runtime/CDSCompressedKPtrs/XShareAuto.java runtime/SharedArchiveFile/CdsSameObjectAlignment.java 8023472: C2 optimization breaks with G1 8023477: Invalid CP index when reading ConstantPool. 8023597: Optimize G1 barriers code for unsafe load_store 8023638: Add the regression test for 8006997 8023691: Create interface for nodes in class Block 8023720: (hotspot) setjmp/longjmp changes the process signal mask on OS X 8023872: Verification error in generated lambda classes 8023976: assert(!CompilationPolicy::can_be_compiled(this, comp_level)) failed: sanity check 8023988: Move local scheduling of nodes to the CFG creation and code motion phase (PhaseCFG) 8024022: new hotspot build - hs25-b49 8024050: Incorrect optimization level and comment specified for unsafe.cpp 8024095: Missing brackets in local scheduling code. Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b107. Issues and Notes: This is PIT for HS25 b49 for JDK 8 b107. -- Alejandro From Alan.Bateman at oracle.com Wed Sep 11 06:29:58 2013 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 11 Sep 2013 14:29:58 +0100 Subject: Result: New jdk8-dev Reviewer: Paul Sandoz Message-ID: <52307056.1060703@oracle.com> Voting for Paul Sandoz [1] is now closed. Yes: 17 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. -Alan. [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/003022.html From david.katleman at oracle.com Wed Sep 11 10:40:08 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 11 Sep 2013 17:40:08 +0000 Subject: hg: jdk8/jdk8: 8024320: Add s390(x) detection to platform.m4 Message-ID: <20130911174008.B574662726@hg.openjdk.java.net> Changeset: 0874bb4707b7 Author: omajid Date: 2013-09-11 12:08 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/0874bb4707b7 8024320: Add s390(x) detection to platform.m4 Reviewed-by: erikj, ihse, dsamersoff ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 From mark.reinhold at oracle.com Wed Sep 11 16:19:05 2013 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Wed, 11 Sep 2013 16:19:05 -0700 Subject: Result: New jdk8-dev Reviewer: Paul Sandoz In-Reply-To: <52307056.1060703@oracle.com> References: <52307056.1060703@oracle.com> Message-ID: <20130911161905.398430@eggemoggin.niobe.net> 2013/9/10 23:29 -0700, alan.bateman at oracle.com: > Voting for Paul Sandoz [1] is now closed. > > Yes: 17 > Veto: 0 > Abstain: 0 > > According to the Bylaws definition of Lazy Consensus, this is sufficient > to approve the nomination. So recorded. - Mark From jonathan.gibbons at oracle.com Thu Sep 12 10:11:10 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 12 Sep 2013 10:11:10 -0700 Subject: CFV: New jdk8 Reviewer: Joel =?ISO-8859-1?Q?Borggr=E9n-Franc?= =?ISO-8859-1?Q?k?= In-Reply-To: <521D482F.4090201@oracle.com> References: <521D482F.4090201@oracle.com> Message-ID: <5231F5AE.7000801@oracle.com> Voting for Joel Borggr?n-Franck [1] is now closed. Yes: 9 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Jonathan Gibbons [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/003049.html [votes] Mike Duigou Joe Darcy Karen Kinnear Eric Joelsson Collen Philmore Mark Reinhold Mandy Chung Jim Holmlund Kumar Srinivasan Paul Sandoz also voted, but was not eligible to vote when his vote was cast. From jonathan.gibbons at oracle.com Thu Sep 12 10:15:05 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 12 Sep 2013 10:15:05 -0700 Subject: Result: New jdk8 Reviewer: Joel =?ISO-8859-1?Q?Borggr=E9n-Franck?= In-Reply-To: <5231F5AE.7000801@oracle.com> References: <521D482F.4090201@oracle.com> <5231F5AE.7000801@oracle.com> Message-ID: <5231F699.90005@oracle.com> (Repeat with correct subject line) On 09/12/2013 10:11 AM, Jonathan Gibbons wrote: > > Voting for Joel Borggr?n-Franck [1] is now closed. > > Yes: 9 > Veto: 0 > Abstain: 0 > > According to the Bylaws definition of Three-Vote Consensus, this is > sufficient to approve the nomination. > > Jonathan Gibbons > > [1] > http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/003049.html > > [votes] > Mike Duigou > Joe Darcy > Karen Kinnear > Eric Joelsson > Collen Philmore > Mark Reinhold > Mandy Chung > Jim Holmlund > Kumar Srinivasan > > Paul Sandoz also voted, but was not eligible to vote when his vote was > cast. > From jonathan.gibbons at oracle.com Thu Sep 12 10:22:07 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 12 Sep 2013 10:22:07 -0700 Subject: Result: New jdk8 Reviewer: Vicente Romero In-Reply-To: <521E71A4.9000106@oracle.com> References: <521E71A4.9000106@oracle.com> Message-ID: <5231F83F.8020803@oracle.com> Voting for Vicente Romero [1] is now closed. Yes: 5 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Jonathan Gibbons [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/003064.html [votes] Joe Darcy Tim Bell Mark Reinhold Jim Holmlund Kumar Srinivasan From jonathan.gibbons at oracle.com Thu Sep 12 10:25:28 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 12 Sep 2013 10:25:28 -0700 Subject: Result: New jdk8 Committer: Jan Lahoda In-Reply-To: <521E718E.1090800@oracle.com> References: <521E718E.1090800@oracle.com> Message-ID: <5231F908.90303@oracle.com> Voting for Jan Lahoda [1] is now closed. Yes: 13 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Jonathan Gibbons [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-August/003063.html [votes] Mike Duigou Omair Majid Joe Darcy Tim Bell Alan Bateman Alexander Zuev Mark Reinhold Paul Sandoz Vicente Romero Kumar Srinivasan Dalibor Topic Henry Jen Jaroslav Bachorik From christine.lu at oracle.com Thu Sep 12 11:10:42 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:10:42 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b107 for changeset 0874bb4707b7 Message-ID: <20130912181042.E25AB62774@hg.openjdk.java.net> Changeset: 14fe208b657c Author: cl Date: 2013-09-12 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/14fe208b657c Added tag jdk8-b107 for changeset 0874bb4707b7 ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:10:53 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:10:53 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b107 for changeset 23fc34133152 Message-ID: <20130912181054.112A162775@hg.openjdk.java.net> Changeset: 260f00a95705 Author: cl Date: 2013-09-12 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/260f00a95705 Added tag jdk8-b107 for changeset 23fc34133152 ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:11:32 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:11:32 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b107 for changeset 5b7f90aab3ad Message-ID: <20130912181135.1AE8062776@hg.openjdk.java.net> Changeset: 9cd0183fe325 Author: cl Date: 2013-09-12 11:08 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/9cd0183fe325 Added tag jdk8-b107 for changeset 5b7f90aab3ad ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:12:29 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:12:29 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b107 for changeset d6a32e3831aa Message-ID: <20130912181232.7221C62777@hg.openjdk.java.net> Changeset: 8ade3eed63da Author: cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/8ade3eed63da Added tag jdk8-b107 for changeset d6a32e3831aa ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:12:46 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:12:46 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b107 for changeset e3c9328f7563 Message-ID: <20130912181248.BDC3B62778@hg.openjdk.java.net> Changeset: d1ea68556fd7 Author: cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/d1ea68556fd7 Added tag jdk8-b107 for changeset e3c9328f7563 ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:13:04 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:13:04 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b107 for changeset eea685b9ccaa Message-ID: <20130912181320.B2B3A62779@hg.openjdk.java.net> Changeset: b67c8099ba28 Author: cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b67c8099ba28 Added tag jdk8-b107 for changeset eea685b9ccaa ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:14:17 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:14:17 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b107 for changeset 3f274927ec18 Message-ID: <20130912181420.E5B5B6277A@hg.openjdk.java.net> Changeset: 1b7f5a27c4ba Author: cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/1b7f5a27c4ba Added tag jdk8-b107 for changeset 3f274927ec18 ! .hgtags From christine.lu at oracle.com Thu Sep 12 11:14:33 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 12 Sep 2013 18:14:33 +0000 Subject: hg: jdk8/jdk8/nashorn: Added tag jdk8-b107 for changeset f35e1255024b Message-ID: <20130912181434.73AF36277B@hg.openjdk.java.net> Changeset: a1f980cc1355 Author: cl Date: 2013-09-12 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/a1f980cc1355 Added tag jdk8-b107 for changeset f35e1255024b ! .hgtags From joe.darcy at oracle.com Fri Sep 13 00:12:26 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Fri, 13 Sep 2013 00:12:26 -0700 Subject: Turning on javac lint warnings when building Java sources in jdk 8 repo In-Reply-To: <52268F9B.8010203@oracle.com> References: <52268F9B.8010203@oracle.com> Message-ID: <5232BADA.3090502@oracle.com> Hello, A follow-up, some lint warnings are now enabled: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/262a625809fd At least a few more should be turned out before JDK 8 GA! Thanks, -Joe On 09/03/2013 06:40 PM, Joe Darcy wrote: > Hello, > > Over the last few months, over on core-libs-dev there have been > various clean up efforts concerning the Java code in the JDK 8 "jdk" > repo, resolving both javac lint and doclint warnings. > > With these clean ups in place, I think it is time for selected > categories of javac lint warnings to be enabled during the build under > -Werror. That is, for lint categories that have been scrubbed, the > build should be reconfigured so that reintroducing such a warning is a > build error. (Under the old build, different packages could use > different javac command line options. With the new build, all the Java > code is compiled under the same options so the full build was reduced > to the least restrictive javac lint setting.) > > As additional warning categories are resolved, the set of enabled lint > categories could be expanded, potentially including doclint categories > too. > > Cheers, > > -Joe > > [1] > http://mail.openjdk.java.net/pipermail/build-dev/2013-August/009806.html From paul.sandoz at oracle.com Sun Sep 15 09:36:57 2013 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Sun, 15 Sep 2013 18:36:57 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: Vote: yes Paul. From marcus.lagergren at oracle.com Sun Sep 15 10:56:03 2013 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Sun, 15 Sep 2013 19:56:03 +0200 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <8950CEF4-2395-4CD6-A5B9-951296252C43@oracle.com> Vote: YES /M On Sep 4, 2013, at 11:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From vladimir.kozlov at oracle.com Sun Sep 15 11:09:16 2013 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Sun, 15 Sep 2013 11:09:16 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5235F7CC.6020208@oracle.com> Vote: yes Vladimir On 9/4/13 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively > developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, > invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to > this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From pete.poulos at gmail.com Tue Sep 17 14:44:31 2013 From: pete.poulos at gmail.com (Pete Poulos) Date: Tue, 17 Sep 2013 15:44:31 -0600 Subject: Shouldn't Optional be Serializable? Message-ID: Shouldn't java.util.Optional be Serializable? Is there a good reason for it not be? Thanks, Pete From forax at univ-mlv.fr Tue Sep 17 15:02:36 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 18 Sep 2013 00:02:36 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: Message-ID: <5238D17C.5090408@univ-mlv.fr> On 09/17/2013 11:44 PM, Pete Poulos wrote: > Shouldn't java.util.Optional be Serializable? Is there a good reason for > it not be? wrong question. the right one is why do you want Optional to be Serializable. > Thanks, > Pete cheers, R?mi From vitalyd at gmail.com Tue Sep 17 16:32:48 2013 From: vitalyd at gmail.com (Vitaly Davidovich) Date: Tue, 17 Sep 2013 19:32:48 -0400 Subject: Shouldn't Optional be Serializable? In-Reply-To: <5238D17C.5090408@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> Message-ID: Presumably because you may want to have class fields that express nullability via Optional rather than null. Whether that's a good design or not is a separate question; conceptually, I don't see a reason why Optional cannot support that. For "reference", Google Guava's version is serializable. If someone were to replace their use with jdk's Optional then they will hit exceptions if the owner class is serialized. Sent from my phone On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: > On 09/17/2013 11:44 PM, Pete Poulos wrote: > >> Shouldn't java.util.Optional be Serializable? Is there a good reason for >> it not be? >> > > wrong question. > the right one is why do you want Optional to be Serializable. > > Thanks, >> Pete >> > > cheers, > R?mi > > From lana.steuck at oracle.com Tue Sep 17 17:00:03 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 18 Sep 2013 00:00:03 +0000 Subject: hg: jdk8/jdk8: 4 new changesets Message-ID: <20130918000005.45A8F628D5@hg.openjdk.java.net> Changeset: 6d7f27953da6 Author: mduigou Date: 2013-09-03 15:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/6d7f27953da6 8024200: handle hg wrapper with space after #! Reviewed-by: tbell ! common/bin/hgforest.sh Changeset: 73355c4c1bc8 Author: lana Date: 2013-09-06 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/73355c4c1bc8 Merge Changeset: 67f64101616e Author: mduigou Date: 2013-09-13 12:06 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/67f64101616e 8024201: Update bugdatabase url Reviewed-by: wetmore ! make/scripts/webrev.ksh Changeset: 4bf059350c51 Author: lana Date: 2013-09-17 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/4bf059350c51 Merge From lana.steuck at oracle.com Tue Sep 17 17:00:12 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 18 Sep 2013 00:00:12 +0000 Subject: hg: jdk8/jdk8/corba: 3 new changesets Message-ID: <20130918000017.92DEB628D6@hg.openjdk.java.net> Changeset: af8e5bc3a150 Author: coffeys Date: 2013-09-03 22:35 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/af8e5bc3a150 8017195: Introduce option to setKeepAlive parameter on CORBA sockets Reviewed-by: chegar, msheppar ! src/share/classes/com/sun/corba/se/impl/transport/DefaultSocketFactoryImpl.java Changeset: 4853dc082c7d Author: lana Date: 2013-09-06 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/4853dc082c7d Merge Changeset: a4bb3b450016 Author: lana Date: 2013-09-17 08:08 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/a4bb3b450016 Merge From lana.steuck at oracle.com Tue Sep 17 17:00:22 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 18 Sep 2013 00:00:22 +0000 Subject: hg: jdk8/jdk8/nashorn: 20 new changesets Message-ID: <20130918000046.E9805628D7@hg.openjdk.java.net> Changeset: b5ff11e00050 Author: sundar Date: 2013-09-04 14:29 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/b5ff11e00050 8024120: Setting __proto__ to null removes the __proto__ property Reviewed-by: lagergren, attila ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/resources/mozilla_compat.js ! test/script/basic/JDK-8023368.js ! test/script/basic/JDK-8023368.js.EXPECTED + test/script/basic/JDK-8024120.js ! test/script/basic/circular_proto.js ! test/script/basic/nonextensible_proto_assign.js Changeset: e43ab4062636 Author: sundar Date: 2013-09-04 19:58 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/e43ab4062636 8024174: Setting __proto__ property in Object literal should be supported Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/CodeGenerator.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java + test/script/basic/JDK-8024174.js Changeset: 9e4acaa1bb7e Author: lana Date: 2013-09-06 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/9e4acaa1bb7e Merge Changeset: 7ae169639485 Author: sundar Date: 2013-09-05 21:17 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/7ae169639485 8024255: When a keyword is used as object property name, the property can not be deleted Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8024255.js Changeset: c3b6ce7b74bf Author: sundar Date: 2013-09-09 20:10 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/c3b6ce7b74bf 8024180: Incorrect handling of expression and parent scope in 'with' statements Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/objects/Global.java ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/GlobalObject.java ! src/jdk/nashorn/internal/runtime/NativeJavaPackage.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/WithObject.java ! src/jdk/nashorn/internal/runtime/resources/Messages.properties + test/script/basic/8024180/global_var_delete.js + test/script/basic/8024180/global_var_delete.js.EXPECTED + test/script/basic/8024180/global_var_shadow.js + test/script/basic/8024180/global_var_shadow.js.EXPECTED + test/script/basic/8024180/scope_no_such_prop.js + test/script/basic/8024180/scope_no_such_prop.js.EXPECTED + test/script/basic/8024180/with_expr_prop_add.js + test/script/basic/8024180/with_expr_prop_add.js.EXPECTED + test/script/basic/8024180/with_expr_proto_prop_add.js + test/script/basic/8024180/with_expr_proto_prop_add.js.EXPECTED + test/script/basic/8024180/with_java_object.js + test/script/basic/8024180/with_java_object.js.EXPECTED ! test/src/jdk/nashorn/internal/runtime/ContextTest.java Changeset: 1eca380a221f Author: sundar Date: 2013-09-09 20:16 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/1eca380a221f Merge Changeset: b6c7cd8b962b Author: jlaskey Date: 2013-09-09 13:35 -0300 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/b6c7cd8b962b 8024397: Nashorn FX Libraries need to be finalized. Reviewed-by: sundar, hannesw, lagergren Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/base.js ! src/jdk/nashorn/internal/runtime/resources/fx/fxml.js ! src/jdk/nashorn/internal/runtime/resources/fx/graphics.js ! src/jdk/nashorn/internal/runtime/resources/fx/media.js ! src/jdk/nashorn/internal/runtime/resources/fx/swing.js ! src/jdk/nashorn/internal/runtime/resources/fx/swt.js ! src/jdk/nashorn/internal/runtime/resources/fx/web.js Changeset: 483b42e56da4 Author: jlaskey Date: 2013-09-10 14:21 -0300 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/483b42e56da4 8024539: FX Libraries update missing file Reviewed-by: sundar Contributed-by: james.laskey at oracle.com ! src/jdk/nashorn/internal/runtime/resources/fx/controls.js Changeset: badf750dda21 Author: attila Date: 2013-09-11 10:27 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/badf750dda21 8024130: We no longer need slots for temporaries in self-assign indices Reviewed-by: jlaskey, lagergren ! src/jdk/nashorn/internal/codegen/Attr.java Changeset: 2d4c8fa8a5f4 Author: sundar Date: 2013-09-11 20:49 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/2d4c8fa8a5f4 8024615: Refactor ScriptObjectMirror and JSObject to support external JSObject implementations Reviewed-by: jlaskey, hannesw ! src/jdk/nashorn/api/scripting/JSObject.java ! src/jdk/nashorn/api/scripting/NashornScriptEngine.java ! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/lookup/MethodHandleFactory.java ! src/jdk/nashorn/internal/objects/NativeArray.java ! src/jdk/nashorn/internal/objects/NativeFunction.java ! src/jdk/nashorn/internal/runtime/ScriptRuntime.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayLikeIterator.java ! src/jdk/nashorn/internal/runtime/arrays/IteratorAction.java + src/jdk/nashorn/internal/runtime/arrays/JSObjectIterator.java + src/jdk/nashorn/internal/runtime/arrays/ReverseJSObjectIterator.java - src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectMirrorIterator.java - src/jdk/nashorn/internal/runtime/arrays/ScriptObjectMirrorIterator.java ! src/jdk/nashorn/internal/runtime/linker/Bootstrap.java ! src/jdk/nashorn/internal/runtime/linker/JSObjectLinker.java + test/src/jdk/nashorn/api/scripting/PluggableJSObjectTest.java ! test/src/jdk/nashorn/api/scripting/ScriptObjectMirrorTest.java Changeset: 66db7354e7e2 Author: sundar Date: 2013-09-11 22:51 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/66db7354e7e2 8024644: PluggableJSObject.iteratingJSObjectTest fails with jdk8-tl build Reviewed-by: jlaskey, hannesw ! test/src/jdk/nashorn/api/scripting/PluggableJSObjectTest.java Changeset: aa86166c6770 Author: sundar Date: 2013-09-11 22:53 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/aa86166c6770 Merge - src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectMirrorIterator.java - src/jdk/nashorn/internal/runtime/arrays/ScriptObjectMirrorIterator.java Changeset: e60f6add90d7 Author: hannesw Date: 2013-09-12 14:02 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/e60f6add90d7 8024476: Octane regression on Richards Reviewed-by: sundar, jlaskey ! src/jdk/nashorn/internal/runtime/JSType.java Changeset: 572a2e50ba9e Author: hannesw Date: 2013-09-12 17:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/572a2e50ba9e 8024512: Regex /[^\[]/ doesn't match Reviewed-by: jlaskey, sundar ! src/jdk/nashorn/internal/runtime/regexp/RegExpScanner.java + test/script/basic/JDK-8024512.js + test/script/basic/JDK-8024512.js.EXPECTED Changeset: 917b16e509bd Author: sundar Date: 2013-09-12 22:16 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/917b16e509bd 8024693: Various minor issues with JSONWriter used by script parser API Reviewed-by: jlaskey, hannesw ! make/build.xml ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! test/script/basic/NASHORN-737.js ! test/script/basic/NASHORN-737.js.EXPECTED + test/script/basic/parser/assignmentExpr.js + test/script/basic/parser/assignmentExpr.js.EXPECTED + test/script/basic/parser/binaryExpr.js + test/script/basic/parser/binaryExpr.js.EXPECTED + test/script/basic/parser/breakStat.js + test/script/basic/parser/breakStat.js.EXPECTED + test/script/basic/parser/condExpr.js + test/script/basic/parser/condExpr.js.EXPECTED + test/script/basic/parser/continueStat.js + test/script/basic/parser/continueStat.js.EXPECTED + test/script/basic/parser/debuggerStat.js + test/script/basic/parser/debuggerStat.js.EXPECTED + test/script/basic/parser/functions.js + test/script/basic/parser/functions.js.EXPECTED + test/script/basic/parser/ifStat.js + test/script/basic/parser/ifStat.js.EXPECTED + test/script/basic/parser/labelledStat.js + test/script/basic/parser/labelledStat.js.EXPECTED + test/script/basic/parser/lhsExpr.js + test/script/basic/parser/lhsExpr.js.EXPECTED + test/script/basic/parser/loopStat.js + test/script/basic/parser/loopStat.js.EXPECTED + test/script/basic/parser/objectLitExpr.js + test/script/basic/parser/objectLitExpr.js.EXPECTED + test/script/basic/parser/parenExpr.js + test/script/basic/parser/parenExpr.js.EXPECTED + test/script/basic/parser/primaryExpr.js + test/script/basic/parser/primaryExpr.js.EXPECTED + test/script/basic/parser/returnStat.js + test/script/basic/parser/returnStat.js.EXPECTED + test/script/basic/parser/switchStat.js + test/script/basic/parser/switchStat.js.EXPECTED + test/script/basic/parser/throwStat.js + test/script/basic/parser/throwStat.js.EXPECTED + test/script/basic/parser/tryCatchStat.js + test/script/basic/parser/tryCatchStat.js.EXPECTED + test/script/basic/parser/unaryExpr.js + test/script/basic/parser/unaryExpr.js.EXPECTED + test/script/basic/parser/useStrict.js + test/script/basic/parser/useStrict.js.EXPECTED + test/script/basic/parser/util.js + test/script/basic/parser/varDecl.js + test/script/basic/parser/varDecl.js.EXPECTED + test/script/basic/parser/withStat.js + test/script/basic/parser/withStat.js.EXPECTED Changeset: 8b0914b25430 Author: sundar Date: 2013-09-13 16:45 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/8b0914b25430 8024619: JDBC java.sql.DriverManager is not usable from JS script Reviewed-by: jlaskey, lagergren, attila ! make/build.xml ! src/jdk/nashorn/internal/runtime/Context.java ! src/jdk/nashorn/internal/runtime/NashornLoader.java ! src/jdk/nashorn/internal/runtime/ScriptLoader.java ! src/jdk/nashorn/internal/runtime/StructureLoader.java + test/script/basic/JDK-8024619.js + test/src/META-INF/services/java.sql.Driver + test/src/jdk/nashorn/api/NashornSQLDriver.java Changeset: 5683eca2967a Author: sundar Date: 2013-09-13 17:50 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/5683eca2967a Merge Changeset: 38378024a332 Author: sundar Date: 2013-09-16 15:08 +0530 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/38378024a332 8024847: Java.to should accept mirror and external JSObjects as array-like objects as well Reviewed-by: hannesw, attila, lagergren ! src/jdk/nashorn/internal/objects/NativeJava.java ! src/jdk/nashorn/internal/runtime/ECMAErrors.java + src/jdk/nashorn/internal/runtime/JSObjectListAdapter.java ! src/jdk/nashorn/internal/runtime/JSType.java ! src/jdk/nashorn/internal/runtime/ListAdapter.java + src/jdk/nashorn/internal/runtime/ScriptObjectListAdapter.java ! src/jdk/nashorn/internal/runtime/arrays/ArrayData.java + test/script/basic/JDK-8024847.js + test/script/basic/JDK-8024847.js.EXPECTED Changeset: f1fd5f0bc84c Author: attila Date: 2013-09-16 14:44 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/f1fd5f0bc84c 8024846: keep separate internal arguments variable Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CompilerConstants.java ! src/jdk/nashorn/internal/parser/Parser.java + test/script/basic/JDK-8024846.js Changeset: 445ad3f6d3b4 Author: lana Date: 2013-09-17 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/445ad3f6d3b4 Merge - src/jdk/nashorn/internal/runtime/arrays/ReverseScriptObjectMirrorIterator.java - src/jdk/nashorn/internal/runtime/arrays/ScriptObjectMirrorIterator.java From lana.steuck at oracle.com Tue Sep 17 17:00:35 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 18 Sep 2013 00:00:35 +0000 Subject: hg: jdk8/jdk8/langtools: 38 new changesets Message-ID: <20130918000246.366F6628D8@hg.openjdk.java.net> Changeset: 23f0f3c9c44a Author: jjg Date: 2013-08-29 19:19 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/23f0f3c9c44a 8023833: Replace direct use of AnnotatedType in javadoc code Reviewed-by: darcy ! src/share/classes/com/sun/tools/javadoc/AnnotatedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java Changeset: 240f424cc0d5 Author: jjg Date: 2013-08-30 11:48 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/240f424cc0d5 8023700: Use non breaking space in various labels Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java ! test/com/sun/javadoc/testProfiles/TestProfiles.java Changeset: 3dd40e5715fb Author: jjg Date: 2013-08-30 15:14 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3dd40e5715fb 8024093: Two *.rej files checked in to langtools/test directory Reviewed-by: mchung - test/tools/javac/diags/examples/MrefStat.java.rej - test/tools/javac/diags/examples/MrefStat1.java.rej Changeset: dd64288f5659 Author: bpatel Date: 2013-08-30 15:59 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/dd64288f5659 7198273: RFE : Javadoc Accessibility : Hyperlinks should contain text or an image with alt text Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java ! test/com/sun/javadoc/testNavigation/TestNavigation.java Changeset: 7a2fe98cb0e6 Author: bpatel Date: 2013-08-30 16:16 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7a2fe98cb0e6 8015882: Javadoc prints NPE when using Taglet Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java ! test/com/sun/javadoc/testLegacyTaglet/C.java + test/com/sun/javadoc/testLegacyTaglet/Check.java ! test/com/sun/javadoc/testLegacyTaglet/TestLegacyTaglet.java Changeset: f050c714b556 Author: jjg Date: 2013-08-30 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/f050c714b556 8008367: Sub-packages missing from Profiles javadoc Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java Changeset: b25e387481dc Author: bpatel Date: 2013-08-30 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/b25e387481dc 8022738: doclet should only generate functional interface text if source >= 8 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java + test/com/sun/javadoc/testLambdaFeature/pkg1/FuncInf.java Changeset: 7993cfab8610 Author: jjg Date: 2013-08-30 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7993cfab8610 8015663: Need to supply tests to provide javadoc for profiles support code coverage Reviewed-by: jjg Contributed-by: evgeniya.stepanova at oracle.com ! test/com/sun/javadoc/testProfiles/TestProfiles.java + test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java ! test/com/sun/javadoc/testProfiles/pkg2/Class1Pkg2.java + test/com/sun/javadoc/testProfiles/pkg2/ClassError.java + test/com/sun/javadoc/testProfiles/pkg2/ClassException.java + test/com/sun/javadoc/testProfiles/pkgDeprecated/Class1PkgDeprecated.java + test/com/sun/javadoc/testProfiles/pkgDeprecated/package-info.java ! test/com/sun/javadoc/testProfiles/profile-rtjar-includes.txt Changeset: 4a6acc42c3a1 Author: vromero Date: 2013-09-02 22:38 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/4a6acc42c3a1 8016177: structural most specific and stuckness Reviewed-by: jjg, vromero Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/DeferredAttr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/util/GraphUtils.java ! src/share/classes/com/sun/tools/javac/util/List.java ! test/tools/javac/Diagnostics/compressed/T8012003c.out ! test/tools/javac/diags/examples/BadArgTypesInLambda.java - test/tools/javac/diags/examples/CyclicInference.java ! test/tools/javac/diags/examples/IncompatibleArgTypesInMethodRef.java + test/tools/javac/diags/examples/PotentiallyAmbiguousOverload.java + test/tools/javac/lambda/8016177/T8016177a.java + test/tools/javac/lambda/8016177/T8016177a.out + test/tools/javac/lambda/8016177/T8016177b.java + test/tools/javac/lambda/8016177/T8016177b.out + test/tools/javac/lambda/8016177/T8016177c.java + test/tools/javac/lambda/8016177/T8016177c.out + test/tools/javac/lambda/8016177/T8016177d.java + test/tools/javac/lambda/8016177/T8016177e.java + test/tools/javac/lambda/8016177/T8016177f.java + test/tools/javac/lambda/8016177/T8016177g.java + test/tools/javac/lambda/8016177/T8016177g.out ! test/tools/javac/lambda/BadRecovery.out ! test/tools/javac/lambda/ErroneousLambdaExpr.java + test/tools/javac/lambda/ErroneousLambdaExpr.out ! test/tools/javac/lambda/MethodReference22.out ! test/tools/javac/lambda/MethodReference23.out ! test/tools/javac/lambda/MethodReference41.java + test/tools/javac/lambda/MethodReference41.out ! test/tools/javac/lambda/MethodReference42.java + test/tools/javac/lambda/MethodReference42.out ! test/tools/javac/lambda/MethodReference43.java + test/tools/javac/lambda/MethodReference43.out ! test/tools/javac/lambda/MethodReference44.java + test/tools/javac/lambda/MethodReference44.out ! test/tools/javac/lambda/MethodReference46.java + test/tools/javac/lambda/MethodReference46.out ! test/tools/javac/lambda/MethodReference47.java ! test/tools/javac/lambda/MethodReference47.out ! test/tools/javac/lambda/MethodReference48.java + test/tools/javac/lambda/MethodReference48.out ! test/tools/javac/lambda/MethodReference70.out ! test/tools/javac/lambda/MethodReference71.out ! test/tools/javac/lambda/MostSpecific04.java + test/tools/javac/lambda/MostSpecific04.out ! test/tools/javac/lambda/MostSpecific05.java + test/tools/javac/lambda/MostSpecific05.out ! test/tools/javac/lambda/MostSpecific08.java + test/tools/javac/lambda/MostSpecific08.out ! test/tools/javac/lambda/TargetType01.java + test/tools/javac/lambda/TargetType01.out ! test/tools/javac/lambda/TargetType02.java + test/tools/javac/lambda/TargetType02.out ! test/tools/javac/lambda/TargetType10.java - test/tools/javac/lambda/TargetType10.out ! test/tools/javac/lambda/TargetType21.java ! test/tools/javac/lambda/TargetType21.out ! test/tools/javac/lambda/TargetType24.java ! test/tools/javac/lambda/TargetType24.out ! test/tools/javac/lambda/TargetType26.out ! test/tools/javac/lambda/TargetType27.out ! test/tools/javac/lambda/TargetType39.out ! test/tools/javac/lambda/TargetType43.out ! test/tools/javac/lambda/TargetType66.java ! test/tools/javac/lambda/TargetType66.out ! test/tools/javac/lambda/mostSpecific/StructuralMostSpecificTest.java - test/tools/javac/lambda/typeInference/InferenceTest5.java + test/tools/javac/lambda/typeInference/InferenceTest6.java ! test/tools/javac/lambda/typeInference/InferenceTest_neg1_2.out - test/tools/javac/lambda/typeInference/InferenceTest_neg5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.out ! test/tools/javac/lambda/typeInference/combo/TypeInferenceComboTest.java Changeset: 2bf4c132bf90 Author: vromero Date: 2013-09-02 22:44 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/2bf4c132bf90 8022162: Incorrect signature determination for certain inner class generics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java + test/tools/javac/T8022162/IncorrectSignatureDeterminationForInnerClassesTest.java Changeset: fb5a846c4a49 Author: vromero Date: 2013-09-03 23:31 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/fb5a846c4a49 8023389: Javac fails to infer type for lambda used with intersection type and wildcards Reviewed-by: jjg, vromero Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/lambda/8023389/T8023389.java Changeset: 9be0afbdf244 Author: vromero Date: 2013-09-03 23:41 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/9be0afbdf244 8023545: Misleading error message when using diamond operator with private constructor Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/T8023545/MisleadingErrorMsgDiamondPlusPrivateCtorTest.java + test/tools/javac/T8023545/MisleadingErrorMsgDiamondPlusPrivateCtorTest.out Changeset: 438547d895dc Author: vromero Date: 2013-09-04 00:01 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/438547d895dc 8023549: Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied Reviewed-by: jjg, vromero Contributed-by: maurizio.cimadamore at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/MrefInferAndExplicitParams.java + test/tools/javac/lambda/8023549/T8023549.java + test/tools/javac/lambda/8023549/T8023549.out Changeset: b94824ddcbb6 Author: vromero Date: 2013-09-04 11:53 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/b94824ddcbb6 8008275: javac.Main should be @Supported Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/Main.java Changeset: 044721d4d359 Author: jjg Date: 2013-09-04 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/044721d4d359 8024288: javadoc generated-by comment should always be present Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java ! test/com/sun/javadoc/testGeneratedBy/TestGeneratedBy.java Changeset: a76c663a9cac Author: jfranck Date: 2013-09-05 11:27 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/a76c663a9cac 8023974: Drop 'implements Completer' and 'implements SourceCompleter' from ClassReader resp. JavaCompiler. Reviewed-by: jjg, jfranck Contributed-by: Andreas Lundblad ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javadoc/JavadocTool.java Changeset: e32a8a29643a Author: bpatel Date: 2013-09-05 16:35 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e32a8a29643a 8023608: method grouping tabs folding issue Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testStylesheet/TestStylesheet.java Changeset: 7c7b4aea6d50 Author: vromero Date: 2013-09-06 09:53 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7c7b4aea6d50 8024039: javac, previous solution for JDK-8022186 was incorrect Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java + test/tools/javac/T8024039/NoDeadCodeGenerationOnTrySmtTest.java Changeset: 64328fe5e4a6 Author: jjg Date: 2013-09-06 15:31 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/64328fe5e4a6 8024434: problem running javadoc tests in samevm mode on Windows Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/PathDocFileFactory.java ! test/tools/javadoc/api/basic/APITest.java ! test/tools/javadoc/api/basic/GetTask_FileManagerTest.java Changeset: c9d6f4749f87 Author: lana Date: 2013-09-06 14:20 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/c9d6f4749f87 Merge Changeset: e84587462a47 Author: lana Date: 2013-09-06 17:10 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/e84587462a47 Merge Changeset: 2de3750d65a5 Author: vromero Date: 2013-09-08 11:54 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/2de3750d65a5 8024398: javac, compiler crashes with try with empty body Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/T8024398/NPETryTest.java Changeset: 6cffcd15a17e Author: jfranck Date: 2013-09-09 09:58 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/6cffcd15a17e 8022260: Rename javac.code.Annotations to javac.code.SymbolMetadata Reviewed-by: jfranck, jjg Contributed-by: Andreas Lundblad - src/share/classes/com/sun/tools/javac/code/Annotations.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java + src/share/classes/com/sun/tools/javac/code/SymbolMetadata.java ! test/tools/javac/lib/DPrinter.java Changeset: a4b9a8859e58 Author: vromero Date: 2013-09-09 16:32 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/a4b9a8859e58 8024154: Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests Reviewed-by: jjg, jfranck ! test/tools/javac/lambda/MethodReference41.java ! test/tools/javac/lambda/MethodReference41.out ! test/tools/javac/lambda/MethodReference42.java ! test/tools/javac/lambda/MethodReference42.out ! test/tools/javac/lambda/MethodReference43.java ! test/tools/javac/lambda/MethodReference43.out ! test/tools/javac/lambda/MethodReference44.java ! test/tools/javac/lambda/MethodReference44.out ! test/tools/javac/lambda/MethodReference46.java ! test/tools/javac/lambda/MethodReference46.out ! test/tools/javac/lambda/MethodReference48.java ! test/tools/javac/lambda/MethodReference48.out Changeset: f4efd6ef6e80 Author: emc Date: 2013-09-09 16:26 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/f4efd6ef6e80 8022322: Reject default and static methods in annotation Summary: Causes javac to reject static and default method declarations inside an annotation Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/annotations/neg/NoDefault.java + test/tools/javac/annotations/neg/NoDefault.out + test/tools/javac/annotations/neg/NoDefaultAbstract.java + test/tools/javac/annotations/neg/NoDefaultAbstract.out + test/tools/javac/annotations/neg/NoStatic.java + test/tools/javac/annotations/neg/NoStatic.out + test/tools/javac/annotations/neg/NoStaticAbstract.java + test/tools/javac/annotations/neg/NoStaticAbstract.out Changeset: 67c5110c60fe Author: emc Date: 2013-09-09 17:11 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/67c5110c60fe 8015322: Javac template test framework Summary: Putback of the javac template test framework from the Lambda repository Reviewed-by: jjg Contributed-by: brian.goetz at oracle.com ! README + test/lib/combo/TEST.properties + test/lib/combo/tools/javac/combo/Diagnostics.java + test/lib/combo/tools/javac/combo/JavacTemplateTestBase.java + test/lib/combo/tools/javac/combo/Template.java + test/lib/combo/tools/javac/combo/TemplateTest.java + test/tools/javac/lambda/bridge/template_tests/BridgeMethodTestCase.java + test/tools/javac/lambda/bridge/template_tests/BridgeMethodsTemplateTest.java + test/tools/javac/lambda/bridge/template_tests/TEST.properties Changeset: 7439356a7dc5 Author: jjg Date: 2013-09-09 17:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/7439356a7dc5 8006972: jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java Reviewed-by: darcy ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.ref Changeset: 77d395862700 Author: jlahoda Date: 2013-09-09 23:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/77d395862700 8019521: Enhanced rethrow disabled in lambdas Summary: Fixing effectively final detection inside lambdas, small cleanup related to thrown types detection in lambdas Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/lambda/EffectivelyFinalThrows.java Changeset: bb7271e64ef6 Author: jfranck Date: 2013-09-10 13:47 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/bb7271e64ef6 8005222: Fixed bugs should have tests with bugid in @bug tag Reviewed-by: jfranck, jjg Contributed-by: Andreas Lundblad ! test/tools/javac/defaultMethods/ClassReaderTest/ClassReaderTest.java ! test/tools/javac/defaultMethods/Neg01.java ! test/tools/javac/defaultMethods/Neg02.java ! test/tools/javac/defaultMethods/Neg03.java ! test/tools/javac/defaultMethods/Neg04.java ! test/tools/javac/defaultMethods/Neg05.java ! test/tools/javac/defaultMethods/Neg06.java ! test/tools/javac/defaultMethods/Neg07.java ! test/tools/javac/defaultMethods/Neg08.java ! test/tools/javac/defaultMethods/Neg09.java ! test/tools/javac/defaultMethods/Neg10.java ! test/tools/javac/defaultMethods/Neg11.java ! test/tools/javac/defaultMethods/Neg12.java ! test/tools/javac/defaultMethods/Neg13.java ! test/tools/javac/defaultMethods/Neg14.java ! test/tools/javac/defaultMethods/Neg15.java ! test/tools/javac/defaultMethods/Neg16.java ! test/tools/javac/defaultMethods/Pos01.java ! test/tools/javac/defaultMethods/Pos02.java ! test/tools/javac/defaultMethods/Pos04.java ! test/tools/javac/defaultMethods/Pos05.java ! test/tools/javac/defaultMethods/Pos06.java ! test/tools/javac/defaultMethods/Pos07.java ! test/tools/javac/defaultMethods/Pos08.java ! test/tools/javac/defaultMethods/Pos10.java ! test/tools/javac/defaultMethods/Pos11.java ! test/tools/javac/defaultMethods/Pos12.java ! test/tools/javac/defaultMethods/Pos13.java ! test/tools/javac/defaultMethods/Pos14.java ! test/tools/javac/defaultMethods/Pos15.java ! test/tools/javac/defaultMethods/Pos16.java ! test/tools/javac/defaultMethods/TestDefaultBody.java ! test/tools/javac/defaultMethods/TestNoBridgeOnDefaults.java ! test/tools/javac/defaultMethods/crossCompile/CrossCompile.java ! test/tools/javac/defaultMethods/separate/Separate.java ! test/tools/javac/defaultMethods/super/TestDefaultSuperCall.java ! test/tools/javac/lambda/EffectivelyFinalTest.java Changeset: d87f017ec217 Author: mcimadamore Date: 2013-09-10 16:47 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/d87f017ec217 8024414: javac, should facilitate the use of the bootstrap compiler for debugging Reviewed-by: jjg ! make/netbeans/langtools/build.xml ! make/tools/anttasks/SelectToolTask.java Changeset: 65c218b25b61 Author: emc Date: 2013-09-11 08:30 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/65c218b25b61 8024510: lib/combo/tools/javac/combo/TemplateTest.java fails Summary: Edit regex in Template to allow "MAJOR." pattern. Reviewed-by: briangoetz ! test/lib/combo/tools/javac/combo/Template.java Changeset: cf37c3775397 Author: bpatel Date: 2013-09-11 14:50 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/cf37c3775397 8015496: Information that package is deprecated is missing in profiles view Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileIndexFrameWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/ProfileWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java ! test/com/sun/javadoc/testProfiles/TestProfilesConfiguration.java + test/com/sun/javadoc/testProfiles/profile-rtjar-includes-nopkgs.txt Changeset: 5d2d484a1216 Author: emc Date: 2013-09-12 14:52 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/5d2d484a1216 8013846: javac fails to reject semantically equivalent generic method declarations Summary: Cause javac to consider intersection types with the same elements to be equal regardless of order. Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/neg/OrderedIntersections.java + test/tools/javac/generics/neg/OrderedIntersections.out Changeset: 3ae1814f7c59 Author: vromero Date: 2013-09-12 22:40 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/3ae1814f7c59 8023558: Javac creates invalid bootstrap methods for complex lambda/methodref case Reviewed-by: jjg Contributed-by: maurizio.cimadamore at oracle.com, vicente.romero at oracle.com ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/lambda/8023558/T8023558a.java + test/tools/javac/lambda/8023558/T8023558b.java + test/tools/javac/lambda/8023558/T8023558c.java Changeset: 03c26c60499c Author: vromero Date: 2013-09-14 15:23 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/03c26c60499c 8024207: javac crash in Flow.AssignAnalyzer.visitIdent Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/T8024207/FlowCrashTest.java + test/tools/javac/T8024207/FlowCrashTest.out Changeset: 4932bb04c4b8 Author: vromero Date: 2013-09-14 19:04 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/4932bb04c4b8 7047734: javac, the LVT is not generated correctly in several scenarios Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Lint.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/share/classes/com/sun/tools/javac/jvm/Items.java + src/share/classes/com/sun/tools/javac/jvm/LVTRanges.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javac/util/Bits.java + test/tools/javac/flow/AliveRanges.java + test/tools/javac/flow/LVTHarness.java + test/tools/javac/flow/tests/TestCaseConditional.java + test/tools/javac/flow/tests/TestCaseDoLoop.java + test/tools/javac/flow/tests/TestCaseFor.java + test/tools/javac/flow/tests/TestCaseForEach.java + test/tools/javac/flow/tests/TestCaseIf.java + test/tools/javac/flow/tests/TestCaseIfElse.java + test/tools/javac/flow/tests/TestCaseSwitch.java + test/tools/javac/flow/tests/TestCaseTry.java + test/tools/javac/flow/tests/TestCaseWhile.java Changeset: 4ce8148ffc4f Author: jlahoda Date: 2013-09-16 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/4ce8148ffc4f 8021112: Spurious unchecked warning reported by javac 6480588: No way to suppress deprecation warnings when implementing deprecated interface Summary: Fixing DeferredLintHandler configuration, so lint warnings are reported with correct @SuppressWarnings settings Reviewed-by: jjg, vromero ! src/share/classes/com/sun/tools/javac/code/DeferredLintHandler.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! test/tools/javac/depDocComment/SuppressDeprecation.out ! test/tools/javac/warnings/6594914/T6594914a.out ! test/tools/javac/warnings/6594914/T6594914b.out + test/tools/javac/warnings/suppress/ImplicitTest.java + test/tools/javac/warnings/suppress/ImplicitTest.out + test/tools/javac/warnings/suppress/PackageInfo.java + test/tools/javac/warnings/suppress/PackageInfo.out + test/tools/javac/warnings/suppress/T6480588.java + test/tools/javac/warnings/suppress/T6480588.out + test/tools/javac/warnings/suppress/T8021112a.java + test/tools/javac/warnings/suppress/T8021112b.java + test/tools/javac/warnings/suppress/T8021112b.out + test/tools/javac/warnings/suppress/TypeAnnotations.java + test/tools/javac/warnings/suppress/TypeAnnotations.out + test/tools/javac/warnings/suppress/VerifySuppressWarnings.java + test/tools/javac/warnings/suppress/pack/DeprecatedClass.java + test/tools/javac/warnings/suppress/pack/ImplicitMain.java + test/tools/javac/warnings/suppress/pack/ImplicitUse.java + test/tools/javac/warnings/suppress/pack/package-info.java Changeset: 252f872b8a2f Author: lana Date: 2013-09-17 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/252f872b8a2f Merge - src/share/classes/com/sun/tools/javac/code/Annotations.java - test/tools/javac/diags/examples/CyclicInference.java - test/tools/javac/diags/examples/MrefStat.java.rej - test/tools/javac/diags/examples/MrefStat1.java.rej - test/tools/javac/lambda/TargetType10.out - test/tools/javac/lambda/typeInference/InferenceTest5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.java - test/tools/javac/lambda/typeInference/InferenceTest_neg5.out From lana.steuck at oracle.com Tue Sep 17 17:02:04 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Wed, 18 Sep 2013 00:02:04 +0000 Subject: hg: jdk8/jdk8/jdk: 92 new changesets Message-ID: <20130918003125.06322628D9@hg.openjdk.java.net> Changeset: 12ac08d79c9b Author: vadim Date: 2013-08-23 14:13 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/12ac08d79c9b 8023052: JVM crash in native layout Reviewed-by: bae, prr ! src/share/native/sun/font/layout/SunLayoutEngine.cpp Changeset: b5c5cff52455 Author: lana Date: 2013-08-28 08:59 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b5c5cff52455 Merge Changeset: 7da90f645a63 Author: jgodinez Date: 2013-08-30 09:10 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7da90f645a63 8017469: [macosx] Printing problem using ja and zh_CN locales Reviewed-by: prr, jchen ! src/macosx/native/sun/awt/CTextPipe.m Changeset: dc09174469ef Author: prr Date: 2013-08-30 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/dc09174469ef 4673406: RFE: Java Printing: Provide a way to display win32 printer driver's dialog Reviewed-by: jgodinez, bae + src/share/classes/sun/print/DocumentPropertiesUI.java + src/share/classes/sun/print/PrinterJobWrapper.java ! src/share/classes/sun/print/RasterPrinterJob.java ! src/share/classes/sun/print/ServiceDialog.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! src/windows/classes/sun/print/Win32MediaTray.java ! src/windows/classes/sun/print/Win32PrintService.java ! src/windows/native/sun/windows/awt_PrintControl.cpp ! src/windows/native/sun/windows/awt_PrintControl.h ! src/windows/native/sun/windows/awt_PrintJob.cpp Changeset: 2114b624bf63 Author: ceisserer Date: 2013-09-01 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2114b624bf63 7189452: XRender pipeline does ignore source-surface offset for text rendering Reviewed-by: prr, bae ! src/solaris/classes/sun/font/XRTextRenderer.java ! src/solaris/classes/sun/java2d/xr/XRBackendNative.java ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: a07c907a82b5 Author: bae Date: 2013-09-04 12:10 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a07c907a82b5 7043064: sun/java2d/cmm/ tests failed against RI b141 & b138-nightly Reviewed-by: prr, vadim ! make/sun/cmm/lcms/mapfile-vers ! makefiles/mapfiles/liblcms/mapfile-vers ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/awt/color/ICC_ProfileGray.java ! src/share/classes/java/awt/color/ICC_ProfileRGB.java ! src/share/classes/sun/java2d/cmm/CMSManager.java ! src/share/classes/sun/java2d/cmm/PCMM.java + src/share/classes/sun/java2d/cmm/Profile.java ! src/share/classes/sun/java2d/cmm/lcms/LCMS.java + src/share/classes/sun/java2d/cmm/lcms/LCMSProfile.java ! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/share/native/sun/java2d/cmm/lcms/LCMS.c ! test/sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java Changeset: c561115d697d Author: ceisserer Date: 2013-09-04 12:38 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c561115d697d 7159455: Nimbus scrollbar rendering glitch with xrender enabled on i945GM Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRPMBlitLoops.java Changeset: 0a317fc785fb Author: ceisserer Date: 2013-09-05 11:50 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0a317fc785fb 8024261: xrender: improve performance of small fillRect operations Reviewed-by: prr, bae ! src/solaris/classes/sun/java2d/xr/XRCompositeManager.java Changeset: 2d223e1a9706 Author: lana Date: 2013-09-06 18:25 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2d223e1a9706 Merge - src/share/classes/sun/misc/Compare.java - src/share/classes/sun/misc/Sort.java Changeset: 08296c2d4c68 Author: bae Date: 2013-09-10 21:54 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/08296c2d4c68 8024511: Crash during color profile destruction Reviewed-by: vadim, prr ! src/share/native/sun/java2d/cmm/lcms/LCMS.c + test/sun/java2d/cmm/ProfileOp/DisposalCrashTest.java Changeset: 1579407c0a82 Author: bae Date: 2013-09-13 20:28 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1579407c0a82 8024697: Fix for 8020983 causes Xcheck:jni warnings Reviewed-by: prr, jchen ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! test/javax/imageio/plugins/jpeg/JpegWriterLeakTest.java Changeset: da6cd0247b27 Author: lana Date: 2013-09-17 08:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/da6cd0247b27 Merge Changeset: cdf68747b0fb Author: xuelei Date: 2013-08-29 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cdf68747b0fb 8023881: IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII Reviewed-by: michaelm ! src/share/classes/java/net/IDN.java + test/java/net/IDN/UseSTD3ASCIIRules.java Changeset: 2d51653d9b4b Author: sjiang Date: 2013-08-30 12:49 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2d51653d9b4b 6566891: RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed Reviewed-by: egahlin, jbachorik, dfuchs, dholmes ! src/share/classes/javax/management/remote/rmi/RMIConnector.java + test/javax/management/remote/mandatory/connection/RMIConnectorInternalMapTest.java + test/javax/management/remote/mandatory/connection/RMIConnectorNullSubjectConnTest.java Changeset: 5b01c851bb1d Author: dxu Date: 2013-08-30 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5b01c851bb1d 8023765: Improve MaxPathLength.java testcase and reduce its test load 7160013: java/io/File/MaxPathLength.java fails Reviewed-by: alanb ! test/ProblemList.txt ! test/java/io/File/MaxPathLength.java Changeset: ead6babac5a9 Author: xuelei Date: 2013-09-01 20:00 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ead6babac5a9 8024068: sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails Reviewed-by: weijun ! test/sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java Changeset: 441da45931fa Author: chegar Date: 2013-09-02 14:02 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/441da45931fa 8024103: AtomicLongArray getAndAccumulate/accumulateAndGet have int type for new value arg Reviewed-by: alanb, psandoz ! src/share/classes/java/util/concurrent/atomic/AtomicLongArray.java Changeset: 92d594a938ff Author: dfuchs Date: 2013-09-02 18:28 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/92d594a938ff 8016127: NLS: logging.properties translatability recommendation 8024131: Issues with cached localizedLevelName in java.util.logging.Level Summary: This fix updates logging.properties resource bundles to follow internationalization guidelines. It also fixes a caching issue with localizedLevelName. The regression test that was added needs both fixes to pass. Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/Level.java ! src/share/classes/sun/util/logging/resources/logging.properties ! src/share/classes/sun/util/logging/resources/logging_de.properties ! src/share/classes/sun/util/logging/resources/logging_es.properties ! src/share/classes/sun/util/logging/resources/logging_fr.properties ! src/share/classes/sun/util/logging/resources/logging_it.properties ! src/share/classes/sun/util/logging/resources/logging_ja.properties ! src/share/classes/sun/util/logging/resources/logging_ko.properties ! src/share/classes/sun/util/logging/resources/logging_pt_BR.properties ! src/share/classes/sun/util/logging/resources/logging_sv.properties ! src/share/classes/sun/util/logging/resources/logging_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_zh_TW.properties + test/java/util/logging/LocalizedLevelName.java Changeset: a7d463f5a5b9 Author: egahlin Date: 2013-09-02 16:03 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a7d463f5a5b9 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing Reviewed-by: mchung, mfang ! src/share/classes/sun/tools/jconsole/Resources.java ! test/ProblemList.txt - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh ! test/sun/tools/jconsole/ResourceCheckTest.java ! test/sun/tools/jconsole/ResourceCheckTest.sh Changeset: 4bdbe25b1e04 Author: mduigou Date: 2013-09-03 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4bdbe25b1e04 8024015: TEST.groups: move jdk/lambda tests from jdk_other to jdk_lang Reviewed-by: alanb, mchung ! test/TEST.groups Changeset: 77a8c4ad516c Author: henryjen Date: 2013-08-28 14:13 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/77a8c4ad516c 8022176: Weaken contract of java.lang.AutoCloseable Reviewed-by: alanb, martin, mduigou, psandoz Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/lang/AutoCloseable.java Changeset: 3db3ae4e0853 Author: henryjen Date: 2013-09-03 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3db3ae4e0853 8024178: Difference in Stream.collect(Collector) methods located in jdk8 and jdk8-lambda repos Reviewed-by: mduigou ! src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java Changeset: 2e8d51a5596b Author: henryjen Date: 2013-09-03 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2e8d51a5596b 8017513: Support for closeable streams 8022237: j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification 8022572: Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed Summary: BaseStream implements AutoCloseable; Remove CloseableStream and DelegatingStream Reviewed-by: alanb, mduigou, psandoz Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/util/stream/AbstractPipeline.java ! src/share/classes/java/util/stream/BaseStream.java - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/Streams.java ! test/java/nio/file/Files/StreamTest.java ! test/java/util/stream/bootlib/java/util/stream/DoubleStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/IntStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/LongStreamTestScenario.java ! test/java/util/stream/bootlib/java/util/stream/StreamTestScenario.java + test/java/util/stream/test/org/openjdk/tests/java/util/stream/StreamCloseTest.java Changeset: 5920155dd080 Author: coffeys Date: 2013-09-03 22:37 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5920155dd080 8017195: Introduce option to setKeepAlive parameter on CORBA sockets Reviewed-by: chegar, msheppar + test/com/sun/corba/transport/KeepAliveSockets.java Changeset: 06b01083ebd7 Author: henryjen Date: 2013-09-03 16:05 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/06b01083ebd7 8023997: j.l.String.join(java.lang.CharSequence, java.lang.Iterable) sample doesn't compile and is incorrect Reviewed-by: alanb ! src/share/classes/java/lang/String.java Changeset: 2cdd1078f45b Author: dholmes Date: 2013-09-03 23:47 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2cdd1078f45b 8024140: [TESTBUG] Profile based regression test groups for jdk repo Reviewed-by: alanb, chegar ! test/TEST.groups Changeset: 4bdbd1fabea4 Author: rfield Date: 2013-09-03 21:42 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4bdbd1fabea4 8008688: Make MethodHandleInfo public Summary: A major overhaul to MethodHandleInfo and method handles in general. Reviewed-by: vlivanov, twisti Contributed-by: john.r.rose at oracle.com ! src/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java + src/share/classes/java/lang/invoke/InfoFromMemberName.java ! src/share/classes/java/lang/invoke/Invokers.java ! src/share/classes/java/lang/invoke/MemberName.java ! src/share/classes/java/lang/invoke/MethodHandle.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/SerializedLambda.java ! test/java/lang/invoke/7087570/Test7087570.java + test/java/lang/invoke/RevealDirectTest.java + test/java/lang/invoke/jtreg.security.policy Changeset: 462c5589bc1a Author: psandoz Date: 2013-08-12 12:22 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/462c5589bc1a 8024182: test/java/util/Arrays/SetAllTest.java fails to compile due to recent compiler changes Summary: Use explicit lambda due to javac simplfying rules for overload resolution with implicit lambdas Reviewed-by: alanb, mduigou ! test/java/util/Arrays/SetAllTest.java Changeset: d62c911aebbb Author: psandoz Date: 2013-09-04 09:34 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d62c911aebbb 8023463: Improvements to HashMap/LinkedHashMap use of bins/buckets and trees (red/black) 8012913: LinkedHashMap key/value/entry spliterators should report ORDERED Reviewed-by: mduigou, forax, bchristi, alanb Contributed-by: Doug Lea
, Paul Sandoz ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/LinkedHashMap.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/util/Map/CheckRandomHashSeed.java ! test/java/util/Map/InPlaceOpsCollisions.java + test/java/util/Map/MapBinToFromTreeTest.java - test/java/util/Map/TreeBinSplitBackToEntries.java ! test/java/util/Spliterator/SpliteratorCharacteristics.java Changeset: 336784cd60c3 Author: alanb Date: 2013-09-04 11:40 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/336784cd60c3 8008981: Deprecate SecurityManager checkTopLevelWindow, checkSystemClipboardAccess, checkAwtEventQueueAccess Reviewed-by: anthony, art, mchung ! src/macosx/classes/sun/lwawt/LWToolkit.java ! src/share/classes/java/awt/TextComponent.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/sun/applet/AppletSecurity.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/windows/classes/sun/awt/windows/WToolkit.java + test/java/awt/security/Permissions.java Changeset: ac6e99af2056 Author: dfuchs Date: 2013-09-04 15:32 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ac6e99af2056 6823527: java.util.logging.Handler has thread safety issues Reviewed-by: dholmes, mchung ! src/share/classes/java/util/logging/ConsoleHandler.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/SocketHandler.java ! src/share/classes/java/util/logging/StreamHandler.java Changeset: b3d6953b9829 Author: dfuchs Date: 2013-09-04 16:22 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b3d6953b9829 8019853: Break logging and AWT circular dependency Summary: Break logging and AWT circular dependency, which was at the root cause for 8023258 - Logger.getLogger() after ImageIO.read() returns different logger instance Reviewed-by: mchung, art ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/misc/JavaAWTAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! test/java/util/logging/TestAppletLoggerContext.java + test/java/util/logging/TestLoggingWithMainAppContext.java Changeset: 478afc30679b Author: sherman Date: 2013-09-04 12:35 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/478afc30679b 6341345: (spec) Console.reader() should make it clear that the reader requires line termination Summary: to clarify the spec Reviewed-by: alanb ! src/share/classes/java/io/Console.java Changeset: c6a4df06d57e Author: sherman Date: 2013-09-04 12:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c6a4df06d57e 7186632: NLS t13y issue on jar.properties file Summary: to remove the redundant backslash Reviewed-by: naoto ! src/share/classes/sun/tools/jar/resources/jar.properties Changeset: bd6fcc5eebb8 Author: rfield Date: 2013-09-04 19:47 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/bd6fcc5eebb8 8020816: Metafactory crashes on code with method reference 8021050: MethodHandleInfo throws exception when method handle is to a method with @CallerSensitive Summary: Fixed by 8008688 - this is a test to confirm the above fixed Reviewed-by: vlivanov + test/jdk/lambda/MethodReferenceTestCallerSensitive.java Changeset: af1b08ff48ae Author: jbachorik Date: 2013-09-05 13:04 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/af1b08ff48ae 8023464: test/closed/sun/tracing/ProviderProxyTest.java failing Summary: Don't rely on assertions when an Exception suits better Reviewed-by: alanb, dfuchs, sjiang ! src/share/classes/sun/tracing/ProviderSkeleton.java Changeset: 9522b5e836d3 Author: jbachorik Date: 2013-09-05 14:34 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/9522b5e836d3 8004179: Few of test/java/lang/management/ThreadMXBean/* tests don't clean up the created threads Summary: Just run those tests in "othervm" mode. Reviewed-by: alanb, dfuchs, sjiang ! test/java/lang/management/ThreadMXBean/LockedMonitors.java ! test/java/lang/management/ThreadMXBean/LockedSynchronizers.java ! test/java/lang/management/ThreadMXBean/MyOwnSynchronizer.java ! test/java/lang/management/ThreadMXBean/SharedSynchronizer.java ! test/java/lang/management/ThreadMXBean/SynchronizationStatistics.java Changeset: 4c711ef41bfa Author: naoto Date: 2013-09-05 10:14 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4c711ef41bfa 8023943: Method description fix for String.toLower/UpperCase() methods Reviewed-by: okutsu ! src/share/classes/java/lang/String.java Changeset: 9cc74675a854 Author: rfield Date: 2013-09-05 14:58 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/9cc74675a854 8024283: 10 nashorn tests fail with similar stack trace InternalError with cause being NoClassDefFoundError Summary: Fix pre-existing 292 bug tickled by combo of nashorn code and MethodHandleInfo changes Reviewed-by: jrose Contributed-by: vladimir.x.ivanov at oracle.com ! src/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java Changeset: f2487bb0c0d2 Author: rfield Date: 2013-09-06 00:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f2487bb0c0d2 8024260: 10 closed/java/lang/invoke/* tests failing after overhaul to MethodHandleInfo Reviewed-by: vlivanov, briangoetz Contributed-by: john.r.rose at oracle.com ! src/share/classes/java/lang/invoke/MethodHandle.java Changeset: da9de6f5cd6f Author: jbachorik Date: 2013-09-06 10:03 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/da9de6f5cd6f 6815130: Intermittent ThreadMXBean/Locks.java test failure Summary: Preventing stale reads from ThreadExecutionSynchronizer.waiting flag Reviewed-by: dholmes, mchung, dfuchs ! test/java/lang/management/ThreadMXBean/Locks.java ! test/java/lang/management/ThreadMXBean/ThreadExecutionSynchronizer.java Changeset: 2064b2077a62 Author: jfranck Date: 2013-09-06 14:20 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/2064b2077a62 5047859: (reflect) Class.getField can't find String[].length Reviewed-by: darcy, mchung ! src/share/classes/java/lang/Class.java + test/java/lang/Class/getField/ArrayLength.java Changeset: 0aba8b6232af Author: mullan Date: 2013-09-06 12:04 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0aba8b6232af 8023362: Don't allow soft-fail behavior if OCSP responder returns "unauthorized" Reviewed-by: vinnie, xuelei ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java + test/java/security/cert/PKIXRevocationChecker/OcspUnauthorized.java Changeset: f23a84a1cf8e Author: mullan Date: 2013-09-06 12:10 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f23a84a1cf8e Merge - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh Changeset: 257de3e3a278 Author: lana Date: 2013-09-06 14:18 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/257de3e3a278 Merge Changeset: 0f47f9f622d9 Author: xuelei Date: 2013-09-07 17:05 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/0f47f9f622d9 7188657: There should be a way to reorder the JSSE ciphers Reviewed-by: weijun, wetmore ! src/share/classes/javax/net/ssl/SSLParameters.java ! src/share/classes/sun/security/ssl/Handshaker.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/ServerHandshaker.java + test/sun/security/ssl/javax/net/ssl/SSLParameters/UseCipherSuitesOrder.java Changeset: 6bfabb71ae1e Author: weijun Date: 2013-09-09 11:08 +0800 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/6bfabb71ae1e 8024046: Test sun/security/krb5/runNameEquals.sh failed on 7u45 Embedded linux-ppc* Reviewed-by: xuelei ! test/sun/security/krb5/runNameEquals.sh Changeset: 4afdf10de648 Author: dfuchs Date: 2013-09-09 13:59 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4afdf10de648 8023168: Cleanup LogManager class initialization and LogManager/LoggerContext relationship 8021003: java/util/logging/Logger/getGlobal/TestGetGlobalConcurrent.java fails intermittently 8019945: test/java/util/logging/LogManagerInstanceTest.java failing intermittently Summary: This fix untangles the class initialization of Logger and LogManager, and also cleans up the relationship between LogManager, LoggerContext, and Logger, which were at the root cause of some intermittent test failures. Reviewed-by: mchung, martin, plevart ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/Logger.java ! test/java/util/logging/Logger/getGlobal/TestGetGlobal.java ! test/java/util/logging/Logger/getGlobal/TestGetGlobalConcurrent.java ! test/java/util/logging/Logger/getGlobal/policy ! test/java/util/logging/ParentLoggersTest.java ! test/java/util/logging/TestAppletLoggerContext.java Changeset: 02064634bc88 Author: msheppar Date: 2013-09-06 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/02064634bc88 8023326: [TESTBUG] java/net/CookieHandler/LocalHostCookie.java misplaced try/finally Summary: amended test to be more robust to set of potential exceptions thrown Reviewed-by: chegar, khazra ! test/java/net/CookieHandler/LocalHostCookie.java Changeset: 4fd7abaf0a5f Author: msheppar Date: 2013-09-09 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4fd7abaf0a5f 8021372: NetworkInterface.getNetworkInterfaces() returns duplicate hardware address Summary: amended src/windows/native/java/net/NetworkInterface_winXP.c to "properly" handle Ipv6IfIndex Reviewed-by: chegar, dsamersoff ! src/windows/native/java/net/NetworkInterface_winXP.c + test/java/net/NetworkInterface/UniqueMacAddressesTest.java Changeset: be0bcd6a904e Author: juh Date: 2013-09-09 10:52 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/be0bcd6a904e 8024432: Fix doclint issues in java.security Reviewed-by: darcy, mullan ! src/share/classes/java/security/AccessController.java ! src/share/classes/java/security/AlgorithmParameters.java ! src/share/classes/java/security/AlgorithmParametersSpi.java ! src/share/classes/java/security/KeyFactory.java ! src/share/classes/java/security/KeyFactorySpi.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/Principal.java ! src/share/classes/java/security/cert/CertPathBuilderSpi.java ! src/share/classes/java/security/cert/CertPathValidatorSpi.java ! src/share/classes/java/security/cert/PKIXRevocationChecker.java ! src/share/classes/java/security/interfaces/RSAMultiPrimePrivateCrtKey.java ! src/share/classes/java/security/interfaces/RSAPrivateCrtKey.java ! src/share/classes/java/security/interfaces/RSAPrivateKey.java ! src/share/classes/java/security/interfaces/RSAPublicKey.java Changeset: 6731ea9123f2 Author: smarks Date: 2013-09-09 14:11 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/6731ea9123f2 8023447: change specification to allow RMI activation to be optional Reviewed-by: darcy, alanb, olagneau ! src/share/classes/java/rmi/activation/Activatable.java ! src/share/classes/java/rmi/activation/ActivationDesc.java ! src/share/classes/java/rmi/activation/ActivationGroup.java ! src/share/classes/java/rmi/activation/ActivationGroupID.java ! src/share/classes/java/rmi/activation/ActivationID.java ! src/share/classes/java/rmi/activation/package.html Changeset: f80b8af9c218 Author: xuelei Date: 2013-09-09 19:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f80b8af9c218 8024444: Change to use othervm mode of tests in SSLEngineImpl Reviewed-by: mullan ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/CloseEngineException.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/CloseInboundException.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/CloseStart.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/DelegatedTaskWrongException.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/EmptyExtensionData.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl/RehandshakeFinished.java Changeset: 909aced59bef Author: alanb Date: 2013-09-10 10:42 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/909aced59bef 8023878: (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently Reviewed-by: alanb Contributed-by: yiming.wang at oracle.com ! test/java/nio/file/WatchService/SensitivityModifier.java Changeset: c9083205e6eb Author: xuelei Date: 2013-09-10 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c9083205e6eb 8024501: sun.security.mscapi.Key has no definition of serialVersionUID Reviewed-by: weijun ! src/windows/classes/sun/security/mscapi/Key.java Changeset: 13ee370ee8b3 Author: okutsu Date: 2013-09-11 15:29 +0900 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/13ee370ee8b3 8024141: Unexpected timezone display name Reviewed-by: peytoia ! src/share/classes/sun/util/locale/provider/LocaleResources.java + test/sun/util/locale/provider/Bug8024141.java Changeset: b271ea30f440 Author: jfranck Date: 2013-09-11 09:45 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b271ea30f440 4987375: (reflect) Class.get{Declared}Method{s} does not return clone() for array types Summary: Update spec to match long standing behavior Reviewed-by: darcy, mchung ! src/share/classes/java/lang/Class.java + test/java/lang/Class/ArrayMethods.java Changeset: 517c5e99fb2f Author: chegar Date: 2013-09-11 11:03 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/517c5e99fb2f 8024508: Fix doclint issues in com.sun.nio.sctp Reviewed-by: alanb ! src/share/classes/com/sun/nio/sctp/Association.java ! src/share/classes/com/sun/nio/sctp/IllegalReceiveException.java ! src/share/classes/com/sun/nio/sctp/IllegalUnbindException.java ! src/share/classes/com/sun/nio/sctp/InvalidStreamException.java ! src/share/classes/com/sun/nio/sctp/MessageInfo.java ! src/share/classes/com/sun/nio/sctp/Notification.java ! src/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/share/classes/com/sun/nio/sctp/SctpServerChannel.java Changeset: d389dedd1ccb Author: chegar Date: 2013-09-11 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/d389dedd1ccb 8023090: Additional debug info for java/net/NetworkInterface/Equals.java Reviewed-by: alanb ! test/java/net/NetworkInterface/Equals.java Changeset: 7bfe3da4fad6 Author: naoto Date: 2013-09-11 05:38 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7bfe3da4fad6 8024332: sun/util/resources/en split between rt.jar and localedata.jar Reviewed-by: alanb, erikj ! make/java/java/genlocales.gmk ! make/java/java/localegen.sh ! make/java/text/base/FILES_java.gmk ! make/java/util/FILES_java.gmk ! make/java/util/FILES_properties.gmk ! make/sun/text/FILES_java.gmk ! make/sun/text/FILES_properties.gmk ! makefiles/CreateJars.gmk ! makefiles/GensrcLocaleDataMetaInfo.gmk ! src/share/classes/sun/util/locale/provider/JRELocaleProviderAdapter.java ! src/share/classes/sun/util/locale/provider/LocaleDataMetaInfo-XLocales.java.template Changeset: c3ef78cd9081 Author: emc Date: 2013-09-11 09:24 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c3ef78cd9081 6962494: Update documentation on Executable.getParameterAnnotations() Summary: Update javadoc comments on getParameterAnnotations to correctly describe its behavior Reviewed-by: darcy, jfranck ! src/share/classes/java/lang/reflect/Executable.java Changeset: 1ec241501e60 Author: michaelm Date: 2013-09-11 15:00 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/1ec241501e60 8024601: Windows networking code prevents use of -Xlint:auxiliaryclass in jdk build Reviewed-by: chegar ! src/share/classes/java/net/AbstractPlainSocketImpl.java + src/share/classes/java/net/InetAddressContainer.java Changeset: 7dcb9d944910 Author: michaelm Date: 2013-09-11 15:02 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/7dcb9d944910 Merge Changeset: 292d93f32aa1 Author: rriggs Date: 2013-09-11 10:16 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/292d93f32aa1 8024164: JSR310 serialization should be described in details Summary: The serialized-form.html should specify the stream format for interoperability Reviewed-by: alanb ! src/share/classes/java/time/Duration.java ! src/share/classes/java/time/Instant.java ! src/share/classes/java/time/LocalDate.java ! src/share/classes/java/time/LocalDateTime.java ! src/share/classes/java/time/LocalTime.java ! src/share/classes/java/time/MonthDay.java ! src/share/classes/java/time/OffsetDateTime.java ! src/share/classes/java/time/OffsetTime.java ! src/share/classes/java/time/Period.java ! src/share/classes/java/time/Ser.java ! src/share/classes/java/time/Year.java ! src/share/classes/java/time/YearMonth.java ! src/share/classes/java/time/ZoneId.java ! src/share/classes/java/time/ZoneOffset.java ! src/share/classes/java/time/ZoneRegion.java ! src/share/classes/java/time/ZonedDateTime.java ! src/share/classes/java/time/chrono/ChronoLocalDateTimeImpl.java ! src/share/classes/java/time/chrono/ChronoZonedDateTimeImpl.java ! src/share/classes/java/time/chrono/Chronology.java ! src/share/classes/java/time/chrono/HijrahChronology.java ! src/share/classes/java/time/chrono/HijrahDate.java ! src/share/classes/java/time/chrono/HijrahEra.java ! src/share/classes/java/time/chrono/IsoChronology.java ! src/share/classes/java/time/chrono/JapaneseChronology.java ! src/share/classes/java/time/chrono/JapaneseDate.java ! src/share/classes/java/time/chrono/JapaneseEra.java ! src/share/classes/java/time/chrono/MinguoChronology.java ! src/share/classes/java/time/chrono/MinguoDate.java ! src/share/classes/java/time/chrono/MinguoEra.java ! src/share/classes/java/time/chrono/Ser.java ! src/share/classes/java/time/chrono/ThaiBuddhistChronology.java ! src/share/classes/java/time/chrono/ThaiBuddhistDate.java ! src/share/classes/java/time/chrono/ThaiBuddhistEra.java ! src/share/classes/java/time/zone/Ser.java ! src/share/classes/java/time/zone/ZoneOffsetTransition.java ! src/share/classes/java/time/zone/ZoneOffsetTransitionRule.java ! src/share/classes/java/time/zone/ZoneRules.java ! test/java/time/tck/java/time/chrono/TCKChronologySerialization.java Changeset: 8b4aef582087 Author: rriggs Date: 2013-09-11 10:35 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/8b4aef582087 Merge Changeset: 60b4cbdb446d Author: sherman Date: 2013-09-11 11:29 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/60b4cbdb446d 8024338: Constant fields introduced by JDK-4759491 fix in b94 are exposed as public fields in public API Summary: to move the new constants out of ZipConstants.java Reviewed-by: martin ! src/share/classes/java/util/zip/ZipConstants.java ! src/share/classes/java/util/zip/ZipConstants64.java ! src/share/classes/java/util/zip/ZipEntry.java Changeset: 70aab3db56de Author: henryjen Date: 2013-09-11 11:25 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/70aab3db56de 8024500: Missing API coverage for java.util.function.BiFunction andThen Reviewed-by: mduigou, alanb + test/java/util/Collections/SingletonIterator.java + test/java/util/function/BiFunction/BiFunctionTest.java Changeset: e407df8093dc Author: sjiang Date: 2013-09-12 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/e407df8093dc 8023529: OpenMBeanInfoSupport.equals/hashCode throw NPE Reviewed-by: dholmes, dfuchs ! src/share/classes/javax/management/openmbean/OpenMBeanInfoSupport.java + test/javax/management/openmbean/OpenMBeanInfoEqualsNPETest.java + test/javax/management/openmbean/OpenMBeanInfoHashCodeNPETest.java Changeset: 262a625809fd Author: darcy Date: 2013-09-12 01:47 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/262a625809fd 8024643: Turn on javac lint checking in building the jdk repo Reviewed-by: erikj, ihse, smarks ! makefiles/Setup.gmk Changeset: 631c8dcd91f4 Author: dfuchs Date: 2013-09-12 17:01 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/631c8dcd91f4 8024525: Make Logger log methods call isLoggable() Summary: This changeset makes the various Logger logging method call isLoggable() instead of inlining the level checks. Reviewed-by: mchung, alanb ! src/share/classes/java/util/logging/Logger.java + test/java/util/logging/Logger/isLoggable/TestIsLoggable.java Changeset: 672f349fbad7 Author: rriggs Date: 2013-09-12 10:58 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/672f349fbad7 8024618: Issues with French locale on compact1,2: expected: but was: Summary: Tests against the data of the French locale are not valid as conformance tests and are redundant with testing of the US Locale above Reviewed-by: alanb ! test/java/time/tck/java/time/format/TCKDateTimeTextPrinting.java Changeset: 60d6f60416ca Author: lancea Date: 2013-09-12 13:20 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/60d6f60416ca 8015340: remove erroneous @since tag Reviewed-by: darcy ! src/share/classes/java/sql/PreparedStatement.java Changeset: be6f5f027bc2 Author: henryjen Date: 2013-09-06 22:20 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/be6f5f027bc2 8011916: Spec update for java.util.stream 8024339: j.u.s.Stream.reduce(BinaryOperator) throws unexpected NPE Reviewed-by: mduigou Contributed-by: brian.goetz at oracle.com ! src/share/classes/java/util/Collection.java ! src/share/classes/java/util/function/package-info.java ! src/share/classes/java/util/stream/BaseStream.java ! src/share/classes/java/util/stream/Collector.java ! src/share/classes/java/util/stream/Collectors.java ! src/share/classes/java/util/stream/DoublePipeline.java ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream/IntPipeline.java ! src/share/classes/java/util/stream/IntStream.java ! src/share/classes/java/util/stream/LongPipeline.java ! src/share/classes/java/util/stream/LongStream.java ! src/share/classes/java/util/stream/PipelineHelper.java ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/StreamSpliterators.java ! src/share/classes/java/util/stream/StreamSupport.java ! src/share/classes/java/util/stream/package-info.java Changeset: 917fffe971c8 Author: bpb Date: 2013-09-11 17:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/917fffe971c8 8010430: Math.round has surprising behavior for odd values of ulp 1 Summary: If the effective floating point exponent is zero return the significand including the implicit 1-bit. Reviewed-by: bpb, darcy, gls Contributed-by: Dmitry Nadezhin ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java ! test/java/lang/Math/RoundTests.java Changeset: ba0b95f310c8 Author: sjiang Date: 2013-09-13 10:48 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ba0b95f310c8 8023669: MBean*Info.hashCode : NPE Reviewed-by: dholmes, dfuchs, jbachorik ! src/share/classes/javax/management/MBeanAttributeInfo.java ! src/share/classes/javax/management/MBeanConstructorInfo.java ! src/share/classes/javax/management/MBeanInfo.java ! src/share/classes/javax/management/MBeanOperationInfo.java ! src/share/classes/javax/management/MBeanParameterInfo.java + test/javax/management/MBeanInfo/MBeanInfoHashCodeNPETest.java Changeset: cc2bae7f8fbb Author: bchristi Date: 2013-09-12 14:22 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/cc2bae7f8fbb 8024009: Remove jdk.map.useRandomSeed system property Summary: Removed usage of hashSeed in Hashtable & WeakHashMap, and removed tests Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/WeakHashMap.java - test/java/util/Map/CheckRandomHashSeed.java ! test/java/util/Map/Collisions.java Changeset: c53411f89b4c Author: msheppar Date: 2013-09-13 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c53411f89b4c 8024675: java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows Summary: amended test to add active, i.e. isUp(), NetworkInterfaces to test list Reviewed-by: alanb, chegar ! test/java/net/NetworkInterface/UniqueMacAddressesTest.java Changeset: c65848f2b6a1 Author: mduigou Date: 2013-09-13 11:18 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/c65848f2b6a1 8021591: Additional explicit null checks Reviewed-by: psandoz, alanb ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/Hashtable.java ! src/share/classes/java/util/IdentityHashMap.java ! src/share/classes/java/util/Map.java ! src/share/classes/java/util/TreeMap.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/javax/security/auth/Subject.java ! test/java/util/Collection/CollectionDefaults.java - test/java/util/Collection/ListDefaults.java ! test/java/util/Collection/MOAT.java ! test/java/util/Collection/testlibrary/CollectionAsserts.java ! test/java/util/Collection/testlibrary/CollectionSupplier.java + test/java/util/Collection/testlibrary/ExtendsAbstractCollection.java + test/java/util/Collection/testlibrary/ExtendsAbstractList.java + test/java/util/Collection/testlibrary/ExtendsAbstractSet.java + test/java/util/List/ListDefaults.java ! test/java/util/Map/Defaults.java Changeset: 973fdd9506b2 Author: mduigou Date: 2013-09-13 11:19 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/973fdd9506b2 8024014: TEST.groups - split sub-groups for jdk_collections, jdk_stream, jdk_concurrent, jdk_util_other from jdk_util Reviewed-by: mchung, dholmes, alanb ! test/TEST.groups Changeset: 5f81a12fed4d Author: bchristi Date: 2013-09-13 11:26 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5f81a12fed4d 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] Summary: On MacOS X set user.home to value of NSHomeDirectory() Reviewed-by: alanb, ddehaven, mduigou ! make/common/Defs-macosx.gmk ! make/java/java/Makefile ! makefiles/CompileNativeLibraries.gmk ! src/solaris/native/java/lang/java_props_macosx.c ! src/solaris/native/java/lang/java_props_macosx.h ! src/solaris/native/java/lang/java_props_md.c Changeset: 5c7690923663 Author: lancea Date: 2013-09-13 19:10 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5c7690923663 8014967: EBehavior of DriverManager.registerDriver(dr) is unspecified if driver is null Reviewed-by: alanb ! src/share/classes/java/sql/DriverManager.java Changeset: a7980b099af1 Author: henryjen Date: 2013-09-06 15:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a7980b099af1 8024825: Some fixes are missing from java.util.stream spec update Reviewed-by: mduigou ! src/share/classes/java/util/stream/ReferencePipeline.java ! src/share/classes/java/util/stream/Stream.java ! src/share/classes/java/util/stream/package-info.java Changeset: 3255a4e348a1 Author: rriggs Date: 2013-09-14 13:55 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/3255a4e348a1 8023639: Difference between LocalTime.now(Clock.systemDefaultZone()) and LocalTime.now() executed successively is more than 100 000 000 nanoseconds for slow machines Summary: Test timed out on a slow machine; it is not a conformance test and should be in the test subtree Reviewed-by: darcy, sherman ! test/java/time/tck/java/time/TCKLocalTime.java ! test/java/time/test/java/time/TestLocalTime.java Changeset: 35bb1c7f227c Author: rriggs Date: 2013-09-14 13:55 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/35bb1c7f227c 8023556: Update javadoc for start of Meiji era Summary: correct the javadoc in JapaneseEra.MEIJI to match the implementation Reviewed-by: darcy, sherman ! src/share/classes/java/time/chrono/JapaneseEra.java ! test/java/time/test/java/time/TestLocalTime.java Changeset: ff6c76f7733e Author: psandoz Date: 2013-09-02 11:59 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ff6c76f7733e 8010293: java/util/concurrent/ConcurrentHashMap/toArray.java fails intermittently Reviewed-by: forax, chegar, alanb Contributed-by: Doug Lea
, Peter Levart , Paul Sandoz ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! test/java/util/concurrent/ConcurrentHashMap/toArray.java Changeset: 5025ed287a4a Author: psandoz Date: 2013-09-15 16:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5025ed287a4a 8024837: Rename java/util/concurrent/ConcurrentHashMap/toArray.java to ToArray.java Reviewed-by: alanb ! test/java/util/concurrent/ConcurrentHashMap/ToArray.java < test/java/util/concurrent/ConcurrentHashMap/toArray.java Changeset: b9d59414de23 Author: sherman Date: 2013-09-15 11:16 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/b9d59414de23 7186311: (props) "Unicode" is misspelled as "Uniocde" in JavaDoc and error message Summary: to correct the typo Reviewed-by: alanb, chegar ! make/tools/src/build/tools/generatecharacter/CharacterName.java ! src/share/classes/java/util/Properties.java Changeset: efa09bf27d39 Author: sherman Date: 2013-09-15 13:58 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/efa09bf27d39 8020687: Deflater.setLevel does not work as expected Summary: to clarify the api to match the existing implementation behavior Reviewed-by: alanb ! src/share/classes/java/util/zip/Deflater.java Changeset: db0fc2b71298 Author: msheppar Date: 2013-09-16 14:51 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/db0fc2b71298 6458027: Disabling IPv6 on a specific network interface causes problems Summary: added a check to test if an interface is configured for IPv6 to native code TwoStacklainDatagramSocketImpl: getMulticastInterface, setMulticastInterface Reviewed-by: chegar, michaelm ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c + test/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java Changeset: 86aa8e7503e9 Author: henryjen Date: 2013-09-16 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/86aa8e7503e9 8024874: Copy-paste typo in the spec for j.u.Comparator.thenComparing(Function, Comparator) Reviewed-by: mduigou ! src/share/classes/java/util/Comparator.java Changeset: 657482758408 Author: lancea Date: 2013-09-17 07:56 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/657482758408 7097386: Correct error in Predicate javadoc example Reviewed-by: alanb, shade ! src/share/classes/javax/sql/rowset/Predicate.java Changeset: ebc44e50df79 Author: lana Date: 2013-09-17 08:16 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ebc44e50df79 Merge - src/share/classes/java/util/stream/CloseableStream.java - src/share/classes/java/util/stream/DelegatingStream.java ! test/ProblemList.txt - test/java/util/Collection/ListDefaults.java - test/java/util/Map/CheckRandomHashSeed.java - test/java/util/Map/TreeBinSplitBackToEntries.java - test/java/util/concurrent/ConcurrentHashMap/toArray.java - test/sun/tools/jconsole/ImmutableResourceTest.java - test/sun/tools/jconsole/ImmutableResourceTest.sh From lana.steuck at oracle.com Tue Sep 17 17:50:44 2013 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Tue, 17 Sep 2013 17:50:44 -0700 (PDT) Subject: jdk8-b108: JSN, Tools, Core Libraries, Serviceability, 2d, Awt, and Swing Message-ID: <201309180050.r8I0oinn004811@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk8/jdk8/rev/4bf059350c51 http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/445ad3f6d3b4 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/252f872b8a2f http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ebc44e50df79 http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/d1ea68556fd7 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/8ade3eed63da http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/9cd0183fe325 http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/a4bb3b450016 --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-8024697 client-libs Fix for 8020983 causes Xcheck:jni warnings JDK-8024511 client-libs Crash during color profile destruction JDK-8024261 client-libs xrender: improve performance of small fillRect operations JDK-8023577 client-libs closed/sun/java2d/SunGraphics2D/CoordinateTruncationBug.java failed on linux JDK-8023097 client-libs t2k.dll crash in T2KFontScaler.getGlyphMetricsNative with NaN rotation JDK-8023052 client-libs JVM crash in native layout JDK-8017469 client-libs [macosx] Printing problem using ja and zh_CN locales JDK-7189452 client-libs XRender pipeline does ignore source-surface offset for text rendering JDK-7159455 client-libs Nimbus scrollbar rendering glitch with xrender enabled on i945GM JDK-7043064 client-libs sun/java2d/cmm/ tests failed against RI b141 & b138-nightly JDK-4673406 client-libs RFE: Java Printing: Provide a way to display win32 printer driver's dialog JDK-8024874 core-libs Copy-paste typo in the spec for j.u.Comparator.thenComparing(Function, Comparator) JDK-8024847 core-libs Java.to should accept mirror and external JSObjects as array-like objects as well JDK-8024846 core-libs VerifyError on valid code - arguments initialized as a local var confuses codegenerator JDK-8024837 core-libs Rename java/util/concurrent/ConcurrentHashMap/toArray.java to ToArray.java JDK-8024825 core-libs Some fixes are missing from java.util.stream spec update JDK-8024693 core-libs Various minor issues with JSONWriter used by script parser API JDK-8024675 core-libs java/net/NetworkInterface/UniqueMacAddressesTest.java fails on Windows JDK-8024644 core-libs PluggableJSObject.iteratingJSObjectTest fails with jdk8-tl build JDK-8024619 core-libs JDBC java.sql.DriverManager is not usable from JS script JDK-8024618 core-libs Issues with French locale on compact1,2: expected: but was: JDK-8024615 core-libs Refactor ScriptObjectMirror and JSObject to support external JSObject implementations JDK-8024601 core-libs Windows networking code prevents use of -Xlint:auxiliaryclass in jdk build JDK-8024539 core-libs FX Libraries update missing file JDK-8024525 core-libs Make Logger log methods call isLoggable() JDK-8024512 core-libs Regex /[^\[]/ doesn't match JDK-8024508 core-libs Fix doclint issues in com.sun.nio.sctp JDK-8024500 core-libs Missing API coverage for java.util.function.BiFunction andThen JDK-8024476 core-libs Octane regression on Richards JDK-8024397 core-libs Nashorn FX Libraries need to be finalized. JDK-8024339 core-libs j.u.s.Stream.reduce(BinaryOperator) throws unexpected NPE JDK-8024338 core-libs Constant fields introduced by JDK-4759491 fix in b94 are exposed as public fields in public API JDK-8024332 core-libs sun/util/resources/en split between rt.jar and localedata.jar JDK-8024283 core-libs 10 nashorn tests fail with similar stack trace InternalError with cause being NoClassDefFoundError JDK-8024260 core-libs closed/java/lang/invoke/* tests failing after overhaul to MethodHandleInfo JDK-8024255 core-libs When a keyword is used as object property name, the property can not be deleted JDK-8024182 core-libs test/java/util/Arrays/SetAllTest.java fails to compile due to recent compiler changes JDK-8024180 core-libs Incorrect handling of expression and parent scope in 'with' statements JDK-8024178 core-libs Difference in Stream.collect(Collector) methods located in jdk8 and jdk8-lambda repos JDK-8024174 core-libs Setting __proto__ property in Object literal should be supported JDK-8024164 core-libs JSR310 serialization should be described in details JDK-8024151 core-libs Add timezone displayname file for L10n JDK-8024141 core-libs Unexpected timezone display name JDK-8024131 core-libs Issues with cached localizedLevelName in java.util.logging.Level JDK-8024130 core-libs Do we need to force slots for temporaries in self-assign? JDK-8024120 core-libs Setting __proto__ to null removes the __proto__ property JDK-8024103 core-libs AtomicLongArray getAndAccumulate/accumulateAndGet have int type for new value arg JDK-8024015 core-libs Test.groups move jdk/lambda tests into jdk_lang group JDK-8024014 core-libs TEST.groups separate jdk_collections jdk_concurrent and jdk_streams out of jdk_util JDK-8024009 core-libs Remove jdk.map.useRandomSeed system property JDK-8023997 core-libs j.l.String.join(java.lang.CharSequence, java.lang.Iterable) sample doesn't compile and is incorrect JDK-8023943 core-libs Method description fix for String.toLower/UpperCase() methods JDK-8023881 core-libs IDN.USE_STD3_ASCII_RULES option is too strict to use Unicode in IDN.toASCII JDK-8023878 core-libs (fs) TEST_BUG java/nio/file/WatchService/SensitivityModifier.java fails intermittently JDK-8023765 core-libs Improve MaxPathLength.java testcase and reduce its test load JDK-8023639 core-libs Difference between LocalTime.now(Clock.systemDefaultZone()) and LocalTime.now() executed successively is more than 100 000 000 nanoseconds for slow machines JDK-8023556 core-libs Update javadoc for start of Meiji era JDK-8023463 core-libs Improvements to HashMap/LinkedHashMap use of bins/buckets and trees (red/black) JDK-8023447 core-libs change specification to allow RMI activation to be optional JDK-8023326 core-libs [TESTBUG] java/net/CookieHandler/LocalHostCookie.java misplaced try/finally JDK-8023168 core-libs Cleanup LogManager class initialization and LogManager/LoggerContext relationship JDK-8023090 core-libs Additional debug info for java/net/NetworkInterface/Equals.java JDK-8022572 core-libs Same exception instances thrown from j.u.stream.Stream.onClose() handlers are not listed as suppressed JDK-8022237 core-libs j.u.s.BaseStream.onClose() has an issue in implementation or requires spec clarification JDK-8022176 core-libs Weaken contract of java.lang.AutoCloseable JDK-8021591 core-libs Additional NPE checks JDK-8021372 core-libs NetworkInterface.getNetworkInterfaces() returns duplicate hardware address JDK-8021050 core-libs MethodHandleInfo throws exception when method handle is to a method with @CallerSensitive JDK-8021003 core-libs java/util/logging/Logger/getGlobal/TestGetGlobalConcurrent.java fails intermittently JDK-8020687 core-libs Deflater.setLevel does not work as expected JDK-8019945 core-libs test/java/util/logging/LogManagerInstanceTest.java failing intermittently JDK-8019853 core-libs Break logging and AWT circular dependency JDK-8017513 core-libs Support for closeable streams JDK-8016127 core-libs NLS: logging.properties translatability recommendation JDK-8015340 core-libs Documentation error in java.sql.PreparedStatement#setObject since 1.6 not 1.5 JDK-8014967 core-libs SPEC: Behavior of DriverManager.registerDriver(dr) is unspecified if driver is null JDK-8012913 core-libs LinkedHashMap key/value/entry spliterators should report ORDERED JDK-8011916 core-libs Spec update for java.util.stream JDK-8010430 core-libs Math.round has surprising behavior for odd values of ulp 1 JDK-8010293 core-libs java/util/concurrent/ConcurrentHashMap/toArray.java fails intermittently JDK-8008981 core-libs Deprecate SecurityManager checkTopLevelWindow, checkSystemClipboardAccess, checkAwtEventQueueAccess JDK-8008688 core-libs Make MethodHandleInfo public JDK-7199674 core-libs (props) user.home property does not return an accessible location in sandboxed environment [macosx] JDK-7186311 core-libs (props) "Unicode" is misspelled as "Uniocde" in JavaDoc and error message JDK-7160013 core-libs java/io/File/MaxPathLength.java fails JDK-7097386 core-libs javax.sql.rowset.Predicate documentation wrong algorithm example JDK-6962494 core-libs Update documentation on Executable.getParameterAnnotations() JDK-6823527 core-libs java.util.logging.Handler has thread safety issues JDK-6458027 core-libs Disabling IPv6 on a specific network interface causes problems JDK-6341345 core-libs (spec) Console.reader() should make it clear that the reader requires line termination JDK-5047859 core-libs (reflect) Class.getField can't find String[].length JDK-4987375 core-libs (reflect) Class.get{Declared}Method{s} does not return clone() for array types JDK-8024018 core-svc closed/javax/management/remote/mBeanCreation/MBeanCreationWithPasswdTest.java failed on windows JDK-8023669 core-svc MBean*Info.hashCode : NPE JDK-8023529 core-svc OpenMBeanInfoSupport.equals/hashCode throw NPE JDK-8023464 core-svc test/closed/sun/tracing/ProviderProxyTest.java failing JDK-8004179 core-svc Few of test/java/lang/management/ThreadMXBean/* tests don't clean up the created threads JDK-6815130 core-svc Intermittent ThreadMXBean/Locks.java test failure JDK-6566891 core-svc RMIConnector: map value referencing map key in WeakHashMap prevents map entry to be removed JDK-8024288 docs javadoc generated-by comment should always be present JDK-8023833 docs Replace direct use of AnnotatedType in javadoc code JDK-8023700 docs Use non breaking space in various labels JDK-8022738 docs doclet should only generate functional interface text if source >= 8 JDK-8015663 docs Need to supply tests to provide javadoc for profiles support code coverage JDK-8015496 docs Information that package is deprecated is missing in profiles view JDK-8008367 docs Sub-packages missing from Profiles javadoc JDK-7198273 docs RFE : Javadoc Accessibility : Hyperlinks should contain text or an image with alt text JDK-8024643 infrastructure Turn on javac lint checking in building the jdk repo JDK-8024201 infrastructure Update webrev.ksh bug urls to point to OpenJDK bug database JDK-8024200 infrastructure hgforest.sh fails to detect Python correctly if space after shebang JDK-8024140 other-libs [TESTBUG] Profile based regression test groups for jdk repo JDK-8017195 other-libs Introduce option to setKeepAlive parameter on CORBA sockets JDK-8024501 security-libs sun.security.mscapi.Key has no definition of serialVersionUID JDK-8024444 security-libs Change to use othervm mode of tests in SSLEngineImpl JDK-8024432 security-libs Fix doclint issues in java.security JDK-8024139 security-libs Need to expose the cause of JDK-8024123 JDK-8024068 security-libs sun/security/ssl/javax/net/ssl/ServerName/IllegalSNIName.java fails JDK-8024046 security-libs Test sun/security/krb5/runNameEquals.sh failed on 7u45 Embedded linux-ppc* JDK-8023362 security-libs Don't allow soft-fail behavior if OCSP responder returns "unauthorized" JDK-7188657 security-libs There should be a way to reorder the JSSE ciphers JDK-8024510 tools lib/combo/tools/javac/combo/TemplateTest.java fails JDK-8024434 tools problem running javadoc tests in samevm mode on Windows JDK-8024414 tools javac, should facilitate the use of the bootstrap compiler for debugging JDK-8024398 tools javac, compiler crashes with try with empty body JDK-8024207 tools javac crash in Flow.AssignAnalyzer.visitIdent JDK-8024154 tools Fix for 8016177: structural most specific and stuckness breaks 6 langtools tests JDK-8024093 tools Two *.rej files checked in to langtools/test directory JDK-8024039 tools javac, previous solution for JDK-8022186 was incorrect JDK-8023974 tools Drop 'implements Completer' and 'implements SourceCompleter' from ClassReader resp. JavaCompiler. JDK-8023608 tools method grouping tabs folding issue JDK-8023558 tools Javac creates invalid bootstrap methods for complex lambda/methodref case JDK-8023549 tools Compiler emitting spurious errors when constructor reference type is inferred and explicit type arguments are supplied JDK-8023545 tools Misleading error message when using diamond operator with private constructor JDK-8023389 tools Javac fails to infer type for lambda used with intersection type and wildcards JDK-8022322 tools Reject default and static methods in annotation JDK-8022260 tools Rename javac.code.Annotations to javac.code.SymbolMetadata JDK-8022162 tools Incorrect signature determination for certain inner class generics JDK-8021112 tools Spurious unchecked warning reported by javac JDK-8020816 tools Metafactory crashes on code with method reference JDK-8019521 tools Enhanced rethrow disabled in lambdas JDK-8016177 tools structural most specific and stuckness JDK-8015882 tools Javadoc prints NPE when using Taglet JDK-8015322 tools Javac template test framework JDK-8013846 tools javac fails to reject semantically equivalent generic method declarations JDK-8008275 tools javac.Main should be @Supported JDK-8006972 tools jtreg test fails: test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java JDK-8005222 tools Fixed bugs should have tests with bugid in @bug tag JDK-7186632 tools NLS t13y issue on jar.properties file JDK-7172176 tools test/sun/tools/jconsole/ImmutableResourceTest.sh failing JDK-7047734 tools javac, the LVT is not generated correctly in several scenarios JDK-6480588 tools No way to suppress deprecation warnings when implementing deprecated interface From pete.poulos at gmail.com Tue Sep 17 18:16:23 2013 From: pete.poulos at gmail.com (Pete Poulos) Date: Tue, 17 Sep 2013 19:16:23 -0600 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> Message-ID: Optional holds data and while the vast majority of use cases for Optional will be to immediately pull the value out and do something, that doesn't change the fact that it is still a data structure, somebody somewhere is going to need to serialize it for some reason. The other data structures in the java.util package are Serializable so making Optional Serializable makes things consistent. As far as I know the cost of adding Serializable to Optional is negligible, but the cost could be fairly significant to someone who needs to serialize it at some point and is unable to do so. Anyhow, I'm currently designing a set of functional (immutable, persistent) data structures for JDK8+ and I'm debating replacing my "Maybe" class (functionally the same as Optional, but with Haskell's naming convention for this data structure) the JDK8 Optional and I'm concerned that the lack of Serializable on Optional would cause problems for potential users of my API. I'm only using Optional/Maybe to wrap return values from methods so I can indicate missing/present values within my data structures, so I could conceivably use Optional and still support serialization. Also, while we are having this discussion, is there an alternative to serialization that is considered superior? Over the years I have read blog posts by people condemning serialization, but I don't recall seeing any alternatives suggested. Thanks, Pete On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich wrote: > Presumably because you may want to have class fields that express > nullability via Optional rather than null. Whether that's a good design or > not is a separate question; conceptually, I don't see a reason why Optional > cannot support that. For "reference", Google Guava's version is > serializable. If someone were to replace their use with jdk's Optional > then they will hit exceptions if the owner class is serialized. > > Sent from my phone > On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: > > > On 09/17/2013 11:44 PM, Pete Poulos wrote: > > > >> Shouldn't java.util.Optional be Serializable? Is there a good reason > for > >> it not be? > >> > > > > wrong question. > > the right one is why do you want Optional to be Serializable. > > > > Thanks, > >> Pete > >> > > > > cheers, > > R?mi > > > > > From stuart.marks at oracle.com Tue Sep 17 18:22:41 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Tue, 17 Sep 2013 18:22:41 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <52390061.8010303@oracle.com> Vote: yes On 9/4/13 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing > other committers' work, he is actively developing Nashorn on daily basis and has > contributed many changesets related to areas of Nashorn's parser and compiler, > invokedynamic linking, security, general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes > must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From alejandro.murillo at oracle.com Tue Sep 17 18:28:16 2013 From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com) Date: Wed, 18 Sep 2013 01:28:16 +0000 Subject: hg: jdk8/jdk8/hotspot: 10 new changesets Message-ID: <20130918012836.D87B6628DB@hg.openjdk.java.net> Changeset: 313b724f8911 Author: amurillo Date: 2013-09-06 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/313b724f8911 8024258: new hotspot build - hs25-b50 Reviewed-by: jcoomes ! make/hotspot_version Changeset: ceda33ff54a3 Author: iignatyev Date: 2013-09-05 16:38 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ceda33ff54a3 8012447: Java CTW implementation Reviewed-by: vlivanov, kvn, twisti ! test/gc/TestVerifyDuringStartup.java ! test/testlibrary/com/oracle/java/testlibrary/JDKToolFinder.java + test/testlibrary/ctw/Makefile + test/testlibrary/ctw/README + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathDirEntry.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJarEntry.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJarInDirEntry.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassesListInFile.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/CompileTheWorld.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/Compiler.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/PathHandler.java + test/testlibrary/ctw/src/sun/hotspot/tools/ctw/Utils.java + test/testlibrary/ctw/test/Bar.java + test/testlibrary/ctw/test/ClassesDirTest.java + test/testlibrary/ctw/test/ClassesListTest.java + test/testlibrary/ctw/test/CtwTest.java + test/testlibrary/ctw/test/Foo.java + test/testlibrary/ctw/test/JarDirTest.java + test/testlibrary/ctw/test/JarsTest.java + test/testlibrary/ctw/test/classes.lst + test/testlibrary/whitebox/Makefile Changeset: cd16d587b0fa Author: adlertz Date: 2013-09-09 19:53 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/cd16d587b0fa Merge Changeset: 72a567cce06f Author: anoll Date: 2013-09-10 07:51 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/72a567cce06f 8024473: Remove unused macro: IRT_ENTRY_FOR_NMETHOD Summary: Removed unused macro Reviewed-by: kvn, adlertz ! src/share/vm/runtime/interfaceSupport.hpp Changeset: edb5ab0f3fe5 Author: vlivanov Date: 2013-09-10 14:51 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/edb5ab0f3fe5 8001107: @Stable annotation for constant folding of lazily evaluated variables Reviewed-by: rbackman, twisti, kvn Contributed-by: john.r.rose at oracle.com, vladimir.x.ivanov at oracle.com ! src/share/vm/ci/ciArray.cpp ! src/share/vm/ci/ciArray.hpp ! src/share/vm/ci/ciConstant.hpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/ci/ciFlags.hpp ! src/share/vm/ci/ciInstance.cpp ! src/share/vm/ci/ciTypeArray.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/oops/fieldInfo.hpp ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/accessFlags.hpp Changeset: e0d33d2ce5aa Author: vlivanov Date: 2013-09-10 15:28 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e0d33d2ce5aa Merge Changeset: 34bd5e86aadb Author: adlertz Date: 2013-09-11 09:34 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/34bd5e86aadb 8010941: MinJumpTableSize is set to 18, investigate if that's still optimal Summary: Lowered the MinJumpTableSize for each platform Reviewed-by: kvn ! src/cpu/sparc/vm/c2_globals_sparc.hpp ! src/cpu/x86/vm/c2_globals_x86.hpp ! src/share/vm/opto/c2_globals.hpp Changeset: 0821b5d72ca8 Author: adlertz Date: 2013-09-12 09:10 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/0821b5d72ca8 Merge Changeset: a09fe9d1e016 Author: amurillo Date: 2013-09-13 00:25 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a09fe9d1e016 Merge Changeset: 85072013aad4 Author: amurillo Date: 2013-09-13 00:25 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/85072013aad4 Added tag hs25-b50 for changeset a09fe9d1e016 ! .hgtags From alejandro.murillo at oracle.com Tue Sep 17 18:33:15 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 17 Sep 2013 19:33:15 -0600 Subject: jdk8-b108: HotSpot Message-ID: <523902DB.1020801@oracle.com> hs25-b50 has been integrated into jdk8-b108. http://hg.openjdk.java.net/jdk8/jdk8/rev/4bf059350c51 http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/a4bb3b450016 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/85072013aad4 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/8ade3eed63da http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/d1ea68556fd7 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/ebc44e50df79 http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/252f872b8a2f http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/445ad3f6d3b4 Component : VM Status : 0 major failures, 0 minor failures Date : 09/17/2013 at 20:57 Tested By : VM SQE &leonid.mesnik at oracle.com Cost(total man-days): 1 Workspace : 2013-09-13-072710.amurillo.hs25-b50-snapshot Bundles : 2013-09-13-072710.amurillo.hs25-b50-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Logs :http://surl.us.oracle.com/PIT_HS25b50 Browsers : NA Patches : NA Number of Tests Executed : 318448 passed tests, 4565 failed tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 8001107: @Stable annotation for constant folding of lazily evaluated variables 8010941: MinJumpTableSize is set to 18, investigate if that's still optimal 8012447: Java CTW implementation 8024258: new hotspot build - hs25-b50 8024473: Remove unused macro: IRT_ENTRY_FOR_NMETHOD Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b108. Issues and Notes: This is PIT for HS25 b50 for JDK 8 b108. There are several JCK failures caused by DKFL mismatch. -- Alejandro From forax at univ-mlv.fr Tue Sep 17 23:37:30 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 18 Sep 2013 08:37:30 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> Message-ID: <52394A2A.2090905@univ-mlv.fr> There is a good reason to not allow Optional to implement Serializable, it promotes a bad way to use Optional, at least from the VM point of view. For the VM, Optional is a boxing, very similar to a boxing to Integer (in fact it's a little better because Integer.valueOf is badly* specified in the JLS but that's another story). so if you write: class Foo { private Optional description; public Optional getDescription() { return description; } } This implementation id bad for two reasons, the first one is that you have to do a double indirection so will double your chance to have a value that is not in the cache but in RAM when you want the underlying String. The second reason is that the VM will usually not be able to remove the boxing because the creation of Optional will be too far from the use. There is a better implementation class Foo { private String description; // warning nullable ! public Optional getDescription() { return Optional.fromNullable(description); } } It's the same API from the user point of view, but the creation of Optional is in the same inline horizon that it's use if getDescription is inlined (and here given that the method is really small, the is a good chance). In that case the VM is able to remove the boxing and everybody is happy. So making Optional serializable goes in the wrong direction. cheers, R?mi * as we now now in 2013, it was less obvious when the decision was taken circa 2003. On 09/18/2013 03:16 AM, Pete Poulos wrote: > Optional holds data and while the vast majority of use cases for Optional > will be to immediately pull the value out and do something, that doesn't > change the fact that it is still a data structure, somebody somewhere is > going to need to serialize it for some reason. The other data structures > in the java.util package are Serializable so making Optional Serializable > makes things consistent. > > As far as I know the cost of adding Serializable to Optional is negligible, > but the cost could be fairly significant to someone who needs to serialize > it at some point and is unable to do so. > > Anyhow, I'm currently designing a set of functional (immutable, persistent) > data structures for JDK8+ and I'm debating replacing my "Maybe" class > (functionally the same as Optional, but with Haskell's naming convention > for this data structure) the JDK8 Optional and I'm concerned that the lack > of Serializable on Optional would cause problems for potential users of my > API. > > I'm only using Optional/Maybe to wrap return values from methods so I can > indicate missing/present values within my data structures, so I could > conceivably use Optional and still support serialization. > > Also, while we are having this discussion, is there an alternative to > serialization that is considered superior? Over the years I have read blog > posts by people condemning serialization, but I don't recall seeing any > alternatives suggested. > > Thanks, > Pete > > > > > > > On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich wrote: > >> Presumably because you may want to have class fields that express >> nullability via Optional rather than null. Whether that's a good design or >> not is a separate question; conceptually, I don't see a reason why Optional >> cannot support that. For "reference", Google Guava's version is >> serializable. If someone were to replace their use with jdk's Optional >> then they will hit exceptions if the owner class is serialized. >> >> Sent from my phone >> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >> >>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>> >>>> Shouldn't java.util.Optional be Serializable? Is there a good reason >> for >>>> it not be? >>>> >>> wrong question. >>> the right one is why do you want Optional to be Serializable. >>> >>> Thanks, >>>> Pete >>>> >>> cheers, >>> R?mi >>> >>> From vitalyd at gmail.com Wed Sep 18 03:54:01 2013 From: vitalyd at gmail.com (Vitaly Davidovich) Date: Wed, 18 Sep 2013 06:54:01 -0400 Subject: Shouldn't Optional be Serializable? In-Reply-To: <52394A2A.2090905@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> Message-ID: R?mi, Sorry, using performance due to indirection and missed escape analysis as reason for not making Optional serializable is just silly. It's not going to prevent people from using this type as a field (docs/guidance is a better way to steer people in the right direction). Using your logic, may as well argue that no wrapper/datastructure class be used at all that has a couple of impls and an interface/base class. And if JIT cannot remove the box for whatever reason, should we not allow Optional at all? :) Cheers Sent from my phone On Sep 18, 2013 2:41 AM, "Remi Forax" wrote: > There is a good reason to not allow Optional to implement Serializable, > it promotes a bad way to use Optional, at least from the VM point of view. > > For the VM, Optional is a boxing, very similar to a boxing to Integer > (in fact it's a little better because Integer.valueOf is badly* specified > in the JLS > but that's another story). > > so if you write: > class Foo { > private Optional description; > > public Optional getDescription() { > return description; > } > } > > This implementation id bad for two reasons, the first one is that you have > to do > a double indirection so will double your chance to have a value that is not > in the cache but in RAM when you want the underlying String. > The second reason is that the VM will usually not be able to remove the > boxing because the creation of Optional will be too far from the use. > > There is a better implementation > class Foo { > private String description; // warning nullable ! > > public Optional getDescription() { > return Optional.fromNullable(**description); > } > } > > It's the same API from the user point of view, but the creation of Optional > is in the same inline horizon that it's use if getDescription is inlined > (and here given that the method is really small, the is a good chance). > In that case the VM is able to remove the boxing and everybody is happy. > > So making Optional serializable goes in the wrong direction. > > cheers, > R?mi > * as we now now in 2013, it was less obvious when the decision was taken > circa 2003. > > On 09/18/2013 03:16 AM, Pete Poulos wrote: > >> Optional holds data and while the vast majority of use cases for Optional >> will be to immediately pull the value out and do something, that doesn't >> change the fact that it is still a data structure, somebody somewhere is >> going to need to serialize it for some reason. The other data structures >> in the java.util package are Serializable so making Optional Serializable >> makes things consistent. >> >> As far as I know the cost of adding Serializable to Optional is >> negligible, >> but the cost could be fairly significant to someone who needs to serialize >> it at some point and is unable to do so. >> >> Anyhow, I'm currently designing a set of functional (immutable, >> persistent) >> data structures for JDK8+ and I'm debating replacing my "Maybe" class >> (functionally the same as Optional, but with Haskell's naming convention >> for this data structure) the JDK8 Optional and I'm concerned that the lack >> of Serializable on Optional would cause problems for potential users of my >> API. >> >> I'm only using Optional/Maybe to wrap return values from methods so I can >> indicate missing/present values within my data structures, so I could >> conceivably use Optional and still support serialization. >> >> Also, while we are having this discussion, is there an alternative to >> serialization that is considered superior? Over the years I have read >> blog >> posts by people condemning serialization, but I don't recall seeing any >> alternatives suggested. >> >> Thanks, >> Pete >> >> >> >> >> >> >> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich > >wrote: >> >> Presumably because you may want to have class fields that express >>> nullability via Optional rather than null. Whether that's a good design >>> or >>> not is a separate question; conceptually, I don't see a reason why >>> Optional >>> cannot support that. For "reference", Google Guava's version is >>> serializable. If someone were to replace their use with jdk's Optional >>> then they will hit exceptions if the owner class is serialized. >>> >>> Sent from my phone >>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >>> >>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>>> >>>> Shouldn't java.util.Optional be Serializable? Is there a good reason >>>>> >>>> for >>> >>>> it not be? >>>>> >>>>> wrong question. >>>> the right one is why do you want Optional to be Serializable. >>>> >>>> Thanks, >>>> >>>>> Pete >>>>> >>>>> cheers, >>>> R?mi >>>> >>>> >>>> > From roger.riggs at oracle.com Wed Sep 18 06:03:44 2013 From: roger.riggs at oracle.com (roger riggs) Date: Wed, 18 Sep 2013 09:03:44 -0400 Subject: Shouldn't Optional be Serializable? In-Reply-To: <52394A2A.2090905@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> Message-ID: <5239A4B0.1030707@oracle.com> Hi Remi,, Optional has semantics beyond those of simple boxing including throwing an exception if it has no value. The class libraries are designed to be useful to developers as part of a whole data model which includes serialization; optimizations of the API to enable VM performance would, I think be considered if the API design can provide the equivalent semantics. BTW, Optional.of(null) does not say it throws NPE; I didn't find any specification that connects the "not null" on the @param to throwing NPE in the class or package javadoc. Optional should be Serializable. $.02, Roger On 9/18/2013 2:37 AM, Remi Forax wrote: > There is a good reason to not allow Optional to implement Serializable, > it promotes a bad way to use Optional, at least from the VM point of > view. > > For the VM, Optional is a boxing, very similar to a boxing to Integer > (in fact it's a little better because Integer.valueOf is badly* > specified in the JLS > but that's another story). > > so if you write: > class Foo { > private Optional description; > > public Optional getDescription() { > return description; > } > } > > This implementation id bad for two reasons, the first one is that you > have to do > a double indirection so will double your chance to have a value that > is not > in the cache but in RAM when you want the underlying String. > The second reason is that the VM will usually not be able to remove the > boxing because the creation of Optional will be too far from the use. > > There is a better implementation > class Foo { > private String description; // warning nullable ! > > public Optional getDescription() { > return Optional.fromNullable(description); > } > } > > It's the same API from the user point of view, but the creation of > Optional > is in the same inline horizon that it's use if getDescription is inlined > (and here given that the method is really small, the is a good chance). > In that case the VM is able to remove the boxing and everybody is happy. > > So making Optional serializable goes in the wrong direction. > > cheers, > R?mi > * as we now now in 2013, it was less obvious when the decision was > taken circa 2003. > > On 09/18/2013 03:16 AM, Pete Poulos wrote: >> Optional holds data and while the vast majority of use cases for >> Optional >> will be to immediately pull the value out and do something, that doesn't >> change the fact that it is still a data structure, somebody somewhere is >> going to need to serialize it for some reason. The other data >> structures >> in the java.util package are Serializable so making Optional >> Serializable >> makes things consistent. >> >> As far as I know the cost of adding Serializable to Optional is >> negligible, >> but the cost could be fairly significant to someone who needs to >> serialize >> it at some point and is unable to do so. >> >> Anyhow, I'm currently designing a set of functional (immutable, >> persistent) >> data structures for JDK8+ and I'm debating replacing my "Maybe" class >> (functionally the same as Optional, but with Haskell's naming convention >> for this data structure) the JDK8 Optional and I'm concerned that the >> lack >> of Serializable on Optional would cause problems for potential users >> of my >> API. >> >> I'm only using Optional/Maybe to wrap return values from methods so I >> can >> indicate missing/present values within my data structures, so I could >> conceivably use Optional and still support serialization. >> >> Also, while we are having this discussion, is there an alternative to >> serialization that is considered superior? Over the years I have >> read blog >> posts by people condemning serialization, but I don't recall seeing any >> alternatives suggested. >> >> Thanks, >> Pete >> >> >> >> >> >> >> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich >> wrote: >> >>> Presumably because you may want to have class fields that express >>> nullability via Optional rather than null. Whether that's a good >>> design or >>> not is a separate question; conceptually, I don't see a reason why >>> Optional >>> cannot support that. For "reference", Google Guava's version is >>> serializable. If someone were to replace their use with jdk's Optional >>> then they will hit exceptions if the owner class is serialized. >>> >>> Sent from my phone >>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >>> >>>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>>> >>>>> Shouldn't java.util.Optional be Serializable? Is there a good reason >>> for >>>>> it not be? >>>>> >>>> wrong question. >>>> the right one is why do you want Optional to be Serializable. >>>> >>>> Thanks, >>>>> Pete >>>>> >>>> cheers, >>>> R?mi >>>> >>>> > From vicente.romero at oracle.com Wed Sep 18 07:08:36 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Wed, 18 Sep 2013 15:08:36 +0100 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <8950CEF4-2395-4CD6-A5B9-951296252C43@oracle.com> References: <5227A84A.3050406@oracle.com> <8950CEF4-2395-4CD6-A5B9-951296252C43@oracle.com> Message-ID: <5239B3E4.3000508@oracle.com> vote: yes On Sep 4, 2013, at 11:38 PM, Stuart Marks wrote: >> I hereby nominate Attila Szegedi to JDK 8 Committer. >> >> Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, invokedynamic linking, security, general performance optimizations, and more. >> >> Attila's changesets (in the jdk8/tl/nashorn repo): >> >> hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " >> >> This currently shows 73 changesets. Attila's reviews (also jdk8/tl/nashorn): >> >> hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" >> >> This currently shows 115 reviews. >> >> Votes are due by 2359 PDT, September 18, 2013. >> >> Only current JDK 8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. >> >> For Lazy Consensus voting instructions, see [2]. >> >> s'marks >> >> [1] http://openjdk.java.net/census >> [2] http://openjdk.java.net/projects/#committer-vote >> From forax at univ-mlv.fr Wed Sep 18 07:33:21 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 18 Sep 2013 16:33:21 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> Message-ID: <5239B9B1.1070606@univ-mlv.fr> On 09/18/2013 12:54 PM, Vitaly Davidovich wrote: > > R?mi, > > Sorry, using performance due to indirection and missed escape analysis > as reason for not making Optional serializable is just silly. > You miss the point here, it's not a bug or an issue with the escape analysis, the reference escape, it's how the code is written if you declare a field Optional so the boxing will be never removed by using escape analysis. It's exactly like using a wrapper type instead of a primitive type when you declare a field. and if you want to serialize a field which is Optional, there is no issue, mark it transient, use orNull() when serializing and fromNullable() when deserializing, BTW it will be better if you decide that the field can not store null in a future version. > It's not going to prevent people from using this type as a field > (docs/guidance is a better way to steer people in the right direction). > Why not having both ? This is IMO similar to what Martin Thompson calls mechanical sympathy, I prefer to live in a world where the JDK API and the VM works in harmony. Optional is nice from the API point of view, but not if you store it in a field. If it's not something that should be stored in field, there is no point to make it serializable. > Using your logic, may as well argue that no wrapper/datastructure > class be used at all that has a couple of impls and an interface/base > class. > no, the trade off is not the same. If you use Optional for every fields, we already know that it doesn't work at all. Because this is how the VMs were working before 2000. > And if JIT cannot remove the box for whatever reason, should we not > allow Optional at all? :) > If people don't want to see the trade off behind it, may be you're right, but I think that the Java community is more mature than that. > Cheers > R?mi > Sent from my phone > > On Sep 18, 2013 2:41 AM, "Remi Forax" > wrote: > > There is a good reason to not allow Optional to implement > Serializable, > it promotes a bad way to use Optional, at least from the VM point > of view. > > For the VM, Optional is a boxing, very similar to a boxing to Integer > (in fact it's a little better because Integer.valueOf is badly* > specified in the JLS > but that's another story). > > so if you write: > class Foo { > private Optional description; > > public Optional getDescription() { > return description; > } > } > > This implementation id bad for two reasons, the first one is that > you have to do > a double indirection so will double your chance to have a value > that is not > in the cache but in RAM when you want the underlying String. > The second reason is that the VM will usually not be able to > remove the > boxing because the creation of Optional will be too far from the use. > > There is a better implementation > class Foo { > private String description; // warning nullable ! > > public Optional getDescription() { > return Optional.fromNullable(description); > } > } > > It's the same API from the user point of view, but the creation of > Optional > is in the same inline horizon that it's use if getDescription is > inlined > (and here given that the method is really small, the is a good > chance). > In that case the VM is able to remove the boxing and everybody is > happy. > > So making Optional serializable goes in the wrong direction. > > cheers, > R?mi > * as we now now in 2013, it was less obvious when the decision was > taken circa 2003. > > On 09/18/2013 03:16 AM, Pete Poulos wrote: > > Optional holds data and while the vast majority of use cases > for Optional > will be to immediately pull the value out and do something, > that doesn't > change the fact that it is still a data structure, somebody > somewhere is > going to need to serialize it for some reason. The other data > structures > in the java.util package are Serializable so making Optional > Serializable > makes things consistent. > > As far as I know the cost of adding Serializable to Optional > is negligible, > but the cost could be fairly significant to someone who needs > to serialize > it at some point and is unable to do so. > > Anyhow, I'm currently designing a set of functional > (immutable, persistent) > data structures for JDK8+ and I'm debating replacing my > "Maybe" class > (functionally the same as Optional, but with Haskell's naming > convention > for this data structure) the JDK8 Optional and I'm concerned > that the lack > of Serializable on Optional would cause problems for potential > users of my > API. > > I'm only using Optional/Maybe to wrap return values from > methods so I can > indicate missing/present values within my data structures, so > I could > conceivably use Optional and still support serialization. > > Also, while we are having this discussion, is there an > alternative to > serialization that is considered superior? Over the years I > have read blog > posts by people condemning serialization, but I don't recall > seeing any > alternatives suggested. > > Thanks, > Pete > > > > > > > On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich > >wrote: > > Presumably because you may want to have class fields that > express > nullability via Optional rather than null. Whether that's > a good design or > not is a separate question; conceptually, I don't see a > reason why Optional > cannot support that. For "reference", Google Guava's > version is > serializable. If someone were to replace their use with > jdk's Optional > then they will hit exceptions if the owner class is > serialized. > > Sent from my phone > On Sep 17, 2013 6:06 PM, "Remi Forax" > wrote: > > On 09/17/2013 11:44 PM, Pete Poulos wrote: > > Shouldn't java.util.Optional be Serializable? Is > there a good reason > > for > > it not be? > > wrong question. > the right one is why do you want Optional to be > Serializable. > > Thanks, > > Pete > > cheers, > R?mi > > > From vitalyd at gmail.com Wed Sep 18 07:42:32 2013 From: vitalyd at gmail.com (Vitaly Davidovich) Date: Wed, 18 Sep 2013 10:42:32 -0400 Subject: Shouldn't Optional be Serializable? In-Reply-To: <5239B9B1.1070606@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <5239B9B1.1070606@univ-mlv.fr> Message-ID: I think the point is that not marking Optional as Serializable as some form of preventive measure to make people not use them as fields due to performance is misguided - it's not going to achieve that, it's just going to annoy people and prompt emails like this. There may be cases where you just don't care about the perf/footprint impact of having the box - this should be left up to user, not crippling Optional. Vitaly Sent from my phone On Sep 18, 2013 10:35 AM, "Remi Forax" wrote: > On 09/18/2013 12:54 PM, Vitaly Davidovich wrote: > >> >> R?mi, >> >> Sorry, using performance due to indirection and missed escape analysis as >> reason for not making Optional serializable is just silly. >> >> > You miss the point here, it's not a bug or an issue with the escape > analysis, > the reference escape, it's how the code is written if you declare a field > Optional > so the boxing will be never removed by using escape analysis. > It's exactly like using a wrapper type instead of a primitive type when > you declare a field. > > and if you want to serialize a field which is Optional, there is no issue, > mark it transient, use orNull() when serializing and > fromNullable() when deserializing, BTW it will be better if you decide > that the field can not store null in a future version. > > It's not going to prevent people from using this type as a field >> (docs/guidance is a better way to steer people in the right direction). >> >> > Why not having both ? > > This is IMO similar to what Martin Thompson calls mechanical sympathy, I > prefer to live in a world > where the JDK API and the VM works in harmony. > Optional is nice from the API point of view, but not if you store it in a > field. > If it's not something that should be stored in field, there is no point to > make it serializable. > > Using your logic, may as well argue that no wrapper/datastructure class >> be used at all that has a couple of impls and an interface/base class. >> >> > no, the trade off is not the same. > If you use Optional for every fields, we already know that it doesn't work > at all. Because this is how the VMs were working before 2000. > > And if JIT cannot remove the box for whatever reason, should we not allow >> Optional at all? :) >> >> > If people don't want to see the trade off behind it, may be you're right, > but I think that the Java community is more mature than that. > > Cheers >> >> > R?mi > > Sent from my phone >> >> On Sep 18, 2013 2:41 AM, "Remi Forax" > forax at univ-mlv.fr>> wrote: >> >> There is a good reason to not allow Optional to implement >> Serializable, >> it promotes a bad way to use Optional, at least from the VM point >> of view. >> >> For the VM, Optional is a boxing, very similar to a boxing to Integer >> (in fact it's a little better because Integer.valueOf is badly* >> specified in the JLS >> but that's another story). >> >> so if you write: >> class Foo { >> private Optional description; >> >> public Optional getDescription() { >> return description; >> } >> } >> >> This implementation id bad for two reasons, the first one is that >> you have to do >> a double indirection so will double your chance to have a value >> that is not >> in the cache but in RAM when you want the underlying String. >> The second reason is that the VM will usually not be able to >> remove the >> boxing because the creation of Optional will be too far from the use. >> >> There is a better implementation >> class Foo { >> private String description; // warning nullable ! >> >> public Optional getDescription() { >> return Optional.fromNullable(**description); >> } >> } >> >> It's the same API from the user point of view, but the creation of >> Optional >> is in the same inline horizon that it's use if getDescription is >> inlined >> (and here given that the method is really small, the is a good >> chance). >> In that case the VM is able to remove the boxing and everybody is >> happy. >> >> So making Optional serializable goes in the wrong direction. >> >> cheers, >> R?mi >> * as we now now in 2013, it was less obvious when the decision was >> taken circa 2003. >> >> On 09/18/2013 03:16 AM, Pete Poulos wrote: >> >> Optional holds data and while the vast majority of use cases >> for Optional >> will be to immediately pull the value out and do something, >> that doesn't >> change the fact that it is still a data structure, somebody >> somewhere is >> going to need to serialize it for some reason. The other data >> structures >> in the java.util package are Serializable so making Optional >> Serializable >> makes things consistent. >> >> As far as I know the cost of adding Serializable to Optional >> is negligible, >> but the cost could be fairly significant to someone who needs >> to serialize >> it at some point and is unable to do so. >> >> Anyhow, I'm currently designing a set of functional >> (immutable, persistent) >> data structures for JDK8+ and I'm debating replacing my >> "Maybe" class >> (functionally the same as Optional, but with Haskell's naming >> convention >> for this data structure) the JDK8 Optional and I'm concerned >> that the lack >> of Serializable on Optional would cause problems for potential >> users of my >> API. >> >> I'm only using Optional/Maybe to wrap return values from >> methods so I can >> indicate missing/present values within my data structures, so >> I could >> conceivably use Optional and still support serialization. >> >> Also, while we are having this discussion, is there an >> alternative to >> serialization that is considered superior? Over the years I >> have read blog >> posts by people condemning serialization, but I don't recall >> seeing any >> alternatives suggested. >> >> Thanks, >> Pete >> >> >> >> >> >> >> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich >> >**wrote: >> >> Presumably because you may want to have class fields that >> express >> nullability via Optional rather than null. Whether that's >> a good design or >> not is a separate question; conceptually, I don't see a >> reason why Optional >> cannot support that. For "reference", Google Guava's >> version is >> serializable. If someone were to replace their use with >> jdk's Optional >> then they will hit exceptions if the owner class is >> serialized. >> >> Sent from my phone >> On Sep 17, 2013 6:06 PM, "Remi Forax" > > wrote: >> >> On 09/17/2013 11:44 PM, Pete Poulos wrote: >> >> Shouldn't java.util.Optional be Serializable? Is >> there a good reason >> >> for >> >> it not be? >> >> wrong question. >> the right one is why do you want Optional to be >> Serializable. >> >> Thanks, >> >> Pete >> >> cheers, >> R?mi >> >> >> >> > From jonathan.gibbons at oracle.com Wed Sep 18 07:42:35 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 18 Sep 2013 07:42:35 -0700 Subject: CFV: New JDK 8 Committer: Attila Szegedi (attila) In-Reply-To: <5227A84A.3050406@oracle.com> References: <5227A84A.3050406@oracle.com> Message-ID: <5239BBDB.30803@oracle.com> Vote: yes On 09/04/2013 02:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed many changesets related to areas of > Nashorn's parser and compiler, invokedynamic linking, security, > general performance optimizations, and more. > > Attila's changesets (in the jdk8/tl/nashorn repo): > > hg log -M -u attila --template "{desc}\n" | grep "^[0-9]\{7\}: " > > This currently shows 73 changesets. Attila's reviews (also > jdk8/tl/nashorn): > > hg log -M --template "{desc}\n" | grep "Reviewed-by: .*attila" > > This currently shows 115 reviews. > > Votes are due by 2359 PDT, September 18, 2013. > > Only current JDK 8 Committers [1] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [2]. > > s'marks > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From josephcu at gmail.com Wed Sep 18 10:09:10 2013 From: josephcu at gmail.com (Joseph Unruh) Date: Wed, 18 Sep 2013 10:09:10 -0700 Subject: Shouldn't Optional be Serializable? In-Reply-To: <52394A2A.2090905@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> Message-ID: While It's clear that there are performance implications to using an Optional field, keeping Optional non-serializable doesn't do much to prevent that from happening. In the vast majority of cases, Optional will be used in a non-serialized context. So, as preventative measures go, this isn't a very effective one. Second, Optional exists primarily as a mechanism for marking that an object may be null. This is a design objective. If the objective was performance, then Optional wouldn't exist. Enforcing this usage on people, particularly in the narrow context of serialization, is a premature optimization. If it's useful to have optional exist at the API level in order to prevent NPEs, why can't it be useful at the individual class level to prevent NPEs? Cheers, Joseph On Tue, Sep 17, 2013 at 11:37 PM, Remi Forax wrote: > There is a good reason to not allow Optional to implement Serializable, > it promotes a bad way to use Optional, at least from the VM point of view. > > For the VM, Optional is a boxing, very similar to a boxing to Integer > (in fact it's a little better because Integer.valueOf is badly* specified > in the JLS > but that's another story). > > so if you write: > class Foo { > private Optional description; > > public Optional getDescription() { > return description; > } > } > > This implementation id bad for two reasons, the first one is that you have > to do > a double indirection so will double your chance to have a value that is not > in the cache but in RAM when you want the underlying String. > The second reason is that the VM will usually not be able to remove the > boxing because the creation of Optional will be too far from the use. > > There is a better implementation > class Foo { > private String description; // warning nullable ! > > public Optional getDescription() { > return Optional.fromNullable(**description); > } > } > > It's the same API from the user point of view, but the creation of Optional > is in the same inline horizon that it's use if getDescription is inlined > (and here given that the method is really small, the is a good chance). > In that case the VM is able to remove the boxing and everybody is happy. > > So making Optional serializable goes in the wrong direction. > > cheers, > R?mi > * as we now now in 2013, it was less obvious when the decision was taken > circa 2003. > > > On 09/18/2013 03:16 AM, Pete Poulos wrote: > >> Optional holds data and while the vast majority of use cases for Optional >> will be to immediately pull the value out and do something, that doesn't >> change the fact that it is still a data structure, somebody somewhere is >> going to need to serialize it for some reason. The other data structures >> in the java.util package are Serializable so making Optional Serializable >> makes things consistent. >> >> As far as I know the cost of adding Serializable to Optional is >> negligible, >> but the cost could be fairly significant to someone who needs to serialize >> it at some point and is unable to do so. >> >> Anyhow, I'm currently designing a set of functional (immutable, >> persistent) >> data structures for JDK8+ and I'm debating replacing my "Maybe" class >> (functionally the same as Optional, but with Haskell's naming convention >> for this data structure) the JDK8 Optional and I'm concerned that the lack >> of Serializable on Optional would cause problems for potential users of my >> API. >> >> I'm only using Optional/Maybe to wrap return values from methods so I can >> indicate missing/present values within my data structures, so I could >> conceivably use Optional and still support serialization. >> >> Also, while we are having this discussion, is there an alternative to >> serialization that is considered superior? Over the years I have read >> blog >> posts by people condemning serialization, but I don't recall seeing any >> alternatives suggested. >> >> Thanks, >> Pete >> >> >> >> >> >> >> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich > >wrote: >> >> Presumably because you may want to have class fields that express >>> nullability via Optional rather than null. Whether that's a good design >>> or >>> not is a separate question; conceptually, I don't see a reason why >>> Optional >>> cannot support that. For "reference", Google Guava's version is >>> serializable. If someone were to replace their use with jdk's Optional >>> then they will hit exceptions if the owner class is serialized. >>> >>> Sent from my phone >>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >>> >>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>>> >>>> Shouldn't java.util.Optional be Serializable? Is there a good reason >>>>> >>>> for >>> >>>> it not be? >>>>> >>>>> wrong question. >>>> the right one is why do you want Optional to be Serializable. >>>> >>>> Thanks, >>>> >>>>> Pete >>>>> >>>>> cheers, >>>> R?mi >>>> >>>> >>>> > From pete.poulos at gmail.com Wed Sep 18 10:32:56 2013 From: pete.poulos at gmail.com (Pete Poulos) Date: Wed, 18 Sep 2013 11:32:56 -0600 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> Message-ID: One use case to consider here is RPC. many RPC frameworks use serialization to transmit the results of the RPC call over the network. If Optional is not serializable then you will be unable to return Optional results from methods invoked via RPC. On Sep 18, 2013 11:13 AM, "Joseph Unruh" wrote: > While It's clear that there are performance implications to using an > Optional field, keeping Optional non-serializable doesn't do much to > prevent that from happening. In the vast majority of cases, Optional will > be used in a non-serialized context. So, as preventative measures go, this > isn't a very effective one. > > Second, Optional exists primarily as a mechanism for marking that an object > may be null. This is a design objective. If the objective was performance, > then Optional wouldn't exist. Enforcing this usage on people, particularly > in the narrow context of serialization, is a premature optimization. If > it's useful to have optional exist at the API level in order to prevent > NPEs, why can't it be useful at the individual class level to prevent NPEs? > > Cheers, > Joseph > > > On Tue, Sep 17, 2013 at 11:37 PM, Remi Forax wrote: > > > There is a good reason to not allow Optional to implement Serializable, > > it promotes a bad way to use Optional, at least from the VM point of > view. > > > > For the VM, Optional is a boxing, very similar to a boxing to Integer > > (in fact it's a little better because Integer.valueOf is badly* specified > > in the JLS > > but that's another story). > > > > so if you write: > > class Foo { > > private Optional description; > > > > public Optional getDescription() { > > return description; > > } > > } > > > > This implementation id bad for two reasons, the first one is that you > have > > to do > > a double indirection so will double your chance to have a value that is > not > > in the cache but in RAM when you want the underlying String. > > The second reason is that the VM will usually not be able to remove the > > boxing because the creation of Optional will be too far from the use. > > > > There is a better implementation > > class Foo { > > private String description; // warning nullable ! > > > > public Optional getDescription() { > > return Optional.fromNullable(**description); > > } > > } > > > > It's the same API from the user point of view, but the creation of > Optional > > is in the same inline horizon that it's use if getDescription is inlined > > (and here given that the method is really small, the is a good chance). > > In that case the VM is able to remove the boxing and everybody is happy. > > > > So making Optional serializable goes in the wrong direction. > > > > cheers, > > R?mi > > * as we now now in 2013, it was less obvious when the decision was taken > > circa 2003. > > > > > > On 09/18/2013 03:16 AM, Pete Poulos wrote: > > > >> Optional holds data and while the vast majority of use cases for > Optional > >> will be to immediately pull the value out and do something, that doesn't > >> change the fact that it is still a data structure, somebody somewhere is > >> going to need to serialize it for some reason. The other data > structures > >> in the java.util package are Serializable so making Optional > Serializable > >> makes things consistent. > >> > >> As far as I know the cost of adding Serializable to Optional is > >> negligible, > >> but the cost could be fairly significant to someone who needs to > serialize > >> it at some point and is unable to do so. > >> > >> Anyhow, I'm currently designing a set of functional (immutable, > >> persistent) > >> data structures for JDK8+ and I'm debating replacing my "Maybe" class > >> (functionally the same as Optional, but with Haskell's naming convention > >> for this data structure) the JDK8 Optional and I'm concerned that the > lack > >> of Serializable on Optional would cause problems for potential users of > my > >> API. > >> > >> I'm only using Optional/Maybe to wrap return values from methods so I > can > >> indicate missing/present values within my data structures, so I could > >> conceivably use Optional and still support serialization. > >> > >> Also, while we are having this discussion, is there an alternative to > >> serialization that is considered superior? Over the years I have read > >> blog > >> posts by people condemning serialization, but I don't recall seeing any > >> alternatives suggested. > >> > >> Thanks, > >> Pete > >> > >> > >> > >> > >> > >> > >> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich >> >wrote: > >> > >> Presumably because you may want to have class fields that express > >>> nullability via Optional rather than null. Whether that's a good > design > >>> or > >>> not is a separate question; conceptually, I don't see a reason why > >>> Optional > >>> cannot support that. For "reference", Google Guava's version is > >>> serializable. If someone were to replace their use with jdk's Optional > >>> then they will hit exceptions if the owner class is serialized. > >>> > >>> Sent from my phone > >>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: > >>> > >>> On 09/17/2013 11:44 PM, Pete Poulos wrote: > >>>> > >>>> Shouldn't java.util.Optional be Serializable? Is there a good reason > >>>>> > >>>> for > >>> > >>>> it not be? > >>>>> > >>>>> wrong question. > >>>> the right one is why do you want Optional to be Serializable. > >>>> > >>>> Thanks, > >>>> > >>>>> Pete > >>>>> > >>>>> cheers, > >>>> R?mi > >>>> > >>>> > >>>> > > > From david.katleman at oracle.com Wed Sep 18 13:46:44 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 18 Sep 2013 20:46:44 +0000 Subject: hg: jdk8/jdk8: 9 new changesets Message-ID: <20130918204645.D5DF36291A@hg.openjdk.java.net> Changeset: 8dadd26c2a58 Author: ihse Date: 2013-09-12 10:38 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/8dadd26c2a58 8024467: Update autoconf-config.guess to autoconf 2.69 Reviewed-by: erikj ! common/autoconf/build-aux/autoconf-config.guess Changeset: 64f52ef175a4 Author: ihse Date: 2013-09-12 10:42 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/64f52ef175a4 8010185: Build should support --with-override-nashorn Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/source-dirs.m4 Changeset: b1e9396fb8af Author: vadim Date: 2013-09-12 12:12 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/b1e9396fb8af 8008022: Upgrade Direct X SDK used to build JDK Reviewed-by: erikj, prr, ihse ! Makefile ! README-builds.html ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/autoconf/toolchain.m4 ! common/autoconf/toolchain_windows.m4 Changeset: 69da99676239 Author: ihse Date: 2013-09-13 13:07 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/69da99676239 8024620: config.log does not end up in corresponding configuration Reviewed-by: erikj ! common/autoconf/configure ! common/autoconf/configure.ac ! common/autoconf/generated-configure.sh Changeset: ac3f5137f84d Author: ihse Date: 2013-09-13 14:59 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/ac3f5137f84d 8024665: Move open changes for JDK-8020411 to closed source Reviewed-by: erikj ! common/autoconf/generated-configure.sh ! common/autoconf/platform.m4 ! common/autoconf/spec.gmk.in Changeset: aab351790498 Author: katleman Date: 2013-09-17 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/aab351790498 Merge Changeset: 59d6af7422af Author: katleman Date: 2013-09-17 19:06 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/59d6af7422af Merge Changeset: 7697621037fd Author: ihse Date: 2013-09-18 12:37 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/7697621037fd 8024815: Make --with-dxsdk and friends deprecated Reviewed-by: erikj ! common/autoconf/basics.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 Changeset: 9286a6e61291 Author: ihse Date: 2013-09-18 13:49 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/9286a6e61291 8024849: Don't remove upper case letters from username when setting USER_RELEASE_SUFFIX Reviewed-by: erikj ! common/autoconf/basics_windows.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/jdk-options.m4 From david.katleman at oracle.com Wed Sep 18 13:47:32 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 18 Sep 2013 20:47:32 +0000 Subject: hg: jdk8/jdk8/jdk: 3 new changesets Message-ID: <20130918204912.4EF756291B@hg.openjdk.java.net> Changeset: 5063b43d7e09 Author: vadim Date: 2013-09-12 12:12 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5063b43d7e09 8008022: Upgrade Direct X SDK used to build JDK Reviewed-by: erikj, prr, ihse ! make/Makefile ! make/common/Defs-windows.gmk ! make/common/Sanity.gmk ! make/common/shared/Defs-versions.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Sanity-Settings.gmk ! make/common/shared/Sanity.gmk ! make/javax/sound/jsoundds/Makefile ! make/jdk_generic_profile.sh ! make/netbeans/awt2d/README ! make/sun/awt/Makefile ! make/sun/jawt/Makefile ! makefiles/CompileNativeLibraries.gmk Changeset: 5da2bb1419e6 Author: katleman Date: 2013-09-17 13:42 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/5da2bb1419e6 Merge Changeset: 006aaa5f069e Author: katleman Date: 2013-09-17 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/006aaa5f069e Merge ! makefiles/CompileNativeLibraries.gmk From christine.lu at oracle.com Thu Sep 19 09:39:58 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:39:58 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b108 for changeset a4bb3b450016 Message-ID: <20130919163958.BE2F962961@hg.openjdk.java.net> Changeset: c1eb93f57603 Author: cl Date: 2013-09-19 09:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/c1eb93f57603 Added tag jdk8-b108 for changeset a4bb3b450016 ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:40:41 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:40:41 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b108 for changeset 85072013aad4 Message-ID: <20130919164043.ADFBE62962@hg.openjdk.java.net> Changeset: 34aa07e92d22 Author: cl Date: 2013-09-19 09:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/34aa07e92d22 Added tag jdk8-b108 for changeset 85072013aad4 ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:42:03 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:42:03 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b108 for changeset d1ea68556fd7 Message-ID: <20130919164206.009AD62964@hg.openjdk.java.net> Changeset: f64b1e497722 Author: cl Date: 2013-09-19 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/f64b1e497722 Added tag jdk8-b108 for changeset d1ea68556fd7 ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:41:49 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:41:49 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b108 for changeset 8ade3eed63da Message-ID: <20130919164151.BD47862963@hg.openjdk.java.net> Changeset: 21b10835b88a Author: cl Date: 2013-09-19 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/21b10835b88a Added tag jdk8-b108 for changeset 8ade3eed63da ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:42:23 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:42:23 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b108 for changeset 006aaa5f069e Message-ID: <20130919164239.AB2D962965@hg.openjdk.java.net> Changeset: a7dd84b9557c Author: cl Date: 2013-09-19 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a7dd84b9557c Added tag jdk8-b108 for changeset 006aaa5f069e ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:44:08 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:44:08 +0000 Subject: hg: jdk8/jdk8/nashorn: Added tag jdk8-b108 for changeset 445ad3f6d3b4 Message-ID: <20130919164409.287EA62967@hg.openjdk.java.net> Changeset: 6ec2f9e5ed5b Author: cl Date: 2013-09-19 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/6ec2f9e5ed5b Added tag jdk8-b108 for changeset 445ad3f6d3b4 ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:43:53 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:43:53 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b108 for changeset 252f872b8a2f Message-ID: <20130919164356.ED99162966@hg.openjdk.java.net> Changeset: 8ecfe6a3ba4c Author: cl Date: 2013-09-19 09:37 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/8ecfe6a3ba4c Added tag jdk8-b108 for changeset 252f872b8a2f ! .hgtags From christine.lu at oracle.com Thu Sep 19 09:39:49 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 19 Sep 2013 16:39:49 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b108 for changeset 9286a6e61291 Message-ID: <20130919163949.85CBA6295F@hg.openjdk.java.net> Changeset: d4762f463fe0 Author: cl Date: 2013-09-19 09:36 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/d4762f463fe0 Added tag jdk8-b108 for changeset 9286a6e61291 ! .hgtags From forax at univ-mlv.fr Thu Sep 19 12:20:52 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Thu, 19 Sep 2013 21:20:52 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> Message-ID: <523B4E94.5090809@univ-mlv.fr> On 09/18/2013 07:32 PM, Pete Poulos wrote: > One use case to consider here is RPC. many RPC frameworks use serialization > to transmit the results of the RPC call over the network. If Optional is > not serializable then you will be unable to return Optional results from > methods invoked via RPC. yes and no, it depends how your RPC framework map errors because if you send an Optional and then throw an exception in the client you will not have a meaningful stack trace. R?mi > On Sep 18, 2013 11:13 AM, "Joseph Unruh" wrote: > >> While It's clear that there are performance implications to using an >> Optional field, keeping Optional non-serializable doesn't do much to >> prevent that from happening. In the vast majority of cases, Optional will >> be used in a non-serialized context. So, as preventative measures go, this >> isn't a very effective one. >> >> Second, Optional exists primarily as a mechanism for marking that an object >> may be null. This is a design objective. If the objective was performance, >> then Optional wouldn't exist. Enforcing this usage on people, particularly >> in the narrow context of serialization, is a premature optimization. If >> it's useful to have optional exist at the API level in order to prevent >> NPEs, why can't it be useful at the individual class level to prevent NPEs? >> >> Cheers, >> Joseph >> >> >> On Tue, Sep 17, 2013 at 11:37 PM, Remi Forax wrote: >> >>> There is a good reason to not allow Optional to implement Serializable, >>> it promotes a bad way to use Optional, at least from the VM point of >> view. >>> For the VM, Optional is a boxing, very similar to a boxing to Integer >>> (in fact it's a little better because Integer.valueOf is badly* specified >>> in the JLS >>> but that's another story). >>> >>> so if you write: >>> class Foo { >>> private Optional description; >>> >>> public Optional getDescription() { >>> return description; >>> } >>> } >>> >>> This implementation id bad for two reasons, the first one is that you >> have >>> to do >>> a double indirection so will double your chance to have a value that is >> not >>> in the cache but in RAM when you want the underlying String. >>> The second reason is that the VM will usually not be able to remove the >>> boxing because the creation of Optional will be too far from the use. >>> >>> There is a better implementation >>> class Foo { >>> private String description; // warning nullable ! >>> >>> public Optional getDescription() { >>> return Optional.fromNullable(**description); >>> } >>> } >>> >>> It's the same API from the user point of view, but the creation of >> Optional >>> is in the same inline horizon that it's use if getDescription is inlined >>> (and here given that the method is really small, the is a good chance). >>> In that case the VM is able to remove the boxing and everybody is happy. >>> >>> So making Optional serializable goes in the wrong direction. >>> >>> cheers, >>> R?mi >>> * as we now now in 2013, it was less obvious when the decision was taken >>> circa 2003. >>> >>> >>> On 09/18/2013 03:16 AM, Pete Poulos wrote: >>> >>>> Optional holds data and while the vast majority of use cases for >> Optional >>>> will be to immediately pull the value out and do something, that doesn't >>>> change the fact that it is still a data structure, somebody somewhere is >>>> going to need to serialize it for some reason. The other data >> structures >>>> in the java.util package are Serializable so making Optional >> Serializable >>>> makes things consistent. >>>> >>>> As far as I know the cost of adding Serializable to Optional is >>>> negligible, >>>> but the cost could be fairly significant to someone who needs to >> serialize >>>> it at some point and is unable to do so. >>>> >>>> Anyhow, I'm currently designing a set of functional (immutable, >>>> persistent) >>>> data structures for JDK8+ and I'm debating replacing my "Maybe" class >>>> (functionally the same as Optional, but with Haskell's naming convention >>>> for this data structure) the JDK8 Optional and I'm concerned that the >> lack >>>> of Serializable on Optional would cause problems for potential users of >> my >>>> API. >>>> >>>> I'm only using Optional/Maybe to wrap return values from methods so I >> can >>>> indicate missing/present values within my data structures, so I could >>>> conceivably use Optional and still support serialization. >>>> >>>> Also, while we are having this discussion, is there an alternative to >>>> serialization that is considered superior? Over the years I have read >>>> blog >>>> posts by people condemning serialization, but I don't recall seeing any >>>> alternatives suggested. >>>> >>>> Thanks, >>>> Pete >>>> >>>> >>>> >>>> >>>> >>>> >>>> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich >>>> wrote: >>>> Presumably because you may want to have class fields that express >>>>> nullability via Optional rather than null. Whether that's a good >> design >>>>> or >>>>> not is a separate question; conceptually, I don't see a reason why >>>>> Optional >>>>> cannot support that. For "reference", Google Guava's version is >>>>> serializable. If someone were to replace their use with jdk's Optional >>>>> then they will hit exceptions if the owner class is serialized. >>>>> >>>>> Sent from my phone >>>>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >>>>> >>>>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>>>>> Shouldn't java.util.Optional be Serializable? Is there a good reason >>>>>> for >>>>>> it not be? >>>>>>> wrong question. >>>>>> the right one is why do you want Optional to be Serializable. >>>>>> >>>>>> Thanks, >>>>>> >>>>>>> Pete >>>>>>> >>>>>>> cheers, >>>>>> R?mi >>>>>> >>>>>> >>>>>> From stuart.marks at oracle.com Thu Sep 19 23:21:10 2013 From: stuart.marks at oracle.com (Stuart Marks) Date: Thu, 19 Sep 2013 23:21:10 -0700 Subject: Result: New JDK 8 Committer: Attila Szegedi (attila) Message-ID: <523BE956.7040002@oracle.com> Voting for Attila Szegedi [1] is now closed. Yes: 24 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Congratulations, Attila! s'marks [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003109.html From staffan.larsen at oracle.com Fri Sep 20 00:43:35 2013 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Fri, 20 Sep 2013 09:43:35 +0200 Subject: Result: New JDK8 Committer: Erik Gahlin Message-ID: Voting for Erik Gahlin [1] is now closed. Yes: 19 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. /Staffan [1] http://mail.openjdk.java.net/pipermail/jdk8-dev/2013-September/003124.html From eamonn at mcmanus.net Fri Sep 20 10:55:12 2013 From: eamonn at mcmanus.net (Eamonn McManus) Date: Fri, 20 Sep 2013 10:55:12 -0700 Subject: Shouldn't Optional be Serializable? In-Reply-To: <523B4E94.5090809@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> Message-ID: > yes and no, > it depends how your RPC framework map errors because if you send an Optional > and then throw an exception in the client you will not have a meaningful stack trace. I don't understand what this means. Concretely, why would you not want Optional to be a valid return type of an RMI method? ?amonn 2013/9/19 Remi Forax > On 09/18/2013 07:32 PM, Pete Poulos wrote: > >> One use case to consider here is RPC. many RPC frameworks use >> serialization >> to transmit the results of the RPC call over the network. If Optional is >> not serializable then you will be unable to return Optional results from >> methods invoked via RPC. >> > > yes and no, > it depends how your RPC framework map errors because if you send an > Optional > and then throw an exception in the client you will not have a meaningful > stack trace. > > R?mi > > > On Sep 18, 2013 11:13 AM, "Joseph Unruh" wrote: >> >> While It's clear that there are performance implications to using an >>> Optional field, keeping Optional non-serializable doesn't do much to >>> prevent that from happening. In the vast majority of cases, Optional will >>> be used in a non-serialized context. So, as preventative measures go, >>> this >>> isn't a very effective one. >>> >>> Second, Optional exists primarily as a mechanism for marking that an >>> object >>> may be null. This is a design objective. If the objective was >>> performance, >>> then Optional wouldn't exist. Enforcing this usage on people, >>> particularly >>> in the narrow context of serialization, is a premature optimization. If >>> it's useful to have optional exist at the API level in order to prevent >>> NPEs, why can't it be useful at the individual class level to prevent >>> NPEs? >>> >>> Cheers, >>> Joseph >>> >>> >>> On Tue, Sep 17, 2013 at 11:37 PM, Remi Forax wrote: >>> >>> There is a good reason to not allow Optional to implement Serializable, >>>> it promotes a bad way to use Optional, at least from the VM point of >>>> >>> view. >>> >>>> For the VM, Optional is a boxing, very similar to a boxing to Integer >>>> (in fact it's a little better because Integer.valueOf is badly* >>>> specified >>>> in the JLS >>>> but that's another story). >>>> >>>> so if you write: >>>> class Foo { >>>> private Optional description; >>>> >>>> public Optional getDescription() { >>>> return description; >>>> } >>>> } >>>> >>>> This implementation id bad for two reasons, the first one is that you >>>> >>> have >>> >>>> to do >>>> a double indirection so will double your chance to have a value that is >>>> >>> not >>> >>>> in the cache but in RAM when you want the underlying String. >>>> The second reason is that the VM will usually not be able to remove the >>>> boxing because the creation of Optional will be too far from the use. >>>> >>>> There is a better implementation >>>> class Foo { >>>> private String description; // warning nullable ! >>>> >>>> public Optional getDescription() { >>>> return Optional.fromNullable(****description); >>>> } >>>> } >>>> >>>> It's the same API from the user point of view, but the creation of >>>> >>> Optional >>> >>>> is in the same inline horizon that it's use if getDescription is inlined >>>> (and here given that the method is really small, the is a good chance). >>>> In that case the VM is able to remove the boxing and everybody is happy. >>>> >>>> So making Optional serializable goes in the wrong direction. >>>> >>>> cheers, >>>> R?mi >>>> * as we now now in 2013, it was less obvious when the decision was taken >>>> circa 2003. >>>> >>>> >>>> On 09/18/2013 03:16 AM, Pete Poulos wrote: >>>> >>>> Optional holds data and while the vast majority of use cases for >>>>> >>>> Optional >>> >>>> will be to immediately pull the value out and do something, that doesn't >>>>> change the fact that it is still a data structure, somebody somewhere >>>>> is >>>>> going to need to serialize it for some reason. The other data >>>>> >>>> structures >>> >>>> in the java.util package are Serializable so making Optional >>>>> >>>> Serializable >>> >>>> makes things consistent. >>>>> >>>>> As far as I know the cost of adding Serializable to Optional is >>>>> negligible, >>>>> but the cost could be fairly significant to someone who needs to >>>>> >>>> serialize >>> >>>> it at some point and is unable to do so. >>>>> >>>>> Anyhow, I'm currently designing a set of functional (immutable, >>>>> persistent) >>>>> data structures for JDK8+ and I'm debating replacing my "Maybe" class >>>>> (functionally the same as Optional, but with Haskell's naming >>>>> convention >>>>> for this data structure) the JDK8 Optional and I'm concerned that the >>>>> >>>> lack >>> >>>> of Serializable on Optional would cause problems for potential users of >>>>> >>>> my >>> >>>> API. >>>>> >>>>> I'm only using Optional/Maybe to wrap return values from methods so I >>>>> >>>> can >>> >>>> indicate missing/present values within my data structures, so I could >>>>> conceivably use Optional and still support serialization. >>>>> >>>>> Also, while we are having this discussion, is there an alternative to >>>>> serialization that is considered superior? Over the years I have read >>>>> blog >>>>> posts by people condemning serialization, but I don't recall seeing any >>>>> alternatives suggested. >>>>> >>>>> Thanks, >>>>> Pete >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich >>>> >>>>>> wrote: >>>>>> >>>>> Presumably because you may want to have class fields that express >>>>> >>>>>> nullability via Optional rather than null. Whether that's a good >>>>>> >>>>> design >>> >>>> or >>>>>> not is a separate question; conceptually, I don't see a reason why >>>>>> Optional >>>>>> cannot support that. For "reference", Google Guava's version is >>>>>> serializable. If someone were to replace their use with jdk's >>>>>> Optional >>>>>> then they will hit exceptions if the owner class is serialized. >>>>>> >>>>>> Sent from my phone >>>>>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >>>>>> >>>>>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>>>>> >>>>>>> Shouldn't java.util.Optional be Serializable? Is there a good >>>>>>> reason >>>>>>> for >>>>>>> it not be? >>>>>>> >>>>>>>> wrong question. >>>>>>>> >>>>>>> the right one is why do you want Optional to be Serializable. >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> Pete >>>>>>>> >>>>>>>> cheers, >>>>>>>> >>>>>>> R?mi >>>>>>> >>>>>>> >>>>>>> >>>>>>> > From martinrb at google.com Fri Sep 20 12:46:56 2013 From: martinrb at google.com (Martin Buchholz) Date: Fri, 20 Sep 2013 12:46:56 -0700 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> Message-ID: Both Collections.emptyList and Collections.singleton are serializable. I think of Optional as a zero-or-one collection, so it should be serializable too. From forax at univ-mlv.fr Sat Sep 21 10:25:57 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 21 Sep 2013 19:25:57 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> Message-ID: <523DD6A5.30002@univ-mlv.fr> On 09/20/2013 07:55 PM, Eamonn McManus wrote: > > yes and no, > > it depends how your RPC framework map errors because if you send an > Optional > > and then throw an exception in the client you will not have a > meaningful stack trace. > > I don't understand what this means. Concretely, why would you not want > Optional to be a valid return type of an RMI method? Hi ?amonn, yes, returning an Optional for a service means that you may return null which is usually a bad practice, given the overhead of being over the wire, it's usully better to throw an exception with a meaningful error message. > > ?amonn R?mi > > > 2013/9/19 Remi Forax > > > On 09/18/2013 07:32 PM, Pete Poulos wrote: > > One use case to consider here is RPC. many RPC frameworks use > serialization > to transmit the results of the RPC call over the network. If > Optional is > not serializable then you will be unable to return Optional > results from > methods invoked via RPC. > > > yes and no, > it depends how your RPC framework map errors because if you send > an Optional > and then throw an exception in the client you will not have a > meaningful stack trace. > > R?mi > > > On Sep 18, 2013 11:13 AM, "Joseph Unruh" > wrote: > > While It's clear that there are performance implications > to using an > Optional field, keeping Optional non-serializable doesn't > do much to > prevent that from happening. In the vast majority of > cases, Optional will > be used in a non-serialized context. So, as preventative > measures go, this > isn't a very effective one. > > Second, Optional exists primarily as a mechanism for > marking that an object > may be null. This is a design objective. If the objective > was performance, > then Optional wouldn't exist. Enforcing this usage on > people, particularly > in the narrow context of serialization, is a premature > optimization. If > it's useful to have optional exist at the API level in > order to prevent > NPEs, why can't it be useful at the individual class level > to prevent NPEs? > > Cheers, > Joseph > > > On Tue, Sep 17, 2013 at 11:37 PM, Remi Forax > > wrote: > > There is a good reason to not allow Optional to > implement Serializable, > it promotes a bad way to use Optional, at least from > the VM point of > > view. > > For the VM, Optional is a boxing, very similar to a > boxing to Integer > (in fact it's a little better because Integer.valueOf > is badly* specified > in the JLS > but that's another story). > > so if you write: > class Foo { > private Optional description; > > public Optional getDescription() { > return description; > } > } > > This implementation id bad for two reasons, the first > one is that you > > have > > to do > a double indirection so will double your chance to > have a value that is > > not > > in the cache but in RAM when you want the underlying > String. > The second reason is that the VM will usually not be > able to remove the > boxing because the creation of Optional will be too > far from the use. > > There is a better implementation > class Foo { > private String description; // warning nullable ! > > public Optional getDescription() { > return Optional.fromNullable(**description); > } > } > > It's the same API from the user point of view, but the > creation of > > Optional > > is in the same inline horizon that it's use if > getDescription is inlined > (and here given that the method is really small, the > is a good chance). > In that case the VM is able to remove the boxing and > everybody is happy. > > So making Optional serializable goes in the wrong > direction. > > cheers, > R?mi > * as we now now in 2013, it was less obvious when the > decision was taken > circa 2003. > > > On 09/18/2013 03:16 AM, Pete Poulos wrote: > > Optional holds data and while the vast majority of > use cases for > > Optional > > will be to immediately pull the value out and do > something, that doesn't > change the fact that it is still a data structure, > somebody somewhere is > going to need to serialize it for some reason. > The other data > > structures > > in the java.util package are Serializable so > making Optional > > Serializable > > makes things consistent. > > As far as I know the cost of adding Serializable > to Optional is > negligible, > but the cost could be fairly significant to > someone who needs to > > serialize > > it at some point and is unable to do so. > > Anyhow, I'm currently designing a set of > functional (immutable, > persistent) > data structures for JDK8+ and I'm debating > replacing my "Maybe" class > (functionally the same as Optional, but with > Haskell's naming convention > for this data structure) the JDK8 Optional and I'm > concerned that the > > lack > > of Serializable on Optional would cause problems > for potential users of > > my > > API. > > I'm only using Optional/Maybe to wrap return > values from methods so I > > can > > indicate missing/present values within my data > structures, so I could > conceivably use Optional and still support > serialization. > > Also, while we are having this discussion, is > there an alternative to > serialization that is considered superior? Over > the years I have read > blog > posts by people condemning serialization, but I > don't recall seeing any > alternatives suggested. > > Thanks, > Pete > > > > > > > On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich > > > wrote: > > Presumably because you may want to have class > fields that express > > nullability via Optional rather than null. > Whether that's a good > > design > > or > not is a separate question; conceptually, I > don't see a reason why > Optional > cannot support that. For "reference", Google > Guava's version is > serializable. If someone were to replace > their use with jdk's Optional > then they will hit exceptions if the owner > class is serialized. > > Sent from my phone > On Sep 17, 2013 6:06 PM, "Remi Forax" > > > wrote: > > On 09/17/2013 11:44 PM, Pete Poulos wrote: > > Shouldn't java.util.Optional be > Serializable? Is there a good reason > for > it not be? > > wrong question. > > the right one is why do you want Optional > to be Serializable. > > Thanks, > > Pete > > cheers, > > R?mi > > > > > From forax at univ-mlv.fr Sat Sep 21 10:31:48 2013 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 21 Sep 2013 19:31:48 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> Message-ID: <523DD804.5090907@univ-mlv.fr> On 09/20/2013 09:46 PM, Martin Buchholz wrote: > Both Collections.emptyList and Collections.singleton are serializable. > I think of Optional as a zero-or-one collection, so it should be > serializable too. > > Hi Martin, if Optional is a zero-or-one collection, it should implements Collection, it doesn't. Optional is the result of a computation that can be something or none. If you want to see Optional as a collection of zero-or-one element, I think it's better to have a method asSet like Guava. cheers, R?mi From simone.bordet at gmail.com Sat Sep 21 12:35:59 2013 From: simone.bordet at gmail.com (Simone Bordet) Date: Sat, 21 Sep 2013 12:35:59 -0700 Subject: Shouldn't Optional be Serializable? In-Reply-To: <523DD6A5.30002@univ-mlv.fr> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> <523DD6A5.30002@univ-mlv.fr> Message-ID: Hi, On Sat, Sep 21, 2013 at 10:25 AM, Remi Forax wrote: > On 09/20/2013 07:55 PM, Eamonn McManus wrote: >> >> > yes and no, >> > it depends how your RPC framework map errors because if you send an >> > Optional >> > and then throw an exception in the client you will not have a meaningful >> > stack trace. >> >> I don't understand what this means. Concretely, why would you not want >> Optional to be a valid return type of an RMI method? > > > Hi ?amonn, > yes, returning an Optional for a service means that you may return null > which is usually a bad practice, > given the overhead of being over the wire, it's usully better to throw an > exception with a meaningful error message. Like ?amonn, I don't follow your reasoning. "Usually a bad practice", "usually better to throw" seem your opinions, and seem weak to base such an (important) decision on opinions only. Do you have more important insights that we're missing ? Does not throwing an exception via RMI have at least the same or even greater overhead than returning Optional ? Did you measure the overhead that retuning a serializable Optional produces ? Thanks ! -- Simone Bordet http://bordet.blogspot.com --- Finally, no matter how good the architecture and design are, to deliver bug-free software with optimal performance and reliability, the implementation technique must be flawless. Victoria Livschitz From mark at talios.com Sun Sep 22 22:30:50 2013 From: mark at talios.com (Mark Derricutt) Date: Mon, 23 Sep 2013 17:30:50 +1200 Subject: Strange covariant/generics downcasting issue with JDK8 Message-ID: Hi all, Since you're all enjoying JavaOne at the moment I was thinking it was about time that I starting building $work's project under JDK8 and give it some love over my normal small projects and ran into an odd issue with generics/covariant returns that works fine under 7u40 and breaks under 8DP. I've extracted this into a simple project [1] which I've pushed to github, I've added a comment on the code that breaks under JDK8. The code in question is: List strings? assertThat(strings).describedAs("test") .isNotEmpty() .has(regexMatch("th.*")) .doesNotHave(regexMatch("moo.*")) .hasSize(3); When calling assertThat(strings) a class of type ListAssertion is returned, and passed along the call chain. The problem appears to be that when doesNotHave() returns, javac no longer sees a ListAssertion but rather a top level AbstractAssertion on which doesNotHave is defined: /** {@inheritDoc} */ public S has(Condition condition) { conditions.assertHas(info, actual, condition); return myself; } /** {@inheritDoc} */ public S doesNotHave(Condition condition) { conditions.assertDoesNotHave(info, actual, condition); return myself; } Now, both has() and doesNotHave() appear to have the exact same signature, yet commenting out the call to doesNotHave() doesn't appear to trigger what appears to be a down casting to AbstractAssertion which doesn't include a method called hasSize(), the output I see from javac is: ~/D/covariantfail (master|?) $ /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/java -version java version "1.8.0-ea" Java(TM) SE Runtime Environment (build 1.8.0-ea-b106) Java HotSpot(TM) 64-Bit Server VM (build 25.0-b48, mixed mode) ~/D/covariantfail (master|?) $ /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/javac -version javac 1.8.0-ea /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/javac -d /Users/amrk/Dropbox/covariantfail/target/test-classes -classpath /Users/amrk/Dropbox/covariantfail/target/test-classes:/Users/amrk/Dropbox/covariantfail/target/classes:/Users/amrk/.m2/repository/org/testng/testng/6.8.5/testng-6.8.5.jar:/Users/amrk/.m2/repository/junit/junit/4.10/junit-4.10.jar:/Users/amrk/.m2/repository/org/hamcrest/hamcrest-core/1.1/hamcrest-core-1.1.jar:/Users/amrk/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar:/Users/amrk/.m2/repository/com/beust/jcommander/1.27/jcommander-1.27.jar:/Users/amrk/.m2/repository/org/yaml/snakeyaml/1.6/snakeyaml-1.6.jar:/Users/amrk/.m2/repository/org/easytesting/fest-assert-core/2.0M10/fest-assert-core-2.0M10.jar:/Users/amrk/.m2/repository/org/easytesting/fest-util/1.2.5/fest-util-1.2.5.jar: -sourcepath /Users/amrk/Dropbox/covariantfail/src/test/java: /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/RegexMatch.java /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java -g -nowarn -target 1.5 -source 1.5 -encoding UTF-8 /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java:37: error: cannot find symbol .hasSize(3); ^ symbol: method hasSize(int) location: class AbstractAssert Note: /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 1 error Is this a known bug in the JDK at all? I'm quite surprised no one else has hit something like this before if its not? [1] https://github.com/talios/jdk8-covariantfail [2] https://github.com/talios/jdk8-covariantfail/commit/faa016e57f754230da46e3453b964d497ec065b5#commitcomment-4151896 -- Mark Derricutt ( mark at talios.com ) ? twitter: https://twitter.com/talios ? podcast: http://www.illegalargument.com ? blog: http://www.theoryinpractice.net ? google+: http://gplus.to/talios From vicente.romero at oracle.com Mon Sep 23 01:02:21 2013 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 23 Sep 2013 09:02:21 +0100 Subject: Strange covariant/generics downcasting issue with JDK8 In-Reply-To: References: Message-ID: <523FF58D.10409@oracle.com> Hi Mark, Any javac issue should be submitted to compiler-dev at ... which is the correct list for this, Thanks, Vicente On 23/09/13 06:30, Mark Derricutt wrote: > Hi all, > > Since you're all enjoying JavaOne at the moment I was thinking it was about time that I starting building $work's project under JDK8 and give it some love over my normal small projects and ran into an odd issue with generics/covariant returns that works fine under 7u40 and breaks under 8DP. > > I've extracted this into a simple project [1] which I've pushed to github, I've added a comment on the code that breaks under JDK8. > > The code in question is: > > List strings? > > assertThat(strings).describedAs("test") > .isNotEmpty() > .has(regexMatch("th.*")) > .doesNotHave(regexMatch("moo.*")) > .hasSize(3); > > When calling assertThat(strings) a class of type ListAssertion is returned, and passed along the call chain. > > The problem appears to be that when doesNotHave() returns, javac no longer sees a ListAssertion but rather a top level AbstractAssertion on which doesNotHave is defined: > > /** {@inheritDoc} */ > public S has(Condition condition) { > conditions.assertHas(info, actual, condition); > return myself; > } > > /** {@inheritDoc} */ > public S doesNotHave(Condition condition) { > conditions.assertDoesNotHave(info, actual, condition); > return myself; > } > > Now, both has() and doesNotHave() appear to have the exact same signature, yet commenting out the call to doesNotHave() doesn't appear to trigger what appears to be a down casting to AbstractAssertion which doesn't include a method called hasSize(), the output I see from javac is: > > ~/D/covariantfail (master|?) $ /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/java -version > java version "1.8.0-ea" > Java(TM) SE Runtime Environment (build 1.8.0-ea-b106) > Java HotSpot(TM) 64-Bit Server VM (build 25.0-b48, mixed mode) > > ~/D/covariantfail (master|?) $ /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/javac -version > javac 1.8.0-ea > > /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/javac -d /Users/amrk/Dropbox/covariantfail/target/test-classes -classpath /Users/amrk/Dropbox/covariantfail/target/test-classes:/Users/amrk/Dropbox/covariantfail/target/classes:/Users/amrk/.m2/repository/org/testng/testng/6.8.5/testng-6.8.5.jar:/Users/amrk/.m2/repository/junit/junit/4.10/junit-4.10.jar:/Users/amrk/.m2/repository/org/hamcrest/hamcrest-core/1.1/hamcrest-core-1.1.jar:/Users/amrk/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar:/Users/amrk/.m2/repository/com/beust/jcommander/1.27/jcommander-1.27.jar:/Users/amrk/.m2/repository/org/yaml/snakeyaml/1.6/snakeyaml-1.6.jar:/Users/amrk/.m2/repository/org/easytesting/fest-assert-core/2.0M10/fest-assert-core-2.0M10.jar:/Users/amrk/.m2/repository/org/easytesting/fest-util/1.2.5/fest-util-1.2.5.jar: -sourcepath /Users/amrk/Dropbox/covariantfail/src/test/java: /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/RegexMatch.java /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java -g -nowarn -target 1.5 -source 1.5 -encoding UTF-8 > /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java:37: error: cannot find symbol > .hasSize(3); > ^ > symbol: method hasSize(int) > location: class AbstractAssert > Note: /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 1 error > > > Is this a known bug in the JDK at all? I'm quite surprised no one else has hit something like this before if its not? > > > > > [1] https://github.com/talios/jdk8-covariantfail > [2] https://github.com/talios/jdk8-covariantfail/commit/faa016e57f754230da46e3453b964d497ec065b5#commitcomment-4151896 > > > > -- Mark Derricutt ( mark at talios.com ) > ? twitter: https://twitter.com/talios > ? podcast: http://www.illegalargument.com > ? blog: http://www.theoryinpractice.net > ? google+: http://gplus.to/talios > From neugens.limasoftware at gmail.com Mon Sep 23 05:52:26 2013 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Mon, 23 Sep 2013 14:52:26 +0200 Subject: Strange covariant/generics downcasting issue with JDK8 In-Reply-To: References: Message-ID: > AppTest.java -g -nowarn -target 1.5 -source 1.5 This looks like the cause, no? Cheers, Mario Il giorno 23/set/2013 07:33, "Mark Derricutt" ha scritto: > Hi all, > > Since you're all enjoying JavaOne at the moment I was thinking it was > about time that I starting building $work's project under JDK8 and give it > some love over my normal small projects and ran into an odd issue with > generics/covariant returns that works fine under 7u40 and breaks under 8DP. > > I've extracted this into a simple project [1] which I've pushed to github, > I've added a comment on the code that breaks under JDK8. > > The code in question is: > > List strings? > > assertThat(strings).describedAs("test") > .isNotEmpty() > .has(regexMatch("th.*")) > .doesNotHave(regexMatch("moo.*")) > .hasSize(3); > > When calling assertThat(strings) a class of type ListAssertion is > returned, and passed along the call chain. > > The problem appears to be that when doesNotHave() returns, javac no longer > sees a ListAssertion but rather a top level AbstractAssertion on which > doesNotHave is defined: > > /** {@inheritDoc} */ > public S has(Condition condition) { > conditions.assertHas(info, actual, condition); > return myself; > } > > /** {@inheritDoc} */ > public S doesNotHave(Condition condition) { > conditions.assertDoesNotHave(info, actual, condition); > return myself; > } > > Now, both has() and doesNotHave() appear to have the exact same signature, > yet commenting out the call to doesNotHave() doesn't appear to trigger what > appears to be a down casting to AbstractAssertion which doesn't include a > method called hasSize(), the output I see from javac is: > > ~/D/covariantfail (master|?) $ > /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/java > -version > java version "1.8.0-ea" > Java(TM) SE Runtime Environment (build 1.8.0-ea-b106) > Java HotSpot(TM) 64-Bit Server VM (build 25.0-b48, mixed mode) > > ~/D/covariantfail (master|?) $ > /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/javac > -version > javac 1.8.0-ea > > /Library/Java/JavaVirtualMachines/jdk1.8.0.jdk/Contents/Home/bin/javac -d > /Users/amrk/Dropbox/covariantfail/target/test-classes -classpath > /Users/amrk/Dropbox/covariantfail/target/test-classes:/Users/amrk/Dropbox/covariantfail/target/classes:/Users/amrk/.m2/repository/org/testng/testng/6.8.5/testng-6.8.5.jar:/Users/amrk/.m2/repository/junit/junit/4.10/junit-4.10.jar:/Users/amrk/.m2/repository/org/hamcrest/hamcrest-core/1.1/hamcrest-core-1.1.jar:/Users/amrk/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar:/Users/amrk/.m2/repository/com/beust/jcommander/1.27/jcommander-1.27.jar:/Users/amrk/.m2/repository/org/yaml/snakeyaml/1.6/snakeyaml-1.6.jar:/Users/amrk/.m2/repository/org/easytesting/fest-assert-core/2.0M10/fest-assert-core-2.0M10.jar:/Users/amrk/.m2/repository/org/easytesting/fest-util/1.2.5/fest-util-1.2.5.jar: > -sourcepath /Users/amrk/Dropbox/covariantfail/src/test/java: > /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/RegexMatch.java > /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java -g > -nowarn -target 1.5 -source 1.5 -encoding UTF-8 > /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java:37: > error: cannot find symbol > .hasSize(3); > ^ > symbol: method hasSize(int) > location: class AbstractAssert > Note: > /Users/amrk/Dropbox/covariantfail/src/test/java/com/talios/AppTest.java > uses unchecked or unsafe operations. > Note: Recompile with -Xlint:unchecked for details. > 1 error > > > Is this a known bug in the JDK at all? I'm quite surprised no one else has > hit something like this before if its not? > > > > > [1] https://github.com/talios/jdk8-covariantfail > [2] > https://github.com/talios/jdk8-covariantfail/commit/faa016e57f754230da46e3453b964d497ec065b5#commitcomment-4151896 > > > > -- Mark Derricutt ( mark at talios.com ) > ? twitter: https://twitter.com/talios > ? podcast: http://www.illegalargument.com > ? blog: http://www.theoryinpractice.net > ? google+: http://gplus.to/talios > > From mark at talios.com Mon Sep 23 16:26:29 2013 From: mark at talios.com (Mark Derricutt) Date: Tue, 24 Sep 2013 11:26:29 +1200 Subject: Strange covariant/generics downcasting issue with JDK8 In-Reply-To: References: Message-ID: <64412D7C-9384-4B6E-82C7-58360646AE4C@talios.com> On 24/09/2013, at 12:52 AM, Mario Torre wrote: > > AppTest.java -g -nowarn -target 1.5 -source 1.5 > > This looks like the cause, no? > I had thought maybe as well, but I get the same issue with "-target 1.8 -source 1.8", and if javac no longer supports 1.5 I would have expected an "invalid source release" error earlier in the process. -- Mark Derricutt ( mark at talios.com ) ? twitter: https://twitter.com/talios ? podcast: http://www.illegalargument.com ? blog: http://www.theoryinpractice.net ? google+: http://gplus.to/talios From alejandro.murillo at oracle.com Tue Sep 24 14:07:02 2013 From: alejandro.murillo at oracle.com (alejandro.murillo at oracle.com) Date: Tue, 24 Sep 2013 21:07:02 +0000 Subject: hg: jdk8/jdk8/hotspot: 75 new changesets Message-ID: <20130924210948.E083E62AA5@hg.openjdk.java.net> Changeset: e42e456fbe6e Author: amurillo Date: 2013-09-13 00:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/e42e456fbe6e 8024764: new hotspot build - hs25-b51 Reviewed-by: jcoomes ! make/hotspot_version Changeset: baa7927dfbd2 Author: zgu Date: 2013-09-04 08:55 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/baa7927dfbd2 8022798: "assert(seq > 0) failed: counter overflow" in Kitchensink Summary: Removed incorrect assertion, sequence number can overflow Reviewed-by: dholmes, kamg ! src/share/vm/services/memPtr.cpp Changeset: 38f750491293 Author: iklam Date: 2013-09-06 08:42 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/38f750491293 8022335: Native stack walk while generating hs_err does not work on Windows x64 Summary: Use WinDbg API StackWalk64() Reviewed-by: zgu, dholmes ! src/os/windows/vm/decoder_windows.cpp ! src/os/windows/vm/decoder_windows.hpp ! src/os_cpu/windows_x86/vm/os_windows_x86.cpp ! src/os_cpu/windows_x86/vm/os_windows_x86.hpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/decoder.cpp ! src/share/vm/utilities/decoder.hpp ! src/share/vm/utilities/vmError.cpp ! src/share/vm/utilities/vmError.hpp Changeset: 592520c14121 Author: kevinw Date: 2013-09-09 10:01 +0100 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/592520c14121 8023478: Test fails with HS crash in GCNotifier. Reviewed-by: sla ! src/share/vm/services/gcNotifier.cpp Changeset: b6767a18b379 Author: hseigel Date: 2013-09-09 14:44 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b6767a18b379 8023167: JVM allows duplicate Runtime[In]VisibleTypeAnnotations attributes in ClassFile/field_info/method_info structures Summary: Add checks for duplicates and issue errors when detected. Reviewed-by: coleenp, zgu ! src/share/vm/classfile/classFileParser.cpp Changeset: 0f648fbe4404 Author: dsamersoff Date: 2013-09-11 14:30 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/0f648fbe4404 8024056: runtime/InitialThreadOverflow/testme.sh fails Summary: on some macines gcc not able to link cxx program Reviewed-by: dholmes ! test/runtime/InitialThreadOverflow/testme.sh Changeset: 1c6b721a3fbf Author: dsamersoff Date: 2013-09-12 15:53 +0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/1c6b721a3fbf 8022617: Openjdk hotspot build is broken on BSD platforms using gcc Summary: Enforce of preprocessing of all assembly sources by assembler-with-cpp Reviewed-by: dholmes, erikj ! make/bsd/makefiles/gcc.make Changeset: 225cedaf9a4b Author: zgu Date: 2013-09-13 10:34 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/225cedaf9a4b Merge ! src/share/vm/classfile/classFileParser.cpp Changeset: 623d923529df Author: mgronlun Date: 2013-09-13 17:47 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/623d923529df 8021353: Event based tracing is missing thread exit Reviewed-by: allwin, acorn, dcubed, dholmes, egahlin ! src/share/vm/runtime/thread.cpp ! src/share/vm/trace/traceMacros.hpp Changeset: b89a1a870965 Author: mgronlun Date: 2013-09-13 19:20 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b89a1a870965 Merge ! src/share/vm/runtime/thread.cpp Changeset: ff8a09595db3 Author: sspitsyn Date: 2013-09-13 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ff8a09595db3 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed Summary: Handle pending exceptions instead of firing a guarantee() Reviewed-by: coleenp, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: ce5ee9de50ce Author: sspitsyn Date: 2013-09-13 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ce5ee9de50ce 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool Summary: The OOME's in the JVMTI merge_cp_and_rewrite and set_new_constant_pool must be handled correctly Reviewed-by: coleenp, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: 0d3ff4d36a31 Author: sspitsyn Date: 2013-09-13 12:48 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/0d3ff4d36a31 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated Summary: Pending exceptions must be handled properly after a call to the JVMTI merge_cp_and_rewrite Reviewed-by: coleenp, dholmes Contributed-by: serguei.spitsyn at oracle.com ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: b135b600a66c Author: sspitsyn Date: 2013-09-13 16:56 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b135b600a66c Merge Changeset: 2e6938dd68f2 Author: dholmes Date: 2013-09-16 07:38 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2e6938dd68f2 6900441: PlatformEvent.park(millis) on Linux could still be affected by changes to the time-of-day clock Summary: Associate CLOCK_MONOTONIC with the pthread_cond_t objects used for relative timed waits Reviewed-by: dcubed, shade ! src/os/linux/vm/os_linux.cpp ! src/os/linux/vm/os_linux.hpp Changeset: 4472884d8b37 Author: dcubed Date: 2013-09-16 12:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/4472884d8b37 6986195: correctly identify Ubuntu as the operating system in crash report instead of "Debian" Summary: Cleanup and document how various Linux release info files are used by print_distro_info(). Reviewed-by: dcubed, dsamersoff, coleenp, iklam, omajid Contributed-by: gerald.thornbrugh at oracle.com ! src/os/linux/vm/os_linux.cpp Changeset: 42863137168c Author: acorn Date: 2013-09-16 17:57 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/42863137168c 8024647: Default method resolution with private superclass method Reviewed-by: kamg, minqi ! src/share/vm/classfile/defaultMethods.cpp Changeset: 921967020b3b Author: acorn Date: 2013-09-16 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/921967020b3b Merge Changeset: 621eda7235d2 Author: minqi Date: 2013-09-16 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/621eda7235d2 7164841: Improvements to the GC log file rotation Summary: made changes to easily identify current log file in rotation. Parameterize the input with %t for time replacement in file name. Reviewed-by: ccheung, tschatzl, tamao, zgu Contributed-by: yumin.qi at oracle.com ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp Changeset: 535973ddf22c Author: minqi Date: 2013-09-16 18:39 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/535973ddf22c Merge Changeset: 88d6b9a1c27c Author: mseledtsov Date: 2013-09-17 20:09 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/88d6b9a1c27c 8016029: test runtime/6878713/Test6878713.sh failed Summary: Rewrote test in Java; updated the test condition to reflect latest changes in the source Reviewed-by: dholmes, ctornqvi - test/runtime/6878713/Test6878713.sh - test/runtime/6878713/testcase.jar + test/runtime/ClassFile/OomWhileParsingRepeatedJsr.java + test/runtime/ClassFile/testcase.jar Changeset: 6f45933aef35 Author: mseledtsov Date: 2013-09-17 20:20 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6f45933aef35 7149464: [TESTBUG] Test runtime/7020373/Test7020373.sh failed to clean up files after test Summary: Re-wrote in Java, this also eliminated temporary result file; set upper limit on malloc'd memory Reviewed-by: dcubed, dholmes, ccheung - test/runtime/7020373/Test7020373.sh - test/runtime/7020373/testcase.jar + test/runtime/ClassFile/JsrRewriting.java + test/runtime/ClassFile/JsrRewritingTestCase.jar Changeset: 41e6ae9f6dd7 Author: zgu Date: 2013-09-18 12:52 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/41e6ae9f6dd7 Merge - test/runtime/6878713/Test6878713.sh - test/runtime/6878713/testcase.jar - test/runtime/7020373/Test7020373.sh - test/runtime/7020373/testcase.jar Changeset: 8e94527f601e Author: bpittore Date: 2013-09-11 20:03 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8e94527f601e 8024007: Misc. cleanup of static agent code Summary: Minor cleanup of static agent code from 8014135 Reviewed-by: dcubed, sspitsyn ! src/os/windows/vm/os_windows.cpp ! src/share/vm/prims/jvmti.xml ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp Changeset: de88570fabfc Author: dholmes Date: 2013-09-11 00:38 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/de88570fabfc 8024256: Minimal VM build is broken with PCH disabled Reviewed-by: coleenp, twisti ! make/excludeSrc.make ! src/share/vm/gc_implementation/shared/allocationStats.hpp ! src/share/vm/gc_implementation/shared/hSpaceCounters.hpp ! src/share/vm/memory/binaryTreeDictionary.cpp ! src/share/vm/utilities/yieldingWorkgroup.hpp Changeset: 4c9d415db1c5 Author: dholmes Date: 2013-09-11 23:49 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/4c9d415db1c5 Merge Changeset: b1491b0303ee Author: bdelsart Date: 2013-09-13 07:47 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b1491b0303ee Merge Changeset: 10efeefa6485 Author: dholmes Date: 2013-09-13 21:36 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/10efeefa6485 8024505: [TESTBUG] update test groups for additional tests that can't run on the minimal VM Reviewed-by: coleenp, hseigel ! test/TEST.groups Changeset: cc5b40a76049 Author: bdelsart Date: 2013-09-18 21:47 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/cc5b40a76049 Merge ! src/share/vm/runtime/thread.cpp Changeset: 7944aba7ba41 Author: ehelin Date: 2013-08-12 17:37 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/7944aba7ba41 8015107: NPG: Use consistent naming for metaspace concepts Reviewed-by: coleenp, mgerdin, hseigel ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_MacroAssembler_sparc.cpp ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/c1_FrameMap_x86.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/arrayOop.hpp ! src/share/vm/oops/instanceOop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/connode.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/memoryService.cpp + test/gc/arguments/TestCompressedClassFlags.java - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java + test/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java ! test/gc/metaspace/TestMetaspaceMemoryPool.java ! test/gc/metaspace/TestMetaspacePerfCounters.java ! test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrs.java ! test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrsError.java ! test/runtime/CompressedOops/CompressedKlassPointerAndOops.java Changeset: 440edcf30231 Author: mgerdin Date: 2013-09-11 08:57 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/440edcf30231 8024176: [macosx] gc/metaspace/ClassMetaspaceSizeInJmapHeap.java failed since jdk8b105, hs25b47 Summary: The code for reading compressed klass pointers in the sa-agent on Mac used readCompOopAddress instead of readCompKlassAddress, this is wrong but has been hidden because compressed oops and compressed klasses has used the same base address in the past. Reviewed-by: sla, jmasa Contributed-by: stefan.johansson at oracle.com ! agent/src/share/classes/sun/jvm/hotspot/debugger/bsd/BsdAddress.java Changeset: f7bc2ab5f659 Author: tschatzl Date: 2013-09-11 10:14 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f7bc2ab5f659 8016825: Large pages for the heap broken on Windows for compressed oops Summary: Correctly pass the requested base address for the heap to the OS function to reserve memory. Reviewed-by: brutisso, stefank ! src/os/windows/vm/os_windows.cpp Changeset: ff218fdb30ba Author: tschatzl Date: 2013-09-11 10:19 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ff218fdb30ba 8021823: G1: Concurrent marking crashes with -XX:ObjectAlignmentInBytes>=32 in 64bit VMs Summary: Correctly calculate the initialization value for the shift between object start and bitmap bit in the G1 mark bitmaps. Reviewed-by: tonyp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp + test/gc/TestObjectAlignment.java Changeset: 040895ec3920 Author: tschatzl Date: 2013-09-11 12:03 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/040895ec3920 Merge Changeset: 24e87613ee58 Author: mgerdin Date: 2013-09-11 09:37 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/24e87613ee58 8009561: NPG: Metaspace fragmentation when retiring a Metachunk Summary: Use best-fit block-splitting freelist allocation from the block freelist. Reviewed-by: jmasa, stefank ! src/share/vm/memory/metaspace.cpp Changeset: 6608fa23708f Author: mgerdin Date: 2013-09-11 06:15 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6608fa23708f Merge Changeset: 40136aa2cdb1 Author: tschatzl Date: 2013-09-11 16:25 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/40136aa2cdb1 8010722: assert: failed: heap size is too big for compressed oops Summary: Use conservative assumptions of required alignment for the various garbage collector components into account when determining the maximum heap size that supports compressed oops. Using this conservative value avoids several circular dependencies in the calculation. Reviewed-by: stefank, dholmes ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/prims/whitebox.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp + test/gc/arguments/TestUseCompressedOopsErgo.java + test/gc/arguments/TestUseCompressedOopsErgoTools.java ! test/testlibrary/whitebox/sun/hotspot/WhiteBox.java Changeset: b82260e84582 Author: tschatzl Date: 2013-09-11 18:47 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b82260e84582 Merge Changeset: d6c266999345 Author: ehelin Date: 2013-09-12 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/d6c266999345 8023476: Metaspace capacity > reserved Reviewed-by: stefank, hseigel, mgerdin ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/metaspaceCounters.cpp Changeset: c4c768305a8f Author: stefank Date: 2013-09-12 10:15 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c4c768305a8f 8024638: Count and expose the amount of committed memory in the metaspaces Reviewed-by: brutisso, ehelin ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 335b388c4b28 Author: stefank Date: 2013-09-13 22:21 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/335b388c4b28 8024651: Remove the incorrect usage of Metablock::overhead() Reviewed-by: brutisso, mgerdin, coleenp, jmasa ! src/share/vm/memory/metablock.cpp ! src/share/vm/memory/metablock.hpp ! src/share/vm/memory/metaspace.cpp Changeset: 9e11762cee52 Author: stefank Date: 2013-09-13 22:22 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/9e11762cee52 8024650: Don't adjust MaxMetaspaceSize up to MetaspaceSize Reviewed-by: jwilhelm, brutisso, tschatzl ! src/share/vm/gc_implementation/parallelScavenge/generationSizer.hpp ! src/share/vm/memory/collectorPolicy.cpp + test/gc/metaspace/TestMetaspaceSizeFlags.java ! test/testlibrary/OutputAnalyzerTest.java ! test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java Changeset: 8227700da288 Author: stefank Date: 2013-09-13 22:23 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8227700da288 8024751: Fix bugs in TraceMetadata Reviewed-by: jmasa, brutisso ! src/share/vm/memory/metaspace.cpp Changeset: 8c5e6482cbfc Author: stefank Date: 2013-09-13 22:25 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8c5e6482cbfc 8024752: Log TraceMetadata* output to gclog_or_tty instead of tty Reviewed-by: brutisso, mgerdin, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/runtime/virtualspace.cpp ! src/share/vm/runtime/virtualspace.hpp Changeset: 9cb63cd234a0 Author: shade Date: 2013-09-13 07:57 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/9cb63cd234a0 8024671: G1 generates assert error messages in product builds Reviewed-by: brutisso, tschatzl ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CardCounts.hpp Changeset: 884ed7a10f09 Author: tschatzl Date: 2013-09-16 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/884ed7a10f09 Merge ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/runtime/globals.hpp Changeset: 23ae5a04724d Author: tschatzl Date: 2013-09-16 10:20 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/23ae5a04724d 8024396: VM crashing with assert(!UseLargePages || UseParallelOldGC || use_large_pages) failed: Wrong alignment to use large pages Summary: Loosen wrong assert for UseParallelOldGC to UseParallelGC Reviewed-by: stefank, brutisso ! src/share/vm/memory/universe.cpp + test/gc/arguments/TestAlignmentToUseLargePages.java Changeset: f9b58dbeab91 Author: tschatzl Date: 2013-09-16 13:32 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/f9b58dbeab91 Merge Changeset: 17deed6716af Author: tschatzl Date: 2013-09-17 12:04 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/17deed6716af 8024914: Swapped usage of idx_t and bm_word_t types in bitMap.inline.hpp Summary: Incorrect usage of idx_t where bm_word_t is appropriate. Reviewed-by: tschatzl, brutisso Contributed-by: Dan Horak ! src/share/vm/utilities/bitMap.inline.hpp Changeset: 5767996b7b7b Author: jwilhelm Date: 2013-09-17 14:02 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/5767996b7b7b 8024884: Test name changed, test list not updated Summary: Updated the test list with the new test name. Reviewed-by: brutisso, ehelin ! test/TEST.groups Changeset: fac394091d73 Author: jwilhelm Date: 2013-09-18 00:08 +0000 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/fac394091d73 Merge Changeset: 73d0d0218068 Author: ehelin Date: 2013-09-17 20:59 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/73d0d0218068 8024718: Metaspace performance counters and memory pools should report the same data Reviewed-by: stefank, dholmes, coleenp ! src/share/vm/memory/metaspaceCounters.cpp ! src/share/vm/memory/metaspaceCounters.hpp ! src/share/vm/services/memoryPool.cpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryUsage.hpp ! test/gc/metaspace/TestMetaspaceMemoryPool.java ! test/gc/metaspace/TestMetaspacePerfCounters.java + test/gc/metaspace/TestPerfCountersAndMemoryPools.java ! test/testlibrary/com/oracle/java/testlibrary/InputArguments.java Changeset: 2f426063daea Author: tschatzl Date: 2013-09-18 10:02 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2f426063daea 8024662: gc/arguments/TestUseCompressedOopsErgo.java does not compile. Summary: Fix compilation error and use of an outdated VM option in the test Reviewed-by: stefank, jwilhelm ! test/gc/arguments/TestUseCompressedOopsErgoTools.java Changeset: 9044964f9163 Author: tschatzl Date: 2013-09-18 13:18 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/9044964f9163 8024669: Native OOME when allocating after changes to maximum heap supporting Coops sizing on sparcv9 Summary: After changes in 8010722 the ergonomics for calculating the size of the heap that supports zero based compressed oops changed. This lead to the VM actually using zero based compressed oops. Due to low default HeapBaseMinAddress, the OS mapping in the application image at the same address, and limitations of the malloc implementation on Solaris this resulted in very little C heap available for the VM. So the VM immediately gives a native OOME when the machine has lots of physical memory (>=32G). The solution is to increase the HeapBaseMinAddress so that the VM has enough C heap. Reviewed-by: kvn, brutisso ! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp Changeset: 719e886d4f72 Author: tschatzl Date: 2013-09-18 15:59 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/719e886d4f72 Merge Changeset: 06ae47d9d088 Author: tschatzl Date: 2013-09-19 09:26 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/06ae47d9d088 Merge ! src/os/linux/vm/os_linux.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java Changeset: 179cd89fb279 Author: tschatzl Date: 2013-09-19 09:34 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/179cd89fb279 Merge ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/thread.cpp ! test/TEST.groups Changeset: 8c83625e3a53 Author: adlertz Date: 2013-09-12 23:13 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/8c83625e3a53 8024646: Remove LRG_List container, replace it with GrowableArray Summary: We already have GrowableArray, use it instead of LRG_List Reviewed-by: kvn ! src/share/vm/opto/chaitin.cpp ! src/share/vm/opto/chaitin.hpp ! src/share/vm/opto/coalesce.hpp ! src/share/vm/opto/live.cpp ! src/share/vm/opto/live.hpp Changeset: 3a4e6c929bf3 Author: twisti Date: 2013-09-12 14:53 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/3a4e6c929bf3 8024275: During CTW: assert(sig_bt[member_arg_pos] == T_OBJECT) failed: dispatch argument must be an object Reviewed-by: kvn, vlivanov ! src/share/vm/classfile/classLoader.cpp Changeset: 591b49112612 Author: twisti Date: 2013-09-12 18:13 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/591b49112612 Merge Changeset: 01b268b3080a Author: vlivanov Date: 2013-09-13 04:16 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/01b268b3080a 8023134: Rename VM LogFile to hotspot_pid{pid}.log (was hotspot.log) Reviewed-by: twisti, kvn, sla ! src/share/tools/LogCompilation/README ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/utilities/ostream.cpp Changeset: 69f26e8e09f9 Author: twisti Date: 2013-09-13 16:55 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/69f26e8e09f9 8024760: add more types, fields and constants to VMStructs Reviewed-by: kvn, coleenp ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! src/share/vm/gc_implementation/g1/ptrQueue.hpp ! src/share/vm/gc_implementation/g1/vmStructs_g1.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/methodData.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: ae3e68933caf Author: adlertz Date: 2013-09-17 05:30 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ae3e68933caf Merge ! src/share/vm/runtime/arguments.cpp Changeset: 22194f27fbfb Author: ctornqvi Date: 2013-09-17 16:55 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/22194f27fbfb 8014905: [TESTBUG] Some hotspot tests should be updated to divide test jdk and compile jdk Summary: Change JDKToolFinder to look in compile.jdk if the executable cannot be found in test.jdk Reviewed-by: dholmes, hseigel ! test/TEST.groups ! test/gc/TestVerifyDuringStartup.java ! test/testlibrary/com/oracle/java/testlibrary/JDKToolFinder.java Changeset: 2c98370f2611 Author: ctornqvi Date: 2013-09-17 23:12 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2c98370f2611 Merge Changeset: 6d7eba360ba4 Author: anoll Date: 2013-09-17 08:39 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/6d7eba360ba4 8024128: guarantee(codelet_size > 0 && (size_t)codelet_size > 2*K) failed: not enough space for interpreter generation Summary: Increase interpreter size for x86 template interpreter Reviewed-by: kvn, iveresov ! src/cpu/x86/vm/templateInterpreter_x86.hpp Changeset: a4788ba67e20 Author: adlertz Date: 2013-09-17 16:07 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/a4788ba67e20 Merge Changeset: b2e698d2276c Author: drchase Date: 2013-09-13 22:38 -0400 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/b2e698d2276c 8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation Summary: Enhance method resolution and resulting data structures, plus some refactoring. Reviewed-by: twisti, acorn, jrose ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciField.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciSymbol.hpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/code/vtableStubs.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/interpreter/linkResolver.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp ! src/share/vm/oops/cpCache.cpp ! src/share/vm/oops/cpCache.hpp ! src/share/vm/oops/fieldStreams.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/klassVtable.hpp ! src/share/vm/oops/method.cpp ! src/share/vm/oops/method.hpp ! src/share/vm/oops/symbol.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/fieldDescriptor.cpp ! src/share/vm/runtime/fieldDescriptor.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/reflectionUtils.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 67bae56fdd69 Author: jrose Date: 2013-09-17 20:48 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/67bae56fdd69 Merge Changeset: ab274453d37f Author: anoll Date: 2013-09-18 07:22 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/ab274453d37f 8022883: Assertion failed: sweptCount >= flushedCount + markedCount + zombifiedCount Summary: Provide correct number of visited nmethods to Tracing Reviewed-by: kvn, iveresov ! src/share/vm/runtime/sweeper.cpp Changeset: 04cbe2026912 Author: rbackman Date: 2013-09-18 09:31 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/04cbe2026912 Merge Changeset: 2795dff62b6c Author: iveresov Date: 2013-09-18 14:10 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/2795dff62b6c 8023542: Test java/io/File/CheckPermission.java fails due to unfinished recursion (java.lang.StackOverflowError) when JIT'ed code (-client,-server) is running Summary: Move null check before klass reference materialization in checkcast Reviewed-by: kvn, roland ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: da051ce490eb Author: adlertz Date: 2013-09-19 18:01 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/da051ce490eb Merge ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/live.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/os.hpp ! src/share/vm/utilities/ostream.cpp ! test/TEST.groups Changeset: 566db1b0e6ef Author: amurillo Date: 2013-09-20 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/566db1b0e6ef Merge - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java - test/runtime/6878713/Test6878713.sh - test/runtime/6878713/testcase.jar - test/runtime/7020373/Test7020373.sh - test/runtime/7020373/testcase.jar Changeset: bf13c3da3d11 Author: amurillo Date: 2013-09-20 11:09 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/bf13c3da3d11 Added tag hs25-b51 for changeset 566db1b0e6ef ! .hgtags From alejandro.murillo at oracle.com Tue Sep 24 14:32:30 2013 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 24 Sep 2013 15:32:30 -0600 Subject: jdk8-b109: HotSpot Message-ID: <524204EE.4040202@oracle.com> hs25-b51 has been integrated into jdk8-b109. http://hg.openjdk.java.net/jdk8/jdk8/rev/d4762f463fe0 http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/c1eb93f57603 http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/bf13c3da3d11 http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/21b10835b88a http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/f64b1e497722 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a7dd84b9557c http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/8ecfe6a3ba4c http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/6ec2f9e5ed5b Component : VM Status : 0 major failures, 0 minor failures Date : 09/24/2013 at 18:20 MSK Tested By : VM SQE &dmitry.fazunenko at oracle.com Cost(total man-days): 2 Workspace : 2013-09-20-181155.amurillo.hs25-b51-snapshot Bundles : 2013-09-20-181155.amurillo.hs25-b51-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Logs :http://surl.us.oracle.com/PIT_hs25b51_summary Browsers : NA Patches : NA Number of Tests Executed : 332517 passed tests, 4487 failed tests Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: Setup is not available: 6900441: PlatformEvent.park(millis) on Linux could still be affected by changes to the time-of-day clock 6986195: correctly identify Ubuntu as the operating system in crash report instead of "Debian" 7149464: [TESTBUG] Test runtime/7020373/Test7020373.sh failed to clean up files after test 7164841: Improvements to the GC log file rotation 8009561: NPG: Metaspace fragmentation when retiring a Metachunk 8010722: assert: failed: heap size is too big for compressed oops 8014013: CallInfo structure no longer accurately reports the result of a LinkResolver operation 8014905: [TESTBUG] Some hotspot tests should be updated to divide test jdk and compile jdk 8015107: NPG: Use consistent naming for metaspace concepts 8016029: test runtime/6878713/Test6878713.sh failed 8016825: Large pages for the heap broken on Windows for compressed oops 8017230: Internal Error (jvmtiRedefineClasses.cpp:1662): guarantee(false) failed: insert_space_at() failed 8021353: Event based tracing is missing thread exit 8021823: G1: Concurrent marking crashes with -XX:ObjectAlignmentInBytes>=32 in 64bit VMs 8022335: Native stack walk while generating hs_err does not work on Windows x64 8022617: Openjdk hotspot build is broken on BSD platforms using gcc 8022798: "assert(seq > 0) failed: counter overflow" in Kitchensink 8022883: Assertion failed: sweptCount >= flushedCount + markedCount + zombifiedCount 8023134: Rename VM LogFile to hotspot_pid{pid}.log (was hotspot.log) 8023167: JVM allows duplicate Runtime[In]VisibleTypeAnnotations attributes in ClassFile/field_info/method_info structures 8023476: Metaspace capacity > reserved 8023478: Test fails with HS crash in GCNotifier. 8023542: Test java/io/File/CheckPermission.java fails due to unfinished recursion (java.lang.StackOverflowError) when JIT'ed code (-client,-server) is running 8024007: Misc. cleanup of static agent code 8024056: runtime/InitialThreadOverflow/testme.sh fails 8024128: guarantee(codelet_size > 0 && (size_t)codelet_size > 2*K) failed: not enough space for interpreter generation 8024176: [macosx] gc/metaspace/ClassMetaspaceSizeInJmapHeap.java failed since jdk8b105, hs25b47 8024256: Minimal VM build is broken with PCH disabled 8024275: During CTW: assert(sig_bt[member_arg_pos] == T_OBJECT) failed: dispatch argument must be an object 8024345: 'assert(_value != NULL) failed: resolving NULL _value' from VM_RedefineClasses::set_new_constant_pool 8024346: ~CautiouslyPreserveExceptionMark - assert(!_thread->has_pending_exception()) failed: unexpected exception generated 8024396: VM crashing with assert(!UseLargePages || UseParallelOldGC || use_large_pages) failed: Wrong alignment to use large pages 8024505: [TESTBUG] update test groups for additional tests that can't run on the minimal VM 8024638: Count and expose the amount of committed memory in the metaspaces 8024646: Remove LRG_List container, replace it with GrowableArray 8024647: Default method resolution with private superclass method 8024650: Don't adjust MaxMetaspaceSize up to MetaspaceSize 8024651: Remove the incorrect usage of Metablock::overhead() 8024662: gc/arguments/TestUseCompressedOopsErgo.java does not compile. 8024669: Native OOME when allocating after changes to maximum heap supporting Coops sizing on sparcv9 8024671: G1 generates assert error messages in product builds 8024718: Metaspace performance counters and memory pools should report the same data 8024751: Fix bugs in TraceMetadata 8024752: Log TraceMetadata* output to gclog_or_tty instead of tty 8024760: add more types, fields and constants to VMStructs 8024764: new hotspot build - hs25-b51 8024884: Test name changed, test list not updated 8024914: Swapped usage of idx_t and bm_word_t types in bitMap.inline.hpp Build change only: New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: 1.8.0-b109. Issues and Notes: This is PIT for HS25 b51 for JDK 8 b109. There are several JCK failures caused by incorrect configuration. Invalidated. -- Alejandro From david.katleman at oracle.com Wed Sep 25 13:33:25 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:33:25 +0000 Subject: hg: jdk8/jdk8/corba: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203326.A9DA762AE9@hg.openjdk.java.net> Changeset: 428428cf5e06 Author: tbell Date: 2013-09-25 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/428428cf5e06 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties From david.katleman at oracle.com Wed Sep 25 13:33:14 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:33:14 +0000 Subject: hg: jdk8/jdk8: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203315.0F61E62AE8@hg.openjdk.java.net> Changeset: 91f47e8da5c6 Author: tbell Date: 2013-09-25 12:21 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/91f47e8da5c6 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties From david.katleman at oracle.com Wed Sep 25 13:33:47 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:33:47 +0000 Subject: hg: jdk8/jdk8/hotspot: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203350.D82E062AEA@hg.openjdk.java.net> Changeset: c81dd5393a5e Author: tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/c81dd5393a5e 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties From david.katleman at oracle.com Wed Sep 25 13:34:23 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:34:23 +0000 Subject: hg: jdk8/jdk8/jaxp: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203427.2F4B362AEB@hg.openjdk.java.net> Changeset: 02bfab2aa938 Author: tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/02bfab2aa938 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties From david.katleman at oracle.com Wed Sep 25 13:34:48 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:34:48 +0000 Subject: hg: jdk8/jdk8/jaxws: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203452.2A54362AEC@hg.openjdk.java.net> Changeset: df5d4d016425 Author: tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/df5d4d016425 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties From david.katleman at oracle.com Wed Sep 25 13:35:19 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:35:19 +0000 Subject: hg: jdk8/jdk8/jdk: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203543.2DED562AED@hg.openjdk.java.net> Changeset: 946f3fd5f8bf Author: tbell Date: 2013-09-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/946f3fd5f8bf 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties ! makefiles/jprt.properties From david.katleman at oracle.com Wed Sep 25 13:36:13 2013 From: david.katleman at oracle.com (david.katleman at oracle.com) Date: Wed, 25 Sep 2013 20:36:13 +0000 Subject: hg: jdk8/jdk8/langtools: 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Message-ID: <20130925203619.D7F6C62AEE@hg.openjdk.java.net> Changeset: 985abf1cd327 Author: tbell Date: 2013-09-25 12:24 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/985abf1cd327 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties From christine.lu at oracle.com Thu Sep 26 10:52:28 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:52:28 +0000 Subject: hg: jdk8/jdk8: Added tag jdk8-b109 for changeset 91f47e8da5c6 Message-ID: <20130926175228.9B9C862B12@hg.openjdk.java.net> Changeset: 0cc21882d2f6 Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/0cc21882d2f6 Added tag jdk8-b109 for changeset 91f47e8da5c6 ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:53:01 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:53:01 +0000 Subject: hg: jdk8/jdk8/corba: Added tag jdk8-b109 for changeset 428428cf5e06 Message-ID: <20130926175302.2668A62B13@hg.openjdk.java.net> Changeset: 3d2b7ce93c5c Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/corba/rev/3d2b7ce93c5c Added tag jdk8-b109 for changeset 428428cf5e06 ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:53:39 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:53:39 +0000 Subject: hg: jdk8/jdk8/hotspot: Added tag jdk8-b109 for changeset c81dd5393a5e Message-ID: <20130926175341.99D4262B14@hg.openjdk.java.net> Changeset: fff4842215d1 Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/hotspot/rev/fff4842215d1 Added tag jdk8-b109 for changeset c81dd5393a5e ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:54:32 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:54:32 +0000 Subject: hg: jdk8/jdk8/jaxp: Added tag jdk8-b109 for changeset 02bfab2aa938 Message-ID: <20130926175435.6A21A62B15@hg.openjdk.java.net> Changeset: 4c84c5b447b0 Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxp/rev/4c84c5b447b0 Added tag jdk8-b109 for changeset 02bfab2aa938 ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:54:51 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:54:51 +0000 Subject: hg: jdk8/jdk8/jaxws: Added tag jdk8-b109 for changeset df5d4d016425 Message-ID: <20130926175454.7774262B16@hg.openjdk.java.net> Changeset: cc682329886b Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jaxws/rev/cc682329886b Added tag jdk8-b109 for changeset df5d4d016425 ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:55:14 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:55:14 +0000 Subject: hg: jdk8/jdk8/jdk: Added tag jdk8-b109 for changeset 946f3fd5f8bf Message-ID: <20130926175527.D207362B17@hg.openjdk.java.net> Changeset: f8c9a4b80148 Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/f8c9a4b80148 Added tag jdk8-b109 for changeset 946f3fd5f8bf ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:56:47 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:56:47 +0000 Subject: hg: jdk8/jdk8/nashorn: Added tag jdk8-b109 for changeset 6ec2f9e5ed5b Message-ID: <20130926175648.E787262B19@hg.openjdk.java.net> Changeset: d1e2050e575e Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/nashorn/rev/d1e2050e575e Added tag jdk8-b109 for changeset 6ec2f9e5ed5b ! .hgtags From christine.lu at oracle.com Thu Sep 26 10:56:30 2013 From: christine.lu at oracle.com (christine.lu at oracle.com) Date: Thu, 26 Sep 2013 17:56:30 +0000 Subject: hg: jdk8/jdk8/langtools: Added tag jdk8-b109 for changeset 985abf1cd327 Message-ID: <20130926175634.2F60A62B18@hg.openjdk.java.net> Changeset: 6f11dc295641 Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/6f11dc295641 Added tag jdk8-b109 for changeset 985abf1cd327 ! .hgtags From mike.duigou at oracle.com Thu Sep 26 14:18:19 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 26 Sep 2013 14:18:19 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) Message-ID: I hereby nominate Brent Christian to jdk8 Committer. Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. Changesets (in jdk8/jdk repo): hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " 8025173: HashMap.put() replacing an existing key can trigger a resize() 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] 8024009: Remove jdk.map.useRandomSeed system property 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X 8010325: Remove hash32() method and hash32 int field from java.lang.String 8005698: Handle Frequent HashMap Collisions with Balanced Trees 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] 7178922: (props) re-visit how os.name is determined on Mac Votes are due by 2359 UTC, October 10, 2013. Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [2]. -Mike [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote From mike.duigou at oracle.com Thu Sep 26 14:32:31 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Thu, 26 Sep 2013 14:32:31 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5A2BDE9E-655F-4A04-B1E6-96550ADE0B6C@oracle.com> Vote: YES On Sep 26 2013, at 14:18 , Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From jonathan.gibbons at oracle.com Thu Sep 26 14:34:47 2013 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Thu, 26 Sep 2013 14:34:47 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244A877.9070605@oracle.com> Vote: yes On 09/26/2013 02:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From david.katleman at oracle.com Thu Sep 26 15:19:45 2013 From: david.katleman at oracle.com (David Katleman) Date: Thu, 26 Sep 2013 15:19:45 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244B301.6060809@oracle.com> Vote: yes On 9/26/2013 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From kumar.x.srinivasan at oracle.com Thu Sep 26 15:28:22 2013 From: kumar.x.srinivasan at oracle.com (Kumar Srinivasan) Date: Thu, 26 Sep 2013 15:28:22 -0700 (PDT) Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244B506.3000002@oracle.com> Vote: yes > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From joe.darcy at oracle.com Thu Sep 26 15:37:24 2013 From: joe.darcy at oracle.com (Joe Darcy) Date: Thu, 26 Sep 2013 15:37:24 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244B724.8090108@oracle.com> Vote: yes -Joe On 9/26/2013 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From mandy.chung at oracle.com Thu Sep 26 15:52:20 2013 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 26 Sep 2013 15:52:20 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244BAA4.20808@oracle.com> Vote: yes From henry.jen at oracle.com Thu Sep 26 16:00:02 2013 From: henry.jen at oracle.com (Henry Jen) Date: Thu, 26 Sep 2013 16:00:02 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: Vote: Yes Cheers, Henry From naoto.sato at oracle.com Thu Sep 26 16:09:14 2013 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 26 Sep 2013 16:09:14 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244BE9A.6070106@oracle.com> Vote: yes Naoto On 9/26/13 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From james.graham at oracle.com Thu Sep 26 16:14:17 2013 From: james.graham at oracle.com (Jim Graham) Date: Thu, 26 Sep 2013 16:14:17 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244BFC9.8050100@oracle.com> Vote: yes ...jim On 9/26/13 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From omajid at redhat.com Thu Sep 26 15:50:09 2013 From: omajid at redhat.com (Omair Majid) Date: Thu, 26 Sep 2013 18:50:09 -0400 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244BA21.1040500@redhat.com> Vote: Yes On 09/26/2013 05:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. From chris.hegarty at oracle.com Thu Sep 26 16:29:16 2013 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Thu, 26 Sep 2013 16:29:16 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244C34C.3020903@oracle.com> Vote: Yes -Chris. On 09/26/2013 02:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From weijun.wang at oracle.com Thu Sep 26 16:33:31 2013 From: weijun.wang at oracle.com (Weijun Wang) Date: Fri, 27 Sep 2013 07:33:31 +0800 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244C44B.8060809@oracle.com> Vote: yes. -weijun On 9/27/13 5:18 AM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From bradford.wetmore at oracle.com Thu Sep 26 17:23:51 2013 From: bradford.wetmore at oracle.com (Bradford Wetmore) Date: Thu, 26 Sep 2013 17:23:51 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5244D017.4000004@oracle.com> Vote: yes. On 9/26/2013 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From xueming.shen at oracle.com Thu Sep 26 21:45:56 2013 From: xueming.shen at oracle.com (Xueming Shen) Date: Thu, 26 Sep 2013 21:45:56 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <52450D84.6000900@oracle.com> Vote: YES On 9/26/13 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From jeff.dinkins at oracle.com Thu Sep 26 21:55:34 2013 From: jeff.dinkins at oracle.com (Jeff Dinkins) Date: Thu, 26 Sep 2013 21:55:34 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: <52450D84.6000900@oracle.com> References: <52450D84.6000900@oracle.com> Message-ID: <93423BB1-07BF-433D-8173-ADE3DA138C9E@oracle.com> Vote: Yes On 9/26/13 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From daniel.fuchs at oracle.com Fri Sep 27 00:55:59 2013 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Fri, 27 Sep 2013 09:55:59 +0200 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <52453A0F.301@oracle.com> Vote: Yes -- daniel On 9/26/13 11:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From artem.ananiev at oracle.com Fri Sep 27 01:21:52 2013 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Fri, 27 Sep 2013 12:21:52 +0400 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <52454020.4040702@oracle.com> Vote: YES. Artem On 9/27/2013 1:18 AM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From anthony.petrov at oracle.com Fri Sep 27 02:43:44 2013 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Fri, 27 Sep 2013 13:43:44 +0400 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <52455350.6010007@oracle.com> Vote: YES -- best regards, Anthony On 09/27/2013 01:18 AM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > From coleen.phillimore at oracle.com Fri Sep 27 05:23:59 2013 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Fri, 27 Sep 2013 08:23:59 -0400 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <524578DF.6040101@oracle.com> Vote: yes On 9/26/2013 5:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From alexander.zuev at oracle.com Fri Sep 27 05:48:40 2013 From: alexander.zuev at oracle.com (Alexander Zuev) Date: Fri, 27 Sep 2013 16:48:40 +0400 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <63E5FF91-F063-4C2A-A8FC-CEEBFC5F6318@oracle.com> Vote: yes With best regards, Alexander Zuev 27.09.2013, ? 1:18, Mike Duigou ???????(?): > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From karen.kinnear at oracle.com Fri Sep 27 06:47:24 2013 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Fri, 27 Sep 2013 09:47:24 -0400 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <1023BE9E-69C8-4533-905B-396B64A4241A@oracle.com> Vote: yes thanks, Karen On Sep 26, 2013, at 5:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > > Brent has been working on the core libraries for a little less than a year but has tackled some significant problems including the initial re-write of HashMap in Java 8 to replace alternative hashing. He's also been contributing platform code for Mac OS. > > Changesets (in jdk8/jdk repo): > > hg log -M -u bchristi --template "{desc}\n" | grep "^[0-9]\{7,7\}: " > > 8025173: HashMap.put() replacing an existing key can trigger a resize() > 7199674: (props) user.home property does not return an accessible location in sandboxed environment [macosx] > 8024009: Remove jdk.map.useRandomSeed system property > 8011194: Apps launched via double-clicked .jars have file.encoding value of US-ASCII on Mac OS X > 8010325: Remove hash32() method and hash32 int field from java.lang.String > 8005698: Handle Frequent HashMap Collisions with Balanced Trees > 8006039: test/tools/launcher/I18NJarTest.java fails on Mac w/ LANG=C, LC_ALL=C > 8005962: TEST_BUG: java/util/Properties/MacJNUEncoding can fail in certain environments > 8003228: (props) sun.jnu.encoding should be set to UTF-8 [macosx] > 7178922: (props) re-visit how os.name is determined on Mac > > Votes are due by 2359 UTC, October 10, 2013. > > Only current jdk8 Committers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > -Mike > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote From Roger.Riggs at Oracle.com Fri Sep 27 09:49:21 2013 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Fri, 27 Sep 2013 09:49:21 -0700 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: <5245B711.1030203@Oracle.com> Vote: Yes On 9/26/13 2:18 PM, Mike Duigou wrote: > I hereby nominate Brent Christian to jdk8 Committer. > From pete.poulos at gmail.com Fri Sep 27 14:24:15 2013 From: pete.poulos at gmail.com (Pete Poulos) Date: Fri, 27 Sep 2013 15:24:15 -0600 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> <523DD6A5.30002@univ-mlv.fr> Message-ID: It looks like the discussion on this is done. I'm new to this list, what is the procedure for something like this? Do I need to create a bug ticket somewhere or submit a patch? Thanks, Pete. On Sep 21, 2013 1:38 PM, "Simone Bordet" wrote: > Hi, > > On Sat, Sep 21, 2013 at 10:25 AM, Remi Forax wrote: > > On 09/20/2013 07:55 PM, Eamonn McManus wrote: > >> > >> > yes and no, > >> > it depends how your RPC framework map errors because if you send an > >> > Optional > >> > and then throw an exception in the client you will not have a > meaningful > >> > stack trace. > >> > >> I don't understand what this means. Concretely, why would you not want > >> Optional to be a valid return type of an RMI method? > > > > > > Hi ?amonn, > > yes, returning an Optional for a service means that you may return null > > which is usually a bad practice, > > given the overhead of being over the wire, it's usully better to throw an > > exception with a meaningful error message. > > Like ?amonn, I don't follow your reasoning. > "Usually a bad practice", "usually better to throw" seem your > opinions, and seem weak to base such an (important) decision on > opinions only. > Do you have more important insights that we're missing ? > > Does not throwing an exception via RMI have at least the same or even > greater overhead than returning Optional ? > Did you measure the overhead that retuning a serializable Optional > produces ? > > Thanks ! > > -- > Simone Bordet > http://bordet.blogspot.com > --- > Finally, no matter how good the architecture and design are, > to deliver bug-free software with optimal performance and reliability, > the implementation technique must be flawless. Victoria Livschitz > From mike.duigou at oracle.com Fri Sep 27 14:43:44 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 27 Sep 2013 14:43:44 -0700 Subject: Shouldn't Optional be Serializable? In-Reply-To: <5239A4B0.1030707@oracle.com> References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <5239A4B0.1030707@oracle.com> Message-ID: On Sep 18 2013, at 06:03 , roger riggs wrote: > Hi Remi,, > > Optional has semantics beyond those of simple boxing including > throwing an exception if it has no value. The class libraries are > designed to be useful to developers as part of a whole data model > which includes serialization; optimizations of the API to enable > VM performance would, I think be considered if the API design can provide > the equivalent semantics. > > BTW, Optional.of(null) does not say it throws NPE; I didn't find any > specification that connects the "not null" on the @param to throwing NPE > in the class or package javadoc. I've filed https://bugs.openjdk.java.net/browse/JDK-8025610 to correct this. Thank you. Mike > > Optional should be Serializable. > > $.02, Roger > > > On 9/18/2013 2:37 AM, Remi Forax wrote: >> There is a good reason to not allow Optional to implement Serializable, >> it promotes a bad way to use Optional, at least from the VM point of view. >> >> For the VM, Optional is a boxing, very similar to a boxing to Integer >> (in fact it's a little better because Integer.valueOf is badly* specified in the JLS >> but that's another story). >> >> so if you write: >> class Foo { >> private Optional description; >> >> public Optional getDescription() { >> return description; >> } >> } >> >> This implementation id bad for two reasons, the first one is that you have to do >> a double indirection so will double your chance to have a value that is not >> in the cache but in RAM when you want the underlying String. >> The second reason is that the VM will usually not be able to remove the >> boxing because the creation of Optional will be too far from the use. >> >> There is a better implementation >> class Foo { >> private String description; // warning nullable ! >> >> public Optional getDescription() { >> return Optional.fromNullable(description); >> } >> } >> >> It's the same API from the user point of view, but the creation of Optional >> is in the same inline horizon that it's use if getDescription is inlined >> (and here given that the method is really small, the is a good chance). >> In that case the VM is able to remove the boxing and everybody is happy. >> >> So making Optional serializable goes in the wrong direction. >> >> cheers, >> R?mi >> * as we now now in 2013, it was less obvious when the decision was taken circa 2003. >> >> On 09/18/2013 03:16 AM, Pete Poulos wrote: >>> Optional holds data and while the vast majority of use cases for Optional >>> will be to immediately pull the value out and do something, that doesn't >>> change the fact that it is still a data structure, somebody somewhere is >>> going to need to serialize it for some reason. The other data structures >>> in the java.util package are Serializable so making Optional Serializable >>> makes things consistent. >>> >>> As far as I know the cost of adding Serializable to Optional is negligible, >>> but the cost could be fairly significant to someone who needs to serialize >>> it at some point and is unable to do so. >>> >>> Anyhow, I'm currently designing a set of functional (immutable, persistent) >>> data structures for JDK8+ and I'm debating replacing my "Maybe" class >>> (functionally the same as Optional, but with Haskell's naming convention >>> for this data structure) the JDK8 Optional and I'm concerned that the lack >>> of Serializable on Optional would cause problems for potential users of my >>> API. >>> >>> I'm only using Optional/Maybe to wrap return values from methods so I can >>> indicate missing/present values within my data structures, so I could >>> conceivably use Optional and still support serialization. >>> >>> Also, while we are having this discussion, is there an alternative to >>> serialization that is considered superior? Over the years I have read blog >>> posts by people condemning serialization, but I don't recall seeing any >>> alternatives suggested. >>> >>> Thanks, >>> Pete >>> >>> >>> >>> >>> >>> >>> On Tue, Sep 17, 2013 at 5:32 PM, Vitaly Davidovich wrote: >>> >>>> Presumably because you may want to have class fields that express >>>> nullability via Optional rather than null. Whether that's a good design or >>>> not is a separate question; conceptually, I don't see a reason why Optional >>>> cannot support that. For "reference", Google Guava's version is >>>> serializable. If someone were to replace their use with jdk's Optional >>>> then they will hit exceptions if the owner class is serialized. >>>> >>>> Sent from my phone >>>> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >>>> >>>>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>>>> >>>>>> Shouldn't java.util.Optional be Serializable? Is there a good reason >>>> for >>>>>> it not be? >>>>>> >>>>> wrong question. >>>>> the right one is why do you want Optional to be Serializable. >>>>> >>>>> Thanks, >>>>>> Pete >>>>>> >>>>> cheers, >>>>> R?mi >>>>> >>>>> >> > From omajid at redhat.com Fri Sep 27 14:49:58 2013 From: omajid at redhat.com (Omair Majid) Date: Fri, 27 Sep 2013 17:49:58 -0400 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <52394A2A.2090905@univ-mlv.fr> <523B4E94.5090809@univ-mlv.fr> <523DD6A5.30002@univ-mlv.fr> Message-ID: <5245FD86.2000808@redhat.com> On 09/27/2013 05:24 PM, Pete Poulos wrote: > It looks like the discussion on this is done. I'm new to this list, what > is the procedure for something like this? Do I need to create a bug ticket > somewhere or submit a patch? If you want to file a bug (as a user, without a patch), you can file one at: http://bugreport.sun.com/bugreport/ If you are an openjdk developer, you can use this instead for the bug: https://bugs.openjdk.java.net/ But easiest is just to send a patch to the right mailing list. For java.util.Optional, that would be core-libs-dev at . An OpenJDK developer will file the bugs for you if the patch is okay. Cheers, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681 From mike.duigou at oracle.com Fri Sep 27 17:15:22 2013 From: mike.duigou at oracle.com (Mike Duigou) Date: Fri, 27 Sep 2013 17:15:22 -0700 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> Message-ID: <5E26F13D-5C47-4637-9C60-CBDC37D8E917@oracle.com> On Sep 17 2013, at 16:32 , Vitaly Davidovich wrote: > Presumably because you may want to have class fields that express > nullability via Optional rather than null. Using Optional as a field type doesn't seem to offer much. Would the Optional field be wrapped in accessors? If it's not wrapped, the result is that orElse(default) gets spread across the usage of the field which is a poor way to apply a default. If if it is wrapped, why not apply the default in the accessor or in the setter and not bother with Optional? > Whether that's a good design or > not is a separate question; That's not generally how JDK expert groups think. Adding any feature to intentionally support bad design wouldn't make much sense. Understanding the dimensions of how a feature might be used is certainly something that the EG spends a lot of time on. The choice of semantics, methods offered and interfaces implemented isn't ever separated from the expected use cases. Optional is a new class/feature to the JDK and it seemed appropriate to start with a minimal implementation. Concern that Optional would be misused in other use cases threatened to derail it's inclusion in Java entirely! Optional is being added for the value it offers in "fluent" sequences of statements. In this context use of Optional as a visible type or for serialization isn't relevant. > conceptually, I don't see a reason why Optional > cannot support that. For "reference", Google Guava's version is > serializable. Guava's Optional certainly proves that it is technically possible (which was probably already known anyway) but that doesn't address whether doing so with the Java Optional would be a good idea or not. > If someone were to replace their use with jdk's Optional > then they will hit exceptions if the owner class is serialized. While the incompatibility is certainly unfortunate this is probably not a sufficient reason by itself to make Java's Optional serializable. Mike > Sent from my phone > On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: > >> On 09/17/2013 11:44 PM, Pete Poulos wrote: >> >>> Shouldn't java.util.Optional be Serializable? Is there a good reason for >>> it not be? >>> >> >> wrong question. >> the right one is why do you want Optional to be Serializable. >> >> Thanks, >>> Pete >>> >> >> cheers, >> R?mi >> >> From brian.goetz at oracle.com Fri Sep 27 17:46:18 2013 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 28 Sep 2013 02:46:18 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: <5E26F13D-5C47-4637-9C60-CBDC37D8E917@oracle.com> References: <5238D17C.5090408@univ-mlv.fr> <5E26F13D-5C47-4637-9C60-CBDC37D8E917@oracle.com> Message-ID: <0A912C03-1E73-485A-904B-3860CBEA789D@oracle.com> Amplifying Mike's observations: this exploration is already covered ground. The JSR-335 EG felt fairly strongly that Optional should not be on any more than needed to support the optional-return idiom only. (Someone suggested maybe even renaming it to OptionalReturn to beat users over the head with this design orientation; perhaps we should have taken that suggestion.) I get that lots of people want Optional to be something else. But, its not simply the case that the EG "forgot" to make it serializable; they explicitly chose not to. And there's certainly been no new data that has come to light that would motivate us to set that choice aside at this point. On Sep 28, 2013, at 2:15 AM, Mike Duigou wrote: > > On Sep 17 2013, at 16:32 , Vitaly Davidovich wrote: > >> Presumably because you may want to have class fields that express >> nullability via Optional rather than null. > > Using Optional as a field type doesn't seem to offer much. > > Would the Optional field be wrapped in accessors? > > If it's not wrapped, the result is that orElse(default) gets spread across the usage of the field which is a poor way to apply a default. > > If if it is wrapped, why not apply the default in the accessor or in the setter and not bother with Optional? > >> Whether that's a good design or >> not is a separate question; > > That's not generally how JDK expert groups think. Adding any feature to intentionally support bad design wouldn't make much sense. Understanding the dimensions of how a feature might be used is certainly something that the EG spends a lot of time on. The choice of semantics, methods offered and interfaces implemented isn't ever separated from the expected use cases. Optional is a new class/feature to the JDK and it seemed appropriate to start with a minimal implementation. Concern that Optional would be misused in other use cases threatened to derail it's inclusion in Java entirely! Optional is being added for the value it offers in "fluent" sequences of statements. In this context use of Optional as a visible type or for serialization isn't relevant. > >> conceptually, I don't see a reason why Optional >> cannot support that. For "reference", Google Guava's version is >> serializable. > > Guava's Optional certainly proves that it is technically possible (which was probably already known anyway) but that doesn't address whether doing so with the Java Optional would be a good idea or not. > >> If someone were to replace their use with jdk's Optional >> then they will hit exceptions if the owner class is serialized. > > While the incompatibility is certainly unfortunate this is probably not a sufficient reason by itself to make Java's Optional serializable. > > Mike > >> Sent from my phone >> On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: >> >>> On 09/17/2013 11:44 PM, Pete Poulos wrote: >>> >>>> Shouldn't java.util.Optional be Serializable? Is there a good reason for >>>> it not be? >>>> >>> >>> wrong question. >>> the right one is why do you want Optional to be Serializable. >>> >>> Thanks, >>>> Pete >>>> >>> >>> cheers, >>> R?mi >>> >>> > From vitalyd at gmail.com Fri Sep 27 21:04:02 2013 From: vitalyd at gmail.com (Vitaly Davidovich) Date: Sat, 28 Sep 2013 00:04:02 -0400 Subject: Shouldn't Optional be Serializable? In-Reply-To: <5E26F13D-5C47-4637-9C60-CBDC37D8E917@oracle.com> References: <5238D17C.5090408@univ-mlv.fr> <5E26F13D-5C47-4637-9C60-CBDC37D8E917@oracle.com> Message-ID: It sounds like this should have been named something else entirely then, not Optional. I just don't buy the argument that omitting serializability, which would've cost close to nothing to support and develop, is somehow going to steer people in the "right" direction. I buy this argument if there's some non-negligible cost to adding a feature (perf loss, code maintenance, back compat issues, complexity, etc) but that's not the case here. Document the intent behind this class in docs and let users make their own choice afterwards. As for storage in fields, it's possible that someone may want to use it as a way to improve maintainability by making it more obvious that it's a nullable value. Someone may also have some small state objects that wrap an Optional inside (possibly coming out of an operation that returns an Optional), and may decide to serialize it somewhere (it could be just for debugging, for example). The point is it shouldn't matter in this specific case - as mentioned, supporting serializability of this simple construct is dirt cheap. I think this is just over analysis, frankly. Vitaly Sent from my phone On Sep 27, 2013 8:15 PM, "Mike Duigou" wrote: > > On Sep 17 2013, at 16:32 , Vitaly Davidovich wrote: > > > Presumably because you may want to have class fields that express > > nullability via Optional rather than null. > > Using Optional as a field type doesn't seem to offer much. > > Would the Optional field be wrapped in accessors? > > If it's not wrapped, the result is that orElse(default) gets spread across > the usage of the field which is a poor way to apply a default. > > If if it is wrapped, why not apply the default in the accessor or in the > setter and not bother with Optional? > > > Whether that's a good design or > > not is a separate question; > > That's not generally how JDK expert groups think. Adding any feature to > intentionally support bad design wouldn't make much sense. Understanding > the dimensions of how a feature might be used is certainly something that > the EG spends a lot of time on. The choice of semantics, methods offered > and interfaces implemented isn't ever separated from the expected use > cases. Optional is a new class/feature to the JDK and it seemed appropriate > to start with a minimal implementation. Concern that Optional would be > misused in other use cases threatened to derail it's inclusion in Java > entirely! Optional is being added for the value it offers in "fluent" > sequences of statements. In this context use of Optional as a visible type > or for serialization isn't relevant. > > > conceptually, I don't see a reason why Optional > > cannot support that. For "reference", Google Guava's version is > > serializable. > > Guava's Optional certainly proves that it is technically possible (which > was probably already known anyway) but that doesn't address whether doing > so with the Java Optional would be a good idea or not. > > > If someone were to replace their use with jdk's Optional > > then they will hit exceptions if the owner class is serialized. > > While the incompatibility is certainly unfortunate this is probably not a > sufficient reason by itself to make Java's Optional serializable. > > Mike > > > Sent from my phone > > On Sep 17, 2013 6:06 PM, "Remi Forax" wrote: > > > >> On 09/17/2013 11:44 PM, Pete Poulos wrote: > >> > >>> Shouldn't java.util.Optional be Serializable? Is there a good reason > for > >>> it not be? > >>> > >> > >> wrong question. > >> the right one is why do you want Optional to be Serializable. > >> > >> Thanks, > >>> Pete > >>> > >> > >> cheers, > >> R?mi > >> > >> > > From brian.goetz at oracle.com Sat Sep 28 00:26:52 2013 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 28 Sep 2013 09:26:52 +0200 Subject: Shouldn't Optional be Serializable? In-Reply-To: References: <5238D17C.5090408@univ-mlv.fr> <5E26F13D-5C47-4637-9C60-CBDC37D8E917@oracle.com> Message-ID: <7388926D-D085-46B0-9639-A5A6B32E8D37@oracle.com> > It sounds like this should have been named something else entirely then, > not Optional. Perhaps. But we're not going to consume infinite time (and every experience we've had so far with Optional suggests that it truly is unbounded) correcting this mistake. Anyway, I won't comment further on Optional because there's little value in continuing the discussion. Just one correction: > I buy this argument if there's some > non-negligible cost to adding a feature (perf loss, code maintenance, back > compat issues, complexity, etc) but that's not the case here. You would be incorrect. Making something in the JDK serializable makes a dramatic increase in our maintenance costs, because it means that the representation is frozen for all time. This constrains our ability to evolve implementations in the future, and the number of cases where we are unable to easily fix a bug or provide an enhancement, which would otherwise be simple, is enormous. So, while it may look like a simple matter of "implements Serializable" to you, it is more than that. The amount of effort consumed by working around an earlier choice to make something serializable is staggering. (You can always argue "but this case is different", and it might be, but that still would presuppose that we think its a good idea.) From paul.sandoz at oracle.com Sat Sep 28 07:43:24 2013 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Sat, 28 Sep 2013 16:43:24 +0200 Subject: CFV: New JDK8 Committer Brent Christian (bchristi) In-Reply-To: References: Message-ID: Vote: yes Paul.