[8u20] Request for approval for JDK-8041953

[Hannes Wallnoefer]

Hi Iris,

Sorry, I thought "noreg-existing" was the correct label from looking at 
other bugs use of it. What I meant is that there is an existing test 
(JDK-8031359.js) for the bug. I guess "noreg****-sqe" is the correct 
label to use for that then?

Regards,
Hannes

Am 2014-04-28 21:39, schrieb Iris Clark:
> Hi, Hannes.
>
> "noreg-existing" is not a documented "noreg" label.  I suspect that you meant to use "noreg-self".  As Sean already mentioned, the set of noreg labels may be found on this page [1].
>
> Thanks,
> iris
>
> [1]: http://openjdk.java.net/guide/changePlanning.html#noreg
>
> -----Original Message-----
> From: Hannes Wallnoefer
> Sent: Monday, April 28, 2014 7:53 AM
> To: Seán Coffey; jdk8u-dev at openjdk.java.net
> Subject: Re: [8u20] Request for approval for JDK-8041953
>
> Thanks, Sean.
>
> Yes, this is a jdk8u specific fix.
>
> I added the '8-na' and 'noreg-existing' labels, the name of the existing test is in the bug title and description.
>
> Regards,
> Hannes
>
> Am 2014-04-28 15:49, schrieb Seán Coffey:
>> Hannes,
>>
>> is this applicable to jdk8u only ? If so, please add the '8-na' label
>> to the bug report.
>> Please add an appropriate noreg label also :
>>
>> http://openjdk.java.net/guide/changePlanning.html
>>
>> Approved for 8u-dev (once you have a valid review)
>>
>> Regards,
>> Sean.
>>
>> On 28/04/14 14:25, Hannes Wallnoefer wrote:
>>> Please approve JDK-8041953 for 8u20.
>>>
>>> This fixes a merge error in jdk8u/jdk8u-dev/nashorn and restores the
>>> content of JavaAdapterBytecodeGenerator.java to what it should be
>>> based on the merged changesets.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8041953
>>> Webrev: http://cr.openjdk.java.net/~hannesw/8041953/
>>> Review request:
>>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-April/002924.
>>> html
>>>
>>> Thanks,
>>> Hannes
>>>