[8u40] Request for review and approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

[Konstantin Shefov]

Well, I have put @ignore after @library: 
http://cr.openjdk.java.net/~kshefov/8059070_8u/webrev.02

On 04.12.2014 15:29, Daniel Fuchs wrote:
> On 04/12/14 13:16, Konstantin Shefov wrote:
>> Hello,
>>
>> I have made a new webrev for this fix that uses Igor's timeout tool from
>> JDK 9: http://cr.openjdk.java.net/~kshefov/8059070_8u/webrev.01
>> This is a fix to test for one of 8u40 features.
>>
>> -Konstantin
>
> Hi Konstantin,
>
> While you're at it, could you move the @ignore tag below
> the @library tag in those files that have an @ignore?
> (e.g. LFGarbageCollectedTest.java)
>
> Having @ignore before @library makes jtreg complain that
> @library should come before @run (I learned that @ignore
> is an @run in disguise).
>
> best regards,
>
> -- daniel
>
>>
>> On 01.12.2014 15:07, Konstantin Shefov wrote:
>>> Paul, Igor
>>>
>>> On 01.12.2014 13:55, Paul Sandoz wrote:
>>>> On Dec 1, 2014, at 11:53 AM, Konstantin Shefov
>>>> <konstantin.shefov at oracle.com> wrote:
>>>>
>>>>> Paul,
>>>>>
>>>>> On 01.12.2014 11:48, Paul Sandoz wrote:
>>>>>> On Nov 28, 2014, at 6:21 PM, Konstantin Shefov
>>>>>> <konstantin.shefov at oracle.com> wrote:
>>>>>>
>>>>>>> Please review and approve backport of JDK-8059070 to 8u40.
>>>>>>>
>>>>>>> This is the test fix and it is a bit different from that of JDK 9.
>>>>>>>
>>>>>> Looks ok.
>>>>>>
>>>>>> Why is it different to the fix in 9?
>>>>> It is because in JDK 8u there is no adjustTimeout function in Utils
>>>>> class, so I added it. And I think it will be better to define where
>>>>> to stop interations depending on the iteration with the maximum
>>>>> time, not the average iteration time.
>>>>> If tests still fail with timeout in JDK 9, I will also change
>>>>> average iteration time to maximum time in JDK 9.
>>>>>
>>>> Ok.
>>>>
>>>> I see Igor has factored out similar functionality in a separate patch
>>>> under review in core-libs.
>>> Well, in this case I can reuse the functionality Igor introduced, but
>>> it is going to be in JDK 9. Will it be backported to JDK 8? And there
>>> is "maxDuration << 1" in the file
>>> "lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java" but what if
>>> we need multiplier greater than 2, e.g. 4?
>>>
>>> -Konstantin
>>>>
>>>> Paul.
>>>
>>
>