[8u-dev] Request for Review and Approval: 8066612: Add a test that will call getDeclaredFields() on all classes and try to set them accessible.

[Seán Coffey]

Looks fine to me Daniel (I'll look at porting this to 7u-dev also)

Approved.

regards,
Sean.

On 17/12/14 18:21, Daniel Fuchs wrote:
> Hi,
>
> This is a request for approval to backport:
>
>   8066612: Add a test that will call getDeclaredFields() on all
>            classes and try to set them accessible.
>   https://bugs.openjdk.java.net/browse/JDK-8066612
>
> to 8u-dev.
>
> The test code is slightly different on 8u compared to 9 so I'm asking
> for review here as well:
>
> On 8u-dev the test is different because it can't use the jrt:/
> filesystem that 9 was using. Instead it parses the jars found on
> the bootclasspath to get the list of classes.
>
> The changes are however very limited:
>
>   - The inner class ClassNameJrtStreamBuilder is replaced with
>     ClassNameStreamBuilder
>   - The class loader passed to Class.forName is now 'null'
>
> Here is the webrev for 8:
> http://cr.openjdk.java.net/~dfuchs/webrev_8066612/webrev-jdk8.01/
>
> To be compared with the changeset pushed in 9:
> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/70e68970bdee
>
> And in case that's needed - the review thread for 9 started here:
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-December/030078.html 
>
>
> best regards
>
> -- daniel
>