Review request for 8049128: 8u20 l10n resource file translation update 2 - jaxp

[huizhe wang]

Hi Michael,

When removing @revision $Id / $Id lines in java files, you may want to 
remove the whole comment block. For example:
in 
http://cr.openjdk.java.net/~mfang/8049128/webrev.jaxp.01/src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources.java.udiff.html:

   20 /*
   21  * $Id: XSLTErrorResources.java,v 1.2.4.1 2005/09/13 09:55:37 pvedula Exp $
   22  */


After removing line 21, it became:

   20 /*
   21  */


As far as indentation goes, they had not been consistent among 
.properies files. But we may want to make it consistent within one file, 
for example, 
http://cr.openjdk.java.net/~mfang/8049128/webrev.jaxp.01/src/com/sun/org/apache/xerces/internal/impl/msg/DOMMessages.properties.html. 
You may remove indentation for line 7 and 8.

Otherwise, it looks fine to me.

Thanks,
Joe

On 7/3/2014 2:37 PM, Michael Fang wrote:
> Hi,
>
> Please help to code review the changes for the following CR:
> 8049128: 8u20 l10n resource file translation update 2 - jaxp
> https://bugs.openjdk.java.net/browse/JDK-8049128
>
> The webrev is located at:
> http://cr.openjdk.java.net/~mfang/8049128/webrev.jaxp.01/
>
> Since we perform resource file translation updates separately for 
> jdk9, jdk8
> and jdk7u, these changes are specific to jdk8u and not ported back from
> jdk9.
>
> thanks,
>
> -michael