FW: [8u40] Request for approval: 8042195: Introduce umbrella header orderAccess.inline.hpp.
Alejandro E Murillo
alejandro.murillo at oracle.com
Tue Jul 8 19:56:04 UTC 2014
On 7/8/2014 12:46 AM, Lindenmaier, Goetz wrote:
> Hi Alejandro,
>
> thanks for helping!
>
> I can't tell you where to find the closed part, as it's closed ;)
I know, I meant to ask David, but looks like you were in the "to" as
well in the reply,
in any case, Vladimir is on vacation, will talk to him about these
changes when he's back
he might push them himself
> Vladimir did the closed changes, he should know.
>
> Do you also want to do the next one right away? It also integrates
> as is:
> 8042737 : Introduce umbrella header prefetch.inline.hpp
If the original reviewers are ok with that, I can push this
thanks
Alejandro
> The bug:
> https://bugs.openjdk.java.net/browse/JDK-8042737
> The webrev:
> http://cr.openjdk.java.net/~goetz/webrevs/8042737-prefIncl/webrev.01/
> The mail thread:
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-May/013927.html
> The change:
> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/4cc7fe54e0e1
> Here Christian helped to push it.
>
> My later changes don't integrate yet, I guess they depend on some other
> change, therefore I'd wait another week or so.
>
> Best regards,
> Goetz.
>
>
>
>
>
> -----Original Message-----
> From: Alejandro E Murillo [mailto:alejandro.murillo at oracle.com]
> Sent: Montag, 7. Juli 2014 17:41
> To: David Holmes; Lindenmaier, Goetz;jdk8u-dev at openjdk.java.net
> Subject: Re: FW: [8u40] Request for approval: 8042195: Introduce umbrella header orderAccess.inline.hpp.
>
>
> Where is the closed part?
> Alejandro
>
> On 7/7/2014 5:03 AM, David Holmes wrote:
>> And we need to make sure the closed part goes with it!
>>
>> David
>>
>> On 7/07/2014 7:51 PM, Lindenmaier, Goetz wrote:
>>> Hi Alejandro,
>>>
>>> could you please assist with integrating this fix?
>>> Do I need to write another mail to another list / with another format?
>>>
>>> I think it should go to 8 so that later fixes which might depend
>>> on the new includes integrate nicely.
>>>
>>> Best regards,
>>> Goetz.
>>>
>>>
>>>
>>>
>>> -----Original Message-----
>>> From: Seán Coffey [mailto:sean.coffey at oracle.com]
>>> Sent: Montag, 7. Juli 2014 11:33
>>> To: Lindenmaier, Goetz;jdk8u-dev at openjdk.java.net
>>> Subject: Re: [8u40] Request for approval: 8042195: Introduce umbrella
>>> header orderAccess.inline.hpp.
>>>
>>> Goetz,
>>>
>>> this is a hotspot fix and needs to enter via the jdk8u hotspot team
>>> forest :
>>> http://hg.openjdk.java.net/jdk8u/hs-dev/
>>>
>>> Such fixes will enter the jdk8u master forest via bulk integration which
>>> Alejandro normally does. Please work with the hotspot team to get your
>>> fix integrated.
>>>
>>> regards,
>>> Sean.
>>>
>>> On 07/07/14 10:27, Lindenmaier, Goetz wrote:
>>>> Hi,
>>>>
>>>> Could you please approve the backport of this change to 8u40?
>>>> It applies cleanly without further changes.
>>>> Who will push this? Do I need a sponsor, or do you do that, Jean?
>>>>
>>>> The bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8042195
>>>> The webrev:
>>>> http://cr.openjdk.java.net/~goetz/webrevs/8042195-oaIncl/webrev.00/
>>>> The JDK 9 review thread:
>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-May/013745.html
>>>> The JDK 9 changeset:
>>>> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/2377269bd73d
>>>>
>>>> Thanks & best regards,
>>>> Goetz.
--
Alejandro
More information about the jdk8u-dev
mailing list