RFR: 8041602 - (prefs) Check jdk/src/windows/native/java/util/WindowsPreference.c for JNI pending exceptions

Alan Bateman Alan.Bateman at oracle.com
Mon Jun 2 13:37:09 UTC 2014


On 31/05/2014 23:02, Mark Sheppard wrote:
> Hi,
>    please oblige and review the following change
> http://cr.openjdk.java.net/~msheppar/8041602/webrev/
>
> which addresses the issue
> https://bugs.openjdk.java.net/browse/JDK-8041602
>
> which is a backport of
> https://bugs.openjdk.java.net/browse/JDK-8035340
>
> the original changeset didn't apply cleanly and was applied manually
> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/740ffd98e35a
>
This looks okay to me, I'm curious as whether it was just the new 
location in the jdk9/jdk tree that caused the issue or another change. A 
minor comment on L48 where it could be "if (result .." to be consistent.

-Alan





More information about the jdk8u-dev mailing list