[8u20] request for review and approval to backport JDK-8043186, JDK-8029800 and JDK-8030726

[Seán Coffey]

Looks fine to me. Still approved for JDK 8u20.

regards,
Sean.

On 03/06/2014 11:14, Jan Lahoda wrote:
> Jon,
>
> Thanks for the comment/review. I updated the review with the 
> overview.html fix:
> http://cr.openjdk.java.net/~jlahoda/jdk8u/webrev-8043186-8/
> The webrev includes also a delta webrev. The original webrev/previous 
> iteration is available here:
> http://cr.openjdk.java.net/~jlahoda/jdk8u/webrev-8043186-8.01
>
> Thanks,
>    Jan
>
> On 2.6.2014 22:15, Jonathan Gibbons wrote:
>> Almost approved: I leave the final call to Sean.
>>
>> The problem is in line 42 of the test in question:
>>
>>    42         "-overview", "SRC_DIR + FS + overview.html", "-use",
>> "-top", "\u0130{@docroot}TOP TEXT", "-d", BUG_ID, "-sourcepath",
>>
>>
>> Although the changes made by Jan are OK/approved, the line of code
>> contains a different error which renders the test somewhat useless :-(
>> Specifically, the string
>>
>> "SRC_DIR + FS + overview.html"
>>
>> should always have been the expression
>>
>> SRC_DIR + FS + "overview.html"
>>
>>
>> -- Jon
>>
>> On 05/30/2014 03:42 AM, Seán Coffey wrote:
>>> Approved but subject to reviewer approval also.
>>>
>>> regards,
>>> Sean.
>>>
>>> On 30/05/2014 10:48, Jan Lahoda wrote:
>>>> Hello,
>>>>
>>>> I'd like to ask for a review of a backport fix, and an approval to
>>>> push it to jdk8u/jdk8u-dev, for the following bug:
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8043186
>>>> ('javac test langtools/tools/javac/util/StringUtilsTest.java fails')
>>>> jdk9 fix: 
>>>> http://hg.openjdk.java.net/jdk9/dev/langtools/rev/4487f6f98252
>>>> jdk8u patch: 
>>>> http://cr.openjdk.java.net/~jlahoda/jdk8u/webrev-8043186-8/
>>>>
>>>> The only difference between the JDK9 and JDK8u fixes is in this test:
>>>> test/com/sun/javadoc/testTopOption/TestTopOption.java
>>>>
>>>> This fix requires also backport of these two other fixes:
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029800
>>>> jdk9 fix: 
>>>> http://hg.openjdk.java.net/jdk9/dev/langtools/rev/bc18278c195e
>>>> jdk8u patch: 
>>>> http://cr.openjdk.java.net/~jlahoda/jdk8u/webrev-8029800-8/
>>>> (applies cleanly except one change in copyright years which is
>>>> already part of jdk8u/jdk8u-dev/langtools)
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8030726
>>>> jdk9 fix: 
>>>> http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c0ebdd10888c
>>>> jdk8u patch: 
>>>> http://cr.openjdk.java.net/~jlahoda/jdk8u/webrev-8030726-8/
>>>> Applies cleanly to: 
>>>> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/langtools
>>>>
>>>> Thanks,
>>>>    Jan
>>>
>>