[8u20]: Request for Review/Approval: JDK-8044046: [asm] refresh internal ASM version to v5.0.3

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Wed Jun 4 14:58:42 UTC 2014


As an fyi, Since this changeset was thought to have created issues, but 
actually "not",
just to play it safe I am delaying the push for 8u until jdk9-b17 is 
promoted
which would contain the 9 version of this changeset.

Kumar

On 6/3/2014 11:49 AM, Seán Coffey wrote:
> Approved.
>
> regards,
> Sean.
>
> On 03/06/2014 16:50, A. Sundararajan wrote:
>> Hi Kumar,
>>
>> Looks good to me.
>>
>> -Sundar
>>
>> On Tuesday 03 June 2014 07:46 PM, Kumar Srinivasan wrote:
>>> Hi Sundar, Paul,
>>>
>>> Can one of you review this ? the difference between the 9 and 8u 
>>> changeset is shown below,
>>> once you two review, Sean will approve this for 8u.
>>>
>>> Thanks
>>>
>>> Kumar
>>>
>>> On 5/30/2014 4:07 PM, Kumar Srinivasan wrote:
>>>> Hello Paul, Sean, Sundar,
>>>>
>>>> Please review and approve the fix for:
>>>> https://bugs.openjdk.java.net/browse/JDK-8044046
>>>>
>>>> The JDK9 changesets (for ref) are here:
>>>> http://cr.openjdk.java.net/~ksrini/8044046/jdk9/webrev.00/
>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e95072225d17
>>>>
>>>> The JDK8u changeset is here:
>>>> http://cr.openjdk.java.net/~ksrini/8044046/jdk8u/webrev.00/
>>>>
>>>> The diffs between jdk9 and jdk8u are the same except for 8u two 
>>>> @SuppressWarnings are being added to keep the
>>>> code in sync with jdk9, this will make the merges from ASM and 
>>>> ObjectWeb seamless.
>>>>
>>>> The two specific files are:
>>>> http://cr.openjdk.java.net/~ksrini/8044046/jdk8u/webrev.00/src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java.udiff.html 
>>>>
>>>> and
>>>> http://cr.openjdk.java.net/~ksrini/8044046/jdk8u/webrev.00/src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java.udiff.html 
>>>>
>>>>
>>>> Thanks
>>>> Kumar
>>>>
>>>>
>>>
>>
>



More information about the jdk8u-dev mailing list