RFR: [8u20]: 8037221: [asm] refresh internal ASM version

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Fri Mar 21 14:40:09 UTC 2014


Ah I see, I  have cc'ed Paul Sandoz,  he usually reviews these for me.


On 3/21/2014 7:12 AM, Seán Coffey wrote:
> "Hello, is it me you're looking for?" - actually, let's not go down 
> the Lionel route ;)
Nicely done.

Kumar

>
> I was hoping someone from the tools group could review but the minor 
> change (or non-changes) needed to import this into jdk8u-dev seem fine 
> to me Kumar. Consider this approved for for 8u20 also.
>
> regards,
> Sean.
>
> On 21/03/14 13:58, Kumar Srinivasan wrote:
>> "Hello? Hello? Hello?
>> Is there anybody in there?
>> Just nod if you can hear me.
>> Is there anyone at home?
>> ....."                     --- Pink Floyd
>>
>> Kumar
>>
>> On 3/20/2014 8:22 AM, Kumar Srinivasan wrote:
>>>
>>> On 3/19/2014 6:14 PM, Kumar Srinivasan wrote:
>>>> Hello,
>>>>
>>>> Please review and approve the back-port of the above fix, the fix 
>>>> is simply a refresh of the
>>>> sources from ObjectWeb's ASM5_GA.
>>>>
>>>> The bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8037221
>>>> Webrev in for jdk9:
>>>> http://cr.openjdk.java.net/~ksrini/8037221/webrev.0/
>>>> Changeset for jdk9:
>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/a791773d6e91
>>>>
>>>> The backport:
>>>> https://bugs.openjdk.java.net/browse/JDK-8037478
>>>>
>>>> Webrev for jdk8u20:
>>>> http://cr.openjdk.java.net/~ksrini/8037221/webrev.1/
>>>>
>>>> There is a subtle difference between the two, for 8u20  the following
>>>> two files  were removed, since those changes don't exist in 8 and 
>>>> 8u20.
>>>
>>> After rereading my email,  I should clarify that,  these files were 
>>> not *removed*,
>>> however the diffs associated with these files were removed from the 
>>> 8u20 webrev.
>>>
>>> Kumar
>>>
>>>>
>>>> src/share/classes/jdk/internal/org/objectweb/asm/tree/MethodNode.java
>>>> src/share/classes/jdk/internal/org/objectweb/asm/tree/analysis/AnalyzerException.java 
>>>>
>>>>
>>>>
>>>> Thanks in advance.
>>>> Kumar
>>>>
>>>>
>>>>
>>>
>>
>




More information about the jdk8u-dev mailing list