RFR(S): 8043529: Serviceability tests using @library failing with java.lang.NoClassDefFoundError

[Yekaterina Kantserova]

Thanks Staffan!

Jaroslav, could you please be my sponsor and push the change? The patch 
is attached to this mail.

Thanks,
Katja



On 05/22/2014 01:09 PM, Staffan Larsen wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
> On 22 maj 2014, at 11:35, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>
>> Thanks Jaroslav!
>>
>> Please find a new webrev here: http://cr.openjdk.java.net/~ykantser/8043529/webrev.01/
>>
>> // Katja
>>
>>
>>
>> On 05/22/2014 09:37 AM, Jaroslav Bachorik wrote:
>>> Hi Katja,
>>>
>>> On 05/22/2014 09:22 AM, Yekaterina Kantserova wrote:
>>>> Hi,
>>>>
>>>> Could I please have a review of this fix.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8043529
>>>> Webrev: http://cr.openjdk.java.net/~ykantser/8043529/webrev.00/
>>> Just a few small issues -
>>>
>>> * test/com/sun/jdi/ExclusiveBind.java L30 is superfluous; it duplicates the build section of the previous line
>>>
>>> * test/java/io/BufferedInputStream/LargeCopyWithMark.java L29 has wrong indentation (extra leading space)
>>>
>>> * test/java/lang/invoke/MethodHandles/CatchExceptionTest.java L40 - wrong indentation (extra leading space)
>>>
>>> * test/sun/reflect/AnonymousNewInstance/ManyNewInstanceAnonTest.java L31 - wrong indentation (extra leading space)
>>>
>>> The rest is fine.
>>>
>>> Cheers,
>>>
>>> -JB-
>>>
>>>> When using @library in a JTreg test even @build need to be specify for
>>>> all library files used by the test. If @build is not specified it can
>>>> lead to intermittent failures when running tests concurrently, since
>>>> javac implicit compilation and @library and -concurrency don't play well
>>>> together.
>>>>
>>>> This is a combine backport of
>>>> https://bugs.openjdk.java.net/browse/JDK-8034960 and
>>>> https://bugs.openjdk.java.net/browse/JDK-8043520. Both changes have been
>>>> reviewed and approved.
>>>>
>>>>
>>>> Thanks,
>>>> Katja
>>>>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8043520.2.patch
Type: text/x-patch
Size: 13311 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/jdk8u-dev/attachments/20140522/ebcf7ae6/8043520.2-0001.patch>