From attila.szegedi at oracle.com Mon Nov 3 06:30:31 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 3 Nov 2014 07:30:31 +0100 Subject: [8u40] Request for Approval: 8061957: Some arithmetic operations have unnecessary widening Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8061957 jdk9 webrev: http://cr.openjdk.java.net/~attila/8061957/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003720.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From attila.szegedi at oracle.com Mon Nov 3 06:31:13 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 3 Nov 2014 07:31:13 +0100 Subject: [8u40] Request for Approval: 8062050: A method is considered caller sensitive, but it doesn't have the CallerSensitive annotation Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8062050 jdk9 webrev: http://cr.openjdk.java.net/~attila/8062050/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003729.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From sean.coffey at oracle.com Mon Nov 3 09:12:45 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 03 Nov 2014 09:12:45 +0000 Subject: [8u40] Request for approval for bulk integration of hs25.40-b17 In-Reply-To: <5453F22E.1040809@oracle.com> References: <5453F22E.1040809@oracle.com> Message-ID: <5457470D.9080802@oracle.com> Approved pending positive PIT results. regards, Sean. On 31/10/2014 20:33, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.40-b17 into jdk8u40-b13. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b17-jdk8u40-b13.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8034056: assert(_heap_alignment >= _space_alignment) failed: > heap_alignment less than space_alignment > 8034775: Failing to initialize VM when running with negative value for > -XX:CICompilerCount > 8036091: compiler/membars/DekkerTest.java fails with > -XX:CICompilerCount=1 > 8038268: VM Crashes in MetaspaceShared::generate_vtable_methods while > creating CDS archive with limiting SharedMiscCodeSize > 8038393: [TESTBUG] ciReplay/* tests fail after 8034775 > 8038422: CDS test failed: assert((size % > os::vm_allocation_granularity()) == 0) failed when limiting > SharedMiscDataSize > 8040798: compiler/startup/SmallCodeCacheStartup.java timed out in > RT_Baseline > 8041984: CompilerThread seems to occupy all CPU in a very rare situation > 8041992: Fix of JDK-8034775 neglects to account for non-JIT VMs > 8042428: CompileQueue::free_all() code is incorrect > 8042431: compiler/7200264/TestIntVect.java fails with: Test Failed: > AddVI 0 < 4 > 8042570: Excessive number of tests timing out on nightly testing due > to fix for 8040798 > 8043158: Crash in CodeSweeperSweepNoFlushTest in CompileQueue::free_all() > 8043275: 8u40 backport: Fix interface initialization for default methods. > 8047383: SIGBUS in C2 compiled method > weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions. > 8047934: Adding new API for unlocking diagnostic argument. > 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no > overflow > 8054530: C2: assert(res == old_res) failed: Inconsistency between old > and new > 8058568: GC cleanup phase can cause G1 skipping a System.gc() > 8058606: [TESTBUG] Detailed Native Memory Tracking (NMT) data is not > verified as output at VM exit > 8058825: EA: ConnectionGraph::split_unique_types does incorrect scalar > replacement > 8058828: Wrong ciConstant type for arrays from > ConstantPool::_resolved_reference > 8059200: Promoted JDK9 b31 for Solaris-amd64 fails (Error: dl failure > on line 744, no picl library) on Solaris 11.1 > 8059445: Remove CompilationRepeat > 8059556: C2: crash while inlining MethodHandle invocation w/ null > receiver > 8061234: ResourceContext.requestAccurateUpdate() is unreliable > 8061861: new hotspot build - hs25.40-b17 > 8062501: Modifications of server socket channel accept() methods for > instrumentation purposes > From sean.coffey at oracle.com Mon Nov 3 09:16:35 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 03 Nov 2014 09:16:35 +0000 Subject: [8u40] Request for Approval: 8061957: Some arithmetic operations have unnecessary widening In-Reply-To: References: Message-ID: <545747F3.9050207@oracle.com> Could this bug report be made public Attila ? Please add a suitable noreg- label also. Approved. regards, Sean. On 03/11/2014 06:30, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8061957 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8061957/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003720.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From sean.coffey at oracle.com Mon Nov 3 09:17:27 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 03 Nov 2014 09:17:27 +0000 Subject: [8u40] Request for Approval: 8062050: A method is considered caller sensitive, but it doesn't have the CallerSensitive annotation In-Reply-To: References: Message-ID: <54574827.1050609@oracle.com> Approved. regards, Sean. On 03/11/2014 06:31, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062050 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8062050/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003729.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From attila.szegedi at oracle.com Mon Nov 3 09:32:48 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 3 Nov 2014 10:32:48 +0100 Subject: [8u40] Request for Approval: 8061957: Some arithmetic operations have unnecessary widening In-Reply-To: <545747F3.9050207@oracle.com> References: <545747F3.9050207@oracle.com> Message-ID: I have evaluated it and there is indeed no reason for this bug to be marked confident, I made it public (it inherited its security level from its parent, for which it is a sub-task; the parent has no need to be confident either). Also added noreg-perf. Thanks, Attila. On Nov 3, 2014, at 10:16 AM, Se?n Coffey wrote: > Could this bug report be made public Attila ? > Please add a suitable noreg- label also. > > Approved. > > regards, > Sean. > > On 03/11/2014 06:30, Attila Szegedi wrote: >> Please approve. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8061957 >> jdk9 webrev: http://cr.openjdk.java.net/~attila/8061957/webrev.00 >> jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-October/003720.html >> >> Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. >> >> Thanks, >> Attila. > From lana.steuck at oracle.com Mon Nov 3 17:45:11 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 3 Nov 2014 09:45:11 -0800 (PST) Subject: jdk8u-b13: jdk8u-dev Message-ID: <201411031745.sA3HjB1A000699@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk8u/jdk8u/rev/43ccc2b9d5b7 http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/d60fbb5343c1 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/88ce114c6adc http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/20688e65812b http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/42a61f4bdca3 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/9df027c40f0f http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/c1d0d673b1ba http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/7f8454e2f02f --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-6521706 client-libs A switch operator in JFrame.processWindowEvent() should be rewritten JDK-8054372 client-libs Cleanup of com.sun.media.sound packages JDK-8033141 client-libs Cleanup of sun.awt.X11 package JDK-8028539 client-libs Endless loop in native code of sun.java2d.loops.ScaledBlit JDK-8026497 client-libs Font2DTest demo: unused resource files JDK-8054431 client-libs Some of the input validation in the javasound is too strict JDK-7058700 client-libs Unexpected exceptions and timeouts in SF2 parser code JDK-7058697 client-libs Unexpected exceptions in MID parser code JDK-8060485 core-libs (str) contentEquals checks the String contents twice on mismatch JDK-8059206 core-libs (tz) Support tzdata2014i JDK-8058892 core-libs FILL_ARRAYS and ARRAYS are eagely initialized in MethodHandleImpl JDK-8062024 core-libs Issue with date.setFullYear when time other than midnight JDK-8062132 core-libs Nashorn incorrectly binds "this" for constructor created by another function JDK-8061391 core-libs String.concat needs to have optimistic builtin versions JDK-8062583 core-libs Throwing object with error prototype causes error proto to be caught JDK-8062401 core-libs User accessors require boxing and do not support optimistic types JDK-8062216 core-libs [nashorn] regresion test failure with TimeZone JDK-8062233 core-libs add java/rmi/server/Unreferenced/finiteGCLatency/FiniteGCLatency.java to problem list JDK-8061955 core-libs asm.js idioms result in unnecessarily code emission JDK-8047073 core-svc Some javax/management/ fails with JFR JDK-8060169 hotspot Update the Crash Reporting URL in the Java crash log JDK-8062635 infrastructure Enable custom CompileJavaClasses.gmk JDK-8062475 infrastructure Enable hook for custom doc generation JDK-8062565 performance CMM: MBean must require -XX:+UnlockCommercialFeatures JDK-8054448 tools (ann) Cannot reference field of inner class in an anonymous class JDK-8058511 tools StackOverflowError at com.sun.tools.javac.code.Types.lub JDK-8059710 tools javac, the same approach used in fix for JDK-8058708 should be applied to Code.closeAliveRanges From maurizio.cimadamore at oracle.com Mon Nov 3 22:21:13 2014 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Mon, 03 Nov 2014 22:21:13 +0000 Subject: [8u40] Request for review: 8057800: Method reference with generic type creates NPE when compiling In-Reply-To: <545286FB.20803@oracle.com> References: <545286FB.20803@oracle.com> Message-ID: <5457FFD9.6080700@oracle.com> Looks good to me Maurizio On 30/10/14 18:44, Vicente-Arturo Romero-Zaldivar wrote: > > Hi, > > Please review the backport of this bug to 8u40. I'm asking for review > as the patch didn't apply cleanly but the difference is minimal. > > Thanks, > Vicente > > Bug: https://bugs.openjdk.java.net/browse/JDK-8057800 > Webrev: http://cr.openjdk.java.net/~vromero/8057800/webrev.00 > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/211903a785f3 > > Thanks, > Vicente > From vicente.romero at oracle.com Mon Nov 3 22:45:57 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 03 Nov 2014 14:45:57 -0800 Subject: [8u40] Request for approval: 8057800: Method reference with generic type creates NPE when compiling Message-ID: <545805A5.2010300@oracle.com> Hi, Please approve the backport of this bug to 8u40. Bug: https://bugs.openjdk.java.net/browse/JDK-8057800 Webrev: http://cr.openjdk.java.net/~vromero/8057800/webrev.00 JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/211903a785f3 open review: http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002342.html Thanks, Vicente From rob.mckenna at oracle.com Mon Nov 3 23:40:57 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 03 Nov 2014 23:40:57 +0000 Subject: [8u40] Request for approval: 8057800: Method reference with generic type creates NPE when compiling In-Reply-To: <545805A5.2010300@oracle.com> References: <545805A5.2010300@oracle.com> Message-ID: <54581289.4010703@oracle.com> Approved. -Rob On 03/11/14 22:45, Vicente-Arturo Romero-Zaldivar wrote: > Hi, > > Please approve the backport of this bug to 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8057800 > Webrev: http://cr.openjdk.java.net/~vromero/8057800/webrev.00 > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/211903a785f3 > open review: > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002342.html > > Thanks, > Vicente From alejandro.murillo at oracle.com Tue Nov 4 02:48:32 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Mon, 03 Nov 2014 19:48:32 -0700 Subject: jdk8u40-b13: HotSpot,------- Message-ID: <54583E80.8060203@oracle.com> hs25.40-b17 has been integrated into jdk8u40-b13. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/43ccc2b9d5b7 http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/7f8454e2f02f http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/86307d477907 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/9df027c40f0f http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/42a61f4bdca3 http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ba80109a9b3e http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/88ce114c6adc http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/d60fbb5343c1 Only a few new issues discovered and all seems "infra related" so you are go for integration! PIT certificate will be sent later. CRs for testing: 8034056: assert(_heap_alignment >= _space_alignment) failed: heap_alignment less than space_alignment 8034775: Failing to initialize VM when running with negative value for -XX:CICompilerCount 8036091: compiler/membars/DekkerTest.java fails with -XX:CICompilerCount=1 8038268: VM Crashes in MetaspaceShared::generate_vtable_methods while creating CDS archive with limiting SharedMiscCodeSize 8038393: [TESTBUG] ciReplay/* tests fail after 8034775 8038422: CDS test failed: assert((size % os::vm_allocation_granularity()) == 0) failed when limiting SharedMiscDataSize 8040798: compiler/startup/SmallCodeCacheStartup.java timed out in RT_Baseline 8041984: CompilerThread seems to occupy all CPU in a very rare situation 8041992: Fix of JDK-8034775 neglects to account for non-JIT VMs 8042428: CompileQueue::free_all() code is incorrect 8042431: compiler/7200264/TestIntVect.java fails with: Test Failed: AddVI 0 < 4 8042570: Excessive number of tests timing out on nightly testing due to fix for 8040798 8043158: Crash in CodeSweeperSweepNoFlushTest in CompileQueue::free_all() 8043275: 8u40 backport: Fix interface initialization for default methods. 8047383: SIGBUS in C2 compiled method weblogic.wsee.jaxws.framework.jaxrpc.EnvironmentFactory$SimulatedWsdlDefinitions. 8047934: Adding new API for unlocking diagnostic argument. 8049542: C2: assert(size_in_words <= (julong)max_jint) failed: no overflow 8054530: C2: assert(res == old_res) failed: Inconsistency between old and new 8058568: GC cleanup phase can cause G1 skipping a System.gc() 8058606: [TESTBUG] Detailed Native Memory Tracking (NMT) data is not verified as output at VM exit 8058825: EA: ConnectionGraph::split_unique_types does incorrect scalar replacement 8058828: Wrong ciConstant type for arrays from ConstantPool::_resolved_reference 8059200: Promoted JDK9 b31 for Solaris-amd64 fails (Error: dl failure on line 744, no picl library) on Solaris 11.1 8059445: Remove CompilationRepeat 8059556: C2: crash while inlining MethodHandle invocation w/ null receiver 8061234: ResourceContext.requestAccurateUpdate() is unreliable 8061861: new hotspot build - hs25.40-b17 8062501: Modifications of server socket channel accept() methods for instrumentation purposes -- Alejandro From marcus.lagergren at oracle.com Tue Nov 4 11:34:14 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 4 Nov 2014 12:34:14 +0100 Subject: Please approve backport request JDK-8061959.js to 8u40 Message-ID: <9243ABA9-2937-4C7C-BDE8-8B48C48CDF37@oracle.com> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003798.html Webrev: http://cr.openjdk.java.net/~lagergren/8061959/ Issue: https://bugs.openjdk.java.net/browse/JDK- 8061959 /M From marcus.lagergren at oracle.com Tue Nov 4 11:34:51 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 4 Nov 2014 12:34:51 +0100 Subject: Please approve backport request for JDK-8062490 to 8u40 Message-ID: <10FFFCF3-95EE-4AE5-A20C-24F72DDE576E@oracle.com> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003800.html Webrev: http://cr.openjdk.java.net/~lagergren/8062490/ Issue: https://bugs.openjdk.java.net/browse/JDK-8062490 /M From marcus.lagergren at oracle.com Tue Nov 4 11:36:10 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 4 Nov 2014 12:36:10 +0100 Subject: Please approve backport request for JDK-8062381 to 8u40 Message-ID: Webrev: http://cr.openjdk.java.net/~lagergren/8062381/ CR: https://bugs.openjdk.java.net/browse/JDK-8062381 Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003795.html /M From marcus.lagergren at oracle.com Tue Nov 4 11:37:05 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 4 Nov 2014 12:37:05 +0100 Subject: Please approve backport request for JDK-8060204 to 8u40 Message-ID: <6031A364-B21F-43CA-BE84-B1944A3F5E0F@oracle.com> Webrev: http://cr.openjdk.java.net/~lagergren/8060204/ CR: https://bugs.openjdk.java.net/browse/JDK-806 0204 Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003787.html /M From sean.coffey at oracle.com Tue Nov 4 11:38:31 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 04 Nov 2014 11:38:31 +0000 Subject: Please approve backport request JDK-8061959.js to 8u40 In-Reply-To: <9243ABA9-2937-4C7C-BDE8-8B48C48CDF37@oracle.com> References: <9243ABA9-2937-4C7C-BDE8-8B48C48CDF37@oracle.com> Message-ID: <5458BAB7.6050703@oracle.com> Approved. regards, Sean. On 04/11/2014 11:34, Marcus Lagergren wrote: > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003798.html > Webrev: http://cr.openjdk.java.net/~lagergren/8061959/ > Issue: https://bugs.openjdk.java.net/browse/JDK- 8061959 > > /M > > From sean.coffey at oracle.com Tue Nov 4 11:39:43 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 04 Nov 2014 11:39:43 +0000 Subject: Please approve backport request for JDK-8062490 to 8u40 In-Reply-To: <10FFFCF3-95EE-4AE5-A20C-24F72DDE576E@oracle.com> References: <10FFFCF3-95EE-4AE5-A20C-24F72DDE576E@oracle.com> Message-ID: <5458BAFF.1020404@oracle.com> Please add a suitable noreg- label to the bug report. Approved. regards, Sean. On 04/11/2014 11:34, Marcus Lagergren wrote: > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003800.html > Webrev: http://cr.openjdk.java.net/~lagergren/8062490/ > Issue: https://bugs.openjdk.java.net/browse/JDK-8062490 > > /M From sean.coffey at oracle.com Tue Nov 4 11:40:25 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 04 Nov 2014 11:40:25 +0000 Subject: Please approve backport request for JDK-8062381 to 8u40 In-Reply-To: References: Message-ID: <5458BB29.4030104@oracle.com> Approved. regards, Sean. On 04/11/2014 11:36, Marcus Lagergren wrote: > Webrev: http://cr.openjdk.java.net/~lagergren/8062381/ > CR: https://bugs.openjdk.java.net/browse/JDK-8062381 > > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003795.html > > /M > > From sean.coffey at oracle.com Tue Nov 4 11:43:10 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 04 Nov 2014 11:43:10 +0000 Subject: Please approve backport request for JDK-8060204 to 8u40 In-Reply-To: <6031A364-B21F-43CA-BE84-B1944A3F5E0F@oracle.com> References: <6031A364-B21F-43CA-BE84-B1944A3F5E0F@oracle.com> Message-ID: <5458BBCE.2090606@oracle.com> Approved. regards, Sean. On 04/11/2014 11:37, Marcus Lagergren wrote: > Webrev: http://cr.openjdk.java.net/~lagergren/8060204/ > CR: https://bugs.openjdk.java.net/browse/JDK-806 0204 > > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003787.html > > /M From marcus.lagergren at oracle.com Tue Nov 4 11:54:18 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Tue, 4 Nov 2014 12:54:18 +0100 Subject: Please approve backport request for JDK-8062490 to 8u40 In-Reply-To: <5458BAFF.1020404@oracle.com> References: <10FFFCF3-95EE-4AE5-A20C-24F72DDE576E@oracle.com> <5458BAFF.1020404@oracle.com> Message-ID: <2880CF0F-AEE3-4AF1-A7B9-69691BA935EC@oracle.com> Done. > On 04 Nov 2014, at 12:39, Se?n Coffey wrote: > > Please add a suitable noreg- label to the bug report. > > Approved. > > regards, > Sean. > > On 04/11/2014 11:34, Marcus Lagergren wrote: >> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003800.html >> Webrev: http://cr.openjdk.java.net/~lagergren/8062490/ >> Issue: https://bugs.openjdk.java.net/browse/JDK-8062490 >> >> /M > From daniel.fuchs at oracle.com Tue Nov 4 12:12:30 2014 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Tue, 04 Nov 2014 13:12:30 +0100 Subject: [8u40] Request for approval - 8048913: java/util/logging/LoggingDeadlock2.java times out Message-ID: <5458C2AE.8010701@oracle.com> Hi, This is a request for approval to backport a fix for a test bug: 8048913: java/util/logging/LoggingDeadlock2.java times out JBS: https://bugs.openjdk.java.net/browse/JDK-8048913 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/3414f6e34216 Review Thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027614.html best regards, -- daniel From sean.coffey at oracle.com Tue Nov 4 12:23:00 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 04 Nov 2014 12:23:00 +0000 Subject: [8u40] Request for approval - 8048913: java/util/logging/LoggingDeadlock2.java times out In-Reply-To: <5458C2AE.8010701@oracle.com> References: <5458C2AE.8010701@oracle.com> Message-ID: <5458C524.3050305@oracle.com> Approved. regards, Sean. On 04/11/2014 12:12, Daniel Fuchs wrote: > Hi, > > This is a request for approval to backport a fix for a test bug: > 8048913: java/util/logging/LoggingDeadlock2.java times out > > JBS: https://bugs.openjdk.java.net/browse/JDK-8048913 > JDK9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/3414f6e34216 > Review Thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027614.html > > best regards, > > -- daniel From michael.x.mcmahon at oracle.com Tue Nov 4 16:59:29 2014 From: michael.x.mcmahon at oracle.com (Michael McMahon) Date: Tue, 04 Nov 2014 16:59:29 +0000 Subject: [8u-dev] Request for approval: 8082744 jdk.net.Sockets.setOption/getOption does not support IP_TOS Message-ID: <545905F1.1000909@oracle.com> Hi Looking for approval for backport of this fix to 8u-dev Bug: https://bugs.openjdk.java.net/browse/JDK-8062744 Webrev: http://cr.openjdk.java.net/~michaelm/8062744/webrev.1.jdk8/ JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/30c2d576a1be Review thread: http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008743.html Thanks, Michael From sean.coffey at oracle.com Tue Nov 4 17:00:33 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 04 Nov 2014 17:00:33 +0000 Subject: [8u-dev] Request for approval: 8082744 jdk.net.Sockets.setOption/getOption does not support IP_TOS In-Reply-To: <545905F1.1000909@oracle.com> References: <545905F1.1000909@oracle.com> Message-ID: <54590631.9060601@oracle.com> Thanks for looking after that Michael. Approved. regards, Sean. On 04/11/2014 16:59, Michael McMahon wrote: > Hi > > Looking for approval for backport of this fix to 8u-dev > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062744 > Webrev: http://cr.openjdk.java.net/~michaelm/8062744/webrev.1.jdk8/ > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/30c2d576a1be > Review thread: > http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008743.html > > Thanks, > Michael From david.holmes at oracle.com Wed Nov 5 02:33:40 2014 From: david.holmes at oracle.com (David Holmes) Date: Wed, 05 Nov 2014 12:33:40 +1000 Subject: [8u40] Request for approval: 8036616: [TESTBUG] Embedded: sun/jvmstat/monitor/MonitoredVm/CR6672135.java should be launched with -XX:+UsePerfData Message-ID: <54598C84.7090906@oracle.com> Hi, This is a request for approval to backport a fix for a test bug: 8036616: [TESTBUG] Embedded: sun/jvmstat/monitor/MonitoredVm/CR6672135.java should be launched with -XX:+UsePerfData JBS: https://bugs.openjdk.java.net/browse/JDK-8036616 JDK9 Changeset: http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/ec59eacb6957 Review Thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-November/015857.html Changeset imported directly. Thanks, David From sean.coffey at oracle.com Wed Nov 5 08:58:29 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 05 Nov 2014 08:58:29 +0000 Subject: [8u40] Request for approval: 8036616: [TESTBUG] Embedded: sun/jvmstat/monitor/MonitoredVm/CR6672135.java should be launched with -XX:+UsePerfData In-Reply-To: <54598C84.7090906@oracle.com> References: <54598C84.7090906@oracle.com> Message-ID: <5459E6B5.10503@oracle.com> Ideally this could go into the jdk8u team hotspot forest where approvals are done at bulk integration time. That said, it's a simple testcase fix and pushing to jdk8u-dev wouldn't be a problem. Approved. regards, Sean. On 05/11/2014 02:33, David Holmes wrote: > Hi, > > This is a request for approval to backport a fix for a test bug: > > 8036616: [TESTBUG] Embedded: > sun/jvmstat/monitor/MonitoredVm/CR6672135.java should be launched with > -XX:+UsePerfData > > JBS: https://bugs.openjdk.java.net/browse/JDK-8036616 > JDK9 Changeset: > http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/ec59eacb6957 > Review Thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-November/015857.html > > Changeset imported directly. > > Thanks, > David From alexander.zvegintsev at oracle.com Wed Nov 5 09:42:51 2014 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Wed, 05 Nov 2014 12:42:51 +0300 Subject: [8u40] Request for approval 8058197: AWT fails on generic non-reparenting window In-Reply-To: <54477EE6.7080900@oracle.com> References: <54477EE6.7080900@oracle.com> Message-ID: <5459F11B.3050103@oracle.com> CCC request is approved now for 9 and 8uX, so could I get an approval for this backport? Thanks, Alexander. On 10/22/2014 01:54 PM, Alexander Zvegintsev wrote: > Hello, > > This is a request for approval to backport a fix from the jdk9 to the > jdk8u-dev repository. > Changes applies cleanly to jdk8u-dev after path reshuffling. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8058197 > The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/a06c13cb2e45 > The review: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008613.html > From sean.coffey at oracle.com Wed Nov 5 09:46:29 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 05 Nov 2014 09:46:29 +0000 Subject: [8u40] Request for approval 8058197: AWT fails on generic non-reparenting window In-Reply-To: <5459F11B.3050103@oracle.com> References: <54477EE6.7080900@oracle.com> <5459F11B.3050103@oracle.com> Message-ID: <5459F1F5.50309@oracle.com> Approved. Please add a suitable noreg- label to master bug record. regards, Sean. On 05/11/2014 09:42, Alexander Zvegintsev wrote: > CCC request is approved now for 9 and 8uX, so could I get an approval > for this backport? > > Thanks, > > Alexander. > > On 10/22/2014 01:54 PM, Alexander Zvegintsev wrote: >> Hello, >> >> This is a request for approval to backport a fix from the jdk9 to the >> jdk8u-dev repository. >> Changes applies cleanly to jdk8u-dev after path reshuffling. >> >> The bug: https://bugs.openjdk.java.net/browse/JDK-8058197 >> The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/a06c13cb2e45 >> The review: >> http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008613.html >> > From bengt.rutisson at oracle.com Wed Nov 5 11:19:10 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 05 Nov 2014 12:19:10 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson Message-ID: <545A07AE.6040003@oracle.com> I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has 12 changesets in JDK 8 [1]. Votes are due by 1300 CET November 19, 2014. Only current JDK8u Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [3]. Thanks, Albert [1] http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com [2] http://openjdk.java.net/census#jdk8u [3] http://openjdk.java.net/projects#committer-vote From bengt.rutisson at oracle.com Wed Nov 5 11:21:44 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Wed, 05 Nov 2014 12:21:44 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545A0848.5080005@oracle.com> Vote: yes Bengt On 2014-11-05 12:19, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has > 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From marcus.lagergren at oracle.com Wed Nov 5 11:43:57 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 5 Nov 2014 12:43:57 +0100 Subject: Please approve backport request to 8u40 for Message-ID: <2E72B7E6-CF6A-4383-A63E-EAE579CD68AB@oracle.com> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003806.html Bug: https://bugs.openjdk.java.net/browse/JDK-8057825 Webrev at: http://cr.openjdk.java.net/~lagergren/8057825/ /M From sean.coffey at oracle.com Wed Nov 5 11:48:30 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 05 Nov 2014 11:48:30 +0000 Subject: Please approve backport request to 8u40 for - JDK-8057825 In-Reply-To: <2E72B7E6-CF6A-4383-A63E-EAE579CD68AB@oracle.com> References: <2E72B7E6-CF6A-4383-A63E-EAE579CD68AB@oracle.com> Message-ID: <545A0E8E.3010708@oracle.com> Assuming this applies cleanly post modular unshuffling. For the future, can you also use a complete subject line as per template request [1]. Approved. regards, Sean. [1] http://openjdk.java.net/projects/jdk8u/approval-template.html On 05/11/14 11:43, Marcus Lagergren wrote: > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003806.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8057825 > Webrev at: http://cr.openjdk.java.net/~lagergren/8057825/ > /M > From mikhail.cherkasov at oracle.com Wed Nov 5 12:14:24 2014 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Wed, 05 Nov 2014 15:14:24 +0300 Subject: Request to backport 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 In-Reply-To: <54521942.4030705@oracle.com> References: <54521942.4030705@oracle.com> Message-ID: <545A14A0.60309@oracle.com> Hi there. It's just kindly reminder about this request for backport approval. Thanks, Mikhail. On 10/30/2014 1:56 PM, mikhail cherkasov wrote: > Hi there, > > I would like to backport this fix from jdk9: > > bug: https://bugs.openjdk.java.net/browse/JDK-8062021 > review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008617.html > jdk9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/2f5c1e181647 > > Thanks, > Mikhail. From rob.mckenna at oracle.com Wed Nov 5 13:05:13 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 05 Nov 2014 13:05:13 +0000 Subject: Request to backport 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 In-Reply-To: <545A14A0.60309@oracle.com> References: <54521942.4030705@oracle.com> <545A14A0.60309@oracle.com> Message-ID: <545A2089.7020907@oracle.com> Approved. -Rob On 05/11/14 12:14, mikhail cherkasov wrote: > Hi there. > > It's just kindly reminder about this request for backport approval. > > Thanks, > Mikhail. > > On 10/30/2014 1:56 PM, mikhail cherkasov wrote: >> Hi there, >> >> I would like to backport this fix from jdk9: >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8062021 >> review thread: >> http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008617.html >> jdk9 changeset: >> http://hg.openjdk.java.net/jdk9/client/jdk/rev/2f5c1e181647 >> >> Thanks, >> Mikhail. > From sean.coffey at oracle.com Wed Nov 5 13:06:51 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 05 Nov 2014 13:06:51 +0000 Subject: Request to backport 8062021: NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 In-Reply-To: <545A2089.7020907@oracle.com> References: <54521942.4030705@oracle.com> <545A14A0.60309@oracle.com> <545A2089.7020907@oracle.com> Message-ID: <545A20EB.4020108@oracle.com> Please use the correct subject for future approval requests. regards, Sean. On 05/11/14 13:05, Rob McKenna wrote: > Approved. > > -Rob > > On 05/11/14 12:14, mikhail cherkasov wrote: >> Hi there. >> >> It's just kindly reminder about this request for backport approval. >> >> Thanks, >> Mikhail. >> >> On 10/30/2014 1:56 PM, mikhail cherkasov wrote: >>> Hi there, >>> >>> I would like to backport this fix from jdk9: >>> >>> bug: https://bugs.openjdk.java.net/browse/JDK-8062021 >>> review thread: >>> http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008617.html >>> jdk9 changeset: >>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/2f5c1e181647 >>> >>> Thanks, >>> Mikhail. >> > From marcus.lagergren at oracle.com Wed Nov 5 14:13:39 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 5 Nov 2014 15:13:39 +0100 Subject: Please approve backport request to 8u40 for - JDK-8057825 In-Reply-To: <545A0E8E.3010708@oracle.com> References: <2E72B7E6-CF6A-4383-A63E-EAE579CD68AB@oracle.com> <545A0E8E.3010708@oracle.com> Message-ID: <74E7DBBC-F085-4225-9BDB-19532EB6DDE7@oracle.com> Thank you Se?n. It applies cleanly post modular unshifting. Apologies about the subject line. I was attacked from behind (I think it was meant to be a hug) by my estranged colleague Staffan Friberg and accidentally pressed the send button too early. I will make sure he is disciplined. ;-) I well spend the rest of the day back porting and making sure that builds work /tests run and so on. Regards Marcus > On 05 Nov 2014, at 12:48, Se?n Coffey wrote: > > Assuming this applies cleanly post modular unshuffling. For the future, can you also use a complete subject line as per template request [1]. > > Approved. > > regards, > Sean. > > [1] http://openjdk.java.net/projects/jdk8u/approval-template.html > > On 05/11/14 11:43, Marcus Lagergren wrote: >> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003806.html >> Bug: https://bugs.openjdk.java.net/browse/JDK-8057825 >> Webrev at: http://cr.openjdk.java.net/~lagergren/8057825/ >> /M >> > From staffan.larsen at oracle.com Wed Nov 5 16:05:22 2014 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Wed, 5 Nov 2014 17:05:22 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <37BA0417-85CC-4FE2-898E-2041BA6F50A3@oracle.com> Vote: yes. > On 5 nov 2014, at 12:19, Bengt Rutisson wrote: > > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From markus.gronlund at oracle.com Wed Nov 5 16:41:18 2014 From: markus.gronlund at oracle.com (=?iso-8859-1?B?TWFya3VzIEdy9m5sdW5k?=) Date: Wed, 5 Nov 2014 08:41:18 -0800 (PST) Subject: [8u40] Request for approval: 8056049: getProcessCpuLoad() stops working in one process when a different process exits Message-ID: <566551f3-a0d5-47aa-88c6-61192b03001e@default> Greetings, ? This is a request for approval to backport: ? Bug: https://bugs.openjdk.java.net/browse/JDK-8056049 ? JDK9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/9cfe1aa7a630 ? Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013013.html ? JDK9 code passed HS-RT (Runtime/SVC) nightly testing. ? Change applies directly to 8u40. ? Thanks in advance Markus From vladimir.x.ivanov at oracle.com Wed Nov 5 15:42:17 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Wed, 05 Nov 2014 19:42:17 +0400 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545A4559.1070607@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 11/5/14, 3:19 PM, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has > 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From sean.coffey at oracle.com Wed Nov 5 16:52:16 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 05 Nov 2014 16:52:16 +0000 Subject: [8u40] Request for approval: 8056049: getProcessCpuLoad() stops working in one process when a different process exits In-Reply-To: <566551f3-a0d5-47aa-88c6-61192b03001e@default> References: <566551f3-a0d5-47aa-88c6-61192b03001e@default> Message-ID: <545A55C0.2070906@oracle.com> Markus, Like the JDK 9 fix, it's best that this goes into the jdk8u hotspot team forest : http://hg.openjdk.java.net/jdk8u/hs-dev/ No push approval necessary for that. Alejandro will handle approvals at bulk integration time. regards, Sean. On 05/11/14 16:41, Markus Gr?nlund wrote: > Greetings, > > > > This is a request for approval to backport: > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8056049 > > > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/9cfe1aa7a630 > > > > Review thread: > > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013013.html > > > > JDK9 code passed HS-RT (Runtime/SVC) nightly testing. > > > > Change applies directly to 8u40. > > > > Thanks in advance > > Markus From volker.simonis at gmail.com Wed Nov 5 18:17:26 2014 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 5 Nov 2014 19:17:26 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: Vote: yes On Wed, Nov 5, 2014 at 12:19 PM, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has 12 > changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this nomination. > Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From jesper.wilhelmsson at oracle.com Wed Nov 5 18:48:20 2014 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Wed, 05 Nov 2014 19:48:20 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545A70F4.8080009@oracle.com> Vote: yes /Jesper Bengt Rutisson skrev 5/11/14 12:19: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has 12 > changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this nomination. > Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From John.Coomes at oracle.com Wed Nov 5 21:27:57 2014 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 5 Nov 2014 13:27:57 -0800 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <21594.38493.358679.397225@mykonos.us.oracle.com> Vote: yes -John From jon.masamitsu at oracle.com Wed Nov 5 21:58:02 2014 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Wed, 05 Nov 2014 13:58:02 -0800 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545A9D6A.70805@oracle.com> vote: yes On 11/5/2014 3:19 AM, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has > 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From Roger.Riggs at Oracle.com Wed Nov 5 22:51:23 2014 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Wed, 05 Nov 2014 17:51:23 -0500 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545AA9EB.7040807@Oracle.com> Vote: Yes On 11/5/14 6:19 AM, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. From brent.christian at oracle.com Thu Nov 6 00:19:14 2014 From: brent.christian at oracle.com (Brent Christian) Date: Wed, 05 Nov 2014 16:19:14 -0800 Subject: [8u40] Backport request: 8034032: Check src/macosx/native/java/util/prefs/MacOSXPreferencesFile.m for JNI pending issues Message-ID: <545ABE82.6050401@oracle.com> Hi, Please approve this backport from 9. The patch applies cleanly (after accounting for the src path change in JDK-8034043). Bug: https://bugs.openjdk.java.net/browse/JDK-8034032 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0ae94f39e0eb Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028098.html Thanks, -Brent From alejandro.murillo at oracle.com Thu Nov 6 01:01:09 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Wed, 05 Nov 2014 18:01:09 -0700 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545AC855.9020607@oracle.com> vote: yes On 11/5/2014 4:19 AM, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > -- Alejandro From sean.coffey at oracle.com Thu Nov 6 10:56:14 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 06 Nov 2014 10:56:14 +0000 Subject: [8u40] Backport request: 8034032: Check src/macosx/native/java/util/prefs/MacOSXPreferencesFile.m for JNI pending issues In-Reply-To: <545ABE82.6050401@oracle.com> References: <545ABE82.6050401@oracle.com> Message-ID: <545B53CE.6030900@oracle.com> Missed this one - please add "approval" to the subject line for future requests. You need to add a noreg- label to the bug record. Approved. regards, Sean. On 06/11/2014 00:19, Brent Christian wrote: > Hi, > > Please approve this backport from 9. The patch applies cleanly (after > accounting for the src path change in JDK-8034043). > > Bug: https://bugs.openjdk.java.net/browse/JDK-8034032 > > Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0ae94f39e0eb > > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028098.html > > Thanks, > -Brent From erik.helin at oracle.com Thu Nov 6 13:24:02 2014 From: erik.helin at oracle.com (Erik Helin) Date: Thu, 06 Nov 2014 14:24:02 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545B7672.9080309@oracle.com> Vote: yes Erik On 2014-11-05 12:19, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has > 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From marcus.lagergren at oracle.com Thu Nov 6 13:38:34 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 6 Nov 2014 14:38:34 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <53B7E88D-2FEB-4405-99DB-24BE10C8B7AD@oracle.com> Vote: yes /M > On 05 Nov 2014, at 12:19, Bengt Rutisson wrote: > > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From mikael.gerdin at oracle.com Thu Nov 6 13:57:29 2014 From: mikael.gerdin at oracle.com (Mikael Gerdin) Date: Thu, 06 Nov 2014 14:57:29 +0100 Subject: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <545B7E49.8020902@oracle.com> Vote: yes On 2014-11-05 12:19, Bengt Rutisson wrote: > > I hereby nominate Stefan Johansson (sjohanss) to JDK8u Committer. > > Stefan is a member of the HotSpot GC team and a JDK9 Committer. He has > 12 changesets in JDK 8 [1]. > > Votes are due by 1300 CET November 19, 2014. > > Only current JDK8u Committers [2] are eligible to vote on this > nomination. Votes must be cast in the open by replying > to this mailing list. > > For Lazy Consensus voting instructions, see [3]. > > Thanks, > Albert > > [1] > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=sjohanss > http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/log?rev=stefan.johansson%40oracle.com > > > [2] http://openjdk.java.net/census#jdk8u > [3] http://openjdk.java.net/projects#committer-vote From vladimir.x.ivanov at oracle.com Thu Nov 6 13:10:10 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 06 Nov 2014 17:10:10 +0400 Subject: [8u40] Request for approval: 8060483: NPE with explicitCastArguments unboxing null Message-ID: <545B7332.8090601@oracle.com> Please, approve backport of the following fix into 8u40: 8060483: NPE with explicitCastArguments unboxing null https://jbs.oracle.com/bugs/browse/JDK-8060483 http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/52a0226d6a84 http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029154.html The changes apply cleanly. Thanks! Best regards, Vladimir Ivanov From sean.coffey at oracle.com Thu Nov 6 14:30:58 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 06 Nov 2014 14:30:58 +0000 Subject: [8u40] Request for approval: 8060483: NPE with explicitCastArguments unboxing null In-Reply-To: <545B7332.8090601@oracle.com> References: <545B7332.8090601@oracle.com> Message-ID: <545B8622.8000206@oracle.com> Approved. regards, Sean. On 06/11/2014 13:10, Vladimir Ivanov wrote: > Please, approve backport of the following fix into 8u40: > > 8060483: NPE with explicitCastArguments unboxing null > https://jbs.oracle.com/bugs/browse/JDK-8060483 > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/52a0226d6a84 > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029154.html > > > The changes apply cleanly. > > Thanks! > > Best regards, > Vladimir Ivanov From mattias.tobiasson at oracle.com Thu Nov 6 09:58:30 2014 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Thu, 6 Nov 2014 01:58:30 -0800 (PST) Subject: [8u40] Backport request: 8061960: TestDaemonThread.java regularly fails due to exceeded timeout Message-ID: <95b22455-8ff6-408d-835f-e13d669ce0cf@default> Hi, Please approve this testbug backport from 9. The patch applies cleanly. The change is just to move /timeout parameter on the command line to the correct position. Old version: @run main TestDaemonThreadLauncher /timeout=240 New version: @run main/timeout=240 TestDaemonThreadLauncher Bug: https://bugs.openjdk.java.net/browse/JDK-8061960 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7d5f40c8d20e Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028098.html Thanks, Mattias From vladimir.x.ivanov at oracle.com Thu Nov 6 14:34:23 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 06 Nov 2014 18:34:23 +0400 Subject: [8u40] Request for approval: 8060483: NPE with explicitCastArguments unboxing null In-Reply-To: <545B8622.8000206@oracle.com> References: <545B7332.8090601@oracle.com> <545B8622.8000206@oracle.com> Message-ID: <545B86EF.2000808@oracle.com> Sean, thanks! Best regards, Vladimir Ivanov On 11/6/14, 6:30 PM, Se?n Coffey wrote: > Approved. > > regards, > Sean. > > On 06/11/2014 13:10, Vladimir Ivanov wrote: >> Please, approve backport of the following fix into 8u40: >> >> 8060483: NPE with explicitCastArguments unboxing null >> https://jbs.oracle.com/bugs/browse/JDK-8060483 >> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/52a0226d6a84 >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-October/029154.html >> >> >> The changes apply cleanly. >> >> Thanks! >> >> Best regards, >> Vladimir Ivanov > From hannes.wallnoefer at oracle.com Thu Nov 6 15:42:56 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 06 Nov 2014 16:42:56 +0100 Subject: [8u40] Request for approval: JDK-8062386: Different versions of nashorn use same code cache directory Message-ID: <545B9700.5080201@oracle.com> Please approve backport of JDK-8062386 to 8u40. The patch applies cleanly to 8u40 after fixing path names. Bug: https://bugs.openjdk.java.net/browse/JDK-8062386 Webrev: http://cr.openjdk.java.net/~hannesw/8062386/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003810.html Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/3fa7d5c6ed92 Thanks, Hannes From rob.mckenna at oracle.com Thu Nov 6 15:46:10 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 06 Nov 2014 15:46:10 +0000 Subject: [8u40] Request for approval: JDK-8062386: Different versions of nashorn use same code cache directory In-Reply-To: <545B9700.5080201@oracle.com> References: <545B9700.5080201@oracle.com> Message-ID: <545B97C2.3030106@oracle.com> Approved. -Rob On 06/11/14 15:42, Hannes Wallnoefer wrote: > Please approve backport of JDK-8062386 to 8u40. > > The patch applies cleanly to 8u40 after fixing path names. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062386 > Webrev: http://cr.openjdk.java.net/~hannesw/8062386/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003810.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/3fa7d5c6ed92 > > Thanks, > Hannes > From sean.coffey at oracle.com Thu Nov 6 15:48:46 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 06 Nov 2014 15:48:46 +0000 Subject: [8u40] Backport request: 8061960: TestDaemonThread.java regularly fails due to exceeded timeout In-Reply-To: <95b22455-8ff6-408d-835f-e13d669ce0cf@default> References: <95b22455-8ff6-408d-835f-e13d669ce0cf@default> Message-ID: <545B985E.4040704@oracle.com> Approved. regards, Sean. On 06/11/2014 09:58, Mattias Tobiasson wrote: > Hi, > Please approve this testbug backport from 9. The patch applies cleanly. > The change is just to move /timeout parameter on the command line to > the correct position. > > Old version: @run main TestDaemonThreadLauncher /timeout=240 > New version: @run main/timeout=240 TestDaemonThreadLauncher > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8061960 > > Changeset: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7d5f40c8d20e > > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028098.html > > Thanks, > Mattias From hannes.wallnoefer at oracle.com Thu Nov 6 15:51:25 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 06 Nov 2014 16:51:25 +0100 Subject: [8u40] Request for approval: JDK-8062624: java.lang.String methods not available on concatenated strings Message-ID: <545B98FD.7050801@oracle.com> Please approve backport of JDK-8062624 to 8u40. The patch applies cleanly to 8u40 after fixing path names. Bug: https://bugs.openjdk.java.net/browse/JDK-8062624 Webrev: http://cr.openjdk.java.net/~hannesw/8062624/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003813.html Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a22f9ba69baa Thanks, Hannes From rob.mckenna at oracle.com Thu Nov 6 15:54:54 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 06 Nov 2014 15:54:54 +0000 Subject: [8u40] Request for approval: JDK-8062624: java.lang.String methods not available on concatenated strings In-Reply-To: <545B98FD.7050801@oracle.com> References: <545B98FD.7050801@oracle.com> Message-ID: <545B99CE.60904@oracle.com> Approved. -Rob On 06/11/14 15:51, Hannes Wallnoefer wrote: > Please approve backport of JDK-8062624 to 8u40. > > The patch applies cleanly to 8u40 after fixing path names. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062624 > Webrev: http://cr.openjdk.java.net/~hannesw/8062624/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003813.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a22f9ba69baa > > Thanks, > Hannes From attila.szegedi at oracle.com Thu Nov 6 16:13:15 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 6 Nov 2014 17:13:15 +0100 Subject: [8u40] Request for Approval: 8062308: Incorrect constant linkage with multiple Globals in a Context Message-ID: <6ED048DA-A739-4696-9558-57376C16591E@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8062308 jdk9 webrev: http://cr.openjdk.java.net/~attila/8062308/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003819.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Thu Nov 6 16:14:23 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 06 Nov 2014 16:14:23 +0000 Subject: [8u40] Request for Approval: 8062308: Incorrect constant linkage with multiple Globals in a Context In-Reply-To: <6ED048DA-A739-4696-9558-57376C16591E@oracle.com> References: <6ED048DA-A739-4696-9558-57376C16591E@oracle.com> Message-ID: <545B9E5F.4090205@oracle.com> Approved. -Rob On 06/11/14 16:13, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062308 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8062308/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003819.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From ivan.gerasimov at oracle.com Thu Nov 6 21:44:29 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 00:44:29 +0300 Subject: [8u40] Request for Approval: 8054029: (fc) FileChannel.size() returns 0 for block devices on Linux Message-ID: <545BEBBD.6090903@oracle.com> Hello! Would you please approve the backport of this edge-case fix? The fix applies cleanly modulo unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8054029 Jdk9 Change: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/f8b718af3f3c Review: http://mail.openjdk.java.net/pipermail/nio-dev/2014-September/002738.html Sincerely yours, Ivan From ivan.gerasimov at oracle.com Thu Nov 6 22:06:23 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 01:06:23 +0300 Subject: [8u40] Request for Approval: 8054029: BitSet.toString() can throw IndexOutOfBoundsException Message-ID: <545BF0DF.2020208@oracle.com> Hello! Would you please approve this unaltered fix. The fix applies cleanly without shuffling, as it was done before the repository restructure. Bug: https://bugs.openjdk.java.net/browse/JDK-8040806 Jdk 9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3bbb836bdf90 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026747.html Sincerely yours, Ivan From rob.mckenna at oracle.com Thu Nov 6 22:07:03 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 06 Nov 2014 22:07:03 +0000 Subject: [8u40] Request for Approval: 8054029: (fc) FileChannel.size() returns 0 for block devices on Linux In-Reply-To: <545BEBBD.6090903@oracle.com> References: <545BEBBD.6090903@oracle.com> Message-ID: <545BF107.6090107@oracle.com> Approved. -Rob On 06/11/14 21:44, Ivan Gerasimov wrote: > Hello! > > Would you please approve the backport of this edge-case fix? > The fix applies cleanly modulo unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8054029 > Jdk9 Change: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/f8b718af3f3c > Review: > http://mail.openjdk.java.net/pipermail/nio-dev/2014-September/002738.html > > Sincerely yours, > Ivan From rob.mckenna at oracle.com Thu Nov 6 22:07:34 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 06 Nov 2014 22:07:34 +0000 Subject: [8u40] Request for Approval: 8054029: BitSet.toString() can throw IndexOutOfBoundsException In-Reply-To: <545BF0DF.2020208@oracle.com> References: <545BF0DF.2020208@oracle.com> Message-ID: <545BF126.8040205@oracle.com> Approved. -Rob On 06/11/14 22:06, Ivan Gerasimov wrote: > Hello! > > Would you please approve this unaltered fix. > The fix applies cleanly without shuffling, as it was done before the > repository restructure. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8040806 > Jdk 9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3bbb836bdf90 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026747.html > > Sincerely yours, > Ivan From ivan.gerasimov at oracle.com Thu Nov 6 22:24:04 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 01:24:04 +0300 Subject: [8u40] Request for Approval: 8011537, 8042470, 8042816 Message-ID: <545BF504.7060702@oracle.com> Hello! Would you please approve these three WatchService related fixes? The fixes apply cleanly, when applied as in the order below. Title: (fs) Path.register(..) clears interrupt status of thread with no InterruptedException Bug: https://bugs.openjdk.java.net/browse/JDK-8011537 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/99e0f1f9c401 Review: http://mail.openjdk.java.net/pipermail/nio-dev/2014-May/002639.html Title: (fs) Path.register doesn't throw IllegalArgumentException if multiple OVERFLOW events are specified Bug: https://bugs.openjdk.java.net/browse/JDK-8042470 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/43f769f86f47 Review: http://mail.openjdk.java.net/pipermail/nio-dev/2014-May/002643.html Title: (fs) Path.register doesn't throw IllegalArgumentException if multiple OVERFLOW events are specified, part 2 Bug: https://bugs.openjdk.java.net/browse/JDK-8042816 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0836900e58a3 Review: http://mail.openjdk.java.net/pipermail/nio-dev/2014-May/002649.html Sincerely yours, Ivan From ivan.gerasimov at oracle.com Thu Nov 6 22:30:48 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 01:30:48 +0300 Subject: [8u40] Request for Approval: 8043476: java/util/BitSet/BSMethods.java failed with: java.lang.OutOfMemoryError: Java heap space Message-ID: <545BF698.9040501@oracle.com> Hello! In addition to the backport of JDK-8054029 (Thanks Rob!), we would need to also backport this fix to avoid test problems. Would you please approve it? The fix applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8043476 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c33989af5014 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026992.html If approved, the fixes for 8054029 and 8043476 will be pushed at the same time. Sincerely yours, Ivan From ivan.gerasimov at oracle.com Thu Nov 6 22:44:24 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 01:44:24 +0300 Subject: [8u40] Request for Approval: 6853696, 8038333, 8038982 Message-ID: <545BF9C8.80607@oracle.com> Hello! Would you please approve backport of these three fixes? The first one fixes an issue with ReferenceQueue.remove returning early, and the next two make the regression test created for the first fix more robust. The fixes apply cleanly when applied in that order. Title: (ref) ReferenceQueue.remove(timeout) may return null even if timeout has not expired Bug: https://bugs.openjdk.java.net/browse/JDK-6853696 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0731952efb10 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-February/025279.html Title: TEST_BUG: java/lang/ref/EarlyTimeout.java fails with a non-adequate message Bug: https://bugs.openjdk.java.net/browse/JDK-8038333 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e419e57a2426 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-March/026060.html Title: java/lang/ref/EarlyTimeout.java: elapsed time 981 is less than timeout 1000 Bug: https://bugs.openjdk.java.net/browse/JDK-8038982 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/a311c31fc622 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026422.html Sincerely yours, Ivan From ivan.gerasimov at oracle.com Thu Nov 6 22:49:52 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 01:49:52 +0300 Subject: [8u40] Request for Approval: 7011804: SequenceInputStream with lots of empty substreams can cause StackOverflowError Message-ID: <545BFB10.4090307@oracle.com> Hello! Would you please approve the backport of this fix? The fix applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-7011804 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e435231f4d75 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-March/025484.html Sincerely yours, Ivan From philip.race at oracle.com Thu Nov 6 22:59:02 2014 From: philip.race at oracle.com (Phil Race) Date: Thu, 06 Nov 2014 14:59:02 -0800 Subject: [8u40] Request for approval: 8061392: PrinterJob NPE when drawing translucent image with null user clip In-Reply-To: <545BFCC2.1080507@oracle.com> References: <545BFCC2.1080507@oracle.com> Message-ID: <545BFD36.4030501@oracle.com> Please approval the identical backport of the fix for Bug: https://bugs.openjdk.java.net/browse/JDK-8061392 JDK9 review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004903.html JDK9 webrev : http://cr.openjdk.java.net/~prr/8061392 Identical JDK8u fix : http://cr.openjdk.java.net/~prr/8061392.8u/ -phil. From ivan.gerasimov at oracle.com Thu Nov 6 23:04:02 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 07 Nov 2014 02:04:02 +0300 Subject: [8u40] Request for Approval: 6904367: (coll) IdentityHashMap is resized before exceeding the expected maximum size Message-ID: <545BFE62.5080802@oracle.com> Hello! Would you please approve this backport? The patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-6904367 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8ed989e71f1b Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027540.html Sincerely yours, Ivan From attila.szegedi at oracle.com Fri Nov 7 08:31:59 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 7 Nov 2014 09:31:59 +0100 Subject: [8u40] Request for Approval: 8059443: NPE when unboxing return values Message-ID: <54806ACB-6C04-428E-8300-26D7EA0BBEF1@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8059443 jdk9 webrev: http://cr.openjdk.java.net/~attila/8059443/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003790.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From david.buck at oracle.com Fri Nov 7 08:36:55 2014 From: david.buck at oracle.com (david buck) Date: Fri, 07 Nov 2014 17:36:55 +0900 Subject: [8u40] request for approval: 8062608: BCEL corrupts debug data of methods that use generics Message-ID: <545C84A7.6050000@oracle.com> Hi! Please approve this backport from jdk9 to jdk8u-dev JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/fe179de493b1 bug url: https://bugs.openjdk.java.net/browse/JDK-8062608 Changes apply cleanly after modularization (de)shuffle. Builds and passes testcase from the bug report. Cheers, -Buck From sean.coffey at oracle.com Fri Nov 7 08:49:45 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 08:49:45 +0000 Subject: [8u40] Request for Approval: 8011537, 8042470, 8042816 In-Reply-To: <545BF504.7060702@oracle.com> References: <545BF504.7060702@oracle.com> Message-ID: <545C87A9.3070504@oracle.com> Approved. regards, Sean. On 06/11/2014 22:24, Ivan Gerasimov wrote: > Hello! > > Would you please approve these three WatchService related fixes? > The fixes apply cleanly, when applied as in the order below. > > Title: (fs) Path.register(..) clears interrupt status of thread with > no InterruptedException > Bug: https://bugs.openjdk.java.net/browse/JDK-8011537 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/99e0f1f9c401 > Review: > http://mail.openjdk.java.net/pipermail/nio-dev/2014-May/002639.html > > Title: (fs) Path.register doesn't throw IllegalArgumentException if > multiple OVERFLOW events are specified > Bug: https://bugs.openjdk.java.net/browse/JDK-8042470 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/raw-rev/43f769f86f47 > Review: > http://mail.openjdk.java.net/pipermail/nio-dev/2014-May/002643.html > > Title: (fs) Path.register doesn't throw IllegalArgumentException if > multiple OVERFLOW events are specified, part 2 > Bug: https://bugs.openjdk.java.net/browse/JDK-8042816 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0836900e58a3 > Review: > http://mail.openjdk.java.net/pipermail/nio-dev/2014-May/002649.html > > Sincerely yours, > Ivan From sean.coffey at oracle.com Fri Nov 7 08:50:18 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 08:50:18 +0000 Subject: [8u40] Request for Approval: 8043476: java/util/BitSet/BSMethods.java failed with: java.lang.OutOfMemoryError: Java heap space In-Reply-To: <545BF698.9040501@oracle.com> References: <545BF698.9040501@oracle.com> Message-ID: <545C87CA.7090001@oracle.com> Approved. regards, Sean. On 06/11/2014 22:30, Ivan Gerasimov wrote: > Hello! > > In addition to the backport of JDK-8054029 (Thanks Rob!), we would > need to also backport this fix to avoid test problems. > Would you please approve it? > The fix applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8043476 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c33989af5014 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026992.html > > If approved, the fixes for 8054029 and 8043476 will be pushed at the > same time. > > Sincerely yours, > Ivan From sean.coffey at oracle.com Fri Nov 7 08:52:27 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 08:52:27 +0000 Subject: [8u40] Request for Approval: 6853696, 8038333, 8038982 In-Reply-To: <545BF9C8.80607@oracle.com> References: <545BF9C8.80607@oracle.com> Message-ID: <545C884B.9000003@oracle.com> Approved. regards, Sean. On 06/11/2014 22:44, Ivan Gerasimov wrote: > Hello! > > Would you please approve backport of these three fixes? > The first one fixes an issue with ReferenceQueue.remove returning > early, and the next two make the regression test created for the first > fix more robust. > The fixes apply cleanly when applied in that order. > > Title: (ref) ReferenceQueue.remove(timeout) may return null even if > timeout has not expired > Bug: https://bugs.openjdk.java.net/browse/JDK-6853696 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/0731952efb10 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-February/025279.html > > Title: TEST_BUG: java/lang/ref/EarlyTimeout.java fails with a > non-adequate message > Bug: https://bugs.openjdk.java.net/browse/JDK-8038333 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e419e57a2426 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-March/026060.html > > Title: java/lang/ref/EarlyTimeout.java: elapsed time 981 is less than > timeout 1000 > Bug: https://bugs.openjdk.java.net/browse/JDK-8038982 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/a311c31fc622 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-April/026422.html > > Sincerely yours, > Ivan From sean.coffey at oracle.com Fri Nov 7 08:54:13 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 08:54:13 +0000 Subject: [8u40] Request for Approval: 7011804: SequenceInputStream with lots of empty substreams can cause StackOverflowError In-Reply-To: <545BFB10.4090307@oracle.com> References: <545BFB10.4090307@oracle.com> Message-ID: <545C88B5.5090701@oracle.com> Approved. regards, Sean. On 06/11/2014 22:49, Ivan Gerasimov wrote: > Hello! > > Would you please approve the backport of this fix? > The fix applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-7011804 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e435231f4d75 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-March/025484.html > > Sincerely yours, > Ivan From sean.coffey at oracle.com Fri Nov 7 08:54:46 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 07 Nov 2014 08:54:46 +0000 Subject: [8u40] Request for approval: 8061392: PrinterJob NPE when drawing translucent image with null user clip In-Reply-To: <545BFD36.4030501@oracle.com> References: <545BFCC2.1080507@oracle.com> <545BFD36.4030501@oracle.com> Message-ID: <545C88D6.9060407@oracle.com> Approved. regards, Sean. On 06/11/2014 22:59, Phil Race wrote: > > Please approval the identical backport of the fix for > Bug: https://bugs.openjdk.java.net/browse/JDK-8061392 > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004903.html > JDK9 webrev : http://cr.openjdk.java.net/~prr/8061392 > Identical JDK8u fix : http://cr.openjdk.java.net/~prr/8061392.8u/ > > -phil. > > > > From sean.coffey at oracle.com Fri Nov 7 08:57:32 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 08:57:32 +0000 Subject: [8u40] Request for Approval: 6904367: (coll) IdentityHashMap is resized before exceeding the expected maximum size In-Reply-To: <545BFE62.5080802@oracle.com> References: <545BFE62.5080802@oracle.com> Message-ID: <545C897C.2060507@oracle.com> Approved. regards, Sean. On 06/11/2014 23:04, Ivan Gerasimov wrote: > Hello! > > Would you please approve this backport? > The patch applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-6904367 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8ed989e71f1b > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-July/027540.html > > Sincerely yours, > Ivan From sean.coffey at oracle.com Fri Nov 7 08:58:17 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 07 Nov 2014 08:58:17 +0000 Subject: [8u40] Request for Approval: 8059443: NPE when unboxing return values In-Reply-To: <54806ACB-6C04-428E-8300-26D7EA0BBEF1@oracle.com> References: <54806ACB-6C04-428E-8300-26D7EA0BBEF1@oracle.com> Message-ID: <545C89A9.9020706@oracle.com> Approved. regards, Sean. On 07/11/2014 08:31, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059443 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8059443/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003790.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From sean.coffey at oracle.com Fri Nov 7 09:01:01 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 09:01:01 +0000 Subject: [8u40] request for approval: 8062608: BCEL corrupts debug data of methods that use generics In-Reply-To: <545C84A7.6050000@oracle.com> References: <545C84A7.6050000@oracle.com> Message-ID: <545C8A4D.1020603@oracle.com> review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029540.html Approved. regards, Sean. On 07/11/2014 08:36, david buck wrote: > Hi! > > Please approve this backport from jdk9 to jdk8u-dev > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/fe179de493b1 > bug url: https://bugs.openjdk.java.net/browse/JDK-8062608 > > Changes apply cleanly after modularization (de)shuffle. Builds and > passes testcase from the bug report. > > Cheers, > -Buck From pavel.rappo at oracle.com Fri Nov 7 15:29:51 2014 From: pavel.rappo at oracle.com (Pavel Rappo) Date: Fri, 7 Nov 2014 15:29:51 +0000 Subject: Request for approval JDK-8064350: com/sun/jndi/ldap/LdapTimeoutTest.java fails with exit_code == 0 Message-ID: <11F9651D-F73C-4573-9741-78A3ECFE94E3@oracle.com> Hi, please approve this backport of https://bugs.openjdk.java.net/browse/JDK-8064350 original jdk9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029551.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/15cdcf4a5ce7 Applies cleanly. Thanks, -Pavel From sean.coffey at oracle.com Fri Nov 7 15:35:28 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 07 Nov 2014 15:35:28 +0000 Subject: Request for approval JDK-8059311 / JDK-8064350: com/sun/jndi/ldap/LdapTimeoutTest.java fails with exit_code == 0 In-Reply-To: <11F9651D-F73C-4573-9741-78A3ECFE94E3@oracle.com> References: <11F9651D-F73C-4573-9741-78A3ECFE94E3@oracle.com> Message-ID: <545CE6C0.3000203@oracle.com> Approved. regards, Sean. On 07/11/14 15:29, Pavel Rappo wrote: > Hi, > > please approve this backport of https://bugs.openjdk.java.net/browse/JDK-8064350 > > original jdk9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029551.html > jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/15cdcf4a5ce7 > > Applies cleanly. > > Thanks, > -Pavel From alejandro.murillo at oracle.com Fri Nov 7 21:04:57 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 07 Nov 2014 14:04:57 -0700 Subject: [8u40] Request for approval for bulk integration of hs25.40-b18 Message-ID: <545D33F9.3030901@oracle.com> Requesting approval to integrate hs25.40-b18 into jdk8u40-b14. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b18-jdk8u40-b14.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8046268: compiler/whitebox/ tests fail : must be osr_compiled 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse 8057043: Type annotations not retained during class redefine / retransform 8058715: stability issues when being launched as an embedded JVM via JNI 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads 8059780: SPECjvm2008-MPEG performance regressions on x64 platforms 8060454: [TESTBUG] Whitebox tests fail with -XX:CompileThreshold=100 8061486: [TESTBUG] compiler/whitebox/ tests fail : must be osr_compiled (reappeared in nightlies) 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method 8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java fails with "must not be in queue" 8062169: Multiple OSR compilations issued for same bci 8062589: new hotspot build - hs25.40-b18 -- Alejandro From philip.race at oracle.com Fri Nov 7 21:47:13 2014 From: philip.race at oracle.com (Phil Race) Date: Fri, 07 Nov 2014 13:47:13 -0800 Subject: [8u40]: Request for approval : 8039444: Swing applications not being displayed properly In-Reply-To: <545D3D55.1060400@oracle.com> References: <545D3D55.1060400@oracle.com> Message-ID: <545D3DE1.9050304@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8039444 Webrev: http://cr.openjdk.java.net/~prr/8039444/ Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-November/004939.html -phil. From sean.coffey at oracle.com Fri Nov 7 23:42:03 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 07 Nov 2014 23:42:03 +0000 Subject: [8u40] Request for approval for bulk integration of hs25.40-b18 In-Reply-To: <545D33F9.3030901@oracle.com> References: <545D33F9.3030901@oracle.com> Message-ID: <545D58CB.8020407@oracle.com> Approved pending positive PIT results. regards, Sean. On 07/11/2014 21:04, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.40-b18 into jdk8u40-b14. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b18-jdk8u40-b14.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8046268: compiler/whitebox/ tests fail : must be osr_compiled > 8056240: Investigate increased GC remark time after class unloading > changes in CRM Fuse > 8057043: Type annotations not retained during class redefine / > retransform > 8058715: stability issues when being launched as an embedded JVM via JNI > 8059216: Make PrintGCApplicationStoppedTime print information about > stopping threads > 8059780: SPECjvm2008-MPEG performance regressions on x64 platforms > 8060454: [TESTBUG] Whitebox tests fail with -XX:CompileThreshold=100 > 8061486: [TESTBUG] compiler/whitebox/ tests fail : must be > osr_compiled (reappeared in nightlies) > 8061651: Interface to the Lookup Index Cache to improve URLClassPath > search time > 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR > versions of method > 8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java > fails with "must not be in queue" > 8062169: Multiple OSR compilations issued for same bci > 8062589: new hotspot build - hs25.40-b18 > From sean.coffey at oracle.com Fri Nov 7 23:46:55 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 07 Nov 2014 23:46:55 +0000 Subject: [8u40]: Request for approval : 8039444: Swing applications not being displayed properly In-Reply-To: <545D3DE1.9050304@oracle.com> References: <545D3D55.1060400@oracle.com> <545D3DE1.9050304@oracle.com> Message-ID: <545D59EF.4030308@oracle.com> Phil, This hasn't been resolved in JDK 9 yet Phil. As per comments in your review thread, are you going to add a 9-na label or maybe close out the 9 record ? Best practice might be to push the same fix to JDK 9 in case of future regression (even if you are going to iterate over the fix in that release again) Bug report is also lacking a noreg- label. Approved. regards, Sean. On 07/11/2014 21:47, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8039444 > Webrev: http://cr.openjdk.java.net/~prr/8039444/ > Review: > http://mail.openjdk.java.net/pipermail/2d-dev/2014-November/004939.html > > -phil. > > From philip.race at oracle.com Fri Nov 7 23:50:51 2014 From: philip.race at oracle.com (Phil Race) Date: Fri, 07 Nov 2014 15:50:51 -0800 Subject: [8u40]: Request for approval : 8039444: Swing applications not being displayed properly In-Reply-To: <545D59EF.4030308@oracle.com> References: <545D3D55.1060400@oracle.com> <545D3DE1.9050304@oracle.com> <545D59EF.4030308@oracle.com> Message-ID: <545D5ADB.1020902@oracle.com> You are going over what I already considered. This is a special case. If I turned it off in 9 no one would see/report any issues so we would not learn anything. It'll be resolved by feature freeze or some milestone like RDP1 .. but what to do in 9 is TBD. That doesn't mean we should wait as 8ux has to be resolved. I deliberately opened up an 8u40 backport so the issue will still be on the 9 radar as that will remain open and there are the other bug reports too. -phil. On 11/7/14 3:46 PM, Se?n Coffey wrote: > Phil, > > This hasn't been resolved in JDK 9 yet Phil. As per comments in your > review thread, are you going to add a 9-na label or maybe close out > the 9 record ? Best practice might be to push the same fix to JDK 9 in > case of future regression (even if you are going to iterate over the > fix in that release again) > > Bug report is also lacking a noreg- label. > > Approved. > > regards, > Sean. > > On 07/11/2014 21:47, Phil Race wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8039444 >> Webrev: http://cr.openjdk.java.net/~prr/8039444/ >> Review: >> http://mail.openjdk.java.net/pipermail/2d-dev/2014-November/004939.html >> >> -phil. >> >> > From anthony.scarpino at oracle.com Sat Nov 8 03:28:38 2014 From: anthony.scarpino at oracle.com (Anthony Scarpino) Date: Fri, 07 Nov 2014 19:28:38 -0800 Subject: [8u40] Request for approval: 8063700 -Xcheck:jni changes cause many JCK failures in api/javax_crypto tests with SunPKCS11 Message-ID: <545D8DE6.5070701@oracle.com> Hi, I'd like to get approval to backport this bug. It is the same code change that went into 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8063700 Webrev: http://cr.openjdk.java.net/~ascarpino/8063700/webrev/ Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-November/011392.html thanks Tony From sean.coffey at oracle.com Sat Nov 8 12:16:01 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Sat, 08 Nov 2014 12:16:01 +0000 Subject: [8u40] Request for approval: 8063700 -Xcheck:jni changes cause many JCK failures in api/javax_crypto tests with SunPKCS11 In-Reply-To: <545D8DE6.5070701@oracle.com> References: <545D8DE6.5070701@oracle.com> Message-ID: <545E0981.7010700@oracle.com> Approved. regards, Sean. On 08/11/2014 03:28, Anthony Scarpino wrote: > Hi, > > I'd like to get approval to backport this bug. It is the same code > change that went into 9. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8063700 > > Webrev: > http://cr.openjdk.java.net/~ascarpino/8063700/webrev/ > > Review: > http://mail.openjdk.java.net/pipermail/security-dev/2014-November/011392.html > > > thanks > > Tony From mattias.tobiasson at oracle.com Mon Nov 10 12:38:31 2014 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Mon, 10 Nov 2014 04:38:31 -0800 (PST) Subject: Approve backport of test bug Message-ID: Hi, Please approve this testbug backport from 9. The patch applies cleanly. The original bug is marked as a jigsaw bug, but that is only because it was discovered in jigsaw builds. The test bug is general and may fail in any build. It currently fails when Resource Manager is enabled. The problem is that the assumes that it can always transform a few standard java io classes when they are loaded. This does not work if those classses have already been used by the jvm before the test is started. The test has also been improved to verify that the correct methods are transformed (with the correct signature, not just the corect name). Bug: https://bugs.openjdk.java.net/browse/JDK-8060165 Changeset: http://closedjdk.us.oracle.com/jdk9/dev/jdk/test/closed/rev/a6d1b2022b93 Review thread: https://java.se.oracle.com/code/cru/CR-JDK9DEV-618 Thanks, Mattias From sean.coffey at oracle.com Mon Nov 10 13:34:31 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 10 Nov 2014 13:34:31 +0000 Subject: Approve backport of test bug In-Reply-To: References: Message-ID: <5460BEE7.1070702@oracle.com> Mattias, Closed sources aren't subject to the jdk8u approval process regards, Sean. On 10/11/14 12:38, Mattias Tobiasson wrote: From david.buck at oracle.com Tue Nov 11 00:15:51 2014 From: david.buck at oracle.com (david buck) Date: Tue, 11 Nov 2014 09:15:51 +0900 Subject: [8u40] request for approval: 8064516: BCEL still corrupts generic methods if bytecode offsets are modified Message-ID: <54615537.4050504@oracle.com> Hi! May I please have approval to backport this fix from JDK9 to JDK8? Fix applies cleanly after modularization path changes. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8064516 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/386372e9ac58 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029602.html Cheers, -Buck From rob.mckenna at oracle.com Tue Nov 11 00:46:34 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 11 Nov 2014 00:46:34 +0000 Subject: [8u40] request for approval: 8064516: BCEL still corrupts generic methods if bytecode offsets are modified In-Reply-To: <54615537.4050504@oracle.com> References: <54615537.4050504@oracle.com> Message-ID: <54615C6A.9070803@oracle.com> Please add an appropriate noreg label. Approved. -Rob On 11/11/14 00:15, david buck wrote: > Hi! > > May I please have approval to backport this fix from JDK9 to JDK8? Fix > applies cleanly after modularization path changes. > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8064516 > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/386372e9ac58 > > review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029602.html > > Cheers, > -Buck From attila.szegedi at oracle.com Tue Nov 11 15:18:26 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 11 Nov 2014 16:18:26 +0100 Subject: [8u40] Request for Approval: 8064467: type info persistence failed to calculate directory name Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8064467 jdk9 webrev: http://cr.openjdk.java.net/~attila/8064467/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003832.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Tue Nov 11 15:40:15 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 11 Nov 2014 15:40:15 +0000 Subject: [8u40] Request for Approval: 8064467: type info persistence failed to calculate directory name In-Reply-To: References: Message-ID: <54622DDF.50108@oracle.com> Approved. -Rob On 11/11/14 15:18, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064467 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8064467/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003832.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From attila.szegedi at oracle.com Tue Nov 11 16:29:18 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 11 Nov 2014 17:29:18 +0100 Subject: [8u40] Request for Approval: 8062799: Binary logical expressions can have numeric types Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8062799 jdk9 webrev: http://cr.openjdk.java.net/~attila/8062799/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003835.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From aleksej.efimov at oracle.com Tue Nov 11 16:34:28 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Tue, 11 Nov 2014 19:34:28 +0300 Subject: [8u40] Request for approval: 8064389: XML parser returns corrupt attribute value Message-ID: <54623A94.8000009@oracle.com> Hi, May I have approval to backport 8064389 fix to 8u40. The unshuffled patch applies cleanly, but there is one difference: the backported test is a testNg test and to support it 'jdk/test/javax/xml/jaxp/testng/TEST.properties' was added to testng directory (already exists in JDK9). Testing JTREG and JPRT tests shows no failures + new test finished with Pass result. The webrev: http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00 Thank you, Aleksej From rob.mckenna at oracle.com Tue Nov 11 16:36:02 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 11 Nov 2014 16:36:02 +0000 Subject: [8u40] Request for Approval: 8062799: Binary logical expressions can have numeric types In-Reply-To: References: Message-ID: <54623AF2.60801@oracle.com> Approved. -Rob On 11/11/14 16:29, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062799 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8062799/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003835.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From aleksej.efimov at oracle.com Tue Nov 11 16:47:09 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Tue, 11 Nov 2014 19:47:09 +0300 Subject: [8u40] Request for approval: 8059327: XML parser returns corrupt attribute value In-Reply-To: <54623A94.8000009@oracle.com> References: <54623A94.8000009@oracle.com> Message-ID: <54623D8D.3090301@oracle.com> Hi, Previous request doesn't follow the approval template. Resending with proper information and subject. Bug: https://bugs.openjdk.java.net/browse/JDK-8059327 JDK9 changesets: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/aa6737ec5ced http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ec5c5325de27 JDK9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029555.html JDK8 webrev: http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00/ Thank you, Aleksej On 11/11/2014 07:34 PM, Aleksej Efimov wrote: > Hi, > > May I have approval to backport 8059327 fix to 8u40. The unshuffled > patch applies cleanly, but there is one difference: the backported > test is a testNg test and to support it > 'jdk/test/javax/xml/jaxp/testng/TEST.properties' was added to testng > directory (already exists in JDK9). > Testing JTREG and JPRT tests shows no failures + new test finished > with Pass result. > The webrev: http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00 > > Thank you, > Aleksej From rob.mckenna at oracle.com Tue Nov 11 16:48:33 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 11 Nov 2014 16:48:33 +0000 Subject: [8u40] Request for approval: 8059327: XML parser returns corrupt attribute value In-Reply-To: <54623D8D.3090301@oracle.com> References: <54623A94.8000009@oracle.com> <54623D8D.3090301@oracle.com> Message-ID: <54623DE1.5070100@oracle.com> Approved, thanks Aleksej, -Rob On 11/11/14 16:47, Aleksej Efimov wrote: > Hi, > Previous request doesn't follow the approval template. Resending with > proper information and subject. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059327 > JDK9 changesets: > http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/aa6737ec5ced > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ec5c5325de27 > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029555.html > > JDK8 webrev: > http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00/ > > Thank you, > Aleksej > > On 11/11/2014 07:34 PM, Aleksej Efimov wrote: >> Hi, >> >> May I have approval to backport 8059327 fix to 8u40. The unshuffled >> patch applies cleanly, but there is one difference: the backported >> test is a testNg test and to support it >> 'jdk/test/javax/xml/jaxp/testng/TEST.properties' was added to testng >> directory (already exists in JDK9). >> Testing JTREG and JPRT tests shows no failures + new test finished >> with Pass result. >> The webrev: http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00 >> >> Thank you, >> Aleksej > From alejandro.murillo at oracle.com Tue Nov 11 19:04:57 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 11 Nov 2014 12:04:57 -0700 Subject: jdk8u40-b14: HotSpot Message-ID: <54625DD9.5030008@oracle.com> hs25.40-b18 has been integrated into jdk8u40-b14. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/df659b8b0bc8 http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/d36513f2cf93 http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/b8ca8ec1daea http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/d8886dede94d http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/d22a374ce856 http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ffc348308de2 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/f18c5b47f27b http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/7e34104c55ca Component : VM Status : 0 major failures, 0 minor failures Date : 11/11/2014 at 17:00 MSK Tested By : STT_VM Cost(total man-days): 1 Workspace : 2014-11-07-172752.amurillo.hs25-40-b18-snapshot Bundles : 2014-11-07-172752.amurillo.hs25-40-b18-snapshot Platforms : Others Tests :/net/sqenfs-1.sfbay/export1/comp/vm/testbase/ Log : link Browsers : NA Patches : NA Number of Tests Executed : 408362 passed tests, 5311 failed tests (no new failures) Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: 8046268: compiler/whitebox/ tests fail : must be osr_compiled 8056240: Investigate increased GC remark time after class unloading changes in CRM Fuse 8057043: Type annotations not retained during class redefine / retransform 8058715: stability issues when being launched as an embedded JVM via JNI 8059216: Make PrintGCApplicationStoppedTime print information about stopping threads 8059780: SPECjvm2008-MPEG performance regressions on x64 platforms 8060454: [TESTBUG] Whitebox tests fail with -XX:CompileThreshold=100 8061486: [TESTBUG] compiler/whitebox/ tests fail : must be osr_compiled (reappeared in nightlies) 8061651: Interface to the Lookup Index Cache to improve URLClassPath search time 8061817: Whitebox.deoptimizeMethod() does not deoptimize all OSR versions of method 8061983: [TESTBUG] compiler/whitebox/MakeMethodNotCompilableTest.java fails with "must not be in queue" 8062169: Multiple OSR compilations issued for same bci 8062589: new hotspot build - hs25.40-b18 New bugs filed: Bugs in PIT build: JDK-8064556 G1: ParallelGCThreads=0 may cause assert(!MetadataOnStackMark::has_buffer_for_thread(Thread::current())) failed: Should be empty JDK-8064566 [TESTBUG] Recently added AppCDS tests fail when there is no way to map shared archive to some addresses Bugs in earlier promoted build: JDK-8064564 Test sun/util/calendar/zi/TestZoneInfo310.java fails with RuntimeException: FAILED: availableIds don't match Number of PIT requested: 1 Integration target J2SE build number: jdk8u40-b14 Issues and Notes: This is PIT for HS25.40-b18 for jdk8u40-b14. Go for integration. -- Alejandro From robert.field at oracle.com Tue Nov 11 22:19:37 2014 From: robert.field at oracle.com (Robert Field) Date: Tue, 11 Nov 2014 14:19:37 -0800 Subject: [8u40] Request for backport approval: 8048121: et. al. -- javac complex method references Message-ID: <54628B79.3050603@oracle.com> Please approve the backport from 9 to 8u40 of a fix for a bug cluster -- 8048121: javac complex method references: revamp and simplify 8037404: javac NPE or VerifyError for code with constructor reference of inner class 8047341: lambda reference to inner class in base class causes LambdaConversionException 8044748: JVM cannot access constructor though ::new reference although can call it directly 8044737: Lambda: NPE while obtaining method reference through lambda expression 8038776: VerifyError when running successfully compiled java class Reviewed-by: dlsmith, vromero Fix is a non-trivial rewrite of the handling of complex method references in javac. Not counting tests, this is 198 deleted lines, 105 added lines. There are ten new tests. In addition to the above bugs addressed, there were several duplicates closed, showing that these bugs appear frequently in the wild. The new code has fermented in JDK9 since June without any bug reports against it. Bug: https://bugs.openjdk.java.net/browse/JDK-8048121 Bug: https://bugs.openjdk.java.net/browse/JDK-8037404 Bug: https://bugs.openjdk.java.net/browse/JDK-8047341 Bug: https://bugs.openjdk.java.net/browse/JDK-8044748 Bug: https://bugs.openjdk.java.net/browse/JDK-8044737 Bug: https://bugs.openjdk.java.net/browse/JDK-8038776 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/97731dc59ef6 JDK9 additional changeset (added tests): http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2b6b96ed3878 JDK8 changes match JDK9 except in trivial ways: line offset, indenting, diamond operator in removed code From sean.coffey at oracle.com Wed Nov 12 09:12:17 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 12 Nov 2014 09:12:17 +0000 Subject: [8u40] Request for backport approval: 8048121: et. al. -- javac complex method references In-Reply-To: <54628B79.3050603@oracle.com> References: <54628B79.3050603@oracle.com> Message-ID: <54632471.4070704@oracle.com> Approved. regards, Sean. On 11/11/2014 22:19, Robert Field wrote: > Please approve the backport from 9 to 8u40 of a fix for a bug cluster -- > > 8048121: javac complex method references: revamp and simplify > 8037404: javac NPE or VerifyError for code with constructor > reference of inner class > 8047341: lambda reference to inner class in base class causes > LambdaConversionException > 8044748: JVM cannot access constructor though ::new reference > although can call it directly > 8044737: Lambda: NPE while obtaining method reference through lambda > expression > 8038776: VerifyError when running successfully compiled java class > > Reviewed-by: dlsmith, vromero > > Fix is a non-trivial rewrite of the handling of complex method > references in javac. Not counting tests, this is 198 deleted lines, > 105 added lines. There are ten new tests. > In addition to the above bugs addressed, there were several duplicates > closed, showing that these bugs appear frequently in the wild. > The new code has fermented in JDK9 since June without any bug reports > against it. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8048121 > Bug: https://bugs.openjdk.java.net/browse/JDK-8037404 > Bug: https://bugs.openjdk.java.net/browse/JDK-8047341 > Bug: https://bugs.openjdk.java.net/browse/JDK-8044748 > Bug: https://bugs.openjdk.java.net/browse/JDK-8044737 > Bug: https://bugs.openjdk.java.net/browse/JDK-8038776 > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/97731dc59ef6 > JDK9 additional changeset (added tests): > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2b6b96ed3878 > > JDK8 changes match JDK9 except in trivial ways: line offset, > indenting, diamond operator in removed code > From aleksej.efimov at oracle.com Wed Nov 12 09:50:13 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Wed, 12 Nov 2014 12:50:13 +0300 Subject: [8u40] Request for approval: 8059327: XML parser returns corrupt attribute value In-Reply-To: <54623DE1.5070100@oracle.com> References: <54623A94.8000009@oracle.com> <54623D8D.3090301@oracle.com> <54623DE1.5070100@oracle.com> Message-ID: <54632D55.8070307@oracle.com> Thank you Rob! -Aleksej On 11/11/2014 07:48 PM, Rob McKenna wrote: > Approved, thanks Aleksej, > > -Rob > > On 11/11/14 16:47, Aleksej Efimov wrote: >> Hi, >> Previous request doesn't follow the approval template. Resending with >> proper information and subject. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8059327 >> JDK9 changesets: >> http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/aa6737ec5ced >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/ec5c5325de27 >> JDK9 review thread: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029555.html >> >> JDK8 webrev: >> http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00/ >> >> Thank you, >> Aleksej >> >> On 11/11/2014 07:34 PM, Aleksej Efimov wrote: >>> Hi, >>> >>> May I have approval to backport 8059327 fix to 8u40. The unshuffled >>> patch applies cleanly, but there is one difference: the backported >>> test is a testNg test and to support it >>> 'jdk/test/javax/xml/jaxp/testng/TEST.properties' was added to testng >>> directory (already exists in JDK9). >>> Testing JTREG and JPRT tests shows no failures + new test finished >>> with Pass result. >>> The webrev: http://cr.openjdk.java.net/~aefimov/8059327/8/webrev.00 >>> >>> Thank you, >>> Aleksej >> > From marcus.lagergren at oracle.com Wed Nov 12 13:17:26 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 12 Nov 2014 14:17:26 +0100 Subject: Please approve JDK-8035312 for backport to 8u40 Message-ID: Webrev: http://cr.openjdk.java.net/~lagergren/8035312/ Issue: https://bugs.openjdk.java.net/browse/JDK-8035312 Review Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html /M From sean.coffey at oracle.com Wed Nov 12 13:48:30 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 12 Nov 2014 13:48:30 +0000 Subject: Please approve JDK-8035312 for backport to 8u40 In-Reply-To: References: Message-ID: <5463652E.8070207@oracle.com> Approved. I'm assuming the patch applies cleanly post modular unshuffling. regards, Sean. On 12/11/14 13:17, Marcus Lagergren wrote: > Webrev: > http://cr.openjdk.java.net/~lagergren/8035312/ > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8035312 > > Review Thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html > > /M From sean.coffey at oracle.com Wed Nov 12 13:55:45 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 12 Nov 2014 13:55:45 +0000 Subject: Please approve JDK-8035312 for backport to 8u40 In-Reply-To: <5463652E.8070207@oracle.com> References: <5463652E.8070207@oracle.com> Message-ID: <546366E1.6020106@oracle.com> Please hold your push Marcus (if possible) - CI servers are reporting build breakage on JDK 9 changeset. regards, Sean. On 12/11/14 13:48, Se?n Coffey wrote: > Approved. I'm assuming the patch applies cleanly post modular > unshuffling. > > regards, > Sean. > > On 12/11/14 13:17, Marcus Lagergren wrote: >> Webrev: >> http://cr.openjdk.java.net/~lagergren/8035312/ >> >> >> Issue: >> https://bugs.openjdk.java.net/browse/JDK-8035312 >> >> >> Review Thread: >> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html >> >> >> >> /M > From attila.szegedi at oracle.com Wed Nov 12 14:00:25 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 12 Nov 2014 15:00:25 +0100 Subject: [8u40] Request for Approval: 8063037: ApplySpecialization.hasApplies shouuld not descend into nested functions Message-ID: <32B84E9E-CA35-4E4C-8350-30949A057CC1@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8063037 jdk9 webrev: http://cr.openjdk.java.net/~attila/8063037/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003844.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Wed Nov 12 14:31:57 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 12 Nov 2014 14:31:57 +0000 Subject: [8u40] Request for Approval: 8063037: ApplySpecialization.hasApplies shouuld not descend into nested functions In-Reply-To: <32B84E9E-CA35-4E4C-8350-30949A057CC1@oracle.com> References: <32B84E9E-CA35-4E4C-8350-30949A057CC1@oracle.com> Message-ID: <54636F5D.508@oracle.com> Approved. -Rob On 12/11/14 14:00, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8063037 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8063037/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003844.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From philip.race at oracle.com Fri Nov 7 21:44:53 2014 From: philip.race at oracle.com (Phil Race) Date: Fri, 07 Nov 2014 13:44:53 -0800 Subject: [8u40]: Request for approval : 8039444: Swing applications not being displayed properly Message-ID: <545D3D55.1060400@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8039444 Webrev: http://cr.openjdk.java.net/~prr/8039444/ Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-November/004939.html -phil. From lagergren at gmail.com Wed Nov 12 13:14:46 2014 From: lagergren at gmail.com (Marcus Lagergren) Date: Wed, 12 Nov 2014 14:14:46 +0100 Subject: Please approve JDK-8035312 for backport to 8u40 Message-ID: Webrev: http://cr.openjdk.java.net/~lagergren/8035312/ Issue: https://bugs.openjdk.java.net/browse/JDK-8035312 Review Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html /M From marcus.lagergren at oracle.com Wed Nov 12 14:50:59 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 12 Nov 2014 15:50:59 +0100 Subject: Please approve JDK-8035312 for backport to 8u40 In-Reply-To: <546366E1.6020106@oracle.com> References: <5463652E.8070207@oracle.com> <546366E1.6020106@oracle.com> Message-ID: <4459F28B-1CE8-49BB-A9A4-EE641CF1E044@oracle.com> It should be fixed. Awaiting confirmation from you that it?s OK. I will push the fix for the break atomically with this backport. /M > On 12 Nov 2014, at 14:55, Se?n Coffey wrote: > > Please hold your push Marcus (if possible) - CI servers are reporting build breakage on JDK 9 changeset. > > regards, > Sean. > > On 12/11/14 13:48, Se?n Coffey wrote: >> Approved. I'm assuming the patch applies cleanly post modular unshuffling. >> >> regards, >> Sean. >> >> On 12/11/14 13:17, Marcus Lagergren wrote: >>> Webrev: >>> http://cr.openjdk.java.net/~lagergren/8035312/ >>> >>> Issue: >>> https://bugs.openjdk.java.net/browse/JDK-8035312 >>> >>> Review Thread: >>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html >>> >>> /M >> > From sean.coffey at oracle.com Wed Nov 12 15:07:19 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 12 Nov 2014 15:07:19 +0000 Subject: Please approve JDK-8035312 for backport to 8u40 In-Reply-To: <4459F28B-1CE8-49BB-A9A4-EE641CF1E044@oracle.com> References: <5463652E.8070207@oracle.com> <546366E1.6020106@oracle.com> <4459F28B-1CE8-49BB-A9A4-EE641CF1E044@oracle.com> Message-ID: <546377A7.6040204@oracle.com> Builds in JDK 9 are green again Marcus. Looks like you're good to push changes. regards, Sean. On 12/11/14 14:50, Marcus Lagergren wrote: > It should be fixed. Awaiting confirmation from you that it?s OK. I will push the fix for the break atomically with this backport. > > /M > >> On 12 Nov 2014, at 14:55, Se?n Coffey wrote: >> >> Please hold your push Marcus (if possible) - CI servers are reporting build breakage on JDK 9 changeset. >> >> regards, >> Sean. >> >> On 12/11/14 13:48, Se?n Coffey wrote: >>> Approved. I'm assuming the patch applies cleanly post modular unshuffling. >>> >>> regards, >>> Sean. >>> >>> On 12/11/14 13:17, Marcus Lagergren wrote: >>>> Webrev: >>>> http://cr.openjdk.java.net/~lagergren/8035312/ >>>> >>>> Issue: >>>> https://bugs.openjdk.java.net/browse/JDK-8035312 >>>> >>>> Review Thread: >>>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html >>>> >>>> /M From marcus.lagergren at oracle.com Wed Nov 12 15:07:44 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 12 Nov 2014 16:07:44 +0100 Subject: Please approve JDK-8035312 for backport to 8u40 In-Reply-To: <546377A7.6040204@oracle.com> References: <5463652E.8070207@oracle.com> <546366E1.6020106@oracle.com> <4459F28B-1CE8-49BB-A9A4-EE641CF1E044@oracle.com> <546377A7.6040204@oracle.com> Message-ID: Thank you, sir /M > On 12 Nov 2014, at 16:07, Se?n Coffey wrote: > > Builds in JDK 9 are green again Marcus. Looks like you're good to push changes. > > regards, > Sean. > > On 12/11/14 14:50, Marcus Lagergren wrote: >> It should be fixed. Awaiting confirmation from you that it?s OK. I will push the fix for the break atomically with this backport. >> >> /M >> >>> On 12 Nov 2014, at 14:55, Se?n Coffey wrote: >>> >>> Please hold your push Marcus (if possible) - CI servers are reporting build breakage on JDK 9 changeset. >>> >>> regards, >>> Sean. >>> >>> On 12/11/14 13:48, Se?n Coffey wrote: >>>> Approved. I'm assuming the patch applies cleanly post modular unshuffling. >>>> >>>> regards, >>>> Sean. >>>> >>>> On 12/11/14 13:17, Marcus Lagergren wrote: >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~lagergren/8035312/ >>>>> >>>>> Issue: >>>>> https://bugs.openjdk.java.net/browse/JDK-8035312 >>>>> >>>>> Review Thread: >>>>> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003838.html >>>>> >>>>> /M > From marcus.lagergren at oracle.com Wed Nov 12 16:21:53 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Wed, 12 Nov 2014 17:21:53 +0100 Subject: Please approve JDK-8063036 for backport into 8u40 Message-ID: Some small pretty printing issues with ?log=recompile, including duplicated lines for method lookups. Moved a lot of the text spewing to log level fine, and formatted type transitions in a lot more readable fashion. bug: https://bugs.openjdk.java.net/browse/JDK-8063036 webrev: http://cr.openjdk.java.net/~lagergren/8063036/ thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003850.html /M From rob.mckenna at oracle.com Wed Nov 12 16:31:32 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 12 Nov 2014 16:31:32 +0000 Subject: Please approve JDK-8063036 for backport into 8u40 In-Reply-To: References: Message-ID: <54638B64.4010102@oracle.com> Approved. Please add a suitable noreg keyword. -Rob On 12/11/14 16:21, Marcus Lagergren wrote: > Some small pretty printing issues with ?log=recompile, including duplicated lines for method lookups. > Moved a lot of the text spewing to log level fine, and formatted type transitions in a lot more readable fashion. > > bug: https://bugs.openjdk.java.net/browse/JDK-8063036 > > webrev: http://cr.openjdk.java.net/~lagergren/8063036/ > > thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003850.html > > /M > > From alexandr.scherbatiy at oracle.com Thu Nov 13 13:15:17 2014 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 13 Nov 2014 16:15:17 +0300 Subject: [8u40] Request for approval: 8064468 ownedWindowList access requires synchronization in Window.setAlwaysOnTop() method Message-ID: <5464AEE5.1070106@oracle.com> Hello, Could you approve the direct backport of the fix to JDK 8u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8064468 The webrev: http://cr.openjdk.java.net/~alexsch/8064468/webrev.00 The review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008682.html The JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/14ea41a9241f Thanks, Alexandr. From joel.franck at oracle.com Thu Nov 13 14:05:58 2014 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Thu, 13 Nov 2014 15:05:58 +0100 Subject: [8u40] Request for approval: 8064391: More thread safety problems in core reflection Message-ID: Hi, Can I get approval to push a fix for: "8064391: More thread safety problems in core reflection" to 8u. This is a 8u version of a more general fix in 9 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 The fix is provided by Martin Bucholz : http://cr.openjdk.java.net/~martin/webrevs/openjdk8/Class-thread-safety/ Reviewed by me here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029644.html JBS issue: https://bugs.openjdk.java.net/browse/JDK-8064391 cheers /Joel From sean.coffey at oracle.com Thu Nov 13 14:57:13 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 13 Nov 2014 14:57:13 +0000 Subject: [8u40] Request for approval: 8064468 ownedWindowList access requires synchronization in Window.setAlwaysOnTop() method In-Reply-To: <5464AEE5.1070106@oracle.com> References: <5464AEE5.1070106@oracle.com> Message-ID: <5464C6C9.5010101@oracle.com> Approved. regards, Sean. On 13/11/2014 13:15, Alexander Scherbatiy wrote: > > > Hello, > > Could you approve the direct backport of the fix to JDK 8u-dev. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8064468 > The webrev: http://cr.openjdk.java.net/~alexsch/8064468/webrev.00 > The review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008682.html > The JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/14ea41a9241f > > Thanks, > Alexandr. > From sean.coffey at oracle.com Thu Nov 13 15:02:14 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 13 Nov 2014 15:02:14 +0000 Subject: [8u40] Request for approval: 8064391: More thread safety problems in core reflection In-Reply-To: References: Message-ID: <5464C7F6.1050305@oracle.com> 8064391 requires a 9-na label since the JDK 9 work was different and worked via another bug ID. Approved. regards, Sean. On 13/11/2014 14:05, Joel Borggr?n-Franck wrote: > Hi, > > Can I get approval to push a fix for: "8064391: More thread safety problems in core reflection" to 8u. > > This is a 8u version of a more general fix in 9 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 > > The fix is provided by Martin Bucholz : http://cr.openjdk.java.net/~martin/webrevs/openjdk8/Class-thread-safety/ > Reviewed by me here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029644.html > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8064391 > > cheers > /Joel From martinrb at google.com Thu Nov 13 15:02:56 2014 From: martinrb at google.com (Martin Buchholz) Date: Thu, 13 Nov 2014 07:02:56 -0800 Subject: [8u40] Request for approval: 8064391: More thread safety problems in core reflection In-Reply-To: References: Message-ID: Hold on... There are some additional thread safety improvements ("volatile") that have not yet landed in jdk9, and I think Peter Levart has proposed additions to my proposed fixes for 7 and 8 (and I've fallen behind keeping up with the Class* changes) On Thu, Nov 13, 2014 at 6:05 AM, Joel Borggr?n-Franck wrote: > Hi, > > Can I get approval to push a fix for: "8064391: More thread safety problems in core reflection" to 8u. > > This is a 8u version of a more general fix in 9 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 > > The fix is provided by Martin Bucholz : http://cr.openjdk.java.net/~martin/webrevs/openjdk8/Class-thread-safety/ > Reviewed by me here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029644.html > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8064391 > > cheers > /Joel From joel.franck at oracle.com Thu Nov 13 15:17:16 2014 From: joel.franck at oracle.com (Joel =?utf-8?Q?Borggr=C3=A9n-Franck?=) Date: Thu, 13 Nov 2014 16:17:16 +0100 Subject: [8u40] Request for approval: 8064391: More thread safety problems in core reflection In-Reply-To: References: Message-ID: <20141113151716.GD16532@oracle.com> Hi Martin, I still like to backport your patch as is, because: - It is small and "obviously correct" - Fixing an existing, but hard to repro race - I was assuming "Here are changes we made locally at Google" implied it was in production If any of this was incorrect, I agree we should wait and reiterate this some more on core-libs-dev. If my assumptions were correct I think this should go in as is, potentially followed by more fixes later on. cheers /Joel On 2014-11-13, Martin Buchholz wrote: > Hold on... There are some additional thread safety improvements > ("volatile") that have not yet landed in jdk9, and I think Peter > Levart has proposed additions to my proposed fixes for 7 and 8 (and > I've fallen behind keeping up with the Class* changes) > > On Thu, Nov 13, 2014 at 6:05 AM, Joel Borggr?n-Franck > wrote: > > Hi, > > > > Can I get approval to push a fix for: "8064391: More thread safety problems in core reflection" to 8u. > > > > This is a 8u version of a more general fix in 9 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 > > > > The fix is provided by Martin Bucholz : http://cr.openjdk.java.net/~martin/webrevs/openjdk8/Class-thread-safety/ > > Reviewed by me here: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029644.html > > > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8064391 > > > > cheers > > /Joel From marcus.lagergren at oracle.com Thu Nov 13 16:02:04 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 13 Nov 2014 17:02:04 +0100 Subject: Please approve backport of JDK-8062937 to 8u40 Message-ID: Bug: https://bugs.openjdk.java.net/browse/JDK-8062937 Webrev: http://cr.openjdk.java.net/~lagergren/8062937/webrev/ Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003855.html /M From sean.coffey at oracle.com Thu Nov 13 16:14:39 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 13 Nov 2014 16:14:39 +0000 Subject: Please approve backport of JDK-8062937 to 8u40 In-Reply-To: References: Message-ID: <5464D8EF.6020804@oracle.com> Please indicate if such ports are direct backports for future requests. I'm assuming this is another clean backport post modular unshuffling. Approved. regards, Sean. On 13/11/2014 16:02, Marcus Lagergren wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8062937 > > Webrev: http://cr.openjdk.java.net/~lagergren/8062937/webrev/ > > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003855.html > > /M > From martinrb at google.com Thu Nov 13 16:30:19 2014 From: martinrb at google.com (Martin Buchholz) Date: Thu, 13 Nov 2014 08:30:19 -0800 Subject: [8u40] Request for approval: 8064391: More thread safety problems in core reflection In-Reply-To: <20141113151716.GD16532@oracle.com> References: <20141113151716.GD16532@oracle.com> Message-ID: On Thu, Nov 13, 2014 at 7:17 AM, Joel Borggr?n-Franck wrote: > Hi Martin, > > I still like to backport your patch as is, because: > > - It is small and "obviously correct" > - Fixing an existing, but hard to repro race > - I was assuming "Here are changes we made locally at Google" implied it > was in production Yes, those are correct. > If any of this was incorrect, I agree we should wait and reiterate this > some more on core-libs-dev. If my assumptions were correct I think this > should go in as is, potentially followed by more fixes later on. Yes, it is perfectly fine to commit these changes now. A reason to wait might be to consolidate these fixes with additional possible fixes. But they should surely make the next update releases - not sure what your schedule is for that. From sean.coffey at oracle.com Thu Nov 13 16:34:43 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 13 Nov 2014 16:34:43 +0000 Subject: [8u40] Request for approval: 8064391: More thread safety problems in core reflection In-Reply-To: References: <20141113151716.GD16532@oracle.com> Message-ID: <5464DDA3.8060909@oracle.com> > But they should surely make the next update releases - not > sure what your schedule is for that. Preliminary schedule is available here : http://openjdk.java.net/projects/jdk8u/releases/8u40.html Rampdown 2 is scheduled for December - the bar will be raised for incoming 8u40 fixes from there on as we work towards 8u40 release. regards, Sean. On 13/11/2014 16:30, Martin Buchholz wrote: > On Thu, Nov 13, 2014 at 7:17 AM, Joel Borggr?n-Franck > wrote: >> Hi Martin, >> >> I still like to backport your patch as is, because: >> >> - It is small and "obviously correct" >> - Fixing an existing, but hard to repro race >> - I was assuming "Here are changes we made locally at Google" implied it >> was in production > Yes, those are correct. > >> If any of this was incorrect, I agree we should wait and reiterate this >> some more on core-libs-dev. If my assumptions were correct I think this >> should go in as is, potentially followed by more fixes later on. > Yes, it is perfectly fine to commit these changes now. A reason to > wait might be to consolidate these fixes with additional possible > fixes. But they should surely make the next update releases - not > sure what your schedule is for that. From marcus.lagergren at oracle.com Thu Nov 13 16:39:18 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Thu, 13 Nov 2014 17:39:18 +0100 Subject: Please approve backport of JDK-8062937 to 8u40 In-Reply-To: <5464D8EF.6020804@oracle.com> References: <5464D8EF.6020804@oracle.com> Message-ID: <5D4CD4EB-8DB2-4509-B972-0B4E7005E8C5@oracle.com> Correct. Yes. /M > On 13 Nov 2014, at 17:14, Se?n Coffey wrote: > > Please indicate if such ports are direct backports for future requests. I'm assuming this is another clean backport post modular unshuffling. > > Approved. > > regards, > Sean. > > On 13/11/2014 16:02, Marcus Lagergren wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8062937 >> >> Webrev: http://cr.openjdk.java.net/~lagergren/8062937/webrev/ >> >> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003855.html >> >> /M >> > From attila.szegedi at oracle.com Thu Nov 13 16:44:09 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 13 Nov 2014 17:44:09 +0100 Subject: [8u40] Request for Approval: 8064707: Remove NativeArray link logic fields Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8064707 jdk9 webrev: http://cr.openjdk.java.net/~attila/8064707/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003847.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From sean.coffey at oracle.com Thu Nov 13 16:51:47 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 13 Nov 2014 16:51:47 +0000 Subject: [8u40] Request for Approval: 8064707: Remove NativeArray link logic fields In-Reply-To: References: Message-ID: <5464E1A3.40405@oracle.com> Approved. regards, Sean. On 13/11/2014 16:44, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064707 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8064707/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003847.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From alexandr.scherbatiy at oracle.com Fri Nov 14 10:24:13 2014 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Fri, 14 Nov 2014 13:24:13 +0300 Subject: [8u40] Request for approval: 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support Message-ID: <5465D84D.1020108@oracle.com> Hello, Could you approve the direct backport of the fix to JDK 8u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8043869 The webrev: http://cr.openjdk.java.net/~alexsch/8043869/webrev.04 The review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-June/008048.html The JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/40041b949b8c Thanks, Alexandr. From vincent.x.ryan at oracle.com Fri Nov 14 10:33:12 2014 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 14 Nov 2014 10:33:12 +0000 Subject: [8u-dev] Request for approval 8040812: Uninitialised memory in jdk/src/share/native/sun/security/ec/impl/mpi.c Message-ID: <7E97E1C3-07A5-4169-8097-EB39A3522F15@oracle.com> Please approve the following backport of 8040812 from JDK 9 to JDK 8u. The unshuffled patch from JDK 9 applies cleanly to JDK 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8040812 Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-June/010616.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c2969f4cd5e4 Thanks. From sean.coffey at oracle.com Fri Nov 14 10:34:24 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 10:34:24 +0000 Subject: [8u40] Request for approval: 8043869 [macosx] java -splash does not honor @2x hi dpi notation for retina support In-Reply-To: <5465D84D.1020108@oracle.com> References: <5465D84D.1020108@oracle.com> Message-ID: <5465DAB0.8070800@oracle.com> Approved. regards, Sean. On 14/11/14 10:24, Alexander Scherbatiy wrote: > > Hello, > > Could you approve the direct backport of the fix to JDK 8u-dev. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8043869 > The webrev: http://cr.openjdk.java.net/~alexsch/8043869/webrev.04 > The review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-June/008048.html > The JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/40041b949b8c > > Thanks, > Alexandr. > From alexandr.scherbatiy at oracle.com Fri Nov 14 10:35:33 2014 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Fri, 14 Nov 2014 13:35:33 +0300 Subject: [8u40] Request for approval: 8049198 [macosx] Incorrect thread access when showing splash screen Message-ID: <5465DAF5.5040708@oracle.com> Hello, Could you approve the direct backport of the fix to JDK 8u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8049198 The webrev: http://cr.openjdk.java.net/~alexsch/8049198/webrev.01 The review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2014-July/008202.html The JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/fb3f4212427f Thanks, Alexandr. From sean.coffey at oracle.com Fri Nov 14 10:37:44 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 10:37:44 +0000 Subject: [8u-dev] Request for approval 8040812: Uninitialised memory in jdk/src/share/native/sun/security/ec/impl/mpi.c In-Reply-To: <7E97E1C3-07A5-4169-8097-EB39A3522F15@oracle.com> References: <7E97E1C3-07A5-4169-8097-EB39A3522F15@oracle.com> Message-ID: <5465DB78.3040500@oracle.com> Approved. regards, Sean. On 14/11/14 10:33, Vincent Ryan wrote: > Please approve the following backport of 8040812 from JDK 9 to JDK 8u. > The unshuffled patch from JDK 9 applies cleanly to JDK 8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8040812 > Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-June/010616.html > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c2969f4cd5e4 > > Thanks. > From sean.coffey at oracle.com Fri Nov 14 10:42:23 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 10:42:23 +0000 Subject: [8u40] Request for approval: 8049198 [macosx] Incorrect thread access when showing splash screen In-Reply-To: <5465DAF5.5040708@oracle.com> References: <5465DAF5.5040708@oracle.com> Message-ID: <5465DC8F.1000002@oracle.com> Please add a suitable noreg- label to the bug report. Approved. regards, Sean. On 14/11/14 10:35, Alexander Scherbatiy wrote: > > Hello, > > Could you approve the direct backport of the fix to JDK 8u-dev. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8049198 > The webrev: http://cr.openjdk.java.net/~alexsch/8049198/webrev.01 > The review thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-July/008202.html > The JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/fb3f4212427f > > Thanks, > Alexandr. > From vincent.x.ryan at oracle.com Fri Nov 14 13:38:20 2014 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Fri, 14 Nov 2014 13:38:20 +0000 Subject: [8u-dev] Request for approval 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m Message-ID: <013D85CE-5A4B-4D38-9EA1-33971CFCF0CA@oracle.com> Please approve the following backport of 8034031 from JDK 9 to JDK 8u. The unshuffled patch from JDK 9 applies cleanly to JDK 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-November/011425.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/a474ad2dbd9b Thanks. From sean.coffey at oracle.com Fri Nov 14 13:41:10 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 13:41:10 +0000 Subject: [8u-dev] Request for approval 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m In-Reply-To: <013D85CE-5A4B-4D38-9EA1-33971CFCF0CA@oracle.com> References: <013D85CE-5A4B-4D38-9EA1-33971CFCF0CA@oracle.com> Message-ID: <54660676.9000608@oracle.com> Approved. regards, Sean. On 14/11/14 13:38, Vincent Ryan wrote: > Please approve the following backport of 8034031 from JDK 9 to JDK 8u. > The unshuffled patch from JDK 9 applies cleanly to JDK 8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 > Review: http://mail.openjdk.java.net/pipermail/security-dev/2014-November/011425.html > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/a474ad2dbd9b > > Thanks. From sean.coffey at oracle.com Fri Nov 14 13:52:33 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 13:52:33 +0000 Subject: hg: jdk8u/jdk8u-dev/hotspot: 8064716: TestHumongousShrinkHeap.java can not be run with -XX:+ExplicitGCInvokesConcurrent; ... In-Reply-To: <201411141340.sAEDeYdQ013001@aojmv0008> References: <201411141340.sAEDeYdQ013001@aojmv0008> Message-ID: <54660921.4040808@oracle.com> Andrey, Konstantin, was a push approval request submitted for this ? If not, please log one for record purposes. On the face of it, it looks like something that should enter via the hotspot team forest but I see that the JDK 9 fix was also pushed to the jdk9-dev forest. thanks, Sean. On 14/11/14 13:40, konstantin.shefov at oracle.com wrote: > Changeset: 7a6313074325 > Author: azakharov > Date: 2014-11-14 17:39 +0400 > URL: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/7a6313074325 > > 8064716: TestHumongousShrinkHeap.java can not be run with -XX:+ExplicitGCInvokesConcurrent > 8062957: Heap is not shrunk when deallocating under memory pressure > Summary: Added explicit -XX:-ExplicitGCInvokesConcurrent to invocations > Reviewed-by: brutisso, tschatzl > > ! test/gc/g1/TestHumongousShrinkHeap.java > ! test/gc/g1/TestShrinkAuxiliaryData.java > ! test/gc/g1/TestShrinkDefragmentedHeap.java > From petr.pchelko at oracle.com Fri Nov 14 13:36:35 2014 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Fri, 14 Nov 2014 17:36:35 +0400 Subject: [8u40] request for approval: JDK-8027148 SystemFlavorMap.getNativesForFlavor returns list of native formats in incorrect order Message-ID: Hello, This is a request for approval to backport a fix from JDK9 to the JDK8u-dev repository. The bug: https://bugs.openjdk.java.net/browse/JDK-8027148 The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/a56aca1ce81b The 8u version is the same as 9. Thank you. With best regards. Petr. From sean.coffey at oracle.com Fri Nov 14 14:59:09 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 14:59:09 +0000 Subject: [8u40] request for approval: JDK-8027148 SystemFlavorMap.getNativesForFlavor returns list of native formats in incorrect order In-Reply-To: References: Message-ID: <546618BD.2010801@oracle.com> Approved. regards, Sean. On 14/11/14 13:36, Petr Pchelko wrote: > Hello, > > This is a request for approval to backport a fix from JDK9 to the JDK8u-dev repository. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8027148 > The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/a56aca1ce81b > > The 8u version is the same as 9. > > Thank you. > With best regards. Petr. From anton.nashatyrev at oracle.com Fri Nov 14 15:13:07 2014 From: anton.nashatyrev at oracle.com (Anton Nashatyrev) Date: Fri, 14 Nov 2014 18:13:07 +0300 Subject: [8u-dev] Backport request: Regression: 8059739: Dragged and Dropped data is corrupted for two data types Message-ID: <54661C03.3030508@oracle.com> Hello, please approve the fix backport from jdk9 to jdk8u-dev. The fix is almost the same except the util method getTextCharset(flavor) moved from DataTransferer (jdk8) to DataFlavorUtil (jdk9). The method body remained the same. Bug: https://bugs.openjdk.java.net/browse/JDK-8059739 Webrev for Jdk8: http://cr.openjdk.java.net/%7Eanashaty/8059739/8/webrev.00/ Webrev for Jdk9: http://cr.openjdk.java.net/%7Eanashaty/8059739/9/webrev.01/ Jdk9 Changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/27da3598f030 Jdk9 Review Thread: http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004020.html Thanks! Anton. From jan.lahoda at oracle.com Fri Nov 14 16:34:56 2014 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 14 Nov 2014 17:34:56 +0100 Subject: [8u40] request for review and approval to backport JDK-8062747: Compiler error when anonymous class uses method with parametrized exception Message-ID: <54662F30.8060603@oracle.com> Hello, I'd like to ask for a review of a backport fix, and an approval to push it to jdk8u/jdk8u-dev, for the following bug: Bug: https://bugs.openjdk.java.net/browse/JDK-8062747 jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/0b467b70ad82 jdk8u patch: http://cr.openjdk.java.net/~jlahoda/8062747-8/webrev.00/ The difference between the JDK9 and JDK8u fixes is that the JDK9 fix uses "WriteableScope" and "WriteableScope.create" while the JDK8u fix uses "Scope" and "new Scope" (respectively), because WriteableScope is only in JDK9. Thanks, Jan From sean.coffey at oracle.com Fri Nov 14 16:55:18 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 14 Nov 2014 16:55:18 +0000 Subject: [8u40] request for review and approval to backport JDK-8062747: Compiler error when anonymous class uses method with parametrized exception In-Reply-To: <54662F30.8060603@oracle.com> References: <54662F30.8060603@oracle.com> Message-ID: <546633F6.4010001@oracle.com> Please get a peer review before pushing. Approved (with that condition) regards, Sean. On 14/11/14 16:34, Jan Lahoda wrote: > Hello, > > I'd like to ask for a review of a backport fix, and an approval to > push it to jdk8u/jdk8u-dev, for the following bug: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062747 > jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/0b467b70ad82 > jdk8u patch: http://cr.openjdk.java.net/~jlahoda/8062747-8/webrev.00/ > > The difference between the JDK9 and JDK8u fixes is that the JDK9 fix > uses "WriteableScope" and "WriteableScope.create" while the JDK8u fix > uses "Scope" and "new Scope" (respectively), because WriteableScope is > only in JDK9. > > Thanks, > Jan From sean.coffey at oracle.com Fri Nov 14 16:56:40 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 14 Nov 2014 16:56:40 +0000 Subject: [8u-dev] Backport request: Regression: 8059739: Dragged and Dropped data is corrupted for two data types In-Reply-To: <54661C03.3030508@oracle.com> References: <54661C03.3030508@oracle.com> Message-ID: <54663448.3030500@oracle.com> Please get a peer review before pushing your change. Approved. regards, Sean. On 14/11/14 15:13, Anton Nashatyrev wrote: > Hello, > > please approve the fix backport from jdk9 to jdk8u-dev. > The fix is almost the same except the util method > getTextCharset(flavor) moved from DataTransferer (jdk8) to > DataFlavorUtil (jdk9). The method body remained the same. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059739 > Webrev for Jdk8: > http://cr.openjdk.java.net/%7Eanashaty/8059739/8/webrev.00/ > Webrev for Jdk9: > http://cr.openjdk.java.net/%7Eanashaty/8059739/9/webrev.01/ > Jdk9 Changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/27da3598f030 > Jdk9 Review Thread: > http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004020.html > > Thanks! > Anton. From vicente.romero at oracle.com Fri Nov 14 19:08:47 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Fri, 14 Nov 2014 11:08:47 -0800 Subject: [8u40] request for review and approval to backport JDK-8062747: Compiler error when anonymous class uses method with parametrized exception - approved In-Reply-To: <54662F30.8060603@oracle.com> References: <54662F30.8060603@oracle.com> Message-ID: <5466533F.50306@oracle.com> review approved, Vicente On 11/14/2014 08:34 AM, Jan Lahoda wrote: > Hello, > > I'd like to ask for a review of a backport fix, and an approval to > push it to jdk8u/jdk8u-dev, for the following bug: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062747 > jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/0b467b70ad82 > jdk8u patch: http://cr.openjdk.java.net/~jlahoda/8062747-8/webrev.00/ > > The difference between the JDK9 and JDK8u fixes is that the JDK9 fix > uses "WriteableScope" and "WriteableScope.create" while the JDK8u fix > uses "Scope" and "new Scope" (respectively), because WriteableScope is > only in JDK9. > > Thanks, > Jan From brent.christian at oracle.com Fri Nov 14 19:15:28 2014 From: brent.christian at oracle.com (Brent Christian) Date: Fri, 14 Nov 2014 11:15:28 -0800 Subject: [8u40] Request for approval for JDK-8064288 : sun.management.Flag should loadLibrary() Message-ID: <546654D0.6080002@oracle.com> Hi, Please approve this fix for 8u40. Bug: https://bugs.openjdk.java.net/browse/JDK-8064288 Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-November/015937.html Thanks! -Brent From rob.mckenna at oracle.com Fri Nov 14 19:19:13 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 14 Nov 2014 19:19:13 +0000 Subject: [8u40] Request for approval for JDK-8064288 : sun.management.Flag should loadLibrary() In-Reply-To: <546654D0.6080002@oracle.com> References: <546654D0.6080002@oracle.com> Message-ID: <546655B1.8010803@oracle.com> Needs an appropriate noreg label. Approved assuming its a straight backport done post-9 push. -Rob On 14/11/14 19:15, Brent Christian wrote: > Hi, > > Please approve this fix for 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064288 > > Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ > > Review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-November/015937.html > > > Thanks! > > -Brent > From roger.riggs at oracle.com Fri Nov 14 19:25:02 2014 From: roger.riggs at oracle.com (roger riggs) Date: Fri, 14 Nov 2014 14:25:02 -0500 Subject: [8u40] Request for approval for JDK-8064288 : sun.management.Flag should loadLibrary() In-Reply-To: <546654D0.6080002@oracle.com> References: <546654D0.6080002@oracle.com> Message-ID: <5466570E.7000805@oracle.com> Hi Brent, Looks fine. I have a personal preference for using limited doPrivileged with an explicit new RuntimePermission("loadLibrary.resource") but it is not material in this case. Roger On 11/14/2014 2:15 PM, Brent Christian wrote: > Hi, > > Please approve this fix for 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064288 > > Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ > > Review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-November/015937.html > > > Thanks! > > -Brent > From alejandro.murillo at oracle.com Fri Nov 14 22:33:12 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 14 Nov 2014 15:33:12 -0700 Subject: [8u40] Request for approval for bulk integration of hs25.40-b19 Message-ID: <54668328.4020400@oracle.com> Requesting approval to integrate hs25.40-b19 into jdk8u40-b15. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b19-jdk8u40-b15.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8056049: getProcessCpuLoad() stops working in one process when a different process exits 8057622: java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest: SEGV inside compiled code (sparc) 8058251: assert(_count > 0) failed: Negative counter when running runtime/NMT/MallocTrackingVerify.java 8059803: Update use of GetVersionEx to get correct Windows version in hs_err files 8060467: CMS: small OldPLABSize and -XX:-ResizePLAB cause assert(ResizePLAB || n_blks == OldPLABSize) failed: Error 8061969: [TESTBUG] MallocSiteHashOverflow.java should be enabled for 32-bit platforms 8062247: [TESTBUG] Allow WhiteBox test to access JVM offsets 8062950: Bug in locking code when UseOptoBiasInlining is disabled: assert(dmw->is_neutral()) failed: invariant 8064361: new hotspot build - hs25.40-b19 8064556: G1: ParallelGCThreads=0 may cause assert(!MetadataOnStackMark::has_buffer_for_thread(Thread::current())) failed: Should be empty -- Alejandro From brent.christian at oracle.com Fri Nov 14 22:34:05 2014 From: brent.christian at oracle.com (Brent Christian) Date: Fri, 14 Nov 2014 14:34:05 -0800 Subject: [8u40] Request for approval for JDK-8064288 : sun.management.Flag should loadLibrary() In-Reply-To: <546655B1.8010803@oracle.com> References: <546654D0.6080002@oracle.com> <546655B1.8010803@oracle.com> Message-ID: <5466835D.4020400@oracle.com> On 11/14/14 11:19 AM, Rob McKenna wrote: > Needs an appropriate noreg label. Added. > Approved assuming its a straight backport done post-9 push. This is new code in 8u40, and was reviewed as such. It will be moved forward to 9 soon. Thanks, -Brent > On 14/11/14 19:15, Brent Christian wrote: >> Hi, >> >> Please approve this fix for 8u40. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8064288 >> >> Webrev: http://cr.openjdk.java.net/~bchristi/8064288/webrev.0/ >> >> Review thread: >> http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-November/015937.html >> >> >> >> Thanks! >> >> -Brent >> > From rob.mckenna at oracle.com Sat Nov 15 00:07:07 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sat, 15 Nov 2014 00:07:07 +0000 Subject: [8u40] Request for approval for bulk integration of hs25.40-b19 In-Reply-To: <54668328.4020400@oracle.com> References: <54668328.4020400@oracle.com> Message-ID: <5466992B.6010405@oracle.com> Approved. -Rob On 14/11/14 22:33, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.40-b19 into jdk8u40-b15. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b19-jdk8u40-b15.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8056049: getProcessCpuLoad() stops working in one process when a > different process exits > 8057622: > java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest: > SEGV inside compiled code (sparc) > 8058251: assert(_count > 0) failed: Negative counter when running > runtime/NMT/MallocTrackingVerify.java > 8059803: Update use of GetVersionEx to get correct Windows version in > hs_err files > 8060467: CMS: small OldPLABSize and -XX:-ResizePLAB cause > assert(ResizePLAB || n_blks == OldPLABSize) failed: Error > 8061969: [TESTBUG] MallocSiteHashOverflow.java should be enabled for > 32-bit platforms > 8062247: [TESTBUG] Allow WhiteBox test to access JVM offsets > 8062950: Bug in locking code when UseOptoBiasInlining is disabled: > assert(dmw->is_neutral()) failed: invariant > 8064361: new hotspot build - hs25.40-b19 > 8064556: G1: ParallelGCThreads=0 may cause > assert(!MetadataOnStackMark::has_buffer_for_thread(Thread::current())) > failed: Should be empty > From mattias.tobiasson at oracle.com Mon Nov 17 10:03:32 2014 From: mattias.tobiasson at oracle.com (Mattias Tobiasson) Date: Mon, 17 Nov 2014 02:03:32 -0800 (PST) Subject: [8u40] Backport request: 8061960: TestDaemonThread.java regularly fails due to exceeded timeout Message-ID: <35dc4c1e-13d0-4829-8089-209a2c9f54fa@default> Hi, Please approve this testbug backport from 9. The patch applies cleanly. The change is just to move "/timeout" parameter on the command line to the correct position. Old version: @run main TestDaemonThreadLauncher /timeout=240 New version: @run main/timeout=240 TestDaemonThreadLauncher Bug: https://bugs.openjdk.java.net/browse/JDK-8061960 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7d5f40c8d20e Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028098.html Thanks, Mattias From sean.coffey at oracle.com Mon Nov 17 10:31:46 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 10:31:46 +0000 Subject: [8u40] Backport request: 8061960: TestDaemonThread.java regularly fails due to exceeded timeout In-Reply-To: <35dc4c1e-13d0-4829-8089-209a2c9f54fa@default> References: <35dc4c1e-13d0-4829-8089-209a2c9f54fa@default> Message-ID: <5469CE92.5040107@oracle.com> Approved. regards, Sean. On 17/11/14 10:03, Mattias Tobiasson wrote: > Hi, > Please approve this testbug backport from 9. The patch applies cleanly. > > The change is just to move "/timeout" parameter on the command line to > the correct position. > Old version: @run main TestDaemonThreadLauncher /timeout=240 > New version: @run main/timeout=240 TestDaemonThreadLauncher > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8061960 > > Changeset: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7d5f40c8d20e > > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028098.html > > Thanks, > Mattias From sergey.lugovoy at oracle.com Mon Nov 17 12:57:20 2014 From: sergey.lugovoy at oracle.com (Sergey Lugovoy) Date: Mon, 17 Nov 2014 15:57:20 +0300 Subject: [8u40] request for approval to backport of nashorn changesets Message-ID: <5469F0B0.8060606@oracle.com> Hi, Please approve backport of the following 2 changesets from jdk9 to jdk8u40. All changesets appled "as is" Bug: https://bugs.openjdk.java.net/browse/JDK-8062638 changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/0c9f3369f3d3 Bug: https://bugs.openjdk.java.net/browse/JDK-8054343 changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/2520d5e7bc5f -- Thanks, Sergey From marcus.lagergren at oracle.com Mon Nov 17 13:38:26 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 17 Nov 2014 14:38:26 +0100 Subject: Please approve backport of JDK-8049407 to 8u40 Message-ID: Bug: https://bugs.openjdk.java.net/browse/JDK-8049407 Webrev: http://cr.openjdk.java.net/~lagergren/8049407/ Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003861.html /M From sean.coffey at oracle.com Mon Nov 17 14:35:52 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 14:35:52 +0000 Subject: [8u40] 8062638 ,8054343 - request for approval to backport of nashorn changesets In-Reply-To: <5469F0B0.8060606@oracle.com> References: <5469F0B0.8060606@oracle.com> Message-ID: <546A07C8.20808@oracle.com> I've added the bugIDs to the subject line. I notice the review links are missing also. Please remember for the next time.[1] Can you add a 'testbug' or 'noreg-self' label to both bug reports ? Approved. regards, Sean. [1] http://openjdk.java.net/projects/jdk8u/approval-template.html On 17/11/14 12:57, Sergey Lugovoy wrote: > Hi, > Please approve backport of the following 2 changesets from jdk9 to > jdk8u40. > All changesets appled "as is" > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062638 > changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/0c9f3369f3d3 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8054343 > changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/2520d5e7bc5f > From sean.coffey at oracle.com Mon Nov 17 14:36:52 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 17 Nov 2014 14:36:52 +0000 Subject: Please approve backport of JDK-8049407 to 8u40 In-Reply-To: References: Message-ID: <546A0804.6030509@oracle.com> Please add testbug or noreg-self label to bug report. Approved. regards, Sean. On 17/11/14 13:38, Marcus Lagergren wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8049407 > Webrev: http://cr.openjdk.java.net/~lagergren/8049407/ > Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003861.html > > /M > > From marcus.lagergren at oracle.com Mon Nov 17 15:40:44 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Mon, 17 Nov 2014 16:40:44 +0100 Subject: Please approve backport of JDK-8049407 to 8u40 In-Reply-To: <546A0804.6030509@oracle.com> References: <546A0804.6030509@oracle.com> Message-ID: <41FCA148-4044-49DB-AEFD-7F2E5A3D319D@oracle.com> Done. Thank you. /M > On 17 Nov 2014, at 15:36, Se?n Coffey wrote: > > Please add testbug or noreg-self label to bug report. > > Approved. > > regards, > Sean. > > On 17/11/14 13:38, Marcus Lagergren wrote: >> Bug: https://bugs.openjdk.java.net/browse/JDK-8049407 >> Webrev: http://cr.openjdk.java.net/~lagergren/8049407/ >> Thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003861.html >> >> /M >> >> > From eric.mccorkle at oracle.com Mon Nov 17 16:32:34 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 17 Nov 2014 11:32:34 -0500 Subject: [8u40] Request for approval for 806433: parameter_index for type annotation not updated after outer.this added Message-ID: <546A2322.9000105@oracle.com> Bug report: https://bugs.openjdk.java.net/browse/JDK-8029012 Changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/aa9b6165ab12 From eric.mccorkle at oracle.com Mon Nov 17 16:35:18 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 17 Nov 2014 11:35:18 -0500 Subject: [8u40] Request for approval for 8064474: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type Message-ID: <546A23C6.1070607@oracle.com> Bug report: https://bugs.openjdk.java.net/browse/JDK-8055063 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/23e10e5df0b3 From sean.coffey at oracle.com Mon Nov 17 16:36:04 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 16:36:04 +0000 Subject: [8u40] Request for approval for 806433: parameter_index for type annotation not updated after outer.this added In-Reply-To: <546A2322.9000105@oracle.com> References: <546A2322.9000105@oracle.com> Message-ID: <546A23F4.6090906@oracle.com> Does this fix apply cleanly Eric and is there a review thread you can point us to ? regards, Sean. On 17/11/14 16:32, Eric McCorkle wrote: > Bug report: https://bugs.openjdk.java.net/browse/JDK-8029012 > > Changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/aa9b6165ab12 From mandy.chung at oracle.com Mon Nov 17 16:57:23 2014 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 17 Nov 2014 08:57:23 -0800 Subject: [8u40] Review request 8064667: Provide support to help identify use of endorsed standards and extension mechanism Message-ID: <546A28F3.1010802@oracle.com> This requests both code review and 8u40 approval for: https://bugs.openjdk.java.net/browse/JDK-8064667 Webrev: http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ JEP 220 [1] proposes to remove the endorsed standards override mechanism and extension mechanism. This patch adds a VM flag in 8u40 to help identify any existing uses of these mechanisms so that users can turn on the VM flag to help identify if they depend on the endorsed standards override mechanism and extension mechanism and can plan to prepare for the migration to a newer JDK release early on. When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any system extension directory contains JAR files. Thanks Mandy [1] http://openjdk.java.net/jeps/220 From michael.fang at oracle.com Mon Nov 17 16:58:07 2014 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 17 Nov 2014 08:58:07 -0800 Subject: Review request for 8055798: Japanese translation for a warning from javac looks incorrect. In-Reply-To: <5425BAB2.9060705@oracle.com> References: <5425BAB2.9060705@oracle.com> Message-ID: <546A291F.4030303@oracle.com> Hi, Please help to code review the changes for the following CR: 8055798: Japanese translation for a warning from javac looks incorrect. https://bugs.openjdk.java.net/browse/JDK-8055798 The webrev is located at: http://cr.openjdk.java.net/~mfang/8055798/ thanks, -michael From alexander.harlap at oracle.com Mon Nov 17 17:29:39 2014 From: alexander.harlap at oracle.com (Alexander Harlap) Date: Mon, 17 Nov 2014 12:29:39 -0500 Subject: Review request for 8059492: Wrong spelling in assert: "Not initialied properly?" Message-ID: <546A3083.9060707@oracle.com> Please help to code review the changes (trivial) for the following CR: 8059492: Wrong spelling in assert: "Not initialied properly?" https://bugs.openjdk.java.net/browse/JDK-8059492 The webrev is located at: http://cr.openjdk.java.net/~aharlap/8059492/webrev.00/ Testing completed: JPRT Alex From coleen.phillimore at oracle.com Mon Nov 17 17:59:38 2014 From: coleen.phillimore at oracle.com (Coleen Phillimore) Date: Mon, 17 Nov 2014 12:59:38 -0500 Subject: Review request for 8059492: Wrong spelling in assert: "Not initialied properly?" In-Reply-To: <546A3083.9060707@oracle.com> References: <546A3083.9060707@oracle.com> Message-ID: <546A378A.5090205@oracle.com> Thank you for fixing that one! Coleen On 11/17/14, 12:29 PM, Alexander Harlap wrote: > Please help to code review the changes (trivial) for the following CR: > 8059492: Wrong spelling in assert: "Not initialied properly?" > https://bugs.openjdk.java.net/browse/JDK-8059492 > > The webrev is located at: > http://cr.openjdk.java.net/~aharlap/8059492/webrev.00/ > > > Testing completed: JPRT > > Alex From sean.coffey at oracle.com Mon Nov 17 18:06:17 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 17 Nov 2014 18:06:17 +0000 Subject: [8u40] Review request 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546A28F3.1010802@oracle.com> References: <546A28F3.1010802@oracle.com> Message-ID: <546A3919.7020804@oracle.com> Looks good to me Mandy. Best to get a runtime reviewer to look at that I guess. Few other comments : a) Will you be filing a CCC for the new flag ? b) Maybe a testcase would be useful (simple one launching in ovm mode with java.endorsed.dirs etc. c) Will you be pushing this to hs-dev or jdk8u-dev forest ? Seems most relevant for hotspot team forest. No approval required in that case. regards, Sean. On 17/11/14 16:57, Mandy Chung wrote: > This requests both code review and 8u40 approval for: > https://bugs.openjdk.java.net/browse/JDK-8064667 > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ > > JEP 220 [1] proposes to remove the endorsed standards override > mechanism and extension mechanism. This patch adds a VM flag in 8u40 > to help identify any existing uses of these mechanisms so that users > can turn on the VM flag to help identify if they depend on the > endorsed standards override mechanism and extension mechanism and can > plan to prepare for the migration to a newer JDK release early on. > When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the > system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if > ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any > system extension directory contains JAR files. > > Thanks > Mandy > [1] http://openjdk.java.net/jeps/220 > > > From christian.tornqvist at oracle.com Mon Nov 17 19:27:52 2014 From: christian.tornqvist at oracle.com (Christian Tornqvist) Date: Mon, 17 Nov 2014 14:27:52 -0500 Subject: [8u-communication] JDK 8u20 released today! In-Reply-To: <53FC4547.6040407@oracle.com> References: <53F3A39E.3010700@oracle.com> <1503800014.9438989.1408479930435.JavaMail.zimbra@redhat.com> <53F421D0.3090106@oracle.com> <350651847.9993656.1408548452148.JavaMail.zimbra@redhat.com> <53FB05B1.2080908@oracle.com> <53FC0C58.6090507@oracle.com> <53FC4547.6040407@oracle.com> Message-ID: <045f01d0029c$954dec10$bfe9c430$@oracle.com> Hi Andrew, With the recent changes allowing pushes for zero/ppc/aix/shark changes outside of jprt, you should be able to push the fix for this issue. Should I assign the bug to you? Best regards, Christian -----Original Message----- From: jdk8u-dev [mailto:jdk8u-dev-bounces at openjdk.java.net] On Behalf Of Se?n Coffey Sent: Tuesday, August 26, 2014 4:29 AM To: David Holmes; Andrew Hughes Cc: jdk8u-dev at openjdk.java.net Subject: Re: [8u-communication] JDK 8u20 released today! On 26/08/2014 05:26, David Holmes wrote: > On 25/08/2014 7:45 PM, Se?n Coffey wrote: >> Please ensure the necessary fixes are now in the JDK 8u codeline. If >> not, please ensure that bug records exist to fix such issues in JDK 8u. > > I have marked 8048169 as affecting 8u40 and added a comment that it > needs backporting. Best way to capture a "must backport" issue is to create a backport record. We have several issues in JBS where the affects version may contain 8uX but an actual fix might not be pushed for 8uX. The backport is currently assigned to the JDK 9 bug owner (Volker) - not sure if Volker can port it or if someone else can take charge of it. regards, Sean. > > I have created 8056011 for the second zero-only issue that Andrew > provides a patch for below, and linked it to 8048169. > > David > >> regards, >> Sean. >> >> On 20/08/14 16:27, Andrew Hughes wrote: >>> ----- Original Message ----- >>>> On 20/08/2014 6:25 AM, Andrew Hughes wrote: >>>>> ----- Original Message ----- >>>>>> I'd like to announce that JDK 8u20 has become available for >>>>>> download today [0]. Thanks to all those who have contributed towards it. >>>>>> >>>>>> OpenJDK 8u20 source code is available via the 8u20 stabilization >>>>>> forest [1]. I plan to update the OpenJDK 8u project page with >>>>>> latest status and to also ask the OpenJDK ops team to mark the >>>>>> 8u20 forests as read-only. >>>>>> >>>>>> If you're packaging this release, it could be useful to let >>>>>> subscribed members know about it via communication on this >>>>>> mailing list. Please continue to contribute fixes back to the >>>>>> jdk8u-dev forest [2] which is already gathering changes for the >>>>>> next non-CPU JDK8u release. >>>>>> >>>>>> Regards, >>>>>> Sean. >>>>>> >>>>>> [0] >>>>>> http://www.oracle.com/technetwork/java/javase/downloads/index.htm >>>>>> l [1] http://hg.openjdk.java.net/jdk8u/jdk8u20/ >>>>>> [2] http://hg.openjdk.java.net/jdk8u/jdk8u-dev >>>>>> >>>>> Zero appears to be broken: >>>>> >>>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2852:114: >>>>> error: >>>>> form\ >>>>> at '%lx' expects argument of type 'long unsigned int', but >>>>> argument >>>>> 4 has >>>>> type 'void*' [-Werror=format=] >>>>> tty->print_cr("Exception <%s> (" INTPTR_FORMAT ")", >>>>> except_oop->print_value_string(), (void*)except_oop()); >>>>> >>>>> ^ >>>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2856:47: >>>>> error: >>>>> format '%d' expects argument of type 'int', but argument 3 has >>>>> type 'address {aka unsigned char*}' [-Werror=format=] >>>>> continuation_bci, THREAD); >>>>> ^ >>>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2856:47: >>>>> error: >>>>> format '%d' expects argument of type 'int', but argument 4 has >>>>> type 'intptr_t {aka long int}' [-Werror=format=] >>>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2856:47: >>>>> error: >>>>> format '%lx' expects argument of type 'long unsigned int', but >>>>> argument 5 has type 'JavaThread*' [-Werror=format=] >>>>> /hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2868:112: >>>>> error: >>>>> format '%lx' expects argument of type 'long unsigned int', but >>>>> argument 4 has type 'void*' [-Werror=format=] >>>>> tty->print_cr("Exception <%s> (" INTPTR_FORMAT ")", >>>>> except_oop->print_value_string(), (void*)except_oop()); >>>>> >>>>> ^ >>>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2872:27: >>>>> error: >>>>> format '%d' expects argument of type 'int', but argument 3 has type >>>>> 'address {aka unsigned char*}' [-Werror=format=] >>>>> THREAD); >>>>> ^ >>>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:2872:27: >>>>> error: >>>>> format '%lx' expects argument of type 'long unsigned int', but >>>>> argument 4 >>>>> has type 'JavaThread*' [-Werror=format=] >>>>> >>>>> 8048169: Change 8037816 breaks HS build on PPC64 and CPP-Interpreter >>>>> platforms >>>>> fixes that but doesn't seem to be in u20. >>>> Unfortunately the need for a 8u backport was not mentioned in the >>>> review >>>> thread: >>>> >>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-June/014453.html >>>> >>>> >>>> Did anyone flag this since 8048169 was pushed? I can't seem to find >>>> any >>>> email thread on it. >>>> >>>> I think we have a hole in the process when the "bug tail" for a >>>> backported fix is not also identified as needing an urgent backport. >>> I couldn't see anything in the thread either. I literally only >>> stumbled across >>> this all yesterday as I found the issue, and u20 was released right as >>> I was doing >>> it :( >>> >>>>> With that applied, it fails further >>>>> on in frame_zero.cpp. I don't see a fix for that in 9 either. >>>> See review thread: >>>> >>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-August/014825.html >>>> >>>> >>>> >>>> Not sure if it has been been pushed anywhere yet. >>> It's a different issue, again with format warnings. I have a fix for >>> 8u, but not >>> sure how applicable it is for 9. I haven't had a chance to look at >>> that yet. >>> >>> Actually, it's just this: >>> >>> diff -r 6533ac845e18 -r c75d6ce2e98b src/cpu/zero/vm/frame_zero.cpp >>> --- a/src/cpu/zero/vm/frame_zero.cpp Mon Jun 30 14:58:52 2014 -0400 >>> +++ b/src/cpu/zero/vm/frame_zero.cpp Tue Aug 19 22:31:00 2014 +0100 >>> @@ -216,7 +216,7 @@ >>> valuebuf[buflen - 1] = '\0'; >>> // Print the result >>> - st->print_cr(" " PTR_FORMAT ": %-21s = %s", addr, fieldbuf, >>> valuebuf); >>> + st->print_cr(" " PTR_FORMAT ": %-21s = %s", p2i(addr), fieldbuf, >>> valuebuf); >>> } >>> } >>> >>> I'm guessing 8048169 covered the PPC port use of the interpreter, but >>> this >>> file is only built as part of Zero. >>> >>>> David >>>> ----- >>>> >> From sergey.bylokhov at oracle.com Mon Nov 17 19:31:25 2014 From: sergey.bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 17 Nov 2014 11:31:25 -0800 (PST) Subject: [8u-dev] Request for approval: 6302052, 8041734, 8029253, 8059943, 7148531, 8061456, 8059941, 8057830, 8062164, 7169583 Message-ID: <77581483-267a-46a5-a84d-ed109d09773e@default> Hello, These are a direct back ports from jdk 9 to jdk 8u-dev. 6302052: Reference to nonexistant Class in javadoc Bug: https://bugs.openjdk.java.net/browse/JDK-6302052 Webrev can be found at: http://cr.openjdk.java.net/~serb/6302052/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b4924515f4ac Review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-August/003786.html Reviewers: Alexander Zvegintsev, Alexander Scherbatiy 8041734: JFrame in full screen mode leaves empty workspace after close Bug: https://bugs.openjdk.java.net/browse/JDK-8041734 Webrev can be found at: http://cr.openjdk.java.net/~serb/8041734/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/54afdf196017 Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-September/008535.html Reviewers: Alexander Zvegintsev, Alexander Scherbatiy 8029253: [macosx] Performance problems with Retina display on Mac OS X Bug: https://bugs.openjdk.java.net/browse/JDK-8029253 Webrev can be found at: http://cr.openjdk.java.net/~serb/8029253/webrev.04 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f8498246a197 Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004870.html Reviewers: Andrew Brygin, Phil Race 8059943: [macosx] Aqua LaF should use BI.TYPE_INT_ARGB_PRE for a better performance Bug: https://bugs.openjdk.java.net/browse/JDK-8059943 Webrev can be found at: http://cr.openjdk.java.net/~serb/8059943/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4108c46e4cea Review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-October/003982.html Reviewers: Alexander Scherbatiy, Alexander Zvegintsev 7148531: [macosx] In test, the window does not have time to resize before make a screenshot Bug: https://bugs.openjdk.java.net/browse/JDK-7148531 Webrev can be found at: http://cr.openjdk.java.net/~serb/7148531/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ff6048f77891 Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008597.html Reviewers: Alexander Scherbatiy, Alexander Zvegintsev 8061456: [OGL] Incorrect clip is used during sw->surface blit in xor mode Bug: https://bugs.openjdk.java.net/browse/JDK-8061456 Webrev can be found at: http://cr.openjdk.java.net/~serb/8061456/webrev.03 jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/be34425400ec Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004906.html Reviewers: Andrew Brygin, Phil Race 8059941: [D3D] The fix for JDK-8029253 should be ported to d3d pipeline Bug: https://bugs.openjdk.java.net/browse/JDK-8059941 Webrev can be found at: http://cr.openjdk.java.net/~serb/8059941/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/12ab3aed2ba5 Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004879.html Reviewers: Andrew Brygin, Phil Race 8057830: Crash in Java2D Queue Flusher, OGLSD_SetScratchSurface Bug: https://bugs.openjdk.java.net/browse/JDK-8057830 Webrev can be found at: http://cr.openjdk.java.net/~serb/Hendrik/8057830/webrev jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/61e00d0b6a23 Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004864.html Reviewers: Sergey Bylokhov, Denis Fokin Contributed-by: Hendrik Schreiber 8062164: Incorrect color conversion, when bicubic interpolation is used Bug: https://bugs.openjdk.java.net/browse/JDK-8062164 Webrev can be found at: http://cr.openjdk.java.net/~serb/8062164/webrev.03 jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/748091d834cf Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004913.html Reviewers: Jim Graham, Phil Race 7169583: JInternalFrame title not antialiased in Nimbus LaF Bug: https://bugs.openjdk.java.net/browse/JDK-7169583 Webrev can be found at: http://cr.openjdk.java.net/~serb/7169583/webrev.00 jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/6a096bc7b769 Review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004012.html Reviewers: Alexander Zvegintsev, Alexander Scherbatiy From eric.mccorkle at oracle.com Mon Nov 17 19:35:33 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 17 Nov 2014 14:35:33 -0500 Subject: [8u40] Request for approval for 806433: parameter_index for type annotation not updated after outer.this added In-Reply-To: <546A23F4.6090906@oracle.com> References: <546A2322.9000105@oracle.com> <546A23F4.6090906@oracle.com> Message-ID: <546A4E05.8000303@oracle.com> A significant portion of the review took place on the Crucible system; however, it focused on the new testing framework (ClassfileInspector.java). The patch applied cleanly, except for Constructor.java, as langtools SQE staff added more test cases to that file in 9, and these changes have not been backported. On 11/17/14 11:36, Se?n Coffey wrote: > Does this fix apply cleanly Eric and is there a review thread you can > point us to ? > > regards, > Sean. > > On 17/11/14 16:32, Eric McCorkle wrote: >> Bug report: https://bugs.openjdk.java.net/browse/JDK-8029012 >> >> Changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/aa9b6165ab12 > From calvin.cheung at oracle.com Mon Nov 17 19:40:33 2014 From: calvin.cheung at oracle.com (Calvin Cheung) Date: Mon, 17 Nov 2014 11:40:33 -0800 Subject: [8u40] Review request 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546A28F3.1010802@oracle.com> References: <546A28F3.1010802@oracle.com> Message-ID: <546A4F31.2040406@oracle.com> Hi Mandy, In 8u40, the jre/lib/ext dir still exists and containing nashorn.jar, javafx.jar, etc. Would those jar files be moved to a different dir? Some minor comments in arguments.cpp: lines 3470 and 3472 can be combined as follows: int nonEmptyDirs = check_non_empty_dirs(Arguments::get_endorsed_dir(), "endorsed"); before return JNI_ERR; at lines 3493 and 3503, the dir should be closed: os::closedir(dir); Calvin On 11/17/2014 8:57 AM, Mandy Chung wrote: > This requests both code review and 8u40 approval for: > https://bugs.openjdk.java.net/browse/JDK-8064667 > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ > > JEP 220 [1] proposes to remove the endorsed standards override > mechanism and extension mechanism. This patch adds a VM flag in 8u40 > to help identify any existing uses of these mechanisms so that users > can turn on the VM flag to help identify if they depend on the > endorsed standards override mechanism and extension mechanism and can > plan to prepare for the migration to a newer JDK release early on. > When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the > system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if > ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any > system extension directory contains JAR files. > > Thanks > Mandy > [1] http://openjdk.java.net/jeps/220 > > > From mandy.chung at oracle.com Mon Nov 17 19:58:39 2014 From: mandy.chung at oracle.com (Mandy Chung) Date: Mon, 17 Nov 2014 11:58:39 -0800 Subject: [8u40] Review request 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546A4F31.2040406@oracle.com> References: <546A28F3.1010802@oracle.com> <546A4F31.2040406@oracle.com> Message-ID: <546A536F.4050309@oracle.com> On 11/17/14 11:40 AM, Calvin Cheung wrote: > Hi Mandy, > > In 8u40, the jre/lib/ext dir still exists and containing nashorn.jar, > javafx.jar, etc. > Would those jar files be moved to a different dir? Good catch. No these jar files will stay in jre/lib/ext. I will revise the patch to detect if jre/lib/ext contains any jar files other than the ones JDK ships. > > Some minor comments in arguments.cpp: > lines 3470 and 3472 can be combined as follows: > int nonEmptyDirs = check_non_empty_dirs(Arguments::get_endorsed_dir(), > "endorsed"); > > before return JNI_ERR; at lines 3493 and 3503, the dir should be closed: > os::closedir(dir); > Will send out an updated webrev. thanks Mandy > Calvin > > On 11/17/2014 8:57 AM, Mandy Chung wrote: >> This requests both code review and 8u40 approval for: >> https://bugs.openjdk.java.net/browse/JDK-8064667 >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ >> >> JEP 220 [1] proposes to remove the endorsed standards override >> mechanism and extension mechanism. This patch adds a VM flag in 8u40 >> to help identify any existing uses of these mechanisms so that users >> can turn on the VM flag to help identify if they depend on the >> endorsed standards override mechanism and extension mechanism and can >> plan to prepare for the migration to a newer JDK release early on. >> When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the >> system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if >> ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any >> system extension directory contains JAR files. >> >> Thanks >> Mandy >> [1] http://openjdk.java.net/jeps/220 >> >> >> > From michael.fang at oracle.com Mon Nov 17 20:34:27 2014 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 17 Nov 2014 12:34:27 -0800 Subject: [8u40] Review request for 8055798: Japanese translation for a warning from javac looks incorrect. Message-ID: <546A5BD3.40707@oracle.com> [resend with proper release number in subject] Hi, Please help to code review the changes for the following CR: 8055798: Japanese translation for a warning from javac looks incorrect. https://bugs.openjdk.java.net/browse/JDK-8055798 The webrev is located at: http://cr.openjdk.java.net/~mfang/8055798/ thanks, -michael From sean.coffey at oracle.com Mon Nov 17 22:11:43 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 22:11:43 +0000 Subject: [8u40] Request for approval for 806433: parameter_index for type annotation not updated after outer.this added In-Reply-To: <546A4E05.8000303@oracle.com> References: <546A2322.9000105@oracle.com> <546A23F4.6090906@oracle.com> <546A4E05.8000303@oracle.com> Message-ID: <546A729F.20303@oracle.com> can you post your final 8u webrev here then ? Please get a peer review before pushing. Approved but subject to review. regards, Sean. On 17/11/2014 19:35, Eric McCorkle wrote: > A significant portion of the review took place on the Crucible system; > however, it focused on the new testing framework (ClassfileInspector.java). > > The patch applied cleanly, except for Constructor.java, as langtools SQE > staff added more test cases to that file in 9, and these changes have > not been backported. > > On 11/17/14 11:36, Se?n Coffey wrote: >> Does this fix apply cleanly Eric and is there a review thread you can >> point us to ? >> >> regards, >> Sean. >> >> On 17/11/14 16:32, Eric McCorkle wrote: >>> Bug report: https://bugs.openjdk.java.net/browse/JDK-8029012 >>> >>> Changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/aa9b6165ab12 From sean.coffey at oracle.com Mon Nov 17 22:17:03 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 22:17:03 +0000 Subject: [8u40] Request for approval for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type In-Reply-To: <546A23C6.1070607@oracle.com> References: <546A23C6.1070607@oracle.com> Message-ID: <546A73DF.5020403@oracle.com> Wrong bug ID in Subject Eric. I've corrected that. You've marked the 8u40 fix record as fixed and provided a JDK 9 changeset in bug report. It doesn't make sense. There is no 8055063 fix in 8u-dev yet. Please re-open the 8u40 bug report. Does this patch apply cleanly to the jdk8u-dev codebase ? regards, Sean. On 17/11/2014 16:35, Eric McCorkle wrote: > Bug report: https://bugs.openjdk.java.net/browse/JDK-8055063 > > Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/23e10e5df0b3 From sean.coffey at oracle.com Mon Nov 17 22:19:58 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 22:19:58 +0000 Subject: [8u-dev] Request for approval: 6302052, 8041734, 8029253, 8059943, 7148531, 8061456, 8059941, 8057830, 8062164, 7169583 In-Reply-To: <77581483-267a-46a5-a84d-ed109d09773e@default> References: <77581483-267a-46a5-a84d-ed109d09773e@default> Message-ID: <546A748E.2030206@oracle.com> Looks good. Thanks for the clear details. Approved. regards, Sean. On 17/11/2014 19:31, Sergey Bylokhov wrote: > Hello, > These are a direct back ports from jdk 9 to jdk 8u-dev. > > 6302052: Reference to nonexistant Class in javadoc > Bug: https://bugs.openjdk.java.net/browse/JDK-6302052 > Webrev can be found at: http://cr.openjdk.java.net/~serb/6302052/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b4924515f4ac > Review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-August/003786.html > Reviewers: Alexander Zvegintsev, Alexander Scherbatiy > > 8041734: JFrame in full screen mode leaves empty workspace after close > Bug: https://bugs.openjdk.java.net/browse/JDK-8041734 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8041734/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/54afdf196017 > Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-September/008535.html > Reviewers: Alexander Zvegintsev, Alexander Scherbatiy > > 8029253: [macosx] Performance problems with Retina display on Mac OS X > Bug: https://bugs.openjdk.java.net/browse/JDK-8029253 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8029253/webrev.04 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f8498246a197 > Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004870.html > Reviewers: Andrew Brygin, Phil Race > > 8059943: [macosx] Aqua LaF should use BI.TYPE_INT_ARGB_PRE for a better performance > Bug: https://bugs.openjdk.java.net/browse/JDK-8059943 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8059943/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/4108c46e4cea > Review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-October/003982.html > Reviewers: Alexander Scherbatiy, Alexander Zvegintsev > > 7148531: [macosx] In test, the window does not have time to resize before make a screenshot > Bug: https://bugs.openjdk.java.net/browse/JDK-7148531 > Webrev can be found at: http://cr.openjdk.java.net/~serb/7148531/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/ff6048f77891 > Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-October/008597.html > Reviewers: Alexander Scherbatiy, Alexander Zvegintsev > > 8061456: [OGL] Incorrect clip is used during sw->surface blit in xor mode > Bug: https://bugs.openjdk.java.net/browse/JDK-8061456 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8061456/webrev.03 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/be34425400ec > Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004906.html > Reviewers: Andrew Brygin, Phil Race > > 8059941: [D3D] The fix for JDK-8029253 should be ported to d3d pipeline > Bug: https://bugs.openjdk.java.net/browse/JDK-8059941 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8059941/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/12ab3aed2ba5 > Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004879.html > Reviewers: Andrew Brygin, Phil Race > > 8057830: Crash in Java2D Queue Flusher, OGLSD_SetScratchSurface > Bug: https://bugs.openjdk.java.net/browse/JDK-8057830 > Webrev can be found at: http://cr.openjdk.java.net/~serb/Hendrik/8057830/webrev > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/61e00d0b6a23 > Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004864.html > Reviewers: Sergey Bylokhov, Denis Fokin > Contributed-by: Hendrik Schreiber > > 8062164: Incorrect color conversion, when bicubic interpolation is used > Bug: https://bugs.openjdk.java.net/browse/JDK-8062164 > Webrev can be found at: http://cr.openjdk.java.net/~serb/8062164/webrev.03 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/748091d834cf > Review: http://mail.openjdk.java.net/pipermail/2d-dev/2014-October/004913.html > Reviewers: Jim Graham, Phil Race > > 7169583: JInternalFrame title not antialiased in Nimbus LaF > Bug: https://bugs.openjdk.java.net/browse/JDK-7169583 > Webrev can be found at: http://cr.openjdk.java.net/~serb/7169583/webrev.00 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/6a096bc7b769 > Review: http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004012.html > Reviewers: Alexander Zvegintsev, Alexander Scherbatiy From sean.coffey at oracle.com Mon Nov 17 22:28:03 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 17 Nov 2014 22:28:03 +0000 Subject: [8u communication] Approaching JDK 8 Updates milestone : 8u40 RDP2 Message-ID: <546A7673.20009@oracle.com> As per the preliminary 8u40 timeline [1], the 8u40 Rampdown 2 milestone is approaching. Please aim to have all 8u40 planned fixes addressed by the first week in December. The 8u40 RDP2 build is planned for the week of December 15th and fixes need to be in the team forests 1 week before that for PIT testing. Once we enter RDP2, we'll fork the JDK8u master forest to create a JDK 8u40 stabilization forest. Only showstopper bugs should be considered for fixing in 8u40 after that milestone. regards, Sean. [1] http://openjdk.java.net/projects/jdk8u/releases/8u40.html From lana.steuck at oracle.com Tue Nov 18 00:38:02 2014 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 17 Nov 2014 16:38:02 -0800 (PST) Subject: jdk8u-b15: jdk8u-dev Message-ID: <201411180038.sAI0c2j3018255@jano-app.us.oracle.com> http://hg.openjdk.java.net/jdk8u/jdk8u/rev/60d2bf063f7d http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/fc37699ddc0e http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/682a6c1aefd7 http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/31dac938108d http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/a278e39ba58d http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/ed46c05af257 http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/eb16b24e2eba http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/46bf2b74baf4 --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-8057893 client-libs JComboBox actionListener never receives "comboBoxEdited" from getActionCommand JDK-8062021 client-libs NPE in sun/lwawt/macosx/CPlatformWindow::toFront after JDK-8060146 JDK-8061392 client-libs PrinterJob NPE when drawing translucent image with null user clip JDK-8039444 client-libs Swing applications not being displayed properly JDK-8049198 client-libs [macosx] Incorrect thread access when showing splash screen JDK-8043869 client-libs [macosx] java -splash does not honor @2x hi dpi notation for retina support JDK-8064468 client-libs ownedWindowList access requires synchronization in Window.setAlwaysOnTop() method JDK-6904367 core-libs (coll) IdentityHashMap is resized before exceeding the expected maximum size JDK-8054029 core-libs (fc) FileChannel.size() returns 0 for block devices on Linux JDK-8042470 core-libs (fs) Path.register doesn't throw IllegalArgumentException if multiple OVERFLOW events are specified JDK-8042816 core-libs (fs) Path.register doesn't throw IllegalArgumentException if multiple OVERFLOW events are specified, part 2 JDK-8011537 core-libs (fs) Path.register(..) clears interrupt status of thread with no InterruptedException JDK-6853696 core-libs (ref) ReferenceQueue.remove(timeout) may return null even if timeout has not expired JDK-8062050 core-libs A method is considered caller sensitive, but it doesn't have the CallerSensitive annotation JDK-8062799 core-libs Binary logical expressions can have numeric types JDK-8040806 core-libs BitSet.toString() can throw IndexOutOfBoundsException JDK-8034032 core-libs Check src/macosx/native/java/util/prefs/MacOSXPreferencesFile.m for JNI pending issues JDK-8063036 core-libs Cosmetics: The recompile log produces double lines for some reason JDK-8064467 core-libs Deoptimization type information persistence doesn't work - "Failed to calculate version dir name" JDK-8062386 core-libs Different versions of nashorn use same code cache directory JDK-8062937 core-libs GlobalConstants produces wrong result with Object.defineProperty JDK-8062490 core-libs JDK-8061391 regresses typescript: OOME with too fat SparseArrayData instances JDK-8059443 core-libs Logical NOT operator throws NullPointerException for null Boolean return values JDK-8061959 core-libs Missing ArrayBuffer.isView() Method JDK-8064391 core-libs More thread safety problems in core reflection JDK-8060483 core-libs NPE with explicitCastArguments unboxing null JDK-8064707 core-libs Remove NativeArray link logic fields JDK-8060204 core-libs Remove all Joni and test Warnings JDK-7011804 core-libs SequenceInputStream with lots of empty substreams can cause StackOverflowError JDK-8061957 core-libs Some arithmetic operations have unnecessary widening JDK-8062381 core-libs String.prototype.charCodeAt called with invalid index throws ClassCastException JDK-8038333 core-libs TEST_BUG: java/lang/ref/EarlyTimeout.java fails with a non-adequate message JDK-8063037 core-libs Trivial bugfixing and exception reuse in ApplySpecialization JDK-8062308 core-libs b36 of 9 introduces regressions over b35 when running lyra JDK-8059311 core-libs com/sun/jndi/ldap/LdapTimeoutTest.java fails with exit_code == 0 JDK-8057825 core-libs emitted socket arg becomes null in avatar.js http tests JDK-8062624 core-libs java.lang.String methods not available on concatenated strings JDK-8038982 core-libs java/lang/ref/EarlyTimeout.java: elapsed time 981 is less than timeout 1000 JDK-8043476 core-libs java/util/BitSet/BSMethods.java failed with: java.lang.OutOfMemoryError: Java heap space JDK-8048913 core-libs java/util/logging/LoggingDeadlock2.java times out JDK-8062744 core-libs jdk.net.Sockets.setOption/getOption does not support IP_TOS JDK-8035312 core-libs push() on frozen array increases its length property JDK-8055319 core-svc Update JFR log dates JDK-8062957 hotspot Heap is not shrunk when deallocating under memory pressure JDK-8064338 hotspot JNI exception pending in jdk/src/closed/share/native/jdk/internal/instrumentation/Tracer.c JDK-8064716 hotspot TestHumongousShrinkHeap.java can not be run with -XX:+ExplicitGCInvokesConcurrent JDK-8036616 hotspot [TESTBUG] Embedded: sun/jvmstat/monitor/MonitoredVm/CR6672135.java should be launched with -XX:+UsePerfData JDK-8061300 hotspot [TESTBUG] closed/gc/TestMemoryPressureReactionDecommit.java still fails with OOM JDK-8063123 hotspot closed/com/oracle/jfr/io/TestInstrumentation.java failing with modular image build JDK-8062683 infrastructure Blacklist Cooperative Memory Management ("CMM") closed code JDK-8062585 other-libs Modify build to omit commercial features when DISABLE_COMMERCIAL_FEATURES is true JDK-8059516 other-libs RM API JavaDoc generation JDK-8061830 other-libs [asm] refresh internal ASM version v5.0.3 JDK-8063700 security-libs -Xcheck:jni changes cause many JCK failures in api/javax_crypto tests in SunPKCS11 JDK-8064507 security-libs Add closed/sun/security/rsa/TestLimits.java to the ProblemList JDK-8040812 security-libs Uninitialised memory in jdk/src/share/native/sun/security/ec/impl/mpi.c JDK-8049600 security-libs [TESTBUG] Some tests could not be changed to work under profiles and should be excluded JDK-8034031 security-libs [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m JDK-8057800 tools Method reference with generic type creates NPE when compiling JDK-8062608 xml BCEL corrupts debug data of methods that use generics JDK-8064516 xml BCEL still corrupts generic methods if bytecode offsets are modified JDK-8059327 xml XML parser returns corrupt attribute value From david.holmes at oracle.com Tue Nov 18 01:35:36 2014 From: david.holmes at oracle.com (David Holmes) Date: Tue, 18 Nov 2014 11:35:36 +1000 Subject: Review request for 8059492: Wrong spelling in assert: "Not initialied properly?" In-Reply-To: <546A3083.9060707@oracle.com> References: <546A3083.9060707@oracle.com> Message-ID: <546AA268.8050501@oracle.com> Alex, On 18/11/2014 3:29 AM, Alexander Harlap wrote: > Please help to code review the changes (trivial) for the following CR: > 8059492: Wrong spelling in assert: "Not initialied properly?" > https://bugs.openjdk.java.net/browse/JDK-8059492 > > The webrev is located at: > http://cr.openjdk.java.net/~aharlap/8059492/webrev.00/ > You've sent this to jdk8u-dev (though hotspot backports are handled directly by review on the appropriate hs mailing list), but your webrev is against 9. Where is this fix destined? Thanks, David > Testing completed: JPRT > > Alex From yuka.kamiya at oracle.com Tue Nov 18 04:36:48 2014 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Tue, 18 Nov 2014 13:36:48 +0900 Subject: [8u40] Review request for 8055798: Japanese translation for a warning from javac looks incorrect. In-Reply-To: <546A5BD3.40707@oracle.com> References: <546A5BD3.40707@oracle.com> Message-ID: <546ACCE0.2030608@oracle.com> Hi, The fix looks good to me. Thanks, -- Yuka On 2014/11/18 5:34, Michael Fang wrote: > [resend with proper release number in subject] > > Hi, > > Please help to code review the changes for the following CR: > 8055798: Japanese translation for a warning from javac looks incorrect. > https://bugs.openjdk.java.net/browse/JDK-8055798 > > The webrev is located at: > http://cr.openjdk.java.net/~mfang/8055798/ > > thanks, > > -michael From michael.fang at oracle.com Tue Nov 18 04:40:27 2014 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 17 Nov 2014 20:40:27 -0800 Subject: [8u40] Review request for 8055798: Japanese translation for a warning from javac looks incorrect. In-Reply-To: <546ACCE0.2030608@oracle.com> References: <546A5BD3.40707@oracle.com> <546ACCE0.2030608@oracle.com> Message-ID: <546ACDBB.9030407@oracle.com> Thanks Yuka. -michael On 14?11?17? 08:36 ??, Yuka Kamiya wrote: > Hi, > > The fix looks good to me. > > Thanks, > -- > Yuka > > > On 2014/11/18 5:34, Michael Fang wrote: >> [resend with proper release number in subject] >> >> Hi, >> >> Please help to code review the changes for the following CR: >> 8055798: Japanese translation for a warning from javac looks incorrect. >> https://bugs.openjdk.java.net/browse/JDK-8055798 >> >> The webrev is located at: >> http://cr.openjdk.java.net/~mfang/8055798/ >> >> thanks, >> >> -michael > From michael.fang at oracle.com Tue Nov 18 07:24:58 2014 From: michael.fang at oracle.com (Michael Fang) Date: Mon, 17 Nov 2014 23:24:58 -0800 Subject: [8u40] Request for approval for 8055798: Japanese translation for a warning from javac looks incorrect. Message-ID: <546AF44A.6040905@oracle.com> Hello JDK8u maintainers, Please approve bug fix 8055798 for 8u40 Bug report: https://bugs.openjdk.java.net/browse/JDK-8055798 Webrev: http://cr.openjdk.java.net/~mfang/8055798/ Review thread: [8u40] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002515.html thanks, -michael From sean.coffey at oracle.com Tue Nov 18 10:49:46 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 18 Nov 2014 10:49:46 +0000 Subject: [8u40] Request for approval for 8055798: Japanese translation for a warning from javac looks incorrect. In-Reply-To: <546AF44A.6040905@oracle.com> References: <546AF44A.6040905@oracle.com> Message-ID: <546B244A.70507@oracle.com> Approved. regards, Sean. On 18/11/14 07:24, Michael Fang wrote: > Hello JDK8u maintainers, > > Please approve bug fix 8055798 for 8u40 > > Bug report: https://bugs.openjdk.java.net/browse/JDK-8055798 > Webrev: http://cr.openjdk.java.net/~mfang/8055798/ > Review thread: [8u40] > http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002515.html > > thanks, > > -michael From eric.mccorkle at oracle.com Tue Nov 18 14:03:01 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 18 Nov 2014 09:03:01 -0500 Subject: [8u40] Request for approval for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type In-Reply-To: <546A73DF.5020403@oracle.com> References: <546A23C6.1070607@oracle.com> <546A73DF.5020403@oracle.com> Message-ID: <546B5195.1040208@oracle.com> So, hgupdater seemed to be doing some strange things. When I committed the changes to jdk9, it opened an 8u40 backport issue, then immediately closed it, and never closed the 9 issue. I'm not sure what's going on there. On 11/17/14 17:17, Se?n Coffey wrote: > Wrong bug ID in Subject Eric. I've corrected that. You've marked the > 8u40 fix record as fixed and provided a JDK 9 changeset in bug report. > It doesn't make sense. There is no 8055063 fix in 8u-dev yet. Please > re-open the 8u40 bug report. > > Does this patch apply cleanly to the jdk8u-dev codebase ? > > regards, > Sean. > > On 17/11/2014 16:35, Eric McCorkle wrote: >> Bug report: https://bugs.openjdk.java.net/browse/JDK-8055063 >> >> Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/23e10e5df0b3 > From sean.coffey at oracle.com Tue Nov 18 14:12:46 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 18 Nov 2014 14:12:46 +0000 Subject: [8u40] Request for approval for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type In-Reply-To: <546B5195.1040208@oracle.com> References: <546A23C6.1070607@oracle.com> <546A73DF.5020403@oracle.com> <546B5195.1040208@oracle.com> Message-ID: <546B53DE.5000109@oracle.com> hgupdater worked fine. You had the master fix version with fixVersion of 8u40 so the bot opened up a backport for JDK 9 and marked it resolved : https://bugs.openjdk.java.net/browse/JDK-8064474 You then reopened that backport bug for unknown reasons and added a dual fix version to the report [9, 8u40] (not allowed) - When the client team forest sync happened a few days later, the bot saw no 9 resolved record and had to open up a new 9 backport. Do not add more than one field to fixVersion. Use the backport mechanism if you wish to create a backport record : https://wiki.openjdk.java.net/display/general/JBS+Overview regards, Sean. On 18/11/14 14:03, Eric McCorkle wrote: > So, hgupdater seemed to be doing some strange things. When I committed > the changes to jdk9, it opened an 8u40 backport issue, then immediately > closed it, and never closed the 9 issue. I'm not sure what's going on > there. > > On 11/17/14 17:17, Se?n Coffey wrote: >> Wrong bug ID in Subject Eric. I've corrected that. You've marked the >> 8u40 fix record as fixed and provided a JDK 9 changeset in bug report. >> It doesn't make sense. There is no 8055063 fix in 8u-dev yet. Please >> re-open the 8u40 bug report. >> >> Does this patch apply cleanly to the jdk8u-dev codebase ? >> >> regards, >> Sean. >> >> On 17/11/2014 16:35, Eric McCorkle wrote: >>> Bug report: https://bugs.openjdk.java.net/browse/JDK-8055063 >>> >>> Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/23e10e5df0b3 From eric.mccorkle at oracle.com Tue Nov 18 14:17:53 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 18 Nov 2014 09:17:53 -0500 Subject: [8u40] Request for approval for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type In-Reply-To: <546A73DF.5020403@oracle.com> References: <546A23C6.1070607@oracle.com> <546A73DF.5020403@oracle.com> Message-ID: <546B5511.8070102@oracle.com> Patch applies cleanly. On 11/17/14 17:17, Se?n Coffey wrote: > Wrong bug ID in Subject Eric. I've corrected that. You've marked the > 8u40 fix record as fixed and provided a JDK 9 changeset in bug report. > It doesn't make sense. There is no 8055063 fix in 8u-dev yet. Please > re-open the 8u40 bug report. > > Does this patch apply cleanly to the jdk8u-dev codebase ? > > regards, > Sean. > > On 17/11/2014 16:35, Eric McCorkle wrote: >> Bug report: https://bugs.openjdk.java.net/browse/JDK-8055063 >> >> Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/23e10e5df0b3 > From sean.coffey at oracle.com Tue Nov 18 14:27:47 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 18 Nov 2014 14:27:47 +0000 Subject: [8u40] Request for approval for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type In-Reply-To: <546B5511.8070102@oracle.com> References: <546A23C6.1070607@oracle.com> <546A73DF.5020403@oracle.com> <546B5511.8070102@oracle.com> Message-ID: <546B5763.4000203@oracle.com> I've reopened the 8u40 bug record for you. Approved. regards, Sean. On 18/11/14 14:17, Eric McCorkle wrote: > Patch applies cleanly. > > On 11/17/14 17:17, Se?n Coffey wrote: >> Wrong bug ID in Subject Eric. I've corrected that. You've marked the >> 8u40 fix record as fixed and provided a JDK 9 changeset in bug report. >> It doesn't make sense. There is no 8055063 fix in 8u-dev yet. Please >> re-open the 8u40 bug report. >> >> Does this patch apply cleanly to the jdk8u-dev codebase ? >> >> regards, >> Sean. >> >> On 17/11/2014 16:35, Eric McCorkle wrote: >>> Bug report: https://bugs.openjdk.java.net/browse/JDK-8055063 >>> >>> Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/23e10e5df0b3 From erik.joelsson at oracle.com Tue Nov 18 15:18:05 2014 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 18 Nov 2014 16:18:05 +0100 Subject: [8u-dev] Request for approval for 8065183: Add --with-copyright-year option to configure Message-ID: <546B632D.4090509@oracle.com> Hello, Please approve the following backport to 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8065183 Review thread: http://mail.openjdk.java.net/pipermail/build-dev/2014-November/013661.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/35c9a2c8bc2d The patch applies cleanly except for generated-configure which naturally needs to be regenerated. /Erik From rob.mckenna at oracle.com Tue Nov 18 15:40:54 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 18 Nov 2014 15:40:54 +0000 Subject: [8u-dev] Request for approval for 8065183: Add --with-copyright-year option to configure In-Reply-To: <546B632D.4090509@oracle.com> References: <546B632D.4090509@oracle.com> Message-ID: <546B6886.7010902@oracle.com> Approved. -Rob On 18/11/14 15:18, Erik Joelsson wrote: > Hello, > > Please approve the following backport to 8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8065183 > Review thread: > http://mail.openjdk.java.net/pipermail/build-dev/2014-November/013661.html > JDK 9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/35c9a2c8bc2d > > The patch applies cleanly except for generated-configure which > naturally needs to be regenerated. > > /Erik > From henry.jen at oracle.com Tue Nov 18 19:42:19 2014 From: henry.jen at oracle.com (Henry Jen) Date: Tue, 18 Nov 2014 11:42:19 -0800 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 Message-ID: <546BA11B.3070509@oracle.com> Hi, This had been asked for several times, so I think we should backport it. I combined both changes as one backport of main bug, JDK-8028497. http://cr.openjdk.java.net/~henryjen/8065267/webrev/ Cheers, Henry From sean.coffey at oracle.com Wed Nov 19 10:03:54 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 19 Nov 2014 10:03:54 +0000 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 In-Reply-To: <546BA11B.3070509@oracle.com> References: <546BA11B.3070509@oracle.com> Message-ID: <546C6B0A.3030800@oracle.com> Henry, How are you going to indicate that JDK-8036614 is fixed in 8u40 ? Can you import 2 changesets and keep history similar to that in JDK 9 ? You'll need to get a review first in any case if you're combining changes into one changesets. Regards, Sean. On 18/11/14 19:42, Henry Jen wrote: > Hi, > > This had been asked for several times, so I think we should backport > it. I combined both changes as one backport of main bug, JDK-8028497. > > http://cr.openjdk.java.net/~henryjen/8065267/webrev/ > > Cheers, > Henry From daniel.daugherty at oracle.com Wed Nov 19 14:59:49 2014 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 19 Nov 2014 07:59:49 -0700 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 In-Reply-To: <546C6B0A.3030800@oracle.com> References: <546BA11B.3070509@oracle.com> <546C6B0A.3030800@oracle.com> Message-ID: <546CB065.2030003@oracle.com> Just in case anyone else gets confused: JDK-8028497 -> JDK-80284007 JDK-8028497 was already backported to JDK8u by Coleen back in April... Dan On 11/19/14 3:03 AM, Se?n Coffey wrote: > Henry, > > How are you going to indicate that JDK-8036614 is fixed in 8u40 ? Can > you import 2 changesets and keep history similar to that in JDK 9 ? > You'll need to get a review first in any case if you're combining > changes into one changesets. > > Regards, > Sean. > > On 18/11/14 19:42, Henry Jen wrote: >> Hi, >> >> This had been asked for several times, so I think we should backport >> it. I combined both changes as one backport of main bug, JDK-8028497. >> >> http://cr.openjdk.java.net/~henryjen/8065267/webrev/ >> >> Cheers, >> Henry > > > From daniel.daugherty at oracle.com Wed Nov 19 15:01:50 2014 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Wed, 19 Nov 2014 08:01:50 -0700 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 In-Reply-To: <546CB065.2030003@oracle.com> References: <546BA11B.3070509@oracle.com> <546C6B0A.3030800@oracle.com> <546CB065.2030003@oracle.com> Message-ID: <546CB0DE.1030203@oracle.com> On 11/19/14 7:59 AM, Daniel D. Daugherty wrote: > Just in case anyone else gets confused: > > JDK-8028497 -> JDK-80284007 And then I typo it also: JDK-8028497 -> JDK-8028407 Dan > > JDK-8028497 was already backported to JDK8u by Coleen back in April... > > Dan > > > On 11/19/14 3:03 AM, Se?n Coffey wrote: >> Henry, >> >> How are you going to indicate that JDK-8036614 is fixed in 8u40 ? Can >> you import 2 changesets and keep history similar to that in JDK 9 ? >> You'll need to get a review first in any case if you're combining >> changes into one changesets. >> >> Regards, >> Sean. >> >> On 18/11/14 19:42, Henry Jen wrote: >>> Hi, >>> >>> This had been asked for several times, so I think we should backport >>> it. I combined both changes as one backport of main bug, JDK-8028497. >>> >>> http://cr.openjdk.java.net/~henryjen/8065267/webrev/ >>> >>> Cheers, >>> Henry >> >> >> > From petr.pchelko at oracle.com Wed Nov 19 14:48:02 2014 From: petr.pchelko at oracle.com (Petr Pchelko) Date: Wed, 19 Nov 2014 18:48:02 +0400 Subject: [8u40] Request for approval: JDK-8058193 [macosx] Potential incomplete fix for JDK-8031485 Message-ID: Hello. This is a request for approval to backport a fix to the jdk8u-dev repository. The bug: https://bugs.openjdk.java.net/browse/JDK-8058193 The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/2f79e5e1359b The review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008714.html The fix for JDK8u is similar to the JDK9 one, except the workspace layout is different. With best regards. Petr. From rob.mckenna at oracle.com Wed Nov 19 15:50:28 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 19 Nov 2014 15:50:28 +0000 Subject: [8u40] Request for approval: JDK-8058193 [macosx] Potential incomplete fix for JDK-8031485 In-Reply-To: References: Message-ID: <546CBC44.1090503@oracle.com> Approved assuming the patch applies cleanly after shuffling. -Rob On 19/11/14 14:48, Petr Pchelko wrote: > Hello. > > This is a request for approval to backport a fix to the jdk8u-dev repository. > > The bug: > https://bugs.openjdk.java.net/browse/JDK-8058193 > The fix: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/2f79e5e1359b > The review: > http://mail.openjdk.java.net/pipermail/awt-dev/2014-November/008714.html > > The fix for JDK8u is similar to the JDK9 one, except the workspace layout is different. > > With best regards. Petr. From henry.jen at oracle.com Wed Nov 19 18:25:00 2014 From: henry.jen at oracle.com (Henry Jen) Date: Wed, 19 Nov 2014 10:25:00 -0800 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 In-Reply-To: <546CB0DE.1030203@oracle.com> References: <546BA11B.3070509@oracle.com> <546C6B0A.3030800@oracle.com> <546CB065.2030003@oracle.com> <546CB0DE.1030203@oracle.com> Message-ID: <546CE07C.7040500@oracle.com> Thanks, Dan. Sorry for the confusion. Cheers, Henry On 11/19/2014 07:01 AM, Daniel D. Daugherty wrote: > On 11/19/14 7:59 AM, Daniel D. Daugherty wrote: >> Just in case anyone else gets confused: >> >> JDK-8028497 -> JDK-80284007 > > And then I typo it also: > > JDK-8028497 -> JDK-8028407 > > Dan > > >> >> JDK-8028497 was already backported to JDK8u by Coleen back in April... >> >> Dan >> >> >> On 11/19/14 3:03 AM, Se?n Coffey wrote: >>> Henry, >>> >>> How are you going to indicate that JDK-8036614 is fixed in 8u40 ? Can >>> you import 2 changesets and keep history similar to that in JDK 9 ? >>> You'll need to get a review first in any case if you're combining >>> changes into one changesets. >>> >>> Regards, >>> Sean. >>> >>> On 18/11/14 19:42, Henry Jen wrote: >>>> Hi, >>>> >>>> This had been asked for several times, so I think we should backport >>>> it. I combined both changes as one backport of main bug, JDK-8028497. >>>> >>>> http://cr.openjdk.java.net/~henryjen/8065267/webrev/ >>>> >>>> Cheers, >>>> Henry >>> >>> >>> >> > From henry.jen at oracle.com Wed Nov 19 18:33:38 2014 From: henry.jen at oracle.com (Henry Jen) Date: Wed, 19 Nov 2014 10:33:38 -0800 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 In-Reply-To: <546C6B0A.3030800@oracle.com> References: <546BA11B.3070509@oracle.com> <546C6B0A.3030800@oracle.com> Message-ID: <546CE282.2010800@oracle.com> On 11/19/2014 02:03 AM, Se?n Coffey wrote: > Henry, > > How are you going to indicate that JDK-8036614 is fixed in 8u40 ? Can > you import 2 changesets and keep history similar to that in JDK 9 ? > You'll need to get a review first in any case if you're combining > changes into one changesets. > OK, let's do it as separate backport. So I assume I can push via jprt once I got approval to backport both JDK-8028407 and JDK-8036614? Cheers, Henry > Regards, > Sean. > > On 18/11/14 19:42, Henry Jen wrote: >> Hi, >> >> This had been asked for several times, so I think we should backport >> it. I combined both changes as one backport of main bug, JDK-8028497. >> >> http://cr.openjdk.java.net/~henryjen/8065267/webrev/ >> >> Cheers, >> Henry > From ivan.gerasimov at oracle.com Wed Nov 19 20:16:50 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 19 Nov 2014 23:16:50 +0300 Subject: [8u40] Request for Approval: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming Message-ID: <546CFAB2.1090204@oracle.com> Hello! I've got a request to backport this recent fix. Would you please approve it? Bug: https://bugs.openjdk.java.net/browse/JDK-8050983 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/488295a6b59c Review: http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008756.html Sincerely yours, Ivan From ivan.gerasimov at oracle.com Wed Nov 19 20:18:54 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 19 Nov 2014 23:18:54 +0300 Subject: [8u40] Request for Approval: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming In-Reply-To: <546CFAB2.1090204@oracle.com> References: <546CFAB2.1090204@oracle.com> Message-ID: <546CFB2E.2030200@oracle.com> Meant to say the patch applies cleanly after unshuffling. On 19.11.2014 23:16, Ivan Gerasimov wrote: > Hello! > > I've got a request to backport this recent fix. > Would you please approve it? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8050983 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/488295a6b59c > Review: > http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008756.html > > Sincerely yours, > Ivan From roger.riggs at oracle.com Wed Nov 19 20:47:35 2014 From: roger.riggs at oracle.com (roger riggs) Date: Wed, 19 Nov 2014 15:47:35 -0500 Subject: RFR 8u40: 8065397: Remove ExtendedPlatformComponent.java from EXFILES list Message-ID: <546D01E7.1020508@oracle.com> Please review a cleanup for the 8u40 build. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-build-8065353/ Thanks, Roger From mandy.chung at oracle.com Wed Nov 19 20:53:53 2014 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 19 Nov 2014 12:53:53 -0800 Subject: RFR 8u40: 8065397: Remove ExtendedPlatformComponent.java from EXFILES list In-Reply-To: <546D01E7.1020508@oracle.com> References: <546D01E7.1020508@oracle.com> Message-ID: <546D0361.5020703@oracle.com> On 11/19/2014 12:47 PM, roger riggs wrote: > Please review a cleanup for the 8u40 build. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-build-8065353/ Looks okay to me. Are you also asking for 8u40 putback approval as well? Or maybe you are thinking to send a separate 8u40 request? Mandy From mandy.chung at oracle.com Wed Nov 19 21:10:54 2014 From: mandy.chung at oracle.com (Mandy Chung) Date: Wed, 19 Nov 2014 13:10:54 -0800 Subject: [8u40] Putback request for 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546A28F3.1010802@oracle.com> References: <546A28F3.1010802@oracle.com> Message-ID: <546D075D.8050601@oracle.com> Coleen and Calvin from runtime team have reviewed and approved this fix. I notice that jdk8u-dev got dropped in their review [1]. May I get the 8u40 approval to putback this change? Updated webrev: http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.02 Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013312.html On 11/17/2014 8:57 AM, Mandy Chung wrote: > This requests both code review and 8u40 approval for: > https://bugs.openjdk.java.net/browse/JDK-8064667 > > Webrev: > http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ > > JEP 220 [1] proposes to remove the endorsed standards override > mechanism and extension mechanism. This patch adds a VM flag in 8u40 > to help identify any existing uses of these mechanisms so that users > can turn on the VM flag to help identify if they depend on the > endorsed standards override mechanism and extension mechanism and can > plan to prepare for the migration to a newer JDK release early on. > When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the > system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if > ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any > system extension directory contains JAR files. > > Thanks > Mandy > [1] http://openjdk.java.net/jeps/220 > > > From naoto.sato at oracle.com Wed Nov 19 21:37:30 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 19 Nov 2014 13:37:30 -0800 Subject: [8u40] Putback request for 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546D075D.8050601@oracle.com> References: <546A28F3.1010802@oracle.com> <546D075D.8050601@oracle.com> Message-ID: <546D0D9A.70406@oracle.com> Since you've already got the code review done specifically for 8u, you are good to go. Naoto On 11/19/14, 1:10 PM, Mandy Chung wrote: > Coleen and Calvin from runtime team have reviewed and approved this > fix. I notice that jdk8u-dev got dropped in their review [1]. > > May I get the 8u40 approval to putback this change? > > Updated webrev: > http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.02 > > Thanks > Mandy > [1] > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013312.html > > > On 11/17/2014 8:57 AM, Mandy Chung wrote: >> This requests both code review and 8u40 approval for: >> https://bugs.openjdk.java.net/browse/JDK-8064667 >> >> Webrev: >> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ >> >> JEP 220 [1] proposes to remove the endorsed standards override >> mechanism and extension mechanism. This patch adds a VM flag in 8u40 >> to help identify any existing uses of these mechanisms so that users >> can turn on the VM flag to help identify if they depend on the >> endorsed standards override mechanism and extension mechanism and can >> plan to prepare for the migration to a newer JDK release early on. >> When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the >> system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if >> ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any >> system extension directory contains JAR files. >> >> Thanks >> Mandy >> [1] http://openjdk.java.net/jeps/220 >> >> >> > From rob.mckenna at oracle.com Wed Nov 19 22:23:33 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 19 Nov 2014 22:23:33 +0000 Subject: [8u40] Request for Approval: 8050983: Misplaced parentheses in sun.net.www.http.HttpClient break HTTP PUT streaming In-Reply-To: <546CFB2E.2030200@oracle.com> References: <546CFAB2.1090204@oracle.com> <546CFB2E.2030200@oracle.com> Message-ID: <546D1865.3040207@oracle.com> Approved. -Rob On 19/11/14 20:18, Ivan Gerasimov wrote: > Meant to say the patch applies cleanly after unshuffling. > > On 19.11.2014 23:16, Ivan Gerasimov wrote: >> Hello! >> >> I've got a request to backport this recent fix. >> Would you please approve it? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8050983 >> Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/488295a6b59c >> Review: >> http://mail.openjdk.java.net/pipermail/net-dev/2014-November/008756.html >> >> Sincerely yours, >> Ivan > From naoto.sato at oracle.com Wed Nov 19 22:33:31 2014 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 19 Nov 2014 14:33:31 -0800 Subject: [8u40] Putback request for 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546D0D9A.70406@oracle.com> References: <546A28F3.1010802@oracle.com> <546D075D.8050601@oracle.com> <546D0D9A.70406@oracle.com> Message-ID: <546D1ABB.6090709@oracle.com> This was somewhat misleading, but take it as an "approval." Naoto On 11/19/14, 1:37 PM, Naoto Sato wrote: > Since you've already got the code review done specifically for 8u, you > are good to go. > > Naoto > > On 11/19/14, 1:10 PM, Mandy Chung wrote: >> Coleen and Calvin from runtime team have reviewed and approved this >> fix. I notice that jdk8u-dev got dropped in their review [1]. >> >> May I get the 8u40 approval to putback this change? >> >> Updated webrev: >> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.02 >> >> Thanks >> Mandy >> [1] >> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013312.html >> >> >> >> On 11/17/2014 8:57 AM, Mandy Chung wrote: >>> This requests both code review and 8u40 approval for: >>> https://bugs.openjdk.java.net/browse/JDK-8064667 >>> >>> Webrev: >>> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ >>> >>> JEP 220 [1] proposes to remove the endorsed standards override >>> mechanism and extension mechanism. This patch adds a VM flag in 8u40 >>> to help identify any existing uses of these mechanisms so that users >>> can turn on the VM flag to help identify if they depend on the >>> endorsed standards override mechanism and extension mechanism and can >>> plan to prepare for the migration to a newer JDK release early on. >>> When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the >>> system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if >>> ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any >>> system extension directory contains JAR files. >>> >>> Thanks >>> Mandy >>> [1] http://openjdk.java.net/jeps/220 >>> >>> >>> >> From sean.coffey at oracle.com Thu Nov 20 09:11:13 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 20 Nov 2014 09:11:13 +0000 Subject: [8u-dev] equest for approval: JDK-8065267 backport of JDK-8028497 and JDK-8036614 In-Reply-To: <546CE282.2010800@oracle.com> References: <546BA11B.3070509@oracle.com> <546C6B0A.3030800@oracle.com> <546CE282.2010800@oracle.com> Message-ID: <546DB031.9020105@oracle.com> On 19/11/2014 18:33, Henry Jen wrote: > On 11/19/2014 02:03 AM, Se?n Coffey wrote: >> Henry, >> >> How are you going to indicate that JDK-8036614 is fixed in 8u40 ? Can >> you import 2 changesets and keep history similar to that in JDK 9 ? >> You'll need to get a review first in any case if you're combining >> changes into one changesets. >> > > OK, let's do it as separate backport. So I assume I can push via jprt > once I got approval to backport both JDK-8028407 and JDK-8036614? Consider this approved if the JDK 9 patches apply cleanly (post any modular path unshuffling). You'll need to add noreg-build labels to the bug reports also. regards, Sean. > > Cheers, > Henry > >> Regards, >> Sean. >> >> On 18/11/14 19:42, Henry Jen wrote: >>> Hi, >>> >>> This had been asked for several times, so I think we should backport >>> it. I combined both changes as one backport of main bug, JDK-8028497. >>> >>> http://cr.openjdk.java.net/~henryjen/8065267/webrev/ >>> >>> Cheers, >>> Henry >> From sean.coffey at oracle.com Thu Nov 20 09:21:41 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 20 Nov 2014 09:21:41 +0000 Subject: [8u40] Putback request for 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546D1ABB.6090709@oracle.com> References: <546A28F3.1010802@oracle.com> <546D075D.8050601@oracle.com> <546D0D9A.70406@oracle.com> <546D1ABB.6090709@oracle.com> Message-ID: <546DB2A5.7060209@oracle.com> Is a CCC required for this change Mandy ? regards, Sean. On 19/11/2014 22:33, Naoto Sato wrote: > This was somewhat misleading, but take it as an "approval." > > Naoto > > On 11/19/14, 1:37 PM, Naoto Sato wrote: >> Since you've already got the code review done specifically for 8u, you >> are good to go. >> >> Naoto >> >> On 11/19/14, 1:10 PM, Mandy Chung wrote: >>> Coleen and Calvin from runtime team have reviewed and approved this >>> fix. I notice that jdk8u-dev got dropped in their review [1]. >>> >>> May I get the 8u40 approval to putback this change? >>> >>> Updated webrev: >>> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.02 >>> >>> Thanks >>> Mandy >>> [1] >>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013312.html >>> >>> >>> >>> >>> On 11/17/2014 8:57 AM, Mandy Chung wrote: >>>> This requests both code review and 8u40 approval for: >>>> https://bugs.openjdk.java.net/browse/JDK-8064667 >>>> >>>> Webrev: >>>> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ >>>> >>>> JEP 220 [1] proposes to remove the endorsed standards override >>>> mechanism and extension mechanism. This patch adds a VM flag in 8u40 >>>> to help identify any existing uses of these mechanisms so that users >>>> can turn on the VM flag to help identify if they depend on the >>>> endorsed standards override mechanism and extension mechanism and can >>>> plan to prepare for the migration to a newer JDK release early on. >>>> When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the >>>> system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if >>>> ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any >>>> system extension directory contains JAR files. >>>> >>>> Thanks >>>> Mandy >>>> [1] http://openjdk.java.net/jeps/220 >>>> >>>> >>>> >>> From mandy.chung at oracle.com Thu Nov 20 17:25:09 2014 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 20 Nov 2014 09:25:09 -0800 Subject: [8u40] Putback request for 8064667: Provide support to help identify use of endorsed standards and extension mechanism In-Reply-To: <546DB2A5.7060209@oracle.com> References: <546A28F3.1010802@oracle.com> <546D075D.8050601@oracle.com> <546D0D9A.70406@oracle.com> <546D1ABB.6090709@oracle.com> <546DB2A5.7060209@oracle.com> Message-ID: <546E23F5.6010006@oracle.com> I should file a CCC (thanks for the reminder) and this option should be documented in the release note or some document. Mandy On 11/20/14 1:21 AM, Se?n Coffey wrote: > Is a CCC required for this change Mandy ? > > regards, > Sean. > > On 19/11/2014 22:33, Naoto Sato wrote: >> This was somewhat misleading, but take it as an "approval." >> >> Naoto >> >> On 11/19/14, 1:37 PM, Naoto Sato wrote: >>> Since you've already got the code review done specifically for 8u, you >>> are good to go. >>> >>> Naoto >>> >>> On 11/19/14, 1:10 PM, Mandy Chung wrote: >>>> Coleen and Calvin from runtime team have reviewed and approved this >>>> fix. I notice that jdk8u-dev got dropped in their review [1]. >>>> >>>> May I get the 8u40 approval to putback this change? >>>> >>>> Updated webrev: >>>> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.02 >>>> >>>> Thanks >>>> Mandy >>>> [1] >>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2014-November/013312.html >>>> >>>> >>>> >>>> >>>> On 11/17/2014 8:57 AM, Mandy Chung wrote: >>>>> This requests both code review and 8u40 approval for: >>>>> https://bugs.openjdk.java.net/browse/JDK-8064667 >>>>> >>>>> Webrev: >>>>> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/ >>>>> >>>>> JEP 220 [1] proposes to remove the endorsed standards override >>>>> mechanism and extension mechanism. This patch adds a VM flag in 8u40 >>>>> to help identify any existing uses of these mechanisms so that users >>>>> can turn on the VM flag to help identify if they depend on the >>>>> endorsed standards override mechanism and extension mechanism and can >>>>> plan to prepare for the migration to a newer JDK release early on. >>>>> When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the >>>>> system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if >>>>> ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any >>>>> system extension directory contains JAR files. >>>>> >>>>> Thanks >>>>> Mandy >>>>> [1] http://openjdk.java.net/jeps/220 >>>>> >>>>> >>>>> >>>> > From bengt.rutisson at oracle.com Fri Nov 21 09:10:59 2014 From: bengt.rutisson at oracle.com (Bengt Rutisson) Date: Fri, 21 Nov 2014 10:10:59 +0100 Subject: Result: CFV: New JDK8u Committer: Stefan Johansson In-Reply-To: <545A07AE.6040003@oracle.com> References: <545A07AE.6040003@oracle.com> Message-ID: <546F01A3.9010202@oracle.com> Voting for Stefan Johansson is now closed. Yes: 12 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Bengt From hannes.wallnoefer at oracle.com Fri Nov 21 17:37:33 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 21 Nov 2014 18:37:33 +0100 Subject: [8u40] Request for approval: JDK-8064789: Nashorn should just warn on code store instantiation error Message-ID: <546F785D.30408@oracle.com> Please approve backport of JDK-8064789 to 8u40. The patch applies cleanly to 8u40 after fixing path names. Bug: https://bugs.openjdk.java.net/browse/JDK-8064789 Webrev: http://cr.openjdk.java.net/~hannesw/8064789/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003853.html Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/ac3ab0a5be8e Thanks, Hannes From rob.mckenna at oracle.com Fri Nov 21 17:42:33 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 21 Nov 2014 17:42:33 +0000 Subject: [8u40] Request for approval: JDK-8064789: Nashorn should just warn on code store instantiation error In-Reply-To: <546F785D.30408@oracle.com> References: <546F785D.30408@oracle.com> Message-ID: <546F7989.3010100@oracle.com> Approved. Please add an appropriate noreg label. -Rob On 21/11/14 17:37, Hannes Wallnoefer wrote: > Please approve backport of JDK-8064789 to 8u40. > > The patch applies cleanly to 8u40 after fixing path names. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064789 > Webrev: http://cr.openjdk.java.net/~hannesw/8064789/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003853.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/ac3ab0a5be8e > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Fri Nov 21 17:55:30 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 21 Nov 2014 18:55:30 +0100 Subject: [8u40] Request for approval: JDK-8064789: Nashorn should just warn on code store instantiation error In-Reply-To: <546F7989.3010100@oracle.com> References: <546F785D.30408@oracle.com> <546F7989.3010100@oracle.com> Message-ID: <546F7C92.6070809@oracle.com> Thanks Rob. I added the noreg-trivial label. Hannes Am 2014-11-21 um 18:42 schrieb Rob McKenna: > Approved. Please add an appropriate noreg label. > > -Rob > > On 21/11/14 17:37, Hannes Wallnoefer wrote: >> Please approve backport of JDK-8064789 to 8u40. >> >> The patch applies cleanly to 8u40 after fixing path names. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8064789 >> Webrev: http://cr.openjdk.java.net/~hannesw/8064789/ >> Review thread: >> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003853.html >> Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/ac3ab0a5be8e >> >> Thanks, >> Hannes > From hannes.wallnoefer at oracle.com Fri Nov 21 18:14:46 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 21 Nov 2014 19:14:46 +0100 Subject: [8u40] Request for approval: JDK-8057691: Nashorn: let & const declarations are not shared between scripts Message-ID: <546F8116.8070909@oracle.com> JDK-8057691: Nashorn: let & const declarations are not shared between scripts Please approve backport of JDK-8057691 to 8u40. Bug: https://bugs.openjdk.java.net/browse/JDK-8057691 Webrev: http://cr.openjdk.java.net/~hannesw/8057691/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003877.html Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559 The patch applies cleanly to 8u40 after fixing path names except for the change in jdk/nashorn/internal/parser/Parser.java. However, that change is quite easy to reconstruct as I just undid a change introduced in JDK-8051889. Change to Parser.java in JDK9: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559#l4.7 Change that needs to be undone in JDK8: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/b7a2db4de254#l13.26 Change backported to JDK8u-dev: http://cr.openjdk.java.net/~hannesw/8057691/webrev-8u-dev/src/jdk/nashorn/internal/parser/Parser.java.udiff.html Thanks, Hannes From rob.mckenna at oracle.com Fri Nov 21 18:34:53 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 21 Nov 2014 18:34:53 +0000 Subject: [8u40] Request for approval: JDK-8057691: Nashorn: let & const declarations are not shared between scripts In-Reply-To: <546F8116.8070909@oracle.com> References: <546F8116.8070909@oracle.com> Message-ID: <546F85CD.1080203@oracle.com> Hi Hannes, approved assuming any 8 specific changes have been codereviewed. -Rob On 21/11/14 18:14, Hannes Wallnoefer wrote: > JDK-8057691: Nashorn: let & const declarations are not shared between > scripts > > Please approve backport of JDK-8057691 to 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8057691 > Webrev: http://cr.openjdk.java.net/~hannesw/8057691/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003877.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559 > > The patch applies cleanly to 8u40 after fixing path names except for > the change in jdk/nashorn/internal/parser/Parser.java. > However, that change is quite easy to reconstruct as I just undid a > change introduced in JDK-8051889. > > Change to Parser.java in JDK9: > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559#l4.7 > Change that needs to be undone in JDK8: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/b7a2db4de254#l13.26 > Change backported to JDK8u-dev: > http://cr.openjdk.java.net/~hannesw/8057691/webrev-8u-dev/src/jdk/nashorn/internal/parser/Parser.java.udiff.html > > Thanks, > Hannes From hannes.wallnoefer at oracle.com Fri Nov 21 19:05:10 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 21 Nov 2014 20:05:10 +0100 Subject: [8u40] Request for approval: JDK-8057691: Nashorn: let & const declarations are not shared between scripts In-Reply-To: <546F85CD.1080203@oracle.com> References: <546F8116.8070909@oracle.com> <546F85CD.1080203@oracle.com> Message-ID: <546F8CE6.30504@oracle.com> Thanks Rob, I'll get the reviews for the 8-specific changes before pushing. Hannes Am 2014-11-21 um 19:34 schrieb Rob McKenna: > Hi Hannes, approved assuming any 8 specific changes have been > codereviewed. > > -Rob > > On 21/11/14 18:14, Hannes Wallnoefer wrote: >> JDK-8057691: Nashorn: let & const declarations are not shared between >> scripts >> >> Please approve backport of JDK-8057691 to 8u40. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8057691 >> Webrev: http://cr.openjdk.java.net/~hannesw/8057691/ >> Review thread: >> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003877.html >> Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559 >> >> The patch applies cleanly to 8u40 after fixing path names except for >> the change in jdk/nashorn/internal/parser/Parser.java. >> However, that change is quite easy to reconstruct as I just undid a >> change introduced in JDK-8051889. >> >> Change to Parser.java in JDK9: >> http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559#l4.7 >> Change that needs to be undone in JDK8: >> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/b7a2db4de254#l13.26 >> Change backported to JDK8u-dev: >> http://cr.openjdk.java.net/~hannesw/8057691/webrev-8u-dev/src/jdk/nashorn/internal/parser/Parser.java.udiff.html >> >> Thanks, >> Hannes > From Sergey.Bylokhov at oracle.com Fri Nov 21 19:10:49 2014 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 21 Nov 2014 22:10:49 +0300 Subject: [8u-dev] Request for approval: 8034085, 8034164 Message-ID: <546F8E39.4060505@oracle.com> Hello, These are a direct back ports from jdk 9 to jdk 8u-dev. 8034085: Do not prefer indexed properties Bug: https://bugs.openjdk.java.net/browse/JDK-8034085 Webrev can be found at: http://cr.openjdk.java.net/~malenkov/8034085.9.0/ jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/51fc11696252 Review: http://mail.openjdk.java.net/pipermail/beans-dev/2014-February/000076.html Reviewers: Alexander Scherbatiy 8034164: Introspector ignores indexed part of the property sometimes Bug: https://bugs.openjdk.java.net/browse/JDK-8034164 Webrev can be found at: http://cr.openjdk.java.net/~malenkov/8034164.9.0/ jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f8d85eeb295e Review: http://mail.openjdk.java.net/pipermail/beans-dev/2014-February/000073.html Reviewers: Alexander Scherbatiy -- Best regards, Sergey. From rob.mckenna at oracle.com Fri Nov 21 21:04:37 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 21 Nov 2014 21:04:37 +0000 Subject: [8u-dev] Request for approval: 8034085, 8034164 In-Reply-To: <546F8E39.4060505@oracle.com> References: <546F8E39.4060505@oracle.com> Message-ID: <546FA8E5.7020401@oracle.com> Approved. -Rob On 21/11/14 19:10, Sergey Bylokhov wrote: > Hello, > These are a direct back ports from jdk 9 to jdk 8u-dev. > > 8034085: Do not prefer indexed properties > Bug: https://bugs.openjdk.java.net/browse/JDK-8034085 > Webrev can be found at: http://cr.openjdk.java.net/~malenkov/8034085.9.0/ > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/51fc11696252 > Review: > http://mail.openjdk.java.net/pipermail/beans-dev/2014-February/000076.html > Reviewers: Alexander Scherbatiy > > 8034164: Introspector ignores indexed part of the property sometimes > Bug: https://bugs.openjdk.java.net/browse/JDK-8034164 > Webrev can be found at: http://cr.openjdk.java.net/~malenkov/8034164.9.0/ > jdk9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f8d85eeb295e > Review: > http://mail.openjdk.java.net/pipermail/beans-dev/2014-February/000073.html > Reviewers: Alexander Scherbatiy > From alejandro.murillo at oracle.com Fri Nov 21 22:23:04 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 21 Nov 2014 15:23:04 -0700 Subject: [8u40] Request for approval for bulk integration of hs25.40-b20 Message-ID: <546FBB48.60202@oracle.com> Requesting approval to integrate hs25.40-b20 into jdk8u40-b16. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b20-jdk8u40-b16.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8033602: wrong stabs data in libjvm.debuginfo on JDK 8 - SPARC 8034005: cannot debug in synchronizer.o or objectMonitor.o on Solaris X86 8048169: Change 8037816 breaks HS build on PPC64 and CPP-Interpreter platforms 8054008: Using -XX:-LazyBootClassLoader crashes with ACCESS_VIOLATION on Win 64bit. 8056049: getProcessCpuLoad() stops working in one process when a different process exits 8056071: compiler/whitebox/IsMethodCompilableTest.java fails with 'method() is not compilable after 3 iterations' 8057622: java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest: SEGV inside compiled code (sparc) 8058209: Race in G1 card scanning could allow scanning of memory covered by PLABs 8058251: assert(_count > 0) failed: Negative counter when running runtime/NMT/MallocTrackingVerify.java 8059131: sawindbg.dll is not compiled with /SAFESEH 8059803: Update use of GetVersionEx to get correct Windows version in hs_err files 8060467: CMS: small OldPLABSize and -XX:-ResizePLAB cause assert(ResizePLAB || n_blks == OldPLABSize) failed: Error 8061969: [TESTBUG] MallocSiteHashOverflow.java should be enabled for 32-bit platforms 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes 8062247: [TESTBUG] Allow WhiteBox test to access JVM offsets 8062870: src/share/vm/services/mallocTracker.hpp:64 assert(_count > 0) failed: Negative counter 8062950: Bug in locking code when UseOptoBiasInlining is disabled: assert(dmw->is_neutral()) failed: invariant 8064361: new hotspot build - hs25.40-b19 8064375: Change certain errors to warnings in CDS output. 8064556: G1: ParallelGCThreads=0 may cause assert(!MetadataOnStackMark::has_buffer_for_thread(Thread::current())) failed: Should be empty 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 8064854: new hotspot build - hs25.40-b20 8065227: Report allocation context stats at end of cleanup 8065305: Make it possible to extend the G1CollectorPolicy 8065361: Fixup headers and definitions for INCLUDE_TRACE -- Alejandro From rob.mckenna at oracle.com Fri Nov 21 22:33:53 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 21 Nov 2014 22:33:53 +0000 Subject: [8u40] Request for approval for bulk integration of hs25.40-b20 In-Reply-To: <546FBB48.60202@oracle.com> References: <546FBB48.60202@oracle.com> Message-ID: <546FBDD1.4080208@oracle.com> Approved pending successful testing. -Rob On 21/11/14 22:23, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.40-b20 into jdk8u40-b16. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b20-jdk8u40-b16.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8033602: wrong stabs data in libjvm.debuginfo on JDK 8 - SPARC > 8034005: cannot debug in synchronizer.o or objectMonitor.o on Solaris X86 > 8048169: Change 8037816 breaks HS build on PPC64 and CPP-Interpreter > platforms > 8054008: Using -XX:-LazyBootClassLoader crashes with ACCESS_VIOLATION > on Win 64bit. > 8056049: getProcessCpuLoad() stops working in one process when a > different process exits > 8056071: compiler/whitebox/IsMethodCompilableTest.java fails with > 'method() is not compilable after 3 iterations' > 8057622: > java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest: > SEGV inside compiled code (sparc) > 8058209: Race in G1 card scanning could allow scanning of memory > covered by PLABs > 8058251: assert(_count > 0) failed: Negative counter when running > runtime/NMT/MallocTrackingVerify.java > 8059131: sawindbg.dll is not compiled with /SAFESEH > 8059803: Update use of GetVersionEx to get correct Windows version in > hs_err files > 8060467: CMS: small OldPLABSize and -XX:-ResizePLAB cause > assert(ResizePLAB || n_blks == OldPLABSize) failed: Error > 8061969: [TESTBUG] MallocSiteHashOverflow.java should be enabled for > 32-bit platforms > 8062036: ConcurrentMarkThread::slt may be invoked before > ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent > crashes > 8062247: [TESTBUG] Allow WhiteBox test to access JVM offsets > 8062870: src/share/vm/services/mallocTracker.hpp:64 assert(_count > 0) > failed: Negative counter > 8062950: Bug in locking code when UseOptoBiasInlining is disabled: > assert(dmw->is_neutral()) failed: invariant > 8064361: new hotspot build - hs25.40-b19 > 8064375: Change certain errors to warnings in CDS output. > 8064556: G1: ParallelGCThreads=0 may cause > assert(!MetadataOnStackMark::has_buffer_for_thread(Thread::current())) > failed: Should be empty > 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 > 8064854: new hotspot build - hs25.40-b20 > 8065227: Report allocation context stats at end of cleanup > 8065305: Make it possible to extend the G1CollectorPolicy > 8065361: Fixup headers and definitions for INCLUDE_TRACE > From attila.szegedi at oracle.com Mon Nov 24 10:44:07 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 24 Nov 2014 11:44:07 +0100 Subject: [8u40] Request for approval: JDK-8057691: Nashorn: let & const declarations are not shared between scripts In-Reply-To: <546F8CE6.30504@oracle.com> References: <546F8116.8070909@oracle.com> <546F85CD.1080203@oracle.com> <546F8CE6.30504@oracle.com> Message-ID: <087FF2D8-CEC4-41D8-8A5D-65787EB0C4D5@oracle.com> +1 on backported change. On Nov 21, 2014, at 8:05 PM, Hannes Wallnoefer wrote: > Thanks Rob, > > I'll get the reviews for the 8-specific changes before pushing. > > Hannes > > Am 2014-11-21 um 19:34 schrieb Rob McKenna: >> Hi Hannes, approved assuming any 8 specific changes have been codereviewed. >> >> -Rob >> >> On 21/11/14 18:14, Hannes Wallnoefer wrote: >>> JDK-8057691: Nashorn: let & const declarations are not shared between scripts >>> >>> Please approve backport of JDK-8057691 to 8u40. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8057691 >>> Webrev: http://cr.openjdk.java.net/~hannesw/8057691/ >>> Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003877.html >>> Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559 >>> >>> The patch applies cleanly to 8u40 after fixing path names except for the change in jdk/nashorn/internal/parser/Parser.java. >>> However, that change is quite easy to reconstruct as I just undid a change introduced in JDK-8051889. >>> >>> Change to Parser.java in JDK9: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559#l4.7 >>> Change that needs to be undone in JDK8: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/b7a2db4de254#l13.26 >>> Change backported to JDK8u-dev: http://cr.openjdk.java.net/~hannesw/8057691/webrev-8u-dev/src/jdk/nashorn/internal/parser/Parser.java.udiff.html >>> >>> Thanks, >>> Hannes >> > From attila.szegedi at oracle.com Mon Nov 24 10:44:07 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Mon, 24 Nov 2014 11:44:07 +0100 Subject: [8u40] Request for approval: JDK-8057691: Nashorn: let & const declarations are not shared between scripts In-Reply-To: <546F8CE6.30504@oracle.com> References: <546F8116.8070909@oracle.com> <546F85CD.1080203@oracle.com> <546F8CE6.30504@oracle.com> Message-ID: <2EF2250C-ADA1-430E-A5F8-D563ADA1E998@oracle.com> +1 on backported change. On Nov 21, 2014, at 8:05 PM, Hannes Wallnoefer wrote: > Thanks Rob, > > I'll get the reviews for the 8-specific changes before pushing. > > Hannes > > Am 2014-11-21 um 19:34 schrieb Rob McKenna: >> Hi Hannes, approved assuming any 8 specific changes have been codereviewed. >> >> -Rob >> >> On 21/11/14 18:14, Hannes Wallnoefer wrote: >>> JDK-8057691: Nashorn: let & const declarations are not shared between scripts >>> >>> Please approve backport of JDK-8057691 to 8u40. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8057691 >>> Webrev: http://cr.openjdk.java.net/~hannesw/8057691/ >>> Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003877.html >>> Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559 >>> >>> The patch applies cleanly to 8u40 after fixing path names except for the change in jdk/nashorn/internal/parser/Parser.java. >>> However, that change is quite easy to reconstruct as I just undid a change introduced in JDK-8051889. >>> >>> Change to Parser.java in JDK9: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/a723569d0559#l4.7 >>> Change that needs to be undone in JDK8: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/b7a2db4de254#l13.26 >>> Change backported to JDK8u-dev: http://cr.openjdk.java.net/~hannesw/8057691/webrev-8u-dev/src/jdk/nashorn/internal/parser/Parser.java.udiff.html >>> >>> Thanks, >>> Hannes >> > From sergey.lugovoy at oracle.com Mon Nov 24 13:46:14 2014 From: sergey.lugovoy at oracle.com (Sergey Lugovoy) Date: Mon, 24 Nov 2014 16:46:14 +0300 Subject: [8u40] 8062638 ,8054343 - request for approval to backport of nashorn changesets In-Reply-To: <546A07C8.20808@oracle.com> References: <5469F0B0.8060606@oracle.com> <546A07C8.20808@oracle.com> Message-ID: <547336A6.9090507@oracle.com> Hi all, Could you approve these changes, please? JDK-8062638 is blocking testing nashorn on Windows. review links: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003831.html http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-September/003369.html On 17.11.2014 17:35, Se?n Coffey wrote: > I've added the bugIDs to the subject line. I notice the review links > are missing also. Please remember for the next time.[1] > Can you add a 'testbug' or 'noreg-self' label to both bug reports ? > > Approved. > > regards, > Sean. > > [1] http://openjdk.java.net/projects/jdk8u/approval-template.html > > On 17/11/14 12:57, Sergey Lugovoy wrote: >> Hi, >> Please approve backport of the following 2 changesets from jdk9 to >> jdk8u40. >> All changesets appled "as is" >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8062638 >> changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/0c9f3369f3d3 >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8054343 >> changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/2520d5e7bc5f >> > -- Thanks, Sergey From sean.coffey at oracle.com Mon Nov 24 14:06:15 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 24 Nov 2014 14:06:15 +0000 Subject: [8u40] 8062638 ,8054343 - request for approval to backport of nashorn changesets In-Reply-To: <547336A6.9090507@oracle.com> References: <5469F0B0.8060606@oracle.com> <546A07C8.20808@oracle.com> <547336A6.9090507@oracle.com> Message-ID: <54733B57.7050209@oracle.com> JDK-8062638 was approved in my last mail! thanks for adding the necessary labels. regards, Sean. On 24/11/14 13:46, Sergey Lugovoy wrote: > Hi all, > Could you approve these changes, please? > JDK-8062638 is blocking testing nashorn on Windows. > > > review links: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003831.html > > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-September/003369.html > > > > On 17.11.2014 17:35, Se?n Coffey wrote: >> I've added the bugIDs to the subject line. I notice the review links >> are missing also. Please remember for the next time.[1] >> Can you add a 'testbug' or 'noreg-self' label to both bug reports ? >> >> Approved. >> >> regards, >> Sean. >> >> [1] http://openjdk.java.net/projects/jdk8u/approval-template.html >> >> On 17/11/14 12:57, Sergey Lugovoy wrote: >>> Hi, >>> Please approve backport of the following 2 changesets from jdk9 to >>> jdk8u40. >>> All changesets appled "as is" >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8062638 >>> changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/0c9f3369f3d3 >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8054343 >>> changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/2520d5e7bc5f >>> >> > From aleksej.efimov at oracle.com Mon Nov 24 14:27:14 2014 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Mon, 24 Nov 2014 17:27:14 +0300 Subject: [8u40] Request for approval: 8064560: (tz) Support tzdata2014j Message-ID: <54734042.3070807@oracle.com> Hi, Please, approve a backport of tzdata2014j changes to JDK8. The unshuffled patch applies cleanly. Testing: JTREG and JPRT tests shows no tz/time failures. Bug: https://bugs.openjdk.java.net/browse/JDK-8064560 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/224bb8a9297b JDK9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029678.html Thank you, Aleksej From rob.mckenna at oracle.com Mon Nov 24 14:30:07 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 24 Nov 2014 14:30:07 +0000 Subject: [8u40] Request for approval: 8064560: (tz) Support tzdata2014j In-Reply-To: <54734042.3070807@oracle.com> References: <54734042.3070807@oracle.com> Message-ID: <547340EF.2090602@oracle.com> Approved. -Rob On 24/11/14 14:27, Aleksej Efimov wrote: > Hi, > > Please, approve a backport of tzdata2014j changes to JDK8. The > unshuffled patch applies cleanly. > Testing: JTREG and JPRT tests shows no tz/time failures. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8064560 > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/224bb8a9297b > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029678.html > > > Thank you, > Aleksej From eric.mccorkle at oracle.com Mon Nov 24 21:25:40 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Mon, 24 Nov 2014 16:25:40 -0500 Subject: [8u40] Request for approval for 8065132 and 8029012 Message-ID: <5473A254.8080605@oracle.com> Hello, Please approve the backport for these two fixes, which cause javac to generate Runtime[In]Visible[Type,Parameter]Annotations attributes that correctly account for synthetic parameters. Note that the patches did not apply cleanly. In the case of 8029012, langtools SQE staff have added cases to the referenceinfos/Constructor.java test that are not present in 8u. For 8065132, diamondification made a behavior-invariant change to the source in ClassWriter.java After these changes, all tests pass. The JBS issues are here: https://bugs.openjdk.java.net/browse/JDK-8065132 https://bugs.openjdk.java.net/browse/JDK-8029012 A webrev containing both changesets is here: http://cr.openjdk.java.net/~emc/8065132/ From vicente.romero at oracle.com Mon Nov 24 21:39:01 2014 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Mon, 24 Nov 2014 13:39:01 -0800 Subject: [8u40] Request for approval for JDK-8059921 and JDK-8063052 Message-ID: <5473A575.80309@oracle.com> Please approve the backport from 9 to 8u40 of the following bugs: JDK-8063052: Inference chokes on wildcard derived from method reference JKD9 bug: https://bugs.openjdk.java.net/browse/JDK-8063052 JDK 8u40 bug: https://bugs.openjdk.java.net/browse/JDK-8065407 changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/d5b3ff8ab3b3 JDK-8059921: Missing compile error in Java 8 mode for Interface.super.field access JKD9 bug: https://bugs.openjdk.java.net/browse/JDK-8059921 JDK 8u40 bug: https://bugs.openjdk.java.net/browse/JDK-8065389 changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2bfbb068284d Thanks, Vicente From sean.coffey at oracle.com Mon Nov 24 22:18:28 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 24 Nov 2014 22:18:28 +0000 Subject: [8u40] Request for approval for JDK-8059921 and JDK-8063052 In-Reply-To: <5473A575.80309@oracle.com> References: <5473A575.80309@oracle.com> Message-ID: <5473AEB4.8000202@oracle.com> Approved on the condition that patches applied cleanly. Obtain a review first otherwise. regards, Sean. On 24/11/2014 21:39, Vicente-Arturo Romero-Zaldivar wrote: > Please approve the backport from 9 to 8u40 of the following bugs: > > JDK-8063052: Inference chokes on wildcard derived from method reference > JKD9 bug: https://bugs.openjdk.java.net/browse/JDK-8063052 > JDK 8u40 bug: https://bugs.openjdk.java.net/browse/JDK-8065407 > changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/d5b3ff8ab3b3 > > > JDK-8059921: Missing compile error in Java 8 mode for > Interface.super.field access > JKD9 bug: https://bugs.openjdk.java.net/browse/JDK-8059921 > JDK 8u40 bug: https://bugs.openjdk.java.net/browse/JDK-8065389 > changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2bfbb068284d > > Thanks, > Vicente > > From sean.coffey at oracle.com Mon Nov 24 22:21:05 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 24 Nov 2014 22:21:05 +0000 Subject: [8u40] Request for approval for 8065132 and 8029012 In-Reply-To: <5473A254.8080605@oracle.com> References: <5473A254.8080605@oracle.com> Message-ID: <5473AF51.4010905@oracle.com> Eric, Since it's not a clean patch application, can you obtain a code review first before pushing ? Approved but subject to above request. regards, Sean. On 24/11/2014 21:25, Eric McCorkle wrote: > Hello, > > Please approve the backport for these two fixes, which cause javac to > generate Runtime[In]Visible[Type,Parameter]Annotations attributes that > correctly account for synthetic parameters. > > Note that the patches did not apply cleanly. In the case of 8029012, > langtools SQE staff have added cases to the > referenceinfos/Constructor.java test that are not present in 8u. For > 8065132, diamondification made a behavior-invariant change to the source > in ClassWriter.java > > After these changes, all tests pass. > > The JBS issues are here: > https://bugs.openjdk.java.net/browse/JDK-8065132 > https://bugs.openjdk.java.net/browse/JDK-8029012 > > A webrev containing both changesets is here: > http://cr.openjdk.java.net/~emc/8065132/ From jonathan.gibbons at oracle.com Tue Nov 25 03:38:07 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 24 Nov 2014 19:38:07 -0800 Subject: [8u40] Request for approval for 8065132 and 8029012 In-Reply-To: <5473AF51.4010905@oracle.com> References: <5473A254.8080605@oracle.com> <5473AF51.4010905@oracle.com> Message-ID: <5473F99F.40800@oracle.com> The webrev looks like it has some problems, such as "duplicate" copies of test files (perhaps by bad composition of the two underlying patches) and the webrev shows strange inconsistencies of some test files having Patch entries and some having Raw entries, and some having both. -- Jon On 11/24/2014 02:21 PM, Se?n Coffey wrote: > Eric, > > Since it's not a clean patch application, can you obtain a code review > first before pushing ? > > Approved but subject to above request. > > regards, > Sean. > > On 24/11/2014 21:25, Eric McCorkle wrote: >> Hello, >> >> Please approve the backport for these two fixes, which cause javac to >> generate Runtime[In]Visible[Type,Parameter]Annotations attributes that >> correctly account for synthetic parameters. >> >> Note that the patches did not apply cleanly. In the case of 8029012, >> langtools SQE staff have added cases to the >> referenceinfos/Constructor.java test that are not present in 8u. For >> 8065132, diamondification made a behavior-invariant change to the source >> in ClassWriter.java >> >> After these changes, all tests pass. >> >> The JBS issues are here: >> https://bugs.openjdk.java.net/browse/JDK-8065132 >> https://bugs.openjdk.java.net/browse/JDK-8029012 >> >> A webrev containing both changesets is here: >> http://cr.openjdk.java.net/~emc/8065132/ > From robert.field at oracle.com Tue Nov 25 06:06:33 2014 From: robert.field at oracle.com (Robert Field) Date: Mon, 24 Nov 2014 22:06:33 -0800 Subject: [8u40] Request for approval: 8058112: Invalid BootstrapMethod for constructor/method reference Message-ID: <54741C69.4030602@oracle.com> Please approve backport from JDK9 to JDK8u40. After adjusting for the extra level of directory structure in jdk9/langtools/src, applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8058112 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/3c5de506a1f2 Reviewers: dlsmith, vromero From eric.mccorkle at oracle.com Tue Nov 25 06:48:40 2014 From: eric.mccorkle at oracle.com (Eric McCorkle) Date: Tue, 25 Nov 2014 01:48:40 -0500 Subject: [8u40] Request for approval for 8065132 and 8029012 In-Reply-To: <5473F99F.40800@oracle.com> References: <5473A254.8080605@oracle.com> <5473AF51.4010905@oracle.com> <5473F99F.40800@oracle.com> Message-ID: <54742648.50403@oracle.com> Ok, I've sorted out the issues with webrev. webrev.first is the first patch, webrev.second is the second, and webrev.01 is the combined. On 11/24/14 22:38, Jonathan Gibbons wrote: > The webrev looks like it has some problems, such as "duplicate" copies > of test files (perhaps by bad composition of the two underlying patches) > and the webrev shows strange inconsistencies of some test files having > Patch entries and some having Raw entries, and some having both. > > -- Jon > > On 11/24/2014 02:21 PM, Se?n Coffey wrote: >> Eric, >> >> Since it's not a clean patch application, can you obtain a code review >> first before pushing ? >> >> Approved but subject to above request. >> >> regards, >> Sean. >> >> On 24/11/2014 21:25, Eric McCorkle wrote: >>> Hello, >>> >>> Please approve the backport for these two fixes, which cause javac to >>> generate Runtime[In]Visible[Type,Parameter]Annotations attributes that >>> correctly account for synthetic parameters. >>> >>> Note that the patches did not apply cleanly. In the case of 8029012, >>> langtools SQE staff have added cases to the >>> referenceinfos/Constructor.java test that are not present in 8u. For >>> 8065132, diamondification made a behavior-invariant change to the source >>> in ClassWriter.java >>> >>> After these changes, all tests pass. >>> >>> The JBS issues are here: >>> https://bugs.openjdk.java.net/browse/JDK-8065132 >>> https://bugs.openjdk.java.net/browse/JDK-8029012 >>> >>> A webrev containing both changesets is here: >>> http://cr.openjdk.java.net/~emc/8065132/ >> > From jonathan.gibbons at oracle.com Tue Nov 25 07:24:32 2014 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Mon, 24 Nov 2014 23:24:32 -0800 Subject: [8u40] Request for approval for 8065132 and 8029012 In-Reply-To: <54742648.50403@oracle.com> References: <5473A254.8080605@oracle.com> <5473AF51.4010905@oracle.com> <5473F99F.40800@oracle.com> <54742648.50403@oracle.com> Message-ID: <54742EB0.5060407@oracle.com> Looks OK to me. -- Jon On 11/24/2014 10:48 PM, Eric McCorkle wrote: > Ok, I've sorted out the issues with webrev. webrev.first is the first > patch, webrev.second is the second, and webrev.01 is the combined. > > On 11/24/14 22:38, Jonathan Gibbons wrote: >> The webrev looks like it has some problems, such as "duplicate" copies >> of test files (perhaps by bad composition of the two underlying patches) >> and the webrev shows strange inconsistencies of some test files having >> Patch entries and some having Raw entries, and some having both. >> >> -- Jon >> >> On 11/24/2014 02:21 PM, Se?n Coffey wrote: >>> Eric, >>> >>> Since it's not a clean patch application, can you obtain a code review >>> first before pushing ? >>> >>> Approved but subject to above request. >>> >>> regards, >>> Sean. >>> >>> On 24/11/2014 21:25, Eric McCorkle wrote: >>>> Hello, >>>> >>>> Please approve the backport for these two fixes, which cause javac to >>>> generate Runtime[In]Visible[Type,Parameter]Annotations attributes that >>>> correctly account for synthetic parameters. >>>> >>>> Note that the patches did not apply cleanly. In the case of 8029012, >>>> langtools SQE staff have added cases to the >>>> referenceinfos/Constructor.java test that are not present in 8u. For >>>> 8065132, diamondification made a behavior-invariant change to the source >>>> in ClassWriter.java >>>> >>>> After these changes, all tests pass. >>>> >>>> The JBS issues are here: >>>> https://bugs.openjdk.java.net/browse/JDK-8065132 >>>> https://bugs.openjdk.java.net/browse/JDK-8029012 >>>> >>>> A webrev containing both changesets is here: >>>> http://cr.openjdk.java.net/~emc/8065132/ From sean.coffey at oracle.com Tue Nov 25 09:24:46 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 25 Nov 2014 09:24:46 +0000 Subject: [8u40] Request for approval: 8058112: Invalid BootstrapMethod for constructor/method reference In-Reply-To: <54741C69.4030602@oracle.com> References: <54741C69.4030602@oracle.com> Message-ID: <54744ADE.1010007@oracle.com> Approved. regards, Sean. On 25/11/2014 06:06, Robert Field wrote: > Please approve backport from JDK9 to JDK8u40. After adjusting for the > extra level of directory structure in jdk9/langtools/src, applies > cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8058112 > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/3c5de506a1f2 > Reviewers: dlsmith, vromero > From konstantin.shefov at oracle.com Tue Nov 25 10:53:39 2014 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Tue, 25 Nov 2014 13:53:39 +0300 Subject: [8u40] Request for approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout Message-ID: <54745FB3.9050206@oracle.com> Please approve backport of JDK-8059070 to 8u40. Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 Webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c The patch applies cleanly to 8u40. Thanks, -Konstantin From sean.coffey at oracle.com Tue Nov 25 11:43:16 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 25 Nov 2014 11:43:16 +0000 Subject: [8u40] Request for approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout In-Reply-To: <54745FB3.9050206@oracle.com> References: <54745FB3.9050206@oracle.com> Message-ID: <54746B54.4050505@oracle.com> Approved. regards, Sean. On 25/11/2014 10:53, Konstantin Shefov wrote: > Please approve backport of JDK-8059070 to 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 > Webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c > > The patch applies cleanly to 8u40. > > Thanks, > -Konstantin From alejandro.murillo at oracle.com Tue Nov 25 17:59:56 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 25 Nov 2014 10:59:56 -0700 Subject: jdk8u40-b16: HotSpot Message-ID: <5474C39C.5020701@oracle.com> hs25.40-b20 has been integrated into jdk8u40-b16. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/64790e9792f8 http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/0d3a452720a5 http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/5ea68fb91139 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/cda81fbeec94 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/8893690584da http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/9dc67d03e6e5 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/74c51ff270c5 http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/e079f3f6d536 Component : VM Status : 0 major failures, 0 minor failures Date : 11/24/2014 at 21:00 MSK Tested By : STT_VM Cost(total man-days): 1 Workspace : 2014-11-21-182438.amurillo.hs25-40-b20-snapshot Bundles : 2014-11-21-182438.amurillo.hs25-40-b20-snapshot Platforms : Others Tests : Log : link Browsers : NA Patches : NA Number of Tests Executed : 221193 passed tests, 2668 failed tests (no new failures) Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: 8033602: wrong stabs data in libjvm.debuginfo on JDK 8 - SPARC 8034005: cannot debug in synchronizer.o or objectMonitor.o on Solaris X86 8048169: Change 8037816 breaks HS build on PPC64 and CPP-Interpreter platforms 8054008: Using -XX:-LazyBootClassLoader crashes with ACCESS_VIOLATION on Win 64bit. 8056049: getProcessCpuLoad() stops working in one process when a different process exits 8056071: compiler/whitebox/IsMethodCompilableTest.java fails with 'method() is not compilable after 3 iterations' 8057622: java/util/stream/test/org/openjdk/tests/java/util/stream/InfiniteStreamWithLimitOpTest: SEGV inside compiled code (sparc) 8058209: Race in G1 card scanning could allow scanning of memory covered by PLABs 8058251: assert(_count > 0) failed: Negative counter when running runtime/NMT/MallocTrackingVerify.java 8059131: sawindbg.dll is not compiled with /SAFESEH 8059803: Update use of GetVersionEx to get correct Windows version in hs_err files 8060467: CMS: small OldPLABSize and -XX:-ResizePLAB cause assert(ResizePLAB || n_blks == OldPLABSize) failed: Error 8061969: [TESTBUG] MallocSiteHashOverflow.java should be enabled for 32-bit platforms 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes 8062247: [TESTBUG] Allow WhiteBox test to access JVM offsets 8062870: src/share/vm/services/mallocTracker.hpp:64 assert(_count > 0) failed: Negative counter 8062950: Bug in locking code when UseOptoBiasInlining is disabled: assert(dmw->is_neutral()) failed: invariant 8064361: new hotspot build - hs25.40-b19 8064375: Change certain errors to warnings in CDS output. 8064556: G1: ParallelGCThreads=0 may cause assert(!MetadataOnStackMark::has_buffer_for_thread(Thread::current())) failed: Should be empty 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 8064854: new hotspot build - hs25.40-b20 8065227: Report allocation context stats at end of cleanup 8065305: Make it possible to extend the G1CollectorPolicy 8065361: Fixup headers and definitions for INCLUDE_TRACE New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: jdk8u40-b16 Issues and Notes: This is PIT for HS25.40-b20 for jdk8u40-b16. Go for integration. -- Alejandro From joel.franck at oracle.com Wed Nov 26 09:51:12 2014 From: joel.franck at oracle.com (=?iso-8859-1?Q?Joel_Borggr=E9n-Franck?=) Date: Wed, 26 Nov 2014 10:51:12 +0100 Subject: [8u40] Request for approval: 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass Message-ID: <5577D073-FE0B-4E35-A98E-4E6C69BDBA1F@oracle.com> Hi, Can I get approval to push: https://bugs.openjdk.java.net/browse/JDK-8062359 to 8u? Fix from 9 applies cleanly modulo source shuffling: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/69a430162d80 Original review here: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-November/009161.html cheers /Joel From sean.coffey at oracle.com Wed Nov 26 10:52:44 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 26 Nov 2014 10:52:44 +0000 Subject: [8u40] Request for approval: 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass In-Reply-To: <5577D073-FE0B-4E35-A98E-4E6C69BDBA1F@oracle.com> References: <5577D073-FE0B-4E35-A98E-4E6C69BDBA1F@oracle.com> Message-ID: <5475B0FC.7060406@oracle.com> Surprised to see that javac tests don't include copyright headers! Looks like a precedent for langtools. Approved. regards, Sean. On 26/11/14 09:51, Joel Borggr?n-Franck wrote: > Hi, > > Can I get approval to push: https://bugs.openjdk.java.net/browse/JDK-8062359 to 8u? > > Fix from 9 applies cleanly modulo source shuffling: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/69a430162d80 > Original review here: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-November/009161.html > > cheers > /Joel From joel.franck at oracle.com Wed Nov 26 11:10:31 2014 From: joel.franck at oracle.com (=?windows-1252?Q?Joel_Borggr=E9n-Franck?=) Date: Wed, 26 Nov 2014 12:10:31 +0100 Subject: [8u40] Request for approval: 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass In-Reply-To: <5475B0FC.7060406@oracle.com> References: <5577D073-FE0B-4E35-A98E-4E6C69BDBA1F@oracle.com> <5475B0FC.7060406@oracle.com> Message-ID: <6F5921B6-9CD5-427B-ABB4-62179C6623D7@oracle.com> This test compares output, @compile/fail/ref= ? , those tests should not have per-file copyright headers but instead have the /* @test /nodynamiccopyright/ jtreg tag. cheers /Joel On 26 nov 2014, at 11:52, Se?n Coffey wrote: > Surprised to see that javac tests don't include copyright headers! Looks like a precedent for langtools. > > Approved. > > regards, > Sean. > > On 26/11/14 09:51, Joel Borggr?n-Franck wrote: >> Hi, >> >> Can I get approval to push: https://bugs.openjdk.java.net/browse/JDK-8062359 to 8u? >> >> Fix from 9 applies cleanly modulo source shuffling: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/69a430162d80 >> Original review here: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-November/009161.html >> >> cheers >> /Joel > From chris.hegarty at oracle.com Wed Nov 26 11:35:06 2014 From: chris.hegarty at oracle.com (Chris Hegarty) Date: Wed, 26 Nov 2014 11:35:06 +0000 Subject: [8u40] Request for approval: 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass In-Reply-To: <6F5921B6-9CD5-427B-ABB4-62179C6623D7@oracle.com> References: <5577D073-FE0B-4E35-A98E-4E6C69BDBA1F@oracle.com> <5475B0FC.7060406@oracle.com> <6F5921B6-9CD5-427B-ABB4-62179C6623D7@oracle.com> Message-ID: <5475BAEA.5050508@oracle.com> On 26/11/14 11:10, Joel Borggr?n-Franck wrote: > This test compares output, @compile/fail/ref= ? , those tests should not have per-file copyright headers but instead have the Just out of curiosity; why would having a copyright header in the test source affect the output, in a way that is nondeterministic ? -Chris. > /* @test /nodynamiccopyright/ > > jtreg tag. > > cheers > /Joel > > On 26 nov 2014, at 11:52, Se?n Coffey wrote: > >> Surprised to see that javac tests don't include copyright headers! Looks like a precedent for langtools. >> >> Approved. >> >> regards, >> Sean. >> >> On 26/11/14 09:51, Joel Borggr?n-Franck wrote: >>> Hi, >>> >>> Can I get approval to push: https://bugs.openjdk.java.net/browse/JDK-8062359 to 8u? >>> >>> Fix from 9 applies cleanly modulo source shuffling: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/69a430162d80 >>> Original review here: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-November/009161.html >>> >>> cheers >>> /Joel >> > From joel.franck at oracle.com Wed Nov 26 12:01:30 2014 From: joel.franck at oracle.com (=?windows-1252?Q?Joel_Borggr=E9n-Franck?=) Date: Wed, 26 Nov 2014 13:01:30 +0100 Subject: [8u40] Request for approval: 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass In-Reply-To: <5475BAEA.5050508@oracle.com> References: <5577D073-FE0B-4E35-A98E-4E6C69BDBA1F@oracle.com> <5475B0FC.7060406@oracle.com> <6F5921B6-9CD5-427B-ABB4-62179C6623D7@oracle.com> <5475BAEA.5050508@oracle.com> Message-ID: I think because we potentially license these files under more than one licenses and those license headers vary in line numbers. cheers /Joel On 26 nov 2014, at 12:35, Chris Hegarty wrote: > On 26/11/14 11:10, Joel Borggr?n-Franck wrote: >> This test compares output, @compile/fail/ref= ? , those tests should not have per-file copyright headers but instead have the > > Just out of curiosity; why would having a copyright header in the test source affect the output, in a way that is nondeterministic ? > > -Chris. > >> /* @test /nodynamiccopyright/ >> >> jtreg tag. >> >> cheers >> /Joel >> >> On 26 nov 2014, at 11:52, Se?n Coffey wrote: >> >>> Surprised to see that javac tests don't include copyright headers! Looks like a precedent for langtools. >>> >>> Approved. >>> >>> regards, >>> Sean. >>> >>> On 26/11/14 09:51, Joel Borggr?n-Franck wrote: >>>> Hi, >>>> >>>> Can I get approval to push: https://bugs.openjdk.java.net/browse/JDK-8062359 to 8u? >>>> >>>> Fix from 9 applies cleanly modulo source shuffling: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/69a430162d80 >>>> Original review here: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-November/009161.html >>>> >>>> cheers >>>> /Joel >>> >> From vladimir.x.ivanov at oracle.com Wed Nov 26 15:51:53 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Wed, 26 Nov 2014 19:51:53 +0400 Subject: [8u40] Bulk request for approval: 8059877, 8059880, 8063135 Message-ID: <5475F719.2060707@oracle.com> Please, approve backport of the following fixes into 8u40: (1) 8059877: GWT branch frequencies pollution due to LF sharing https://bugs.openjdk.java.net/browse/JDK-8059877 http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2380107db316 (2) 8059880: Get rid of LambdaForm interpretation https://bugs.openjdk.java.net/browse/JDK-8059880 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/01c8bf6084fb (3) 8063135: Enable full LF sharing by default https://bugs.openjdk.java.net/browse/JDK-8063135 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/fdea482eec4a The changes apply cleanly. Thanks! Best regards, Vladimir Ivanov From rob.mckenna at oracle.com Wed Nov 26 17:09:24 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 26 Nov 2014 17:09:24 +0000 Subject: [8u40] Bulk request for approval: 8059877, 8059880, 8063135 In-Reply-To: <5475F719.2060707@oracle.com> References: <5475F719.2060707@oracle.com> Message-ID: <54760944.8030600@oracle.com> Approved. -Rob On 26/11/14 15:51, Vladimir Ivanov wrote: > Please, approve backport of the following fixes into 8u40: > > (1) 8059877: GWT branch frequencies pollution due to LF sharing > https://bugs.openjdk.java.net/browse/JDK-8059877 > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2380107db316 > > (2) 8059880: Get rid of LambdaForm interpretation > https://bugs.openjdk.java.net/browse/JDK-8059880 > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/01c8bf6084fb > > (3) 8063135: Enable full LF sharing by default > https://bugs.openjdk.java.net/browse/JDK-8063135 > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/fdea482eec4a > > The changes apply cleanly. > > Thanks! > > Best regards, > Vladimir Ivanov From vladimir.x.ivanov at oracle.com Wed Nov 26 16:25:07 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Wed, 26 Nov 2014 20:25:07 +0400 Subject: [8u40] Bulk request for approval: 8059877, 8059880, 8063135 In-Reply-To: <54760944.8030600@oracle.com> References: <5475F719.2060707@oracle.com> <54760944.8030600@oracle.com> Message-ID: <5475FEE3.9070802@oracle.com> Thank you, Rob. Best regards, Vladimir Ivanov On 11/26/14, 9:09 PM, Rob McKenna wrote: > Approved. > > -Rob > > On 26/11/14 15:51, Vladimir Ivanov wrote: >> Please, approve backport of the following fixes into 8u40: >> >> (1) 8059877: GWT branch frequencies pollution due to LF sharing >> https://bugs.openjdk.java.net/browse/JDK-8059877 >> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2380107db316 >> >> (2) 8059880: Get rid of LambdaForm interpretation >> https://bugs.openjdk.java.net/browse/JDK-8059880 >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/01c8bf6084fb >> >> (3) 8063135: Enable full LF sharing by default >> https://bugs.openjdk.java.net/browse/JDK-8063135 >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/fdea482eec4a >> >> The changes apply cleanly. >> >> Thanks! >> >> Best regards, >> Vladimir Ivanov > From konstantin.shefov at oracle.com Thu Nov 27 08:06:36 2014 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Thu, 27 Nov 2014 11:06:36 +0300 Subject: [8u40] Request for approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout Message-ID: <5476DB8C.6020607@oracle.com> Please approve backport of JDK-8059070 to 8u40. Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 Webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c The patch applies cleanly to 8u40. Thanks, -Konstantin From sean.coffey at oracle.com Thu Nov 27 09:09:47 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 27 Nov 2014 09:09:47 +0000 Subject: [8u40] Request for approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout In-Reply-To: <5476DB8C.6020607@oracle.com> References: <5476DB8C.6020607@oracle.com> Message-ID: <5476EA5B.1080201@oracle.com> This was already approved Konstantin : http://mail.openjdk.java.net/pipermail/jdk8u-dev/2014-November/002571.html regards, Sean. On 27/11/2014 08:06, Konstantin Shefov wrote: > Please approve backport of JDK-8059070 to 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 > Webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c > > The patch applies cleanly to 8u40. > > Thanks, > -Konstantin From alexandr.scherbatiy at oracle.com Thu Nov 27 11:32:50 2014 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Thu, 27 Nov 2014 14:32:50 +0300 Subject: [8u40] Request for approval: 8065098 JColorChooser no longer supports drag and drop between two JVM instances Message-ID: <54770BE2.4060604@oracle.com> Hello, Could you approve the direct backport of the fix to JDK 8u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8065098 The webrev: http://cr.openjdk.java.net/~alexsch/8065098/webrev.02 The review thread: http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004050.html The JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/675344f2c1b6 Thanks, Alexandr. From sean.coffey at oracle.com Thu Nov 27 11:50:06 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 27 Nov 2014 11:50:06 +0000 Subject: [8u40] Request for approval: 8065098 JColorChooser no longer supports drag and drop between two JVM instances In-Reply-To: <54770BE2.4060604@oracle.com> References: <54770BE2.4060604@oracle.com> Message-ID: <54770FEE.7060602@oracle.com> Approved. regards, Sean. On 27/11/2014 11:32, Alexander Scherbatiy wrote: > > Hello, > > Could you approve the direct backport of the fix to JDK 8u-dev. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8065098 > The webrev: http://cr.openjdk.java.net/~alexsch/8065098/webrev.02 > The review thread: > http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004050.html > The JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/675344f2c1b6 > > Thanks, > Alexandr. > From attila.szegedi at oracle.com Thu Nov 27 13:23:55 2014 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 27 Nov 2014 14:23:55 +0100 Subject: [8u40] Request for Approval: 8051778: support bind on all Nashorn callables Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8051778 jdk9 webrev: http://cr.openjdk.java.net/~attila/8051778/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003892.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From sean.coffey at oracle.com Thu Nov 27 13:45:03 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 27 Nov 2014 13:45:03 +0000 Subject: [8u40] Request for Approval: 8051778: support bind on all Nashorn callables In-Reply-To: References: Message-ID: <54772ADF.90709@oracle.com> Approved. regards, Sean. On 27/11/2014 13:23, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8051778 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8051778/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003892.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From vladimir.x.ivanov at oracle.com Thu Nov 27 13:38:26 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 27 Nov 2014 17:38:26 +0400 Subject: [8u40] Request for approval: 8065985 Message-ID: <54772952.8080002@oracle.com> Please, approve backport of the following fixes into 8u40: 8065985: "Inlining failure of Number.doubleValue() in JSType.toNumeric() causes 15% peak perf regresion on Box2D" https://bugs.openjdk.java.net/browse/JDK-8065985 http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003888.html http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/64962ecb8b85 The fix applies cleanly. Thanks! Best regards, Vladimir Ivanov From sean.coffey at oracle.com Thu Nov 27 14:40:16 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 27 Nov 2014 14:40:16 +0000 Subject: [8u40] Request for approval: 8065985 In-Reply-To: <54772952.8080002@oracle.com> References: <54772952.8080002@oracle.com> Message-ID: <547737D0.3090805@oracle.com> Approved. regards, Sean. On 27/11/2014 13:38, Vladimir Ivanov wrote: > Please, approve backport of the following fixes into 8u40: > > 8065985: "Inlining failure of Number.doubleValue() in > JSType.toNumeric() causes 15% peak perf regresion on Box2D" > > https://bugs.openjdk.java.net/browse/JDK-8065985 > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003888.html > > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/64962ecb8b85 > > The fix applies cleanly. > > Thanks! > > Best regards, > Vladimir Ivanov From hannes.wallnoefer at oracle.com Thu Nov 27 16:45:07 2014 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 27 Nov 2014 17:45:07 +0100 Subject: 8u40] Request for approval: JDK-8057980: let & const: remaining issues with lexical scoping Message-ID: <54775513.7070206@oracle.com> Please approve backport of JDK-8057980 to 8u40. Bug: https://bugs.openjdk.java.net/browse/JDK-8057980 Webrev JDK9: http://cr.openjdk.java.net/~hannesw/8057980/webrev-9.02/ Webrev JDK8u: http://cr.openjdk.java.net/~hannesw/8057980/webrev-8u/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003909.html Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/e26843ca558b The patch applies cleanly to 8u40 after fixing path names except for some of the changes to jdk/nashorn/internal/parser/Parser.java. The manually backported changes have been reviewed and tested. Thanks, Hannes From rob.mckenna at oracle.com Thu Nov 27 16:48:49 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 27 Nov 2014 16:48:49 +0000 Subject: 8u40] Request for approval: JDK-8057980: let & const: remaining issues with lexical scoping In-Reply-To: <54775513.7070206@oracle.com> References: <54775513.7070206@oracle.com> Message-ID: <547755F1.9060900@oracle.com> Approved. -Rob On 27/11/14 16:45, Hannes Wallnoefer wrote: > Please approve backport of JDK-8057980 to 8u40. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8057980 > Webrev JDK9: http://cr.openjdk.java.net/~hannesw/8057980/webrev-9.02/ > Webrev JDK8u: http://cr.openjdk.java.net/~hannesw/8057980/webrev-8u/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003909.html > Changeset: http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/e26843ca558b > > The patch applies cleanly to 8u40 after fixing path names except for > some of the changes to jdk/nashorn/internal/parser/Parser.java. The > manually backported changes have been reviewed and tested. > > Thanks, > Hannes From alejandro.murillo at oracle.com Thu Nov 27 20:34:34 2014 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Thu, 27 Nov 2014 13:34:34 -0700 Subject: [8u40] Request for approval for bulk integration of hs25.40-b21 Message-ID: <54778ADA.5020903@oracle.com> Requesting approval to integrate hs25.40-b21 into jdk8u40-b17. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b21-jdk8u40-b17.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8050079: crash while compiling java.lang.ref.Finalizer::runFinalizer 8058148: MaxNodeLimit and LiveNodeCountInliningCutoff 8058847: C2: EliminateAutoBox regression after 8042786 8060147: SIGSEGV in Metadata::mark_on_stack() while marking metadata in ciEnv 8064701: Some CDS optimizations should be disabled if bootclasspath is modified by JVMTI 8065346: WB_AddToBootstrapClassLoaderSearch calls JvmtiEnv::create_a_jvmti when not in _thread_in_vm state 8065385: new hotspot build - hs25.40-b21 -- Alejandro From rob.mckenna at oracle.com Thu Nov 27 20:46:30 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 27 Nov 2014 20:46:30 +0000 Subject: [8u40] Request for approval for bulk integration of hs25.40-b21 In-Reply-To: <54778ADA.5020903@oracle.com> References: <54778ADA.5020903@oracle.com> Message-ID: <54778DA6.4080304@oracle.com> Approved pending successful PIT. -Rob On 27/11/14 20:34, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.40-b21 into jdk8u40-b17. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u40/hs25.40-b21-jdk8u40-b17.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8050079: crash while compiling java.lang.ref.Finalizer::runFinalizer > 8058148: MaxNodeLimit and LiveNodeCountInliningCutoff > 8058847: C2: EliminateAutoBox regression after 8042786 > 8060147: SIGSEGV in Metadata::mark_on_stack() while marking metadata > in ciEnv > 8064701: Some CDS optimizations should be disabled if bootclasspath is > modified by JVMTI > 8065346: WB_AddToBootstrapClassLoaderSearch calls > JvmtiEnv::create_a_jvmti when not in _thread_in_vm state > 8065385: new hotspot build - hs25.40-b21 > From marcus.lagergren at oracle.com Fri Nov 28 10:04:58 2014 From: marcus.lagergren at oracle.com (Marcus Lagergren) Date: Fri, 28 Nov 2014 11:04:58 +0100 Subject: Please approve backport for JDK-8066119 into 8u40 Message-ID: <2FBF2276-8E92-40CC-B0F0-B8283C9F38FF@oracle.com> Very trivial, tagged with label "noreg-trivial". Bug report at: https://bugs.openjdk.java.net/browse/JDK-8066119 Webrev at: http://cr.openjdk.java.net/~lagergren/8066119/ Review thread at: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003920.html Merges cleanly after reshuffle. /M From sean.coffey at oracle.com Fri Nov 28 10:10:38 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 28 Nov 2014 10:10:38 +0000 Subject: Please approve backport for JDK-8066119 into 8u40 In-Reply-To: <2FBF2276-8E92-40CC-B0F0-B8283C9F38FF@oracle.com> References: <2FBF2276-8E92-40CC-B0F0-B8283C9F38FF@oracle.com> Message-ID: <54784A1E.9000601@oracle.com> Approved. regards, Sean. On 28/11/2014 10:04, Marcus Lagergren wrote: > Very trivial, tagged with label "noreg-trivial". > > Bug report at: https://bugs.openjdk.java.net/browse/JDK-8066119 > Webrev at: http://cr.openjdk.java.net/~lagergren/8066119/ > Review thread at: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003920.html > > Merges cleanly after reshuffle. > > /M > From ivan.gerasimov at oracle.com Fri Nov 28 11:50:23 2014 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Fri, 28 Nov 2014 14:50:23 +0300 Subject: [8u-dev] Request for Approval: 8062771: Core reflection should use final fields whenever possible Message-ID: <5478617F.2030608@oracle.com> Hi! Would you please approve this straightforward backport from 9? I only had to skip a few files, as they already contain necessary changes. The rest of the patch applies cleanly after unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8062771 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029485.html Webrev: http://cr.openjdk.java.net/~igerasim/8062771/0/webrev/ Review for this backport: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029901.html Sincerely yours, Ivan From sean.coffey at oracle.com Fri Nov 28 11:54:15 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 28 Nov 2014 11:54:15 +0000 Subject: [8u-dev] Request for Approval: 8062771: Core reflection should use final fields whenever possible In-Reply-To: <5478617F.2030608@oracle.com> References: <5478617F.2030608@oracle.com> Message-ID: <54786267.8060201@oracle.com> Approved. regards, Sean. On 28/11/2014 11:50, Ivan Gerasimov wrote: > Hi! > > Would you please approve this straightforward backport from 9? > I only had to skip a few files, as they already contain necessary > changes. > The rest of the patch applies cleanly after unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062771 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1e5c2bd424d5 > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029485.html > Webrev: http://cr.openjdk.java.net/~igerasim/8062771/0/webrev/ > Review for this backport: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029901.html > > Sincerely yours, > Ivan From jan.lahoda at oracle.com Fri Nov 28 13:51:33 2014 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Fri, 28 Nov 2014 14:51:33 +0100 Subject: [8u40] request for approval to backport JDK-8057794: Compiler Error when obtaining .class property Message-ID: <54787DE5.60703@oracle.com> Hello, I'd like to ask for an approval to backport fix for: Bug: https://bugs.openjdk.java.net/browse/JDK-8057794 jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2f8f2ae8a806 The fix applies cleanly to: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/langtools after reshuffling. Thanks, Jan From sean.coffey at oracle.com Fri Nov 28 14:10:53 2014 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 28 Nov 2014 14:10:53 +0000 Subject: [8u40] request for approval to backport JDK-8057794: Compiler Error when obtaining .class property In-Reply-To: <54787DE5.60703@oracle.com> References: <54787DE5.60703@oracle.com> Message-ID: <5478826D.3050206@oracle.com> Approved. regards, Sean. On 28/11/2014 13:51, Jan Lahoda wrote: > Hello, > > I'd like to ask for an approval to backport fix for: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8057794 > jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/2f8f2ae8a806 > > The fix applies cleanly to: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/langtools after reshuffling. > > Thanks, > Jan From sergey.lugovoy at oracle.com Fri Nov 28 14:34:25 2014 From: sergey.lugovoy at oracle.com (Sergey Lugovoy) Date: Fri, 28 Nov 2014 17:34:25 +0300 Subject: [8u40] Request for approval: 8057779: Tests failed on Windows when in output contains path to script Message-ID: <547887F1.40103@oracle.com> Please approve. Changes apply cleanly. bug: https://bugs.openjdk.java.net/browse/JDK-8057779 jdk9 webrev: http://cr.openjdk.java.net/~yan/8057779/webrev.00/ review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-September/003491.html -- Thanks, Sergey From sean.coffey at oracle.com Fri Nov 28 14:39:55 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 28 Nov 2014 14:39:55 +0000 Subject: [8u40] Request for approval: 8057779: Tests failed on Windows when in output contains path to script In-Reply-To: <547887F1.40103@oracle.com> References: <547887F1.40103@oracle.com> Message-ID: <5478893B.1010801@oracle.com> Approved. regards, Sean. On 28/11/2014 14:34, Sergey Lugovoy wrote: > Please approve. > Changes apply cleanly. > > bug: https://bugs.openjdk.java.net/browse/JDK-8057779 > jdk9 webrev: http://cr.openjdk.java.net/~yan/8057779/webrev.00/ > review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-September/003491.html > > From alexandr.scherbatiy at oracle.com Fri Nov 28 15:15:21 2014 From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy) Date: Fri, 28 Nov 2014 18:15:21 +0300 Subject: [8u40] Request for approval: 8031696 [macosx] TwentyThousandTest test failed with OOM Message-ID: <54789189.2080402@oracle.com> Hello, Could you approve the direct backport of the fix to JDK 8u-dev. The bug: https://bugs.openjdk.java.net/browse/JDK-8031696 The webrev: http://cr.openjdk.java.net/~alexsch/8031696/webrev.01/ The review thread: http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004052.html The JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/3b2bc2801098 Thanks, Alexandr. From rob.mckenna at oracle.com Fri Nov 28 16:10:41 2014 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 28 Nov 2014 16:10:41 +0000 Subject: [8u40] Request for approval: 8031696 [macosx] TwentyThousandTest test failed with OOM In-Reply-To: <54789189.2080402@oracle.com> References: <54789189.2080402@oracle.com> Message-ID: <54789E81.3080505@oracle.com> Approved. -Rob On 28/11/14 15:15, Alexander Scherbatiy wrote: > > Hello, > > Could you approve the direct backport of the fix to JDK 8u-dev. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8031696 > The webrev: http://cr.openjdk.java.net/~alexsch/8031696/webrev.01/ > The review thread: > http://mail.openjdk.java.net/pipermail/swing-dev/2014-November/004052.html > The JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/3b2bc2801098 > > Thanks, > Alexandr. > From konstantin.shefov at oracle.com Fri Nov 28 17:21:02 2014 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Fri, 28 Nov 2014 20:21:02 +0300 Subject: [8u40] Request for review and approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout Message-ID: <5478AEFE.8010009@oracle.com> Please review and approve backport of JDK-8059070 to 8u40. This is the test fix and it is a bit different from that of JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 Webrev: http://cr.openjdk.java.net/~kshefov/8059070_8u/webrev.00 Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c Thanks, -Konstantin From vladimir.x.ivanov at oracle.com Fri Nov 28 16:49:01 2014 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Fri, 28 Nov 2014 20:49:01 +0400 Subject: [8u40] Request for review and approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout In-Reply-To: <5478AEFE.8010009@oracle.com> References: <5478AEFE.8010009@oracle.com> Message-ID: <5478A77D.4020400@oracle.com> Looks good. Best regards, Vladimir Ivanov On 11/28/14, 9:21 PM, Konstantin Shefov wrote: > Please review and approve backport of JDK-8059070 to 8u40. > > This is the test fix and it is a bit different from that of JDK 9. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 > Webrev: http://cr.openjdk.java.net/~kshefov/8059070_8u/webrev.00 > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html > > Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c > > > Thanks, > -Konstantin From sean.coffey at oracle.com Fri Nov 28 17:50:59 2014 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 28 Nov 2014 17:50:59 +0000 Subject: [8u40] Request for review and approval: 8059070 : [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout In-Reply-To: <5478A77D.4020400@oracle.com> References: <5478AEFE.8010009@oracle.com> <5478A77D.4020400@oracle.com> Message-ID: <5478B603.2000906@oracle.com> Approved.... again ;) regards, Sean. On 28/11/2014 16:49, Vladimir Ivanov wrote: > Looks good. > > Best regards, > Vladimir Ivanov > > On 11/28/14, 9:21 PM, Konstantin Shefov wrote: >> Please review and approve backport of JDK-8059070 to 8u40. >> >> This is the test fix and it is a bit different from that of JDK 9. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8059070 >> Webrev: http://cr.openjdk.java.net/~kshefov/8059070_8u/webrev.00 >> Review thread: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-November/029831.html >> >> >> Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/1d480d8fcf8c >> >> >> Thanks, >> -Konstantin