[8u40] Review request 8064667: Provide support to help identify use of endorsed standards and extension mechanism

[Mandy Chung]

On 11/17/14 11:40 AM, Calvin Cheung wrote:
> Hi Mandy,
>
> In 8u40, the jre/lib/ext dir still exists and containing nashorn.jar, 
> javafx.jar, etc.
> Would those jar files be moved to a different dir?

Good catch.  No these jar files will stay in jre/lib/ext.  I will revise 
the patch to detect if jre/lib/ext contains any jar files other than the 
ones JDK ships.
>
> Some minor comments in arguments.cpp:
> lines 3470 and 3472 can be combined as follows:
> int nonEmptyDirs = check_non_empty_dirs(Arguments::get_endorsed_dir(), 
> "endorsed");
>
> before return JNI_ERR; at lines 3493 and 3503, the dir should be closed:
> os::closedir(dir);
>

Will send out an updated webrev.

thanks
Mandy

> Calvin
>
> On 11/17/2014 8:57 AM, Mandy Chung wrote:
>> This requests both code review and 8u40 approval for:
>>    https://bugs.openjdk.java.net/browse/JDK-8064667
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8064667/webrev.00/
>>
>> JEP 220 [1] proposes to remove the endorsed standards override 
>> mechanism and extension mechanism. This patch adds a VM flag in 8u40 
>> to help identify any existing uses of these mechanisms so that users 
>> can turn on the VM flag to help identify if they depend on the 
>> endorsed standards override mechanism and extension mechanism and can 
>> plan to prepare for the migration to a newer JDK release early on. 
>> When -XX:+CheckEndorsedAndExtDirs is set, the VM will exit if the 
>> system property -Djava.endorsed.dirs or -Djava.ext.dirs is set, or if 
>> ${java.home}/lib/endorsed or ${java.home}/lib/ext exists, or any 
>> system extension directory contains JAR files.
>>
>> Thanks
>> Mandy
>> [1] http://openjdk.java.net/jeps/220
>>
>>
>>
>