[8u40] Request for approval: 8062359: javac Attr crashes with NPE in TypeAnnotationsValidator visitNewClass

Joel Borggrén-Franck joel.franck at oracle.com
Wed Nov 26 12:01:30 UTC 2014


I think because we potentially license these files under more than one licenses and those license headers vary in line numbers.

cheers
/Joel

On 26 nov 2014, at 12:35, Chris Hegarty <chris.hegarty at oracle.com> wrote:

> On 26/11/14 11:10, Joel Borggrén-Franck wrote:
>> This test compares output, @compile/fail/ref= … , those tests should not have per-file copyright headers but instead have the
> 
> Just out of curiosity; why would having a copyright header in the test source affect the output, in a way that is nondeterministic ?
> 
> -Chris.
> 
>> /* @test /nodynamiccopyright/
>> 
>> jtreg tag.
>> 
>> cheers
>> /Joel
>> 
>> On 26 nov 2014, at 11:52, Seán Coffey <sean.coffey at oracle.com> wrote:
>> 
>>> Surprised to see that javac tests don't include copyright headers! Looks like a precedent for langtools.
>>> 
>>> Approved.
>>> 
>>> regards,
>>> Sean.
>>> 
>>> On 26/11/14 09:51, Joel Borggrén-Franck wrote:
>>>> Hi,
>>>> 
>>>> Can I get approval to push: https://bugs.openjdk.java.net/browse/JDK-8062359 to 8u?
>>>> 
>>>> Fix from 9 applies cleanly modulo source shuffling: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/69a430162d80
>>>> Original review here: http://mail.openjdk.java.net/pipermail/compiler-dev/2014-November/009161.html
>>>> 
>>>> cheers
>>>> /Joel
>>> 
>> 



More information about the jdk8u-dev mailing list