[8u-dev] Request for approval: 8055949: ByteArrayOutputStream capacity should be maximal array size permitted by VM

[Ivan Gerasimov]

Thanks everyone!

Special thanks to Martin for the fix :-)

Sincerely yours,
Ivan


On 17.09.2014 20:24, Rob McKenna wrote:
> Hi Ivan,
>
> Approved, but we'd like to bring the test in too. Thanks,
>
>     -Rob
>
> On 16/09/14 20:24, Ivan Gerasimov wrote:
>>
>> On 16.09.2014 23:13, Rob McKenna wrote:
>>> Hi Ivan,
>>>
>>> Can you give some detail around why the test is ignored?
>>>
>> The test was mark ignored from the very beginning.
>> This is because the test needs to allocate quite a huge array.
>> The test is still useful for QA, but is not meant to be run in 
>> automatic mode.
>>
>> Please see the original explanation from Martin about this matter:
>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028336.html 
>>
>>
>> Sincerely yours,
>> Ivan
>>> -Rob
>>>
>>> On 16/09/14 19:50, Martin Buchholz wrote:
>>>> On Tue, Sep 16, 2014 at 11:33 AM, Ivan Gerasimov 
>>>> <ivan.gerasimov at oracle.com>
>>>> wrote:
>>>>
>>>>> Hello!
>>>>>
>>>>> We've got a request to backport this recent fix, which helps in 
>>>>> dealing
>>>>> with BAOSes of large size.
>>>>>
>>>> Pleasantly surprised!
>>>>
>>>>
>>>>> The unshuffled patch applies cleanly.
>>>>> However I suggest to backport it without the regression test, and 
>>>>> I have
>>>>> two reasons for that:
>>>>>
>>>> It doesn't make much difference, but I would include the test in the
>>>> backport.
>>>>
>>>>
>>>>> First, it is @ignored.
>>>>> Second, it has a mixed copyright header: with Google's name at the 
>>>>> top and
>>>>> Oracle's contacts at the bottom.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055949
>>>>> Change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/raw-rev/1522c5bb84df
>>>>> Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-
>>>>> August/028334.html
>>>>>
>>>>> Would you please approve this backport?
>>>>>
>>>> I support this request.
>>>>
>>>>
>>>>> Sincerely yours,
>>>>> Ivan
>>>>>
>>>
>>>
>>>
>>
>
>
>