RfA: JDK-8133897, ACC: IndexOutOfBounds exception being thrown

[Rob McKenna]

Nope, new bug is the way to go.

	-Rob

On 20/08/15 23:06, Pete Brunet wrote:
>
>
> On 8/20/15 4:36 PM, Pete Brunet wrote:
>>
>> On 8/20/15 4:27 PM, Pete Brunet wrote:
>>> Thanks Rob, I'll investigate and open another bug if I see that I can
>>> test it since 8133897 is already pushed/resolved.  -Pete
>> unless there is a way to update the existing changeset?
> or update an existing resolved bug with an additional changeset?
>>> On 8/20/15 4:24 PM, Rob McKenna wrote:
>>>> If it can be tested I'd say it should have a test. If not then
>>>> noreg-hard.
>>>>
>>>> Is there a test for getBounds generally? Perhaps this could be added
>>>> to it.
>>>>
>>>>      -Rob
>>>>
>>>> On 20/08/15 22:07, Pete Brunet wrote:
>>>>> Hi Rob, I asked on the swing-dev list but didn't get an answer yet so
>>>>> maybe I can get one here.  The question is if this simple fix qualifies
>>>>> for a noreg-trivial tag.
>>>>>
>>>>> Pete
>>>>>
>>>>> On 8/20/15 3:50 PM, Rob McKenna wrote:
>>>>>> Approved for 8u-dev. Please add an appropriate noreg label.
>>>>>>
>>>>>>       -Rob
>>>>>>
>>>>>> On 20/08/15 21:43, Pete Brunet wrote:
>>>>>>> Requesting approval to backport the 9 fix for JDK-8133897 into 8u.
>>>>>>>
>>>>>>> 9 Bug: https://bugs.openjdk.java.net/browse/JDK-8133897
>>>>>>> 8u backport bug:  https://bugs.openjdk.java.net/browse/JDK-8134001
>>>>>>> 9 Fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/9cad345fb47b
>>>>>>>
>>>>>>> It will be the same fix with the path adjusted for the 8u to 9
>>>>>>> restructuring.
>>>>>>>
>>>>>>> It's a simple patch:
>>>>>>>
>>>>>>>             public Rectangle getBounds() {
>>>>>>> -            return parent.getUI().getTabBounds(parent,
>>>>>>> -
>>>>>>> parent.indexOfTab(title));
>>>>>>> +            int i = parent.indexOfTab(title);
>>>>>>> +            // Check for no title. Even though that's a bug in the
>>>>>>> app
>>>>>>> we should
>>>>>>> +            // inhibit an ArrayIndexOutOfBoundsException from
>>>>>>> getTabBounds.
>>>>>>> +            return (i == -1) ? null :
>>>>>>> parent.getUI().getTabBounds(parent, i);
>>>>>>>             }
>>>>>>>
>>>>>>> Thanks, Pete
>>>>>>>
>