RfA: JDK-8133897, ACC: IndexOutOfBounds exception being thrown

[Pete Brunet]

Hi Sergery, Did you mean "pushed without approvals" or "pushed without
approved reviews"?  Do we now need approvals for pushes into 9 client?

I received two +1s on my RfR before pushing the patch.  The related
discussion was not about the patch but about how the bug might have been
exposed in the first place.

The only issue I have right now (other than possibly the issue you
raised about an RfA vs RfR approval) is that I need to create a
regression test.  I am working on that, JDK-8134116.

Pete

On 8/21/15 4:34 AM, Sergey Bylokhov wrote:
> HI, Pete.
> This request should be rejected since the fix to jdk9 was pushed
> without approvals. As far as I understand discussion on the swing-dev
> alias still in progress.
>
> On 20.08.15 23:43, Pete Brunet wrote:
>> Requesting approval to backport the 9 fix for JDK-8133897 into 8u.
>>
>> 9 Bug: https://bugs.openjdk.java.net/browse/JDK-8133897
>> 8u backport bug:  https://bugs.openjdk.java.net/browse/JDK-8134001
>> 9 Fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/9cad345fb47b
>>
>> It will be the same fix with the path adjusted for the 8u to 9
>> restructuring.
>>
>> It's a simple patch:
>>
>>           public Rectangle getBounds() {
>> -            return parent.getUI().getTabBounds(parent,
>> -                                              
>> parent.indexOfTab(title));
>> +            int i = parent.indexOfTab(title);
>> +            // Check for no title. Even though that's a bug in the app
>> we should
>> +            // inhibit an ArrayIndexOutOfBoundsException from
>> getTabBounds.
>> +            return (i == -1) ? null :
>> parent.getUI().getTabBounds(parent, i);
>>           }
>>
>> Thanks, Pete
>>
>
>