RFR: JDK-8068028 - JNI exception pending in jdk/src/solaris/native/java/net

Chris Hegarty chris.hegarty at oracle.com
Wed Jan 21 21:42:12 UTC 2015


> On 21 Jan 2015, at 21:11, Mark Sheppard <mark.sheppard at oracle.com> wrote:
> 
> update webrev with  suggested amendments
> http://cr.openjdk.java.net/~msheppar/8068028/webrev.02/

Looks good Mark.

-Chris.

> regards
> Mark
> 
>> On 21/01/2015 17:33, Seán Coffey wrote:
>> Hi Mark,
>> 
>> does line 121 in net_util_md.c also require a NULL check ?
>> While we're here, what about line 230 in src/solaris/native/java/net/NetworkInterface.c ?
>> 
>> For the Inet6AddressImpl.c change, do you need to call cleanupAndReturn like the Inet4 implementation ?
>> 
>> regards,
>> Sean.
>> 
>>> On 21/01/15 17:11, Mark Sheppard wrote:
>>> Hi
>>>  please oblige and review the following changes
>>> http://cr.openjdk.java.net/~msheppar/8068028/webrev/
>>> which address the issue
>>> https://bugs.openjdk.java.net/browse/JDK-8068028
>>> 
>>> CHECK_NULL added to JNI function call  returns in
>>> src/solaris/native/java/net/Inet6AddressImpl.c
>>> src/solaris/native/java/net/net_util_md.c
>>> 
>>> regards
>>> Mark
>>> 
>>> 
>>> 
>>> 
>> 
> 


More information about the jdk8u-dev mailing list