RFR: JDK-8068028 - JNI exception pending in jdk/src/solaris/native/java/net

[Mark Sheppard]

OK .. thanks Sean, Chris for reviews

On 21/01/2015 22:09, Seán Coffey wrote:
> I thought there was still a possibility to have a NULL value floating 
> around. In any case, I'm not seeing ni_defaultIndexID being used. 
> Wondering if it's a necessary call. Not an issue for this bug fix. 
> Your changes look fine to me also.
>
> regards,
> Sean.
>
> On 21/01/2015 21:55, Mark Sheppard wrote:
>> Hi Sean,
>>     you could put one in, but the JNI call is the last statement in 
>> the function, so the CHECK_NULL would be
>> superfluous as the return from the function is executed next, as as 
>> such there is no possible conflict with another JNI call
>> at that point.
>>
>> 230     ni_defaultIndexID = (*env)->GetStaticFieldID(env, ni_class, 
>> "defaultIndex", "I");
>> 231 }
>>
>>
>>
>> Maybe for consistency and style?
>>
>> I did amend a couple of minor issues in NetworkInterface.c
>>
>> regards
>> Mark
>> On 21/01/2015 21:48, Seán Coffey wrote:
>>> Hi Mark,
>>>
>>> does line 230 in NetworkInterface.c still need a NULL check ?
>>>
>>> regards,
>>> Sean.
>>>
>>>>   230     ni_defaultIndexID = (*env)->GetStaticFieldID(env, 
>>>> ni_class, "defaultIndex", "I");
>>>
>>> On 21/01/2015 21:42, Chris Hegarty wrote:
>>>>> On 21 Jan 2015, at 21:11, Mark Sheppard <mark.sheppard at oracle.com> 
>>>>> wrote:
>>>>>
>>>>> update webrev with  suggested amendments
>>>>> http://cr.openjdk.java.net/~msheppar/8068028/webrev.02/
>>>> Looks good Mark.
>>>>
>>>> -Chris.
>>>>
>>>>> regards
>>>>> Mark
>>>>>
>>>>>> On 21/01/2015 17:33, Seán Coffey wrote:
>>>>>> Hi Mark,
>>>>>>
>>>>>> does line 121 in net_util_md.c also require a NULL check ?
>>>>>> While we're here, what about line 230 in 
>>>>>> src/solaris/native/java/net/NetworkInterface.c ?
>>>>>>
>>>>>> For the Inet6AddressImpl.c change, do you need to call 
>>>>>> cleanupAndReturn like the Inet4 implementation ?
>>>>>>
>>>>>> regards,
>>>>>> Sean.
>>>>>>
>>>>>>> On 21/01/15 17:11, Mark Sheppard wrote:
>>>>>>> Hi
>>>>>>>   please oblige and review the following changes
>>>>>>> http://cr.openjdk.java.net/~msheppar/8068028/webrev/
>>>>>>> which address the issue
>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8068028
>>>>>>>
>>>>>>> CHECK_NULL added to JNI function call  returns in
>>>>>>> src/solaris/native/java/net/Inet6AddressImpl.c
>>>>>>> src/solaris/native/java/net/net_util_md.c
>>>>>>>
>>>>>>> regards
>>>>>>> Mark
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>
>>
>