[8u60] Request for Approval: 8066773: JSON-friendly wrapper for objects

Attila Szegedi attila.szegedi at oracle.com
Wed Jun 3 11:19:44 UTC 2015


Okay, spoke too soon about cleanly applying changes; they do apply cleanly, but are otherwise insufficient, as I discovered in pre-commit testing. I uploaded and got reviewed a 8u-dev specific webrev too, so please approve that separately:

jdk8u-dev webrev: http://cr.openjdk.java.net/~attila/8066773/webrev.8u-dev
jdk8u-dev review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-June/004649.html

Thanks,
  Attila.

> On Jun 2, 2015, at 12:51 PM, Attila Szegedi <attila.szegedi at oracle.com> wrote:
> 
> Thank you for bringing this to my attention, Seán. I got in contact with the documentation team about this. I will try to ensure that we republish Nashorn JavaDoc for 8u60, or lacking that, add a release notes entry.
> 
> Thanks,
>  Attila.
> 
>> On Jun 2, 2015, at 11:23 AM, Seán Coffey <sean.coffey at oracle.com> wrote:
>> 
>> Attila,
>> 
>> I'm not sure if you've plans to get docs [1] republished in this area for 8u60. If not, it might be good to ensure this new method is captured in 8u60 release notes.
>> 
>> Approved.
>> 
>> [1] https://docs.oracle.com/javase/8/docs/jdk/api/nashorn/jdk/nashorn/api/scripting/ScriptObjectMirror.html
>> 
>> Regards,
>> Sean.
>> 
>> 
>> On 02/06/2015 10:00, Attila Szegedi wrote:
>>> Please approve.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8066773
>>> jdk9 webrev: http://cr.openjdk.java.net/~attila/8066773/webrev.00
>>> jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004625.html
>>> Approved CCC request: http://ccc.us.oracle.com/8066773
>>> 
>>> Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. CCC request was filed and approved because of addition of a new method to the ScriptObjectMirror exported API.
>>> 
>>> Thanks,
>>>  Attila.
>> 
> 



More information about the jdk8u-dev mailing list