[8u-60] request for review and approval to backport JDK-8080842: Using Lambda Expression with name clash results in ClassFormatError

[Jan Lahoda]

Thanks, Sean. Pushed.

Jan

On 5.6.2015 10:19, Seán Coffey wrote:
> Your approach seems fine Jan. The @modules tag is new for JDK 9 and can
> be ignored/removed for JDK8u and earlier releases.
>
> Regards,
> Sean.
>
> On 05/06/2015 08:00, Jan Lahoda wrote:
>> Hi,
>>
>> Right before pushing the change, I realized that one of the tests is
>> using the @modules tags, which seems inappropriate for 8u. Any
>> guidance on what to do when backporting tests with the @modules tags?
>>
>> For this patch, an updated webrev where the @modules tags are removed
>> from the test is here:
>> http://cr.openjdk.java.net/~jlahoda/8080842-8/webrev.01/
>>
>> Does this seem fine, or are there any objections?
>>
>> Thanks,
>>     Jan
>>
>> On 4.6.2015 10:29, Seán Coffey wrote:
>>> Approved.
>>>
>>> Regards,
>>> Sean.
>>>
>>> On 04/06/2015 05:12, Srikanth wrote:
>>>>
>>>>
>>>> On Thursday 04 June 2015 02:02 AM, Jan Lahoda wrote:
>>>>> Hello,
>>>>>
>>>>> I'd like to ask for a code review
>>>>
>>>> The 8u changes look good to me.
>>>>
>>>> Thanks
>>>> Srikanth
>>>>
>>>>> and an approval to backport the following fix to 8u-dev:
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8080842
>>>>> jdk9 fix:
>>>>> http://hg.openjdk.java.net/jdk9/dev/langtools/rev/283c9951fd23
>>>>>
>>>>> The fix does not apply cleanly to 8u-dev/langtools. The webrev for
>>>>> 8u-dev is here:
>>>>> http://cr.openjdk.java.net/~jlahoda/8080842-8/webrev.00/
>>>>>
>>>>> Notable changes between the jdk9 and 8u-dev fixes:
>>>>> -in Scope, using an anonymous innerclass instead of a lambda for
>>>>> filter
>>>>> -in RemoveSymbolUnitTest.java, several changes to adjust to Scope as
>>>>> it was in 8 (WriteableScope.create -> new Scope; Scope.findFirst ->
>>>>> Scope.lookup(...).sym).
>>>>>
>>>>> Thanks,
>>>>>     Jan
>>>>
>>>
>