[8u60] request for review: 8068489: remove unnecessary complexity in Flow and Bits, after JDK-8064857

[Vicente-Arturo Romero-Zaldivar]

Hi Maurizio,

On 06/10/2015 04:33 PM, Maurizio Cimadamore wrote:
> It generally looks good - I found however some differences with the 
> code in 9:
>
> * we seem to have replaced 'new ListBuffer<P>' with 'new 
> ListBuffer<PendingExit>' - the 9 version simply uses diamond; I think 
> we could so the same (also to minimize diffs)
> * indentation seems to be off (likely as a result of the merge) esp. 
> in AssignAnalyzer.{letInit,visitClassDef,visitMethodDef}

yep, good catch!

I have fixed those issues. I have published a new review at: 
http://cr.openjdk.java.net/~vromero/8068489/webrev.01/

Thanks,
Vicente

>
> Maurizio
>
> On 05/06/15 23:03, Vicente-Arturo Romero-Zaldivar wrote:
>> Hi,
>>
>> Please review the backport of bug:
>>
>> 8068489: remove unnecessary complexity in Flow and Bits, after 
>> JDK-8064857
>>
>> JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8068489
>> backport: https://bugs.openjdk.java.net/browse/JDK-8068547
>> original patch pushed to 9: 
>> http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/5e500700b168
>> public review: http://cr.openjdk.java.net/~vromero/8068489/webrev/
>>
>> The original patch doesn't apply cleanly. There are no major 
>> differences but I think that there are enough to deserve a review.
>>
>> Thanks,
>> Vicente
>