RfR and RfA: Backport of JDK-8055831 Open Source Java Access Bridge

Pete Brunet peter.brunet at oracle.com
Sat Mar 28 00:30:30 UTC 2015


Please review and approve a backport of JDK-8055831 to open source the
Java Access Bridge.  The original patch has been pushed to 9 and the
backport now needs to be pushed to 8u.

Due to the significant directory structure changes in 9 due to
modularization I could not simply apply the patch.  However the effect
is functionally the same.  Here are the changes:

- moved the JAB files from closed to open
- change the copyright headers to open style
- adjust the make files accordingly
- create javadoc for com.sun.java.accessibility.util; creates it in
docs/jre/api/accessibility/jaccess/spec
- removed extraneous unused files; these are tools inadvertently picked
up in 7u6 when the JAB was first integrated and which will be added later
- removed some dead code
- cleaned up comments/documentation
- cleaned up some code indentation issues
- in package-private EventQueueMonitor.addTopLevelWindow the return
value was not used so I changed the return from boolean to void

The open part of the patch is here:
http://cr.openjdk.java.net/~ptbrunet/JDK-8076182/webrev.00/

(I see I have five copyright dates to fix in jdk/make.)

There is a closed part but it's just the removal of the source files
from the closed repository.

The patch has been through a successful 32/64 bit JPRT build and
subsequent testing on my machine

This patch needs to be pushed by Tuesday so I'll appreciate your review.

Thanks, Pete


More information about the jdk8u-dev mailing list