From alejandro.murillo at oracle.com Fri May 1 13:22:01 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 01 May 2015 07:22:01 -0600 Subject: [8u60] Request for approval for bulk integration of hs25.60-b14 Message-ID: <55437DF9.1030302@oracle.com> Requesting approval to integrate hs25.60-b14 into jdk8u60-b14. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b14-jdk8u60-b14.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8038098: [TESTBUG] remove explicit set build flavor from hotspot/test/compiler/* tests 8049536: os::commit_memory on Solaris uses aligment_hint as page size 8049864: TestParallelHeapSizeFlags fails with unexpected heap size 8050486: compiler/rtm/ tests fail due to monitor deflation at safepoint synchronization 8053995: Add method to WhiteBox to get vm pagesize. 8058354: SPECjvm2008-Derby -2.7% performance regression on Solaris-X64 starting with 9-b29 8058846: c.o.j.t.Platform::isX86 and isX64 may simultaneously return true 8062280: C2: inlining failure due to access checks being too strict 8062537: [TESTBUG] Conflicting GC combinations in hotspot tests 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared 8066875: VirtualSpace does not use large pages 8067469: G1 ignores AlwaysPreTouch 8067648: JVM crashes reproducible with GCM cipher suites in GCTR doFinal 8068272: Extend WhiteBox API with methods that check monitor state and force safepoint 8068915: uncommon trap w/ Reason_speculate_class_check causes performance regression due to continuous deoptimizations 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact 8071788: BlockInliningWrapper.asType() is broken 8072863: Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath 8073705: more performance issues in class redefinition 8074548: Never-taken branches cause repeated deopts in MHs.GWT case 8077054: DMH LFs should be customizeable 8077255: TracePageSizes output reports wrong page size on Windows with G1 8078043: new hotspot build - hs25.60-b13 8078270: new hotspot build - hs25.60-b14 8078375: [TESTBUG] gc/g1/TestLargePageUseForAuxMemory.java specifies wrong library path 8078470: [Linux] Replace syscall use in os::fork_and_exec with glibc fork() and execve() 8078482: ppc: pass thread to throw_AbstractMethodError -- Alejandro From maurizio.cimadamore at oracle.com Fri May 1 15:41:47 2015 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Fri, 01 May 2015 16:41:47 +0100 Subject: [8u60] Request for approval 8064803: Javac erroneously uses instantiated signatures when merging abstract most-specific methods Message-ID: <55439EBB.6090706@oracle.com> Hello, This is a request for approval to backport a fix from the jdk9 to the jdk8u-dev repository. Changes applies cleanly to jdk8u-dev after path reshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8064803 jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/6641bd634136 Cheers Maurizio From sean.coffey at oracle.com Fri May 1 15:43:09 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 01 May 2015 16:43:09 +0100 Subject: [8u60] Request for approval 8064803: Javac erroneously uses instantiated signatures when merging abstract most-specific methods In-Reply-To: <55439EBB.6090706@oracle.com> References: <55439EBB.6090706@oracle.com> Message-ID: <55439F0D.5000400@oracle.com> Approved. Regards, Sean. On 01/05/15 16:41, Maurizio Cimadamore wrote: > Hello, > This is a request for approval to backport a fix from the jdk9 to the > jdk8u-dev repository. > Changes applies cleanly to jdk8u-dev after path reshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8064803 > jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/6641bd634136 > > Cheers > Maurizio From alejandro.murillo at oracle.com Mon May 4 17:41:52 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Mon, 04 May 2015 11:41:52 -0600 Subject: [8u60] Request for approval for bulk integration of hs25.60-b14 In-Reply-To: <55437DF9.1030302@oracle.com> References: <55437DF9.1030302@oracle.com> Message-ID: <5547AF60.3020606@oracle.com> Hi guys, haven't seen a reply to this. can you please approve Thanks Alejandro On 5/1/2015 7:22 AM, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.60-b14 into jdk8u60-b14. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b14-jdk8u60-b14.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8038098: [TESTBUG] remove explicit set build flavor from > hotspot/test/compiler/* tests > 8049536: os::commit_memory on Solaris uses aligment_hint as page size > 8049864: TestParallelHeapSizeFlags fails with unexpected heap size > 8050486: compiler/rtm/ tests fail due to monitor deflation at > safepoint synchronization > 8053995: Add method to WhiteBox to get vm pagesize. > 8058354: SPECjvm2008-Derby -2.7% performance regression on Solaris-X64 > starting with 9-b29 > 8058846: c.o.j.t.Platform::isX86 and isX64 may simultaneously return true > 8062280: C2: inlining failure due to access checks being too strict > 8062537: [TESTBUG] Conflicting GC combinations in hotspot tests > 8063137: Never-taken branches should be pruned when GWT LambdaForms > are shared > 8066875: VirtualSpace does not use large pages > 8067469: G1 ignores AlwaysPreTouch > 8067648: JVM crashes reproducible with GCM cipher suites in GCTR doFinal > 8068272: Extend WhiteBox API with methods that check monitor state and > force safepoint > 8068915: uncommon trap w/ Reason_speculate_class_check causes > performance regression due to continuous deoptimizations > 8069591: Customize LambdaForms which are invoked using > MH.invoke/invokeExact > 8071788: BlockInliningWrapper.asType() is broken > 8072863: Replace fatal() with vm_exit_during_initialization() when an > incorrect class is found on the bootclasspath > 8073705: more performance issues in class redefinition > 8074548: Never-taken branches cause repeated deopts in MHs.GWT case > 8077054: DMH LFs should be customizeable > 8077255: TracePageSizes output reports wrong page size on Windows with G1 > 8078043: new hotspot build - hs25.60-b13 > 8078270: new hotspot build - hs25.60-b14 > 8078375: [TESTBUG] gc/g1/TestLargePageUseForAuxMemory.java specifies > wrong library path > 8078470: [Linux] Replace syscall use in os::fork_and_exec with glibc > fork() and execve() > 8078482: ppc: pass thread to throw_AbstractMethodError > -- Alejandro From lana.steuck at oracle.com Mon May 4 19:32:50 2015 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 4 May 2015 12:32:50 -0700 (PDT) Subject: jdk8u-b14: jdk8u-dev Message-ID: <201505041932.t44JWoLh006389@sc11152554.us.oracle.com> http://hg.openjdk.java.net/jdk8u/jdk8u/rev/455a74ebdf59 http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/24e7c53c5716 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/a136ed2f3041 http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/02fd713f25df http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/feb70717506d http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/ddb4bf8a306a http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/b0f52462883d http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/c4108e15fbde --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-7145508 client-libs [embedded] java.awt.GraphicsDevice.get/setDisplayMode behavior is inco JDK-8076106 client-libs [macosx] Drag image of TransferHandler does not honor MultiResolutionI JDK-8068412 client-libs [macosx] Initialization of Cocoa hangs if CoreAudio was initialized be JDK-8015085 client-libs [macosx] Label shortening via " ... " broken when String contains co JDK-8078165 client-libs [macosx] NPE when attempting to get image from toolkit JDK-4952954 client-libs abort flag is not cleared for every write operation for JPEG ImageWrit JDK-6573305 client-libs Animated icon is not visible by click on menu JDK-8074956 client-libs ArrayIndexOutOfBoundsException in javax.swing.text.html.parser.Conten JDK-6475361 client-libs Attempting to remove help menu from java.awt.MenuBar throws NullPointe JDK-8066132 client-libs BufferedImage::getPropertyNames() always returns null JDK-8078654 client-libs CloseTTFontFileFunc callback should be removed JDK-8067657 client-libs Dead/outdated links in Javadoc of package java.beans JDK-6515713 client-libs example in JFormattedTextField API docs instantiates abstract class JDK-8051617 client-libs Fullscreen mode is not working properly on Xorg JDK-8077982 client-libs GIFLIB upgrade JDK-8076455 client-libs IME Composition Window is displayed on incorrect position JDK-8074500 client-libs java.awt.Checkbox.setState() call causes ItemEvent to be filed JDK-8073001 client-libs Java's system LnF on OS X: editable JComboBoxes are being rendered in JDK-6459798 client-libs JDesktopPane,JFileChooser violate encapsulation by returning internal JDK-8073795 client-libs JMenuBar looks bad under retina JDK-4958064 client-libs JPGWriter does not throw UnsupportedException when canWriteSequence re JDK-6338077 client-libs link back to self in javadoc JTextArea.replaceRange() JDK-8043393 client-libs NullPointerException and no event received when clipboard data flavor JDK-7180976 client-libs Pending String deadlocks UIDefaults JDK-6459800 client-libs Some Swing classes violate encapsulation by returning internal Insets JDK-6470361 client-libs Swing's Threading Policy example does not compile JDK-8044444 client-libs The output's 'Page-n' footer does not show completely. JDK-7044727 core-libs (tz) TimeZone.getDefault() call returns incorrect value in Windows ter JDK-8053905 core-libs Eager code generation fails for earley boyer with split threshold set JDK-8066407 core-libs Function with same body not reparsed after SyntaxError JDK-6991580 core-libs IPv6 Nameservers in resolv.conf throws NumberFormatException JDK-8076287 core-libs Performance degradation observed with TimeZone Benchmark JDK-8074350 core-libs Support ISO 4217 "Current funds codes" table (A.2) JDK-8078384 core-libs Test execution blocker: Nashorn testsuite failing due to compile error JDK-8077953 core-svc [TEST_BUG] com/sun/management/OperatingSystemMXBean/TestTotalSwap.java JDK-8075331 hotspot jdb eval java.util.Arrays.asList(array) shows inconsistent behaviour JDK-8050825 infrastructure Support running regression tests using jtreg_tests+TESTDIRS from top l JDK-8078348 security-libs [TEST_BUG] sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java fails JDK-8064546 security-libs CipherInputStream throws BadPaddingException if stream is not fully re JDK-8077786 tools Check varargs access against inferred signature JDK-8075520 tools Varargs access check mishandles capture variables JDK-8061778 tools Wrong LineNumberTable for default constructors JDK-8073357 xml schema1.xsd has wrong content. Sequence of the enum values has been ch From sean.coffey at oracle.com Tue May 5 08:10:35 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 05 May 2015 09:10:35 +0100 Subject: [8u60] Request for approval for bulk integration of hs25.60-b14 In-Reply-To: <5547AF60.3020606@oracle.com> References: <55437DF9.1030302@oracle.com> <5547AF60.3020606@oracle.com> Message-ID: <55487AFB.1050305@oracle.com> Approved pending positive PIT results. Regards, Sean. On 04/05/2015 18:41, Alejandro E Murillo wrote: > > Hi guys, > haven't seen a reply to this. > can you please approve > > Thanks > Alejandro > > On 5/1/2015 7:22 AM, Alejandro E Murillo wrote: >> Requesting approval to integrate hs25.60-b14 into jdk8u60-b14. >> >> A webrev is available at: >> >> http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b14-jdk8u60-b14.webrev/ >> >> >> Pre-integration testing is in progress; the integration will proceed >> only after SQE has analyzed the results and approved. >> >> The fixes in the proposed integration are below. All have undergone >> nightly testing and are already in a jdk9 repository. >> >> 8038098: [TESTBUG] remove explicit set build flavor from >> hotspot/test/compiler/* tests >> 8049536: os::commit_memory on Solaris uses aligment_hint as page size >> 8049864: TestParallelHeapSizeFlags fails with unexpected heap size >> 8050486: compiler/rtm/ tests fail due to monitor deflation at >> safepoint synchronization >> 8053995: Add method to WhiteBox to get vm pagesize. >> 8058354: SPECjvm2008-Derby -2.7% performance regression on >> Solaris-X64 starting with 9-b29 >> 8058846: c.o.j.t.Platform::isX86 and isX64 may simultaneously return >> true >> 8062280: C2: inlining failure due to access checks being too strict >> 8062537: [TESTBUG] Conflicting GC combinations in hotspot tests >> 8063137: Never-taken branches should be pruned when GWT LambdaForms >> are shared >> 8066875: VirtualSpace does not use large pages >> 8067469: G1 ignores AlwaysPreTouch >> 8067648: JVM crashes reproducible with GCM cipher suites in GCTR doFinal >> 8068272: Extend WhiteBox API with methods that check monitor state >> and force safepoint >> 8068915: uncommon trap w/ Reason_speculate_class_check causes >> performance regression due to continuous deoptimizations >> 8069591: Customize LambdaForms which are invoked using >> MH.invoke/invokeExact >> 8071788: BlockInliningWrapper.asType() is broken >> 8072863: Replace fatal() with vm_exit_during_initialization() when an >> incorrect class is found on the bootclasspath >> 8073705: more performance issues in class redefinition >> 8074548: Never-taken branches cause repeated deopts in MHs.GWT case >> 8077054: DMH LFs should be customizeable >> 8077255: TracePageSizes output reports wrong page size on Windows >> with G1 >> 8078043: new hotspot build - hs25.60-b13 >> 8078270: new hotspot build - hs25.60-b14 >> 8078375: [TESTBUG] gc/g1/TestLargePageUseForAuxMemory.java specifies >> wrong library path >> 8078470: [Linux] Replace syscall use in os::fork_and_exec with glibc >> fork() and execve() >> 8078482: ppc: pass thread to throw_AbstractMethodError >> > From erik.joelsson at oracle.com Tue May 5 10:56:56 2015 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 05 May 2015 12:56:56 +0200 Subject: [8u60] Request for approval 8079087: Add support for Cygwin 2.0 Message-ID: <5548A1F8.4050809@oracle.com> Hello, I would like to backport "8079087: Add support for Cygwin 2.0" so that the community may continue building jdk8u with the current versions of Cygwin. Patch from jdk9 applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-8079087 JDK 9 review: http://mail.openjdk.java.net/pipermail/build-dev/2015-May/014897.html /Erik From sean.coffey at oracle.com Tue May 5 11:15:53 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 05 May 2015 12:15:53 +0100 Subject: [8u60] Request for approval 8079087: Add support for Cygwin 2.0 In-Reply-To: <5548A1F8.4050809@oracle.com> References: <5548A1F8.4050809@oracle.com> Message-ID: <5548A669.3080606@oracle.com> Approved. Please add a noreg-build label to bug report. Regards, Sean. On 05/05/2015 11:56, Erik Joelsson wrote: > Hello, > > I would like to backport "8079087: Add support for Cygwin 2.0" so that > the community may continue building jdk8u with the current versions of > Cygwin. Patch from jdk9 applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079087 > JDK 9 review: > http://mail.openjdk.java.net/pipermail/build-dev/2015-May/014897.html > > /Erik From alejandro.murillo at oracle.com Tue May 5 13:29:46 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 05 May 2015 07:29:46 -0600 Subject: jdk8u60-b14: HotSpot Message-ID: <5548C5CA.4050301@oracle.com> hs25.60-b14 has been integrated into jdk8u60-b14. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/455a74ebdf59 http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/c4108e15fbde http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/c9f8b7319d0a http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/ddb4bf8a306a http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/feb70717506d http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/3ad03712ea43 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/a136ed2f3041 http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/24e7c53c5716 Component : VM Status : 0 major failures, 0 minor failures Date : 05/05/2015 at 14:30 MSK Tested By : STT_VM Cost(total man-days): 1 Workspace : 2015-04-30-221008.amurillo.hs25-60-b14-snapshot Bundles : 2015-04-30-221008.amurillo.hs25-60-b14-snapshot Platforms : Others Tests : Log : link Browsers : NA Patches : NA Number of Tests Executed : 314858 passed tests, 3794 failed tests (no new failures) Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: 8038098: [TESTBUG] remove explicit set build flavor from hotspot/test/compiler/* tests 8049536: os::commit_memory on Solaris uses aligment_hint as page size 8049864: TestParallelHeapSizeFlags fails with unexpected heap size 8050486: compiler/rtm/ tests fail due to monitor deflation at safepoint synchronization 8053995: Add method to WhiteBox to get vm pagesize. 8058354: SPECjvm2008-Derby -2.7% performance regression on Solaris-X64 starting with 9-b29 8058846: c.o.j.t.Platform::isX86 and isX64 may simultaneously return true 8062280: C2: inlining failure due to access checks being too strict 8062537: [TESTBUG] Conflicting GC combinations in hotspot tests 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared 8066875: VirtualSpace does not use large pages 8067469: G1 ignores AlwaysPreTouch 8067648: JVM crashes reproducible with GCM cipher suites in GCTR doFinal 8068272: Extend WhiteBox API with methods that check monitor state and force safepoint 8068915: uncommon trap w/ Reason_speculate_class_check causes performance regression due to continuous deoptimizations 8069591: Customize LambdaForms which are invoked using MH.invoke/invokeExact 8071788: BlockInliningWrapper.asType() is broken 8072863: Replace fatal() with vm_exit_during_initialization() when an incorrect class is found on the bootclasspath 8073705: more performance issues in class redefinition 8074548: Never-taken branches cause repeated deopts in MHs.GWT case 8077054: DMH LFs should be customizeable 8077255: TracePageSizes output reports wrong page size on Windows with G1 8078043: new hotspot build - hs25.60-b13 8078270: new hotspot build - hs25.60-b14 8078375: [TESTBUG] gc/g1/TestLargePageUseForAuxMemory.java specifies wrong library path 8078470: [Linux] Replace syscall use in os::fork_and_exec with glibc fork() and execve() 8078482: ppc: pass thread to throw_AbstractMethodError New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: 8079336: Hprof fail with ASSERTION FAILURE: is_array==JNI_TRUE [hprof_reference.c:622] Number of PIT requested: 1 Integration target J2SE build number: jdk8u60-b14 Issues and Notes: This is PIT for HS25.60-b14 for jdk8u60-b14. GO for integration. -- Alejandro From semyon.sadetsky at oracle.com Tue May 5 15:23:47 2015 From: semyon.sadetsky at oracle.com (Semyon Sadetsky) Date: Tue, 05 May 2015 18:23:47 +0300 Subject: [8u-dev] Request for approval 8072769: System tray icon title freezes java Message-ID: <5548E083.7000406@oracle.com> Hello, Could you approve the back-port for the fix for 8072769 to jdk8u-dev. The jdk9 patch applies cleanly post modular path unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8072769 jdk9 fix: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2c5f536a678a Best, --Semyon From semyon.sadetsky at oracle.com Tue May 5 15:23:53 2015 From: semyon.sadetsky at oracle.com (Semyon Sadetsky) Date: Tue, 05 May 2015 18:23:53 +0300 Subject: [8u-dev] Request for approval 8041642: Incorrect paint of JProgressBar in Nimbus LF Message-ID: <5548E089.3020405@oracle.com> Hello, Could you approve the back-port for the fix for 8041642 to jdk8u-dev. The jdk9 patch applies cleanly post modular path unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8041642 JDK 9 fix: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f8e45b6fd6c6 Best, --Semyon From sean.coffey at oracle.com Tue May 5 15:32:10 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 05 May 2015 16:32:10 +0100 Subject: [8u-dev] Request for approval 8072769: System tray icon title freezes java In-Reply-To: <5548E083.7000406@oracle.com> References: <5548E083.7000406@oracle.com> Message-ID: <5548E27A.1030502@oracle.com> Approved. Regards, Sean. On 05/05/2015 16:23, Semyon Sadetsky wrote: > Hello, > > Could you approve the back-port for the fix for 8072769 to jdk8u-dev. > The jdk9 patch applies cleanly post modular path unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8072769 > jdk9 fix: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/2c5f536a678a > > Best, > --Semyon From sean.coffey at oracle.com Tue May 5 15:32:18 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 05 May 2015 16:32:18 +0100 Subject: [8u-dev] Request for approval 8041642: Incorrect paint of JProgressBar in Nimbus LF In-Reply-To: <5548E089.3020405@oracle.com> References: <5548E089.3020405@oracle.com> Message-ID: <5548E282.1000805@oracle.com> Approved. Regards, Sean. On 05/05/2015 16:23, Semyon Sadetsky wrote: > Hello, > > Could you approve the back-port for the fix for 8041642 to jdk8u-dev. > The jdk9 patch applies cleanly post modular path unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8041642 > JDK 9 fix: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f8e45b6fd6c6 > > Best, > --Semyon From attila.szegedi at oracle.com Tue May 5 16:41:46 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 5 May 2015 18:41:46 +0200 Subject: [8u60] Request for Approval: 8075090: Add tests for the basic failure of try/finally compilation Message-ID: <2DD6F2B8-DC2B-43B7-BA62-F0B3B273DE01@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8075090 jdk9 webrev: http://cr.openjdk.java.net/~attila/8075090/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-March/004334.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Tue May 5 16:46:44 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 05 May 2015 17:46:44 +0100 Subject: [8u60] Request for Approval: 8075090: Add tests for the basic failure of try/finally compilation In-Reply-To: <2DD6F2B8-DC2B-43B7-BA62-F0B3B273DE01@oracle.com> References: <2DD6F2B8-DC2B-43B7-BA62-F0B3B273DE01@oracle.com> Message-ID: <5548F3F4.1000109@oracle.com> Approved. -Rob On 05/05/15 17:41, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8075090 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8075090/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-March/004334.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From sean.coffey at oracle.com Tue May 5 17:00:44 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 05 May 2015 18:00:44 +0100 Subject: [8u-dev] Request for approval : 8078560: The crash reporting URL listed by javac needs to be updated Message-ID: <5548F73C.8070201@oracle.com> Simple website correction which should be ported to 8u-dev. jdk9 changeset applies cleanly. bug report : https://bugs.openjdk.java.net/browse/JDK-8078560 JDK 9 changeset : http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/40058141a4ec -- Regards, Sean. From ivan.gerasimov at oracle.com Tue May 5 17:05:53 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Tue, 05 May 2015 20:05:53 +0300 Subject: [8u-dev] Request for Approval to Backport: 8078439: SPNEGO auth fails if client proposes MS krb5 OID Message-ID: <5548F871.3020502@oracle.com> Hello! Would you please approve porting back this security fix into jdk8u-dev? The patch applies cleanly after unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8078439 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/51f5501a54a6 Review: http://mail.openjdk.java.net/pipermail/security-dev/2015-April/012081.html The build/testing on all available platforms went fine. Sincerely yours, Ivan From rob.mckenna at oracle.com Tue May 5 17:08:04 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 05 May 2015 18:08:04 +0100 Subject: [8u-dev] Request for approval : 8078560: The crash reporting URL listed by javac needs to be updated In-Reply-To: <5548F73C.8070201@oracle.com> References: <5548F73C.8070201@oracle.com> Message-ID: <5548F8F4.7040502@oracle.com> Approved. -Rob On 05/05/15 18:00, Se?n Coffey wrote: > Simple website correction which should be ported to 8u-dev. > > jdk9 changeset applies cleanly. > > bug report : https://bugs.openjdk.java.net/browse/JDK-8078560 > JDK 9 changeset : > http://hg.openjdk.java.net/jdk9/jdk9/langtools/rev/40058141a4ec > From rob.mckenna at oracle.com Tue May 5 17:10:39 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 05 May 2015 18:10:39 +0100 Subject: [8u-dev] Request for Approval to Backport: 8078439: SPNEGO auth fails if client proposes MS krb5 OID In-Reply-To: <5548F871.3020502@oracle.com> References: <5548F871.3020502@oracle.com> Message-ID: <5548F98F.8030200@oracle.com> Approved. -Rob On 05/05/15 18:05, Ivan Gerasimov wrote: > Hello! > > Would you please approve porting back this security fix into jdk8u-dev? > The patch applies cleanly after unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8078439 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/51f5501a54a6 > Review: > http://mail.openjdk.java.net/pipermail/security-dev/2015-April/012081.html > > The build/testing on all available platforms went fine. > > Sincerely yours, > Ivan From vincent.x.ryan at oracle.com Tue May 5 18:01:07 2015 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 5 May 2015 19:01:07 +0100 Subject: [8u-dev] Request for Approval to Backport: 8079129: NullPointerException in PKCS#12 Keystore in PKCS12KeyStore.java Message-ID: <9BA6B265-6DD6-4E4D-B1C2-22F09E7C86AC@oracle.com> Please approve the backport of this security fix to jdk8u-dev. The jdk9 patch applied cleanly to jdk8u-dev, following path reshuffling. Thanks. Bug: https://bugs.openjdk.java.net/browse/JDK-8079129 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/207c1b0356ea From sean.coffey at oracle.com Tue May 5 18:13:27 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Tue, 05 May 2015 19:13:27 +0100 Subject: [8u-dev] Request for Approval to Backport: 8079129: NullPointerException in PKCS#12 Keystore in PKCS12KeyStore.java In-Reply-To: <9BA6B265-6DD6-4E4D-B1C2-22F09E7C86AC@oracle.com> References: <9BA6B265-6DD6-4E4D-B1C2-22F09E7C86AC@oracle.com> Message-ID: <55490847.9070205@oracle.com> Approved. Regards, Sean. On 05/05/2015 19:01, Vincent Ryan wrote: > Please approve the backport of this security fix to jdk8u-dev. > The jdk9 patch applied cleanly to jdk8u-dev, following path reshuffling. > Thanks. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079129 > JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/207c1b0356ea > From vincent.x.ryan at oracle.com Tue May 5 18:25:30 2015 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Tue, 5 May 2015 19:25:30 +0100 Subject: [8u-dev] Request for Approval to Backport: 8079129: NullPointerException in PKCS#12 Keystore in PKCS12KeyStore.java In-Reply-To: <55490847.9070205@oracle.com> References: <9BA6B265-6DD6-4E4D-B1C2-22F09E7C86AC@oracle.com> <55490847.9070205@oracle.com> Message-ID: <7D23C399-75EC-4FEB-90B4-694790E344FC@oracle.com> Ta. > On 5 May 2015, at 19:13, Se?n Coffey wrote: > > Approved. > > Regards, > Sean. > > On 05/05/2015 19:01, Vincent Ryan wrote: >> Please approve the backport of this security fix to jdk8u-dev. >> The jdk9 patch applied cleanly to jdk8u-dev, following path reshuffling. >> Thanks. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8079129 >> JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/207c1b0356ea >> > From hannes.wallnoefer at oracle.com Wed May 6 12:56:21 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 06 May 2015 14:56:21 +0200 Subject: [8u60] Request for approval for JDK-8078049 and JDK-8078612 Message-ID: <554A0F75.8080301@oracle.com> Please approve backport of JDK-8078049 and JDK-8078612 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8078049 Webrev: http://cr.openjdk.java.net/~hannesw/8078049/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004472.html Bug: https://bugs.openjdk.java.net/browse/JDK-8078612 Webrev: http://cr.openjdk.java.net/~hannesw/8078612/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004473.html The changes apply cleanly to 8u-dev after reshuffling path names. Thanks, Hannes From sean.coffey at oracle.com Wed May 6 13:05:03 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 06 May 2015 14:05:03 +0100 Subject: [8u60] Request for approval for JDK-8078049 and JDK-8078612 In-Reply-To: <554A0F75.8080301@oracle.com> References: <554A0F75.8080301@oracle.com> Message-ID: <554A117F.7060105@oracle.com> Approved. Regards, Sean. On 06/05/15 13:56, Hannes Wallnoefer wrote: > Please approve backport of JDK-8078049 and JDK-8078612 to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8078049 > Webrev: http://cr.openjdk.java.net/~hannesw/8078049/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004472.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8078612 > Webrev: http://cr.openjdk.java.net/~hannesw/8078612/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004473.html > > The changes apply cleanly to 8u-dev after reshuffling path names. > > Thanks, > Hannes > From attila.szegedi at oracle.com Wed May 6 13:14:42 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 6 May 2015 15:14:42 +0200 Subject: [8u60] Request for Approval: 8079269: Optimistic rewrite in object literal causes ArrayIndexOutOfBoundsException Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079269 jdk9 webrev: http://cr.openjdk.java.net/~attila/8079269/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004478.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Wed May 6 13:18:20 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 06 May 2015 14:18:20 +0100 Subject: [8u60] Request for Approval: 8079269: Optimistic rewrite in object literal causes ArrayIndexOutOfBoundsException In-Reply-To: References: Message-ID: <554A149C.6080207@oracle.com> Approved. -Rob On 06/05/15 14:14, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079269 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8079269/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004478.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From attila.szegedi at oracle.com Wed May 6 14:17:53 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 6 May 2015 16:17:53 +0200 Subject: [8u60] Request for Approval: 8079349: Eliminate dead code around Nashorn code generator Message-ID: <9FA4A6DE-8BA8-4356-B50E-A2C90608F663@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079349 jdk9 webrev: http://cr.openjdk.java.net/~attila/8079349/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004481.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Wed May 6 15:19:51 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 06 May 2015 16:19:51 +0100 Subject: [8u60] Request for Approval: 8079349: Eliminate dead code around Nashorn code generator In-Reply-To: <9FA4A6DE-8BA8-4356-B50E-A2C90608F663@oracle.com> References: <9FA4A6DE-8BA8-4356-B50E-A2C90608F663@oracle.com> Message-ID: <554A3117.8000000@oracle.com> Approved. -Rob On 06/05/15 15:17, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079349 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8079349/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004481.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From gnu.andrew at redhat.com Wed May 6 15:32:59 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 6 May 2015 11:32:59 -0400 (EDT) Subject: [8u60] Request for approval 8077982: GIFLIB upgrade In-Reply-To: <554228C6.6070805@oracle.com> References: <554228C6.6070805@oracle.com> Message-ID: <1919727455.12249835.1430926379464.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Hello, > > This is a request for approval to backport a fix from the jdk9 to the > jdk8u-dev repository. > Changes applies cleanly to jdk8u-dev after path reshuffling. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8077982 > The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/5bf5794f6193 > The review: > http://mail.openjdk.java.net/pipermail/awt-dev/2015-April/009269.html > > -- > Thanks, > > Alexander. > > The splashscreen changes, such as: @@ -310,7 +296,7 @@ free(pBitmapBits); free(pOldBitmapBits); - DGifCloseFile(gif); + DGifCloseFile(gif, NULL); return 1; } @@ -318,7 +304,7 @@ int SplashDecodeGifStream(Splash * splash, SplashStream * stream) { - GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc); + GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc, NULL); if (!gif) return 0; will break system giflib builds with versions older than 5. In fixing this in IcedTea, we added #ifdefs to this code. { +#if GIFLIB_MAJOR >= 5 + int error = 0; + GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc, &error); + + if (error) + return 0; +#else GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc); if (!gif) return 0; +#endif +#if GIFLIB_MAJOR > 5 || (GIFLIB_MAJOR == 5 && GIFLIB_MINOR >= 1) + int error = 0; + DGifCloseFile(gif, &error); + if (error) + return 0; +#else DGifCloseFile(gif); +#endif -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From attila.szegedi at oracle.com Wed May 6 15:41:53 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 6 May 2015 17:41:53 +0200 Subject: [8u60] Request for Approval: 8079362: Enforce best practices for Node token API usage Message-ID: <9804141A-0B2B-455D-91EC-524D93D192D3@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079362 jdk9 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004487.html jdk8 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.8u-dev Changes apply *almost* cleanly to jdk8u-dev after path reshuffling from modular source code layout, except for these deviations: 1. the 8u-dev changeset doesn?t contain changes to Parser API files in src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree directory, as this API is 9-only. 2. the 8u-dev changeset doesn?t contain changes in the ordering of imports in Lower.java, as it is already correct in 8u-dev (it was incorrect in 9). I didn?t ask the team to review these trivial deviations; if you think it?s required I?ll ask them to do it. Thanks, Attila. From sean.coffey at oracle.com Wed May 6 15:55:52 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 06 May 2015 16:55:52 +0100 Subject: [8u60] Request for approval 8077982: GIFLIB upgrade In-Reply-To: <1919727455.12249835.1430926379464.JavaMail.zimbra@redhat.com> References: <554228C6.6070805@oracle.com> <1919727455.12249835.1430926379464.JavaMail.zimbra@redhat.com> Message-ID: <554A3988.9040004@oracle.com> Sounds like a good approach Andrew. Can you file a bug and fix in JDK 9 ? A backport should be possible then. Regards, Sean. On 06/05/15 16:32, Andrew Hughes wrote: > ----- Original Message ----- >> Hello, >> >> This is a request for approval to backport a fix from the jdk9 to the >> jdk8u-dev repository. >> Changes applies cleanly to jdk8u-dev after path reshuffling. >> >> The bug: https://bugs.openjdk.java.net/browse/JDK-8077982 >> The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/5bf5794f6193 >> The review: >> http://mail.openjdk.java.net/pipermail/awt-dev/2015-April/009269.html >> >> -- >> Thanks, >> >> Alexander. >> >> > The splashscreen changes, such as: > > @@ -310,7 +296,7 @@ > free(pBitmapBits); > free(pOldBitmapBits); > > - DGifCloseFile(gif); > + DGifCloseFile(gif, NULL); > > return 1; > } > @@ -318,7 +304,7 @@ > int > SplashDecodeGifStream(Splash * splash, SplashStream * stream) > { > - GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc); > + GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc, NULL); > > if (!gif) > return 0; > > will break system giflib builds with versions older than 5. > > In fixing this in IcedTea, we added #ifdefs to this code. > > { > +#if GIFLIB_MAJOR >= 5 > + int error = 0; > + GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc, &error); > + > + if (error) > + return 0; > +#else > GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc); > > if (!gif) > return 0; > +#endif > > +#if GIFLIB_MAJOR > 5 || (GIFLIB_MAJOR == 5 && GIFLIB_MINOR >= 1) > + int error = 0; > + DGifCloseFile(gif, &error); > + if (error) > + return 0; > +#else > DGifCloseFile(gif); > +#endif > From gnu.andrew at redhat.com Wed May 6 16:16:25 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 6 May 2015 12:16:25 -0400 (EDT) Subject: [8u60] Request for approval 8077982: GIFLIB upgrade In-Reply-To: <554A3988.9040004@oracle.com> References: <554228C6.6070805@oracle.com> <1919727455.12249835.1430926379464.JavaMail.zimbra@redhat.com> <554A3988.9040004@oracle.com> Message-ID: <734698136.12279133.1430928985201.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Sounds like a good approach Andrew. Can you file a bug and fix in JDK 9 > ? A backport should be possible then. > Yes, sure. I was planning to before 8077982, because that version wouldn't build against a system giflib >= 5.0. > Regards, > Sean. > > On 06/05/15 16:32, Andrew Hughes wrote: > > ----- Original Message ----- > >> Hello, > >> > >> This is a request for approval to backport a fix from the jdk9 to the > >> jdk8u-dev repository. > >> Changes applies cleanly to jdk8u-dev after path reshuffling. > >> > >> The bug: https://bugs.openjdk.java.net/browse/JDK-8077982 > >> The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/5bf5794f6193 > >> The review: > >> http://mail.openjdk.java.net/pipermail/awt-dev/2015-April/009269.html > >> > >> -- > >> Thanks, > >> > >> Alexander. > >> > >> > > The splashscreen changes, such as: > > > > @@ -310,7 +296,7 @@ > > free(pBitmapBits); > > free(pOldBitmapBits); > > > > - DGifCloseFile(gif); > > + DGifCloseFile(gif, NULL); > > > > return 1; > > } > > @@ -318,7 +304,7 @@ > > int > > SplashDecodeGifStream(Splash * splash, SplashStream * stream) > > { > > - GifFileType *gif = DGifOpen((void *) stream, > > SplashStreamGifInputFunc); > > + GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc, > > NULL); > > > > if (!gif) > > return 0; > > > > will break system giflib builds with versions older than 5. > > > > In fixing this in IcedTea, we added #ifdefs to this code. > > > > { > > +#if GIFLIB_MAJOR >= 5 > > + int error = 0; > > + GifFileType *gif = DGifOpen((void *) stream, SplashStreamGifInputFunc, > > &error); > > + > > + if (error) > > + return 0; > > +#else > > GifFileType *gif = DGifOpen((void *) stream, > > SplashStreamGifInputFunc); > > > > if (!gif) > > return 0; > > +#endif > > > > +#if GIFLIB_MAJOR > 5 || (GIFLIB_MAJOR == 5 && GIFLIB_MINOR >= 1) > > + int error = 0; > > + DGifCloseFile(gif, &error); > > + if (error) > > + return 0; > > +#else > > DGifCloseFile(gif); > > +#endif > > > > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From rob.mckenna at oracle.com Wed May 6 16:17:47 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 06 May 2015 17:17:47 +0100 Subject: [8u60] Request for Approval: 8079362: Enforce best practices for Node token API usage In-Reply-To: <9804141A-0B2B-455D-91EC-524D93D192D3@oracle.com> References: <9804141A-0B2B-455D-91EC-524D93D192D3@oracle.com> Message-ID: <554A3EAB.3090406@oracle.com> Hi Attila, If the patch doesn't apply cleanly we generally look for a codereview. -Rob On 06/05/15 16:41, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079362 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004487.html > > jdk8 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.8u-dev > > Changes apply *almost* cleanly to jdk8u-dev after path reshuffling from modular source code layout, except for these deviations: > 1. the 8u-dev changeset doesn?t contain changes to Parser API files in src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree directory, as this API is 9-only. > 2. the 8u-dev changeset doesn?t contain changes in the ordering of imports in Lower.java, as it is already correct in 8u-dev (it was incorrect in 9). > > I didn?t ask the team to review these trivial deviations; if you think it?s required I?ll ask them to do it. > > Thanks, > Attila. From paul.sandoz at oracle.com Wed May 6 16:50:37 2015 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Wed, 6 May 2015 18:50:37 +0200 Subject: [8u60] RFA 8078490: Missed submissions in ForkJoinPool Message-ID: <03D8CF9D-E872-4DD2-82B3-CC369CABFFAC@oracle.com> Hi, Please approve a backport of 8078490 to 8u60. Patch applies cleanly and the test runs without failure. https://bugs.openjdk.java.net/browse/JDK-8078490 http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/032983.html http://hg.openjdk.java.net/jdk9/dev/jdk/rev/97a1facbcaaa Thanks, Paul. From sean.coffey at oracle.com Wed May 6 17:04:58 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 06 May 2015 18:04:58 +0100 Subject: [8u60] RFA 8078490: Missed submissions in ForkJoinPool In-Reply-To: <03D8CF9D-E872-4DD2-82B3-CC369CABFFAC@oracle.com> References: <03D8CF9D-E872-4DD2-82B3-CC369CABFFAC@oracle.com> Message-ID: <554A49BA.2060101@oracle.com> Approved. Regards, Sean. On 06/05/15 17:50, Paul Sandoz wrote: > Hi, > > Please approve a backport of 8078490 to 8u60. Patch applies cleanly and the test runs without failure. > > https://bugs.openjdk.java.net/browse/JDK-8078490 > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/032983.html > > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/97a1facbcaaa > > Thanks, > Paul. From aleksej.efimov at oracle.com Wed May 6 23:43:09 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Thu, 07 May 2015 02:43:09 +0300 Subject: [8u-dev] Request for approval: 8077685: (tz) Support tzdata2015d Message-ID: <554AA70D.8050104@oracle.com> Hi, Can I have an approval for 2015d TZ data integration to JDK8. The JDK9 patch applies cleanly after reshuffling. Testing: JTREG and JPRT shows no failures. JBS: https://bugs.openjdk.java.net/browse/JDK-8077685 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3a60fce622dd JDK9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/033103.html With Best Regards, Aleksej From rob.mckenna at oracle.com Thu May 7 03:08:17 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 07 May 2015 04:08:17 +0100 Subject: [8u-dev] Request for approval: 8077685: (tz) Support tzdata2015d In-Reply-To: <554AA70D.8050104@oracle.com> References: <554AA70D.8050104@oracle.com> Message-ID: <554AD721.7090505@oracle.com> Approved. -Rob On 07/05/15 00:43, Aleksej Efimov wrote: > Hi, > > Can I have an approval for 2015d TZ data integration to JDK8. The JDK9 > patch applies cleanly after reshuffling. > Testing: JTREG and JPRT shows no failures. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8077685 > JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3a60fce622dd > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/033103.html > > With Best Regards, > Aleksej From sean.coffey at oracle.com Thu May 7 11:23:42 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 07 May 2015 12:23:42 +0100 Subject: [8u-dev] Request for approval : 8050123: Incorrect property name documented in CORBA InputStream API Message-ID: <554B4B3E.1050103@oracle.com> Simple typo fix for corba system property. Ports directly from JDK 9. bug ID : https://bugs.openjdk.java.net/browse/JDK-8050123 JDK 9 changeset : http://hg.openjdk.java.net/jdk9/jdk9/corba/rev/28ca8dfebab6 review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/032741.html -- Regards, Sean. From rob.mckenna at oracle.com Thu May 7 14:33:15 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 07 May 2015 15:33:15 +0100 Subject: [8u-dev] Request for approval : 8050123: Incorrect property name documented in CORBA InputStream API In-Reply-To: <554B4B3E.1050103@oracle.com> References: <554B4B3E.1050103@oracle.com> Message-ID: <554B77AB.1020702@oracle.com> Approved. -Rob On 07/05/15 12:23, Se?n Coffey wrote: > Simple typo fix for corba system property. Ports directly from JDK 9. > > bug ID : https://bugs.openjdk.java.net/browse/JDK-8050123 > JDK 9 changeset : > http://hg.openjdk.java.net/jdk9/jdk9/corba/rev/28ca8dfebab6 > review thread : > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-April/032741.html > From attila.szegedi at oracle.com Fri May 8 12:01:19 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 8 May 2015 14:01:19 +0200 Subject: [8u60] Request for Approval: 8079362: Enforce best practices for Node token API usage In-Reply-To: <554A3EAB.3090406@oracle.com> References: <9804141A-0B2B-455D-91EC-524D93D192D3@oracle.com> <554A3EAB.3090406@oracle.com> Message-ID: <262C1FB7-5338-4CE3-B86F-1DE2DC0CC44C@oracle.com> Understood. I had it reviewed, so with that in mind, please approve it as below (added a link to the jdk8 review thread): Bug: https://bugs.openjdk.java.net/browse/JDK-8079362 jdk9 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004487.html jdk8 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.8u-dev jdk8 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004497.html Thanks, Attila. > On May 6, 2015, at 6:17 PM, Rob McKenna wrote: > > Hi Attila, > > If the patch doesn't apply cleanly we generally look for a codereview. > > -Rob > > On 06/05/15 16:41, Attila Szegedi wrote: >> Please approve. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8079362 >> jdk9 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.00 >> jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004487.html >> >> jdk8 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.8u-dev >> >> Changes apply *almost* cleanly to jdk8u-dev after path reshuffling from modular source code layout, except for these deviations: >> 1. the 8u-dev changeset doesn?t contain changes to Parser API files in src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree directory, as this API is 9-only. >> 2. the 8u-dev changeset doesn?t contain changes in the ordering of imports in Lower.java, as it is already correct in 8u-dev (it was incorrect in 9). >> >> I didn?t ask the team to review these trivial deviations; if you think it?s required I?ll ask them to do it. >> >> Thanks, >> Attila. > From sundararajan.athijegannathan at oracle.com Fri May 8 12:39:19 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 08 May 2015 18:09:19 +0530 Subject: [8u60] approval request for 8079470: Misleading error message when explicit signature constructor is called with wrong arguments Message-ID: <554CAE77.1040501@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079470 8u60 webrev: http://cr.openjdk.java.net/~sundar/8079470/8u60/webrev.00/ jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004491.html Thanks, -Sundar From sean.coffey at oracle.com Fri May 8 15:30:13 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 08 May 2015 16:30:13 +0100 Subject: [8u60] Request for Approval: 8079362: Enforce best practices for Node token API usage In-Reply-To: <262C1FB7-5338-4CE3-B86F-1DE2DC0CC44C@oracle.com> References: <9804141A-0B2B-455D-91EC-524D93D192D3@oracle.com> <554A3EAB.3090406@oracle.com> <262C1FB7-5338-4CE3-B86F-1DE2DC0CC44C@oracle.com> Message-ID: <554CD685.7020802@oracle.com> Thanks for following up Attila. Approved. Regards, Sean. On 08/05/15 13:01, Attila Szegedi wrote: > Understood. I had it reviewed, so with that in mind, please approve it as below (added a link to the jdk8 review thread): > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079362 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004487.html > > jdk8 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.8u-dev > jdk8 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004497.html > > Thanks, > Attila. > >> On May 6, 2015, at 6:17 PM, Rob McKenna wrote: >> >> Hi Attila, >> >> If the patch doesn't apply cleanly we generally look for a codereview. >> >> -Rob >> >> On 06/05/15 16:41, Attila Szegedi wrote: >>> Please approve. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8079362 >>> jdk9 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.00 >>> jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004487.html >>> >>> jdk8 webrev: http://cr.openjdk.java.net/~attila/8079362/webrev.8u-dev >>> >>> Changes apply *almost* cleanly to jdk8u-dev after path reshuffling from modular source code layout, except for these deviations: >>> 1. the 8u-dev changeset doesn?t contain changes to Parser API files in src/jdk.scripting.nashorn/share/classes/jdk/nashorn/api/tree directory, as this API is 9-only. >>> 2. the 8u-dev changeset doesn?t contain changes in the ordering of imports in Lower.java, as it is already correct in 8u-dev (it was incorrect in 9). >>> >>> I didn?t ask the team to review these trivial deviations; if you think it?s required I?ll ask them to do it. >>> >>> Thanks, >>> Attila. From sean.coffey at oracle.com Fri May 8 15:31:22 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 08 May 2015 16:31:22 +0100 Subject: [8u60] approval request for 8079470: Misleading error message when explicit signature constructor is called with wrong arguments In-Reply-To: <554CAE77.1040501@oracle.com> References: <554CAE77.1040501@oracle.com> Message-ID: <554CD6CA.10602@oracle.com> Approved. If the JDK 9 changes didn't apply cleanly (post path shuffling), please obtain a peer review before pushing. Regards, Sean. On 08/05/15 13:39, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079470 > 8u60 webrev: http://cr.openjdk.java.net/~sundar/8079470/8u60/webrev.00/ > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004491.html > > Thanks, > -Sundar > From sundararajan.athijegannathan at oracle.com Fri May 8 15:36:50 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Fri, 08 May 2015 21:06:50 +0530 Subject: [8u60] approval request for 8079470: Misleading error message when explicit signature constructor is called with wrong arguments In-Reply-To: <554CD6CA.10602@oracle.com> References: <554CAE77.1040501@oracle.com> <554CD6CA.10602@oracle.com> Message-ID: <554CD812.1090801@oracle.com> Forgot to mention. After path shuffling, it applied cleanly. i.e., no other 8u specific change. -Sundar On Friday 08 May 2015 09:01 PM, Se?n Coffey wrote: > Approved. If the JDK 9 changes didn't apply cleanly (post path > shuffling), please obtain a peer review before pushing. > > Regards, > Sean. > > On 08/05/15 13:39, A. Sundararajan wrote: >> Please approve. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8079470 >> 8u60 webrev: http://cr.openjdk.java.net/~sundar/8079470/8u60/webrev.00/ >> jdk9 review thread: >> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004491.html >> >> Thanks, >> -Sundar >> > From alejandro.murillo at oracle.com Fri May 8 16:05:10 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 08 May 2015 10:05:10 -0600 Subject: [8u60] Request for approval for bulk integration of hs25.60-b15 Message-ID: <554CDEB6.5050701@oracle.com> Requesting approval to integrate hs25.60-b15 into jdk8u60-b15. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b15-jdk8u60-b15.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8035132: [TESTBUG] test/runtime/lambda-features/InvokespecialInterface.java test has unrecognized option 8076212: AllocateHeap() and ReallocateHeap() should be inlined. 8076579: Popping a stack frame after exception breakpoint sets last method param to exception 8077674: BSD build failures due to undefined macros 8079189: new hotspot build - hs25.60-b15 -- Alejandro From aleksej.efimov at oracle.com Fri May 8 22:08:42 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Sat, 09 May 2015 01:08:42 +0300 Subject: [8u-dev] Request for approval: 8062518: AIOBE occurs when accessing to document function in extended function in JAXP Message-ID: <554D33EA.9080008@oracle.com> Hi, Can I have an approval for the backport of 8062518 fix to JDK8. The JAXP part of JDK9 patch applies cleanly after reshuffling. Test was moved to JDK repo, because there is no test folder in JDK8 jaxp repo. Testing: JTREG and JPRT shows no failures. JBS: https://bugs.openjdk.java.net/browse/JDK-8062518 JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/fbc4583c5f11 JDK9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033260.html Webrev: http://cr.openjdk.java.net/~aefimov/8062518/8/00/ With Best Regards, Aleksej From sean.coffey at oracle.com Mon May 11 07:28:44 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 11 May 2015 08:28:44 +0100 Subject: [8u60] Request for approval: 8078331: Upgrade JDK to use LittleCMS 2.7 In-Reply-To: <5542489B.1080404@oracle.com> References: <5542489B.1080404@oracle.com> Message-ID: <55505A2C.4010509@oracle.com> Let's also remember to update the THIRD_PARTY_README files for this upgrade. Approved. Regards, Sean. On 30/04/2015 16:22, Phil Race wrote: > http://mail.openjdk.java.net/pipermail/2d-dev/2015-April/005354.html > https://bugs.openjdk.java.net/browse/JDK-8078331 > http://cr.openjdk.java.net/~prr/8078331.8u/ From sean.coffey at oracle.com Mon May 11 07:41:56 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 11 May 2015 08:41:56 +0100 Subject: [8u-dev] Request for approval: 8062518: AIOBE occurs when accessing to document function in extended function in JAXP In-Reply-To: <554D33EA.9080008@oracle.com> References: <554D33EA.9080008@oracle.com> Message-ID: <55505D44.4060600@oracle.com> Approved. Regards, Sean. On 08/05/2015 23:08, Aleksej Efimov wrote: > Hi, > > Can I have an approval for the backport of 8062518 fix to JDK8. The > JAXP part of JDK9 patch applies cleanly after reshuffling. > Test was moved to JDK repo, because there is no test folder in JDK8 > jaxp repo. > Testing: JTREG and JPRT shows no failures. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8062518 > JDK9 changeset: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/fbc4583c5f11 > JDK9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033260.html > Webrev: http://cr.openjdk.java.net/~aefimov/8062518/8/00/ > > With Best Regards, > Aleksej From sean.coffey at oracle.com Mon May 11 07:42:54 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 11 May 2015 08:42:54 +0100 Subject: [8u60] Request for approval for bulk integration of hs25.60-b15 In-Reply-To: <554CDEB6.5050701@oracle.com> References: <554CDEB6.5050701@oracle.com> Message-ID: <55505D7E.2070708@oracle.com> Approved pending positive PIT results. Regards, Sean. On 08/05/2015 17:05, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.60-b15 into jdk8u60-b15. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b15-jdk8u60-b15.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8035132: [TESTBUG] > test/runtime/lambda-features/InvokespecialInterface.java test has > unrecognized option > 8076212: AllocateHeap() and ReallocateHeap() should be inlined. > 8076579: Popping a stack frame after exception breakpoint sets last > method param to exception > 8077674: BSD build failures due to undefined macros > 8079189: new hotspot build - hs25.60-b15 > From masayoshi.okutsu at oracle.com Tue May 12 07:41:54 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Tue, 12 May 2015 16:41:54 +0900 Subject: [8u60] Request for approval: 8055088: Optimization for locale resources loading isn't working Message-ID: <5551AEC2.5010603@oracle.com> Hello, Could you please approve backport of the fix for 8055088 to jdk8u-dev? The fix is identical to the JDK 9 one. Bug: https://bugs.openjdk.java.net/browse/JDK-8055088 Webrev: http://cr.openjdk.java.net/~okutsu/8u/8055088/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/i18n-dev/2014-August/001461.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/83efc933b992 Thanks, Masayoshi From masayoshi.okutsu at oracle.com Tue May 12 08:03:38 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Tue, 12 May 2015 17:03:38 +0900 Subject: [8u60] Request for approval: 8055088: Optimization for locale resources loading isn't working In-Reply-To: <5551AEC2.5010603@oracle.com> References: <5551AEC2.5010603@oracle.com> Message-ID: <5551B3DA.9070102@oracle.com> Sorry. One file was missing in the webrev.00. I've updated the webrev. http://cr.openjdk.java.net/~okutsu/8u/8055088/webrev.01/ Thanks, Masayoshi On 5/12/2015 4:41 PM, Masayoshi Okutsu wrote: > Hello, > > Could you please approve backport of the fix for 8055088 to jdk8u-dev? > The fix is identical to the JDK 9 one. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8055088 > Webrev: http://cr.openjdk.java.net/~okutsu/8u/8055088/webrev.00/ > Review thread: > http://mail.openjdk.java.net/pipermail/i18n-dev/2014-August/001461.html > JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/83efc933b992 > > Thanks, > Masayoshi > From sean.coffey at oracle.com Tue May 12 08:10:37 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 12 May 2015 09:10:37 +0100 Subject: [8u60] Request for approval: 8055088: Optimization for locale resources loading isn't working In-Reply-To: <5551B3DA.9070102@oracle.com> References: <5551AEC2.5010603@oracle.com> <5551B3DA.9070102@oracle.com> Message-ID: <5551B57D.6080607@oracle.com> Approved. Regards, Sean. On 12/05/2015 09:03, Masayoshi Okutsu wrote: > Sorry. One file was missing in the webrev.00. I've updated the webrev. > > http://cr.openjdk.java.net/~okutsu/8u/8055088/webrev.01/ > > Thanks, > Masayoshi > > On 5/12/2015 4:41 PM, Masayoshi Okutsu wrote: >> Hello, >> >> Could you please approve backport of the fix for 8055088 to >> jdk8u-dev? The fix is identical to the JDK 9 one. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8055088 >> Webrev: http://cr.openjdk.java.net/~okutsu/8u/8055088/webrev.00/ >> Review thread: >> http://mail.openjdk.java.net/pipermail/i18n-dev/2014-August/001461.html >> JDK9 changeset: >> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/83efc933b992 >> >> Thanks, >> Masayoshi >> > From sundararajan.athijegannathan at oracle.com Tue May 12 11:35:31 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Tue, 12 May 2015 17:05:31 +0530 Subject: [8u60] approval request for 8080090: -d option should dump script source as well Message-ID: <5551E583.5020608@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8080090 8u-dev webrev: http://cr.openjdk.java.net/~sundar/8080090/8u60/ jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004512.html Backported 'as is' except for modular source layout difference. Thanks, -Sundar From sean.coffey at oracle.com Tue May 12 12:02:20 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 12 May 2015 13:02:20 +0100 Subject: [8u60] approval request for 8080090: -d option should dump script source as well In-Reply-To: <5551E583.5020608@oracle.com> References: <5551E583.5020608@oracle.com> Message-ID: <5551EBCB.3000604@oracle.com> Approved. Regards, Sean. On 12/05/2015 12:35, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080090 > 8u-dev webrev: http://cr.openjdk.java.net/~sundar/8080090/8u60/ > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004512.html > > Backported 'as is' except for modular source layout difference. > > Thanks, > -Sundar > From semyon.sadetsky at oracle.com Tue May 12 14:09:40 2015 From: semyon.sadetsky at oracle.com (Semyon Sadetsky) Date: Tue, 12 May 2015 17:09:40 +0300 Subject: [8u-dev] Request for approval 6894632: Removing rows from a DefaultTableModel with a RowSorter deselectes last row Message-ID: <555209A4.4000509@oracle.com> Hello, Could you approve the back-port for the fix for 6894632 to jdk8u-dev. The jdk9 patch applies cleanly post modular path unshuffling. bug: https://bugs.openjdk.java.net/browse/JDK-6894632 webrev: http://cr.openjdk.java.net/~ssadetsky/6894632/webrev.02/ Regards, --Semyon From semyon.sadetsky at oracle.com Tue May 12 14:13:12 2015 From: semyon.sadetsky at oracle.com (Semyon Sadetsky) Date: Tue, 12 May 2015 17:13:12 +0300 Subject: [8u-dev] Request for approval 8013566: Failure of GroupLayout in combination of addPreferredGap and addGroup's Message-ID: <55520A78.5060206@oracle.com> Hello, Could you approve the back-port for the fix for 8013566 to jdk8u-dev. The jdk9 patch applies cleanly post modular path unshuffling. bug: https://bugs.openjdk.java.net/browse/JDK-8013566 webrev: http://cr.openjdk.java.net/~ssadetsky/8013566/webrev.01/ Regards, --Semyon From sean.coffey at oracle.com Tue May 12 14:14:01 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 12 May 2015 15:14:01 +0100 Subject: [8u-dev] Request for approval 6894632: Removing rows from a DefaultTableModel with a RowSorter deselectes last row In-Reply-To: <555209A4.4000509@oracle.com> References: <555209A4.4000509@oracle.com> Message-ID: <55520AA9.9040300@oracle.com> review thread : http://mail.openjdk.java.net/pipermail/swing-dev/2015-March/004252.html Approved. Regards, Sean. On 12/05/2015 15:09, Semyon Sadetsky wrote: > Hello, > > Could you approve the back-port for the fix for 6894632 to jdk8u-dev. > The jdk9 patch applies cleanly post modular path unshuffling. > > bug: https://bugs.openjdk.java.net/browse/JDK-6894632 > webrev: http://cr.openjdk.java.net/~ssadetsky/6894632/webrev.02/ > > Regards, > --Semyon From sean.coffey at oracle.com Tue May 12 14:15:10 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 12 May 2015 15:15:10 +0100 Subject: [8u-dev] Request for approval 8013566: Failure of GroupLayout in combination of addPreferredGap and addGroup's In-Reply-To: <55520A78.5060206@oracle.com> References: <55520A78.5060206@oracle.com> Message-ID: <55520AEE.4090102@oracle.com> review thread : http://mail.openjdk.java.net/pipermail/swing-dev/2015-March/004263.html Approved. Regards, Sean. On 12/05/2015 15:13, Semyon Sadetsky wrote: > Hello, > > Could you approve the back-port for the fix for 8013566 to jdk8u-dev. > The jdk9 patch applies cleanly post modular path unshuffling. > > bug: https://bugs.openjdk.java.net/browse/JDK-8013566 > webrev: http://cr.openjdk.java.net/~ssadetsky/8013566/webrev.01/ > > Regards, > --Semyon From jaroslav.bachorik at oracle.com Tue May 12 15:40:33 2015 From: jaroslav.bachorik at oracle.com (Jaroslav Bachorik) Date: Tue, 12 May 2015 17:40:33 +0200 Subject: [8u-dev] Request for approval for CR 4505697 - nsk/jdi/ExceptionEvent/_itself_/exevent006 and exevent008 tests fail with InvocationTargetException Message-ID: <55521EF1.9080607@oracle.com> Please approve this backport of a JDK 9 fix. The backport applies cleanly. Issue: https://bugs.openjdk.java.net/browse/JDK-4505697 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/016b6a289fc4 Review discussion: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-February/014212.html All the related tests are passing after transplanting the changeset. Thanks, -JB- From alejandro.murillo at oracle.com Tue May 12 16:36:25 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 12 May 2015 10:36:25 -0600 Subject: jdk8u60-b15: HotSpot Message-ID: <55522C09.3020003@oracle.com> hs25.60-b15 has been integrated into jdk8u60-b15. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/7ed130e10665 http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/68b50073c52a http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/b99f1bf208f3 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/040ce4bf5a41 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/8c0018c9c533 http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/a006fa0a9e8f http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/248db113703a http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/78fcf7f0eac8 Component : VM Status : 0 major failures, 1 minor failures Date : 05/12/2015 at 18:00 MSK Tested By : STT_VM Cost(total man-days): 1 Workspace : 2015-05-08-022244.amurillo.hs25-60-b15-snapshot Bundles : 2015-05-08-022244.amurillo.hs25-60-b15-snapshot Platforms : Others Tests : Log : link Browsers : NA Patches : NA Number of Tests Executed : 312311 passed tests, 26 failed tests (1 new failure) Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: CRs for testing: 8035132: [TESTBUG] test/runtime/lambda-features/InvokespecialInterface.java test has unrecognized option 8076212: AllocateHeap() and ReallocateHeap() should be inlined. 8076579: Popping a stack frame after exception breakpoint sets last method param to exception 8077674: BSD build failures due to undefined macros 8078116: ARM: fix for 8054092 lost in merge and needs to be reapplied 8078387: [TESTBUG] closed/gc/8059064/Test8059064.java timeouts 8079189: new hotspot build - hs25.60-b15 New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: https://bugs.openjdk.java.net/browse/JDK-8080154 Number of PIT requested: 1 Integration target J2SE build number: jdk8u60-b15 Issues and Notes: This is PIT for HS25.60-b15 for jdk8u60-b15. GO for integration. -- Alejandro From rob.mckenna at oracle.com Tue May 12 16:50:06 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 12 May 2015 17:50:06 +0100 Subject: [8u-dev] Request for approval for CR 4505697 - nsk/jdi/ExceptionEvent/_itself_/exevent006 and exevent008 tests fail with InvocationTargetException In-Reply-To: <55521EF1.9080607@oracle.com> References: <55521EF1.9080607@oracle.com> Message-ID: <55522F3E.2000002@oracle.com> Approved. Please add the appropriate noreg label to the bug. -Rob On 12/05/15 16:40, Jaroslav Bachorik wrote: > Please approve this backport of a JDK 9 fix. The backport applies > cleanly. > > Issue: https://bugs.openjdk.java.net/browse/JDK-4505697 > Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/016b6a289fc4 > Review discussion: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-February/014212.html > > All the related tests are passing after transplanting the changeset. > > Thanks, > > -JB- From vivi.an at oracle.com Tue May 12 18:24:19 2015 From: vivi.an at oracle.com (Vivi An) Date: Tue, 12 May 2015 11:24:19 -0700 Subject: Request for approval 8075609: java.lang.IllegalArgumentException: aContainer is not a focus cycle root of aComponent Message-ID: <55524553.1070709@oracle.com> Hello, Could you please approve the straight back-port for the fix for 8075609 to jdk8u-dev? Bug:https://bugs.openjdk.java.net/browse/JDK-8075609 Webrev:http://cr.openjdk.java.net/~van/8075609/webrev.00/ Review Threads: http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004495.html http://mail.openjdk.java.net/pipermail/swing-dev/2015-April/004463.html Regards, ~ Vivi From sean.coffey at oracle.com Tue May 12 20:03:24 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 12 May 2015 21:03:24 +0100 Subject: Request for approval 8075609: java.lang.IllegalArgumentException: aContainer is not a focus cycle root of aComponent In-Reply-To: <55524553.1070709@oracle.com> References: <55524553.1070709@oracle.com> Message-ID: <55525C8C.6040109@oracle.com> Vivi, can you add some background information to the bug and open it up to the public ? Also - are you planning on pushing this to JDK 9 first ? That fix is still marked unresolved. Regards, Sean. On 12/05/2015 19:24, Vivi An wrote: > Hello, > > Could you please approve the straight back-port for the fix for > 8075609 to jdk8u-dev? > > Bug:https://bugs.openjdk.java.net/browse/JDK-8075609 > Webrev:http://cr.openjdk.java.net/~van/8075609/webrev.00/ > > Review Threads: > http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004495.html > http://mail.openjdk.java.net/pipermail/swing-dev/2015-April/004463.html > > Regards, > > ~ Vivi > From vivi.an at oracle.com Tue May 12 21:36:54 2015 From: vivi.an at oracle.com (Vivi An) Date: Tue, 12 May 2015 14:36:54 -0700 Subject: Request for approval 8075609: java.lang.IllegalArgumentException: aContainer is not a focus cycle root of aComponent In-Reply-To: <55524553.1070709@oracle.com> References: <55524553.1070709@oracle.com> Message-ID: <55527276.5050706@oracle.com> Instead of using getWindowAncestor to find root window, the fix using focusCycleRoot to get root container of the component's focus traversal cycle, since the focus root is not always a window. JDK9 changeset:http://hg.openjdk.java.net/jdk9/client/jdk/rev/45d0cfe4d888 Thanks! ~ Vivi On 5/12/2015 11:24 AM, Vivi An wrote: > Hello, > > Could you please approve the straight back-port for the fix for > 8075609 to jdk8u-dev? > > Bug:https://bugs.openjdk.java.net/browse/JDK-8075609 > Webrev:http://cr.openjdk.java.net/~van/8075609/webrev.00/ > > Review Threads: > http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004495.html > http://mail.openjdk.java.net/pipermail/swing-dev/2015-April/004463.html > > Regards, > > ~ Vivi > From sean.coffey at oracle.com Tue May 12 21:46:30 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 12 May 2015 22:46:30 +0100 Subject: Request for approval 8075609: java.lang.IllegalArgumentException: aContainer is not a focus cycle root of aComponent In-Reply-To: <55527276.5050706@oracle.com> References: <55524553.1070709@oracle.com> <55527276.5050706@oracle.com> Message-ID: <555274B6.9040801@oracle.com> Thanks for the updates Vivi. Approved. Regards, Sean. On 12/05/2015 22:36, Vivi An wrote: > Instead of using getWindowAncestor to find root window, the fix using > focusCycleRoot to get root container of the component's focus > traversal cycle, > since the focus root is not always a window. > > JDK9 > changeset:http://hg.openjdk.java.net/jdk9/client/jdk/rev/45d0cfe4d888 > > Thanks! > > ~ Vivi > > On 5/12/2015 11:24 AM, Vivi An wrote: >> Hello, >> >> Could you please approve the straight back-port for the fix for >> 8075609 to jdk8u-dev? >> >> Bug:https://bugs.openjdk.java.net/browse/JDK-8075609 >> Webrev:http://cr.openjdk.java.net/~van/8075609/webrev.00/ >> >> Review Threads: >> http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004495.html >> http://mail.openjdk.java.net/pipermail/swing-dev/2015-April/004463.html >> >> Regards, >> >> ~ Vivi >> > From sundararajan.athijegannathan at oracle.com Wed May 13 08:11:38 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 May 2015 13:41:38 +0530 Subject: [8u60] approval request for Java(TM) SE Runtime Environment (build 1.8.0_60-ea-b11) Message-ID: <5553073A.2080607@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8080182 jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8080182/8u60/webrev.00/ jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004519.html Backported "as is" except for modular source layout difference. Thanks, -Sundar From sean.coffey at oracle.com Wed May 13 08:15:53 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 13 May 2015 09:15:53 +0100 Subject: [8u60] approval request for Java(TM) SE Runtime Environment (build 1.8.0_60-ea-b11) In-Reply-To: <5553073A.2080607@oracle.com> References: <5553073A.2080607@oracle.com> Message-ID: <55530839.7050304@oracle.com> Approved. Regards, Sean. On 13/05/2015 09:11, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080182 > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8080182/8u60/webrev.00/ > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004519.html > > Backported "as is" except for modular source layout difference. > > Thanks, > -Sundar From david.holmes at oracle.com Wed May 13 09:00:22 2015 From: david.holmes at oracle.com (David Holmes) Date: Wed, 13 May 2015 19:00:22 +1000 Subject: [8u60] approval request for Java(TM) SE Runtime Environment (build 1.8.0_60-ea-b11) In-Reply-To: <5553073A.2080607@oracle.com> References: <5553073A.2080607@oracle.com> Message-ID: <555312A6.5010806@oracle.com> Presumably subject should reference: 8080182: Array.prototype.sort throws IAE on inconsistent comparison ;-) David On 13/05/2015 6:11 PM, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080182 > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8080182/8u60/webrev.00/ > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004519.html > > Backported "as is" except for modular source layout difference. > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Wed May 13 09:02:16 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 May 2015 14:32:16 +0530 Subject: [8u60] approval request for 8080182: Array.prototype.sort throws IAE on inconsistent comparison [was Java(TM) SE Runtime Environment (build 1.8.0_60-ea-b11)] In-Reply-To: <555312A6.5010806@oracle.com> References: <5553073A.2080607@oracle.com> <555312A6.5010806@oracle.com> Message-ID: <55531318.6020908@oracle.com> yep. Cut-paste error ;) -Sundar On Wednesday 13 May 2015 02:30 PM, David Holmes wrote: > Presumably subject should reference: > > 8080182: Array.prototype.sort throws IAE on inconsistent comparison > > ;-) > > David > > On 13/05/2015 6:11 PM, A. Sundararajan wrote: >> Please approve. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8080182 >> jdk8u-dev webrev: >> http://cr.openjdk.java.net/~sundar/8080182/8u60/webrev.00/ >> jdk9 review thread: >> http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004519.html >> >> Backported "as is" except for modular source layout difference. >> >> Thanks, >> -Sundar From sundararajan.athijegannathan at oracle.com Wed May 13 09:57:50 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 May 2015 15:27:50 +0530 Subject: [8u60] approval request for JDK-8066222: too strong assertion on function expression names Message-ID: <5553201E.8060805@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8066222 jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8066222/8u60/webrev.00/ jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/003951.html Thanks, -Sundar From sean.coffey at oracle.com Wed May 13 10:03:00 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 13 May 2015 11:03:00 +0100 Subject: [8u60] approval request for JDK-8066222: too strong assertion on function expression names In-Reply-To: <5553201E.8060805@oracle.com> References: <5553201E.8060805@oracle.com> Message-ID: <55532154.807@oracle.com> Approved. Regards, Sean. On 13/05/15 10:57, A. Sundararajan wrote: > > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066222 > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8066222/8u60/webrev.00/ > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/003951.html > > Thanks, > -Sundar From sundararajan.athijegannathan at oracle.com Wed May 13 13:46:57 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 13 May 2015 19:16:57 +0530 Subject: [8u60] approval request for 8067420, 8068985 Message-ID: <555355D1.1030805@oracle.com> Please approve. Bugs: https://bugs.openjdk.java.net/browse/JDK-8067420 https://bugs.openjdk.java.net/browse/JDK-8068985 jdk8u webrev: http://cr.openjdk.java.net/~sundar/8067420_8068985/webrev.00/ jdk9 review threads: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004025.html http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-January/004103.html Backported 'as is' except for modular source layout difference. Thanks, -Sundar From rob.mckenna at oracle.com Wed May 13 14:10:08 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 13 May 2015 15:10:08 +0100 Subject: [8u60] approval request for 8067420, 8068985 In-Reply-To: <555355D1.1030805@oracle.com> References: <555355D1.1030805@oracle.com> Message-ID: <55535B40.1060905@oracle.com> Approved. -Rob On 13/05/15 14:46, A. Sundararajan wrote: > Please approve. > > Bugs: > > https://bugs.openjdk.java.net/browse/JDK-8067420 > https://bugs.openjdk.java.net/browse/JDK-8068985 > > > jdk8u webrev: > http://cr.openjdk.java.net/~sundar/8067420_8068985/webrev.00/ > > jdk9 review threads: > > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004025.html > > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-January/004103.html > > > Backported 'as is' except for modular source layout difference. > > Thanks, > -Sundar From hannes.wallnoefer at oracle.com Wed May 13 14:44:49 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Wed, 13 May 2015 16:44:49 +0200 Subject: [8u60] Request for approval for JDK-8080286 Message-ID: <55536361.90808@oracle.com> Please approve backport of JDK-8080286 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8080286 Webrev: http://cr.openjdk.java.net/~mhaupt/8080286/webrev.01/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004529.html The changes apply cleanly to 8u-dev. Thanks, Hannes From rob.mckenna at oracle.com Wed May 13 15:49:01 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 13 May 2015 16:49:01 +0100 Subject: [8u60] Request for approval for JDK-8080286 In-Reply-To: <55536361.90808@oracle.com> References: <55536361.90808@oracle.com> Message-ID: <5553726D.5050703@oracle.com> Approved. -Rob On 13/05/15 15:44, Hannes Wallnoefer wrote: > Please approve backport of JDK-8080286 to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080286 > Webrev: http://cr.openjdk.java.net/~mhaupt/8080286/webrev.01/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004529.html > > The changes apply cleanly to 8u-dev. > > Thanks, > Hannes > > From hannes.wallnoefer at oracle.com Thu May 14 11:38:20 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 May 2015 13:38:20 +0200 Subject: [8u60] Request for approval for JDK-8066226, JDK-8066215, JDK-8066214 Message-ID: <5554892C.8070007@oracle.com> Please approve backport of JDK-8066226, JDK-8066215, and JDK-8066214 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8066226 Webrev: http://cr.openjdk.java.net/~hannesw/8066226/webrev.01/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004039.html Bug: https://bugs.openjdk.java.net/browse/JDK-8066215 Webrev: http://cr.openjdk.java.net/~hannesw/8066215/webrev/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004021.html Bug: https://bugs.openjdk.java.net/browse/JDK-8066214 Webrev: http://cr.openjdk.java.net/~hannesw/8066214/webrev/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/003954.html All changes apply cleanly to 8u-dev after path reshuffling. Thanks, Hannes From rob.mckenna at oracle.com Thu May 14 11:48:40 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 14 May 2015 12:48:40 +0100 Subject: [8u60] Request for approval for JDK-8066226, JDK-8066215, JDK-8066214 In-Reply-To: <5554892C.8070007@oracle.com> References: <5554892C.8070007@oracle.com> Message-ID: <55548B98.6000509@oracle.com> Approved. -Rob On 14/05/15 12:38, Hannes Wallnoefer wrote: > Please approve backport of JDK-8066226, JDK-8066215, and JDK-8066214 > to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066226 > Webrev: http://cr.openjdk.java.net/~hannesw/8066226/webrev.01/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004039.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066215 > Webrev: http://cr.openjdk.java.net/~hannesw/8066215/webrev/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004021.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066214 > Webrev: http://cr.openjdk.java.net/~hannesw/8066214/webrev/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/003954.html > > All changes apply cleanly to 8u-dev after path reshuffling. > > Thanks, > Hannes > From hannes.wallnoefer at oracle.com Thu May 14 14:02:44 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Thu, 14 May 2015 16:02:44 +0200 Subject: [8u60] Approval for backport of JDK-8047365 Message-ID: <5554AB04.20606@oracle.com> Please approve backport of JDK-8047365 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8047365 JDK9 webrev: http://cr.openjdk.java.net/~hannesw/8047365/webrev/ JDK8u backport webrev: http://cr.openjdk.java.net/~hannesw/8047365/8u-dev/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003816.html I had to merge two changes in MethodEmitter.java manually because of later changes in method signature of dynamicGet and dynamicSet. That later changes did not touch the code added for this bug however, so the merge is very straightforward. Thanks, Hannes From sundararajan.athijegannathan at oracle.com Thu May 14 14:09:55 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 14 May 2015 19:39:55 +0530 Subject: [8u60] Approval for backport of JDK-8047365 In-Reply-To: <5554AB04.20606@oracle.com> References: <5554AB04.20606@oracle.com> Message-ID: <5554ACB3.8060100@oracle.com> +1 on backport webrev. -Sundar On Thursday 14 May 2015 07:32 PM, Hannes Wallnoefer wrote: > Please approve backport of JDK-8047365 to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8047365 > JDK9 webrev: http://cr.openjdk.java.net/~hannesw/8047365/webrev/ > JDK8u backport webrev: > http://cr.openjdk.java.net/~hannesw/8047365/8u-dev/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003816.html > > I had to merge two changes in MethodEmitter.java manually because of > later changes in method signature of dynamicGet and dynamicSet. That > later changes did not touch the code added for this bug however, so > the merge is very straightforward. > > Thanks, > Hannes From sean.coffey at oracle.com Thu May 14 14:14:32 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 14 May 2015 15:14:32 +0100 Subject: [8u60] Approval for backport of JDK-8047365 In-Reply-To: <5554ACB3.8060100@oracle.com> References: <5554AB04.20606@oracle.com> <5554ACB3.8060100@oracle.com> Message-ID: <5554ADC8.30001@oracle.com> Approved. Regards, Sean. On 14/05/2015 15:09, A. Sundararajan wrote: > +1 on backport webrev. > > -Sundar > > On Thursday 14 May 2015 07:32 PM, Hannes Wallnoefer wrote: >> Please approve backport of JDK-8047365 to 8u60: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8047365 >> JDK9 webrev: http://cr.openjdk.java.net/~hannesw/8047365/webrev/ >> JDK8u backport webrev: >> http://cr.openjdk.java.net/~hannesw/8047365/8u-dev/ >> Review thread: >> http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-November/003816.html >> >> I had to merge two changes in MethodEmitter.java manually because of >> later changes in method signature of dynamicGet and dynamicSet. That >> later changes did not touch the code added for this bug however, so >> the merge is very straightforward. >> >> Thanks, >> Hannes > From huizhe.wang at oracle.com Thu May 14 17:42:31 2015 From: huizhe.wang at oracle.com (huizhe wang) Date: Thu, 14 May 2015 10:42:31 -0700 Subject: [8u60] Approval for backport of JDK-8080344 Message-ID: <5554DE87.3080709@oracle.com> Please approve backport of JDK-8080344 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8080344 JDK9 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8080344/webrev/ JDK8u backport webrev: http://cr.openjdk.java.net/~joehw/8u/8080344/webrev/ Review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033421.html Note that XPathEvaluationResult.java and XPathNodes.java are JDK9-only classes. Otherwise, the patch was unshuffled and imported cleanly to jdk8u-dev/jaxp repo. Thanks, Joe From sean.coffey at oracle.com Thu May 14 17:48:33 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 14 May 2015 18:48:33 +0100 Subject: [8u60] Approval for backport of JDK-8080344 In-Reply-To: <5554DE87.3080709@oracle.com> References: <5554DE87.3080709@oracle.com> Message-ID: <5554DFF1.3030206@oracle.com> Please add a suitable noreg- label to the bug report. Approved. Regards, Sean. On 14/05/2015 18:42, huizhe wang wrote: > Please approve backport of JDK-8080344 to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080344 > JDK9 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8080344/webrev/ > JDK8u backport webrev: > http://cr.openjdk.java.net/~joehw/8u/8080344/webrev/ > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033421.html > > Note that XPathEvaluationResult.java and XPathNodes.java are JDK9-only > classes. Otherwise, the patch was unshuffled and imported cleanly to > jdk8u-dev/jaxp repo. > > Thanks, > Joe From rob.mckenna at oracle.com Thu May 14 17:52:12 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 14 May 2015 18:52:12 +0100 Subject: [8u60] Approval for backport of JDK-8080344 In-Reply-To: <5554DE87.3080709@oracle.com> References: <5554DE87.3080709@oracle.com> Message-ID: <5554E0CC.6040806@oracle.com> Approved. Please add a noreg keyword. -Rob On 14/05/15 18:42, huizhe wang wrote: > Please approve backport of JDK-8080344 to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080344 > JDK9 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8080344/webrev/ > JDK8u backport webrev: > http://cr.openjdk.java.net/~joehw/8u/8080344/webrev/ > Review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033421.html > > Note that XPathEvaluationResult.java and XPathNodes.java are JDK9-only > classes. Otherwise, the patch was unshuffled and imported cleanly to > jdk8u-dev/jaxp repo. > > Thanks, > Joe From naoto.sato at oracle.com Thu May 14 18:24:36 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Thu, 14 May 2015 11:24:36 -0700 Subject: [8u60] Request for approval for CR 8080342 - Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle Message-ID: <5554E864.9090308@oracle.com> Hello, Please approve the backport of the following JDK9 changeset to 8u60. The patch applied cleanly after the file location adjustment. Bug: https://bugs.openjdk.java.net/browse/JDK-8080342 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8960ba885c1e Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033424.html Naoto From sean.coffey at oracle.com Thu May 14 19:16:03 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 14 May 2015 20:16:03 +0100 Subject: [8u60] Request for approval for CR 8080342 - Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle In-Reply-To: <5554E864.9090308@oracle.com> References: <5554E864.9090308@oracle.com> Message-ID: <5554F473.2070108@oracle.com> Approved. Regards, Sean. On 14/05/2015 19:24, Naoto Sato wrote: > Hello, > > Please approve the backport of the following JDK9 changeset to 8u60. > The patch applied cleanly after the file location adjustment. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080342 > Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8960ba885c1e > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033424.html > > Naoto From attila.szegedi at oracle.com Fri May 15 08:27:17 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 15 May 2015 10:27:17 +0200 Subject: [8u60] Request for Approval: 8067931: Improve error message when with statement is passed a POJO and 8080295: Need to adjust test output for 8067931 Message-ID: Please approve 8067931 and 8080295 jointly. (8067931 broke a test that relied on wording of the error message it changes, and 8080295 fixes the break by adjusting the test to reflect the new error message text.) Bug: https://bugs.openjdk.java.net/browse/JDK-8067931 jdk9 webrev: http://cr.openjdk.java.net/~attila/8067931/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004500.html Bug: https://bugs.openjdk.java.net/browse/JDK-8080295 jdk9 webrev: http://cr.openjdk.java.net/~attila/8080295/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004542.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From attila.szegedi at oracle.com Fri May 15 08:27:39 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 15 May 2015 10:27:39 +0200 Subject: [8u60] Request for Approval: 8079424: code generator for discarded boolean logical operation has an extra pop Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079424 jdk9 webrev: http://cr.openjdk.java.net/~attila/8079424/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004502.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From sean.coffey at oracle.com Fri May 15 08:35:33 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 15 May 2015 09:35:33 +0100 Subject: [8u60] Request for Approval: 8067931: Improve error message when with statement is passed a POJO and 8080295: Need to adjust test output for 8067931 In-Reply-To: References: Message-ID: <5555AFD5.8050303@oracle.com> Approved. Regards, Sean. On 15/05/2015 09:27, Attila Szegedi wrote: > Please approve 8067931 and 8080295 jointly. (8067931 broke a test that relied on wording of the error message it changes, and 8080295 fixes the break by adjusting the test to reflect the new error message text.) > > Bug: https://bugs.openjdk.java.net/browse/JDK-8067931 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8067931/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004500.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080295 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8080295/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004542.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From sean.coffey at oracle.com Fri May 15 08:35:41 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Fri, 15 May 2015 09:35:41 +0100 Subject: [8u60] Request for Approval: 8079424: code generator for discarded boolean logical operation has an extra pop In-Reply-To: References: Message-ID: <5555AFDD.8010606@oracle.com> Approved. Regards, Sean. On 15/05/2015 09:27, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079424 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8079424/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004502.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From hannes.wallnoefer at oracle.com Fri May 15 09:59:13 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 15 May 2015 11:59:13 +0200 Subject: [8u60] Request for approval for JDK-8080471 Message-ID: <5555C371.3000508@oracle.com> Please approve backport of JDK-8080471 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8080471 JDK9 webrev: http://cr.openjdk.java.net/~mhaupt/8080471/webrev.00/ JDK8u webrev: http://cr.openjdk.java.net/~hannesw/8080471/8u-dev/webrev/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004548.html The tests in 8u-dev are slightly different because of non-modular source code so the patch had to be slightly adapted. Thanks, Hannes From sean.coffey at oracle.com Fri May 15 10:15:57 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 15 May 2015 11:15:57 +0100 Subject: [8u60] Request for approval for JDK-8080471 In-Reply-To: <5555C371.3000508@oracle.com> References: <5555C371.3000508@oracle.com> Message-ID: <5555C75D.8030001@oracle.com> Approved. Regards, Sean. On 15/05/15 10:59, Hannes Wallnoefer wrote: > Please approve backport of JDK-8080471 to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080471 > JDK9 webrev: http://cr.openjdk.java.net/~mhaupt/8080471/webrev.00/ > JDK8u webrev: http://cr.openjdk.java.net/~hannesw/8080471/8u-dev/webrev/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004548.html > > The tests in 8u-dev are slightly different because of non-modular > source code so the patch had to be slightly adapted. > > Thanks, > Hannes From alexey.ivanov at oracle.com Fri May 15 10:30:54 2015 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Fri, 15 May 2015 13:30:54 +0300 Subject: [8u60] Request for approval: 8033069: mouse wheel scroll closes combobox popup Message-ID: <5555CADE.9030806@oracle.com> Hello, Could you please approve the following backport of the fix to 8u60? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8033069 Webrev: http://cr.openjdk.java.net/~aivanov/8033069/jdk9/webrev.00/ Review: http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004475.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/37420463e70c The changeset applies cleanly to jdk8 after paths reshuffling. Thank you, Alexey From sean.coffey at oracle.com Fri May 15 10:44:33 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 15 May 2015 11:44:33 +0100 Subject: [8u60] Request for approval: 8033069: mouse wheel scroll closes combobox popup In-Reply-To: <5555CADE.9030806@oracle.com> References: <5555CADE.9030806@oracle.com> Message-ID: <5555CE11.7050705@oracle.com> Approved. Regards, Sean. On 15/05/15 11:30, Alexey Ivanov wrote: > Hello, > > Could you please approve the following backport of the fix to 8u60? > > JBS bug: https://bugs.openjdk.java.net/browse/JDK-8033069 > Webrev: http://cr.openjdk.java.net/~aivanov/8033069/jdk9/webrev.00/ > Review: > http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004475.html > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/37420463e70c > > The changeset applies cleanly to jdk8 after paths reshuffling. > > Thank you, > Alexey From alexander.potochkin at oracle.com Fri May 15 11:37:03 2015 From: alexander.potochkin at oracle.com (Alexander Potochkin) Date: Fri, 15 May 2015 14:37:03 +0300 Subject: Result: New JDK 8u Committer: Alexey Ivanov Message-ID: <5555DA5F.2040709@oracle.com> Voting for Alexey Ivanov [1] is now closed. Yes: 8 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Thanks alexp [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-April/003425.html From alexander.zvegintsev at oracle.com Fri May 15 11:51:52 2015 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Fri, 15 May 2015 14:51:52 +0300 Subject: [8u60] Request for approval 8072448: Can not input Japanese in JTextField on RedHat Linux Message-ID: <5555DDD8.9050900@oracle.com> Hello, Please approve backport of a fix from the jdk9 to the jdk8u-dev repository. Changes applies cleanly to jdk8u-dev after path reshuffling. The bug: https://bugs.openjdk.java.net/browse/JDK-8072448 The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/4fabb24ec671 -- Thanks, Alexander. From sean.coffey at oracle.com Fri May 15 12:58:16 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 15 May 2015 13:58:16 +0100 Subject: [8u60] Request for approval 8072448: Can not input Japanese in JTextField on RedHat Linux In-Reply-To: <5555DDD8.9050900@oracle.com> References: <5555DDD8.9050900@oracle.com> Message-ID: <5555ED68.1060409@oracle.com> Alexander, can you open up this bug report to the public ? Approved. Regards, Sean. On 15/05/15 12:51, Alexander Zvegintsev wrote: > Hello, > > Please approve backport of a fix from the jdk9 to the jdk8u-dev > repository. > Changes applies cleanly to jdk8u-dev after path reshuffling. > > The bug: https://bugs.openjdk.java.net/browse/JDK-8072448 > The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/4fabb24ec671 > > From alexander.zvegintsev at oracle.com Fri May 15 13:00:27 2015 From: alexander.zvegintsev at oracle.com (Alexander Zvegintsev) Date: Fri, 15 May 2015 16:00:27 +0300 Subject: [8u60] Request for approval 8072448: Can not input Japanese in JTextField on RedHat Linux In-Reply-To: <5555ED68.1060409@oracle.com> References: <5555DDD8.9050900@oracle.com> <5555ED68.1060409@oracle.com> Message-ID: <5555EDEB.4060808@oracle.com> Sean, Sure. Thanks, Alexander. On 05/15/2015 03:58 PM, Se?n Coffey wrote: > Alexander, > > can you open up this bug report to the public ? > > Approved. > > Regards, > Sean. > > On 15/05/15 12:51, Alexander Zvegintsev wrote: >> Hello, >> >> Please approve backport of a fix from the jdk9 to the jdk8u-dev >> repository. >> Changes applies cleanly to jdk8u-dev after path reshuffling. >> >> The bug: https://bugs.openjdk.java.net/browse/JDK-8072448 >> The fix: http://hg.openjdk.java.net/jdk9/client/jdk/rev/4fabb24ec671 >> >> > From attila.szegedi at oracle.com Fri May 15 13:41:16 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Fri, 15 May 2015 15:41:16 +0200 Subject: [8u60] Request for Approval: 8078414: Don't create impossible converters for ScriptObjectMirror Message-ID: <62ACBCCF-1EE0-4A30-8E01-644E6DBF5BDC@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8078414 jdk9 webrev: http://cr.openjdk.java.net/~attila/8078414/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004555.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Fri May 15 13:42:29 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 15 May 2015 14:42:29 +0100 Subject: [8u60] Request for Approval: 8078414: Don't create impossible converters for ScriptObjectMirror In-Reply-To: <62ACBCCF-1EE0-4A30-8E01-644E6DBF5BDC@oracle.com> References: <62ACBCCF-1EE0-4A30-8E01-644E6DBF5BDC@oracle.com> Message-ID: <5555F7C5.2010408@oracle.com> Approved pending 9 push. -Rob On 15/05/15 14:41, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8078414 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8078414/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004555.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. From hannes.wallnoefer at oracle.com Fri May 15 15:30:55 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Fri, 15 May 2015 17:30:55 +0200 Subject: [8u60] Request for approval for JDK-8071928, JDK-8073846, JDK-8049300 Message-ID: <5556112F.1040200@oracle.com> Please approve backport of JDK-8071928, JDK-8073846, and JDK-8049300 to 8u60: Bug: https://bugs.openjdk.java.net/browse/JDK-8071928 Webrev: http://cr.openjdk.java.net/~hannesw/8071928/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-April/004444.html Bug: https://bugs.openjdk.java.net/browse/JDK-8073846 Webrev: http://cr.openjdk.java.net/~hannesw/8073846/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-April/004444.html Bug: https://bugs.openjdk.java.net/browse/JDK-8049300 Webrev: http://cr.openjdk.java.net/~mhaupt/8049300/webrev.01/ Review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004559.html All changes apply cleanly to 8u-dev after path reshuffling. Thanks, Hannes From alejandro.murillo at oracle.com Fri May 15 15:51:02 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 15 May 2015 09:51:02 -0600 Subject: [8u60] Request for approval for bulk integration of hs25.60-b16 Message-ID: <555615E6.6050609@oracle.com> Requesting approval to integrate hs25.60-b16 into jdk8u60-b16. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b16-jdk8u60-b16.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8076523: assert(((ABS(iv_adjustment_in_bytes) % elt_size) == 0)) fails in superword.cpp 8078113: 8011102 changes may cause incorrect results 8078497: C2's superword optimization causes unaligned memory accesses 8079343: Crash in PhaseIdealLoop with "assert(!had_error) failed: bad dominance" 8079686: new hotspot build - hs25.60-b16 -- Alejandro From david.dehaven at oracle.com Fri May 15 15:52:06 2015 From: david.dehaven at oracle.com (David DeHaven) Date: Fri, 15 May 2015 08:52:06 -0700 Subject: [8u60] Request for Approval: 8080343: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle Message-ID: Yet another GPL header fix. JBS issue: https://bugs.openjdk.java.net/browse/JDK-8080343 Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009369.html Trivial patch is in the review thread. -DrD- From rob.mckenna at oracle.com Fri May 15 15:53:33 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 15 May 2015 16:53:33 +0100 Subject: [8u60] Request for approval for JDK-8071928, JDK-8073846, JDK-8049300 In-Reply-To: <5556112F.1040200@oracle.com> References: <5556112F.1040200@oracle.com> Message-ID: <5556167D.2010109@oracle.com> Approved. -Rob On 15/05/15 16:30, Hannes Wallnoefer wrote: > Please approve backport of JDK-8071928, JDK-8073846, and JDK-8049300 > to 8u60: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8071928 > Webrev: http://cr.openjdk.java.net/~hannesw/8071928/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-April/004444.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8073846 > Webrev: http://cr.openjdk.java.net/~hannesw/8073846/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-April/004444.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8049300 > Webrev: http://cr.openjdk.java.net/~mhaupt/8049300/webrev.01/ > Review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004559.html > > All changes apply cleanly to 8u-dev after path reshuffling. > > Thanks, > Hannes From rob.mckenna at oracle.com Fri May 15 15:54:06 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 15 May 2015 16:54:06 +0100 Subject: [8u60] Request for Approval: 8080343: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle In-Reply-To: References: Message-ID: <5556169E.9060205@oracle.com> Approved. -Rob On 15/05/15 16:52, David DeHaven wrote: > Yet another GPL header fix. > > JBS issue: https://bugs.openjdk.java.net/browse/JDK-8080343 > Review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009369.html > > Trivial patch is in the review thread. > > -DrD- > From rob.mckenna at oracle.com Fri May 15 15:55:46 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 15 May 2015 16:55:46 +0100 Subject: [8u60] Request for approval for bulk integration of hs25.60-b16 In-Reply-To: <555615E6.6050609@oracle.com> References: <555615E6.6050609@oracle.com> Message-ID: <55561702.8010909@oracle.com> Approved pending positive PIT. -Rob On 15/05/15 16:51, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.60-b16 into jdk8u60-b16. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b16-jdk8u60-b16.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8076523: assert(((ABS(iv_adjustment_in_bytes) % elt_size) == 0)) fails > in superword.cpp > 8078113: 8011102 changes may cause incorrect results > 8078497: C2's superword optimization causes unaligned memory accesses > 8079343: Crash in PhaseIdealLoop with "assert(!had_error) failed: bad > dominance" > 8079686: new hotspot build - hs25.60-b16 > From Sergey.Bylokhov at oracle.com Fri May 15 19:43:42 2015 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 15 May 2015 22:43:42 +0300 Subject: [8u60] Request for Approval: 8080341 Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle Message-ID: <55564C6E.9020303@oracle.com> Hello, This is a direct back port from jdk9 to jdk 8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8080341 Review: http://mail.openjdk.java.net/pipermail/beans-dev/2015-May/000135.html jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/faf108e55314 Reviewers: Alexander Scherbatiy, Phil Race -- Best regards, Sergey. From rob.mckenna at oracle.com Fri May 15 20:58:27 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 15 May 2015 21:58:27 +0100 Subject: [8u60] Request for Approval: 8080341 Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle In-Reply-To: <55564C6E.9020303@oracle.com> References: <55564C6E.9020303@oracle.com> Message-ID: <55565DF3.4090100@oracle.com> Approved. -Rob On 15/05/15 20:43, Sergey Bylokhov wrote: > Hello, > This is a direct back port from jdk9 to jdk 8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080341 > Review: > http://mail.openjdk.java.net/pipermail/beans-dev/2015-May/000135.html > jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/faf108e55314 > > Reviewers: Alexander Scherbatiy, Phil Race > From sundararajan.athijegannathan at oracle.com Mon May 18 15:10:47 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 May 2015 20:40:47 +0530 Subject: [8u60] approval request for 8072853: SimpleScriptContext used by NashornScriptEngine doesn't completely complies to the spec regarding exception throwing Message-ID: <555A00F7.4070506@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8072853 jdk9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033499.html jdk8u webrev: http://cr.openjdk.java.net/~sundar/8072853/README Backported 'as is' except for modular source code layout difference. Thanks, -Sundar From sundararajan.athijegannathan at oracle.com Mon May 18 15:12:33 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 18 May 2015 20:42:33 +0530 Subject: [8u60] approval request for 8072853: SimpleScriptContext used by NashornScriptEngine doesn't completely complies to the spec regarding exception throwing In-Reply-To: <555A00F7.4070506@oracle.com> References: <555A00F7.4070506@oracle.com> Message-ID: <555A0161.6010501@oracle.com> Correct 8u-dev webrev link: http://cr.openjdk.java.net/~sundar/8072853/8u60/webrev.00/ thanks -Sundar A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8072853 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033499.html > jdk8u webrev: http://cr.openjdk.java.net/~sundar/8072853/README > > Backported 'as is' except for modular source code layout difference. > > Thanks, > -Sundar From rob.mckenna at oracle.com Mon May 18 15:15:33 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 18 May 2015 16:15:33 +0100 Subject: [8u60] approval request for 8072853: SimpleScriptContext used by NashornScriptEngine doesn't completely complies to the spec regarding exception throwing In-Reply-To: <555A0161.6010501@oracle.com> References: <555A00F7.4070506@oracle.com> <555A0161.6010501@oracle.com> Message-ID: <555A0215.20304@oracle.com> Approved. -Rob On 18/05/15 16:12, A. Sundararajan wrote: > Correct 8u-dev webrev link: > http://cr.openjdk.java.net/~sundar/8072853/8u60/webrev.00/ > > thanks > -Sundar > > A. Sundararajan wrote: >> Please approve. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8072853 >> jdk9 review thread: >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033499.html >> jdk8u webrev: http://cr.openjdk.java.net/~sundar/8072853/README >> >> Backported 'as is' except for modular source code layout difference. >> >> Thanks, >> -Sundar > From ivan.gerasimov at oracle.com Mon May 18 15:57:27 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 18 May 2015 18:57:27 +0300 Subject: [8u-dev] 8080217: MethodTypes are not localized Message-ID: <555A0BE7.3070105@oracle.com> Hi! Would you please approve backporting this fix to 8u-dev? The patch applies cleanly after unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8065077 Jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/6eeeed95be5b The fixed jdk8 was successfull built on all platforms. Sincerely yours, Ivan From sean.coffey at oracle.com Mon May 18 16:12:48 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Mon, 18 May 2015 17:12:48 +0100 Subject: [8u-dev] 8080217: MethodTypes are not localized In-Reply-To: <555A0BE7.3070105@oracle.com> References: <555A0BE7.3070105@oracle.com> Message-ID: <555A0F80.5070903@oracle.com> Approved. Regards, Sean. On 18/05/15 16:57, Ivan Gerasimov wrote: > Hi! > > Would you please approve backporting this fix to 8u-dev? > The patch applies cleanly after unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8065077 > Jdk9 changeset: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/6eeeed95be5b > > The fixed jdk8 was successfull built on all platforms. > > Sincerely yours, > Ivan From ivan.gerasimov at oracle.com Mon May 18 17:54:56 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 18 May 2015 20:54:56 +0300 Subject: [8u-dev] Request for Approval to Backport: 8074657: Missing space on a boundary of concatenated strings Message-ID: <555A2770.1080102@oracle.com> Hi! This fixes a few error messages and indentation in a couple of files. The patch applies cleanly after unshuffling. Bug: https://bugs.openjdk.java.net/browse/JDK-8074657 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5f4dda02ab10 Jdk9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033323.html Sincerely yours, Ivan From rob.mckenna at oracle.com Mon May 18 18:14:43 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 18 May 2015 19:14:43 +0100 Subject: [8u-dev] Request for Approval to Backport: 8074657: Missing space on a boundary of concatenated strings In-Reply-To: <555A2770.1080102@oracle.com> References: <555A2770.1080102@oracle.com> Message-ID: <555A2C13.1030208@oracle.com> Approved. -Rob On 18/05/15 18:54, Ivan Gerasimov wrote: > Hi! > > This fixes a few error messages and indentation in a couple of files. > The patch applies cleanly after unshuffling. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8074657 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/5f4dda02ab10 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033323.html > > Sincerely yours, > Ivan From vladimir.x.ivanov at oracle.com Mon May 18 18:57:26 2015 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Mon, 18 May 2015 21:57:26 +0300 Subject: [8u60] Bulk request for approval: 8059455, 8078290 Message-ID: <555A3616.4020804@oracle.com> Please, approve backports of the following fixes into 8u60: (1) 8059455: LambdaForm.prepare() does unnecessary work for cached LambdaForms http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/6d6d9555d2e6 https://bugs.openjdk.java.net/browse/JDK-8059455 (2) 8078290: Customize adapted MethodHandle in MH.invoke() case http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b41a4874ae5f https://bugs.openjdk.java.net/browse/JDK-8078290 The fixes apply cleanly. Thanks! Best regards, Vladimir Ivanov From jan.lahoda at oracle.com Mon May 18 19:23:47 2015 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 18 May 2015 21:23:47 +0200 Subject: [8u-60] request for approval to backport JDK-8080338, JDK-8080339, JDK-8080340: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle In-Reply-To: <54DD181C.30206@oracle.com> References: <54DD181C.30206@oracle.com> Message-ID: <555A3C43.8090401@oracle.com> Hello, I'd like to ask for an approval to backport the following fix to 8u-dev: Bugs: https://bugs.openjdk.java.net/browse/JDK-8080338 https://bugs.openjdk.java.net/browse/JDK-8080339 https://bugs.openjdk.java.net/browse/JDK-8080340 jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/8bc4c0b6eeb7 The fix applies cleanly to 8u-dev/langtools. Thanks, Jan From rob.mckenna at oracle.com Mon May 18 19:27:48 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 18 May 2015 20:27:48 +0100 Subject: [8u60] Bulk request for approval: 8059455, 8078290 In-Reply-To: <555A3616.4020804@oracle.com> References: <555A3616.4020804@oracle.com> Message-ID: <555A3D34.4000607@oracle.com> Please add a noreg keyword to 8059455. Approved. -Rob On 18/05/15 19:57, Vladimir Ivanov wrote: > Please, approve backports of the following fixes into 8u60: > > (1) 8059455: LambdaForm.prepare() does unnecessary work for cached > LambdaForms > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/6d6d9555d2e6 > https://bugs.openjdk.java.net/browse/JDK-8059455 > > (2) 8078290: Customize adapted MethodHandle in MH.invoke() case > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b41a4874ae5f > https://bugs.openjdk.java.net/browse/JDK-8078290 > > The fixes apply cleanly. > > Thanks! > > Best regards, > Vladimir Ivanov From rob.mckenna at oracle.com Mon May 18 19:28:03 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 18 May 2015 20:28:03 +0100 Subject: [8u-60] request for approval to backport JDK-8080338, JDK-8080339, JDK-8080340: Incorrect GPL header causes RE script to miss swap to commercial header for licensee source bundle In-Reply-To: <555A3C43.8090401@oracle.com> References: <54DD181C.30206@oracle.com> <555A3C43.8090401@oracle.com> Message-ID: <555A3D43.1070209@oracle.com> Approved. -Rob On 18/05/15 20:23, Jan Lahoda wrote: > Hello, > > I'd like to ask for an approval to backport the following fix to 8u-dev: > > Bugs: > https://bugs.openjdk.java.net/browse/JDK-8080338 > https://bugs.openjdk.java.net/browse/JDK-8080339 > https://bugs.openjdk.java.net/browse/JDK-8080340 > > jdk9 fix: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/8bc4c0b6eeb7 > > The fix applies cleanly to 8u-dev/langtools. > > Thanks, > Jan From vladimir.x.ivanov at oracle.com Mon May 18 19:44:15 2015 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Mon, 18 May 2015 22:44:15 +0300 Subject: [8u60] Bulk request for approval: 8059455, 8078290 In-Reply-To: <555A3D34.4000607@oracle.com> References: <555A3616.4020804@oracle.com> <555A3D34.4000607@oracle.com> Message-ID: <555A410F.3090105@oracle.com> Thanks, Rob! Done. Best regards, Vladimir Ivanov On 5/18/15 10:27 PM, Rob McKenna wrote: > Please add a noreg keyword to 8059455. > > Approved. > > -Rob > > On 18/05/15 19:57, Vladimir Ivanov wrote: >> Please, approve backports of the following fixes into 8u60: >> >> (1) 8059455: LambdaForm.prepare() does unnecessary work for cached >> LambdaForms >> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/6d6d9555d2e6 >> https://bugs.openjdk.java.net/browse/JDK-8059455 >> >> (2) 8078290: Customize adapted MethodHandle in MH.invoke() case >> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/b41a4874ae5f >> https://bugs.openjdk.java.net/browse/JDK-8078290 >> >> The fixes apply cleanly. >> >> Thanks! >> >> Best regards, >> Vladimir Ivanov From lana.steuck at oracle.com Tue May 19 06:30:06 2015 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 18 May 2015 23:30:06 -0700 (PDT) Subject: jdk8u-b16: jdk8u-dev Message-ID: <201505190630.t4J6U6Uw015208@sc11152554.us.oracle.com> http://hg.openjdk.java.net/jdk8u/jdk8u/rev/08a417ec9b3e http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/bf44ade6c2c2 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/ecb7e46b820f http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/6ed3821c212a http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/1c9eb173022b http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/3cb841defba0 http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/75b0573e0a5d http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/3b19c17ea11c --- All the fixes will be tested during promotion (no PIT testing at this point): List of all fixes: =================== JDK-8078049 core-libs Nashorn crashes when attempting to start TypeScript compiler JDK-8078082 client-libs [TEST_BUG] java/awt/SplashScreen/MultiResolutionSplash/MultiResolution JDK-8041642 client-libs Incorrect paint of JProgressBar in Nimbus LF JDK-8075609 client-libs java.lang.IllegalArgumentException: aContainer is not a focus cycle ro JDK-8072769 client-libs System tray icon title freezes java JDK-8078331 client-libs Upgrade JDK to use LittleCMS 2.7 JDK-8080090 core-libs -d option should dump script source as well JDK-8077685 core-libs (tz) Support tzdata2015d JDK-8075090 core-libs Add tests for the basic failure of try/finally compilation JDK-8080182 core-libs Array.prototype.sort throws IAE on inconsistent comparison JDK-8067420 core-libs BrowserJSObjectLinker should give priority to beans linker for propert JDK-8079349 core-libs Eliminate dead code around Nashorn code generator JDK-8066215 core-libs Fuzzing bug: length valueOf bug JDK-8066214 core-libs Fuzzing bug: Object.prototype.toLocaleString(0) JDK-8066226 core-libs Fuzzing bug: parameter counts differ in TypeConverterFactory JDK-8079470 core-libs Misleading error message when explicit signature constructor is called JDK-8078490 core-libs Missed submissions in ForkJoinPool JDK-8079269 core-libs Optimistic rewrite in object literal causes ArrayIndexOutOfBoundsExcep JDK-8055088 core-libs Optimization for locale resources loading isn't working JDK-8078612 core-libs Persistent code cache should support more configurations JDK-8066222 core-libs too strong assertion on function expression names JDK-8080286 core-libs use path separator setting consistently in Nashorn project properties JDK-8047365 core-libs Very long function names break codegen JDK-8068985 core-libs Wrong 'this' bound to eval call within a function when caller's 'this' JDK-4505697 core-svc nsk/jdi/ExceptionEvent/_itself_/exevent006 and exevent008 tests fail w JDK-8079087 infrastructure Add support for Cygwin 2.0 JDK-8050123 other-libs Incorrect property name documented in CORBA InputStream API JDK-8079129 security-libs NullPointerException in PKCS#12 Keystore in PKCS12KeyStore.java JDK-8078439 security-libs SPNEGO auth fails if client proposes MS krb5 OID JDK-8064803 tools Javac erroneously uses instantiated signatures when merging abstract m JDK-8078560 tools The crash reporting URL listed by javac needs to be updated JDK-8062518 xml AIOBE occurs when accessing to document function in extended function From volker.simonis at gmail.com Tue May 19 13:54:59 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 19 May 2015 15:54:59 +0200 Subject: [8u60] request for approval: 8080190: PPC64: Fix wrong rotate instructions in the .ad file Message-ID: Hi, could you please approve the downport of the following, ppc-only fix to jdk8u/hs-dev/hotspot Bug: https://bugs.openjdk.java.net/browse/JDK-8080190 Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2015/8080190.8u/ Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-May/thread.html#17920 URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4140f485ba27 The change cleanly applies to the jdk8u/hs-dev/hotspot repository. I would really like to bring this into 8u60 as this is a serious bug which leads to incorrect computations. Is this still possible by goiong trough jdk8u/hs-dev/hotspot? The other question is if I can push this ppc-only change myself to jdk8u/hs-dev/hotspot or if I need a sponsor? Thank you and best regards, Volker From alejandro.murillo at oracle.com Tue May 19 16:37:35 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 19 May 2015 10:37:35 -0600 Subject: jdk8u60-b16: HotSpot Message-ID: <555B66CF.1080006@oracle.com> hs25.60-b16 has been integrated into jdk8u60-b16. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/08a417ec9b3e http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/3b19c17ea11c http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/ab2353694ea7 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/3cb841defba0 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/1c9eb173022b http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/6ed3821c212a http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/ecb7e46b820f http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/bf44ade6c2c2 Component : VM Status : 0 major failures, 0 minor failure Date : 05/19/2015 at 17:30 MSK Tested By : STT_VM Cost(total man-days): 1 Workspace : 2015-05-15-012529.amurillo.hs25-60-b16-snapshot Bundles : 22015-05-15-012529.amurillo.hs25-60-b16-snapshot Platforms : Others Tests : Log : link Browsers : NA Patches : NA Number of Tests Executed : 427730 passed tests, 4418 failed tests (0 new failure) Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: 8076523: assert(((ABS(iv_adjustment_in_bytes) % elt_size) == 0)) fails in superword.cpp 8078113: 8011102 changes may cause incorrect results 8078497: C2's superword optimization causes unaligned memory accesses 8079343: Crash in PhaseIdealLoop with "assert(!had_error) failed: bad dominance" 8079686: new hotspot build - hs25.60-b16 New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Reopened 8075805: SIGSEGV in GuardedMemory::print_on Number of PIT requested: 1 Integration target J2SE build number: jdk8u60-b16 Issues and Notes: This is PIT for HS25.60-b16 for jdk8u60-b16. Go for integration. -- Alejandro From rob.mckenna at oracle.com Tue May 19 16:46:29 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 19 May 2015 17:46:29 +0100 Subject: [8u60] request for approval: 8080190: PPC64: Fix wrong rotate instructions in the .ad file In-Reply-To: References: Message-ID: <555B68E5.2010304@oracle.com> Hi Volker, You can push directly to the hotspot team repo. It will make 8u60 assuming you push before RDP 2. http://openjdk.java.net/projects/jdk8u/releases/8u60.html You should have committer access to that repo. Let us know if not. -Rob On 19/05/15 14:54, Volker Simonis wrote: > Hi, > > could you please approve the downport of the following, ppc-only fix > to jdk8u/hs-dev/hotspot > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080190 > Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2015/8080190.8u/ > Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-May/thread.html#17920 > URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4140f485ba27 > > The change cleanly applies to the jdk8u/hs-dev/hotspot repository. > > I would really like to bring this into 8u60 as this is a serious bug > which leads to incorrect computations. > Is this still possible by goiong trough jdk8u/hs-dev/hotspot? > > The other question is if I can push this ppc-only change myself to > jdk8u/hs-dev/hotspot or if I need a sponsor? > > Thank you and best regards, > Volker > From vladimir.kozlov at oracle.com Tue May 19 17:25:02 2015 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Tue, 19 May 2015 10:25:02 -0700 Subject: [8u60] request for approval: 8080190: PPC64: Fix wrong rotate instructions in the .ad file In-Reply-To: References: Message-ID: <555B71EE.30908@oracle.com> Reviewed and approved. Yes, you can push to jdk8u/hs-dev/hotspot. You have 8u committer status. Thanks, Vladimir On 5/19/15 6:54 AM, Volker Simonis wrote: > Hi, > > could you please approve the downport of the following, ppc-only fix > to jdk8u/hs-dev/hotspot > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080190 > Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2015/8080190.8u/ > Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-May/thread.html#17920 > URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4140f485ba27 > > The change cleanly applies to the jdk8u/hs-dev/hotspot repository. > > I would really like to bring this into 8u60 as this is a serious bug > which leads to incorrect computations. > Is this still possible by goiong trough jdk8u/hs-dev/hotspot? > > The other question is if I can push this ppc-only change myself to > jdk8u/hs-dev/hotspot or if I need a sponsor? > > Thank you and best regards, > Volker > From alejandro.murillo at oracle.com Tue May 19 17:38:40 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 19 May 2015 11:38:40 -0600 Subject: [8u60] request for approval: 8080190: PPC64: Fix wrong rotate instructions in the .ad file In-Reply-To: <555B68E5.2010304@oracle.com> References: <555B68E5.2010304@oracle.com> Message-ID: <555B7520.4070006@oracle.com> Volker, if this is only affecting ppc then go ahead and push manually. if not, let me know and I can grab the patch and push it via jprt cheers Alejandro On 5/19/2015 10:46 AM, Rob McKenna wrote: > Hi Volker, > > You can push directly to the hotspot team repo. It will make 8u60 > assuming you push before RDP 2. > > http://openjdk.java.net/projects/jdk8u/releases/8u60.html > > You should have committer access to that repo. Let us know if not. > > -Rob > > On 19/05/15 14:54, Volker Simonis wrote: >> Hi, >> >> could you please approve the downport of the following, ppc-only fix >> to jdk8u/hs-dev/hotspot >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8080190 >> Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2015/8080190.8u/ >> Review: >> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-May/thread.html#17920 >> URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4140f485ba27 >> >> The change cleanly applies to the jdk8u/hs-dev/hotspot repository. >> >> I would really like to bring this into 8u60 as this is a serious bug >> which leads to incorrect computations. >> Is this still possible by goiong trough jdk8u/hs-dev/hotspot? >> >> The other question is if I can push this ppc-only change myself to >> jdk8u/hs-dev/hotspot or if I need a sponsor? >> >> Thank you and best regards, >> Volker >> -- Alejandro From mark.sheppard at oracle.com Tue May 19 17:47:35 2015 From: mark.sheppard at oracle.com (Mark Sheppard) Date: Tue, 19 May 2015 18:47:35 +0100 Subject: RFA[8u-dev]: JDK-8068721 - RMI-IIOP communication fails when ConcurrentHashMap is passed to remote method Message-ID: <555B7737.1030803@oracle.com> Hi please approve the backport of https://bugs.openjdk.java.net/browse/JDK-8068721 to jdk8u changes were applied in parallel with jdk9 and regressions passed OK webrev: http://cr.openjdk.java.net/~msheppar/8068721/jdk8/corba/webrev/ http://cr.openjdk.java.net/~msheppar/8068721/jdk8/jdk/webrev/ issue: https://bugs.openjdk.java.net/browse/JDK-8068721 changeset: http://hg.openjdk.java.net/jdk9/dev/corba/rev/366c1c9fb6bb http://hg.openjdk.java.net/jdk9/dev/jdk/rev/24d02d2cc675 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032469.html regards Mark From sean.coffey at oracle.com Tue May 19 18:14:57 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Tue, 19 May 2015 19:14:57 +0100 Subject: RFA[8u-dev]: JDK-8068721 - RMI-IIOP communication fails when ConcurrentHashMap is passed to remote method In-Reply-To: <555B7737.1030803@oracle.com> References: <555B7737.1030803@oracle.com> Message-ID: <555B7DA1.6000001@oracle.com> Approved. Regards, Sean. On 19/05/2015 18:47, Mark Sheppard wrote: > Hi > please approve the backport of > https://bugs.openjdk.java.net/browse/JDK-8068721 > to jdk8u > > changes were applied in parallel with jdk9 and regressions passed OK > > webrev: http://cr.openjdk.java.net/~msheppar/8068721/jdk8/corba/webrev/ > http://cr.openjdk.java.net/~msheppar/8068721/jdk8/jdk/webrev/ > > issue: https://bugs.openjdk.java.net/browse/JDK-8068721 > > changeset: http://hg.openjdk.java.net/jdk9/dev/corba/rev/366c1c9fb6bb > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/24d02d2cc675 > > > review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032469.html > > regards > Mark > From philip.race at oracle.com Tue May 19 23:40:57 2015 From: philip.race at oracle.com (Phil Race) Date: Tue, 19 May 2015 16:40:57 -0700 Subject: [8u60]: request for approval: backport of 8076419: Path2D copy constructors and clone method propagate size of arrays from source path Message-ID: <555BCA09.9020306@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8076419 8u review : http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005391.html webrev : http://cr.openjdk.java.net/~prr/8076419.8u/ JDK9 changeset : http://hg.openjdk.java.net/jdk9/client/jdk/rev/9e9588daa10c -phil. From sundararajan.athijegannathan at oracle.com Wed May 20 04:33:09 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 20 May 2015 10:03:09 +0530 Subject: [8u60] 8072002: The spec on javax.script.Compilable contains a typo and confusing inconsistency Message-ID: <555C0E85.9050701@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8072002 jdk9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033552.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8072002/8u60/webrev.00/ Backported 'as is' except for the modular source code layout difference. Thanks, -Sundar From sean.coffey at oracle.com Wed May 20 08:07:20 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 20 May 2015 09:07:20 +0100 Subject: [8u60]: request for approval: backport of 8076419: Path2D copy constructors and clone method propagate size of arrays from source path In-Reply-To: <555BCA09.9020306@oracle.com> References: <555BCA09.9020306@oracle.com> Message-ID: <555C40B8.9040009@oracle.com> Approved. Regards, Sean. On 20/05/2015 00:40, Phil Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8076419 > > 8u review : > http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005391.html > > webrev : http://cr.openjdk.java.net/~prr/8076419.8u/ > > > JDK9 changeset : > http://hg.openjdk.java.net/jdk9/client/jdk/rev/9e9588daa10c > > -phil. From sean.coffey at oracle.com Wed May 20 08:17:02 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 20 May 2015 09:17:02 +0100 Subject: [8u60] 8072002: The spec on javax.script.Compilable contains a typo and confusing inconsistency In-Reply-To: <555C0E85.9050701@oracle.com> References: <555C0E85.9050701@oracle.com> Message-ID: <555C42FE.9050706@oracle.com> Approved. Regards, Sean. On 20/05/2015 05:33, A. Sundararajan wrote: > > Please approve. > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8072002 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033552.html > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8072002/8u60/webrev.00/ > > Backported 'as is' except for the modular source code layout difference. > > Thanks, > -Sundar From erik.joelsson at oracle.com Wed May 20 12:32:54 2015 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 20 May 2015 14:32:54 +0200 Subject: [8u60] Request for review and approval: JDK-8074523: Java.net bundle has incorrect file version for jre/jdk Message-ID: <555C7EF6.1010208@oracle.com> Please review and approve this fix for 8u60. On windows, native libraries and executables have version numbers embedded into them. These can be seen when right-clicking the binary in explorer, on the Details tab, as "Product version". Currently in 8 update releases, these versions strings are inconsistent. An example: in 8u45 b09 we have: bin\client\jvm.dll: 8.0.0.9 bin\decora_sse.dll: 8.0.45.09 bin\deploy.dll: 8.0.450.9 bin\java.exe: 8.0.45.9 These differences fall into 4 different categories. 1. jvm.dll in hotspot is not picking up the update version at all. This is due to a bug in the build-infra makefile rewrite that wasn't discovered in JDK 8 because it didn't have an update version. 2. decora_sse.dll is part of javafx. Fixing their version scheme is out of scope of this fix. A separate bug for javafx would be needed. 3. deploy.dll is actually the correct one. Historically we have encoded the update version with an extra digit for a potential letter at the end of the string. 4. java.exe, and the rest of the binaries from the jdk repository lost their extra 0 in the build-infra makefile rewrite and it wasn't discovered in JDK 8. Since we no longer use letters in update version strings, we could fix this by removing the extra 0. However, we have already released 8 updates where some binaries have the extra 0. Removing it would mean releasing 8u60 with binaries having version numbers lower than previous updates. For this reason I propose fixing this by adding the 0 for JDK and Hotspot binaries again, and of course by supplying the correct variable to the hotspot makefiles so that it even gets the update version in there. For clarity, with this patch, the above will log like this: bin\client\jvm.dll: 8.0.450.9 bin\decora_sse.dll: 8.0.45.09 bin\deploy.dll: 8.0.450.9 bin\java.exe: 8.0.450.9 Note that in JDK 9, the version number scheme is being completely reworked so this will not be an issue. Bug: https://bugs.openjdk.java.net/browse/JDK-8074523 Webrev: http://cr.openjdk.java.net/~erikj/8074523/webrev.01/index.html /Erik From sean.coffey at oracle.com Wed May 20 12:49:37 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 20 May 2015 13:49:37 +0100 Subject: [8u60] Request for review and approval: JDK-8074523: Java.net bundle has incorrect file version for jre/jdk In-Reply-To: <555C7EF6.1010208@oracle.com> References: <555C7EF6.1010208@oracle.com> Message-ID: <555C82E1.6010606@oracle.com> It might be good to edit the bug synopsis before pushing the change. I don't think this issue is specific to java.net bundles. Might also be useful to use the noreg-sqe label rather than noreg-build given that SQE team do appear to have test code for this area. Approved pending code review. Regards, Sean. On 20/05/15 13:32, Erik Joelsson wrote: > Please review and approve this fix for 8u60. > > On windows, native libraries and executables have version numbers > embedded into them. These can be seen when right-clicking the binary > in explorer, on the Details tab, as "Product version". Currently in 8 > update releases, these versions strings are inconsistent. An example: > > in 8u45 b09 we have: > > bin\client\jvm.dll: 8.0.0.9 > bin\decora_sse.dll: 8.0.45.09 > bin\deploy.dll: 8.0.450.9 > bin\java.exe: 8.0.45.9 > > These differences fall into 4 different categories. > > 1. jvm.dll in hotspot is not picking up the update version at all. > This is due to a bug in the build-infra makefile rewrite that wasn't > discovered in JDK 8 because it didn't have an update version. > > 2. decora_sse.dll is part of javafx. Fixing their version scheme is > out of scope of this fix. A separate bug for javafx would be needed. > > 3. deploy.dll is actually the correct one. Historically we have > encoded the update version with an extra digit for a potential letter > at the end of the string. > > 4. java.exe, and the rest of the binaries from the jdk repository lost > their extra 0 in the build-infra makefile rewrite and it wasn't > discovered in JDK 8. > > Since we no longer use letters in update version strings, we could fix > this by removing the extra 0. However, we have already released 8 > updates where some binaries have the extra 0. Removing it would mean > releasing 8u60 with binaries having version numbers lower than > previous updates. For this reason I propose fixing this by adding the > 0 for JDK and Hotspot binaries again, and of course by supplying the > correct variable to the hotspot makefiles so that it even gets the > update version in there. For clarity, with this patch, the above will > log like this: > > bin\client\jvm.dll: 8.0.450.9 > bin\decora_sse.dll: 8.0.45.09 > bin\deploy.dll: 8.0.450.9 > bin\java.exe: 8.0.450.9 > > Note that in JDK 9, the version number scheme is being completely > reworked so this will not be an issue. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8074523 > Webrev: http://cr.openjdk.java.net/~erikj/8074523/webrev.01/index.html > > /Erik From paul.sandoz at oracle.com Wed May 20 13:40:40 2015 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Wed, 20 May 2015 15:40:40 +0200 Subject: [8u60] RFA 8080623 CPU overhead in FJ due to spinning in awaitWork Message-ID: <298E0D51-0636-418F-BE98-704688B92680@oracle.com> Hi, I would like to backport the following to 8u60: https://bugs.openjdk.java.net/browse/JDK-8080623 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033570.html Patch applies cleanly: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dec15d6a0cbc Thanks, Paul. From volker.simonis at gmail.com Wed May 20 13:43:09 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 20 May 2015 15:43:09 +0200 Subject: [8u60] request for approval: 8080190: PPC64: Fix wrong rotate instructions in the .ad file In-Reply-To: <555B7520.4070006@oracle.com> References: <555B68E5.2010304@oracle.com> <555B7520.4070006@oracle.com> Message-ID: Hi everybody, thanks a lot for your support. I've just successfully pushed the change to jdk8u/hs-dev/hotspot. Regards, Volker On Tue, May 19, 2015 at 7:38 PM, Alejandro E Murillo wrote: > > Volker, > if this is only affecting ppc then go ahead and push manually. > if not, let me know and I can grab the patch and push it via jprt > > cheers > Alejandro > > > On 5/19/2015 10:46 AM, Rob McKenna wrote: >> >> Hi Volker, >> >> You can push directly to the hotspot team repo. It will make 8u60 assuming >> you push before RDP 2. >> >> http://openjdk.java.net/projects/jdk8u/releases/8u60.html >> >> You should have committer access to that repo. Let us know if not. >> >> -Rob >> >> On 19/05/15 14:54, Volker Simonis wrote: >>> >>> Hi, >>> >>> could you please approve the downport of the following, ppc-only fix >>> to jdk8u/hs-dev/hotspot >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8080190 >>> Webrev: http://cr.openjdk.java.net/~simonis/webrevs/2015/8080190.8u/ >>> Review: >>> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-May/thread.html#17920 >>> URL: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4140f485ba27 >>> >>> The change cleanly applies to the jdk8u/hs-dev/hotspot repository. >>> >>> I would really like to bring this into 8u60 as this is a serious bug >>> which leads to incorrect computations. >>> Is this still possible by goiong trough jdk8u/hs-dev/hotspot? >>> >>> The other question is if I can push this ppc-only change myself to >>> jdk8u/hs-dev/hotspot or if I need a sponsor? >>> >>> Thank you and best regards, >>> Volker >>> > > -- > Alejandro > From rob.mckenna at oracle.com Wed May 20 13:58:08 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 20 May 2015 14:58:08 +0100 Subject: [8u60] RFA 8080623 CPU overhead in FJ due to spinning in awaitWork In-Reply-To: <298E0D51-0636-418F-BE98-704688B92680@oracle.com> References: <298E0D51-0636-418F-BE98-704688B92680@oracle.com> Message-ID: <555C92F0.9010306@oracle.com> Approved. -Rob On 20/05/15 14:40, Paul Sandoz wrote: > Hi, > > I would like to backport the following to 8u60: > > https://bugs.openjdk.java.net/browse/JDK-8080623 > > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033570.html > > Patch applies cleanly: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dec15d6a0cbc > > Thanks, > Paul. > From erik.joelsson at oracle.com Wed May 20 14:09:40 2015 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Wed, 20 May 2015 16:09:40 +0200 Subject: [8u60] Request for review and approval: JDK-8074523: Windows native binaries have inconsistent "Product version" In-Reply-To: <555C82E1.6010606@oracle.com> References: <555C7EF6.1010208@oracle.com> <555C82E1.6010606@oracle.com> Message-ID: <555C95A4.5010801@oracle.com> Thanks, changed to: Windows native binaries have inconsistent "Product version" Changed the label. /Erik On 2015-05-20 14:49, Se?n Coffey wrote: > It might be good to edit the bug synopsis before pushing the change. I > don't think this issue is specific to java.net bundles. Might also be > useful to use the noreg-sqe label rather than noreg-build given that > SQE team do appear to have test code for this area. > > Approved pending code review. > > Regards, > Sean. > > On 20/05/15 13:32, Erik Joelsson wrote: >> Please review and approve this fix for 8u60. >> >> On windows, native libraries and executables have version numbers >> embedded into them. These can be seen when right-clicking the binary >> in explorer, on the Details tab, as "Product version". Currently in 8 >> update releases, these versions strings are inconsistent. An example: >> >> in 8u45 b09 we have: >> >> bin\client\jvm.dll: 8.0.0.9 >> bin\decora_sse.dll: 8.0.45.09 >> bin\deploy.dll: 8.0.450.9 >> bin\java.exe: 8.0.45.9 >> >> These differences fall into 4 different categories. >> >> 1. jvm.dll in hotspot is not picking up the update version at all. >> This is due to a bug in the build-infra makefile rewrite that wasn't >> discovered in JDK 8 because it didn't have an update version. >> >> 2. decora_sse.dll is part of javafx. Fixing their version scheme is >> out of scope of this fix. A separate bug for javafx would be needed. >> >> 3. deploy.dll is actually the correct one. Historically we have >> encoded the update version with an extra digit for a potential letter >> at the end of the string. >> >> 4. java.exe, and the rest of the binaries from the jdk repository >> lost their extra 0 in the build-infra makefile rewrite and it wasn't >> discovered in JDK 8. >> >> Since we no longer use letters in update version strings, we could >> fix this by removing the extra 0. However, we have already released 8 >> updates where some binaries have the extra 0. Removing it would mean >> releasing 8u60 with binaries having version numbers lower than >> previous updates. For this reason I propose fixing this by adding the >> 0 for JDK and Hotspot binaries again, and of course by supplying the >> correct variable to the hotspot makefiles so that it even gets the >> update version in there. For clarity, with this patch, the above will >> log like this: >> >> bin\client\jvm.dll: 8.0.450.9 >> bin\decora_sse.dll: 8.0.45.09 >> bin\deploy.dll: 8.0.450.9 >> bin\java.exe: 8.0.450.9 >> >> Note that in JDK 9, the version number scheme is being completely >> reworked so this will not be an issue. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8074523 >> Webrev: http://cr.openjdk.java.net/~erikj/8074523/webrev.01/index.html >> >> /Erik > From ivan.gerasimov at oracle.com Wed May 20 16:58:09 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 20 May 2015 19:58:09 +0300 Subject: [8u-dev] Request for review AND approval to backport: 8077102: Message-ID: <555CBD21.6060207@oracle.com> Hi! The backport required some manual editing, thus I'm asking for a review too. Would you please review and approve backporting this fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8077102 WEBREV: http://cr.openjdk.java.net/~igerasim/8077102/00/webrev/ The fix was tested on all available platforms, no failures. Sincerely yours, Ivan From rob.mckenna at oracle.com Wed May 20 17:31:40 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 20 May 2015 18:31:40 +0100 Subject: [8u-dev] Request for approval: 8077822: javac does not recognize '*.java' as file if '-J' option is specified Message-ID: <555CC4FC.8040903@oracle.com> Hi folks, Patch applies cleanly. https://bugs.openjdk.java.net/browse/JDK-8077822 http://hg.openjdk.java.net/jdk9/dev/jdk/rev/befc91735d0b http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033559.html -Rob From naoto.sato at oracle.com Wed May 20 17:58:41 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 20 May 2015 10:58:41 -0700 Subject: [8u-dev] Request for approval: 8077822: javac does not recognize '*.java' as file if '-J' option is specified In-Reply-To: <555CC4FC.8040903@oracle.com> References: <555CC4FC.8040903@oracle.com> Message-ID: <555CCB51.3030909@oracle.com> Approved. Naoto On 5/20/15 10:31 AM, Rob McKenna wrote: > Hi folks, > > Patch applies cleanly. > > https://bugs.openjdk.java.net/browse/JDK-8077822 > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/befc91735d0b > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033559.html > > -Rob From sean.coffey at oracle.com Wed May 20 20:50:15 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 20 May 2015 21:50:15 +0100 Subject: Approval missing : Re: hg: jdk8u/jdk8u-dev/jdk: 8066985: Java Webstart downloading packed files can result in Timezone set to UTC In-Reply-To: <201505201458.t4KEw0VI019279@aojmv0008.oracle.com> References: <201505201458.t4KEw0VI019279@aojmv0008.oracle.com> Message-ID: <555CF387.5040502@oracle.com> Mikhail, I don't see an approval request for this push to jdk8u-dev. Can you retroactively log one for records purposes ? Regards, Sean. On 20/05/2015 15:58, mikhail.cherkasov at oracle.com wrote: > Changeset: 721a9a7c39b7 > Author: mcherkas > Date: 2015-05-20 18:55 +0400 > URL: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/721a9a7c39b7 > > 8066985: Java Webstart downloading packed files can result in Timezone set to UTC > Reviewed-by: ksrini > > ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java > ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java > ! src/share/classes/com/sun/java/util/jar/pack/Utils.java > + test/tools/pack200/DefaultTimeZoneTest.java > From philip.race at oracle.com Wed May 20 22:20:59 2015 From: philip.race at oracle.com (Phil Race) Date: Wed, 20 May 2015 15:20:59 -0700 Subject: [8u60]: request for approval: backport of 8078464 : Path2D storage growth algorithms should be less linear Message-ID: <555D08CB.8090104@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8078464 8u review : http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005397.html webrev : http://cr.openjdk.java.net/~prr/8078464.8u/ JDK 9 changeset : http://hg.openjdk.java.net/jdk9/client/jdk/rev/9b6ed21ae317 -phil. From rob.mckenna at oracle.com Wed May 20 22:29:16 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 20 May 2015 23:29:16 +0100 Subject: [8u60]: request for approval: backport of 8078464 : Path2D storage growth algorithms should be less linear In-Reply-To: <555D08CB.8090104@oracle.com> References: <555D08CB.8090104@oracle.com> Message-ID: <555D0ABC.9050401@oracle.com> Approved. -Rob On 20/05/15 23:20, Phil Race wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8078464 > 8u review : > http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005397.html > webrev : http://cr.openjdk.java.net/~prr/8078464.8u/ > JDK 9 changeset : > http://hg.openjdk.java.net/jdk9/client/jdk/rev/9b6ed21ae317 > > -phil. From mikhail.cherkasov at oracle.com Wed May 20 22:56:15 2015 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Thu, 21 May 2015 01:56:15 +0300 Subject: Approval missing : Re: hg: jdk8u/jdk8u-dev/jdk: 8066985: Java Webstart downloading packed files can result in Timezone set to UTC In-Reply-To: <555CF387.5040502@oracle.com> References: <201505201458.t4KEw0VI019279@aojmv0008.oracle.com> <555CF387.5040502@oracle.com> Message-ID: <555D110F.5060404@oracle.com> Hi Sean, I'll send approval in 1 min. Thanks, Mikhail. On 5/20/2015 11:50 PM, Se?n Coffey wrote: > Mikhail, > > I don't see an approval request for this push to jdk8u-dev. Can you > retroactively log one for records purposes ? > > Regards, > Sean. > > On 20/05/2015 15:58, mikhail.cherkasov at oracle.com wrote: >> Changeset: 721a9a7c39b7 >> Author: mcherkas >> Date: 2015-05-20 18:55 +0400 >> URL: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/721a9a7c39b7 >> >> 8066985: Java Webstart downloading packed files can result in >> Timezone set to UTC >> Reviewed-by: ksrini >> >> ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java >> ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java >> ! src/share/classes/com/sun/java/util/jar/pack/Utils.java >> + test/tools/pack200/DefaultTimeZoneTest.java >> > From mikhail.cherkasov at oracle.com Wed May 20 23:02:57 2015 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Thu, 21 May 2015 02:02:57 +0300 Subject: [8u-dev] approval request for 8066985: Java Webstart downloading packed files can result in Timezone set to UTC Message-ID: <555D12A1.1050907@oracle.com> Hello there! Please approve a fix for 8u-dev: Bug: https://bugs.openjdk.java.net/browse/JDK-8066985 Webrev: http://cr.openjdk.java.net/~mcherkas/8066985/webrev.12/ Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032347.html http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033572.html Thanks, Mikhail. From sundararajan.athijegannathan at oracle.com Thu May 21 04:58:34 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 21 May 2015 10:28:34 +0530 Subject: [8u60] approval request for 8067636 and 8080598 Message-ID: <555D65FA.5030106@oracle.com> Please approve. Bugs: https://bugs.openjdk.java.net/browse/JDK-8067636 https://bugs.openjdk.java.net/browse/JDK-8080598 jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8067636_8080598/8u60/webrev.00/ jdk9 review threads: http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004036.html http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004579.html Backported "as is" except for the modular source layout differences. Thanks, -Sundar From weijun.wang at oracle.com Thu May 21 06:46:20 2015 From: weijun.wang at oracle.com (Weijun Wang) Date: Thu, 21 May 2015 14:46:20 +0800 Subject: [8u-dev] Request for review AND approval to backport: 8077102: In-Reply-To: <555CBD21.6060207@oracle.com> References: <555CBD21.6060207@oracle.com> Message-ID: <555D7F3C.5050605@oracle.com> Code change is fine. Thanks Max On 5/21/2015 12:58 AM, Ivan Gerasimov wrote: > Hi! > > The backport required some manual editing, thus I'm asking for a review > too. > Would you please review and approve backporting this fix? > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8077102 > WEBREV: http://cr.openjdk.java.net/~igerasim/8077102/00/webrev/ > > The fix was tested on all available platforms, no failures. > > Sincerely yours, > Ivan From sean.coffey at oracle.com Thu May 21 07:22:38 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 21 May 2015 08:22:38 +0100 Subject: [8u60] approval request for 8067636 and 8080598 In-Reply-To: <555D65FA.5030106@oracle.com> References: <555D65FA.5030106@oracle.com> Message-ID: <555D87BE.2000200@oracle.com> Approved. Regards, Sean. On 21/05/2015 05:58, A. Sundararajan wrote: > Please approve. > > Bugs: > > https://bugs.openjdk.java.net/browse/JDK-8067636 > https://bugs.openjdk.java.net/browse/JDK-8080598 > > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8067636_8080598/8u60/webrev.00/ > > jdk9 review threads: > > http://mail.openjdk.java.net/pipermail/nashorn-dev/2014-December/004036.html > > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004579.html > > Backported "as is" except for the modular source layout differences. > > Thanks, > -Sundar From sean.coffey at oracle.com Thu May 21 07:28:09 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 21 May 2015 08:28:09 +0100 Subject: [8u-dev] approval request for 8066985: Java Webstart downloading packed files can result in Timezone set to UTC In-Reply-To: <555D12A1.1050907@oracle.com> References: <555D12A1.1050907@oracle.com> Message-ID: <555D8908.3050906@oracle.com> Thanks for following up Mikhail. Approved for jdk8u-dev. It's not obvious why this is marked 9-na - if you can add some brief info to bug on that, it could be useful for reference. Regards, Sean. On 21/05/2015 00:02, mikhail cherkasov wrote: > Hello there! > > Please approve a fix for 8u-dev: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8066985 > Webrev: http://cr.openjdk.java.net/~mcherkas/8066985/webrev.12/ > Review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-March/032347.html > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033572.html > > Thanks, > Mikhail. From darwinfelix at yahoo.com Wed May 20 23:28:29 2015 From: darwinfelix at yahoo.com (Darwin Felix) Date: Wed, 20 May 2015 16:28:29 -0700 Subject: 8078439: 8048194: possible bug in commit for these two fixes Message-ID: <1432164509.64528.BPMail_high_carrier@web162905.mail.bf1.yahoo.com> 8078439: 8048194: possible bug in commit for these two fixes It appears that this commit has a bug: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/d777e2918a77/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java Fundamentally, it appears that this commit desires to honor the initiator/client's preferred mechanism - first one in the list of mechanisms the client is offering to the target/server. However, the commit does not allow for the condition where the server can only support a different mechanism from the client's offering/list (server not able to support mechList[0] but is able to support mechList[N]). In my humble opinion, based on my quick glance of the code, this commit is broken because the server is no longer allowed to select from one of the other mechanisms from the client's list. This next commit also appears to have a bug: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/9ab9f20e9bdd/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java It appears that this commit also desires to honor the initiator/client's preferred mechanism. However, this commit also appears to suffer from the condition where the server can only support a different mechanism from the client's offering/list (server not able to support mechList[0] but is able to support mechList[N]). Perhaps the above two (2) commits should be reverted? An alternative approach to supporting/honoring the initiator/client's preferred mechanism: Prior to the above two (2) commits, SpNegoContext.java suffered from the condition where it did not make an attempt/consider to use the initiator/client's preferred mechanism. Instead, the code would find a mechanism from the client's list that the server can support. Meaning, the server's supported/preferred mechanisms is the outer loop and the client's supported/preferred mechanism is the inner loop (preference specified by its order in the list). Here's what the code looked like prior to the above two (2) commits: http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/1a3de3cdc684/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java Perhaps, if we simply place the client's list as the outer loop and the server's list as the inner loop, we might be able to honor the client's preferred mechanism while ensuring that the chosen mechanism is one that the server can support. For example, have a look at the implementation of the method named SpNegoContext.negotiate_mech_type(supported_mechSet, mechList) Notice that the server's list is chosen as being the outer loop. It might make more sense to have the client's list be the outer loop. If possible, I would like to discuss the possibility of reverting the above two commits and instead implement my proposed change (mechList as the outer loop and supported_mechSet as the inner loop) to the method named negotiate_mech_type. thanks, -darwin From sean.coffey at oracle.com Thu May 21 07:57:29 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 21 May 2015 08:57:29 +0100 Subject: 8078439: 8048194: possible bug in commit for these two fixes In-Reply-To: <1432164509.64528.BPMail_high_carrier@web162905.mail.bf1.yahoo.com> References: <1432164509.64528.BPMail_high_carrier@web162905.mail.bf1.yahoo.com> Message-ID: <555D8FE9.4060706@oracle.com> Darwin, being a security libs issues, this is probably best discussed on the security-dev java.net mailing list. I'll forward this and cc you. You may also wish to report your issue via http://bugreport.java.com/ Regards, Sean. On 21/05/2015 00:28, Darwin Felix wrote: > 8078439: 8048194: possible bug in commit for these two fixes > > It appears that this commit has a bug: > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/d777e2918a77/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java > Fundamentally, it appears that this commit desires to honor the initiator/client's preferred mechanism - first one in the list of mechanisms the client is offering to the target/server. > However, the commit does not allow for the condition where the server can only support a different mechanism from the client's offering/list (server not able to support mechList[0] but is able to support mechList[N]). > > In my humble opinion, based on my quick glance of the code, this commit is broken because the server is no longer allowed to select from one of the other mechanisms from the client's list. > > > This next commit also appears to have a bug: > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/9ab9f20e9bdd/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java > It appears that this commit also desires to honor the initiator/client's preferred mechanism. > However, this commit also appears to suffer from the condition where the server can only support a different mechanism from the client's offering/list (server not able to support mechList[0] but is able to support mechList[N]). > > > > Perhaps the above two (2) commits should be reverted? > > An alternative approach to supporting/honoring the initiator/client's preferred mechanism: > > Prior to the above two (2) commits, SpNegoContext.java suffered from the condition where it did not make an attempt/consider to use the initiator/client's preferred mechanism. Instead, the code would find a mechanism from the client's list that the server can support. Meaning, the server's supported/preferred mechanisms is the outer loop and the client's supported/preferred mechanism is the inner loop (preference specified by its order in the list). > > Here's what the code looked like prior to the above two (2) commits: > > http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/file/1a3de3cdc684/src/share/classes/sun/security/jgss/spnego/SpNegoContext.java > Perhaps, if we simply place the client's list as the outer loop and the server's list as the inner loop, we might be able to honor the client's preferred mechanism while ensuring that the chosen mechanism is one that the server can support. > > For example, have a look at the implementation of the method named > > SpNegoContext.negotiate_mech_type(supported_mechSet, mechList) > > Notice that the server's list is chosen as being the outer loop. It might make more sense to have the client's list be the outer loop. > > > If possible, I would like to discuss the possibility of reverting the above two commits and instead implement my proposed change (mechList as the outer loop and supported_mechSet as the inner loop) to the method named negotiate_mech_type. > > > thanks, > -darwin From sean.coffey at oracle.com Thu May 21 08:32:20 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 21 May 2015 09:32:20 +0100 Subject: [8u-dev] Request for review AND approval to backport: 8077102: In-Reply-To: <555D7F3C.5050605@oracle.com> References: <555CBD21.6060207@oracle.com> <555D7F3C.5050605@oracle.com> Message-ID: <555D9814.3000106@oracle.com> Approved. Regards, Sean. On 21/05/2015 07:46, Weijun Wang wrote: > Code change is fine. > > Thanks > Max > > On 5/21/2015 12:58 AM, Ivan Gerasimov wrote: >> Hi! >> >> The backport required some manual editing, thus I'm asking for a review >> too. >> Would you please review and approve backporting this fix? >> >> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8077102 >> WEBREV: http://cr.openjdk.java.net/~igerasim/8077102/00/webrev/ >> >> The fix was tested on all available platforms, no failures. >> >> Sincerely yours, >> Ivan From rob.mckenna at oracle.com Thu May 21 12:08:34 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 21 May 2015 13:08:34 +0100 Subject: [8u-dev] Request for Approval: 8077155: LoginContext Subject ignored by jdk8 sun.net.www.protocol.http.HttpURLConnection Message-ID: <555DCAC2.2090106@oracle.com> Hi folks, Looking to backport this change to 8. Patch applies cleanly. bug: https://bugs.openjdk.java.net/browse/JDK-8077155 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/6d6986142663 review: http://mail.openjdk.java.net/pipermail/net-dev/2015-May/008985.html -Rob From sean.coffey at oracle.com Thu May 21 12:19:48 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 21 May 2015 13:19:48 +0100 Subject: [8u-dev] Request for Approval: 8077155: LoginContext Subject ignored by jdk8 sun.net.www.protocol.http.HttpURLConnection In-Reply-To: <555DCAC2.2090106@oracle.com> References: <555DCAC2.2090106@oracle.com> Message-ID: <555DCD64.90104@oracle.com> Approved. Regards, Sean. On 21/05/2015 13:08, Rob McKenna wrote: > Hi folks, > > Looking to backport this change to 8. Patch applies cleanly. > > bug: https://bugs.openjdk.java.net/browse/JDK-8077155 > 9 changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/6d6986142663 > review: > http://mail.openjdk.java.net/pipermail/net-dev/2015-May/008985.html > > -Rob From sundararajan.athijegannathan at oracle.com Thu May 21 13:38:56 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 21 May 2015 19:08:56 +0530 Subject: [8u60] approval request for 8080848: delete of bound Java method property results in crash Message-ID: <555DDFF0.9060704@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8080848 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004582.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8080848/8u60/webrev.00/ Backported "as is" except for the modular source layout difference. Thanks, -Sundar From rob.mckenna at oracle.com Thu May 21 13:44:28 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 21 May 2015 14:44:28 +0100 Subject: [8u60] approval request for 8080848: delete of bound Java method property results in crash In-Reply-To: <555DDFF0.9060704@oracle.com> References: <555DDFF0.9060704@oracle.com> Message-ID: <555DE13C.3050207@oracle.com> Approved. -Rob On 21/05/15 14:38, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8080848 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004582.html > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8080848/8u60/webrev.00/ > > Backported "as is" except for the modular source layout difference. > > Thanks, > -Sundar From mandy.chung at oracle.com Thu May 21 16:58:47 2015 From: mandy.chung at oracle.com (Mandy Chung) Date: Thu, 21 May 2015 09:58:47 -0700 Subject: [8u60] Request Approval for 8068937 and 8080815 Message-ID: <555E0EC7.60403@oracle.com> 1. JDK-8068937: jdeps shows "not found" if target class has no reference other than its own package JDK-8068937 has been fixed in JDK 9. This is to request backport to 8u60. https://bugs.openjdk.java.net/browse/JDK-8068937 http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8068937/webrev.00/ The fix is imported and revised to remove use of lambda. 2. JDK-8080815: Update 8u jdeps list of internal APIs This is 8u-only fix. It has been reviewed [1] by Daniel Fuchs. https://bugs.openjdk.java.net/browse/JDK-8080815 http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8080815/webrev.00/ Thanks Mandy [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033634.html From sundararajan.athijegannathan at oracle.com Thu May 21 17:06:17 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 21 May 2015 22:36:17 +0530 Subject: [8u60] approval request for 8079145: jdk.nashorn.internal.runtime.arrays.IntArrayData.convert assertion Message-ID: <555E1089.4030801@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079145 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004585.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8079145/8u60/webrev.00/ Thanks, -Sundar From sundararajan.athijegannathan at oracle.com Thu May 21 17:06:42 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 21 May 2015 22:36:42 +0530 Subject: [8u60] approval request for 8079145: jdk.nashorn.internal.runtime.arrays.IntArrayData.convert assertion Message-ID: <555E10A2.7050103@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8079145 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004585.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8079145/8u60/webrev.00/ Thanks, -Sundar From rob.mckenna at oracle.com Thu May 21 17:11:32 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 21 May 2015 18:11:32 +0100 Subject: [8u60] Request Approval for 8068937 and 8080815 In-Reply-To: <555E0EC7.60403@oracle.com> References: <555E0EC7.60403@oracle.com> Message-ID: <555E11C4.4090302@oracle.com> Approved assuming codereview approval for 1. -Rob On 21/05/15 17:58, Mandy Chung wrote: > 1. JDK-8068937: jdeps shows "not found" if target class has no reference > other than its own package > > JDK-8068937 has been fixed in JDK 9. This is to request backport to 8u60. > > https://bugs.openjdk.java.net/browse/JDK-8068937 > http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8068937/webrev.00/ > > The fix is imported and revised to remove use of lambda. > > 2. JDK-8080815: Update 8u jdeps list of internal APIs > > This is 8u-only fix. It has been reviewed [1] by Daniel Fuchs. > > https://bugs.openjdk.java.net/browse/JDK-8080815 > http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8080815/webrev.00/ > > Thanks > Mandy > [1] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033634.html From rob.mckenna at oracle.com Thu May 21 17:13:04 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 21 May 2015 18:13:04 +0100 Subject: [8u60] approval request for 8079145: jdk.nashorn.internal.runtime.arrays.IntArrayData.convert assertion In-Reply-To: <555E1089.4030801@oracle.com> References: <555E1089.4030801@oracle.com> Message-ID: <555E1220.1040300@oracle.com> Approved. -Rob On 21/05/15 18:06, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8079145 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004585.html > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8079145/8u60/webrev.00/ > > Thanks, > -Sundar From daniel.fuchs at oracle.com Thu May 21 17:24:15 2015 From: daniel.fuchs at oracle.com (Daniel Fuchs) Date: Thu, 21 May 2015 19:24:15 +0200 Subject: [8u60] Request Approval for 8068937 and 8080815 In-Reply-To: <555E11C4.4090302@oracle.com> References: <555E0EC7.60403@oracle.com> <555E11C4.4090302@oracle.com> Message-ID: <555E14BF.4010904@oracle.com> On 21/05/15 19:11, Rob McKenna wrote: > Approved assuming codereview approval for 1. 1. looks fine to me :-) best regards, -- daniel > > -Rob > > On 21/05/15 17:58, Mandy Chung wrote: >> 1. JDK-8068937: jdeps shows "not found" if target class has no reference >> other than its own package >> >> JDK-8068937 has been fixed in JDK 9. This is to request backport to >> 8u60. >> >> https://bugs.openjdk.java.net/browse/JDK-8068937 >> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8068937/webrev.00/ >> >> The fix is imported and revised to remove use of lambda. >> >> 2. JDK-8080815: Update 8u jdeps list of internal APIs >> >> This is 8u-only fix. It has been reviewed [1] by Daniel Fuchs. >> >> https://bugs.openjdk.java.net/browse/JDK-8080815 >> http://cr.openjdk.java.net/~mchung/jdk8u/webrevs/8080815/webrev.00/ >> >> Thanks >> Mandy >> [1] >> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033634.html From peter.brunet at oracle.com Fri May 22 03:52:54 2015 From: peter.brunet at oracle.com (Pete Brunet) Date: Thu, 21 May 2015 22:52:54 -0500 Subject: RfA backport of JDK-8078408 Message-ID: <555EA816.3030705@oracle.com> I'd like to backport JDK-8078408 from 9 to 8u. The 8u bug is JDK-8079828. This is a simple patch to add a null check to eliminate an NPE. https://bugs.openjdk.java.net/browse/JDK-8078408 // 9 bug https://bugs.openjdk.java.net/browse/JDK-8079828 // 8u bug http://hg.openjdk.java.net/jdk9/client/jdk/rev/0c2a21066609 http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009347.html Due to the different file structure from 9 to 8u the patch would not apply cleanly but after making the same change the patch builds clean locally and on JPRT and tests clean. Pete From sean.coffey at oracle.com Fri May 22 08:12:38 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 22 May 2015 09:12:38 +0100 Subject: RfA backport of JDK-8078408 In-Reply-To: <555EA816.3030705@oracle.com> References: <555EA816.3030705@oracle.com> Message-ID: <555EE4F6.6010603@oracle.com> Approved. Regards, Sean. On 22/05/2015 04:52, Pete Brunet wrote: > I'd like to backport JDK-8078408 from 9 to 8u. The 8u bug is JDK-8079828. > > This is a simple patch to add a null check to eliminate an NPE. > > https://bugs.openjdk.java.net/browse/JDK-8078408 // 9 bug > https://bugs.openjdk.java.net/browse/JDK-8079828 // 8u bug > http://hg.openjdk.java.net/jdk9/client/jdk/rev/0c2a21066609 > http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009347.html > > Due to the different file structure from 9 to 8u the patch would not > apply cleanly but after making the same change the patch builds clean > locally and on JPRT and tests clean. > > Pete From denis.kononenko at oracle.com Fri May 22 11:30:38 2015 From: denis.kononenko at oracle.com (denis kononenko) Date: Fri, 22 May 2015 14:30:38 +0300 Subject: [8u60] Request Approval for 8077866 Message-ID: <555F135E.9040406@oracle.com> Please approve. JDK-8077866: [TESTBUG] Some of java.lang tests cannot be run on compact profiles 1, 2 This is backport for JDK-8080694 which has been fixed in JDK 9. JDK 9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033505.html JDK 9 webrev link: http://cr.openjdk.java.net/~skovalev/dkononen/8077866/webrev.00/ The change is applied cleanly. Thank you, Denis. From rob.mckenna at oracle.com Fri May 22 11:32:38 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 22 May 2015 12:32:38 +0100 Subject: [8u60] Request Approval for 8077866 In-Reply-To: <555F135E.9040406@oracle.com> References: <555F135E.9040406@oracle.com> Message-ID: <555F13D6.9010506@oracle.com> Approved. Please follow the approval request template for future requests: http://openjdk.java.net/projects/jdk8u/approval-template.html -Rob On 22/05/15 12:30, denis kononenko wrote: > > Please approve. > > JDK-8077866: [TESTBUG] Some of java.lang tests cannot be run on compact > profiles 1, 2 > > This is backport for JDK-8080694 which has been fixed in JDK 9. > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033505.html > JDK 9 webrev link: > http://cr.openjdk.java.net/~skovalev/dkononen/8077866/webrev.00/ > > The change is applied cleanly. > > Thank you, > Denis. > > From mark.reinhold at oracle.com Fri May 22 15:29:58 2015 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Fri, 22 May 2015 08:29:58 -0700 Subject: Result: New JDK 8u Committer: Alexey Ivanov In-Reply-To: <5555DA5F.2040709@oracle.com> References: <5555DA5F.2040709@oracle.com> Message-ID: <20150522082958.944418@eggemoggin.niobe.net> 2015/5/15 4:37 -0700, alexander.potochkin at oracle.com: > Voting for Alexey Ivanov [1] is now closed. > > Yes: 8 > Veto: 0 > Abstain: 0 > > According to the Bylaws definition of Lazy Consensus, this is > sufficient to approve the nomination. So recorded. - Mark From alejandro.murillo at oracle.com Fri May 22 18:36:48 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 22 May 2015 12:36:48 -0600 Subject: [8u60] Request for approval for bulk integration of hs25.60-b17 Message-ID: <555F7740.3070706@oracle.com> Requesting approval to integrate hs25.60-b17 into jdk8u60-b17. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b17-jdk8u60-b17.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 6536943: Bogus -Xcheck:jni warning for SIG_INT action for SIGINT in JVM started from non-interactive shell 8048179: Early reclaim of large objects that are referenced by a few objects 8061715: gc/g1/TestShrinkAuxiliaryData15.java fails with java.lang.RuntimeException: heap decommit failed - after > before 8069367: Eagerly reclaimed humongous objects left on mark stack 8075215: SATB buffer processing found reclaimed humongous object 8075466: SATB queue pre-filter verify found reclaimed humongous object 8076265: Simplify deal_with_reference 8078021: SATB apply_closure_to_completed_buffer should have closure argument 8078023: verify_no_cset_oops found reclaimed humongous object in SATB buffer 8079644: memory stomping error with ResourceManagement and TestAgentStress.java 8080190: PPC64: Fix wrong rotate instructions in the .ad file 8080458: new hotspot build - hs25.60-b17 -- Alejandro From rob.mckenna at oracle.com Fri May 22 18:59:11 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 22 May 2015 19:59:11 +0100 Subject: [8u60] Request for approval for bulk integration of hs25.60-b17 In-Reply-To: <555F7740.3070706@oracle.com> References: <555F7740.3070706@oracle.com> Message-ID: <555F7C7F.6080004@oracle.com> Approved pending successful PIT. -Rob On 22/05/15 19:36, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.60-b17 into jdk8u60-b17. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b17-jdk8u60-b17.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 6536943: Bogus -Xcheck:jni warning for SIG_INT action for SIGINT in JVM > started from non-interactive shell > 8048179: Early reclaim of large objects that are referenced by a few > objects > 8061715: gc/g1/TestShrinkAuxiliaryData15.java fails with > java.lang.RuntimeException: heap decommit failed - after > before > 8069367: Eagerly reclaimed humongous objects left on mark stack > 8075215: SATB buffer processing found reclaimed humongous object > 8075466: SATB queue pre-filter verify found reclaimed humongous object > 8076265: Simplify deal_with_reference > 8078021: SATB apply_closure_to_completed_buffer should have closure > argument > 8078023: verify_no_cset_oops found reclaimed humongous object in SATB > buffer > 8079644: memory stomping error with ResourceManagement and > TestAgentStress.java > 8080190: PPC64: Fix wrong rotate instructions in the .ad file > 8080458: new hotspot build - hs25.60-b17 > From vincent.x.ryan at oracle.com Sat May 23 17:52:51 2015 From: vincent.x.ryan at oracle.com (Vincent Ryan) Date: Sat, 23 May 2015 18:52:51 +0100 Subject: [8u60] Request for approval for 8062552: Support keystore type detection for JKS and PKCS12 keystores Message-ID: <3D457EF2-2C56-4657-9B89-4DCAE906B3E6@oracle.com> Please approve the following 8u-only fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8062552 Webrev: http://cr.openjdk.java.net/~vinnie/8062552/webrev.02/ Review: http://mail.openjdk.java.net/pipermail/security-dev/2015-May/012176.html From sean.coffey at oracle.com Mon May 25 07:25:17 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 25 May 2015 08:25:17 +0100 Subject: [8u60] Request for approval for 8062552: Support keystore type detection for JKS and PKCS12 keystores In-Reply-To: <3D457EF2-2C56-4657-9B89-4DCAE906B3E6@oracle.com> References: <3D457EF2-2C56-4657-9B89-4DCAE906B3E6@oracle.com> Message-ID: <5562CE5D.2040408@oracle.com> Approved. Regards, Sean. On 23/05/2015 18:52, Vincent Ryan wrote: > Please approve the following 8u-only fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8062552 > Webrev: http://cr.openjdk.java.net/~vinnie/8062552/webrev.02/ > Review: http://mail.openjdk.java.net/pipermail/security-dev/2015-May/012176.html From sundararajan.athijegannathan at oracle.com Mon May 25 14:53:45 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Mon, 25 May 2015 20:23:45 +0530 Subject: [8u60] approval request for 8068978: All versions of javax.script.ScriptEngine.eval(...) method may clarify ScriptException throwing Message-ID: <55633779.10709@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8068978 jdk9 review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033685.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8068978/8u60/webrev.00/ Backported 'as is' except for modular source layout difference. Thanks, -Sundar From sean.coffey at oracle.com Mon May 25 15:03:51 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Mon, 25 May 2015 16:03:51 +0100 Subject: [8u60] approval request for 8068978: All versions of javax.script.ScriptEngine.eval(...) method may clarify ScriptException throwing In-Reply-To: <55633779.10709@oracle.com> References: <55633779.10709@oracle.com> Message-ID: <556339D7.5000708@oracle.com> Sundar, this looks like a spec change in an update release and as such isn't appropriate. Can we leave this change out of jdk8u ? Regards, Sean. On 25/05/15 15:53, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8068978 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033685.html > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8068978/8u60/webrev.00/ > > Backported 'as is' except for modular source layout difference. > > Thanks, > -Sundar From maurizio.cimadamore at oracle.com Mon May 25 17:04:57 2015 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Mon, 25 May 2015 18:04:57 +0100 Subject: [8u60] Request for approval 8055963: Inference failure with nested invocation Message-ID: <55635639.90600@oracle.com> Hello, This is a request for approval to backport a fix from the jdk9 to the jdk8u-dev repository. Changes applies cleanly to jdk8u-dev after path reshuffling. All relevanttests pass. Bug: https://bugs.openjdk.java.net/browse/JDK-8055963 jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c419bddef7f3 Cheers Maurizio From rob.mckenna at oracle.com Mon May 25 17:16:53 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 25 May 2015 18:16:53 +0100 Subject: [8u60] Request for approval 8055963: Inference failure with nested invocation In-Reply-To: <55635639.90600@oracle.com> References: <55635639.90600@oracle.com> Message-ID: <55635905.8040608@oracle.com> Approved -Rob On 25/05/15 18:04, Maurizio Cimadamore wrote: > Hello, > This is a request for approval to backport a fix from the jdk9 to the > jdk8u-dev repository. > Changes applies cleanly to jdk8u-dev after path reshuffling. All > relevanttests pass. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8055963 > jdk9 fix: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c419bddef7f3 > > Cheers > Maurizio From attila.szegedi at oracle.com Tue May 26 14:00:32 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 26 May 2015 16:00:32 +0200 Subject: [8u60] Request for Approval: 8081015: Allow conversion of native arrays to Queue and Collection Message-ID: <5A1C9C4E-15A1-417F-B6C7-5389FEE817B7@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8081015 jdk9 webrev: http://cr.openjdk.java.net/~attila/8081015/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004600.html Changes needed to be tailored to apply to jdk8u-dev (import section of NativeJava.java); separate reviews are provided: jdk8 webrev: http://cr.openjdk.java.net/~attila/8081015/webrev.8u-dev jdk8 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004604.html Thanks, Attila. From rob.mckenna at oracle.com Tue May 26 14:10:12 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 26 May 2015 15:10:12 +0100 Subject: [8u60] Request for Approval: 8081015: Allow conversion of native arrays to Queue and Collection In-Reply-To: <5A1C9C4E-15A1-417F-B6C7-5389FEE817B7@oracle.com> References: <5A1C9C4E-15A1-417F-B6C7-5389FEE817B7@oracle.com> Message-ID: <55647EC4.6040207@oracle.com> Approved. -Rob On 26/05/15 15:00, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8081015 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8081015/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004600.html > > Changes needed to be tailored to apply to jdk8u-dev (import section of NativeJava.java); separate reviews are provided: > > jdk8 webrev: http://cr.openjdk.java.net/~attila/8081015/webrev.8u-dev > jdk8 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004604.html > > Thanks, > Attila. > From attila.szegedi at oracle.com Tue May 26 15:27:33 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Tue, 26 May 2015 17:27:33 +0200 Subject: [8u60] Request for Approval: 8081062: ListAdapter should take advantage of JSObject Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8081062 jdk9 webrev: http://cr.openjdk.java.net/~attila/8081062/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004606.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Tue May 26 15:29:13 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 26 May 2015 16:29:13 +0100 Subject: [8u60] Request for Approval: 8081062: ListAdapter should take advantage of JSObject In-Reply-To: References: Message-ID: <55649149.6030002@oracle.com> Approved -Rob On 26/05/15 16:27, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8081062 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8081062/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004606.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. > From alejandro.murillo at oracle.com Tue May 26 17:16:14 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Tue, 26 May 2015 11:16:14 -0600 Subject: jdk8u60-b17: HotSpot Message-ID: <5564AA5E.6080100@oracle.com> hs25.60-b17 has been integrated into jdk8u60-b17. http://hg.openjdk.java.net/jdk8u/jdk8u/rev/ec24cc303a2c http://hg.openjdk.java.net/jdk8u/jdk8u/corba/rev/7ef66778231f http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/c26d09f1065c http://hg.openjdk.java.net/jdk8u/jdk8u/jaxp/rev/e882f38df713 http://hg.openjdk.java.net/jdk8u/jdk8u/jaxws/rev/d6a80a0a3e9a http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/c30db4c968f6 http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/rev/87dcdc1fd75b http://hg.openjdk.java.net/jdk8u/jdk8u/nashorn/rev/ff7052ce0f6b Component : VM Status : 0 major failures, 0 minor failure Date : 05/26/2015 at 18:00 MSK Tested By : STT_VM Cost(total man-days): 1 Workspace : 2015-05-22-055822.amurillo.hs25-60-b17-snapshot Bundles : 2015-05-22-055822.amurillo.hs25-60-b17-snapshot Platforms : Others Tests : Log : link Browsers : NA Patches : NA Number of Tests Executed : 440049 passed tests, 4388 failed tests (0 new failure) Bug verification status: ====================================== Tested, Pass: Tested, Pass (partial fixes): Tested, Fail: Untested bug fixes: 6536943: Bogus -Xcheck:jni warning for SIG_INT action for SIGINT in JVM started from non-interactive shell 8048179: Early reclaim of large objects that are referenced by a few objects 8061715: gc/g1/TestShrinkAuxiliaryData15.java fails with java.lang.RuntimeException: heap decommit failed - after > before 8069367: Eagerly reclaimed humongous objects left on mark stack 8075215: SATB buffer processing found reclaimed humongous object 8075466: SATB queue pre-filter verify found reclaimed humongous object 8076265: Simplify deal_with_reference 8078021: SATB apply_closure_to_completed_buffer should have closure argument 8078023: verify_no_cset_oops found reclaimed humongous object in SATB buffer 8079644: memory stomping error with ResourceManagement and TestAgentStress.java 8080190: PPC64: Fix wrong rotate instructions in the .ad file 8080458: new hotspot build - hs25.60-b17 New bugs filed: Bugs in PIT build: Bugs in earlier promoted build: Number of PIT requested: 1 Integration target J2SE build number: jdk8u60-b17 Issues and Notes: This is PIT for HS25.60-b17 for jdk8u60-b17. Go for integration. -- Alejandro From sundararajan.athijegannathan at oracle.com Wed May 27 09:35:14 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 May 2015 15:05:14 +0530 Subject: [8u60] approval request for 8007456: Nashorn test framework @argument does not handle quoted strings Message-ID: <55658FD2.3050108@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8007456 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004611.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8007456/8u60/webrev.00/ Thanks, -Sundar From sean.coffey at oracle.com Wed May 27 09:38:16 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 27 May 2015 10:38:16 +0100 Subject: [8u60] approval request for 8007456: Nashorn test framework @argument does not handle quoted strings In-Reply-To: <55658FD2.3050108@oracle.com> References: <55658FD2.3050108@oracle.com> Message-ID: <55659088.4070707@oracle.com> Approved. Regards, Sean. On 27/05/15 10:35, A. Sundararajan wrote: > Please approve. > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8007456 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004611.html > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8007456/8u60/webrev.00/ > > Thanks, > -Sundar From vadim.pakhnushev at oracle.com Wed May 27 12:06:06 2015 From: vadim.pakhnushev at oracle.com (Vadim Pakhnushev) Date: Wed, 27 May 2015 15:06:06 +0300 Subject: [8u60] Request for approval for 8079652: Could not enable D3D pipeline Message-ID: <5565B32E.3000302@oracle.com> Bug: https://bugs.openjdk.java.net/browse/JDK-8079652 JDK 9 Review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005374.html JDK 9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/f4d322ccd488 JDK 8u patch (identical except for the file path): diff -r 9ef0071d0e24 src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp --- a/src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp Tue May 26 13:42:41 2015 -0500 +++ b/src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp Wed May 27 15:03:38 2015 +0300 @@ -828,7 +828,7 @@ return 0; } - HWND hWnd = CreateWindow(L"D3DFocusWindow", L"D3DFocusWindow", 0, + HWND hWnd = CreateWindow(L"D3DFocusWindow", L"D3DFocusWindow", WS_POPUP, mi.rcMonitor.left, mi.rcMonitor.top, 1, 1, NULL, NULL, GetModuleHandle(NULL), NULL); if (hWnd == 0) { Thanks, Vadim From sean.coffey at oracle.com Wed May 27 12:07:32 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 27 May 2015 13:07:32 +0100 Subject: [8u60] Request for approval for 8079652: Could not enable D3D pipeline In-Reply-To: <5565B32E.3000302@oracle.com> References: <5565B32E.3000302@oracle.com> Message-ID: <5565B384.8020809@oracle.com> Approved. Regards, Sean. On 27/05/15 13:06, Vadim Pakhnushev wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8079652 > JDK 9 Review thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005374.html > JDK 9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/f4d322ccd488 > JDK 8u patch (identical except for the file path): > > diff -r 9ef0071d0e24 > src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp > --- a/src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp Tue May > 26 13:42:41 2015 -0500 > +++ b/src/windows/native/sun/java2d/d3d/D3DPipelineManager.cpp Wed May > 27 15:03:38 2015 +0300 > @@ -828,7 +828,7 @@ > return 0; > } > > - HWND hWnd = CreateWindow(L"D3DFocusWindow", L"D3DFocusWindow", 0, > + HWND hWnd = CreateWindow(L"D3DFocusWindow", L"D3DFocusWindow", > WS_POPUP, > mi.rcMonitor.left, mi.rcMonitor.top, 1, 1, > NULL, NULL, GetModuleHandle(NULL), NULL); > if (hWnd == 0) { > > > Thanks, > Vadim From attila.szegedi at oracle.com Wed May 27 12:51:40 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Wed, 27 May 2015 15:51:40 +0300 Subject: [8u60] Request for Approval: 8081204: ListAdapter throws NPE when adding/removing elements outside of JS context Message-ID: Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8081204 jdk9 webrev: http://cr.openjdk.java.net/~attila/8081204/webrev.00 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004615.html Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. Thanks, Attila. From rob.mckenna at oracle.com Wed May 27 12:57:38 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 27 May 2015 13:57:38 +0100 Subject: [8u60] Request for Approval: 8081204: ListAdapter throws NPE when adding/removing elements outside of JS context In-Reply-To: References: Message-ID: <5565BF42.20408@oracle.com> Approved. -Rob On 27/05/15 13:51, Attila Szegedi wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8081204 > jdk9 webrev: http://cr.openjdk.java.net/~attila/8081204/webrev.00 > jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004615.html > > Changes apply cleanly to jdk8u-dev after path reshuffling from modular source code layout. > > Thanks, > Attila. > From peter.brunet at oracle.com Wed May 27 15:35:43 2015 From: peter.brunet at oracle.com (Pete Brunet) Date: Wed, 27 May 2015 10:35:43 -0500 Subject: RfA JDK-8077296 RE build fails on non-Win builds when attempting to build Win only javadoc Message-ID: <5565E44F.2080405@oracle.com> I'd like to push the JDK-8077296 patch to 8u. https://bugs.openjdk.java.net/browse/JDK-8077296 http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009392.html Background: - As part of the open sourcing of the JAB and Java Accessibility Utilities (JAU) the JAU Javadoc was set up to be added to the build. - Due to an 8u RE build issue (it uses source bundles) the Javadoc had to be temporarily disabled: JDK-8076552 - The issue was caused by JAU code being in windows instead of share. - For 9 the JAU code is in jdk.accessibility/share/classes/com/sun/java/accessibility/util (and the JAB code under jdk.accessibility/windows). - For 8u both the JAU and JAB code is in jdk/src/windows. - The problem on 8u is with non-windows builds; the 8 Javadoc build process doesn't find the JAU files because they are in a windows directory. - The fix is to refactor so 8u is like 9 with the JAU files in share; then the javadoc build process will find the source for all build platforms. - Make has been changed so jaccess.jar is built for all platforms. - Some obsolete files have been removed as they were causing build problems. They were removed from 9 earlier but not from 8u. These are com/sun/java/accessibility/util/java/awt/ChoiceTranslator.java and all the files in com/sun/java/accessibility/extensions. I tested this by doing a source bundles build on Win, transferring the zips to Mac, unzipping the zips, and building from the unzipped files. That build was successful and the use of jaccess.jar was successful. Pete From sean.coffey at oracle.com Wed May 27 16:59:25 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Wed, 27 May 2015 17:59:25 +0100 Subject: RfA JDK-8077296 RE build fails on non-Win builds when attempting to build Win only javadoc In-Reply-To: <5565E44F.2080405@oracle.com> References: <5565E44F.2080405@oracle.com> Message-ID: <5565F7ED.4090205@oracle.com> Approved. Please add noreg-build label to the bug report. Regards, Sean. On 27/05/15 16:35, Pete Brunet wrote: > I'd like to push the JDK-8077296 patch to 8u. > > https://bugs.openjdk.java.net/browse/JDK-8077296 > http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009392.html > > Background: > - As part of the open sourcing of the JAB and Java Accessibility > Utilities (JAU) the JAU Javadoc was set up to be added to the build. > - Due to an 8u RE build issue (it uses source bundles) the Javadoc had > to be temporarily disabled: JDK-8076552 > - The issue was caused by JAU code being in windows instead of share. > - For 9 the JAU code is in > jdk.accessibility/share/classes/com/sun/java/accessibility/util (and the > JAB code under jdk.accessibility/windows). > - For 8u both the JAU and JAB code is in jdk/src/windows. > - The problem on 8u is with non-windows builds; the 8 Javadoc build > process doesn't find the JAU files because they are in a windows directory. > - The fix is to refactor so 8u is like 9 with the JAU files in share; > then the javadoc build process will find the source for all build platforms. > - Make has been changed so jaccess.jar is built for all platforms. > - Some obsolete files have been removed as they were causing build > problems. They were removed from 9 earlier but not from 8u. These are > com/sun/java/accessibility/util/java/awt/ChoiceTranslator.java and all > the files in com/sun/java/accessibility/extensions. > > I tested this by doing a source bundles build on Win, transferring the > zips to Mac, unzipping the zips, and building from the unzipped files. > That build was successful and the use of jaccess.jar was successful. > > Pete From sundararajan.athijegannathan at oracle.com Wed May 27 17:33:04 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Wed, 27 May 2015 23:03:04 +0530 Subject: [8u60] approval request for 8081156: jjs "nashorn.args" system property is not effective when script arguments are passed Message-ID: <5565FFD0.9010706@oracle.com> Please approve. Bug: https://bugs.openjdk.java.net/browse/JDK-8081156 jdk9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004619.html jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8081156/8u60/webrev.00/ Backported 'as is' except for modular source layout difference. Thanks, -Sundar From sean.coffey at oracle.com Wed May 27 17:36:22 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Wed, 27 May 2015 18:36:22 +0100 Subject: [8u60] approval request for 8081156: jjs "nashorn.args" system property is not effective when script arguments are passed In-Reply-To: <5565FFD0.9010706@oracle.com> References: <5565FFD0.9010706@oracle.com> Message-ID: <55660096.4000306@oracle.com> Approved. Regards, Sean. On 27/05/15 18:33, A. Sundararajan wrote: > Please approve. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8081156 > jdk9 review thread: > http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-May/004619.html > jdk8u-dev webrev: > http://cr.openjdk.java.net/~sundar/8081156/8u60/webrev.00/ > > Backported 'as is' except for modular source layout difference. > > Thanks, > -Sundar From Roger.Riggs at Oracle.com Wed May 27 20:54:15 2015 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Wed, 27 May 2015 16:54:15 -0400 Subject: [8u60] RFR: 8081022 : java/time/test/java/time/format/TestZoneTextPrinterParser.java fails by timeout on slow device Message-ID: <55662EF7.2040102@Oracle.com> Please review this test modification to reduce the running time and to apply the recommended randomness pattern. This is the same as the JDK 9 review except that it adds the RandomFactory to the jdk8 test library. (There is no existing changeset that contained only the RandomFactory to be backported) Webrev: http://cr.openjdk.java.net/~rriggs/webrev-random-8081022/ Issue: https://bugs.openjdk.java.net/browse/JDK-8081022 Thanks, Roger From naoto.sato at oracle.com Wed May 27 21:01:34 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Wed, 27 May 2015 14:01:34 -0700 Subject: [8u60] RFR: 8081022 : java/time/test/java/time/format/TestZoneTextPrinterParser.java fails by timeout on slow device In-Reply-To: <55662EF7.2040102@Oracle.com> References: <55662EF7.2040102@Oracle.com> Message-ID: <556630AE.20300@oracle.com> +1 as well. Naoto On 5/27/15 1:54 PM, Roger Riggs wrote: > Please review this test modification to reduce the running time > and to apply the recommended randomness pattern. > > This is the same as the JDK 9 review except that it adds the > RandomFactory to the jdk8 test library. > (There is no existing changeset that contained only the RandomFactory to > be backported) > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-random-8081022/ > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8081022 > > Thanks, Roger > > From sundararajan.athijegannathan at oracle.com Thu May 28 04:28:22 2015 From: sundararajan.athijegannathan at oracle.com (A. Sundararajan) Date: Thu, 28 May 2015 09:58:22 +0530 Subject: [8u60] approval request for 8081355: Test missed for the fix of JDK-8007456 backport to jdk8u-dev Message-ID: <55669966.8@oracle.com> Hi, I missed checking in a test while backporting a fix to jdk8u-dev. Bug: https://bugs.openjdk.java.net/browse/JDK-8081355 jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8081355/webrev.00/ This is to add test that was missed while backporting https://bugs.openjdk.java.net/browse/JDK-8007456 to jdk8u-dev. Backport commit message for reference: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/aa83c9841e3c CC'ing original reviewers for the record.. Thanks, -Sundar From sean.coffey at oracle.com Thu May 28 07:36:41 2015 From: sean.coffey at oracle.com (=?windows-1252?Q?Se=E1n_Coffey?=) Date: Thu, 28 May 2015 08:36:41 +0100 Subject: [8u60] approval request for 8081355: Test missed for the fix of JDK-8007456 backport to jdk8u-dev In-Reply-To: <55669966.8@oracle.com> References: <55669966.8@oracle.com> Message-ID: <5566C589.5020707@oracle.com> Please add a 9-na label to the bug report. Approved. Regards, Sean. On 28/05/2015 05:28, A. Sundararajan wrote: > Hi, > > I missed checking in a test while backporting a fix to jdk8u-dev. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8081355 > jdk8u-dev webrev: http://cr.openjdk.java.net/~sundar/8081355/webrev.00/ > > This is to add test that was missed while backporting > https://bugs.openjdk.java.net/browse/JDK-8007456 to jdk8u-dev. > > Backport commit message for reference: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/rev/aa83c9841e3c > > CC'ing original reviewers for the record.. > > Thanks, > -Sundar From alexey.ivanov at oracle.com Thu May 28 13:14:20 2015 From: alexey.ivanov at oracle.com (Alexey Ivanov) Date: Thu, 28 May 2015 16:14:20 +0300 Subject: [8u-dev] Request for approval: 8080628: No mnemonics on Open and Save buttons in JFileChooser Message-ID: <556714AC.6040005@oracle.com> Hello, Could you please approve the following backport of the fix to 8u-dev? JBS bug: https://bugs.openjdk.java.net/browse/JDK-8080628 Webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk8/webrev.00/ Review: http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004560.html The changeset for jdk8 differs from jdk9 in four files: basic_ja.properties, basic_ko.properties, basic_zh_CN.properties, basic_zh_TW.properties. JDK9 webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk9/webrev.02/ JDK9 review: http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004547.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/8c5418750241 Thank you, Alexey From sean.coffey at oracle.com Thu May 28 14:00:20 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 28 May 2015 15:00:20 +0100 Subject: [8u-dev] Request for approval: 8080628: No mnemonics on Open and Save buttons in JFileChooser In-Reply-To: <556714AC.6040005@oracle.com> References: <556714AC.6040005@oracle.com> Message-ID: <55671F74.2040307@oracle.com> Approved. Regards, Sean. On 28/05/2015 14:14, Alexey Ivanov wrote: > Hello, > > Could you please approve the following backport of the fix to 8u-dev? > > JBS bug: https://bugs.openjdk.java.net/browse/JDK-8080628 > Webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk8/webrev.00/ > Review: > http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004560.html > > The changeset for jdk8 differs from jdk9 in four files: > basic_ja.properties, basic_ko.properties, basic_zh_CN.properties, > basic_zh_TW.properties. > > JDK9 webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk9/webrev.02/ > JDK9 review: > http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004547.html > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/8c5418750241 > > Thank you, > Alexey From Roger.Riggs at Oracle.com Thu May 28 17:54:12 2015 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Thu, 28 May 2015 13:54:12 -0400 Subject: [8u60] Request for approval for 8066808 langtools/test/Makefile should not use OS-specific jtreg binary Message-ID: <55675644.1030101@Oracle.com> Please approve the backport of the change to invoke jtreg without the platform. It was made to 9 and has been backported to 7 but not 8. Changeset: http://hg.openjdk.java.net/jdk9/jdk9/langtools/raw-rev/2b47c42974ff Original Issue: https://bugs.openjdk.java.net/browse/JDK-8066808 Thanks, Roger From sean.coffey at oracle.com Thu May 28 18:09:56 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 28 May 2015 19:09:56 +0100 Subject: [8u60] Request for approval for 8066808 langtools/test/Makefile should not use OS-specific jtreg binary In-Reply-To: <55675644.1030101@Oracle.com> References: <55675644.1030101@Oracle.com> Message-ID: <556759F4.5090403@oracle.com> Approved. Regards, Sean. On 28/05/2015 18:54, Roger Riggs wrote: > Please approve the backport of the change to invoke jtreg without the > platform. > It was made to 9 and has been backported to 7 but not 8. > > Changeset: > http://hg.openjdk.java.net/jdk9/jdk9/langtools/raw-rev/2b47c42974ff > > Original Issue: > https://bugs.openjdk.java.net/browse/JDK-8066808 > > Thanks, Roger > From anton.nashatyrev at oracle.com Thu May 28 18:21:42 2015 From: anton.nashatyrev at oracle.com (Anton Nashatyrev) Date: Thu, 28 May 2015 21:21:42 +0300 Subject: [8u-dev] Backport request: 8041470: JButtons stay pressed after they have lost focus if you use the mouse wheel Message-ID: <55675CB6.1020006@oracle.com> Hello, please approve the fix backport from jdk9 to jdk8u-dev. The patch was applied with minor changes Bug: https://bugs.openjdk.java.net/browse/JDK-8041470 Jdk9 Webrev: http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.02/ Jdk9 Changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/98c829f6a157 Jdk9 Review Thread: http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009434.html Thanks! Anton. From sean.coffey at oracle.com Thu May 28 18:23:58 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Thu, 28 May 2015 19:23:58 +0100 Subject: [8u-dev] Backport request: 8041470: JButtons stay pressed after they have lost focus if you use the mouse wheel In-Reply-To: <55675CB6.1020006@oracle.com> References: <55675CB6.1020006@oracle.com> Message-ID: <55675D3E.7050902@oracle.com> Approved. Regards, Sean. On 28/05/2015 19:21, Anton Nashatyrev wrote: > Hello, > > please approve the fix backport from jdk9 to jdk8u-dev. The patch > was applied with minor changes > > Bug: https://bugs.openjdk.java.net/browse/JDK-8041470 > Jdk9 Webrev: http://cr.openjdk.java.net/%7Eanashaty/8041470/webrev.02/ > Jdk9 Changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/98c829f6a157 > Jdk9 Review Thread: > http://mail.openjdk.java.net/pipermail/awt-dev/2015-May/009434.html > > Thanks! > Anton. From aleksej.efimov at oracle.com Fri May 29 11:15:03 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Fri, 29 May 2015 14:15:03 +0300 Subject: [8u-dev] Request for approval: 8081392: getNodeValue should return NULL value for Element nodes Message-ID: <55684A37.6070302@oracle.com> Hi, Can I ask for approval of the JDK-8081392 [1] bug fix [2] to JDK8. The source fix applies cleanly after reshuffling. 8062518/DocumentExtFunc.java test fix applies cleanly after test reshuffling (test in a JDK repo, not in JAXP). Other test fixes applies cleanly. JPRT and JTREG testing shows no related failures. With Best Regards, Aleksej JDK9 changesets: http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/b5b21a17c24e http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c05d8801ca4d JDK9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033779.html [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8081392 [2] JDK8 Webrev: http://cr.openjdk.java.net/~aefimov/8081392/8 From sean.coffey at oracle.com Fri May 29 12:00:03 2015 From: sean.coffey at oracle.com (=?UTF-8?B?U2XDoW4gQ29mZmV5?=) Date: Fri, 29 May 2015 13:00:03 +0100 Subject: [8u-dev] Request for approval: 8081392: getNodeValue should return NULL value for Element nodes In-Reply-To: <55684A37.6070302@oracle.com> References: <55684A37.6070302@oracle.com> Message-ID: <556854C3.1010003@oracle.com> Approved. Regards, Sean. On 29/05/15 12:15, Aleksej Efimov wrote: > Hi, > > Can I ask for approval of the JDK-8081392 [1] bug fix [2] to JDK8. The > source fix applies cleanly after reshuffling. > 8062518/DocumentExtFunc.java test fix applies cleanly after test > reshuffling (test in a JDK repo, not in JAXP). Other test fixes > applies cleanly. JPRT and JTREG testing shows no related failures. > > With Best Regards, > Aleksej > > JDK9 changesets: > http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/b5b21a17c24e > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c05d8801ca4d > > JDK9 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033779.html > > [1] JBS: https://bugs.openjdk.java.net/browse/JDK-8081392 > [2] JDK8 Webrev: http://cr.openjdk.java.net/~aefimov/8081392/8 > From maxim.soloviev at oracle.com Fri May 29 11:34:59 2015 From: maxim.soloviev at oracle.com (Maxim Soloviev) Date: Fri, 29 May 2015 14:34:59 +0300 Subject: [8u-dev] Review request : JDK-8081479: Backport JDBC tests from JDK 9 from test/java/sql and test/javax/sql to JDK 8u. Message-ID: <55684EE3.3040304@oracle.com> Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8081479 Webrev is http://cr.openjdk.java.net/~kshefov/8081479/webrev.00/ It's a backport of JDK9 JDBC tests to JDK8u. Thanks Maxim From Roger.Riggs at Oracle.com Fri May 29 13:42:42 2015 From: Roger.Riggs at Oracle.com (Roger Riggs) Date: Fri, 29 May 2015 09:42:42 -0400 Subject: [8u60] Request for approval for multiple CRs CR 8034906 - Fix typos, errors and Javadoc differences in java.time Message-ID: <55686CD2.8090503@Oracle.com> Please approve doc-only updates backported from JDK 9 in the java.time package. They are applied essentially unchanged after unshuffling. 1) 8034906: Fix typos, errors and Javadoc differences in java.time Reviewed-by: psandoz changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f3905a67a72c 2) 8068284: Missing @throws in DateTimeFormatterBuilder.appendOffset 8068285: Missing @throws in DateTimeFormatterBuilder.appendInstant 8062803: 'principal' should be 'principle' in java.time package description 8062796: java.time.format.DateTimeFormatter error in API doc example Reviewed-by: lancea, mchung changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/bd4d6a62e1fd 3) 8075678: java.time javadoc error in DateTimeFormatter::parsedLeapSecond 8075676: java.time package javadoc typos 8068276: java.time.chrono.HijrahChronology.eraOf() assertions may lead to misunderstanding Reviewed-by: lancea, scolebourne changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/83e0f851c7b8 Thanks, Roger From rob.mckenna at oracle.com Fri May 29 13:53:11 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 29 May 2015 14:53:11 +0100 Subject: [8u60] Request for approval for multiple CRs CR 8034906 - Fix typos, errors and Javadoc differences in java.time In-Reply-To: <55686CD2.8090503@Oracle.com> References: <55686CD2.8090503@Oracle.com> Message-ID: <55686F47.4050905@oracle.com> Approved. One or two are missing noreg keywords, please add them where applicable. -Rob On 29/05/15 14:42, Roger Riggs wrote: > Please approve doc-only updates backported from JDK 9 in the java.time > package. > They are applied essentially unchanged after unshuffling. > > 1) > 8034906: Fix typos, errors and Javadoc differences in java.time > Reviewed-by: psandoz > changeset: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f3905a67a72c > > 2) > 8068284: Missing @throws in DateTimeFormatterBuilder.appendOffset > 8068285: Missing @throws in DateTimeFormatterBuilder.appendInstant > 8062803: 'principal' should be 'principle' in java.time package description > 8062796: java.time.format.DateTimeFormatter error in API doc example > Reviewed-by: lancea, mchung > changeset: > http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/bd4d6a62e1fd > > 3) > 8075678: java.time javadoc error in DateTimeFormatter::parsedLeapSecond > 8075676: java.time package javadoc typos > 8068276: java.time.chrono.HijrahChronology.eraOf() assertions may lead > to misunderstanding > Reviewed-by: lancea, scolebourne > changeset: > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/83e0f851c7b8 > > Thanks, Roger > > > > > > > From lance.andersen at oracle.com Fri May 29 13:54:27 2015 From: lance.andersen at oracle.com (Lance Andersen) Date: Fri, 29 May 2015 09:54:27 -0400 Subject: [8u-dev] Review request : JDK-8081479: Backport JDBC tests from JDK 9 from test/java/sql and test/javax/sql to JDK 8u. In-Reply-To: <55684EE3.3040304@oracle.com> References: <55684EE3.3040304@oracle.com> Message-ID: Hi Maxim, this looks fine Best Lance On May 29, 2015, at 7:34 AM, Maxim Soloviev wrote: > Hello, > > Please review the test bug fix > https://bugs.openjdk.java.net/browse/JDK-8081479 > Webrev is http://cr.openjdk.java.net/~kshefov/8081479/webrev.00/ > It's a backport of JDK9 JDBC tests to JDK8u. > > Thanks > Maxim Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From rob.mckenna at oracle.com Fri May 29 13:55:11 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 29 May 2015 14:55:11 +0100 Subject: [8u60] Request for approval for multiple CRs CR 8034906 - Fix typos, errors and Javadoc differences in java.time In-Reply-To: <55686F47.4050905@oracle.com> References: <55686CD2.8090503@Oracle.com> <55686F47.4050905@oracle.com> Message-ID: <55686FBF.2000606@oracle.com> Hi Roger, I'm revoking this approval. I believe further discussion is necessary. -Rob On 29/05/15 14:53, Rob McKenna wrote: > Approved. > > One or two are missing noreg keywords, please add them where applicable. > > -Rob > > On 29/05/15 14:42, Roger Riggs wrote: >> Please approve doc-only updates backported from JDK 9 in the java.time >> package. >> They are applied essentially unchanged after unshuffling. >> >> 1) >> 8034906: Fix typos, errors and Javadoc differences in java.time >> Reviewed-by: psandoz >> changeset: >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f3905a67a72c >> >> 2) >> 8068284: Missing @throws in DateTimeFormatterBuilder.appendOffset >> 8068285: Missing @throws in DateTimeFormatterBuilder.appendInstant >> 8062803: 'principal' should be 'principle' in java.time package >> description >> 8062796: java.time.format.DateTimeFormatter error in API doc example >> Reviewed-by: lancea, mchung >> changeset: >> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/bd4d6a62e1fd >> >> 3) >> 8075678: java.time javadoc error in DateTimeFormatter::parsedLeapSecond >> 8075676: java.time package javadoc typos >> 8068276: java.time.chrono.HijrahChronology.eraOf() assertions may lead >> to misunderstanding >> Reviewed-by: lancea, scolebourne >> changeset: >> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/83e0f851c7b8 >> >> Thanks, Roger >> >> >> >> >> >> >> From konstantin.shefov at oracle.com Fri May 29 14:17:40 2015 From: konstantin.shefov at oracle.com (Konstantin Shefov) Date: Fri, 29 May 2015 17:17:40 +0300 Subject: [8u-60] Request for approval for JDK-8081479: Backport JDBC tests from JDK 9 from test/java/sql and test/javax/sql to JDK 8u. Message-ID: <55687504.6010405@oracle.com> Hello, Please approve the test fix to 8u60. BugID: https://bugs.openjdk.java.net/browse/JDK-8081479 Webrev is http://cr.openjdk.java.net/~kshefov/8081479/webrev.00/ Fix has already been reviewed by Lance.Andersen at oracle.com (see below) Thanks -Konstantin ================================================================= Hi Maxim, this looks fine Best Lance On May 29, 2015, at 7:34 AM, Maxim Soloviev > wrote: > Hello, > > Please review the test bug fix > https://bugs.openjdk.java.net/browse/JDK-8081479 > Webrev is http://cr.openjdk.java.net/~kshefov/8081479/webrev.00/ > It's a backport of JDK9 JDBC tests to JDK8u. > > Thanks > Maxim Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen at oracle.com From rob.mckenna at oracle.com Fri May 29 14:18:59 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 29 May 2015 15:18:59 +0100 Subject: [8u-60] Request for approval for JDK-8081479: Backport JDBC tests from JDK 9 from test/java/sql and test/javax/sql to JDK 8u. In-Reply-To: <55687504.6010405@oracle.com> References: <55687504.6010405@oracle.com> Message-ID: <55687553.60009@oracle.com> Approved. -Rob On 29/05/15 15:17, Konstantin Shefov wrote: > Hello, > > Please approve the test fix to 8u60. > BugID: https://bugs.openjdk.java.net/browse/JDK-8081479 > Webrev is http://cr.openjdk.java.net/~kshefov/8081479/webrev.00/ > > Fix has already been reviewed by Lance.Andersen at oracle.com (see below) > > Thanks > -Konstantin > > ================================================================= > > Hi Maxim, > > this looks fine > > Best > Lance > On May 29, 2015, at 7:34 AM, Maxim Soloviev > wrote: > >> Hello, >> >> Please review the test bug fix >> https://bugs.openjdk.java.net/browse/JDK-8081479 >> Webrev is http://cr.openjdk.java.net/~kshefov/8081479/webrev.00/ >> It's a backport of JDK9 JDBC tests to JDK8u. >> >> Thanks >> Maxim > > > > Lance Andersen| > Principal Member of Technical Staff | +1.781.442.2037 > Oracle Java Engineering > 1 Network Drive > Burlington, MA 01803 > Lance.Andersen at oracle.com > > From alejandro.murillo at oracle.com Fri May 29 17:16:59 2015 From: alejandro.murillo at oracle.com (Alejandro E Murillo) Date: Fri, 29 May 2015 11:16:59 -0600 Subject: [8u60] Request for approval for bulk integration of hs25.60-b18 Message-ID: <55689F0B.8000101@oracle.com> Requesting approval to integrate hs25.60-b18 into jdk8u60-b18. A webrev is available at: http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b18-jdk8u60-b18.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in the proposed integration are below. All have undergone nightly testing and are already in a jdk9 repository. 8031686: G1: assert(_hrs.max_length() == _expansion_regions) failed 8046668: Excessive checked JNI warnings from Java startup 8060036: C2: CmpU nodes can end up with wrong type information 8077620: [TESTBUG] Some of the hotspot tests require at least compact profile 3 8080156: Integer.toString(int value) sometimes throws NPE 8080804: new hotspot build - hs25.60-b18 -- Alejandro From rob.mckenna at oracle.com Fri May 29 19:37:13 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Fri, 29 May 2015 20:37:13 +0100 Subject: [8u60] Request for approval for bulk integration of hs25.60-b18 In-Reply-To: <55689F0B.8000101@oracle.com> References: <55689F0B.8000101@oracle.com> Message-ID: <5568BFE9.6050709@oracle.com> Approved pending positive PIT. -Rob On 29/05/15 18:16, Alejandro E Murillo wrote: > Requesting approval to integrate hs25.60-b18 into jdk8u60-b18. > > A webrev is available at: > > http://cr.openjdk.java.net/~amurillo/8u60/hs25.60-b18-jdk8u60-b18.webrev/ > > Pre-integration testing is in progress; the integration will proceed > only after SQE has analyzed the results and approved. > > The fixes in the proposed integration are below. All have undergone > nightly testing and are already in a jdk9 repository. > > 8031686: G1: assert(_hrs.max_length() == _expansion_regions) failed > 8046668: Excessive checked JNI warnings from Java startup > 8060036: C2: CmpU nodes can end up with wrong type information > 8077620: [TESTBUG] Some of the hotspot tests require at least compact > profile 3 > 8080156: Integer.toString(int value) sometimes throws NPE > 8080804: new hotspot build - hs25.60-b18 > From ivan.gerasimov at oracle.com Sat May 30 14:32:00 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Sat, 30 May 2015 17:32:00 +0300 Subject: [8u-dev] Request for approval to backport: 7011441: jndi/ldap/Connection.java needs to avoid spurious wakeup Message-ID: <5569C9E0.1060100@oracle.com> Hello! Would you please approve backporting this fix, which makes waiting more accurate? Unshuffled patch applies cleanly. Bug: https://bugs.openjdk.java.net/browse/JDK-7011441 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/13bc4d9ce7f3 Jdk9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033660.html Sincerely yours, Ivan From rob.mckenna at oracle.com Sat May 30 22:59:19 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Sat, 30 May 2015 23:59:19 +0100 Subject: [8u-dev] Request for approval to backport: 7011441: jndi/ldap/Connection.java needs to avoid spurious wakeup In-Reply-To: <5569C9E0.1060100@oracle.com> References: <5569C9E0.1060100@oracle.com> Message-ID: <556A40C7.7060902@oracle.com> Approved. -Rob On 30/05/15 15:32, Ivan Gerasimov wrote: > Hello! > > Would you please approve backporting this fix, which makes waiting more > accurate? > Unshuffled patch applies cleanly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-7011441 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/13bc4d9ce7f3 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-May/033660.html > > Sincerely yours, > Ivan