[8u60] Request for approval for multiple CRs CR 8034906 - Fix typos, errors and Javadoc differences in java.time

Rob McKenna rob.mckenna at oracle.com
Fri May 29 13:55:11 UTC 2015


Hi Roger, I'm revoking this approval. I believe further discussion is 
necessary.

	-Rob

On 29/05/15 14:53, Rob McKenna wrote:
> Approved.
>
> One or two are missing noreg keywords, please add them where applicable.
>
>      -Rob
>
> On 29/05/15 14:42, Roger Riggs wrote:
>> Please approve doc-only updates backported from JDK 9 in the java.time
>> package.
>> They are applied essentially unchanged after unshuffling.
>>
>> 1)
>> 8034906: Fix typos, errors and Javadoc differences in java.time
>> Reviewed-by: psandoz
>> changeset:
>>     http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f3905a67a72c
>>
>> 2)
>> 8068284: Missing @throws in DateTimeFormatterBuilder.appendOffset
>> 8068285: Missing @throws in DateTimeFormatterBuilder.appendInstant
>> 8062803: 'principal' should be 'principle' in java.time package
>> description
>> 8062796: java.time.format.DateTimeFormatter error in API doc example
>> Reviewed-by: lancea, mchung
>> changeset:
>>      http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/bd4d6a62e1fd
>>
>> 3)
>> 8075678: java.time javadoc error in DateTimeFormatter::parsedLeapSecond
>> 8075676: java.time package javadoc typos
>> 8068276: java.time.chrono.HijrahChronology.eraOf() assertions may lead
>> to misunderstanding
>> Reviewed-by: lancea, scolebourne
>> changeset:
>>      http://hg.openjdk.java.net/jdk9/dev/jdk/rev/83e0f851c7b8
>>
>> Thanks, Roger
>>
>>
>>
>>
>>
>>
>>


More information about the jdk8u-dev mailing list