From aleksej.efimov at oracle.com Sun Nov 1 15:44:41 2015 From: aleksej.efimov at oracle.com (Aleksej Efimov) Date: Sun, 1 Nov 2015 18:44:41 +0300 Subject: [8u72] Backport of JDK-8058175: XML - Attribute values with supplemental characters are being corrupted In-Reply-To: References: Message-ID: <56363369.6080701@oracle.com> Hi Vincent, I'll do the backport to 8u-dev. About getting it into 8u72 - we're currently in RDP2 [1] for 8u72 and I'm not sure that it will be approved for 8u72 inclusion, but will try it. Best Regards. Aleksej [1] http://openjdk.java.net/projects/jdk8u/phase2/phase2-process.html On 10/31/2015 05:14 PM, Vincent Privat wrote: > Hi, > > Could we please get JDK-8058175 backported to 8u72? > > There is no known workaround and it's a major problem for JOSM, see > JDK-8141097. > By the way, is it possible to add label "josm-found" to JDK-8141097 and > resolve it as a duplicate of JDK-8058175? We have verified that our > original problem is solved in JDK9 thanks to this correction. > > The fix appears to be quite simple, see > http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/705a3999eb77 > > Best regards, > Vincent From michael.haupt at oracle.com Mon Nov 2 08:12:46 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Mon, 2 Nov 2015 09:12:46 +0100 Subject: [8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev Message-ID: (Apologies for multiple posts with wrong subject lines.) > Dear all, > > cross-posted to jdk8u-dev and core-libs-dev. > > Please review this change. > Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 > Webrev: http://cr.openjdk.java.net/~mhaupt/8139863/webrev.00 > > This adds a missing test to 8u-dev that was not pushed along with the feature backport it belongs to. The backport was approved; see http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-September/004185.html . > > Thanks, > > Michael From cheleswer.sahu at oracle.com Mon Nov 2 12:31:19 2015 From: cheleswer.sahu at oracle.com (cheleswer sahu) Date: Mon, 2 Nov 2015 18:01:19 +0530 Subject: [8u76] request for approval: 8122944: perfdata used is seen as too high on sparc zone with jdk1.9 and causes a test failure Message-ID: <56375797.8030207@oracle.com> Hi! May I please have approval to backport this fix from JDK9 to JDK8. I have built the JDK-8, it shows no error. JDK9 fix applies cleanly to JDK8. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8122944 JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f160dec9a350 Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-July/017718.html Regards, Cheleswer From rob.mckenna at oracle.com Mon Nov 2 13:10:49 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 2 Nov 2015 13:10:49 +0000 Subject: [8u76] request for approval: 8122944: perfdata used is seen as too high on sparc zone with jdk1.9 and causes a test failure In-Reply-To: <56375797.8030207@oracle.com> References: <56375797.8030207@oracle.com> Message-ID: <563760D9.8050306@oracle.com> Approved -Rob On 02/11/15 12:31, cheleswer sahu wrote: > Hi! > > May I please have approval to backport this fix from JDK9 to JDK8. I > have built the JDK-8, it shows no error. JDK9 fix applies cleanly to JDK8. > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8122944 > > JDK9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/f160dec9a350 > > Review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-July/017718.html > > > Regards, > Cheleswer > From michael.haupt at oracle.com Wed Nov 4 08:39:16 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Wed, 4 Nov 2015 09:39:16 +0100 Subject: [8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev In-Reply-To: References: Message-ID: <52A380C7-D34D-4C35-82C1-0C0A78E1F5EC@oracle.com> All, the code in question has been reviewed already: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-February/031871.html Best, Michael > Am 02.11.2015 um 09:12 schrieb Michael Haupt : > > (Apologies for multiple posts with wrong subject lines.) > >> Dear all, >> >> cross-posted to jdk8u-dev and core-libs-dev. >> >> Please review this change. >> Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8139863/webrev.00 >> >> This adds a missing test to 8u-dev that was not pushed along with the feature backport it belongs to. The backport was approved; see http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-September/004185.html . >> >> Thanks, >> >> Michael -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany Oracle is committed to developing practices and products that help protect the environment From cheleswer.sahu at oracle.com Wed Nov 4 10:08:45 2015 From: cheleswer.sahu at oracle.com (cheleswer sahu) Date: Wed, 4 Nov 2015 15:38:45 +0530 Subject: [8u76] Request for approval: 8129348: Debugger hangs in trace mode with TRACE_SENDS Message-ID: <5639D92D.6060005@oracle.com> Hi! May I please have approval to backport this fix from JDK9 to JDK8. I have built the JDK8, and tested already. JDK9 fix applies cleanly to JDK8 after path reshuffling. As I do not have account for OPENJDK, Kevin walls will push this fix into JDK8u repository. BUGURL: https://bugs.openjdk.java.net/browse/JDK-8129348 JDK9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/2ec082c65880 Review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-October/018075.html Regards, Cheleswer From andreas.eriksson at oracle.com Wed Nov 4 12:12:20 2015 From: andreas.eriksson at oracle.com (Andreas Eriksson) Date: Wed, 4 Nov 2015 13:12:20 +0100 Subject: [8u-dev] Request for approval for CR JDK-8074696 - Remote debugging session hangs for several minutes when calling findBootType Message-ID: <5639F624.8030700@oracle.com> Hi, I'd like approval for a JDK 8 backport of JDK-8074696 : Remote debugging session hangs for several minutes when calling findBootType. The changeset from JDK 9 applies cleanly after running it through unshuffle_patch.sh. JDK 9 Changeset: http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/0701fcfde528 JDK 9 review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-October/018069.html Regards, Andreas From sean.coffey at oracle.com Wed Nov 4 14:19:02 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 4 Nov 2015 14:19:02 +0000 Subject: [8u76] Request for approval: 8129348: Debugger hangs in trace mode with TRACE_SENDS In-Reply-To: <5639D92D.6060005@oracle.com> References: <5639D92D.6060005@oracle.com> Message-ID: <563A13D6.50309@oracle.com> Please add a suitable noreg-label to the master bug report. Approved for jdk8u-dev. Regards, Sean. On 04/11/2015 10:08, cheleswer sahu wrote: > Hi! > May I please have approval to backport this fix from JDK9 to JDK8. I > have built the JDK8, and tested already. JDK9 fix applies cleanly to > JDK8 after path reshuffling. As I do not have account for OPENJDK, > Kevin walls will push this fix into JDK8u repository. > > BUGURL: https://bugs.openjdk.java.net/browse/JDK-8129348 > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/2ec082c65880 > Review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-October/018075.html > > Regards, > Cheleswer From sean.coffey at oracle.com Wed Nov 4 14:19:37 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 4 Nov 2015 14:19:37 +0000 Subject: [8u-dev] Request for approval for CR JDK-8074696 - Remote debugging session hangs for several minutes when calling findBootType In-Reply-To: <5639F624.8030700@oracle.com> References: <5639F624.8030700@oracle.com> Message-ID: <563A13F9.6000809@oracle.com> Approved. Regards, Sean. On 04/11/2015 12:12, Andreas Eriksson wrote: > Hi, > > I'd like approval for a JDK 8 backport of JDK-8074696 > : Remote debugging > session hangs for several minutes when calling findBootType. > The changeset from JDK 9 applies cleanly after running it through > unshuffle_patch.sh. > > JDK 9 Changeset: > http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/0701fcfde528 > JDK 9 review thread: > http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-October/018069.html > > Regards, > Andreas From rob.mckenna at oracle.com Wed Nov 4 15:09:31 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 4 Nov 2015 15:09:31 +0000 Subject: [8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev In-Reply-To: <52A380C7-D34D-4C35-82C1-0C0A78E1F5EC@oracle.com> References: <52A380C7-D34D-4C35-82C1-0C0A78E1F5EC@oracle.com> Message-ID: <563A1FAB.1090805@oracle.com> Sorry for the delay Michael, I had understood the subject to mean you were waiting on another explicit review. Approved. -Rob On 04/11/15 08:39, Michael Haupt wrote: > All, > > the code in question has been reviewed already: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-February/031871.html > > Best, > > Michael > >> Am 02.11.2015 um 09:12 schrieb Michael Haupt : >> >> (Apologies for multiple posts with wrong subject lines.) >> >>> Dear all, >>> >>> cross-posted to jdk8u-dev and core-libs-dev. >>> >>> Please review this change. >>> Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 >>> Webrev: http://cr.openjdk.java.net/~mhaupt/8139863/webrev.00 >>> >>> This adds a missing test to 8u-dev that was not pushed along with the feature backport it belongs to. The backport was approved; see http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-September/004185.html . >>> >>> Thanks, >>> >>> Michael > From michael.haupt at oracle.com Wed Nov 4 16:06:18 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Wed, 4 Nov 2015 17:06:18 +0100 Subject: [8u-dev] Request for review and approval: 8139863: [TESTBUG] Need to port tests for JDK-8134903 to 8u-dev In-Reply-To: <563A1FAB.1090805@oracle.com> References: <52A380C7-D34D-4C35-82C1-0C0A78E1F5EC@oracle.com> <563A1FAB.1090805@oracle.com> Message-ID: <28BFF972-9735-410F-A129-44AEB3C8544F@oracle.com> Hi Rob, my bad. Thanks a lot! Michael > Am 04.11.2015 um 16:09 schrieb Rob McKenna : > > Sorry for the delay Michael, I had understood the subject to mean you were waiting on another explicit review. > > Approved. > > -Rob > > On 04/11/15 08:39, Michael Haupt wrote: >> All, >> >> the code in question has been reviewed already: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-February/031871.html >> >> Best, >> >> Michael >> >>> Am 02.11.2015 um 09:12 schrieb Michael Haupt : >>> >>> (Apologies for multiple posts with wrong subject lines.) >>> >>>> Dear all, >>>> >>>> cross-posted to jdk8u-dev and core-libs-dev. >>>> >>>> Please review this change. >>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8139863 >>>> Webrev: http://cr.openjdk.java.net/~mhaupt/8139863/webrev.00 >>>> >>>> This adds a missing test to 8u-dev that was not pushed along with the feature backport it belongs to. The backport was approved; see http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-September/004185.html . >>>> >>>> Thanks, >>>> >>>> Michael >> -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany Oracle is committed to developing practices and products that help protect the environment From vladimir.x.ivanov at oracle.com Thu Nov 5 09:13:13 2015 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 5 Nov 2015 12:13:13 +0300 Subject: CFV: New JDK8u Committer: Michael Haupt Message-ID: <563B1DA9.90305@oracle.com> I hereby nominate Michael Haupt to jdk8u Committer. Michael has made many contributions in several areas of the JDK [1] Michael is part of the Nashorn team; his focus is on dynamic language implementations. He also collaborates with the Valhalla project for value types. Prior to joining Nashorn, Michael worked briefly in the HotSpot compiler team. He has been an Oracle employee since 2011, which is when he joined the Virtual Machine Research Group at Oracle Labs, where he has worked on the Maxine meta-circular JVM and on dynamic language implementations. He used to be the tech lead of the FastR project, a high-performance Java-based implementation of the R programming language. Michael has also contributed to the LambdaForm-based java.lang.invoke infrastructure in the past. He is JDK9 Committer [2]. Votes are due by Nov, 19, 2015 Only current JDK8u Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Lazy Consensus voting instructions, see [4]. Best regards, Vladimir Ivanov [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 [2] http://openjdk.java.net/census#mhaupt [3] http://openjdk.java.net/census#jdk8u [4] http://openjdk.java.net/projects#committer-vote From vladimir.x.ivanov at oracle.com Thu Nov 5 09:13:40 2015 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 5 Nov 2015 12:13:40 +0300 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B1DC4.90202@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 11/5/15 12:13 PM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, which > is when he joined the Virtual Machine Research Group at Oracle Labs, > where he has worked on the Maxine meta-circular JVM and on dynamic > language implementations. He used to be the tech lead of the FastR > project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From sundararajan.athijegannathan at oracle.com Thu Nov 5 09:28:44 2015 From: sundararajan.athijegannathan at oracle.com (Sundararajan Athijegannathan) Date: Thu, 5 Nov 2015 14:58:44 +0530 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B214C.5080006@oracle.com> Vote: yes -Sundar On 11/5/2015 2:43 PM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From paul.sandoz at oracle.com Thu Nov 5 09:38:46 2015 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Thu, 5 Nov 2015 10:38:46 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <14D926E8-90FB-4FA3-B20B-C4547946DCCC@oracle.com> Vote: yes Paul. From attila.szegedi at oracle.com Thu Nov 5 09:49:37 2015 From: attila.szegedi at oracle.com (Attila Szegedi) Date: Thu, 5 Nov 2015 10:49:37 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DC4.90202@oracle.com> References: <563B1DA9.90305@oracle.com> <563B1DC4.90202@oracle.com> Message-ID: <3ECD740C-B5A3-424F-ABAA-407B60D816C2@oracle.com> Vote: yes Attila. > On Nov 5, 2015, at 10:13 AM, Vladimir Ivanov wrote: > > Vote: yes > > Best regards, > Vladimir Ivanov > > On 11/5/15 12:13 PM, Vladimir Ivanov wrote: >> I hereby nominate Michael Haupt to jdk8u Committer. >> >> Michael has made many contributions in several areas of the JDK [1] >> >> Michael is part of the Nashorn team; his focus is on dynamic language >> implementations. He also collaborates with the Valhalla project for >> value types. Prior to joining Nashorn, Michael worked briefly in the >> HotSpot compiler team. He has been an Oracle employee since 2011, which >> is when he joined the Virtual Machine Research Group at Oracle Labs, >> where he has worked on the Maxine meta-circular JVM and on dynamic >> language implementations. He used to be the tech lead of the FastR >> project, a high-performance Java-based implementation of the R >> programming language. Michael has also contributed to the >> LambdaForm-based java.lang.invoke infrastructure in the past. >> >> He is JDK9 Committer [2]. >> >> Votes are due by Nov, 19, 2015 >> >> Only current JDK8u Committers [3] are eligible to vote on this >> nomination. Votes must be cast in the open by replying to this mailing >> list. >> >> For Lazy Consensus voting instructions, see [4]. >> >> Best regards, >> Vladimir Ivanov >> >> [1] >> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 >> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c >> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 >> [2] http://openjdk.java.net/census#mhaupt >> [3] http://openjdk.java.net/census#jdk8u >> [4] http://openjdk.java.net/projects#committer-vote From frederic.parain at oracle.com Thu Nov 5 10:09:08 2015 From: frederic.parain at oracle.com (Frederic Parain) Date: Thu, 5 Nov 2015 11:09:08 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B2AC4.5020001@oracle.com> Vote: yes Fred On 11/05/2015 10:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote -- Frederic Parain - Oracle Grenoble Engineering Center - France Phone: +33 4 76 18 81 17 Email: Frederic.Parain at oracle.com From serguei.spitsyn at oracle.com Thu Nov 5 10:34:08 2015 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 5 Nov 2015 02:34:08 -0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B30A0.60408@oracle.com> Vote: yes On 11/5/15 01:13, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From vladimir.kozlov at oracle.com Thu Nov 5 12:07:41 2015 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 5 Nov 2015 20:07:41 +0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B468D.2060703@oracle.com> Vote: yes On 11/5/15 5:13 PM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, which > is when he joined the Virtual Machine Research Group at Oracle Labs, > where he has worked on the Maxine meta-circular JVM and on dynamic > language implementations. He used to be the tech lead of the FastR > project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From volker.simonis at gmail.com Thu Nov 5 13:10:08 2015 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 5 Nov 2015 14:10:08 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: Vote: yes Regards, Volker On Thu, Nov 5, 2015 at 10:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for value > types. Prior to joining Nashorn, Michael worked briefly in the HotSpot > compiler team. He has been an Oracle employee since 2011, which is when he > joined the Virtual Machine Research Group at Oracle Labs, where he has > worked on the Maxine meta-circular JVM and on dynamic language > implementations. He used to be the tech lead of the FastR project, a > high-performance Java-based implementation of the R programming language. > Michael has also contributed to the LambdaForm-based java.lang.invoke > infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From harold.seigel at oracle.com Thu Nov 5 13:46:03 2015 From: harold.seigel at oracle.com (harold seigel) Date: Thu, 5 Nov 2015 08:46:03 -0500 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B5D9B.8010006@oracle.com> Vote: yes Harold On 11/5/2015 4:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From karen.kinnear at oracle.com Thu Nov 5 14:56:24 2015 From: karen.kinnear at oracle.com (Karen Kinnear) Date: Thu, 5 Nov 2015 09:56:24 -0500 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <8EE307B0-3B82-47BA-A860-B4D475EABF4C@oracle.com> vote: yes thanks, Karen > On Nov 5, 2015, at 4:13 AM, Vladimir Ivanov wrote: > > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language implementations. He also collaborates with the Valhalla project for value types. Prior to joining Nashorn, Michael worked briefly in the HotSpot compiler team. He has been an Oracle employee since 2011, which is when he joined the Virtual Machine Research Group at Oracle Labs, where he has worked on the Maxine meta-circular JVM and on dynamic language implementations. He used to be the tech lead of the FastR project, a high-performance Java-based implementation of the R programming language. Michael has also contributed to the LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From staffan.larsen at oracle.com Thu Nov 5 15:16:14 2015 From: staffan.larsen at oracle.com (Staffan Larsen) Date: Thu, 5 Nov 2015 16:16:14 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: Vote: yes > On 5 nov. 2015, at 10:13, Vladimir Ivanov wrote: > > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language implementations. He also collaborates with the Valhalla project for value types. Prior to joining Nashorn, Michael worked briefly in the HotSpot compiler team. He has been an Oracle employee since 2011, which is when he joined the Virtual Machine Research Group at Oracle Labs, where he has worked on the Maxine meta-circular JVM and on dynamic language implementations. He used to be the tech lead of the FastR project, a high-performance Java-based implementation of the R programming language. Michael has also contributed to the LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From yumin.qi at oracle.com Thu Nov 5 17:57:50 2015 From: yumin.qi at oracle.com (Yumin Qi) Date: Thu, 5 Nov 2015 09:57:50 -0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563B989E.2010604@oracle.com> Vote: Yes On 11/5/2015 1:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From Peter.B.Kessler at Oracle.COM Fri Nov 6 00:45:49 2015 From: Peter.B.Kessler at Oracle.COM (Peter B. Kessler) Date: Thu, 05 Nov 2015 16:45:49 -0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563BF83D.90608@Oracle.COM> Vote: yes ... peter On 11/ 5/15 01:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language implementations. He also collaborates with the Valhalla project for value types. Prior to joining Nashorn, Michael worked briefly in the HotSpot compiler team. He has been an Oracle employee since 2011, which is when he joined the Virtual Machine Research Group at Oracle Labs, where he has worked on the Maxine meta-circular JVM and on dynamic language implementations. He used to be the tech lead of the FastR project, a high-performance Java-based implementation of the R programming language. Michael has also contributed to the LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From shafi.s.ahmad at oracle.com Fri Nov 6 12:41:01 2015 From: shafi.s.ahmad at oracle.com (Shafi Ahmad) Date: Fri, 6 Nov 2015 04:41:01 -0800 (PST) Subject: Request for approval: JDK-8140249- JVM Crashing During startUp If Flight Recording is enabled Message-ID: <5d90e921-13af-4d3d-8ee0-dd8e399d7e31@default> Hi, May I have approval to backport this fix from jdk9 to jdk8. I have build the jdk8 and tested already. jdk9 fix applies cleanly to jdk8 source. Bug: https://bugs.openjdk.java.net/browse/JDK-8141282 jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/d806ff9d9804 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-November/016373.html Thank you. Regards, Shafi From sean.coffey at oracle.com Fri Nov 6 12:58:55 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 6 Nov 2015 12:58:55 +0000 Subject: Request for approval: JDK-8140249- JVM Crashing During startUp If Flight Recording is enabled In-Reply-To: <5d90e921-13af-4d3d-8ee0-dd8e399d7e31@default> References: <5d90e921-13af-4d3d-8ee0-dd8e399d7e31@default> Message-ID: <563CA40F.2020500@oracle.com> Shafi, can you please add a suitable noreg label to this bug report : http://openjdk.java.net/guide/changePlanning.html#noreg Approved for jdk8u-dev. Regards, Sean. On 06/11/15 12:41, Shafi Ahmad wrote: > Hi, > > May I have approval to backport this fix from jdk9 to jdk8. > I have build the jdk8 and tested already. > jdk9 fix applies cleanly to jdk8 source. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8141282 > jdk9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/d806ff9d9804 > Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-November/016373.html > > Thank you. > > Regards, > Shafi From vicente.romero at oracle.com Sat Nov 7 00:00:04 2015 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Fri, 6 Nov 2015 16:00:04 -0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563D3F04.9000408@oracle.com> vote: yes Vicente On 11/05/2015 01:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From jonathan.gibbons at oracle.com Sat Nov 7 00:03:01 2015 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Fri, 06 Nov 2015 16:03:01 -0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <563D3FB5.9000109@oracle.com> Vote: yes On 11/05/2015 01:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From john.r.rose at oracle.com Sat Nov 7 00:46:16 2015 From: john.r.rose at oracle.com (John Rose) Date: Fri, 6 Nov 2015 16:46:16 -0800 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <7EC53BB3-1005-4C4C-B9B5-21F823E6F3B3@oracle.com> Vote: yes From maurizio.cimadamore at oracle.com Tue Nov 10 09:37:27 2015 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 10 Nov 2015 09:37:27 +0000 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <5641BAD7.4040009@oracle.com> Vote: yes Maurizio On 05/11/15 09:13, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From hannes.wallnoefer at oracle.com Tue Nov 10 09:45:21 2015 From: hannes.wallnoefer at oracle.com (Hannes Wallnoefer) Date: Tue, 10 Nov 2015 10:45:21 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <5641BCB1.8080109@oracle.com> Vote: yes Hannes Am 2015-11-05 um 10:13 schrieb Vladimir Ivanov: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From mikhail.cherkasov at oracle.com Thu Nov 12 11:42:23 2015 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Thu, 12 Nov 2015 14:42:23 +0300 Subject: [8u-dev] Request for approval for 8132890: Text overlapping on dot matrix printers. Message-ID: <56447B1F.8020702@oracle.com> Hello, Could you please approve the following backport of the fix to 8u-dev? The fix is the same, but a test was moved from close to open part, hence the backport was reviewed: http://mail.openjdk.java.net/pipermail/2d-dev/2015-November/005806.html JBS: https://bugs.openjdk.java.net/browse/JDK-8132890 Webrev: http://cr.openjdk.java.net/~mcherkas/8132890/webrev.00/ JDK9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/edec0fe63ceb Thanks, Mikhail. From sean.coffey at oracle.com Thu Nov 12 11:44:45 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Thu, 12 Nov 2015 11:44:45 +0000 Subject: [8u-dev] Request for approval for 8132890: Text overlapping on dot matrix printers. In-Reply-To: <56447B1F.8020702@oracle.com> References: <56447B1F.8020702@oracle.com> Message-ID: <56447BAD.9070802@oracle.com> Approved. Regards, Sean. On 12/11/2015 11:42, mikhail cherkasov wrote: > Hello, > > Could you please approve the following backport of the fix to 8u-dev? > The fix is the same, but a test was moved from close to open part, > hence the backport > was reviewed: > http://mail.openjdk.java.net/pipermail/2d-dev/2015-November/005806.html > > JBS: https://bugs.openjdk.java.net/browse/JDK-8132890 > Webrev: > http://cr.openjdk.java.net/~mcherkas/8132890/webrev.00/ > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/edec0fe63ceb > > Thanks, > Mikhail. From mikhail.cherkasov at oracle.com Thu Nov 12 12:02:03 2015 From: mikhail.cherkasov at oracle.com (mikhail cherkasov) Date: Thu, 12 Nov 2015 15:02:03 +0300 Subject: [8u-dev] Request for approval for 8132890: Text overlapping on dot matrix printers. In-Reply-To: <56447BAD.9070802@oracle.com> References: <56447B1F.8020702@oracle.com> <56447BAD.9070802@oracle.com> Message-ID: <56447FBB.4000204@oracle.com> Thank you! On 11/12/2015 14:44, Se?n Coffey wrote: > Approved. > > Regards, > Sean. > > On 12/11/2015 11:42, mikhail cherkasov wrote: >> Hello, >> >> Could you please approve the following backport of the fix to 8u-dev? >> The fix is the same, but a test was moved from close to open part, >> hence the backport >> was reviewed: >> http://mail.openjdk.java.net/pipermail/2d-dev/2015-November/005806.html >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8132890 >> Webrev: >> http://cr.openjdk.java.net/~mcherkas/8132890/webrev.00/ >> >> JDK9 changeset: >> http://hg.openjdk.java.net/jdk9/client/jdk/rev/edec0fe63ceb >> >> Thanks, >> Mikhail. > From maurizio.cimadamore at oracle.com Thu Nov 12 13:54:34 2015 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 12 Nov 2015 13:54:34 +0000 Subject: [8u] request for review: 8066974: Compiler doesn't infer method's generic type information in lambda body Message-ID: <56449A1A.2070201@oracle.com> Hi, Please review the backport of bug: JDK-8066974: Compiler doesn't infer method's generic type information in lambda body JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8066974 original patch pushed to 9: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c402b2856ed1 public review: http://cr.openjdk.java.net/~mcimadamore/8066974/ The 9 patch doesn't apply cleanly to 8u because of the changes around the Kind.java class (which has been converted into an enum in 9), and also because of the patch uses lambda expressions. Changes are relatively superficial though. Thanks, Maurizio From vicente.romero at oracle.com Thu Nov 12 18:09:37 2015 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 12 Nov 2015 10:09:37 -0800 Subject: [8u] request for review: 8066974: Compiler doesn't infer method's generic type information in lambda body In-Reply-To: <56449A1A.2070201@oracle.com> References: <56449A1A.2070201@oracle.com> Message-ID: <5644D5E1.5030706@oracle.com> approved, Thanks, Vicente On 11/12/2015 05:54 AM, Maurizio Cimadamore wrote: > Hi, > Please review the backport of bug: > > JDK-8066974: Compiler doesn't infer method's generic type information > in lambda body > > JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8066974 > original patch pushed to 9: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c402b2856ed1 > public review: http://cr.openjdk.java.net/~mcimadamore/8066974/ > > The 9 patch doesn't apply cleanly to 8u because of the changes around > the Kind.java class (which has been converted into an enum in 9), and > also because of the patch uses lambda expressions. Changes are > relatively superficial though. > > Thanks, > Maurizio From maurizio.cimadamore at oracle.com Thu Nov 12 18:43:22 2015 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 12 Nov 2015 18:43:22 +0000 Subject: [8u] request for approval: 8066974: Compiler doesn't infer method's generic type information in lambda body Message-ID: <5644DDCA.9060806@oracle.com> Hi, Please review the backport of bug: JDK-8066974: Compiler doesn't infer method's generic type information in lambda body JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8066974 original patch pushed to 9: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c402b2856ed1 backport bug: https://bugs.openjdk.java.net/browse/JDK-8142883 public review: http://cr.openjdk.java.net/~mcimadamore/8066974/ All relevant tests pass. Thanks, Maurizio From rob.mckenna at oracle.com Thu Nov 12 18:57:45 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 12 Nov 2015 18:57:45 +0000 Subject: [8u] request for approval: 8066974: Compiler doesn't infer method's generic type information in lambda body In-Reply-To: <5644DDCA.9060806@oracle.com> References: <5644DDCA.9060806@oracle.com> Message-ID: <5644E129.9040705@oracle.com> Approved -Rob On 12/11/15 18:43, Maurizio Cimadamore wrote: > Hi, > Please review the backport of bug: > > JDK-8066974: Compiler doesn't infer method's generic type information in > lambda body > > JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8066974 > original patch pushed to 9: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/c402b2856ed1 > backport bug: https://bugs.openjdk.java.net/browse/JDK-8142883 > public review: http://cr.openjdk.java.net/~mcimadamore/8066974/ > > All relevant tests pass. > > Thanks, > Maurizio From vicente.romero at oracle.com Thu Nov 12 19:03:16 2015 From: vicente.romero at oracle.com (Vicente-Arturo Romero-Zaldivar) Date: Thu, 12 Nov 2015 11:03:16 -0800 Subject: Fwd: [8u] request for review: 8133659: Compiler fails to NullPointerException when calling super with Object<>() In-Reply-To: <5644DE26.5010002@oracle.com> References: <55D3633B.6000206@oracle.com> <5644DE26.5010002@oracle.com> Message-ID: <5644E274.6030407@oracle.com> approved, Thanks, Vicente > > -------- Forwarded Message -------- > Subject: [8u] request for review: 8133659: Compiler fails to > NullPointerException when calling super with Object<>() > Date: Tue, 18 Aug 2015 17:54:19 +0100 > From: Maurizio Cimadamore > To: jdk8u-dev at openjdk.java.net >> "jdk8u-dev at openjdk.java.net" > , Vicente-Arturo Romero-Zaldivar > > > > > Whoops - wrong subject on email (that's what I get for using cut and > paste :-)) > > Maurizio > > On 17/08/15 12:03, Maurizio Cimadamore wrote: > > Hi, > > Please review the backport of bug: > > > > JDK-8133659: Compiler fails to NullPointerException when calling super > > with Object<>() > > > > JDK9 bug:https://bugs.openjdk.java.net/browse/JDK-8065986 > > backport:https://bugs.openjdk.java.net/browse/JDK-8133659 > > original patch pushed to 9: > >http://hg.openjdk.java.net/jdk9/dev/langtools/rev/caa3490d5aee > > public review:http://cr.openjdk.java.net/~mcimadamore/8133659/ > > > > The 9 patch doesn't apply cleanly to 8u because of the changes around > > the Kind.java class (which has been converted into an enum in 9). > > Changes are only superficial though. > > > > Thanks, > > Maurizio > > > From maurizio.cimadamore at oracle.com Thu Nov 12 21:23:53 2015 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 12 Nov 2015 21:23:53 +0000 Subject: [8u] request for approval: 8133659: Compiler fails to NullPointerException when calling super with Object<>() Message-ID: <56450369.3040308@oracle.com> Hi, Please review the backport of bug: JDK-8133659: Compiler fails to NullPointerException when calling super with Object<>() JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8065986 backport: https://bugs.openjdk.java.net/browse/JDK-8133659 original patch pushed to 9: http://hg.openjdk.java.net/jdk9/dev/langtools/rev/caa3490d5aee public review: http://cr.openjdk.java.net/~mcimadamore/8133659/ All relevant tests have been run. Thanks, Maurizio From rob.mckenna at oracle.com Thu Nov 12 21:26:45 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 12 Nov 2015 21:26:45 +0000 Subject: [8u] request for approval: 8133659: Compiler fails to NullPointerException when calling super with Object<>() In-Reply-To: <56450369.3040308@oracle.com> References: <56450369.3040308@oracle.com> Message-ID: <56450415.4030303@oracle.com> Approved -Rob On 12/11/15 21:23, Maurizio Cimadamore wrote: > Hi, > Please review the backport of bug: > > JDK-8133659: Compiler fails to NullPointerException when calling super > with Object<>() > > JDK9 bug: https://bugs.openjdk.java.net/browse/JDK-8065986 > backport: https://bugs.openjdk.java.net/browse/JDK-8133659 > original patch pushed to 9: > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/caa3490d5aee > public review: http://cr.openjdk.java.net/~mcimadamore/8133659/ > > All relevant tests have been run. > > Thanks, > Maurizio From dalibor.topic at oracle.com Fri Nov 13 09:08:49 2015 From: dalibor.topic at oracle.com (dalibor topic) Date: Fri, 13 Nov 2015 10:08:49 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <5645A8A1.2060303@oracle.com> Vote: Yes. -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | K?hneh?fe 5 | 22761 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: Alexander van der Ven, Astrid Kepper, Val Maher Oracle is committed to developing practices and products that help protect the environment From aph at redhat.com Mon Nov 16 10:19:30 2015 From: aph at redhat.com (Andrew Haley) Date: Mon, 16 Nov 2015 10:19:30 +0000 Subject: RFR: Backport 8138966: Intermittent SEGV running ParallelGC Message-ID: <5649ADB2.4050901@redhat.com> This one was observed on AArch64, but it is in shared code. I think I'll need someone to push this. http://cr.openjdk.java.net/~aph/8138966/jdk8/ Thanks, Andrew. From thomas.schatzl at oracle.com Mon Nov 16 13:11:38 2015 From: thomas.schatzl at oracle.com (Thomas Schatzl) Date: Mon, 16 Nov 2015 14:11:38 +0100 Subject: RFR: Backport 8138966: Intermittent SEGV running ParallelGC In-Reply-To: <5649ADB2.4050901@redhat.com> References: <5649ADB2.4050901@redhat.com> Message-ID: <1447679498.2289.78.camel@oracle.com> Hi Andrew, On Mon, 2015-11-16 at 10:19 +0000, Andrew Haley wrote: > This one was observed on AArch64, but it is in shared code. I think > I'll need someone to push this. > > http://cr.openjdk.java.net/~aph/8138966/jdk8/ > > Thanks, I will request a backport for this change to 8u, and push it if I get the permission. (That should not be a problem imo.) Sorry for overlooking that this change would be very useful for 8u. Thanks, Thomas From peter.levart at gmail.com Mon Nov 16 14:19:42 2015 From: peter.levart at gmail.com (Peter Levart) Date: Mon, 16 Nov 2015 15:19:42 +0100 Subject: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <563B1DA9.90305@oracle.com> References: <563B1DA9.90305@oracle.com> Message-ID: <5649E5FE.8000709@gmail.com> Vote: Yes. Regards, Peter On 11/05/2015 10:13 AM, Vladimir Ivanov wrote: > I hereby nominate Michael Haupt to jdk8u Committer. > > Michael has made many contributions in several areas of the JDK [1] > > Michael is part of the Nashorn team; his focus is on dynamic language > implementations. He also collaborates with the Valhalla project for > value types. Prior to joining Nashorn, Michael worked briefly in the > HotSpot compiler team. He has been an Oracle employee since 2011, > which is when he joined the Virtual Machine Research Group at Oracle > Labs, where he has worked on the Maxine meta-circular JVM and on > dynamic language implementations. He used to be the tech lead of the > FastR project, a high-performance Java-based implementation of the R > programming language. Michael has also contributed to the > LambdaForm-based java.lang.invoke infrastructure in the past. > > He is JDK9 Committer [2]. > > Votes are due by Nov, 19, 2015 > > Only current JDK8u Committers [3] are eligible to vote on this > nomination. Votes must be cast in the open by replying to this mailing > list. > > For Lazy Consensus voting instructions, see [4]. > > Best regards, > Vladimir Ivanov > > [1] > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/nashorn/log?rev=user%28mhaupt%29 > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/bb189430ea6c > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/050116960e99 > [2] http://openjdk.java.net/census#mhaupt > [3] http://openjdk.java.net/census#jdk8u > [4] http://openjdk.java.net/projects#committer-vote From christoph.langer at sap.com Mon Nov 16 15:56:57 2015 From: christoph.langer at sap.com (Langer, Christoph) Date: Mon, 16 Nov 2015 15:56:57 +0000 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions Message-ID: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> Hi, can you please approve a direct backport of 8130910 to 8u-dev? Bug: https://bugs.openjdk.java.net/browse/JDK-8130910 Review thread of JDK9: http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html JDK9 changeset: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 I did a new webrev because the patch had a small reject in perfMemory_aix.cpp: http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ Thanks, Christoph From rob.mckenna at oracle.com Mon Nov 16 16:04:42 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 16 Nov 2015 16:04:42 +0000 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> Message-ID: <5649FE9A.7080703@oracle.com> Approved. Please add an appropriate noreg label to the bug however. -Rob On 16/11/15 15:56, Langer, Christoph wrote: > Hi, > > can you please approve a direct backport of 8130910 to 8u-dev? > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8130910 > > Review thread of JDK9: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 > > I did a new webrev because the patch had a small reject in perfMemory_aix.cpp: > http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ > > Thanks, > Christoph > From aleksey.shipilev at oracle.com Mon Nov 16 18:23:31 2015 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Mon, 16 Nov 2015 21:23:31 +0300 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted Message-ID: <564A1F23.6030009@oracle.com> Hi, There is a simple Hotspot compiler change that improves the Atomic*FieldUpdater performance by a large margin, and thus provides a migration path with the eventual demise of sun.misc.Unsafe. Therefore, I'd like us to consider this in 8u76 to expose users to this improvement earlier than JDK 9 release. I am not a 8u Committer, so if the change is approved, I'd need a sponsor. Bug: https://bugs.openjdk.java.net/browse/JDK-8140483 Webrev: http://cr.openjdk.java.net/~shade/8140483/webrev.02/ JDK 9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/0835ef4e6232 JDK 9 Review: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-October/019549.html The change was in jdk9/hs-comp for two weeks now, and a few days in jdk9/jdk9. The patch applies automatically with a bit of the fuzz. jdk8u builds and runs fine at least on Linux x86_64, the performance improvement is the same as in JDK 9. Thanks, -Aleksey From martinrb at google.com Mon Nov 16 18:28:15 2015 From: martinrb at google.com (Martin Buchholz) Date: Mon, 16 Nov 2015 10:28:15 -0800 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: <564A1F23.6030009@oracle.com> References: <564A1F23.6030009@oracle.com> Message-ID: FYI I am preparing a new wave of jsr166-jdk9 integrations. http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ On Mon, Nov 16, 2015 at 10:23 AM, Aleksey Shipilev < aleksey.shipilev at oracle.com> wrote: > Hi, > > There is a simple Hotspot compiler change that improves the > Atomic*FieldUpdater performance by a large margin, and thus provides a > migration path with the eventual demise of sun.misc.Unsafe. Therefore, > I'd like us to consider this in 8u76 to expose users to this improvement > earlier than JDK 9 release. I am not a 8u Committer, so if the change is > approved, I'd need a sponsor. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8140483 > > Webrev: > http://cr.openjdk.java.net/~shade/8140483/webrev.02/ > > JDK 9 Changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/0835ef4e6232 > > JDK 9 Review: > > > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-October/019549.html > > The change was in jdk9/hs-comp for two weeks now, and a few days in > jdk9/jdk9. > > The patch applies automatically with a bit of the fuzz. jdk8u builds and > runs fine at least on Linux x86_64, the performance improvement is the > same as in JDK 9. > > Thanks, > -Aleksey > > From aleksey.shipilev at oracle.com Mon Nov 16 18:39:35 2015 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Mon, 16 Nov 2015 21:39:35 +0300 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: References: <564A1F23.6030009@oracle.com> Message-ID: <564A22E7.7080605@oracle.com> On 11/16/2015 09:28 PM, Martin Buchholz wrote: > FYI I am preparing a new wave of jsr166-jdk9 integrations. > http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/ > Yes, that is another part of the A*FU performance story, and it should/will be handled with another backport. Thanks, -Aleksey From rob.mckenna at oracle.com Mon Nov 16 20:15:44 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 16 Nov 2015 20:15:44 +0000 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: <564A1F23.6030009@oracle.com> References: <564A1F23.6030009@oracle.com> Message-ID: <564A3970.6090703@oracle.com> Approved. Please add an appropriate noreg label to the bug. -Rob On 16/11/15 18:23, Aleksey Shipilev wrote: > Hi, > > There is a simple Hotspot compiler change that improves the > Atomic*FieldUpdater performance by a large margin, and thus provides a > migration path with the eventual demise of sun.misc.Unsafe. Therefore, > I'd like us to consider this in 8u76 to expose users to this improvement > earlier than JDK 9 release. I am not a 8u Committer, so if the change is > approved, I'd need a sponsor. > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8140483 > > Webrev: > http://cr.openjdk.java.net/~shade/8140483/webrev.02/ > > JDK 9 Changeset: > http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/0835ef4e6232 > > JDK 9 Review: > > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-October/019549.html > > The change was in jdk9/hs-comp for two weeks now, and a few days in > jdk9/jdk9. > > The patch applies automatically with a bit of the fuzz. jdk8u builds and > runs fine at least on Linux x86_64, the performance improvement is the > same as in JDK 9. > > Thanks, > -Aleksey > From aleksey.shipilev at oracle.com Mon Nov 16 20:20:54 2015 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Mon, 16 Nov 2015 23:20:54 +0300 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: <564A3970.6090703@oracle.com> References: <564A1F23.6030009@oracle.com> <564A3970.6090703@oracle.com> Message-ID: <564A3AA6.5020103@oracle.com> Thanks Rob! Added "noreg-perf". Looking for a sponsor! Cheers, -Aleksey On 11/16/2015 11:15 PM, Rob McKenna wrote: > Approved. Please add an appropriate noreg label to the bug. > > -Rob > > On 16/11/15 18:23, Aleksey Shipilev wrote: >> Hi, >> >> There is a simple Hotspot compiler change that improves the >> Atomic*FieldUpdater performance by a large margin, and thus provides a >> migration path with the eventual demise of sun.misc.Unsafe. Therefore, >> I'd like us to consider this in 8u76 to expose users to this improvement >> earlier than JDK 9 release. I am not a 8u Committer, so if the change is >> approved, I'd need a sponsor. >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8140483 >> >> Webrev: >> http://cr.openjdk.java.net/~shade/8140483/webrev.02/ >> >> JDK 9 Changeset: >> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/0835ef4e6232 >> >> JDK 9 Review: >> >> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-October/019549.html >> >> >> The change was in jdk9/hs-comp for two weeks now, and a few days in >> jdk9/jdk9. >> >> The patch applies automatically with a bit of the fuzz. jdk8u builds and >> runs fine at least on Linux x86_64, the performance improvement is the >> same as in JDK 9. >> >> Thanks, >> -Aleksey >> From paul.sandoz at oracle.com Mon Nov 16 20:27:17 2015 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Mon, 16 Nov 2015 21:27:17 +0100 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: <564A3AA6.5020103@oracle.com> References: <564A1F23.6030009@oracle.com> <564A3970.6090703@oracle.com> <564A3AA6.5020103@oracle.com> Message-ID: <110A3E4D-33B2-4732-96CF-D7F8E5860E53@oracle.com> > On 16 Nov 2015, at 21:20, Aleksey Shipilev wrote: > > Thanks Rob! > Added "noreg-perf". > > Looking for a sponsor! > I push this for you tomorrow. Paul. From aleksey.shipilev at oracle.com Mon Nov 16 20:47:54 2015 From: aleksey.shipilev at oracle.com (Aleksey Shipilev) Date: Mon, 16 Nov 2015 23:47:54 +0300 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: <110A3E4D-33B2-4732-96CF-D7F8E5860E53@oracle.com> References: <564A1F23.6030009@oracle.com> <564A3970.6090703@oracle.com> <564A3AA6.5020103@oracle.com> <110A3E4D-33B2-4732-96CF-D7F8E5860E53@oracle.com> Message-ID: <564A40FA.4060501@oracle.com> On 11/16/2015 11:27 PM, Paul Sandoz wrote: > >> On 16 Nov 2015, at 21:20, Aleksey Shipilev wrote: >> >> Thanks Rob! >> Added "noreg-perf". >> >> Looking for a sponsor! >> > > I push this for you tomorrow. Thank you, Paul! -Aleksey From masayoshi.okutsu at oracle.com Tue Nov 17 08:54:21 2015 From: masayoshi.okutsu at oracle.com (Masayoshi Okutsu) Date: Tue, 17 Nov 2015 17:54:21 +0900 Subject: Code Review for JDK-8141243: Unexpected timezone returned after parsing a date In-Reply-To: References: Message-ID: <564AEB3D.3040609@oracle.com> Hi Ramanand, I don't think this fix is correct. This change mixes up time zone IDs and display names. SimpleDateFomat should parse only display names. There's no perfect solution on the issue because the short display names (abbreviations) can't be unique. So, I'd suggest that the UTC display names in all resource bundles (all TimeZoneNames*.java under sun.util.resources) move up to the compatibility group. BTW, the symptom is reproducible in JDK 9 with the legacy time zone names (run java with -Djava.locale.providers=COMPAT). So, the fix should be done in JDK 9 first. Thanks, Masayoshi On 11/16/2015 10:38 PM, Ramanand Patil wrote: > Hi all, > > > > Please review a fix for Bug Id - HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8141243"JDK-8141243. > > > > > > Issue - When parsing the virtual timezone "UTC" with java.text.SimpleDateFormat, the timezone is set to the first timezone that matches an actual timezone in the UTC group, which is Antarctica/Troll. When comparing this timezone with the result of TimeZone.getTimeZone("UTC"), we fail. > > > > Webrev - http://cr.openjdk.java.net/~aefimov/8141243/webrev.00/ > > > > > > Regards, > > Ramanand. > > From paul.sandoz at oracle.com Tue Nov 17 12:09:43 2015 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Tue, 17 Nov 2015 13:09:43 +0100 Subject: Request for approval: 8140483, Atomic*FieldUpdaters final fields should be trusted In-Reply-To: <110A3E4D-33B2-4732-96CF-D7F8E5860E53@oracle.com> References: <564A1F23.6030009@oracle.com> <564A3970.6090703@oracle.com> <564A3AA6.5020103@oracle.com> <110A3E4D-33B2-4732-96CF-D7F8E5860E53@oracle.com> Message-ID: <9F1687BF-DE4B-4BE9-8A96-0A047BBE8186@oracle.com> > On 16 Nov 2015, at 21:27, Paul Sandoz wrote: > > >> On 16 Nov 2015, at 21:20, Aleksey Shipilev wrote: >> >> Thanks Rob! >> Added "noreg-perf". >> >> Looking for a sponsor! >> > > I push this for you tomorrow. > Pushed: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/714096aec397 Paul. From ramanand.patil at oracle.com Tue Nov 17 16:09:19 2015 From: ramanand.patil at oracle.com (Ramanand Patil) Date: Tue, 17 Nov 2015 08:09:19 -0800 (PST) Subject: Code Review for JDK-8141243: Unexpected timezone returned after parsing a date In-Reply-To: <564AEB3D.3040609@oracle.com> References: <564AEB3D.3040609@oracle.com> Message-ID: Hi Masayoshi, Thank you for your feedback and suggestion. As you said, I understood that There's no perfect solution on the issue because the short display names(abbreviations) can't be unique. I was trying to apply the workaround by considering the cases where the short display names are same as the Zone IDs. Anyways if the issue is reproducible in JDK 9 with the legacy time zone names I will dig more into it and try to find the correct fix. Sorry, if I am asking very simple question(I am new to this group/process and want to understand correctly), I didn't understand what is meant by your suggestion of moving UTC display names in all resource bundles (all TimeZoneNames*.java under sun.util.resources) up to the compatibility group. Thank you for your help. Regards, Ramanand. -----Original Message----- From: Masayoshi Okutsu Sent: Tuesday, November 17, 2015 2:24 PM To: Ramanand Patil; i18n-dev; core-libs-dev; jdk8u-dev Subject: Re: Code Review for JDK-8141243: Unexpected timezone returned after parsing a date Hi Ramanand, I don't think this fix is correct. This change mixes up time zone IDs and display names. SimpleDateFomat should parse only display names. There's no perfect solution on the issue because the short display names (abbreviations) can't be unique. So, I'd suggest that the UTC display names in all resource bundles (all TimeZoneNames*.java under sun.util.resources) move up to the compatibility group. BTW, the symptom is reproducible in JDK 9 with the legacy time zone names (run java with -Djava.locale.providers=COMPAT). So, the fix should be done in JDK 9 first. Thanks, Masayoshi On 11/16/2015 10:38 PM, Ramanand Patil wrote: > Hi all, > > > > Please review a fix for Bug Id - HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-8141243"JDK-8141243. > > > > > > Issue - When parsing the virtual timezone "UTC" with java.text.SimpleDateFormat, the timezone is set to the first timezone that matches an actual timezone in the UTC group, which is Antarctica/Troll. When comparing this timezone with the result of TimeZone.getTimeZone("UTC"), we fail. > > > > Webrev - http://cr.openjdk.java.net/~aefimov/8141243/webrev.00/ > > > > > > Regards, > > Ramanand. > > From christoph.langer at sap.com Tue Nov 17 16:44:05 2015 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 17 Nov 2015 16:44:05 +0000 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <5649FE9A.7080703@oracle.com> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> <5649FE9A.7080703@oracle.com> Message-ID: <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> OK, I added the label noreg-hard. Dan, Jerry, can anyone of you push the change? Thanks Christoph -----Original Message----- From: Rob McKenna [mailto:rob.mckenna at oracle.com] Sent: Montag, 16. November 2015 17:05 To: Langer, Christoph ; jdk8u-dev at openjdk.java.net Cc: Gerald Thornbrugh Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions Approved. Please add an appropriate noreg label to the bug however. -Rob On 16/11/15 15:56, Langer, Christoph wrote: > Hi, > > can you please approve a direct backport of 8130910 to 8u-dev? > > Bug: > https://bugs.openjdk.java.net/browse/JDK-8130910 > > Review thread of JDK9: > http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html > > JDK9 changeset: > http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 > > I did a new webrev because the patch had a small reject in perfMemory_aix.cpp: > http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ > > Thanks, > Christoph > From daniel.daugherty at oracle.com Tue Nov 17 16:49:40 2015 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 17 Nov 2015 09:49:40 -0700 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> <5649FE9A.7080703@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> Message-ID: <564B5AA4.10406@oracle.com> I'll take a look at sponsoring this in a little while. Dan On 11/17/15 9:44 AM, Langer, Christoph wrote: > OK, I added the label noreg-hard. > > Dan, Jerry, can anyone of you push the change? > > Thanks > Christoph > > -----Original Message----- > From: Rob McKenna [mailto:rob.mckenna at oracle.com] > Sent: Montag, 16. November 2015 17:05 > To: Langer, Christoph ; jdk8u-dev at openjdk.java.net > Cc: Gerald Thornbrugh > Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions > > Approved. Please add an appropriate noreg label to the bug however. > > -Rob > > On 16/11/15 15:56, Langer, Christoph wrote: >> Hi, >> >> can you please approve a direct backport of 8130910 to 8u-dev? >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8130910 >> >> Review thread of JDK9: >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html >> >> JDK9 changeset: >> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 >> >> I did a new webrev because the patch had a small reject in perfMemory_aix.cpp: >> http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ >> >> Thanks, >> Christoph >> From christoph.langer at sap.com Tue Nov 17 16:51:06 2015 From: christoph.langer at sap.com (Langer, Christoph) Date: Tue, 17 Nov 2015 16:51:06 +0000 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <564B5AA4.10406@oracle.com> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> <5649FE9A.7080703@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> <564B5AA4.10406@oracle.com> Message-ID: <0DFD2E72402C9243A8630A7759B27E4338F55A33@DEWDFEMB12B.global.corp.sap> Thanks in advance, Dan. -----Original Message----- From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com] Sent: Dienstag, 17. November 2015 17:50 To: Langer, Christoph ; Rob McKenna ; jdk8u-dev at openjdk.java.net Cc: Gerald Thornbrugh Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions I'll take a look at sponsoring this in a little while. Dan On 11/17/15 9:44 AM, Langer, Christoph wrote: > OK, I added the label noreg-hard. > > Dan, Jerry, can anyone of you push the change? > > Thanks > Christoph > > -----Original Message----- > From: Rob McKenna [mailto:rob.mckenna at oracle.com] > Sent: Montag, 16. November 2015 17:05 > To: Langer, Christoph ; jdk8u-dev at openjdk.java.net > Cc: Gerald Thornbrugh > Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions > > Approved. Please add an appropriate noreg label to the bug however. > > -Rob > > On 16/11/15 15:56, Langer, Christoph wrote: >> Hi, >> >> can you please approve a direct backport of 8130910 to 8u-dev? >> >> Bug: >> https://bugs.openjdk.java.net/browse/JDK-8130910 >> >> Review thread of JDK9: >> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html >> >> JDK9 changeset: >> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 >> >> I did a new webrev because the patch had a small reject in perfMemory_aix.cpp: >> http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ >> >> Thanks, >> Christoph >> From stefan.karlsson at oracle.com Tue Nov 17 16:56:04 2015 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Tue, 17 Nov 2015 17:56:04 +0100 Subject: [8u] Request for approval: 8058563: InstanceKlass::_dependencies list isn't cleared from empty nmethodBucket entries Message-ID: <564B5C24.2050308@oracle.com> Hi, I?d like to get approval for the backport of the fix for JDK-8058563 to 8u. The backport involved non-trivial changes to the JDK 9 patch. These changes have been reviewed on the hotspot-dev list: 8058563: InstanceKlass::_dependencies list isn't cleared from empty nmethodBucket entries Thanks, StefanK From david.buck at oracle.com Tue Nov 17 17:21:30 2015 From: david.buck at oracle.com (david buck) Date: Wed, 18 Nov 2015 02:21:30 +0900 Subject: [8u] Request for approval: 8058563: InstanceKlass::_dependencies list isn't cleared from empty nmethodBucket entries In-Reply-To: <564B5C24.2050308@oracle.com> References: <564B5C24.2050308@oracle.com> Message-ID: <564B621A.7010102@oracle.com> Hi Stefan! Would you please resend your request to the alias with direct links to: - the JBS bug - review thread(s): - jdk9 changeset [ JDK 8 Updates: Push Approval Request Template ] http://openjdk.java.net/projects/jdk8u/approval-template.html Cheers, -Buck On 2015/11/18 1:56, Stefan Karlsson wrote: > Hi, > > I?d like to get approval for the backport of the fix for JDK-8058563 to 8u. > > The backport involved non-trivial changes to the JDK 9 patch. These > changes have been reviewed on the hotspot-dev list: > 8058563: InstanceKlass::_dependencies list isn't cleared from empty > nmethodBucket entries > > Thanks, > StefanK From daniel.daugherty at oracle.com Tue Nov 17 17:42:11 2015 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 17 Nov 2015 10:42:11 -0700 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <0DFD2E72402C9243A8630A7759B27E4338F55A33@DEWDFEMB12B.global.corp.sap> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> <5649FE9A.7080703@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> <564B5AA4.10406@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F55A33@DEWDFEMB12B.global.corp.sap> Message-ID: <564B66F3.1010303@oracle.com> So here's what the commit looks like: $ hg log -v -r tip changeset: 7667:9f8038f83a6e tag: tip user: clanger date: Tue Nov 17 09:39:45 2015 -0800 files: src/os/aix/vm/perfMemory_aix.cpp src/os/bsd/vm/perfMemory_bsd.cpp src/os/linux/vm/perfMemory_linux.cpp src/os/solaris/vm/perfMemory_solaris.cpp description: 8130910: hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions Summary: Add check for fchir() failure and disable shared PerfMemory in that case. Reviewed-by: dcubed, simonis, gthornbr I've compared this fix with the version that I sponsored for JDK9-hs-rt back in August and it looks good. Christoph and Jerry, are you guys good with this changeset? Dan On 11/17/15 9:51 AM, Langer, Christoph wrote: > Thanks in advance, Dan. > > -----Original Message----- > From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com] > Sent: Dienstag, 17. November 2015 17:50 > To: Langer, Christoph ; Rob McKenna ; jdk8u-dev at openjdk.java.net > Cc: Gerald Thornbrugh > Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions > > I'll take a look at sponsoring this in a little while. > > Dan > > > On 11/17/15 9:44 AM, Langer, Christoph wrote: >> OK, I added the label noreg-hard. >> >> Dan, Jerry, can anyone of you push the change? >> >> Thanks >> Christoph >> >> -----Original Message----- >> From: Rob McKenna [mailto:rob.mckenna at oracle.com] >> Sent: Montag, 16. November 2015 17:05 >> To: Langer, Christoph ; jdk8u-dev at openjdk.java.net >> Cc: Gerald Thornbrugh >> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions >> >> Approved. Please add an appropriate noreg label to the bug however. >> >> -Rob >> >> On 16/11/15 15:56, Langer, Christoph wrote: >>> Hi, >>> >>> can you please approve a direct backport of 8130910 to 8u-dev? >>> >>> Bug: >>> https://bugs.openjdk.java.net/browse/JDK-8130910 >>> >>> Review thread of JDK9: >>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html >>> >>> JDK9 changeset: >>> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 >>> >>> I did a new webrev because the patch had a small reject in perfMemory_aix.cpp: >>> http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ >>> >>> Thanks, >>> Christoph >>> > From daniel.daugherty at oracle.com Tue Nov 17 20:10:30 2015 From: daniel.daugherty at oracle.com (Daniel D. Daugherty) Date: Tue, 17 Nov 2015 13:10:30 -0700 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <564B7A75.7030001@oracle.com> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> <5649FE9A.7080703@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> <564B5AA4.10406@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F55A33@DEWDFEMB12B.global.corp.sap> <564B66F3.1010303@oracle.com> <564B7A75.7030001@oracle.com> Message-ID: <564B89B6.7020105@oracle.com> Thanks! The changeset pushed about 15 minutes ago... Dan On 11/17/15 12:05 PM, Gerald Thornbrugh wrote: > Hi Dan, >> So here's what the commit looks like: >> >> $ hg log -v -r tip >> changeset: 7667:9f8038f83a6e >> tag: tip >> user: clanger >> date: Tue Nov 17 09:39:45 2015 -0800 >> files: src/os/aix/vm/perfMemory_aix.cpp >> src/os/bsd/vm/perfMemory_bsd.cpp src/os/linux/vm/perfMemory_linux.cpp >> src/os/solaris/vm/perfMemory_solaris.cpp >> description: >> 8130910: hsperfdata file is created in wrong directory and not >> cleaned up if /tmp/hsperfdata_ has wrong permissions >> Summary: Add check for fchir() failure and disable shared PerfMemory >> in that case. >> Reviewed-by: dcubed, simonis, gthornbr >> >> >> I've compared this fix with the version that I sponsored for >> JDK9-hs-rt back in August and it looks good. >> >> Christoph and Jerry, are you guys good with this changeset? > I good with this change set. > > Thanks! > > Jerry >> >> Dan >> >> On 11/17/15 9:51 AM, Langer, Christoph wrote: >>> Thanks in advance, Dan. >>> >>> -----Original Message----- >>> From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com] >>> Sent: Dienstag, 17. November 2015 17:50 >>> To: Langer, Christoph ; Rob McKenna >>> ; jdk8u-dev at openjdk.java.net >>> Cc: Gerald Thornbrugh >>> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file >>> is created in wrong directory and not cleaned up if >>> /tmp/hsperfdata_ has wrong permissions >>> >>> I'll take a look at sponsoring this in a little while. >>> >>> Dan >>> >>> >>> On 11/17/15 9:44 AM, Langer, Christoph wrote: >>>> OK, I added the label noreg-hard. >>>> >>>> Dan, Jerry, can anyone of you push the change? >>>> >>>> Thanks >>>> Christoph >>>> >>>> -----Original Message----- >>>> From: Rob McKenna [mailto:rob.mckenna at oracle.com] >>>> Sent: Montag, 16. November 2015 17:05 >>>> To: Langer, Christoph ; >>>> jdk8u-dev at openjdk.java.net >>>> Cc: Gerald Thornbrugh >>>> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file >>>> is created in wrong directory and not cleaned up if >>>> /tmp/hsperfdata_ has wrong permissions >>>> >>>> Approved. Please add an appropriate noreg label to the bug however. >>>> >>>> -Rob >>>> >>>> On 16/11/15 15:56, Langer, Christoph wrote: >>>>> Hi, >>>>> >>>>> can you please approve a direct backport of 8130910 to 8u-dev? >>>>> >>>>> Bug: >>>>> https://bugs.openjdk.java.net/browse/JDK-8130910 >>>>> >>>>> Review thread of JDK9: >>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html >>>>> >>>>> >>>>> JDK9 changeset: >>>>> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 >>>>> >>>>> I did a new webrev because the patch had a small reject in >>>>> perfMemory_aix.cpp: >>>>> http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ >>>>> >>>>> Thanks, >>>>> Christoph >>>>> >>> >> > > From alen.vrecko at gmail.com Tue Nov 17 17:02:07 2015 From: alen.vrecko at gmail.com (=?UTF-8?B?QWxlbiBWcmXEjWtv?=) Date: Tue, 17 Nov 2015 18:02:07 +0100 Subject: JDK9 "SSL" enhancements backport to JDK8 Message-ID: Hi. Any ideas if/when the enhancement to "SSL" in JDK9 will make it to JDK8? The improvements are quite substantial to say the least. I could not find any info regarding back-porting in https://bugs.openjdk.java.net/browse/JDK-8046943 and related issues. Best regards. Alen From gerald.thornbrugh at oracle.com Tue Nov 17 19:05:25 2015 From: gerald.thornbrugh at oracle.com (Gerald Thornbrugh) Date: Tue, 17 Nov 2015 12:05:25 -0700 Subject: [8u-dev] Request for Approval: 8130910 hsperfdata file is created in wrong directory and not cleaned up if /tmp/hsperfdata_ has wrong permissions In-Reply-To: <564B66F3.1010303@oracle.com> References: <0DFD2E72402C9243A8630A7759B27E4338F541CA@DEWDFEMB12B.global.corp.sap> <5649FE9A.7080703@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F559EE@DEWDFEMB12B.global.corp.sap> <564B5AA4.10406@oracle.com> <0DFD2E72402C9243A8630A7759B27E4338F55A33@DEWDFEMB12B.global.corp.sap> <564B66F3.1010303@oracle.com> Message-ID: <564B7A75.7030001@oracle.com> Hi Dan, > So here's what the commit looks like: > > $ hg log -v -r tip > changeset: 7667:9f8038f83a6e > tag: tip > user: clanger > date: Tue Nov 17 09:39:45 2015 -0800 > files: src/os/aix/vm/perfMemory_aix.cpp > src/os/bsd/vm/perfMemory_bsd.cpp src/os/linux/vm/perfMemory_linux.cpp > src/os/solaris/vm/perfMemory_solaris.cpp > description: > 8130910: hsperfdata file is created in wrong directory and not cleaned > up if /tmp/hsperfdata_ has wrong permissions > Summary: Add check for fchir() failure and disable shared PerfMemory > in that case. > Reviewed-by: dcubed, simonis, gthornbr > > > I've compared this fix with the version that I sponsored for > JDK9-hs-rt back in August and it looks good. > > Christoph and Jerry, are you guys good with this changeset? I good with this change set. Thanks! Jerry > > Dan > > On 11/17/15 9:51 AM, Langer, Christoph wrote: >> Thanks in advance, Dan. >> >> -----Original Message----- >> From: Daniel D. Daugherty [mailto:daniel.daugherty at oracle.com] >> Sent: Dienstag, 17. November 2015 17:50 >> To: Langer, Christoph ; Rob McKenna >> ; jdk8u-dev at openjdk.java.net >> Cc: Gerald Thornbrugh >> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file >> is created in wrong directory and not cleaned up if >> /tmp/hsperfdata_ has wrong permissions >> >> I'll take a look at sponsoring this in a little while. >> >> Dan >> >> >> On 11/17/15 9:44 AM, Langer, Christoph wrote: >>> OK, I added the label noreg-hard. >>> >>> Dan, Jerry, can anyone of you push the change? >>> >>> Thanks >>> Christoph >>> >>> -----Original Message----- >>> From: Rob McKenna [mailto:rob.mckenna at oracle.com] >>> Sent: Montag, 16. November 2015 17:05 >>> To: Langer, Christoph ; >>> jdk8u-dev at openjdk.java.net >>> Cc: Gerald Thornbrugh >>> Subject: Re: [8u-dev] Request for Approval: 8130910 hsperfdata file >>> is created in wrong directory and not cleaned up if >>> /tmp/hsperfdata_ has wrong permissions >>> >>> Approved. Please add an appropriate noreg label to the bug however. >>> >>> -Rob >>> >>> On 16/11/15 15:56, Langer, Christoph wrote: >>>> Hi, >>>> >>>> can you please approve a direct backport of 8130910 to 8u-dev? >>>> >>>> Bug: >>>> https://bugs.openjdk.java.net/browse/JDK-8130910 >>>> >>>> Review thread of JDK9: >>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-August/019588.html >>>> >>>> >>>> JDK9 changeset: >>>> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/efc17f03e5d4 >>>> >>>> I did a new webrev because the patch had a small reject in >>>> perfMemory_aix.cpp: >>>> http://cr.openjdk.java.net/~clanger/webrevs/8130910.8udev/ >>>> >>>> Thanks, >>>> Christoph >>>> >> > From sgehwolf at redhat.com Wed Nov 18 10:50:21 2015 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Wed, 18 Nov 2015 11:50:21 +0100 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms Message-ID: <1447843821.3660.11.camel@redhat.com> Hi, I'd like to ask for approval of a Zero-specific hotspot 8 backport. Currently, the jdk8u forest fails to build the Zero variant with GCC 5 due to this: src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: function returns address of local variable [-Werror=return-local-addr] ???return dummy; ??????????^ src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: declared here ???address dummy = (address) &dummy; ???????????^ Note: Fedora 22+ have GCC 5. The above problem and the actual overflow bug (if warning is ignored at build time + on relevant arch) goes away when JDK-8087120 gets backported to 8u. Original Bug:?https://bugs.openjdk.java.net/browse/JDK-8087120 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087120/webrev.01/ 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-June/018884.html The 9 webrev applies with no change to the 8 forest. I'd need somebody to sponsor this for me. Thanks, Severin From Xuelei.Fan at Oracle.COM Wed Nov 18 14:09:01 2015 From: Xuelei.Fan at Oracle.COM (Xuelei Fan) Date: Wed, 18 Nov 2015 22:09:01 +0800 Subject: JDK9 "SSL" enhancements backport to JDK8 In-Reply-To: References: Message-ID: <564C867D.2010904@Oracle.COM> Hi Alen, Except JDK-8046943, what else enhancements would you like to see in JDK 8u? What's the requirement for each backport? Thanks, Xuelei On 11/18/2015 1:02 AM, Alen Vre?ko wrote: > Hi. > > Any ideas if/when the enhancement to "SSL" in JDK9 will make it to JDK8? > The improvements are quite substantial to say the least. > > I could not find any info regarding back-porting in > https://bugs.openjdk.java.net/browse/JDK-8046943 > and related issues. > > Best regards. > Alen > From rob.mckenna at oracle.com Wed Nov 18 21:08:31 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 18 Nov 2015 21:08:31 +0000 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <1447843821.3660.11.camel@redhat.com> References: <1447843821.3660.11.camel@redhat.com> Message-ID: <564CE8CF.4020302@oracle.com> Approved. Please add a suitable noreg label to the bug. -Rob On 18/11/15 10:50, Severin Gehwolf wrote: > Hi, > > I'd like to ask for approval of a Zero-specific hotspot 8 backport. > Currently, the jdk8u forest fails to build the Zero variant with GCC 5 > due to this: > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: function returns address of local variable [-Werror=return-local-addr] > return dummy; > ^ > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: declared here > address dummy = (address) &dummy; > ^ > Note: Fedora 22+ have GCC 5. The above problem and the actual overflow > bug (if warning is ignored at build time + on relevant arch) goes away > when JDK-8087120 gets backported to 8u. > > Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 > 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087120/webrev.01/ > 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-June/018884.html > > The 9 webrev applies with no change to the 8 forest. I'd need somebody > to sponsor this for me. > > Thanks, > Severin > From sgehwolf at redhat.com Thu Nov 19 09:20:28 2015 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 19 Nov 2015 10:20:28 +0100 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <564CE8CF.4020302@oracle.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> Message-ID: <1447924828.4010.3.camel@redhat.com> On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: > Approved. Please add a suitable noreg label to the bug. > > -Rob Thanks, Rob! I've added a noreg-hard label to?JDK-8087120. Cheers, Severin > On 18/11/15 10:50, Severin Gehwolf wrote: > > Hi, > > > > I'd like to ask for approval of a Zero-specific hotspot 8 backport. > > Currently, the jdk8u forest fails to build the Zero variant with > > GCC 5 > > due to this: > > > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: function > > returns address of local variable [-Werror=return-local-addr] > > ????return dummy; > > ???????????^ > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: declared > > here > > ????address dummy = (address) &dummy; > > ????????????^ > > Note: Fedora 22+ have GCC 5. The above problem and the actual > > overflow > > bug (if warning is ignored at build time + on relevant arch) goes > > away > > when JDK-8087120 gets backported to 8u. > > > > Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 > > 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087120/ > > webrev.01/ > > 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev > > /2015-June/018884.html > > > > The 9 webrev applies with no change to the 8 forest. I'd need > > somebody > > to sponsor this for me. > > > > Thanks, > > Severin > > From sgehwolf at redhat.com Thu Nov 19 09:41:20 2015 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 19 Nov 2015 10:41:20 +0100 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <564CE8CF.4020302@oracle.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> Message-ID: <1447926080.4010.8.camel@redhat.com> On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: > Approved. Please add a suitable noreg label to the bug. > > -Rob Another question: Wouldn't I need a sponsor to get this integrated? Is this being taken care of automatically? Thanks for your help! Cheers, Severin > On 18/11/15 10:50, Severin Gehwolf wrote: > > Hi, > > > > I'd like to ask for approval of a Zero-specific hotspot 8 backport. > > Currently, the jdk8u forest fails to build the Zero variant with > > GCC 5 > > due to this: > > > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: function > > returns address of local variable [-Werror=return-local-addr] > > ????return dummy; > > ???????????^ > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: declared > > here > > ????address dummy = (address) &dummy; > > ????????????^ > > Note: Fedora 22+ have GCC 5. The above problem and the actual > > overflow > > bug (if warning is ignored at build time + on relevant arch) goes > > away > > when JDK-8087120 gets backported to 8u. > > > > Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 > > 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087120/ > > webrev.01/ > > 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev > > /2015-June/018884.html > > > > The 9 webrev applies with no change to the 8 forest. I'd need > > somebody > > to sponsor this for me. > > > > Thanks, > > Severin > > From rob.mckenna at oracle.com Thu Nov 19 15:43:47 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 19 Nov 2015 15:43:47 +0000 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <1447926080.4010.8.camel@redhat.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> Message-ID: <564DEE33.5000402@oracle.com> Correct. You need a sponsor. Perhaps Andrew would be willing to help? Failing that please work with the hotspot group. -Rob On 19/11/15 09:41, Severin Gehwolf wrote: > On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: >> Approved. Please add a suitable noreg label to the bug. >> >> -Rob > > Another question: Wouldn't I need a sponsor to get this integrated? Is > this being taken care of automatically? > > Thanks for your help! > > Cheers, > Severin > >> On 18/11/15 10:50, Severin Gehwolf wrote: >>> Hi, >>> >>> I'd like to ask for approval of a Zero-specific hotspot 8 backport. >>> Currently, the jdk8u forest fails to build the Zero variant with >>> GCC 5 >>> due to this: >>> >>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: function >>> returns address of local variable [-Werror=return-local-addr] >>> return dummy; >>> ^ >>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: declared >>> here >>> address dummy = (address) &dummy; >>> ^ >>> Note: Fedora 22+ have GCC 5. The above problem and the actual >>> overflow >>> bug (if warning is ignored at build time + on relevant arch) goes >>> away >>> when JDK-8087120 gets backported to 8u. >>> >>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 >>> 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087120/ >>> webrev.01/ >>> 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot-dev >>> /2015-June/018884.html >>> >>> The 9 webrev applies with no change to the 8 forest. I'd need >>> somebody >>> to sponsor this for me. >>> >>> Thanks, >>> Severin >>> > From vladimir.kozlov at oracle.com Thu Nov 19 17:53:43 2015 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 19 Nov 2015 09:53:43 -0800 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <1447953699.4010.45.camel@redhat.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> <564DEE33.5000402@oracle.com> <1447953699.4010.45.camel@redhat.com> Message-ID: <564E0CA7.1040302@oracle.com> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot On 11/19/15 9:21 AM, Severin Gehwolf wrote: > On Thu, 2015-11-19 at 15:43 +0000, Rob McKenna wrote: >> Correct. You need a sponsor. Perhaps Andrew would be willing to help? >> Failing that please work with the hotspot group. > > Thanks, Rob. > > Hotspot people: To which JDK 8 tree should this get pushed? Andrew, > tells me that he can push it for me once we know where :) > > Thanks, > Severin > >> -Rob >> >> On 19/11/15 09:41, Severin Gehwolf wrote: >>> On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: >>>> Approved. Please add a suitable noreg label to the bug. >>>> >>>> -Rob >>> >>> Another question: Wouldn't I need a sponsor to get this integrated? >>> Is >>> this being taken care of automatically? >>> >>> Thanks for your help! >>> >>> Cheers, >>> Severin >>> >>>> On 18/11/15 10:50, Severin Gehwolf wrote: >>>>> Hi, >>>>> >>>>> I'd like to ask for approval of a Zero-specific hotspot 8 >>>>> backport. >>>>> Currently, the jdk8u forest fails to build the Zero variant >>>>> with >>>>> GCC 5 >>>>> due to this: >>>>> >>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: >>>>> function >>>>> returns address of local variable [-Werror=return-local-addr] >>>>> return dummy; >>>>> ^ >>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: >>>>> declared >>>>> here >>>>> address dummy = (address) &dummy; >>>>> ^ >>>>> Note: Fedora 22+ have GCC 5. The above problem and the actual >>>>> overflow >>>>> bug (if warning is ignored at build time + on relevant arch) >>>>> goes >>>>> away >>>>> when JDK-8087120 gets backported to 8u. >>>>> >>>>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 >>>>> 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087 >>>>> 120/ >>>>> webrev.01/ >>>>> 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot >>>>> -dev >>>>> /2015-June/018884.html >>>>> >>>>> The 9 webrev applies with no change to the 8 forest. I'd need >>>>> somebody >>>>> to sponsor this for me. >>>>> >>>>> Thanks, >>>>> Severin >>>>> >>> > From sgehwolf at redhat.com Thu Nov 19 17:57:10 2015 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Thu, 19 Nov 2015 18:57:10 +0100 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <564E0CA7.1040302@oracle.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> <564DEE33.5000402@oracle.com> <1447953699.4010.45.camel@redhat.com> <564E0CA7.1040302@oracle.com> Message-ID: <1447955830.4010.46.camel@redhat.com> On Thu, 2015-11-19 at 09:53 -0800, Vladimir Kozlov wrote: > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot Thank you, Vladimir! Cheers, Severin > On 11/19/15 9:21 AM, Severin Gehwolf wrote: > > On Thu, 2015-11-19 at 15:43 +0000, Rob McKenna wrote: > > > Correct. You need a sponsor. Perhaps Andrew would be willing to > > > help? > > > Failing that please work with the hotspot group. > > > > Thanks, Rob. > > > > Hotspot people: To which JDK 8 tree should this get pushed? Andrew, > > tells me that he can push it for me once we know where :) > > > > Thanks, > > Severin > > > > > -Rob > > > > > > On 19/11/15 09:41, Severin Gehwolf wrote: > > > > On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: > > > > > Approved. Please add a suitable noreg label to the bug. > > > > > > > > > > -Rob > > > > > > > > Another question: Wouldn't I need a sponsor to get this > > > > integrated? > > > > Is > > > > this being taken care of automatically? > > > > > > > > Thanks for your help! > > > > > > > > Cheers, > > > > Severin > > > > > > > > > On 18/11/15 10:50, Severin Gehwolf wrote: > > > > > > Hi, > > > > > > > > > > > > I'd like to ask for approval of a Zero-specific hotspot 8 > > > > > > backport. > > > > > > Currently, the jdk8u forest fails to build the Zero variant > > > > > > with > > > > > > GCC 5 > > > > > > due to this: > > > > > > > > > > > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: > > > > > > function > > > > > > returns address of local variable [-Werror=return-local- > > > > > > addr] > > > > > > ??????return dummy; > > > > > > ?????????????^ > > > > > > src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: > > > > > > declared > > > > > > here > > > > > > ??????address dummy = (address) &dummy; > > > > > > ??????????????^ > > > > > > Note: Fedora 22+ have GCC 5. The above problem and the > > > > > > actual > > > > > > overflow > > > > > > bug (if warning is ignored at build time + on relevant > > > > > > arch) > > > > > > goes > > > > > > away > > > > > > when JDK-8087120 gets backported to 8u. > > > > > > > > > > > > Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087 > > > > > > 120 > > > > > > 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK- > > > > > > 8087 > > > > > > 120/ > > > > > > webrev.01/ > > > > > > 9 review thread: http://mail.openjdk.java.net/pipermail/hot > > > > > > spot > > > > > > -dev > > > > > > /2015-June/018884.html > > > > > > > > > > > > The 9 webrev applies with no change to the 8 forest. I'd > > > > > > need > > > > > > somebody > > > > > > to sponsor this for me. > > > > > > > > > > > > Thanks, > > > > > > Severin > > > > > > > > > > > > From alen.vrecko at gmail.com Thu Nov 19 17:52:24 2015 From: alen.vrecko at gmail.com (=?UTF-8?B?QWxlbiBWcmXEjWtv?=) Date: Thu, 19 Nov 2015 18:52:24 +0100 Subject: JDK9 "SSL" enhancements backport to JDK8 In-Reply-To: <564C867D.2010904@Oracle.COM> References: <564C867D.2010904@Oracle.COM> Message-ID: Hi, Xuelei. To put things into perspective. I ran a simulation of https production load on the venerable E5620 machines. A simple server client set-up sending dummy data no other processing overhead. (took care of coordinated omission). On JDK8u65 the plain old SSLServerSocket code took literally 50% of all CPU resources. I see a consistent load factor of ~8 out of 16. Running the same exact bytecode (compiled with JDK8u65) on JDK9b92, I see a consistent load factor of ~1 out of 16. That is ~6% of all CPU availability. Profiling with YourKit revealed that massive amounts of time are spent in the crypto (~92%). The ghash#update in particulary screams out on JDK8. On JDK9 things are significantly better. ghash#update only takes ~2% CPU time while on JDK8 it takes ~45%. Just some rough ballparks. Fundamentally I'd like to see a future JDK8uN to give me a similar load factor as seen currently with JDK9b92. I am still pretty blown away with the difference. The related commits look pretty self-contained. I'd most probably botch the job if I backport myself. You're the experts here. ;) Thanks. Alen 2015-11-18 15:09 GMT+01:00 Xuelei Fan : > Hi Alen, > > Except JDK-8046943, what else enhancements would you like to see in JDK 8u? > What's the requirement for each backport? > > Thanks, > Xuelei > > > On 11/18/2015 1:02 AM, Alen Vre?ko wrote: >> >> Hi. >> >> Any ideas if/when the enhancement to "SSL" in JDK9 will make it to JDK8? >> The improvements are quite substantial to say the least. >> >> I could not find any info regarding back-porting in >> https://bugs.openjdk.java.net/browse/JDK-8046943 >> and related issues. >> >> Best regards. >> Alen >> > From gnu.andrew at redhat.com Fri Nov 20 03:18:34 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 19 Nov 2015 22:18:34 -0500 (EST) Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <564E0CA7.1040302@oracle.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> <564DEE33.5000402@oracle.com> <1447953699.4010.45.camel@redhat.com> <564E0CA7.1040302@oracle.com> Message-ID: <808044557.12110864.1447989514323.JavaMail.zimbra@redhat.com> ----- Original Message ----- > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot > > On 11/19/15 9:21 AM, Severin Gehwolf wrote: > > On Thu, 2015-11-19 at 15:43 +0000, Rob McKenna wrote: > >> Correct. You need a sponsor. Perhaps Andrew would be willing to help? > >> Failing that please work with the hotspot group. > > > > Thanks, Rob. > > > > Hotspot people: To which JDK 8 tree should this get pushed? Andrew, > > tells me that he can push it for me once we know where :) > > > > Thanks, > > Severin > > > >> -Rob > >> > >> On 19/11/15 09:41, Severin Gehwolf wrote: > >>> On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: > >>>> Approved. Please add a suitable noreg label to the bug. > >>>> > >>>> -Rob > >>> > >>> Another question: Wouldn't I need a sponsor to get this integrated? > >>> Is > >>> this being taken care of automatically? > >>> > >>> Thanks for your help! > >>> > >>> Cheers, > >>> Severin > >>> > >>>> On 18/11/15 10:50, Severin Gehwolf wrote: > >>>>> Hi, > >>>>> > >>>>> I'd like to ask for approval of a Zero-specific hotspot 8 > >>>>> backport. > >>>>> Currently, the jdk8u forest fails to build the Zero variant > >>>>> with > >>>>> GCC 5 > >>>>> due to this: > >>>>> > >>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: > >>>>> function > >>>>> returns address of local variable [-Werror=return-local-addr] > >>>>> return dummy; > >>>>> ^ > >>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: > >>>>> declared > >>>>> here > >>>>> address dummy = (address) &dummy; > >>>>> ^ > >>>>> Note: Fedora 22+ have GCC 5. The above problem and the actual > >>>>> overflow > >>>>> bug (if warning is ignored at build time + on relevant arch) > >>>>> goes > >>>>> away > >>>>> when JDK-8087120 gets backported to 8u. > >>>>> > >>>>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 > >>>>> 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087 > >>>>> 120/ > >>>>> webrev.01/ > >>>>> 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot > >>>>> -dev > >>>>> /2015-June/018884.html > >>>>> > >>>>> The 9 webrev applies with no change to the 8 forest. I'd need > >>>>> somebody > >>>>> to sponsor this for me. > >>>>> > >>>>> Thanks, > >>>>> Severin > >>>>> > >>> > > > Built: $ /mnt/builder/jdk8u-dev/images/j2sdk-image/bin/java -version openjdk version "1.8.0-internal" OpenJDK Runtime Environment (build 1.8.0-internal-andre_2015_11_20_01_48-b00) OpenJDK 64-Bit Zero VM (build 25.66-b00, interpreted mode) with GCC 5.1.0 and pushed the change: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c6ef40024aa2 An extra fix was needed to make it build, taken from 8075967: diff -r c6ef40024aa2 src/cpu/zero/vm/frame_zero.cpp --- a/src/cpu/zero/vm/frame_zero.cpp Fri Jun 12 16:09:45 2015 +0100 +++ b/src/cpu/zero/vm/frame_zero.cpp Fri Nov 20 03:17:01 2015 +0000 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights reserved. * Copyright 2007, 2008, 2009, 2010, 2011 Red Hat, Inc. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -216,7 +216,7 @@ valuebuf[buflen - 1] = '\0'; // Print the result - st->print_cr(" " PTR_FORMAT ": %-21s = %s", addr, fieldbuf, valuebuf); + st->print_cr(" " PTR_FORMAT ": %-21s = %s", p2i(addr), fieldbuf, valuebuf); } } I don't know if 8075967 should be backported in full (it contains other changes, and this seems to have been thrown in there to make it build): 8075967: Zero interpreter asserts for SafeFetch<32,N> calls in ObjectMonitor Summary: Implement SafeFetchX unsafely and make CanUseSafeFetchX false for Zero Reviewed-by: sgehwolf, dholmes or we should backport just the above under a new bug ID. Thoughts? Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From vladimir.kozlov at oracle.com Fri Nov 20 03:33:59 2015 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 19 Nov 2015 19:33:59 -0800 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <808044557.12110864.1447989514323.JavaMail.zimbra@redhat.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> <564DEE33.5000402@oracle.com> <1447953699.4010.45.camel@redhat.com> <564E0CA7.1040302@oracle.com> <808044557.12110864.1447989514323.JavaMail.zimbra@redhat.com> Message-ID: <564E94A7.7030700@oracle.com> Related 8074552 and 8075533 are not backported to 8u. So I would suggest to push your point fix with new bug id (and link it to 8075967) https://bugs.openjdk.java.net/browse/JDK-8074552 https://bugs.openjdk.java.net/browse/JDK-8075533 Thanks, Vladimir On 11/19/15 7:18 PM, Andrew Hughes wrote: > ----- Original Message ----- >> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot >> >> On 11/19/15 9:21 AM, Severin Gehwolf wrote: >>> On Thu, 2015-11-19 at 15:43 +0000, Rob McKenna wrote: >>>> Correct. You need a sponsor. Perhaps Andrew would be willing to help? >>>> Failing that please work with the hotspot group. >>> >>> Thanks, Rob. >>> >>> Hotspot people: To which JDK 8 tree should this get pushed? Andrew, >>> tells me that he can push it for me once we know where :) >>> >>> Thanks, >>> Severin >>> >>>> -Rob >>>> >>>> On 19/11/15 09:41, Severin Gehwolf wrote: >>>>> On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: >>>>>> Approved. Please add a suitable noreg label to the bug. >>>>>> >>>>>> -Rob >>>>> >>>>> Another question: Wouldn't I need a sponsor to get this integrated? >>>>> Is >>>>> this being taken care of automatically? >>>>> >>>>> Thanks for your help! >>>>> >>>>> Cheers, >>>>> Severin >>>>> >>>>>> On 18/11/15 10:50, Severin Gehwolf wrote: >>>>>>> Hi, >>>>>>> >>>>>>> I'd like to ask for approval of a Zero-specific hotspot 8 >>>>>>> backport. >>>>>>> Currently, the jdk8u forest fails to build the Zero variant >>>>>>> with >>>>>>> GCC 5 >>>>>>> due to this: >>>>>>> >>>>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: >>>>>>> function >>>>>>> returns address of local variable [-Werror=return-local-addr] >>>>>>> return dummy; >>>>>>> ^ >>>>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: >>>>>>> declared >>>>>>> here >>>>>>> address dummy = (address) &dummy; >>>>>>> ^ >>>>>>> Note: Fedora 22+ have GCC 5. The above problem and the actual >>>>>>> overflow >>>>>>> bug (if warning is ignored at build time + on relevant arch) >>>>>>> goes >>>>>>> away >>>>>>> when JDK-8087120 gets backported to 8u. >>>>>>> >>>>>>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 >>>>>>> 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087 >>>>>>> 120/ >>>>>>> webrev.01/ >>>>>>> 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot >>>>>>> -dev >>>>>>> /2015-June/018884.html >>>>>>> >>>>>>> The 9 webrev applies with no change to the 8 forest. I'd need >>>>>>> somebody >>>>>>> to sponsor this for me. >>>>>>> >>>>>>> Thanks, >>>>>>> Severin >>>>>>> >>>>> >>> >> > > Built: > > $ /mnt/builder/jdk8u-dev/images/j2sdk-image/bin/java -version > openjdk version "1.8.0-internal" > OpenJDK Runtime Environment (build 1.8.0-internal-andre_2015_11_20_01_48-b00) > OpenJDK 64-Bit Zero VM (build 25.66-b00, interpreted mode) > > with GCC 5.1.0 and pushed the change: > > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c6ef40024aa2 > > An extra fix was needed to make it build, taken from 8075967: > > diff -r c6ef40024aa2 src/cpu/zero/vm/frame_zero.cpp > --- a/src/cpu/zero/vm/frame_zero.cpp Fri Jun 12 16:09:45 2015 +0100 > +++ b/src/cpu/zero/vm/frame_zero.cpp Fri Nov 20 03:17:01 2015 +0000 > @@ -1,5 +1,5 @@ > /* > - * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved. > + * Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights reserved. > * Copyright 2007, 2008, 2009, 2010, 2011 Red Hat, Inc. > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > * > @@ -216,7 +216,7 @@ > valuebuf[buflen - 1] = '\0'; > > // Print the result > - st->print_cr(" " PTR_FORMAT ": %-21s = %s", addr, fieldbuf, valuebuf); > + st->print_cr(" " PTR_FORMAT ": %-21s = %s", p2i(addr), fieldbuf, valuebuf); > } > } > > I don't know if 8075967 should be backported in full (it contains other changes, > and this seems to have been thrown in there to make it build): > > 8075967: Zero interpreter asserts for SafeFetch<32,N> calls in ObjectMonitor > Summary: Implement SafeFetchX unsafely and make CanUseSafeFetchX false for Zero > Reviewed-by: sgehwolf, dholmes > > or we should backport just the above under a new bug ID. Thoughts? > > Thanks, > From gnu.andrew at redhat.com Fri Nov 20 03:34:57 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 19 Nov 2015 22:34:57 -0500 (EST) Subject: Coherent release process In-Reply-To: <72EC8BBA6F43AD603B3286DF@[192.168.1.9]> References: <72EC8BBA6F43AD603B3286DF@[192.168.1.9]> Message-ID: <447666547.12112509.1447990497599.JavaMail.zimbra@redhat.com> [Adding in the 8u mailing list] ----- Original Message ----- > Hi, > > I was wondering if/when the OpenJDK project may develop a more coherent > release plan? Right now, there seems to be no consistent strategy, which > makes it very difficult for downstream consumers of OpenJDK to be able to > reliably build out new OpenJDK releases. While I appreciate that the > process has become easier with OpenJDK 8 vs the prior OpenJDK versions, > right now the build process for new releases, particularly critical > security updates, seems quite the mess. +1. I've said pretty much the same before and it's only got worse of late. The number of people I have to explain it to, even people who actively work on OpenJDK on a daily basis, suggests it's far from obvious. It's nice to know I'm not the only one who feels this way. > > For example: > > To build OpenJDK 1.8u66, you have to use the jdk8u (JDK 8 Updates Master) > branch (doesn't make sense) > To build OpenJDK 1.8u60, you use the jdk8u60 release branch (makes sense) > To build OpenJDK 1.8u51, you use the jdk8u60-dev branch (doesn't make sense) > Actually, that won't get you u66 unless you explicitly check out a tag. The current tip of 8u is currently receiving fixes people are pushing for u76, which I believe is due to be released next April, at the same time as the u75 security update, which will be based on u72. As far as I've been able to grasp, this is the current 8u schedule: October 2015: u65 (security update based on u60) & u66 (feature release) January 2016: u71 (security update based on u66) & u72 (feature release) April 2016: u75 (security update based on u72) & u76 (feature release) July 2016: u81 (security update based on u76) & u82 (feature release) You should be able to get all versions from the 8u tree by checking out appropriate tags. Only 8u65 onwards will be up to date with the latest security fixes. > The lack of consistency among branches for different releases makes it > extremely hard to create a well defined build process for OpenJDK. Moreover, the recent changes, as I've mentioned before, also make it virtually impossible to test something like u72 before it is released. What I witnessed with u66 was the first few builds being pushed to the 8u tree, but later builds did not appear until u66 was released in late October. When I raised this before, it was pointed out that the build could be reconstructed by finding bugs in the bug database that had been tagged as added to the release and backporting them to a checkout of the latest u66 tag myself [0]. Not only is this incredibly time consuming and error prone, but there is no guarantee that the result is the same as what Oracle are testing. I really don't think the OpenJDK project as a whole should suffer because Oracle change their internal processes. > > In addition the fact that the bug system is locked down makes it extremely > hard to report issues back upstream, such as the fact that the hgforest.sh > script doesn't correctly honor command arguments, meaning that it has to be > patched to get a consistent build of the downstream modules that get > checked out. The following patch fixes this rather significant problem. > > > > As we rely heavily on being able to provide up to date, consistent, secure > OpenJDK builds to our customers, having the process to build new releases > be reliable is of significant importance. I imagine that is the case for > many others as well. Another problem I've also observed. I'm happy for you to ping me if you have a patch and need a bug opening (I've done this for colleagues at Red Hat), but as Dalibor mentions in response, the OCA needs to be sorted first. There's not much point opening a bug with a patch if the patch can't be committed for legal reasons. > > Thanks for your time and consideration, > Quanah > > -- > > Quanah Gibson-Mount > Platform Architect > Zimbra, Inc. > -------------------- > Zimbra :: the leader in open source messaging and collaboration > [0] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-September/004212.html Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From gnu.andrew at redhat.com Fri Nov 20 03:36:57 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 19 Nov 2015 22:36:57 -0500 (EST) Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <564E94A7.7030700@oracle.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> <564DEE33.5000402@oracle.com> <1447953699.4010.45.camel@redhat.com> <564E0CA7.1040302@oracle.com> <808044557.12110864.1447989514323.JavaMail.zimbra@redhat.com> <564E94A7.7030700@oracle.com> Message-ID: <1159453317.12112720.1447990617014.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Related 8074552 and 8075533 are not backported to 8u. > So I would suggest to push your point fix with new bug id (and link it to > 8075967) > > https://bugs.openjdk.java.net/browse/JDK-8074552 > https://bugs.openjdk.java.net/browse/JDK-8075533 > Yes, I agree that sounds like the safest option. My impression of the original changeset is that this really should been a separate bug to begin with; the change is unrelated to the rest. I'll prepare such a bug tomorrow. > Thanks, > Vladimir > > On 11/19/15 7:18 PM, Andrew Hughes wrote: > > ----- Original Message ----- > >> http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot > >> > >> On 11/19/15 9:21 AM, Severin Gehwolf wrote: > >>> On Thu, 2015-11-19 at 15:43 +0000, Rob McKenna wrote: > >>>> Correct. You need a sponsor. Perhaps Andrew would be willing to help? > >>>> Failing that please work with the hotspot group. > >>> > >>> Thanks, Rob. > >>> > >>> Hotspot people: To which JDK 8 tree should this get pushed? Andrew, > >>> tells me that he can push it for me once we know where :) > >>> > >>> Thanks, > >>> Severin > >>> > >>>> -Rob > >>>> > >>>> On 19/11/15 09:41, Severin Gehwolf wrote: > >>>>> On Wed, 2015-11-18 at 21:08 +0000, Rob McKenna wrote: > >>>>>> Approved. Please add a suitable noreg label to the bug. > >>>>>> > >>>>>> -Rob > >>>>> > >>>>> Another question: Wouldn't I need a sponsor to get this integrated? > >>>>> Is > >>>>> this being taken care of automatically? > >>>>> > >>>>> Thanks for your help! > >>>>> > >>>>> Cheers, > >>>>> Severin > >>>>> > >>>>>> On 18/11/15 10:50, Severin Gehwolf wrote: > >>>>>>> Hi, > >>>>>>> > >>>>>>> I'd like to ask for approval of a Zero-specific hotspot 8 > >>>>>>> backport. > >>>>>>> Currently, the jdk8u forest fails to build the Zero variant > >>>>>>> with > >>>>>>> GCC 5 > >>>>>>> due to this: > >>>>>>> > >>>>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:59:10: error: > >>>>>>> function > >>>>>>> returns address of local variable [-Werror=return-local-addr] > >>>>>>> return dummy; > >>>>>>> ^ > >>>>>>> src/os_cpu/linux_zero/vm/os_linux_zero.cpp:58:11: note: > >>>>>>> declared > >>>>>>> here > >>>>>>> address dummy = (address) &dummy; > >>>>>>> ^ > >>>>>>> Note: Fedora 22+ have GCC 5. The above problem and the actual > >>>>>>> overflow > >>>>>>> bug (if warning is ignored at build time + on relevant arch) > >>>>>>> goes > >>>>>>> away > >>>>>>> when JDK-8087120 gets backported to 8u. > >>>>>>> > >>>>>>> Original Bug: https://bugs.openjdk.java.net/browse/JDK-8087120 > >>>>>>> 9 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8087 > >>>>>>> 120/ > >>>>>>> webrev.01/ > >>>>>>> 9 review thread: http://mail.openjdk.java.net/pipermail/hotspot > >>>>>>> -dev > >>>>>>> /2015-June/018884.html > >>>>>>> > >>>>>>> The 9 webrev applies with no change to the 8 forest. I'd need > >>>>>>> somebody > >>>>>>> to sponsor this for me. > >>>>>>> > >>>>>>> Thanks, > >>>>>>> Severin > >>>>>>> > >>>>> > >>> > >> > > > > Built: > > > > $ /mnt/builder/jdk8u-dev/images/j2sdk-image/bin/java -version > > openjdk version "1.8.0-internal" > > OpenJDK Runtime Environment (build > > 1.8.0-internal-andre_2015_11_20_01_48-b00) > > OpenJDK 64-Bit Zero VM (build 25.66-b00, interpreted mode) > > > > with GCC 5.1.0 and pushed the change: > > > > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c6ef40024aa2 > > > > An extra fix was needed to make it build, taken from 8075967: > > > > diff -r c6ef40024aa2 src/cpu/zero/vm/frame_zero.cpp > > --- a/src/cpu/zero/vm/frame_zero.cpp Fri Jun 12 16:09:45 2015 +0100 > > +++ b/src/cpu/zero/vm/frame_zero.cpp Fri Nov 20 03:17:01 2015 +0000 > > @@ -1,5 +1,5 @@ > > /* > > - * Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights > > reserved. > > + * Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights > > reserved. > > * Copyright 2007, 2008, 2009, 2010, 2011 Red Hat, Inc. > > * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. > > * > > @@ -216,7 +216,7 @@ > > valuebuf[buflen - 1] = '\0'; > > > > // Print the result > > - st->print_cr(" " PTR_FORMAT ": %-21s = %s", addr, fieldbuf, valuebuf); > > + st->print_cr(" " PTR_FORMAT ": %-21s = %s", p2i(addr), fieldbuf, > > valuebuf); > > } > > } > > > > I don't know if 8075967 should be backported in full (it contains other > > changes, > > and this seems to have been thrown in there to make it build): > > > > 8075967: Zero interpreter asserts for SafeFetch<32,N> calls in > > ObjectMonitor > > Summary: Implement SafeFetchX unsafely and make CanUseSafeFetchX false for > > Zero > > Reviewed-by: sgehwolf, dholmes > > > > or we should backport just the above under a new bug ID. Thoughts? > > > > Thanks, > > > -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From david.holmes at oracle.com Fri Nov 20 03:51:51 2015 From: david.holmes at oracle.com (David Holmes) Date: Fri, 20 Nov 2015 13:51:51 +1000 Subject: Coherent release process In-Reply-To: References: <72EC8BBA6F43AD603B3286DF@[192.168.1.9]> <447666547.12112509.1447990497599.JavaMail.zimbra@redhat.com> Message-ID: <564E98D7.9050504@oracle.com> Trivial patches can be accepted without the provider being an OCA signatory. However the patch must be provided using OpenJDK technology so it can't be taken from an external website, but if small enough should be included inline in an email message. Thanks, David On 20/11/2015 1:45 PM, Quanah Gibson-Mount wrote: > > --On Thursday, November 19, 2015 10:34 PM -0500 Andrew Hughes > wrote: > >> [Adding in the 8u mailing list] >> >> ----- Original Message ----- >>> Hi, > > Hi Andrew, > > Thanks for the follow up! > > >> Actually, that won't get you u66 unless you explicitly check out a tag. >> The current tip of 8u is currently receiving fixes people are pushing for >> u76, which I believe is due to be released next April, at the same time >> as the u75 security update, which will be based on u72. > > Yes, I use a tag for building. However, that process is completely > unreliable UNLESS you use my patch, because the tag is not passed down > when pulling out the sub modules, which means you get mismatched code. > I.e., without my patch, you cannot build a consistent OpenJDK release > against a specific tag. > >>> >>> >>> As we rely heavily on being able to provide up to date, consistent, >>> secure OpenJDK builds to our customers, having the process to build new >>> releases be reliable is of significant importance. I imagine that is >>> the case for many others as well. >> >> Another problem I've also observed. I'm happy for you to ping me if you >> have a patch and need a bug opening (I've done this for colleagues at Red >> Hat), but as Dalibor mentions in response, the OCA needs to be sorted >> first. There's not much point opening a bug with a patch if the patch >> can't be committed for legal reasons. > > I can't see why it'd be a problem to have the patch committed. It's > literally modifying hgforest.sh to include the ${command_args} command > line options that were originally passed get_source.sh. Again, without > this patch, there is literally no way to build OpenJDK where all > portions of the checkout from mercurial are fixed to a given tag. > > --Quanah > > -- > > Quanah Gibson-Mount > Platform Architect > Zimbra, Inc. > -------------------- > Zimbra :: the leader in open source messaging and collaboration From sgehwolf at redhat.com Fri Nov 20 10:42:08 2015 From: sgehwolf at redhat.com (Severin Gehwolf) Date: Fri, 20 Nov 2015 11:42:08 +0100 Subject: [8u] Request for approval: 8087120: [GCC5] java.lang.StackOverflowError on Zero JVM initialization on non x86 platforms In-Reply-To: <808044557.12110864.1447989514323.JavaMail.zimbra@redhat.com> References: <1447843821.3660.11.camel@redhat.com> <564CE8CF.4020302@oracle.com> <1447926080.4010.8.camel@redhat.com> <564DEE33.5000402@oracle.com> <1447953699.4010.45.camel@redhat.com> <564E0CA7.1040302@oracle.com> <808044557.12110864.1447989514323.JavaMail.zimbra@redhat.com> Message-ID: <1448016128.5038.1.camel@redhat.com> On Thu, 2015-11-19 at 22:18 -0500, Andrew Hughes wrote: > Built: > > $ /mnt/builder/jdk8u-dev/images/j2sdk-image/bin/java??-version > openjdk version "1.8.0-internal" > OpenJDK Runtime Environment (build 1.8.0-internal- > andre_2015_11_20_01_48-b00) > OpenJDK 64-Bit Zero VM (build 25.66-b00, interpreted mode) > > with GCC 5.1.0 and pushed the change: > > http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/c6ef40024aa2 Thanks, Andrew! Cheers, Severin From vladimir.x.ivanov at oracle.com Fri Nov 20 10:53:46 2015 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Fri, 20 Nov 2015 13:53:46 +0300 Subject: Result: CFV: New JDK8u Committer: Michael Haupt Message-ID: <564EFBBA.8080406@oracle.com> Voting for Michael Haupt [1] is now closed. Yes: 20 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Best regards, Vladimir Ivanov [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-November/004441.html From thomas.schatzl at oracle.com Fri Nov 20 11:04:51 2015 From: thomas.schatzl at oracle.com (Thomas Schatzl) Date: Fri, 20 Nov 2015 12:04:51 +0100 Subject: [8u] Request for approval for CR 8138966 - Intermittent SEGV running ParallelGC Message-ID: <1448017491.2289.27.camel@oracle.com> Hello, can I have approval for the backport of JDK-8138966: Intermittent SEGV running ParallelGC. This issue fixes crashes on non-TSO platforms with parallel GC by adding necessary memory barriers (which are NOPs on TSO platforms). CR: https://bugs.openjdk.java.net/browse/JDK-8138966 JDK9 - Review thread link: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2015-October/015161.html JDK8u - Review thread link: n/a. Applies cleanly apart from path changes in the patch. This was due to directory restructuring in JDK9 that is unrelated to this change. JDK9 changeset link: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/d5e5e9f4fc04 (pushed into group repos 11/04) (JDK8u webrev for completeness) http://cr.openjdk.java.net/~aph/8138966/jdk8/ Thanks, Thomas From michael.haupt at oracle.com Fri Nov 20 12:11:27 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Fri, 20 Nov 2015 13:11:27 +0100 Subject: Result: CFV: New JDK8u Committer: Michael Haupt In-Reply-To: <564EFBBA.8080406@oracle.com> References: <564EFBBA.8080406@oracle.com> Message-ID: <1CF1DAF0-1CBA-4C19-9464-5D4C63E553A5@oracle.com> ... thank you, Vladimir and all voters! Best, Michael > Am 20.11.2015 um 11:53 schrieb Vladimir Ivanov : > > Voting for Michael Haupt [1] is now closed. > > Yes: 20 > Veto: 0 > Abstain: 0 > > According to the Bylaws definition of Three-Vote Consensus, this is > sufficient to approve the nomination. > > Best regards, > Vladimir Ivanov > > [1] http://mail.openjdk.java.net/pipermail/jdk8u-dev/2015-November/004441.html -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany Oracle is committed to developing practices and products that help protect the environment From dmitry.markov at oracle.com Fri Nov 20 12:48:24 2015 From: dmitry.markov at oracle.com (dmitry markov) Date: Fri, 20 Nov 2015 15:48:24 +0300 Subject: [8u-dev] Request for approval 8052396: Catch exceptions resulting from missing font cmap Message-ID: <564F1698.40802@oracle.com> Hello, Could you approve the back-port of the fix for 8052396 to jdk8u-dev, please? The jdk9 patch applies cleanly. The bug: https://bugs.openjdk.java.net/browse/JDK-8052396 The webrev: http://cr.openjdk.java.net/~dmarkov/8052396/jdk8u/webrev.00/ The review thread: http://mail.openjdk.java.net/pipermail/2d-dev/2014-July/004705.html The jdk9 changeset: http://hg.openjdk.java.net/jdk9/client/jdk/rev/3a643c6ec1c1 Thanks, Dmitry From david.buck at oracle.com Fri Nov 20 13:26:54 2015 From: david.buck at oracle.com (david buck) Date: Fri, 20 Nov 2015 22:26:54 +0900 Subject: [8u] Request for approval for CR 8138966 - Intermittent SEGV running ParallelGC In-Reply-To: <1448017491.2289.27.camel@oracle.com> References: <1448017491.2289.27.camel@oracle.com> Message-ID: <564F1F9E.9000200@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2015/11/20 20:04, Thomas Schatzl wrote: > Hello, > > can I have approval for the backport of JDK-8138966: Intermittent SEGV > running ParallelGC. > > This issue fixes crashes on non-TSO platforms with parallel GC by adding > necessary memory barriers (which are NOPs on TSO platforms). > > CR: > https://bugs.openjdk.java.net/browse/JDK-8138966 > > JDK9 - Review thread link: > http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2015-October/015161.html > > JDK8u - Review thread link: > n/a. Applies cleanly apart from path changes in the patch. This was due > to directory restructuring in JDK9 that is unrelated to this change. > > JDK9 changeset link: > http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/d5e5e9f4fc04 (pushed > into group repos 11/04) > > (JDK8u webrev for completeness) > http://cr.openjdk.java.net/~aph/8138966/jdk8/ > > Thanks, > Thomas > > > From naoto.sato at oracle.com Sat Nov 21 00:42:14 2015 From: naoto.sato at oracle.com (Naoto Sato) Date: Fri, 20 Nov 2015 16:42:14 -0800 Subject: [8u-dev] Request for approval 8052396: Catch exceptions resulting from missing font cmap In-Reply-To: <564F1698.40802@oracle.com> References: <564F1698.40802@oracle.com> Message-ID: <564FBDE6.9010902@oracle.com> Approved. Naoto On 11/20/15 4:48 AM, dmitry markov wrote: > Hello, > > Could you approve the back-port of the fix for 8052396 to jdk8u-dev, > please? The jdk9 patch applies cleanly. > > The bug: > https://bugs.openjdk.java.net/browse/JDK-8052396 > The webrev: > http://cr.openjdk.java.net/~dmarkov/8052396/jdk8u/webrev.00/ > The review thread: > http://mail.openjdk.java.net/pipermail/2d-dev/2014-July/004705.html > The jdk9 changeset: > http://hg.openjdk.java.net/jdk9/client/jdk/rev/3a643c6ec1c1 > > Thanks, > Dmitry From michael.haupt at oracle.com Mon Nov 23 09:21:20 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Mon, 23 Nov 2015 10:21:20 +0100 Subject: [8u-dev] Request for approval: 8143297: Nashorn compilation time reported in nanoseconds Message-ID: Dear all, please approve this backport. Bug: https://bugs.openjdk.java.net/browse/JDK-8143297 JDK 9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-November/005585.html The patch applies successfully after path adaption with an offset of -1, hence here's a webrev FTR: http://cr.openjdk.java.net/~mhaupt/8143297-8u/webrev.00 Thanks, Michael -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany Oracle is committed to developing practices and products that help protect the environment From sean.coffey at oracle.com Mon Nov 23 09:36:52 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Mon, 23 Nov 2015 09:36:52 +0000 Subject: [8u-dev] Request for approval: 8143297: Nashorn compilation time reported in nanoseconds In-Reply-To: References: Message-ID: <5652DE34.3010406@oracle.com> Approved. Regards, Sean. On 23/11/2015 09:21, Michael Haupt wrote: > Dear all, > > please approve this backport. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8143297 > JDK 9 review thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-November/005585.html > > The patch applies successfully after path adaption with an offset of -1, hence here's a webrev FTR: http://cr.openjdk.java.net/~mhaupt/8143297-8u/webrev.00 > > Thanks, > > Michael > From gnu.andrew at redhat.com Tue Nov 24 01:08:18 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Mon, 23 Nov 2015 20:08:18 -0500 (EST) Subject: [8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp In-Reply-To: <622107090.15904614.1448326553019.JavaMail.zimbra@redhat.com> Message-ID: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8143855/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8143855 The Zero build is broken on current 8u, due to one of the arguments to a print_cr statement being of the wrong type. This was already fixed in OpenJDK 9 as part of 8075967 [0] [1]. The above webrev is a backport of just the required frame_zero.cpp change from that changeset, which applies as-is on OpenJDK 8. Ok to push to 8? [0] https://bugs.openjdk.java.net/browse/JDK-8075967 [1] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2206bbeb318569e Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From sean.coffey at oracle.com Tue Nov 24 10:57:58 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Tue, 24 Nov 2015 10:57:58 +0000 Subject: [8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp In-Reply-To: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> References: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> Message-ID: <565442B6.2080207@oracle.com> Can you add the 'regression' and '9-na' labels to the 8143855 bug report also ? A noreg label should also be added [1]. Approved for jdk8u-dev but subject to code review given that this is not a direct JDK 9 backport. (cc'ing Coleen) [1] http://openjdk.java.net/guide/changePlanning.html#noreg Regards, Sean. On 24/11/2015 01:08, Andrew Hughes wrote: > Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8143855/webrev.01/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8143855 > > The Zero build is broken on current 8u, due to one of the arguments to > a print_cr statement being of the wrong type. This was already fixed > in OpenJDK 9 as part of 8075967 [0] [1]. The above webrev is a backport > of just the required frame_zero.cpp change from that changeset, which > applies as-is on OpenJDK 8. > > Ok to push to 8? > > [0] https://bugs.openjdk.java.net/browse/JDK-8075967 > [1] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2206bbeb318569e > > Thanks, From rob.mckenna at oracle.com Tue Nov 24 16:37:52 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Tue, 24 Nov 2015 16:37:52 +0000 Subject: Request for review & approval: 8141260: isReachable crash in windows xp Message-ID: <56549260.9040700@oracle.com> Hi folks, The recently updated ICMP (8133015) code fails on Windows XP due to a missing api. This fix allows XP to fall back to the old tcp based method: https://bugs.openjdk.java.net/browse/JDK-8141260 http://cr.openjdk.java.net/~robm/8141260/webrev.01/ -Rob From gnu.andrew at redhat.com Wed Nov 25 02:34:53 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 24 Nov 2015 21:34:53 -0500 (EST) Subject: [8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp In-Reply-To: <565442B6.2080207@oracle.com> References: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> <565442B6.2080207@oracle.com> Message-ID: <500014055.16874374.1448418893914.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Can you add the 'regression' and '9-na' labels to the 8143855 bug report > also ? > A noreg label should also be added [1]. > Done. Thanks for the link to this updated guide page. This is the first time I've seen it. It is a little unclear when it suggests setting the status to Open; it is not possible to set the status directly, instead 'Triage' has to be clicked to change NEW -> OPEN. > Approved for jdk8u-dev but subject to code review given that this is not > a direct JDK 9 backport. (cc'ing Coleen) Ok, but this is just a subset of the original changeset. Arguably, it should have been a separate changeset to begin with as these changes have nothing to do with the rest of it. The line in question hasn't been changed since it was introduced with the import of the Zero port in 2009, but new build flags and/or compilers have triggered this latest warning. > > [1] http://openjdk.java.net/guide/changePlanning.html#noreg > > Regards, > Sean. > > On 24/11/2015 01:08, Andrew Hughes wrote: > > Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8143855/webrev.01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8143855 > > > > The Zero build is broken on current 8u, due to one of the arguments to > > a print_cr statement being of the wrong type. This was already fixed > > in OpenJDK 9 as part of 8075967 [0] [1]. The above webrev is a backport > > of just the required frame_zero.cpp change from that changeset, which > > applies as-is on OpenJDK 8. > > > > Ok to push to 8? > > > > [0] https://bugs.openjdk.java.net/browse/JDK-8075967 > > [1] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2206bbeb318569e > > > > Thanks, > > -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From sean.coffey at oracle.com Wed Nov 25 08:20:04 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 25 Nov 2015 08:20:04 +0000 Subject: [8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp In-Reply-To: <500014055.16874374.1448418893914.JavaMail.zimbra@redhat.com> References: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> <565442B6.2080207@oracle.com> <500014055.16874374.1448418893914.JavaMail.zimbra@redhat.com> Message-ID: <56556F34.8000905@oracle.com> On 25/11/2015 02:34, Andrew Hughes wrote: > ----- Original Message ----- >> Can you add the 'regression' and '9-na' labels to the 8143855 bug report >> also ? >> A noreg label should also be added [1]. >> > Done. Thanks for the link to this updated guide page. This is the first > time I've seen it. It is a little unclear when it suggests setting the > status to Open; it is not possible to set the status directly, instead > 'Triage' has to be clicked to change NEW -> OPEN. I'll see if we get a link to the JBS state model inserted after this point (state model : https://wiki.openjdk.java.net/display/general/JBS+Overview) > >> Approved for jdk8u-dev but subject to code review given that this is not >> a direct JDK 9 backport. (cc'ing Coleen) > Ok, but this is just a subset of the original changeset. Arguably, it > should have been a separate changeset to begin with as these changes > have nothing to do with the rest of it. The line in question hasn't > been changed since it was introduced with the import of the Zero port > in 2009, but new build flags and/or compilers have triggered this latest > warning. I agree the change is small and safe, but I've seen failures before where parts of a fix are pulled into other releases. For the sake of consistency, it should be reviewed. Hopefully that can be done quickly by Coleen or any other jdk8u reviewer. regards, Sean. > >> [1] http://openjdk.java.net/guide/changePlanning.html#noreg >> >> Regards, >> Sean. >> >> On 24/11/2015 01:08, Andrew Hughes wrote: >>> Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8143855/webrev.01/ >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8143855 >>> >>> The Zero build is broken on current 8u, due to one of the arguments to >>> a print_cr statement being of the wrong type. This was already fixed >>> in OpenJDK 9 as part of 8075967 [0] [1]. The above webrev is a backport >>> of just the required frame_zero.cpp change from that changeset, which >>> applies as-is on OpenJDK 8. >>> >>> Ok to push to 8? >>> >>> [0] https://bugs.openjdk.java.net/browse/JDK-8075967 >>> [1] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2206bbeb318569e >>> >>> Thanks, >> From david.holmes at oracle.com Wed Nov 25 08:46:49 2015 From: david.holmes at oracle.com (David Holmes) Date: Wed, 25 Nov 2015 18:46:49 +1000 Subject: [8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp In-Reply-To: <56556F34.8000905@oracle.com> References: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> <565442B6.2080207@oracle.com> <500014055.16874374.1448418893914.JavaMail.zimbra@redhat.com> <56556F34.8000905@oracle.com> Message-ID: <56557579.2090908@oracle.com> Reviewed. This is an exact backport of the change to the file src/cpu/zero/vm/frame_zero.cpp David On 25/11/2015 6:20 PM, Se?n Coffey wrote: > On 25/11/2015 02:34, Andrew Hughes wrote: >> ----- Original Message ----- >>> Can you add the 'regression' and '9-na' labels to the 8143855 bug report >>> also ? >>> A noreg label should also be added [1]. >>> >> Done. Thanks for the link to this updated guide page. This is the first >> time I've seen it. It is a little unclear when it suggests setting the >> status to Open; it is not possible to set the status directly, instead >> 'Triage' has to be clicked to change NEW -> OPEN. > I'll see if we get a link to the JBS state model inserted after this point > (state model : https://wiki.openjdk.java.net/display/general/JBS+Overview) >> >>> Approved for jdk8u-dev but subject to code review given that this is not >>> a direct JDK 9 backport. (cc'ing Coleen) >> Ok, but this is just a subset of the original changeset. Arguably, it >> should have been a separate changeset to begin with as these changes >> have nothing to do with the rest of it. The line in question hasn't >> been changed since it was introduced with the import of the Zero port >> in 2009, but new build flags and/or compilers have triggered this latest >> warning. > I agree the change is small and safe, but I've seen failures before > where parts of a fix > are pulled into other releases. For the sake of consistency, it should > be reviewed. > > Hopefully that can be done quickly by Coleen or any other jdk8u reviewer. > > regards, > Sean. >> >>> [1] http://openjdk.java.net/guide/changePlanning.html#noreg >>> >>> Regards, >>> Sean. >>> >>> On 24/11/2015 01:08, Andrew Hughes wrote: >>>> Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8143855/webrev.01/ >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8143855 >>>> >>>> The Zero build is broken on current 8u, due to one of the arguments to >>>> a print_cr statement being of the wrong type. This was already fixed >>>> in OpenJDK 9 as part of 8075967 [0] [1]. The above webrev is a backport >>>> of just the required frame_zero.cpp change from that changeset, which >>>> applies as-is on OpenJDK 8. >>>> >>>> Ok to push to 8? >>>> >>>> [0] https://bugs.openjdk.java.net/browse/JDK-8075967 >>>> [1] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2206bbeb318569e >>>> >>>> Thanks, >>> > From ivan.gerasimov at oracle.com Wed Nov 25 13:49:27 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Wed, 25 Nov 2015 16:49:27 +0300 Subject: [8u-dev] Request for approval to backport: 8133207: ParallelProbes.java test fails after changes for JDK-8080115 Message-ID: <5655BC67.4000501@oracle.com> Hello! Would you approve backporting this test fix into 8u-dev? The fix applies cleanly and the fixed test passes, when run in agentvm mode. The label noreg-self is in place. Bug: https://bugs.openjdk.java.net/browse/JDK-8133207 Jdk9 Review: http://mail.openjdk.java.net/pipermail/nio-dev/2015-August/003260.html Jdk9 Change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/e1aa58e9592c Sincerely yours, Ivan From david.buck at oracle.com Wed Nov 25 13:55:47 2015 From: david.buck at oracle.com (david buck) Date: Wed, 25 Nov 2015 22:55:47 +0900 Subject: [8u-dev] Request for approval to backport: 8133207: ParallelProbes.java test fails after changes for JDK-8080115 In-Reply-To: <5655BC67.4000501@oracle.com> References: <5655BC67.4000501@oracle.com> Message-ID: <5655BDE3.6040700@oracle.com> approved for backport to 8u-dev Cheers, -Buck On 2015/11/25 22:49, Ivan Gerasimov wrote: > Hello! > > Would you approve backporting this test fix into 8u-dev? > The fix applies cleanly and the fixed test passes, when run in agentvm > mode. > The label noreg-self is in place. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8133207 > Jdk9 Review: > http://mail.openjdk.java.net/pipermail/nio-dev/2015-August/003260.html > Jdk9 Change: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/e1aa58e9592c > > Sincerely yours, > Ivan From rob.mckenna at oracle.com Wed Nov 25 14:00:06 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Wed, 25 Nov 2015 14:00:06 +0000 Subject: Request for review & approval: 8141260: isReachable crash in windows xp In-Reply-To: <56549260.9040700@oracle.com> References: <56549260.9040700@oracle.com> Message-ID: <5655BEE6.1070006@oracle.com> forgot to cc net-dev -Rob On 24/11/15 16:37, Rob McKenna wrote: > Hi folks, > > The recently updated ICMP (8133015) code fails on Windows XP due to a > missing api. This fix allows XP to fall back to the old tcp based method: > > https://bugs.openjdk.java.net/browse/JDK-8141260 > http://cr.openjdk.java.net/~robm/8141260/webrev.01/ > > -Rob From sean.coffey at oracle.com Wed Nov 25 15:32:06 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Wed, 25 Nov 2015 15:32:06 +0000 Subject: Request for review & approval: 8141260: isReachable crash in windows xp In-Reply-To: <5655BEE6.1070006@oracle.com> References: <56549260.9040700@oracle.com> <5655BEE6.1070006@oracle.com> Message-ID: <5655D476.7080005@oracle.com> Looks ok to me Rob and provides a re-introduction of the old Java_java_net_Inet4AddressImpl_isReachable0 function for XP systems where necessary. Reviewed. Approved for jdk8u-dev also. Regards, Sean. On 25/11/15 14:00, Rob McKenna wrote: > forgot to cc net-dev > > -Rob > > On 24/11/15 16:37, Rob McKenna wrote: >> Hi folks, >> >> The recently updated ICMP (8133015) code fails on Windows XP due to a >> missing api. This fix allows XP to fall back to the old tcp based >> method: >> >> https://bugs.openjdk.java.net/browse/JDK-8141260 >> http://cr.openjdk.java.net/~robm/8141260/webrev.01/ >> >> -Rob From mark.sheppard at oracle.com Wed Nov 25 18:27:49 2015 From: mark.sheppard at oracle.com (Mark Sheppard) Date: Wed, 25 Nov 2015 18:27:49 +0000 Subject: Request for review & approval: 8141260: isReachable crash in windows xp In-Reply-To: <5655D476.7080005@oracle.com> References: <56549260.9040700@oracle.com> <5655BEE6.1070006@oracle.com> <5655D476.7080005@oracle.com> Message-ID: <5655FDA5.3050501@oracle.com> yes, the fix looks fine, and I verified the individual isReachable test on the test host where it failed. it is possible to refactor the function Java_java_net_Inet4AddressImpl_isReachable0 a little, by extracting the newly re-introduced "else" block into its own function e.g. wxp_ping4 such that if (isVistaSP1OrGreater()) { jint src_addr = 0; jint dest_addr = 0; jbyte caddr[4]; int sz; /** * Convert IP address from byte array to integer */ sz = (*env)->GetArrayLength(env, addrArray); if (sz != 4) { return JNI_FALSE; } memset((char *) caddr, 0, sizeof(caddr)); (*env)->GetByteArrayRegion(env, addrArray, 0, 4, caddr); dest_addr = ((caddr[0]<<24) & 0xff000000); dest_addr |= ((caddr[1] <<16) & 0xff0000); dest_addr |= ((caddr[2] <<8) & 0xff00); dest_addr |= (caddr[3] & 0xff); dest_addr = htonl(dest_addr); /** * If a network interface was specified, let's convert its address * as well. */ if (!(IS_NULL(ifArray))) { memset((char *) caddr, 0, sizeof(caddr)); (*env)->GetByteArrayRegion(env, ifArray, 0, 4, caddr); src_addr = ((caddr[0]<<24) & 0xff000000); src_addr |= ((caddr[1] <<16) & 0xff0000); src_addr |= ((caddr[2] <<8) & 0xff00); src_addr |= (caddr[3] & 0xff); src_addr = htonl(src_addr); } return ping4(env, src_addr, dest_addr, timeout); } else { wxp_ping4(env, this, addrArray, timeout, ifArray, ttl) } regards Mark On 25/11/2015 15:32, Se?n Coffey wrote: > Looks ok to me Rob and provides a re-introduction of the old > Java_java_net_Inet4AddressImpl_isReachable0 function for XP systems > where necessary. Reviewed. > > Approved for jdk8u-dev also. > > Regards, > Sean. > > On 25/11/15 14:00, Rob McKenna wrote: >> forgot to cc net-dev >> >> -Rob >> >> On 24/11/15 16:37, Rob McKenna wrote: >>> Hi folks, >>> >>> The recently updated ICMP (8133015) code fails on Windows XP due to a >>> missing api. This fix allows XP to fall back to the old tcp based >>> method: >>> >>> https://bugs.openjdk.java.net/browse/JDK-8141260 >>> http://cr.openjdk.java.net/~robm/8141260/webrev.01/ >>> >>> -Rob > From rob.mckenna at oracle.com Thu Nov 26 00:54:41 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Thu, 26 Nov 2015 00:54:41 +0000 Subject: Request for review & approval: 8141260: isReachable crash in windows xp In-Reply-To: <5655FDA5.3050501@oracle.com> References: <56549260.9040700@oracle.com> <5655BEE6.1070006@oracle.com> <5655D476.7080005@oracle.com> <5655FDA5.3050501@oracle.com> Message-ID: <56565851.5080307@oracle.com> Sounds good Mark, will do pre-push, cheers. -Rob On 25/11/15 18:27, Mark Sheppard wrote: > yes, the fix looks fine, and I verified the individual isReachable test > on the test host where it failed. > > it is possible to refactor the function > > Java_java_net_Inet4AddressImpl_isReachable0 > > a little, by extracting the newly re-introduced "else" block into its > own function > e.g. wxp_ping4 > > such that > > if (isVistaSP1OrGreater()) { > jint src_addr = 0; > jint dest_addr = 0; > jbyte caddr[4]; > int sz; > > /** > * Convert IP address from byte array to integer > */ > sz = (*env)->GetArrayLength(env, addrArray); > if (sz != 4) { > return JNI_FALSE; > } > memset((char *) caddr, 0, sizeof(caddr)); > (*env)->GetByteArrayRegion(env, addrArray, 0, 4, caddr); > dest_addr = ((caddr[0]<<24) & 0xff000000); > dest_addr |= ((caddr[1] <<16) & 0xff0000); > dest_addr |= ((caddr[2] <<8) & 0xff00); > dest_addr |= (caddr[3] & 0xff); > dest_addr = htonl(dest_addr); > > /** > * If a network interface was specified, let's convert its address > * as well. > */ > if (!(IS_NULL(ifArray))) { > memset((char *) caddr, 0, sizeof(caddr)); > (*env)->GetByteArrayRegion(env, ifArray, 0, 4, caddr); > src_addr = ((caddr[0]<<24) & 0xff000000); > src_addr |= ((caddr[1] <<16) & 0xff0000); > src_addr |= ((caddr[2] <<8) & 0xff00); > src_addr |= (caddr[3] & 0xff); > src_addr = htonl(src_addr); > } > > return ping4(env, src_addr, dest_addr, timeout); > } else { > wxp_ping4(env, this, addrArray, timeout, ifArray, ttl) > } > > > > regards > Mark > > On 25/11/2015 15:32, Se?n Coffey wrote: >> Looks ok to me Rob and provides a re-introduction of the old >> Java_java_net_Inet4AddressImpl_isReachable0 function for XP systems >> where necessary. Reviewed. >> >> Approved for jdk8u-dev also. >> >> Regards, >> Sean. >> >> On 25/11/15 14:00, Rob McKenna wrote: >>> forgot to cc net-dev >>> >>> -Rob >>> >>> On 24/11/15 16:37, Rob McKenna wrote: >>>> Hi folks, >>>> >>>> The recently updated ICMP (8133015) code fails on Windows XP due to a >>>> missing api. This fix allows XP to fall back to the old tcp based >>>> method: >>>> >>>> https://bugs.openjdk.java.net/browse/JDK-8141260 >>>> http://cr.openjdk.java.net/~robm/8141260/webrev.01/ >>>> >>>> -Rob >> > From gnu.andrew at redhat.com Thu Nov 26 03:41:53 2015 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 25 Nov 2015 22:41:53 -0500 (EST) Subject: [8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp In-Reply-To: <56557579.2090908@oracle.com> References: <1209153997.15910494.1448327298700.JavaMail.zimbra@redhat.com> <565442B6.2080207@oracle.com> <500014055.16874374.1448418893914.JavaMail.zimbra@redhat.com> <56556F34.8000905@oracle.com> <56557579.2090908@oracle.com> Message-ID: <1541140070.17605230.1448509313361.JavaMail.zimbra@redhat.com> ----- Original Message ----- > Reviewed. > > This is an exact backport of the change to the file > src/cpu/zero/vm/frame_zero.cpp > > David Thanks, David. I pushed this fix: http://hg.openjdk.java.net/jdk8u/jdk8u-dev/hotspot/rev/4a4a5b8b3dfe -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07 From goetz.lindenmaier at sap.com Fri Nov 27 10:08:13 2015 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 27 Nov 2015 10:08:13 +0000 Subject: [8u-dev] Request for approval to backport: 8139421: PPC64LE: MacroAssembler::bxx64_patchable kill register R12 Message-ID: <4295855A5C1DE049A61835A1887419CC41ED4D23@DEWDFEMB12A.global.corp.sap> Hi I would like to backport this fix for PPC64le to 8u-dev: 8139421: PPC64LE: MacroAssembler::bxx64_patchable kill register R12 http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/c6a1e7983723 http://cr.openjdk.java.net/~mdoerr/8139421_PPC64LE_R12/webrev.00/ http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-October/019327.html It is ppc64-only, so I don't need a sponsor. Please approve this backport. Best regards, Goetz. From goetz.lindenmaier at sap.com Fri Nov 27 10:09:44 2015 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 27 Nov 2015 10:09:44 +0000 Subject: [8u-dev] Request for approval to backport: 8139258: PPC64LE: argument passing problem when passing 15 floats in native call Message-ID: <4295855A5C1DE049A61835A1887419CC41ED4D34@DEWDFEMB12A.global.corp.sap> Hi I would like to backport this fix for PPC64le to 8u-dev: 8139258: PPC64LE: argument passing problem when passing 15 floats in native call http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4149ec42e1a6 http://cr.openjdk.java.net/~asmundak/8139258/hotspot/webrev.02/ http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-November/020641.html It is ppc64-only, so I don't need a sponsor. Please approve this backport. Best regards, Goetz. From sean.coffey at oracle.com Fri Nov 27 10:26:57 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 27 Nov 2015 10:26:57 +0000 Subject: [8u-dev] Request for approval to backport: 8139421: PPC64LE: MacroAssembler::bxx64_patchable kill register R12 In-Reply-To: <4295855A5C1DE049A61835A1887419CC41ED4D23@DEWDFEMB12A.global.corp.sap> References: <4295855A5C1DE049A61835A1887419CC41ED4D23@DEWDFEMB12A.global.corp.sap> Message-ID: <56582FF1.4040504@oracle.com> Please add a suitable noreg label to the master bug report. http://openjdk.java.net/guide/changePlanning.html#noreg Approved for jdk8u-dev. Regards, Sean. On 27/11/15 10:08, Lindenmaier, Goetz wrote: > Hi > > I would like to backport this fix for PPC64le to 8u-dev: > 8139421: PPC64LE: MacroAssembler::bxx64_patchable kill register R12 > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/c6a1e7983723 > http://cr.openjdk.java.net/~mdoerr/8139421_PPC64LE_R12/webrev.00/ > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015-October/019327.html > > It is ppc64-only, so I don't need a sponsor. > > Please approve this backport. > > Best regards, > Goetz. From sean.coffey at oracle.com Fri Nov 27 10:27:59 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 27 Nov 2015 10:27:59 +0000 Subject: [8u-dev] Request for approval to backport: 8139258: PPC64LE: argument passing problem when passing 15 floats in native call In-Reply-To: <4295855A5C1DE049A61835A1887419CC41ED4D34@DEWDFEMB12A.global.corp.sap> References: <4295855A5C1DE049A61835A1887419CC41ED4D34@DEWDFEMB12A.global.corp.sap> Message-ID: <5658302F.6040703@oracle.com> Please add a noreg label to this test also. Approved. Regards, Sean. On 27/11/15 10:09, Lindenmaier, Goetz wrote: > Hi > > I would like to backport this fix for PPC64le to 8u-dev: > > 8139258: PPC64LE: argument passing problem when passing 15 floats in native call > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4149ec42e1a6 > http://cr.openjdk.java.net/~asmundak/8139258/hotspot/webrev.02/ > http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-November/020641.html > > It is ppc64-only, so I don't need a sponsor. > > Please approve this backport. > > Best regards, > Goetz. > From goetz.lindenmaier at sap.com Fri Nov 27 10:50:40 2015 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 27 Nov 2015 10:50:40 +0000 Subject: [8u-dev] Request for approval to backport: 8139258: PPC64LE: argument passing problem when passing 15 floats in native call In-Reply-To: <5658302F.6040703@oracle.com> References: <4295855A5C1DE049A61835A1887419CC41ED4D34@DEWDFEMB12A.global.corp.sap> <5658302F.6040703@oracle.com> Message-ID: <4295855A5C1DE049A61835A1887419CC41ED4D7B@DEWDFEMB12A.global.corp.sap> Hi, can I use "noreg-other: non-oracle platform"? for this one? Best regards, Goetz. > -----Original Message----- > From: Se?n Coffey [mailto:sean.coffey at oracle.com] > Sent: Freitag, 27. November 2015 11:28 > To: Lindenmaier, Goetz ; jdk8u- > dev at openjdk.java.net > Subject: Re: [8u-dev] Request for approval to backport: 8139258: PPC64LE: > argument passing problem when passing 15 floats in native call > > Please add a noreg label to this test also. > > Approved. > > Regards, > Sean. > > On 27/11/15 10:09, Lindenmaier, Goetz wrote: > > Hi > > > > I would like to backport this fix for PPC64le to 8u-dev: > > > > 8139258: PPC64LE: argument passing problem when passing 15 floats in > native call > > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4149ec42e1a6 > > http://cr.openjdk.java.net/~asmundak/8139258/hotspot/webrev.02/ > > http://mail.openjdk.java.net/pipermail/hotspot-dev/2015- > November/020641.html > > > > It is ppc64-only, so I don't need a sponsor. > > > > Please approve this backport. > > > > Best regards, > > Goetz. > > From goetz.lindenmaier at sap.com Fri Nov 27 11:04:32 2015 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Fri, 27 Nov 2015 11:04:32 +0000 Subject: [8u-dev] Request for approval to backport: 8139421: PPC64LE: MacroAssembler::bxx64_patchable kill register R12 In-Reply-To: <56582FF1.4040504@oracle.com> References: <4295855A5C1DE049A61835A1887419CC41ED4D23@DEWDFEMB12A.global.corp.sap> <56582FF1.4040504@oracle.com> Message-ID: <4295855A5C1DE049A61835A1887419CC41ED4DBC@DEWDFEMB12A.global.corp.sap> Sorry, me again: I set it to noreg-external, the link to test is already mentioned in the bug. I hope that's fine. Best regards, Goetz. > -----Original Message----- > From: Se?n Coffey [mailto:sean.coffey at oracle.com] > Sent: Freitag, 27. November 2015 11:27 > To: Lindenmaier, Goetz ; jdk8u- > dev at openjdk.java.net > Subject: Re: [8u-dev] Request for approval to backport: 8139421: PPC64LE: > MacroAssembler::bxx64_patchable kill register R12 > > Please add a suitable noreg label to the master bug report. > http://openjdk.java.net/guide/changePlanning.html#noreg > > Approved for jdk8u-dev. > > Regards, > Sean. > > On 27/11/15 10:08, Lindenmaier, Goetz wrote: > > Hi > > > > I would like to backport this fix for PPC64le to 8u-dev: > > 8139421: PPC64LE: MacroAssembler::bxx64_patchable kill register R12 > > http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/c6a1e7983723 > > http://cr.openjdk.java.net/~mdoerr/8139421_PPC64LE_R12/webrev.00/ > > http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2015- > October/019327.html > > > > It is ppc64-only, so I don't need a sponsor. > > > > Please approve this backport. > > > > Best regards, > > Goetz. From sean.coffey at oracle.com Fri Nov 27 11:31:29 2015 From: sean.coffey at oracle.com (=?UTF-8?Q?Se=c3=a1n_Coffey?=) Date: Fri, 27 Nov 2015 11:31:29 +0000 Subject: [8u-dev] Request for approval to backport: 8139258: PPC64LE: argument passing problem when passing 15 floats in native call In-Reply-To: <4295855A5C1DE049A61835A1887419CC41ED4D7B@DEWDFEMB12A.global.corp.sap> References: <4295855A5C1DE049A61835A1887419CC41ED4D34@DEWDFEMB12A.global.corp.sap> <5658302F.6040703@oracle.com> <4295855A5C1DE049A61835A1887419CC41ED4D7B@DEWDFEMB12A.global.corp.sap> Message-ID: <56583F11.2040307@oracle.com> Hey Goetz, I wouldn't single out a PPC fix for no testcase just because it's not an Oracle JDK platform. PPC tests could be added to OpenJDK forest via the @requires jtreg tag if necessary. In any case, I see you've marked this with noreg-external which should be fine. noreg-other would also have been ok to use I guess. Regards, Sean. On 27/11/15 10:50, Lindenmaier, Goetz wrote: > Hi, > > can I use > "noreg-other: non-oracle platform"? > for this one? > > Best regards, > Goetz. > >> -----Original Message----- >> From: Se?n Coffey [mailto:sean.coffey at oracle.com] >> Sent: Freitag, 27. November 2015 11:28 >> To: Lindenmaier, Goetz ; jdk8u- >> dev at openjdk.java.net >> Subject: Re: [8u-dev] Request for approval to backport: 8139258: PPC64LE: >> argument passing problem when passing 15 floats in native call >> >> Please add a noreg label to this test also. >> >> Approved. >> >> Regards, >> Sean. >> >> On 27/11/15 10:09, Lindenmaier, Goetz wrote: >>> Hi >>> >>> I would like to backport this fix for PPC64le to 8u-dev: >>> >>> 8139258: PPC64LE: argument passing problem when passing 15 floats in >> native call >>> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/4149ec42e1a6 >>> http://cr.openjdk.java.net/~asmundak/8139258/hotspot/webrev.02/ >>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015- >> November/020641.html >>> It is ppc64-only, so I don't need a sponsor. >>> >>> Please approve this backport. >>> >>> Best regards, >>> Goetz. >>> From michael.haupt at oracle.com Mon Nov 30 10:45:34 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Mon, 30 Nov 2015 11:45:34 +0100 Subject: [8u-dev] Request for approval: 8131129: Attempt to define a duplicate BMH$Species class Message-ID: <98C721A1-A2B0-4F55-95F6-BBF10E46AB19@oracle.com> Dear all, please approve this backport. Bug: https://bugs.openjdk.java.net/browse/JDK-8131129 JDK 9 review thread (long): http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-October/036109.html Patch adopted in JDK 9: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7ad9bc01099b The patch applies cleanly after path adaption. Webrev FTR: http://cr.openjdk.java.net/~mhaupt/8131129-8u/webrev.00/ Thanks, Michael -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany Oracle is committed to developing practices and products that help protect the environment From david.buck at oracle.com Mon Nov 30 11:13:04 2015 From: david.buck at oracle.com (david buck) Date: Mon, 30 Nov 2015 20:13:04 +0900 Subject: [8u-dev] Request for approval: 8131129: Attempt to define a duplicate BMH$Species class In-Reply-To: <98C721A1-A2B0-4F55-95F6-BBF10E46AB19@oracle.com> References: <98C721A1-A2B0-4F55-95F6-BBF10E46AB19@oracle.com> Message-ID: <565C2F40.7080507@oracle.com> approved for backport to jdk8u-dev Please be sure to add the appropriate noreg label (maybe noreg-sqe for this one?) to the bug report: [ noreg bug labels ] http://openjdk.java.net/guide/changePlanning.html#noreg As the review thread spans both October and November, we should have links to both archives in this request thread, otherwise the actual approvals get left out. http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-November/036272.html Cheers, -Buck On 2015/11/30 19:45, Michael Haupt wrote: > Dear all, > > please approve this backport. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8131129 > JDK 9 review thread (long): http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-October/036109.html > Patch adopted in JDK 9: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7ad9bc01099b > > The patch applies cleanly after path adaption. Webrev FTR: http://cr.openjdk.java.net/~mhaupt/8131129-8u/webrev.00/ > > Thanks, > > Michael > From michael.haupt at oracle.com Mon Nov 30 12:26:22 2015 From: michael.haupt at oracle.com (Michael Haupt) Date: Mon, 30 Nov 2015 13:26:22 +0100 Subject: [8u-dev] Request for approval: 8131129: Attempt to define a duplicate BMH$Species class In-Reply-To: <565C2F40.7080507@oracle.com> References: <98C721A1-A2B0-4F55-95F6-BBF10E46AB19@oracle.com> <565C2F40.7080507@oracle.com> Message-ID: <9DE58ED4-7BC0-4F18-89E0-4F9925853C58@oracle.com> Hi David, thanks - I've added the noreg-sqe label. Best, Michael > Am 30.11.2015 um 12:13 schrieb david buck : > > approved for backport to jdk8u-dev > > Please be sure to add the appropriate noreg label (maybe noreg-sqe for this one?) to the bug report: > > [ noreg bug labels ] > http://openjdk.java.net/guide/changePlanning.html#noreg > > As the review thread spans both October and November, we should have links to both archives in this request thread, otherwise the actual approvals get left out. > > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-November/036272.html > > Cheers, > -Buck > > > On 2015/11/30 19:45, Michael Haupt wrote: >> Dear all, >> >> please approve this backport. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8131129 >> JDK 9 review thread (long): http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-October/036109.html >> Patch adopted in JDK 9: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7ad9bc01099b >> >> The patch applies cleanly after path adaption. Webrev FTR: http://cr.openjdk.java.net/~mhaupt/8131129-8u/webrev.00/ >> >> Thanks, >> >> Michael >> -- Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany Oracle is committed to developing practices and products that help protect the environment From ivan.gerasimov at oracle.com Mon Nov 30 13:12:22 2015 From: ivan.gerasimov at oracle.com (Ivan Gerasimov) Date: Mon, 30 Nov 2015 16:12:22 +0300 Subject: [8u-dev] Request for approval to backport: 8068761: Test java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed with SocketTimeoutException Message-ID: <565C4B36.80200@oracle.com> Hi! I'd like to backport this fix, as the reported test bug is observed with jdk8 from time to time. The patch applies smoothly. Bug: https://bugs.openjdk.java.net/browse/JDK-8068761 Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/9eceb4a5ea96 Jdk9 review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-July/034612.html Sincerely yours, Ivan From rob.mckenna at oracle.com Mon Nov 30 13:13:57 2015 From: rob.mckenna at oracle.com (Rob McKenna) Date: Mon, 30 Nov 2015 13:13:57 +0000 Subject: [8u-dev] Request for approval to backport: 8068761: Test java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed with SocketTimeoutException In-Reply-To: <565C4B36.80200@oracle.com> References: <565C4B36.80200@oracle.com> Message-ID: <565C4B95.3070301@oracle.com> Approved. -Rob On 30/11/15 13:12, Ivan Gerasimov wrote: > Hi! > > I'd like to backport this fix, as the reported test bug is observed with > jdk8 from time to time. > The patch applies smoothly. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8068761 > Jdk9 change: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/9eceb4a5ea96 > Jdk9 review: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-July/034612.html > > Sincerely yours, > Ivan