[8u76] Request for approval for CR 8143855 - Bad printf formatting in frame_zero.cpp

[Andrew Hughes]

----- Original Message -----
> Can you add the 'regression' and '9-na' labels to the 8143855 bug report
> also ?
> A noreg label should also be added [1].
> 

Done. Thanks for the link to this updated guide page. This is the first
time I've seen it. It is a little unclear when it suggests setting the
status to Open; it is not possible to set the status directly, instead
'Triage' has to be clicked to change NEW -> OPEN.

> Approved for jdk8u-dev but subject to code review given that this is not
> a direct JDK 9 backport. (cc'ing Coleen)

Ok, but this is just a subset of the original changeset. Arguably, it
should have been a separate changeset to begin with as these changes
have nothing to do with the rest of it. The line in question hasn't
been changed since it was introduced with the import of the Zero port
in 2009, but new build flags and/or compilers have triggered this latest
warning.

> 
> [1] http://openjdk.java.net/guide/changePlanning.html#noreg
> 
> Regards,
> Sean.
> 
> On 24/11/2015 01:08, Andrew Hughes wrote:
> > Webrev: http://cr.openjdk.java.net/~andrew/openjdk8/8143855/webrev.01/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8143855
> >
> > The Zero build is broken on current 8u, due to one of the arguments to
> > a print_cr statement being of the wrong type. This was already fixed
> > in OpenJDK 9 as part of 8075967 [0] [1]. The above webrev is a backport
> > of just the required frame_zero.cpp change from that changeset, which
> > applies as-is on OpenJDK 8.
> >
> > Ok to push to 8?
> >
> > [0] https://bugs.openjdk.java.net/browse/JDK-8075967
> > [1] http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/2206bbeb318569e
> >
> > Thanks,
> 
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07