[8u] Request for approval and review: 8075805: Crash while trying to release CompiledICHolder

[Vladimir Kozlov]

Nice. Looks good.

Thanks,
Vladimir

On 10/7/15 10:19 PM, Tobias Hartmann wrote:
> Hi Vladimir,
>
> On 07.10.2015 14:43, Vladimir Kozlov wrote:
>> Changes are matching jdk9 changes.
>> Tobias, should we backport 8058737 changes too? Next code is missing in 8u now:
>>
>> +        MutexLocker cl(CompiledIC_lock);
>> +        nm->clear_ic_stubs();
>>
>> It was P2. Why we did not backport it?
>
> Yes, you are right. It seems like I missed to backport that one because it never showed up with 8. However, we should backport it. The patch for JDK-8058737 applies cleanly. I updated the other webrevs:
>
> JDK-8058737: CodeCache::find_blob fails with 'unsafe access to zombie method'
> https://bugs.openjdk.java.net/browse/JDK-8058737
> http://cr.openjdk.java.net/~thartmann/8058737/webrev.01/
>
> JDK-8075805: Crash while trying to release CompiledICHolder
> https://bugs.openjdk.java.net/browse/JDK-8075805
> http://cr.openjdk.java.net/~thartmann/8075805_8u/webrev.01/
>
> JDK-8134493: Cleaning inline caches of unloaded nmethods should be done in sweeper
> https://bugs.openjdk.java.net/browse/JDK-8134493
> http://cr.openjdk.java.net/~thartmann/8134493_8u/webrev.01/
>
> All changes (now also including 8058737) :
> http://cr.openjdk.java.net/~thartmann/8075805_8134493_8u/webrev.01
>
> Thanks,
> Tobias
>
>
>> Thanks,
>> Vladimir
>>
>> On 10/7/15 6:27 PM, Tobias Hartmann wrote:
>>> Hi,
>>>
>>> please approve and review the following backport to 8u.
>>>
>>> 8075805: Crash while trying to release CompiledICHolder
>>> https://bugs.openjdk.java.net/browse/JDK-8075805
>>> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/c0ea5537dc8b
>>> http://cr.openjdk.java.net/~thartmann/8075805/webrev.01/
>>>
>>> I would also like to backport this follow up change that fixes an issue with the fix for 8075805:
>>>
>>> 8134493: Cleaning inline caches of unloaded nmethods should be done in sweeper
>>> https://bugs.openjdk.java.net/browse/JDK-8134493
>>> http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/9df4555d2d7d
>>> http://cr.openjdk.java.net/~thartmann/8134493/webrev.01/
>>>
>>> Unfortunately, both changesets do not apply cleanly to 8u. I merged the fixes, here are the new webrevs:
>>>
>>> JDK-8075805:
>>> http://cr.openjdk.java.net/~thartmann/8075805_8u/webrev.00/
>>>
>>> JDK-8134493 (incremental):
>>> http://cr.openjdk.java.net/~thartmann/8134493_8u/webrev.00/
>>>
>>> Both changes:
>>> http://cr.openjdk.java.net/~thartmann/8075805_8134493_8u/webrev.00/
>>>
>>> Both fixes were pushed some months ago and testing showed no problems.
>>>
>>> Thanks,
>>> Tobias
>>>