[8u-dev] Request for approval - 8135307: CompletionFailure thrown when calling FieldDoc.type, if the field's type is missing

Vicente-Arturo Romero-Zaldivar vicente.romero at oracle.com
Mon Sep 28 17:32:52 UTC 2015


Hi Jan,

It looks OK for me,

Thanks for the fix and the explanation,
Vicente

On 09/28/2015 08:11 AM, Jan Lahoda wrote:
> Hi Vicente,
>
> Good catch - I first created a JDK 7 version of the test (where the 
> ExecutableMemberDoc.receiverType() does not exist, so I had to skip 
> the sub-test), and then used it as the base for the JDK 8 test, and 
> forgot to reinstate the sub-test. A fixed webrev is here:
> http://cr.openjdk.java.net/~jlahoda/8135307-8/webrev.02/
>
> How does it look?
>
> Thanks,
>     Jan
>
> On 25.9.2015 21:09, Vicente-Arturo Romero-Zaldivar wrote:
>> Hi Rob,
>>
>> In test CompletionError, method start() in the switch statement, in the
>> original test there is a code for case 9:, in the backport this code is
>> not there. What's the reason for this?
>>
>> Thanks,
>> Vicente
>>
>> On 09/25/2015 07:11 AM, Rob McKenna wrote:
>>> As this backport did not apply cleanly, I also need a codereview:
>>>
>>> http://cr.openjdk.java.net/~robm/8135307/webrev.01/
>>>
>>>     -Rob
>>>
>>> On 25/09/15 15:03, Rob McKenna wrote:
>>>> Hi folks,
>>>>
>>>> Looking for approval for:
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8135307
>>>> 9 Changeset:
>>>> http://hg.openjdk.java.net/jdk9/dev/langtools/rev/8e76163b3f3a
>>>>
>>>>      -Rob
>>



More information about the jdk8u-dev mailing list