[PATCH] 8153925: WindowsWatchService hangs on GetOverlappedResult and locks directory

[Alan Bateman]

On 09/04/2016 23:23, Alex Kashchenko wrote:
> Hi,
>
> Please review a fix for the windows-specific WatchService problem:
>
>  - issue: https://bugs.openjdk.java.net/browse/JDK-8153925
>  - patch: http://cr.openjdk.java.net/~akasko/jdk8u/8153925/webrev.00/
>  - reproducer: 
> http://cr.openjdk.java.net/~akasko/jdk8u/8153925/reproducer.00/GetOverlappedResultHangsTest.java
>  - original JBoss Tools issue: 
> https://issues.jboss.org/browse/JBIDE-22078
>
> The patch adds an additional flag to WindowsWatchKey that is set to 
> true when ReadDirectoryChangesW call fails. If the flag is set then 
> GetOverlappedResult won't be called after CancelIo call during key 
> invalidation.
>
Would you mind bringing this to nio-dev for discussion with more details 
as to how the issue arises? Also, it's normal for changes like this to 
bake in the main line for a bit before back porting to 8u.

-Alan