[8u-dev] Request for approval to backport: 8044762 and 8049226

Omair Majid omajid at redhat.com
Wed Apr 20 20:55:13 UTC 2016


Hi,

I would like to backport the following two changesets that improve the
behaviour of the JVM when the jdwp port can not be opened. Before these
patches, the JVM would abort(3). After these, it exit(3)s. This makes
the behaviour much saner, avoiding unnecessary core dumps. It also makes
the exit behaviour better, handling jdwp errors similar to how the JVM
handles the cases when the main class can not be found: it exits instead
of abort'ing.

The bugs names are quite misleading, so please watch out.

Bug: https://bugs.openjdk.java.net/browse/JDK-8044762
(Not available publicly; I can't access it myself)
Webrev: http://cr.openjdk.java.net/~omajid/webrevs/8044762-jdk8u/00/
JDK 9 Changeset: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/5e7143c1abc1

The only difference from 9 is that com/sun/jdi/OptionTest.java is not
present in the ProblemList.txt file so it isn't removed. I can't find
the original review thread for this. The change itself seems very safe
to me, it just adds a null pointer guard to existing code.

Bug: https://bugs.openjdk.java.net/browse/JDK-8049226
Webrev: http://cr.openjdk.java.net/~omajid/webrevs/8049226-jdk8u/00/
Original review thread: http://mail.openjdk.java.net/pipermail/serviceability-dev/2014-August/015360.html
JDK 9 Changeset: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/8c8a7b6f49de

This change from 9 applies as-is, aside from the changed paths.

Thanks,
Omair

-- 
PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681


More information about the jdk8u-dev mailing list