[8u-dev] Request for review: 8160156: javac is generating let expressions unnecessarily

[Maurizio Cimadamore]

Ah ok - the right directory structure is only created if -d is specified 
(which is used by jtreg) - which is normal javac behavior (which I keep 
forgetting about :-)).

Maurizio


On 16/08/16 00:17, Maurizio Cimadamore wrote:
>
>
> On 15/08/16 17:31, Vicente-Arturo Romero-Zaldivar wrote:
>> On 08/15/2016 12:16 PM, Maurizio Cimadamore wrote:
>>> The tests seem to belong to the wrong folder? I.e. they should be in 
>>> a folder whose name matches the package name?
>>
>> You can do it for clarity but it's not strictly necessary. Javac will 
>> generate the right class file structure
> I tried to replicate that structure in a local folder and I got this:
>
> $ javac LetExpressionsAreUnnecessarilyGeneratedTest.java
> $ javac Sub.java
> Sub.java:3: error: package base does not exist
>    import base.LetExpressionsAreUnnecessarilyGeneratedTest;
>               ^
> Sub.java:5: error: cannot find symbol
>    public class Sub extends LetExpressionsAreUnnecessarilyGeneratedTest {
>                             ^
>   symbol: class LetExpressionsAreUnnecessarilyGeneratedTest
> Sub.java:10: error: not an enclosing class: Sub
>                    Sub.super.i += 10;
>                       ^
> 3 errors
>
> What am I missing?
>
> Maurizio
>>
>>>
>>> Maurizio
>>
>> Vicente
>>
>>>
>>>
>>> On 11/08/16 15:40, Vicente-Arturo Romero-Zaldivar wrote:
>>>> Please review the following backport to 8udev. The jtreg test is 
>>>> different from the jdk9 version.
>>>>
>>>> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8160156
>>>> backport: https://bugs.openjdk.java.net/browse/JDK-8163866
>>>> open webrev: http://cr.openjdk.java.net/~vromero/8160156/webrev.00/
>>>> jdk9 patch: 
>>>> http://hg.openjdk.java.net/jdk9/dev/langtools/rev/88cc9b782624
>>>>
>>>> Thanks,
>>>> Vicente
>>>
>>
>