PING: [8u112] Request for review & approval for CR8151841: Build needs additional flags to compile with GCC 6

[Seán Coffey]

Haven't forgotten about this one. Hope to get to it today.

Regards,
Sean.

On 05/08/2016 16:12, Andrew Hughes wrote:
>
> ----- Original Message -----
>> I'm seeing this patch fail across all platforms on internal builds.
>> Please hold off any push for now. Maybe other config changes are needed
>> on our build systems.
>>
>> e.g.
>>
>>> /opt/jprt/products/P1/SS12u1/SS12u1/prod/bin/CC
>>> \
>>>                       -m64 -G -KPIC     \
>>> 	           -I/opt/jprt/T/P1/094712.scoffey/s/hotspot/agent/src/os/solaris/proc
>>> 	           \
>>> 	           -I../generated                                       \
>>> 	           -I/opt/jprt/products/P1/jdk7u7-latest/jdk1.7.0_07/include
>>> 	           \
>>> 	           -I/opt/jprt/products/P1/jdk7u7-latest/jdk1.7.0_07/include/solaris
>>> 	           \
>>> 	                                     \
>>> 	           /opt/jprt/T/P1/094712.scoffey/s/hotspot/agent/src/os/solaris/proc/saproc.cpp
>>> 	           \
>>> 	           sadis.o                                          \
>>> 	           -M
>>> 	           /opt/jprt/T/P1/094712.scoffey/s/hotspot/agent/src/os/solaris/proc/mapfile
>>> 	           -mt -xnolib -norunpath
>>> 	           \
>>> 	           -o libsaproc.so
>>> 	           \
>>> 	           -ldl -ldemangle -lthread -lc
>>> ld: fatal: file @NO_DELETE_NULL_POINTER_CHECKS_CFLAG@: open failed: No such
>>> file or directory
>>> ld: fatal: file @NO_LIFETIME_DSE_CFLAG@: open failed: No such file or
>>> directory
>>> ld: fatal: file @CXXSTD_CXXFLAG@: open failed: No such file or directory
>>> ld: fatal: file processing errors. No output written to
>>> libgenerateJvmOffsets.so
>>> gmake[6]: *** [libgenerateJvmOffsets.so] Error 1
>>> gmake[6]: *** Waiting for unfinished jobs....
>>> gmake[6]: Leaving directory
>>> `/opt/jprt/T/P1/094712.scoffey/s/build/solaris-x86_64-normal-server-release/hotspot/solaris_amd64_compiler2/product'
>>> gmake[5]: *** [the_vm] Error 2
> It needs to be pushed by someone at Oracle anyway, so your internal
> configure can be updated.
>
> I think that might be the problem here. @CXXSTD_CXXFLAG@ and friends
> should be substituted by configure with either the flag or the empty
> string, so something is going wrong earlier with the configure stage.