CFV: New jdk8u Committer: Shafi Ahmad

[David Holmes]

Vote: veto

Not withstanding the fact that Shafi has been doing a lot of work in 
backporting and fixing issue in 8u - which is very much appreciated - I 
feel this nomination is a little premature. The updated list below 
reduces from 20 to 12, and I am struggling to see 8 "significant 
contributions". I would accept these, plus the active-processor backport:

- 8161144: Fix for JDK-8147451 failed: Crash in 
Method::checked_resolve_jmethod_id(_jmethodID*)

- 8162419: closed/com/oracle/jfr/runtime/TestVMInfoEvent.sh failing 
after JDK-8155968

- 8158373: SIGSEGV: Metadata::mark_on_stack [Very borderline]

- 8147451: Crash in Method::checked_resolve_jmethod_id(_jmethodID*)

But that only comes to 5.

These are all not "significant contributions" in my opinion:

- 8166872: GPL header in 
/hotspot/src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp

- 8157548: JVM crashes sometimes while starting

- 8156836: SIGSEGV: Test test/compiler/jsr292/VMAnonymousClasses.java 
fails with JTREG 4.2 b02

- 8147026: Convert an assert in ClassLoaderData to a guarantee

- 8150002: Check for the validity of oop before printing it in 
verify_remembered_set

- 8144957: Remove PICL warning message

- 8140249: JVM Crashing During startUp If Flight Recording is enabled

Sorry.

David



On 7/12/2016 12:08 AM, Poonam Bajaj Parhar wrote:
> Hello David,
>
> Here are the contributions that were made by Shafi:
>
> 8161144: Fix for JDK-8147451 failed: Crash in 
> Method::checked_resolve_jmethod_id(_jmethodID*) 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/d18eb5b5a3d6?revcount=1000>
>
> 8166872: GPL header in 
> /hotspot/src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/f7b4a17a9d49?revcount=1000>
>
> 8157548: JVM crashes sometimes while starting 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/4eba7ec59722?revcount=1000>
>
> 8162419: closed/com/oracle/jfr/runtime/TestVMInfoEvent.sh failing 
> after JDK-8155968 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/db2cffccdb85?revcount=1000>
>
> 8161144: Fix for JDK-8147451 failed: Crash in 
> Method::checked_resolve_jmethod_id(_jmethodID*) 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/1f6b58e0bd06?revcount=1000>
>
> 8156836: SIGSEGV: Test test/compiler/jsr292/VMAnonymousClasses.java 
> fails with JTREG 4.2 b02 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/649f01d13b2d?revcount=1000>
>
> 8158373: SIGSEGV: Metadata::mark_on_stack 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/001e0c530e2c?revcount=1000>
>
> 8147026: Convert an assert in ClassLoaderData to a guarantee 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/9f2a972df4da?revcount=1000>
>
> 8147451: Crash in Method::checked_resolve_jmethod_id(_jmethodID*) 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/fde446cb8e19?revcount=1000>
>
> 8150002: Check for the validity of oop before printing it in 
> verify_remembered_set 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/f21c5c4d5231?revcount=1000>
>
> 8144957: Remove PICL warning message 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/1246f293a0e8?revcount=1000>
>
> 8140249: JVM Crashing During startUp If Flight Recording is enabled 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/522ea1472a62?revcount=1000>
>
>
> and the following was a backport from 9 that required significant work 
> to backport the changes to 8u:
>
> 6515172: Runtime.availableProcessors() ignores Linux taskset command 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/3a38e441474d?revcount=1000> 
>
>
>
> Thanks,
> Poonam
>
>
> On 12/5/2016 4:46 PM, David Holmes wrote:
>> Hi Poonam,
>>
>> On 6/12/2016 7:55 AM, Poonam Bajaj Parhar wrote:
>>> I hereby nominate Shafi Ahmad (shshahma) to JDK 8u Committer.
>>>
>>> Shafi is currently a JDK 8u Author, and a member of the JVM Sustaining
>>> group at Oracle. He has made many non-trivial contributions to JDK 
>>> 8u [3].
>>
>> Some of these seem to be backports of other people's contributions. 
>> Can you isolate Shafi's specific contributions, or where the backport 
>> needed a non-trivial adjustment, please.
>>
>> Thanks,
>> David
>> ------
>>
>>> Votes are due by the end of Dec 19, 2016.
>>>
>>> Only current JDK 8u Committers [1] are eligible to vote on this 
>>> nomination.
>>> Votes must be cast in the open by replying to this mailing list.
>>>
>>> For Lazy Consensus voting instructions, see [2].
>>>
>>> regards,
>>> Poonam
>>>
>>> [1] http://openjdk.java.net/census
>>> [2] http://openjdk.java.net/projects/#committer-vote
>>> [3]http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/log?revcount=1000&rev=(keyword(%22shafi.s.ahmad@oracle.com%22)+or+author(shshahma))+and+not+desc(%22Merge%22) 
>>>
>>>
>