[8u-dev] Request for approval: 8169112: java.lang.VerifyError: (class: GregorSamsa, method: template-bash signature: (LGregorSamsa8; )V) Register 10 contains wrong type

[Langer, Christoph]

Thanks, the fix is pushed:

http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jaxp/rev/e73eb9ed69f6
http://hg.openjdk.java.net/jdk8u/jdk8u-dev/jdk/rev/71215ac21d10

@Joe: I don't know into which patch 8u*** this fix will go by default now. I leave it to you if you want to accelerate this into an earlier fix, as it is a regression...

Best regards
Christoph

> -----Original Message-----
> From: David Buck [mailto:david.buck at oracle.com]
> Sent: Freitag, 16. Dezember 2016 08:50
> To: Langer, Christoph <christoph.langer at sap.com>; jdk8u-
> dev at openjdk.java.net
> Subject: Re: [8u-dev] Request for approval: 8169112: java.lang.VerifyError:
> (class: GregorSamsa, method: template-bash signature: (LGregorSamsa8; )V)
> Register 10 contains wrong type
> 
> approved for push to jdk8u-dev
> 
> Cheers,
> -Buck
> 
> On 2016/12/16 16:35, Langer, Christoph wrote:
> > Hi,
> >
> > please approve this downport. Changes have been reviewed by Joe.
> >
> > Thanks
> > Christoph
> >
> > From: Joe Wang [mailto:huizhe.wang at oracle.com]
> > Sent: Donnerstag, 15. Dezember 2016 19:08
> > To: Langer, Christoph <christoph.langer at sap.com>
> > Cc: jdk8u-dev at openjdk.java.net; core-libs-dev at openjdk.java.net; Aleks
> Efimov <aleksej.efimov at oracle.com>; jeff Dinkins <Jeff.Dinkins at oracle.com>
> > Subject: Re: 8u-dev: RFR (JAXP): 8169112: java.lang.VerifyError: (class:
> GregorSamsa, method: template-bash signature: (LGregorSamsa8;)V) Register
> 10 contains wrong type
> >
> > Hi Christoph,
> >
> > The patches look good to me.
> >
> > Thanks,
> > Joe
> >
> > On 12/15/16, 6:11 AM, Langer, Christoph wrote:
> > Hi,
> >
> > please review(@Joe) & approve the downport of this regression fix. As it is a
> JAXP issue and includes a testcase, the change needs to be split into a jaxp part
> and a jdk part.
> >
> > The jaxp part applies cleanly after unshuffling, the JDK part had to be
> modified to fit into the jdk8 layout.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8169112
> > JAXP:
> http://cr.openjdk.java.net/~clanger/webrevs/8169112_jaxp.8udev/<http://cr.op
> enjdk.java.net/%7Eclanger/webrevs/8169112_jaxp.8udev/>
> > JDK:
> http://cr.openjdk.java.net/~clanger/webrevs/8169112_jdk.8udev/<http://cr.ope
> njdk.java.net/%7Eclanger/webrevs/8169112_jdk.8udev/>
> >
> > Thanks & best regards
> > Christoph
> >
> >
> > From: Joe Wang [mailto:huizhe.wang at oracle.com]
> > Sent: Mittwoch, 14. Dezember 2016 21:52
> > To: Langer, Christoph
> <christoph.langer at sap.com><mailto:christoph.langer at sap.com>
> > Cc: core-libs-dev at openjdk.java.net<mailto:core-libs-dev at openjdk.java.net>;
> Aleks Efimov
> <aleksej.efimov at oracle.com><mailto:aleksej.efimov at oracle.com>; jeff
> Dinkins <Jeff.Dinkins at oracle.com><mailto:Jeff.Dinkins at oracle.com>
> > Subject: Re: RFR (JAXP): 8169112: java.lang.VerifyError: (class: GregorSamsa,
> method: template-bash signature: (LGregorSamsa8;)V) Register 10 contains
> wrong type
> >
> >
> >
> > I guess I should also request a downport to jdk8 immediately, as it is a
> regression, right?
> >
> > Yes, that would be great. Please create a patch for JDK 8 or work with Aleksej
> (Aleksej backported your previous patch), and ask for approval through the
> jdk8-dev alias.
> >
> > Best,
> > Joe
> >
> >