[8u-dev] Request for approval: backport of JDK-8059661: Test SoftReference and OOM behavior

[Seán Coffey]

Ok - thanks for the webrev and clarifications. Looks good!

Approved for jdk8u-dev.

Regards,
Sean.

On 11/02/16 12:11, Alexander Vorobyev wrote:
> Here is webrev:
> http://cr.openjdk.java.net/~kshefov/8059661/webrev.00/
>
> About https://bugs.openjdk.java.net/browse/JDK-8044186 - I'll probably 
> backport it too, but later. Because this fix affects many tests 
> besides this one. Also, JDK-8044186 does not affect functionality  of 
> TestSoftReferencesBehaviorOnOOME so it really can wait some time.
>
> For your information, all the difference between my patch and original 
> patch from JDK-8059661 is:
>  29c29
> <  * @build TestSoftReference
> ---
> >  * @build TestSoftReferencesBehaviorOnOOME - it could not be 
> compiled without it, JDK-8065865
>
> 33a34
> > import java.util.*;
> 37d37
> < import java.util.Random;
> 41c41
> <     private static final Random rndGenerator = 
> Utils.getRandomInstance();
> ---
> >     private static final Random rndGenerator = new Random();
>
>
>
> On 10.02.2016 21:14, Seán Coffey wrote:
>> Alexander,
>>
>> On 10/02/16 16:48, Alexander Vorobyev wrote:
>>>
>>> Hi All,
>>>
>>> I'd like approval for a JDK 8 backport of JDK-8059661 
>>> (https://bugs.openjdk.java.net/browse/JDK-8059661)
>>>
>>> The changeset from JDK 9 applies cleanly.
>>> But it was slightly changed:
>> So it doesn't apply cleanly then. Can you post your webrev ?
>>
>> Also - are you committing fixes from below bug IDs also? Will you 
>> list them in the changeset and approval request ?
>>
>> regards,
>> Sean.
>>> it uses standard java.util.Random() instead of 
>>> Utils.getRandomInstance(), because JDK-8044186 
>>> (https://bugs.openjdk.java.net/browse/JDK-8044186) is not backported 
>>> to JDK 8 yet.
>>> Also, it contains one-line fix for JDK-8065865 
>>> (https://bugs.openjdk.java.net/browse/JDK-8065865). Fix for 
>>> JDK-8059661 could not be compiled without it.
>>>
>>> JDK 9 Changeset:
>>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/18f7ade7de0d
>>> JDK 9 review thread:
>>> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-October/010977.html 
>>>
>>>
>>> Thanks,
>>> Alexander
>>>
>>>
>>>
>>
>