[8u76] Request for approval for CR 8061624 -- [TESTBUG] Some tests cannot be ran under compact profiles and therefore shall be excluded

[David Holmes]

Thanks for clarifying. Looks ok.

David

On 14/01/2016 7:40 PM, Sergei Kovalev wrote:
> Hi David,
>
> Appreciate your feedback.
>
> Updated review link:
> http://cr.openjdk.java.net/~skovalev/8061624/webrev.01/
>
> See my comments in-lined.
>
> 14.01.16 06:55, David Holmes wrote:
>> Hi Sergei,
>>
>> On 14/01/2016 1:17 AM, Sergei Kovalev wrote:
>>> Hi,
>>>
>>> Could somebody approve this patch into jdk8u-dev?
>>>
>>> Issue record: https://bugs.openjdk.java.net/browse/JDK-8061624
>>> Patch review: http://cr.openjdk.java.net/~skovalev/8061624/webrev.00/
>>>
>>> The proposed solution is not applicable for JDK9 forest because it uses
>>> module mechanism.
>>>
>>> Solution: modify TEST.group file to exclude execution of tests on
>>> compact profiles. Tests list see below:
>>>
>>> Required Full JRE:
>>> javax/xml/ws/8043129/MailTest.java  -- because of MailcapCommandMap
>>> component
>>> sun/security/pkcs11/Provider/Login.sh -- because of
>>> com.sun.security.auth.callback.DialogCallbackHandler
>>> javax/xml/bind/jxc/8046817/GenerateEnumSchema.java -- because of
>>> javax.xml.bind.annotation.XmlType
>>
>> I don't see a entry for the above, but I see this:
>>
>> javax/xml/ws/8046817
>>
>> which doesn't seem to exist.
> That's really my error. I've removed wrong line.
>
> javax/xml/bind/jxc/8046817/GenerateEnumSchema.java covered by
> "javax/xml/bind/jxc" (line 352). There are several test cases under the
> folder and I'd like to combine them in single line because all of them
> have similar requirements.
>>
>>> Required full JDK:
>>> javax/xml/ws/8033113/WsImportTest.java -- because of wsimport binary
>>> tool
>>> javax/xml/ws/ebcdic/WsImportTest.java  -- because of wsimport binary
>>> tool
>>> sun/management/jmxremote/startstop/JMXStartStopTest.java  -- because of
>>> jcmd binary tool
>>> javax/xml/ws/8046817/GenerateEnumSchema.java -- because of schemagen
>>> binary tool
>>
>> You seem to have overlooked adding back javax/xml/crypto to compact2
> The item already listed in the section "needs_compact3" (see line 489).
>>
>> David
>> -----
>>
>