[8u-dev] RFR: 8154558: Incorrect GPL header in ProcessEnvironment_md.c reported

Seán Coffey sean.coffey at oracle.com
Wed Jul 6 09:55:05 UTC 2016


Looks fine to me also Aleksej.

Regards,
Sean.

On 06/07/16 10:45, Aleks Efimov wrote:
> Ivan,
>
> Thanks for reviewing this particular change. For the records: we're 
> planning to handle the modification years typos/errors as part of 
> JDK-8159475 (same for JDK9). 8154558 will address changes only in 
> ProcessEnvironment_md.c.
>
> With Best Regards,
> Aleksej
>
> On 05/07/16 02:21, Ivan Gerasimov wrote:
>> And two more, missing a space between the years:
>>
>> share/classes/com/sun/jmx/remote/protocol/iiop/IIOPProxyImpl.java: * 
>> Copyright (c) 2009,2013, Oracle and/or its affiliates. All rights 
>> reserved.
>> solaris/classes/java/net/DefaultDatagramSocketImplFactory.java: * 
>> Copyright (c) 2007,2011, Oracle and/or its affiliates. All rights 
>> reserved.
>>
>> With kind regards,
>> Ivan
>>
>>
>> On 05.07.2016 2:13, Ivan Gerasimov wrote:
>>> Hi Aleksej!
>>>
>>> Looks good.  A couple more such glitches found with grep:
>>>
>>> share/classes/org/jcp/xml/dsig/internal/dom/XMLDSigRI.java: * 
>>> Copyright (c) 2005, 2013 Oracle and/or its affiliates. All rights 
>>> reserved.
>>> share/classes/com/sun/java/accessibility/util/package-info.java: * 
>>> Copyright (c) 2013, 2015 Oracle and/or its affiliates. All rights 
>>> reserved.
>>>
>>> I'm not a jdk8u-dev Reviewer, so you'll need someone more powerful 
>>> to approve this.
>>>
>>> With kind regards,
>>> Ivan
>>>
>>>
>>> On 05.07.2016 1:44, Aleks Efimov wrote:
>>>> Hello,
>>>>
>>>> jdk/src/windows/native/java/lang/ProcessEnvironment_md.c file 
>>>> contains incorrect GPL header: comma after modification years is 
>>>> missing.
>>>>
>>>> Please, help to review its addition:
>>>>     http://cr.openjdk.java.net/~aefimov/8154558
>>>>
>>>>
>>>> With Best Regards,
>>>> Aleksej
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8154558
>>>>
>>>
>>>
>>
>



More information about the jdk8u-dev mailing list