[8u-dev] Request for approval: Backport of security test enhancements

Svetlana Nikandrova svetlana.nikandrova at oracle.com
Thu Mar 3 17:40:29 UTC 2016


Xuelei, Sean,

one of my teammates pointed out that it may be unclear that this patch 
contains only part of
"8061210: Issues in TLS" (to be exact only test's fix) and suggested to 
create a separate test-bug:

https://bugs.openjdk.java.net/browse/JDK-8151197

While this is unchanged test fix from jdk 9 and you already approved/reviewed it as a part of the whole patch may I consider this test fix also approved/reviewed?
  
Here is the code change I'm talking about:

diff -r d384337ea835 test/javax/net/ssl/TLS/TestJSSE.java
--- a/test/javax/net/ssl/TLS/TestJSSE.java      Mon Jun 29 15:04:43 2015 +0800
+++ b/test/javax/net/ssl/TLS/TestJSSE.java      Thu Mar 03 20:00:05 2016 +0300
@@ -1,5 +1,5 @@
  /**
- * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2010, 2016, Oracle and/or its affiliates. All rights reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it under
@@ -78,6 +78,10 @@
      private static final String LOCAL_IP = "127.0.0.1";

      public static void main(String... args) throws Exception {
+        // reset the security property to make sure that the algorithms
+        // and keys used in this test are not disabled.
+        Security.setProperty("jdk.tls.disabledAlgorithms", "");
+
          String serverProtocol = System.getProperty("SERVER_PROTOCOL");
          String clientProtocol = System.getProperty("CLIENT_PROTOCOL");
          int port = jdk.testlibrary.Utils.getFreePort();


Thank you,
Svetlana

On 03.03.2016 15:55, Xuelei Fan wrote:
> Looks fine to me.  Please pass JPRT before pushing.
>
> On 3/3/2016 8:41 PM, Svetlana Nikandrova wrote:
>> Little reminder.
>>
> Thanks!
>
> Xuelei
>
>> On 29.02.2016 18:05, Svetlana Nikandrova wrote:
>>> Sean,
>>> thank you!
>>>
>>> Xue-Lei,
>>> if you don't mind could you please take a look? Original tests were
>>> already reviewed by you, I've just added latter tests' fixes.
>>> Webrev:
>>> http://cr.openjdk.java.net/~kshefov/8048607/webrev.00/
>>> <http://cr.openjdk.java.net/%7Ekshefov/8048607/webrev.00/>
>>>
>>> Thank you,
>>> Svetlana
>>>
>>> On 25.02.2016 15:49, Seán Coffey wrote:
>>>> Approved for jdk8u-dev but subject to peer code review before pushing.
>>>>
>>>> Regards,
>>>> Sean.
>>>>
>>>> On 25/02/2016 12:36, Svetlana Nikandrova wrote:
>>>>> Hello,
>>>>>
>>>>> please review and approve tests' backport from jdk9. Tests were
>>>>> combined with there fixes.
>>>>> Originally reviewed Xue-Lei Fan.
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~kshefov/8048607/webrev.00/
>>>>> <http://cr.openjdk.java.net/%7Ekshefov/8048607/webrev.00/>
>>>>>
>>>>> Please find detailed info below:
>>>>>
>>>>> "8041781: Need new regression tests for PBE keys"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8041781
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2014-June/010705.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/28da5b382a13
>>>>>
>>>>> "8049432: New tests for TLS property jdk.tls.client.protocols"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8049432
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2014-December/011483.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/306c2e872d8f
>>>>> + fix for that test:
>>>>> "8069038: javax/net/ssl/TLS/TLSClientPropertyTest.java needs to be
>>>>> updated for JDK-8061210"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8069038
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2015-January/011645.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/e57fae04212b
>>>>>
>>>>> "8050460: JAAS login/logout tests with LoginContext"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8050460
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2015-August/012674.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3eccb33e612a
>>>>>
>>>>> "8049237: Need new tests for X509V3 certificates"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8049237
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2015-August/012732.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/7a555c3509d2
>>>>>
>>>>> "8049429: Tests for java client server communications with various
>>>>> TLS/SSL combinations."
>>>>> https://bugs.openjdk.java.net/browse/JDK-8049429
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2014-September/011140.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/b1ad730c120a
>>>>> + test fix "8061464: A typo in CipherTestUtils test"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8061464
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2014-October/011352.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c17ad02a6268
>>>>> + test fix "8069253: javax/net/ssl/TLS/TestJSSE.java failed on Mac"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8069253
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2015-June/012455.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/93ced310c728
>>>>> + fix for that test from "8061210: Issues in TLS"
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/6c16bc68f187
>>>>>
>>>>> "8048607: Test key generation of DES and DESEDE"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8048607
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2015-January/011569.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/b868adbb539e
>>>>>
>>>>> "8048599: Tests for key wrap and unwrap operations"
>>>>> https://bugs.openjdk.java.net/browse/JDK-8048599
>>>>> Review thread:
>>>>> http://mail.openjdk.java.net/pipermail/security-dev/2015-April/011965.html
>>>>>
>>>>> JDK 9 changeset:
>>>>> http://hg.openjdk.java.net/jdk9/dev/jdk/rev/c5c8b1850425
>>>>>
>>>>> Thank you,
>>>>> Svetlana



More information about the jdk8u-dev mailing list