[8u-dev] Request for approval for CR JDK-8129419 - heapDumper.cpp: assert(length_in_bytes > 0) failed: nothing to copy

[Andreas Eriksson]

Thanks Dan.

- Andreas

On 2016-03-03 19:44, Daniel D. Daugherty wrote:
> > Webrevs: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/
> > hotspot
>
> src/os/solaris/vm/os_solaris.cpp
>     No comments.
>
> src/share/vm/services/heapDumper.cpp
>     No comments.
>
>
> > jdk
>
> src/share/classes/com/sun/tools/hat/internal/parser/HprofReader.java
>     No comments.
>
>
> Also compared the JDK9 version of the hotspot fix with the JDK8u version
> of the hotspot fix and I concur with the need for the differences. The
> HprofReader.java are identical (compared the versions from the two
> different repos).
>
> Thumbs up!
>
> Dan
>
>
> On 2/19/16 7:59 AM, Andreas Eriksson wrote:
>> OK, thanks.
>>
>> - Andreas
>>
>> On 2016-02-19 15:41, Seán Coffey wrote:
>>> Andreas,
>>>
>>> Given that the code has changed for the backport, I'd suggest you 
>>> seek a JDK 8u Reviewer to check this in addition to Dmitry. I'll 
>>> check if the process can be enhanced for such scenarios.
>>>
>>> Approved for jdk8u-dev but pending review.
>>>
>>> Regards,
>>> Sean.
>>>
>>> On 18/02/16 16:41, Andreas Eriksson wrote:
>>>> Hi,
>>>>
>>>> I'd like approval for a JDK 8 backport of 8129419: heapDumper.cpp: 
>>>> assert(length_in_bytes > 0) failed: nothing to copy
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8129419
>>>> Webrevs: http://cr.openjdk.java.net/~aeriksso/8129419/webrev.jdk8.00/
>>>> Review thread: 
>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-February/018862.html
>>>> Reviewed-by: Dmitry Samersoff (dsamersoff)
>>>>
>>>> If I've understood it correctly, a review by Dmitry is enough since 
>>>> he reviewed the JDK 9 version, even though he is not an 8u reviewer?
>>>>
>>>> Regards,
>>>> Andreas
>>>
>>
>>
>