[8u-dev] Request for approval: 4858370: JDWP: Memory Leak: GlobalRefs never deleted when processing invokeMethod command

[Severin Gehwolf]

On Tue, 2016-03-29 at 14:04 +0100, Rob McKenna wrote:
> Approved.
> 
>     -Rob

Thanks, Rob!

Cheers,
Severin

> On 29/03/16 02:37, Severin Gehwolf wrote:
> > 
> > Hi,
> > 
> > Please approve the backport of JDK-4858370 to JDK 8. The patch for
> > invoker.c is the same as for 9 (after path unshuffeling). Only the
> > test
> > has some slight modifications in order to set the JVM options for
> > the
> > debuggee since the test lib does not support the same things as in
> > JDK
> > 9. I'd need somebody to sponsor this change.
> > 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-4858370
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-4858370/we
> > brev.jdk8.01/
> > hg-export: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-4858370
> > /JDK-4858370-jdk8-jdk.export.patch
> > 
> > Original JDK 9 webrev that got pushed:
> > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-4858370/webrev.02/
> > 
> > JDK 9 review thread:
> > http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-Marc
> > h/019155.html
> > 
> > Please let me know if there are questions!
> > 
> > Thanks,
> > Severin