[8u-dev] Request for approval for JDK-8151731: Add new jtreg keyword to jdk 8

[Seán Coffey]

Hi Svetlana,

comments inline..

On 30/03/2016 15:49, Svetlana Nikandrova wrote:
> Sean,
>
> yes, it makes sense as this standalone change for us. We have a list 
> of tests from jdk 9 in progress of being backported to jdk 8. I 
> believe it will reduce cost of backporting and future maintenance to 
> keep code as close to jdk 9 as possible.
> Therefor this keywords will allow us to keep tests with only this 
> keyword difference as direct backports.
> As for 8078334 - we plan to do marking of remaining test after we 
> finish with tests' backports.
OK - I've no problem with the new keyword being introduced. I just 
thought it would made sense to introduce it at the same time as when the 
8078334 changeset[1] is backported. If you want to backport it 
separately, consider your 8151731 request approved for jdk8u-dev.
>
> About a OpenJDK wiki I also couldn't find info except of mail threads 
> and JBS bugs.  Could you please refer me to someone who can help with 
> doc's update?
I think we should document these keywords once and for all. I've asked 
Joe Darcy in the past but I think he seems happy to capture such info in 
emails only [2] [3] - something I don't agree with. Please contact Jon 
Gibbons about a suggestion to update the jtreg docs[4] with these 
keywords and their usage.

regards,
Sean.

[1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/110f7f35760f
[2] http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-March/001991.html
[3] http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-April/002164.html
[4] http://openjdk.java.net/jtreg/tag-spec.html

>
> Thank you,
> Svetlana
>
> On 14.03.2016 17:57, Seán Coffey wrote:
>> Svetlana, does it make sense to introduce such keywords without 
>> modifying the tests that need them ? i.e. should 8078334 be backported ?
>>
>> It would be nice to get such keywords documented in a OpenJDK wiki 
>> somewhere. (if one exists, please add to master record) I see a 
>> reference to some mail threads in the master record but that's not a 
>> substitute for docs IMO.
>>
>> Regards,
>> Sean.
>>
>> On 14/03/16 14:36, Svetlana Nikandrova wrote:
>>> Hello,
>>>
>>> please approve 2 additional jtreg keywords used in jdk 9: 
>>> "intermittent" and "randomness".
>>> This test's marking can be useful by itself and will simplify tests' 
>>> and test's fixes backporting.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8151731
>>>
>>> webrev:
>>> http://cr.openjdk.java.net/~msolovie/8151731/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Emsolovie/8151731/webrev.00/>
>>>
>>> Thank you,
>>> Svetlana
>>>
>>
>