[PATCH]: fix get_source.sh script for non-English locale

Seán Coffey sean.coffey at oracle.com
Tue May 10 14:11:42 UTC 2016


Hi Guido,

thanks for highlighting this. The issue appears to be fixed in JDK 9 via 
http://hg.openjdk.java.net/jdk9/jdk9/rev/d9edec389373

I'll backport this changeset to jdk8u-dev.

Regards,
Sean.

On 10/05/2016 14:16, Guido Trentalancia wrote:
> Always check the hg version using the default C locale for messages,
> otherwise the output string does not match.
>
> The hg version check had been introduced with the following:
> changeset:   1057:406ecd8cce66
> user:        mduigou
> date:        Tue Jun 24 15:21:47 2014 -0700
> summary:     8047925: Add mercurial version checks to get_source.sh
>
> Signed-off-by: Guido Trentalancia <guido at trentalancia.net>
> ---
>   get_source.sh |    1 +
>   1 file changed, 1 insertion(+)
>
> --- jdk8u60-orig/get_source.sh	2016-05-10 14:40:37.791909160 +0200
> +++ jdk8u60/get_source.sh	2016-05-10 14:54:17.716317364 +0200
> @@ -67,7 +67,7 @@ if [ "x$hgwhere" = "x" ]; then
>     error "Could not locate Mercurial command"
>   fi
>   
> -hgversion="`hg --version 2> /dev/null | sed -n -e 's@^Mercurial Distributed SCM (version \([^+]*\).*)\$@\1 at p'`"
> +hgversion="`LC_MESSAGES=C hg --version 2> /dev/null | sed -n -e 's@^Mercurial Distributed SCM (version \([^+]*\).*)\$@\1 at p'`"
>   if [ "x${hgversion}" = "x" ] ; then
>     error "Could not determine Mercurial version of $hgwhere"
>   fi



More information about the jdk8u-dev mailing list